[HACKERS] pg_upgrade code questions

2010-05-13 Thread Takahiro Itagaki
I read pg_upgrade code glance over, and found 4 issues in it. Are there any issues to be fixed before 9.0 release? 1. NAMEDATASIZE 2. extern PGDLLIMPORT 3. pathSeparator 4. EDB_NATIVE_LANG 1. NAMEDATASIZE pg_upgrade has the following definition, but should it be just

Re: [HACKERS] Re: [ANNOUNCE] Bug-fix and new feature of pg_lesslog is released

2010-05-13 Thread Koichi Suzuki
Thanks a lot for the comment/advice. Yes, full page backup block considerablly shortens the recovery time. As we discussed about two years ago, I have a solution accelerate the recovery even without full page image. I'd like to submit this solution to the community again. When I evaluated

Re: [HACKERS] Re: [ANNOUNCE] Bug-fix and new feature of pg_lesslog is released

2010-05-13 Thread Koichi Suzuki
WAL streming filter is an interesting idea. We can leave full page backup for local recovery and decrease the amount of WAL to transfer. If SR writes WAL in record by record basis, implementation will be simple. If SR writes WAL in block by block basis, WAL records may be divided from

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Devrim GÜNDÜZ
On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: 4. EDB_NATIVE_LANG Of course it is commented out with #ifdef, but do we have codes for EDB in core? I was about to raise similar thing, for the documentation: http://developer.postgresql.org/pgdocs/postgres/pgupgrade.html

Re: [HACKERS] How to know killed by pg_terminate_backend

2010-05-13 Thread Heikki Linnakangas
Tatsuo Ishii wrote: If a backend killed by pg_terminate_backend(), the backend returns 57P01 which is identical to the one when it's killed by postmaster. Problem is, pgpool-II needs to trigger failover if postmaster goes down because apparently pgpool-II cannot use the PostgreSQL server

Re: [HACKERS] Tags missing from GIT mirror?

2010-05-13 Thread Peter Eisentraut
On ons, 2010-05-12 at 16:11 -0400, Andrew Dunstan wrote: Of course, we might also find some other brokenness if we try to import all the tags. Also, be aware of this (from http://cvs2svn.tigris.org/cvs2git.html): Differences between CVS and git branch/tag models: CVS allows a

Re: [HACKERS] Tags missing from GIT mirror?

2010-05-13 Thread Andrew Dunstan
Peter Eisentraut wrote: On ons, 2010-05-12 at 16:11 -0400, Andrew Dunstan wrote: Of course, we might also find some other brokenness if we try to import all the tags. Also, be aware of this (from http://cvs2svn.tigris.org/cvs2git.html): Differences between CVS and git branch/tag

Re: [HACKERS] Retiring from the PostgreSQL core team

2010-05-13 Thread Andrew Dunstan
Jan Wieck wrote: To whom it may concern, this is to inform the PostgreSQL community of my retirement from my PostgreSQL core team position. Over the past years I have not been able to dedicate as much time to PostgreSQL as everyone would have liked. The main reason for that was that I was

Re: [HACKERS] Retiring from the PostgreSQL core team

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 00:24 -0400, Jan Wieck wrote: Over the past years I have not been able to dedicate as much time to PostgreSQL as everyone would have liked. The main reason for that was that I was swamped with other work and private matters and simply didn't have time. I did follow the

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 10:49 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 3:50 AM, Robert Haas robertmh...@gmail.com wrote: rhaas=# rollback; ROLLBACK So at this point, one would think that there are no locks hanging around anywhere. Back to the standby: rhaas=# select * from

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Fujii Masao
On Thu, May 13, 2010 at 6:47 PM, Simon Riggs si...@2ndquadrant.com wrote: Rollbacks are always flushed to disk, so this explanation doesn't work. Even if it were it would take no longer than ~1 sec if everything were working correctly on the test system. Yeah, rollbacks are always flushed

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 8:22 AM, Devrim GÜNDÜZ dev...@gunduz.org wrote: On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: 4. EDB_NATIVE_LANG Of course it is commented out with #ifdef, but do we have codes for EDB in core? I was about to raise similar thing, for the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 1:47 AM, Bruce Momjian br...@momjian.us wrote: bruce wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: All other binaries had such a designation, and all /contrib binaries were missing them.  I assume I was doing cleanup.  You want the icon removed

Re: [HACKERS] List traffic

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 2:04 AM, Marc G. Fournier scra...@hub.org wrote: On Wed, 12 May 2010, Greg Stark wrote: I'm thinking I'll move -general (and the useless -novice) to another folder. But I'm left wondering what to do with -admin and -performance. They're a random mix of user content

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 19:08 +0900, Fujii Masao wrote: I was able to reproduce such a hang by not executing another transaction after rollback. In this case, walsender cannot replicate the rollback since it's not in the disk. WALWriter is not active? -- Simon Riggs

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Fujii Masao
On Thu, May 13, 2010 at 7:22 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:08 +0900, Fujii Masao wrote: I was able to reproduce such a hang by not executing another transaction after rollback. In this case, walsender cannot replicate the rollback since it's not in the

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 19:32 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 7:22 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:08 +0900, Fujii Masao wrote: I was able to reproduce such a hang by not executing another transaction after rollback. In this case,

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Fujii Masao
On Thu, May 13, 2010 at 8:05 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:32 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 7:22 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:08 +0900, Fujii Masao wrote: I was able to reproduce such a

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 20:13 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 8:05 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:32 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 7:22 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:08 +0900,

Re: [HACKERS] weird hang while running in HS mode

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 20:13 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 8:05 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:32 +0900, Fujii Masao wrote: On Thu, May 13, 2010 at 7:22 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-05-13 at 19:08 +0900,

Re: [HACKERS] Tags missing from GIT mirror?

2010-05-13 Thread Peter Eisentraut
On tor, 2010-05-13 at 04:41 -0400, Andrew Dunstan wrote: Right, and omitting tags was in fact one of the features of fromcvs that made us use it, because any tool that tries to convert tags will explode on our CVS tree, for reasons explained in the above paragraph. We have also discussed

Re: [HACKERS] Tags missing from GIT mirror?

2010-05-13 Thread Andrew Dunstan
Peter Eisentraut wrote: On tor, 2010-05-13 at 04:41 -0400, Andrew Dunstan wrote: Right, and omitting tags was in fact one of the features of fromcvs that made us use it, because any tool that tries to convert tags will explode on our CVS tree, for reasons explained in the above paragraph.

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Magnus Hagander wrote: On Thu, May 13, 2010 at 2:04 AM, Marc G. Fournier scra...@hub.org wrote: On Wed, 12 May 2010, Greg Stark wrote: I'm thinking I'll move -general (and the useless -novice) to another folder. But I'm left wondering what to do with -admin and

Re: [HACKERS] List traffic

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 3:27 PM, Marc G. Fournier scra...@hub.org wrote: On Thu, 13 May 2010, Magnus Hagander wrote: On Thu, May 13, 2010 at 2:04 AM, Marc G. Fournier scra...@hub.org wrote: On Wed, 12 May 2010, Greg Stark wrote: I'm thinking I'll move -general (and the useless -novice) to

Re: [HACKERS] make install fails due to /bin/mkdir: missing operand

2010-05-13 Thread Peter Eisentraut
On mån, 2010-05-10 at 20:07 +0900, Kenichiro Tanaka wrote: Reproduce case: #prefix and with-pgport are not important ./configure --enable-nls='UFT_JP' --prefix=/home/p900/posgrehome --with-pgport=1900 make make install make install

Re: [HACKERS] make install fails due to /bin/mkdir: missing operand

2010-05-13 Thread Peter Eisentraut
On mån, 2010-05-10 at 11:40 -0400, Alvaro Herrera wrote: Excerpts from Kenichiro Tanaka's message of lun may 10 07:07:27 -0400 2010: Reproduce case: #prefix and with-pgport are not important ./configure --enable-nls='UFT_JP' --prefix=/home/p900/posgrehome --with-pgport=1900 make make

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Magnus Hagander wrote: On Thu, May 13, 2010 at 8:22 AM, Devrim G?ND?Z dev...@gunduz.org wrote: On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: 4. EDB_NATIVE_LANG Of course it is commented out with #ifdef, but do we have codes for EDB in core? I was about to raise

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: Magnus Hagander wrote: On Thu, May 13, 2010 at 8:22 AM, Devrim G?ND?Z dev...@gunduz.org wrote: On Thu, 2010-05-13 at 15:13 +0900, Takahiro Itagaki wrote: 4. EDB_NATIVE_LANG Of course it is commented out with

[HACKERS] wal_mode in postgresql.conf

2010-05-13 Thread Bruce Momjian
Why is 'wal_level' listed next to 'fsync' in postgresql.conf? #wal_level = 'hot_standby' # minimal, archive, or hot_standby #fsync = on # turns forced synchronization on or off #synchronous_commit = on# immediate

Re: [HACKERS] wal_level in postgresql.conf

2010-05-13 Thread Bruce Momjian
Bruce Momjian wrote: Why is 'wal_level' listed next to 'fsync' in postgresql.conf? #wal_level = 'hot_standby' # minimal, archive, or hot_standby #fsync = on # turns forced synchronization on or off #synchronous_commit = on

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: I have added SGML comments to comment out the text that mentions EDB Advanced Server.  Is that enough?  Should I remove the text from the SGML?  Should I move it to the bottom of

Re: [HACKERS] List traffic

2010-05-13 Thread damien clochard
Le 11/05/2010 19:24, Alvaro Herrera a écrit : Excerpts from Marc G. Fournier's message of mar may 11 09:58:34 -0400 2010: If list traffic, especially on -hackers, is getting so large, should we look at maybe splitting it? I could easily enough split things such that I duplicate the

Re: [HACKERS] multibyte charater set in levenshtein function

2010-05-13 Thread Alexander Korotkov
On Thu, May 13, 2010 at 6:03 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Well, since it's only used in one place, why are you defining a macro at all? In order to structure code better. My question was about another. Is memcmp function good choice to compare very short sequences of

[HACKERS] wal_level and continuous archiving documentation

2010-05-13 Thread Joshua Tolley
I was reading through http://www.postgresql.org/docs/9.0/static/continuous-archiving.html and noticed that wal_level isn't mentioned where I'd expect it to be. Specifically, there's a paragraph that starts, To enable WAL archiving, set the archive_mode configuration parameter to on, and specify

Re: [HACKERS] Retiring from the PostgreSQL core team

2010-05-13 Thread David Fetter
On Thu, May 13, 2010 at 12:24:47AM -0400, Jan Wieck wrote: To whom it may concern, this is to inform the PostgreSQL community of my retirement from my PostgreSQL core team position. Over the past years I have not been able to dedicate as much time to PostgreSQL as everyone would have

Re: [HACKERS] List traffic

2010-05-13 Thread Greg Stark
On Wed, May 12, 2010 at 5:24 PM, Robert Haas robertmh...@gmail.com wrote: The difference between discussing a patch and discussing an idea that might lead to a patch is fairly fine. And importantly -- who would be able to subscribe to one and not the other? If you have to subscribe to both to

Re: [HACKERS] multibyte charater set in levenshtein function

2010-05-13 Thread Alexander Korotkov
On Wed, May 12, 2010 at 11:04 PM, Alvaro Herrera alvhe...@alvh.no-ip.orgwrote: On a quick look, I didn't like the way you separated the pg_database_encoding_max_length() 1 cases. There seem to be too much common code. Can that be refactored a bit better? I did a little refactoring in order

Re: [HACKERS] Query execution plan from 8.3 - 8.4

2010-05-13 Thread Brendan Hill
Thanks for the advice, will do. Regards, Brendan Hill Chief Information Officer Jims Group Pty Ltd 48 Edinburgh Rd Mooroolbark VIC 3138 www.jims.net For all Jims IT enquiries: infot...@jims.net For emergencies: 1300 130 490 (intl +61 4 3456 5776) -Original Message- From: Kevin Grittner

[HACKERS] quoting and recovery.conf

2010-05-13 Thread Bruce Momjian
Is there a reason we require single quotes around boolean values in recovery.conf? standby_mode = 'off' This does not work: standby_mode = off I knew there were inconsistencies between quoting in postgresql.conf and recovery.conf, but I didn't realize it extended to boolean

Re: [HACKERS] max_standby_delay considered harmful

2010-05-13 Thread Josh Berkus
On 5/12/10 8:07 PM, Robert Haas wrote: I think that would be a good thing to check (it'll confirm whether this is the same bug), but I'm not convinced we should actually fix it that way. Prior to 8.4, we handled a smart shutdown during recovery at the conclusion of recovery, just prior to

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: On Thu, May 13, 2010 at 5:06 PM, Bruce Momjian br...@momjian.us wrote: I have added SGML comments to comment out the text that mentions EDB Advanced Server. ?Is that enough? ?Should I remove the text from the SGML? ?Should I move

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Joshua D. Drake
On Thu, 2010-05-13 at 17:19 +0200, Magnus Hagander wrote: I say remove it. On all accounts. There's a fork of postgres for EDB AS, shouldn't there be a fork of pg_upgrade the same way, if it requires special code? The code in community postgresql certainly shouldn't have any EDB AS code in

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Andrew Dunstan
Bruce Momjian wrote: Indeed. Given the (presumably large) delta between EDB's code and ours, having to have some delta in pg_upgrade isn't going to make much difference for them. I think the community code and docs should completely omit any mention of that. I am trying to think of

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
My thought had been a split along the lines of major components of the server ... for instance, a totally seperate list for HS related issues, so that, if nothing else, those 'lurkers' that are only interested in developments on that front could be there but not on the main stream -hackers

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Josh Berkus
On 5/13/10 10:14 AM, Bruce Momjian wrote: I am trying to think of this as a non-EnterpriseDB employee. If suppose Greenplum had given us a utility and they wanted it to work with their version of the database, what accommodation would we make for them? I agree on the documentation, but would

Re: [HACKERS] List traffic

2010-05-13 Thread Yeb Havinga
Greg Stark wrote: On Wed, May 12, 2010 at 5:24 PM, Robert Haas robertmh...@gmail.com wrote: The difference between discussing a patch and discussing an idea that might lead to a patch is fairly fine. And importantly -- who would be able to subscribe to one and not the other? If you

Re: [HACKERS] List traffic

2010-05-13 Thread Magnus Hagander
On Thu, May 13, 2010 at 8:05 PM, Marc G. Fournier scra...@hub.org wrote: My thought had been a split along the lines of major components of the server ... for instance, a totally seperate list for HS related issues, so that, if nothing else, those 'lurkers' that are only interested in

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Magnus Hagander wrote: On Thu, May 13, 2010 at 8:05 PM, Marc G. Fournier scra...@hub.org wrote: My thought had been a split along the lines of major components of the server ... for instance, a totally seperate list for HS related issues, so that, if nothing else, those

Re: [HACKERS] List traffic

2010-05-13 Thread Alvaro Herrera
Excerpts from Yeb Havinga's message of jue may 13 15:06:53 -0400 2010: Now I made a new gmail account, subscribed to all lists with some volume and let it all message per message come into the inbox. Together with thunderbird/imap this works quite nicely. With filters it's possible to tag

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Alvaro Herrera wrote: Excerpts from Yeb Havinga's message of jue may 13 15:06:53 -0400 2010: My $0.02 - I like the whole 'don't sort, search' (or how did they call it?) just let the inbox fill up, google is fast enough. What would be really interesting is to have some

Re: [HACKERS] List traffic

2010-05-13 Thread Tom Lane
Marc G. Fournier scra...@hub.org writes: On Thu, 13 May 2010, Magnus Hagander wrote: We tried that with pgsql-hackers-win32 and iirc also pgsql-hackers-pitr, and it was a big failure... But, we are doing that now with pgsql-cluster-hackers and it looks to be working quite well from what I

[HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Florian Pflug
Hi After the recent discussion about the impossibility of efficiently implementing FK-like constraint triggers in PL/PGSQL that work correctly under SERIALIZABLe transactions, I've compared our behavior to that of Oracle. As it turns out, a slight difference in Oracle's behavior makes those FK

Re: [HACKERS] List traffic

2010-05-13 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@alvh.no-ip.org writes: Excerpts from Yeb Havinga's message of jue may 13 15:06:53 -0400 2010: Now I made a new gmail account Yeah, this approach is interesting. A few days ago I started using Sup ( http://sup.rubyforge.org/ ) to manage my email Feature wise, I think

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Tom Lane
Florian Pflug f...@phlo.org writes: All in all, I believe that SHARE and UPDATE row-level locks should be changed to cause concurrent UPDATEs to fail with a serialization error. I don't see an argument for doing that for FOR SHARE locks, and it already happens for FOR UPDATE (at least if the

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Kevin Grittner
Florian Pflug f...@phlo.org wrote: All in all, I believe that SHARE and UPDATE row-level locks should be changed to cause concurrent UPDATEs to fail with a serialization error. I can come up with a patch that does that, but I wanted to get some feedback on the idea before I put the work in.

[HACKERS] HS/SR Assert server crash

2010-05-13 Thread Bruce Momjian
I was able to easily crash the standby server today just by starting it and connecting to it via psql. The master was idle. The failure was: LOG: streaming replication successfully connected to primary TRAP: FailedAssertion(!(((xmax) = ((TransactionId) 3))), File: procarray.c,

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Tom Lane wrote: Marc G. Fournier scra...@hub.org writes: On Thu, 13 May 2010, Magnus Hagander wrote: We tried that with pgsql-hackers-win32 and iirc also pgsql-hackers-pitr, and it was a big failure... But, we are doing that now with pgsql-cluster-hackers and it looks

[HACKERS] nvarchar notation accepted?

2010-05-13 Thread Jaime Casanova
Hi, i migrate a ms sql server database to postgres and was trying some queries from the application to find if everything works right... when i was looking to those queries i found some that has a notation for nvarchar (ej: campo = N'sometext') i was expecting those to fail but this actually

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Robert Haas
On Thu, May 13, 2010 at 1:00 PM, Bruce Momjian br...@momjian.us wrote: Is there a reason we require single quotes around boolean values in recovery.conf?        standby_mode = 'off' This does not work:        standby_mode = off I knew there were inconsistencies between quoting in

Re: [HACKERS] List traffic

2010-05-13 Thread Joshua D. Drake
On Thu, 2010-05-13 at 19:13 -0300, Marc G. Fournier wrote: On Thu, 13 May 2010, Tom Lane wrote: Marc G. Fournier scra...@hub.org writes: On Thu, 13 May 2010, Magnus Hagander wrote: We tried that with pgsql-hackers-win32 and iirc also pgsql-hackers-pitr, and it was a big failure...

Re: [HACKERS] List traffic

2010-05-13 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On Thu, 2010-05-13 at 19:13 -0300, Marc G. Fournier wrote: But that, IMHO, is the point of the smaller list ... it allows the group on that list to hash out their ideas, and, hopefully, deal with both arguments and counter arguments so that when

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Josh Berkus wrote: On 5/13/10 10:14 AM, Bruce Momjian wrote: I am trying to think of this as a non-EnterpriseDB employee. If suppose Greenplum had given us a utility and they wanted it to work with their version of the database, what accommodation would we make for them? I agree on the

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Florian Pflug
On May 13, 2010, at 23:39 , Tom Lane wrote: Florian Pflug f...@phlo.org writes: All in all, I believe that SHARE and UPDATE row-level locks should be changed to cause concurrent UPDATEs to fail with a serialization error. I don't see an argument for doing that for FOR SHARE locks, and it

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Florian Pflug
On May 13, 2010, at 23:51 , Kevin Grittner wrote: Florian Pflug f...@phlo.org wrote: All in all, I believe that SHARE and UPDATE row-level locks should be changed to cause concurrent UPDATEs to fail with a serialization error. I can come up with a patch that does that, but I wanted to get

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Takahiro Itagaki wrote: I read pg_upgrade code glance over, and found 4 issues in it. Are there any issues to be fixed before 9.0 release? 1. NAMEDATASIZE 2. extern PGDLLIMPORT 3. pathSeparator 4. EDB_NATIVE_LANG 1. NAMEDATASIZE pg_upgrade has the following

Re: [HACKERS] How to know killed by pg_terminate_backend

2010-05-13 Thread Tatsuo Ishii
Maybe we could make PostgreSQL a little bit smarter so that it returns a different code than 57P01 when killed by pg_terminate_backend(). Seems reasonable. Does the victim backend currently know why it has been killed? I don't think so. One idea is postmaster sets a flag in the shared

Re: [HACKERS] Re: [COMMITTERS] pgsql: Add PGFILEDESC description to Makefiles for all /contrib

2010-05-13 Thread Bruce Momjian
Magnus Hagander wrote: On Thu, May 13, 2010 at 1:47 AM, Bruce Momjian br...@momjian.us wrote: bruce wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: All other binaries had such a designation, and all /contrib binaries were missing them. ?I assume I was doing cleanup.

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Bruce Momjian
Robert Haas wrote: On Thu, May 13, 2010 at 1:00 PM, Bruce Momjian br...@momjian.us wrote: Is there a reason we require single quotes around boolean values in recovery.conf? ? ? ? ?standby_mode = 'off' This does not work: ? ? ? ?standby_mode = off I knew there were

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Greg Stark
On Thu, May 13, 2010 at 10:25 PM, Florian Pflug f...@phlo.org wrote: C1: BEGIN C1: SELECT * FROM t WHERE id = 1 FOR UPDATE C2: BEGIN C2: SET TRANSACTION ISOLATION LEVEL SERIALIZABLE C2: SELECT * FROM t -- Take snapshot before C1 commits C1: COMMIT C2: DELETE FROM t WHERE id = 1 C2: COMMIT

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Takahiro Itagaki wrote: 2. extern PGDLLIMPORT pg_upgrade has own definitions of extern PGDLLIMPORT Oid binary_upgrade_next_xxx in pg_upgrade_sysoids.c. But those variables are not declared as PGDLLIMPORT in the core. Can we access unexported

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Greg Stark
On Thu, May 13, 2010 at 11:33 PM, Robert Haas robertmh...@gmail.com wrote: I think we should add a TODO to parse recovery.conf with the same code we use to parse postgresql.conf, or possibly merge the two files. This issue was previously alluded to here:

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Takahiro Itagaki wrote: 2. extern PGDLLIMPORT pg_upgrade has own definitions of extern PGDLLIMPORT Oid binary_upgrade_next_xxx in pg_upgrade_sysoids.c. But those variables are not declared as PGDLLIMPORT in the core. Can

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Tom Lane
Greg Stark gsst...@mit.edu writes: On Thu, May 13, 2010 at 11:33 PM, Robert Haas robertmh...@gmail.com wrote: I think we should add a TODO to parse recovery.conf with the same code we use to parse postgresql.conf, or possibly merge the two files. This issue was previously alluded to here:

[HACKERS] JSON manipulation functions

2010-05-13 Thread Joseph Adams
First off, thank you for allowing me to participate in Google Summer of Code 2010. I'm sorry I haven't been active for the past few weeks. Today, I added the wiki page for my project, but the project schedule is highly tentative: http://wiki.postgresql.org/wiki/JSON_datatype_GSoC_2010 . I'd

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Takahiro Itagaki
Bruce Momjian br...@momjian.us wrote: 2. extern PGDLLIMPORT pg_upgrade has own definitions of extern PGDLLIMPORT Oid binary_upgrade_next_xxx The issue here is that you use PGDLLIMPORT where you are importing the variable, not where it is defined. For example, look at

Re: [HACKERS] wal_level and continuous archiving documentation

2010-05-13 Thread Fujii Masao
On Fri, May 14, 2010 at 1:42 AM, Joshua Tolley eggyk...@gmail.com wrote: I was reading through http://www.postgresql.org/docs/9.0/static/continuous-archiving.html and noticed that wal_level isn't mentioned where I'd expect it to be. Specifically, there's a paragraph that starts, To enable WAL

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Fujii Masao
On Fri, May 14, 2010 at 9:37 AM, Bruce Momjian br...@momjian.us wrote: I thought the problem was just quotes inside strings, not the requirement of quotes for everything. You can embed a single quote in a parameter value by writing two quotes. Regards, -- Fujii Masao NIPPON TELEGRAPH AND

Re: [HACKERS] wal_level in postgresql.conf

2010-05-13 Thread Fujii Masao
On Fri, May 14, 2010 at 12:22 AM, Bruce Momjian br...@momjian.us wrote: Bruce Momjian wrote: Why is 'wal_level' listed next to 'fsync' in postgresql.conf?       #wal_level = 'hot_standby'              # minimal, archive, or hot_standby       #fsync = on                             # turns

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Joshua D. Drake wrote: Between labels, filters, watch lists and all the other goodies any MUA will give you, I see no reason to have this all broken out anymore. So, if one merges all the lists into one (not arguing for / against that), how do you filter? Based on what?

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Takahiro Itagaki
Jaime Casanova ja...@2ndquadrant.com wrote: i migrate a ms sql server database to postgres and was trying some queries from the application to find if everything works right... when i was looking to those queries i found some that has a notation for nvarchar (ej: campo = N'sometext') Do you

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Bruce Momjian
Takahiro Itagaki wrote: Bruce Momjian br...@momjian.us wrote: 2. extern PGDLLIMPORT pg_upgrade has own definitions of extern PGDLLIMPORT Oid binary_upgrade_next_xxx The issue here is that you use PGDLLIMPORT where you are importing the variable, not where it

Re: [HACKERS] List traffic

2010-05-13 Thread Alvaro Herrera
Excerpts from Marc G. Fournier's message of jue may 13 23:11:40 -0400 2010: On Thu, 13 May 2010, Joshua D. Drake wrote: Between labels, filters, watch lists and all the other goodies any MUA will give you, I see no reason to have this all broken out anymore. So, if one merges all the

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Tom Lane
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Jaime Casanova ja...@2ndquadrant.com wrote: i migrate a ms sql server database to postgres and was trying some queries from the application to find if everything works right... when i was looking to those queries i found some that has a

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Jaime Casanova
On Thu, May 13, 2010 at 10:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Actually, the lexer translates N'foo' to NCHAR 'foo' and then the grammar treats that just like CHAR 'foo'.  In short, the N doesn't do anything very useful, and it certainly doesn't have any effect on encoding behavior.  I

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Tom Lane
Jaime Casanova ja...@2ndquadrant.com writes: On Thu, May 13, 2010 at 10:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Actually, the lexer translates N'foo' to NCHAR 'foo' and then the grammar treats that just like CHAR 'foo'.  In short, the N doesn't do anything very useful, and it certainly

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Jaime Casanova
On Thu, May 13, 2010 at 10:13 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Jaime Casanova ja...@2ndquadrant.com wrote: i migrate a ms sql server database to postgres and was trying some queries from the application to find if everything works right... when i was looking to

[HACKERS] Generalized Inverted Generalized Search Tree

2010-05-13 Thread Takahiro Itagaki
We can index multiple scalar values per row with GIN access method, and also can index single vector value per row with GiST AM. Is it worth having a new AM to index multiple vector values per row? It will be an AM for the missing feature in below: | scalar | vector |

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Peter Eisentraut
On tor, 2010-05-13 at 23:52 -0400, Tom Lane wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Jaime Casanova ja...@2ndquadrant.com wrote: i migrate a ms sql server database to postgres and was trying some queries from the application to find if everything works right... when

Re: [HACKERS] List traffic

2010-05-13 Thread Marc G. Fournier
On Thu, 13 May 2010, Alvaro Herrera wrote: If most of the questions are badly categorized or cross posted to more than one list, how useful a label is the X-Mailing-List header? How useful is to filter on the pgsql-general label? That is a point, but, IMHO, that is one of our key issues ...

Re: [HACKERS] quoting and recovery.conf

2010-05-13 Thread Simon Riggs
On Thu, 2010-05-13 at 21:15 -0400, Tom Lane wrote: Greg Stark gsst...@mit.edu writes: On Thu, May 13, 2010 at 11:33 PM, Robert Haas robertmh...@gmail.com wrote: I think we should add a TODO to parse recovery.conf with the same code we use to parse postgresql.conf, or possibly merge the two

Re: [HACKERS] Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-05-13 Thread Anssi Kääriäinen
On 05/14/2010 03:37 AM, Greg Stark wrote: On Thu, May 13, 2010 at 10:25 PM, Florian Pflugf...@phlo.org wrote: C1: BEGIN C1: SELECT * FROM t WHERE id = 1 FOR UPDATE C2: BEGIN C2: SET TRANSACTION ISOLATION LEVEL SERIALIZABLE C2: SELECT * FROM t -- Take snapshot before C1 commits C1: COMMIT