Re: [HACKERS] Typo in planstats.sgml

On 18/06/2017 01:03, Peter Eisentraut wrote: > On 6/17/17 05:00, Julien Rouhaud wrote: >> A "condition" is missing, patch attached. > > fixed > Thanks. -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] logical replication - still unstable after all these months

On 2017-06-18 00:27, Peter Eisentraut wrote: On 6/17/17 06:48, Erik Rijkers wrote: On 2017-05-28 12:44, Erik Rijkers wrote: re: srsubstate in pg_subscription_rel: No idea what it means. At the very least this value 'w' is missing from the documentation, which only mentions: i = initalize

Re: [HACKERS] type cache for concat functions

2017-06-18 0:50 GMT+02:00 Dmitry Dolgov <9erthali...@gmail.com>: > > On 20 May 2017 at 10:03, Pavel Stehule wrote: > > > > Now concat is 2x times slower than || operator. With cached FmgrInfo for > > output function it will be only 5%. > > Looks nice and does what's

Re: [HACKERS] Decimal64 and Decimal128

On Sun, Jun 18, 2017 at 2:31 PM, Robert Haas wrote: > On Sat, Jun 17, 2017 at 3:50 PM, Thomas Munro > wrote: >> On Sun, Jun 18, 2017 at 5:38 AM, Robert Haas wrote: >>> I feel like these would logically just be

Re: [HACKERS] Decimal64 and Decimal128

On Sat, Jun 17, 2017 at 3:50 PM, Thomas Munro wrote: > On Sun, Jun 18, 2017 at 5:38 AM, Robert Haas wrote: >> On Thu, Jun 15, 2017 at 10:27 PM, Thomas Munro >> wrote: >>> 1. They are fixed size, and

Re: [HACKERS] outfuncs.c utility statement support

On 6/14/17 12:05, Tom Lane wrote: > Peter Eisentraut writes: >> So this seems to be a pretty basic bug. Some node fields of type char >> may be zero, and so printing them as a zero byte just truncates the >> whole output string. This could be fixed by printing

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

On 2017-06-17 21:55, Tom Lane wrote: > I spent some time looking into this. I reverted your commits > 198457848ae5c86bec3336a9437dd5aa30f480c2 (Replace err.h functions with > standard C equivalents) and fb10acb040b90bdcbad09defd303363db29257d1 > (Remove inclusion of sys/cdefs.h) locally and tried

Re: [HACKERS] Typo in planstats.sgml

On 6/17/17 05:00, Julien Rouhaud wrote: > A "condition" is missing, patch attached. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] type cache for concat functions

> On 20 May 2017 at 10:03, Pavel Stehule wrote: > > Now concat is 2x times slower than || operator. With cached FmgrInfo for > output function it will be only 5%. Looks nice and does what's expected (what else one may need from a Saturday evening). I just can mention

Re: [HACKERS] logical replication - still unstable after all these months

On 6/17/17 06:48, Erik Rijkers wrote: > On 2017-05-28 12:44, Erik Rijkers wrote: > > re: srsubstate in pg_subscription_rel: > >> No idea what it means. At the very least this value 'w' is missing >> from the documentation, which only mentions: >> i = initalize >> d = data copy >> s =

[HACKERS] initdb initalization failure for collation "ja_JP"

Building on Cygwin latest 10 beta1 or head sourece, make check fails as: -initdb.log - The database cluster will be initialized with locales COLLATE: en_US.UTF-8 CTYPE:en_US.UTF-8 MESSAGES: C MONETARY: en_US.UTF-8 NUMERIC:

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

*Updates till now:* - added a record to pg_proc (src/include/catalog/pg_proc.h) - modified opr_sanity regression check expected results - implemented a low-level function called `array_contains_elem` as an equivalent to `array_contain_compare` but accepts anyelement instead of

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

On 6/16/17 10:51, Tom Lane wrote: > So I'm back to the position that we ought to stick the indent > code under src/tools/ in our main repo. Is anyone really > seriously against that? I think it would be better to have it separate. Other than for reasons of principle and general modularity of

Re: [HACKERS] INSERT ... ON CONFLICT () SELECT

On Sat, Jun 17, 2017 at 7:49 AM, Matt Pulver wrote: > With the proposed "INSERT ... ON CONFLICT () SELECT" feature, the > get_or_create_id() function is simplified to: Are you locking the existing rows? Because otherwise, the determination that they're conflicting can

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

I wrote: > Piotr Stefaniak writes: >> There are also the "portability fixes" and they're the main problem. > Fair enough. I spent some time looking into this. I reverted your commits 198457848ae5c86bec3336a9437dd5aa30f480c2 (Replace err.h functions with standard C

Re: [HACKERS] Decimal64 and Decimal128

On Sun, Jun 18, 2017 at 5:38 AM, Robert Haas wrote: > On Thu, Jun 15, 2017 at 10:27 PM, Thomas Munro > wrote: >> 1. They are fixed size, and DECFLOAT(9) [= 32 bit] and DECFLOAT(17) >> [= 64 bit] could in theory be passed by value. Of course

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

Robert Haas writes: > On Fri, Jun 16, 2017 at 10:51 AM, Tom Lane wrote: >> So I'm back to the position that we ought to stick the indent >> code under src/tools/ in our main repo. Is anyone really >> seriously against that? > Is it under the same

Re: [HACKERS] Preliminary results for proposed new pgindent implementation

On Fri, Jun 16, 2017 at 10:51 AM, Tom Lane wrote: > So I'm back to the position that we ought to stick the indent > code under src/tools/ in our main repo. Is anyone really > seriously against that? Is it under the same license as everything else? -- Robert Haas

Re: [HACKERS] Decimal64 and Decimal128

On Thu, Jun 15, 2017 at 10:27 PM, Thomas Munro wrote: > 1. They are fixed size, and DECFLOAT(9) [= 32 bit] and DECFLOAT(17) > [= 64 bit] could in theory be passed by value. Of course we don't > have a way to make those pass-by-value and yet pass DECFLOAT(34) [= >

Re: [HACKERS] how are the rpms configured that are available in PostgreSQL RPM Building Project - Yum Repository

Hi, On Fri, 2017-06-16 at 19:40 +, Cook, Malcolm wrote: > > I am referring to the contents of https://yum.postgresql.org/ (specifically > version 9.6 rpms for CentoOS7) > > More specifically I wonder if they are configured:    --with-python --with- > tcl --with-pam --with-ldap

[HACKERS] 答复: [HACKERS] 答复: GiST API Adancement

2017-06-16 17:06 GMT+03:00 Tom Lane : > Yuan Dong writes: >> ·¢¼þÈË: Andrew Borodin >>> I think there is one more aspect of development: backward >>> compatibility: it's impossible to update all existing extensions. This >>> is not

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, On Sat, Jun 17, 2017 at 6:38 PM, Peter Eisentraut wrote: > On 6/16/17 23:46, Amit Kapila wrote: >> I have just posted one way >> to determine if icu library has support for ucol_strcollUTF8, see if >> that sounds like a way forward to you. > > I'm not in a

[HACKERS] INSERT ... ON CONFLICT () SELECT

Hello, I am looking to add a new language feature that returns the rows that conflict on an INSERT, and would appreciate feedback and guidance on this. Here is an example. To implement a get_or_create_id() function, this is how it must currently be done: CREATE TABLE example ( id SERIAL

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

On Sat, Jun 17, 2017 at 10:24:32AM -0400, Peter Eisentraut wrote: > On 6/15/17 15:19, Julien Rouhaud wrote: > > Hi, > > > > I just found $SUBJECT, patch attached. > > fixed Thanks! -- Julien Rouhaud http://dalibo.com - http://dalibo.org -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

On 6/15/17 15:19, Julien Rouhaud wrote: > Hi, > > I just found $SUBJECT, patch attached. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Getting server crash on Windows when using ICU collation

On 6/16/17 23:46, Amit Kapila wrote: > I have just posted one way > to determine if icu library has support for ucol_strcollUTF8, see if > that sounds like a way forward to you. I'm not in a position to test such patches, so someone else will have to take that on. It might not be worth

Re: [HACKERS] Getting server crash on Windows when using ICU collation

Hi, Attached is the patch that detects the ICU version on Windows and based on that it decides whether 'HAVE_UCOL_STRCOLLUTF8' flag needs to be set or not. If this patch gets consisdered then, we may have to revert the changes following git commit. Thanks. commit

Re: [HACKERS] [BUGS] BUG #14699: Statement trigger and logical replication

2017-06-16 22:08 GMT-03:00 Peter Eisentraut : > > The issue is that the logical replication initial data copy fires a > statement trigger for INSERT, because it's implemented as a COPY > internally. > > We should document such behavior. AFAICS we discuss later

Re: [HACKERS] logical replication - still unstable after all these months

On 2017-05-28 12:44, Erik Rijkers wrote: re: srsubstate in pg_subscription_rel: No idea what it means. At the very least this value 'w' is missing from the documentation, which only mentions: i = initalize d = data copy s = synchronized r = (normal replication) Shouldn't we add this

Re: [HACKERS] Incorrect comment in 001_ssltests.pl

On Sat, Jun 17, 2017 at 5:20 PM, Magnus Hagander wrote: > One could argue that the first sentences should just read "the argument" > once the second one isn't referred, but I can't get too excited about that. > Thus, patch applied as-is - thanks! Thanks. -- Michael --

[HACKERS] Typo in planstats.sgml

A "condition" is missing, patch attached. -- Julien Rouhaud http://dalibo.com - http://dalibo.org diff --git a/doc/src/sgml/planstats.sgml b/doc/src/sgml/planstats.sgml index 8caf297f85..838fcda6d2 100644 --- a/doc/src/sgml/planstats.sgml +++ b/doc/src/sgml/planstats.sgml @@ -501,8 +501,8 @@

Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

> To be clear, part of "retrying from the beginning" means that if a> result from one statement is used to determine the content (or> whether to run) a subsequent statement, that first statement must be> run in the new transaction and the results evaluated again to> determine what to use for the

Re: [HACKERS] Incorrect comment in 001_ssltests.pl

On Sat, Jun 17, 2017 at 1:53 AM, Michael Paquier wrote: > Hi all, > > I have noticed the following thing: > --- a/src/test/ssl/t/001_ssltests.pl > +++ b/src/test/ssl/t/001_ssltests.pl > @@ -34,8 +34,6 @@ sub run_test_psql > # The first argument is a (part of a)

Re: [HACKERS] Typos in comments

On Sat, Jun 17, 2017 at 8:55 AM, Daniel Gustafsson wrote: > Spotted one “paramter” typo and git grep found two more, patch attached > with > s/paramter/parameter/ for these. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/

[HACKERS] Typos in comments

Spotted one “paramter” typo and git grep found two more, patch attached with s/paramter/parameter/ for these. cheers ./daniel typo-paramter.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: