Re: [HACKERS] Planning time in explain/explain analyze

2014-01-08 Thread Andreas Karlsson
feel that such a patch would be more invasive. Just my reasoning for the current solution. I welcome any opinions about how to print planning time for prepared statements since I am not a heavy user of them. -- Andreas Karlsson diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml

Re: [HACKERS] Planning time in explain/explain analyze

2014-01-02 Thread Andreas Karlsson
of the patch. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PoC: Partial sort

2013-12-31 Thread Andreas Karlsson
for improvement. You could decrement the bound for the tuplesort after every completed sort. Otherwise the optimizations for small limits wont apply to partial sort. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Planning time in explain/explain analyze

2013-12-28 Thread Andreas Karlsson
New version of the patch with updated documentation and which does not display the planning time when the COSTS are off. I will add it to the next commitfest. -- Andreas Karlsson diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml new file mode 100644 index 2af1738..240a3d5

Re: [HACKERS] A GIN index internals question

2013-12-27 Thread Andreas Karlsson
. This tidbitmap becomes lossy if the matching TIDs do not fit into the workmem. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] trailing comment ghost-timing

2013-12-24 Thread Andreas Karlsson
thought the server should print timing even if PGRES_EMPTY_QUERY is returned. Now after thinking on it I am not so sure. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Planning time in explain/explain analyze

2013-12-24 Thread Andreas Karlsson
On 12/24/2013 02:31 PM, Peter Eisentraut wrote: On 12/23/13, 8:12 PM, Andreas Karlsson wrote: A user asked in -performance[1] if there is a way to measure the planning time. log_planner_stats Thanks for the suggestion, I will use that if I need to know the plan times. But I do not think

Re: [HACKERS] Planning time in explain/explain analyze

2013-12-24 Thread Andreas Karlsson
not clutter anything too much. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Planning time in explain/explain analyze

2013-12-23 Thread Andreas Karlsson
loops=1) Index Cond: (oid = s.datid) Planning time: 0.264 ms Total runtime: 0.158 ms (11 rows) Links 1. http://www.postgresql.org/message-id/cacfv+pknembqyjpcqrgsvmc_hvrgai3d_ge893n8qbx+ymh...@mail.gmail.com -- Andreas Karlsson diff --git a/src/backend/commands/explain.c b/src/backend

Re: [HACKERS] trailing comment ghost-timing

2013-12-23 Thread Andreas Karlsson
guess one would have to modify psql_scan() to check if a scanned query only contains comments and then not send it to the server at all. The minimal file to reproduce it is: /**/ -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] PoC: Partial sort

2013-12-23 Thread Andreas Karlsson
the improvements to joins. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] trailing comment ghost-timing

2013-12-23 Thread Andreas Karlsson
: PQexec(..., /**/;); PQexec(..., /**/); If this has to be fixed it should be in the client. I think people would complain if we broke the API by starting to throw an exception on PQexec with a string containing no actual query. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Planning time in explain/explain analyze

2013-12-23 Thread Andreas Karlsson
On 12/24/2013 03:33 AM, Tom Lane wrote: Andreas Karlsson andr...@proxel.se writes: The patch does not include any changes to documentation or tests. I will fix that if people think this patch is useful. I take it you've not tried the regression tests with this. Yeah, forgot to mention

Re: [HACKERS] PoC: Partial sort

2013-12-18 Thread Andreas Karlsson
with an increased chance of spilling to disk. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PoC: Partial sort

2013-12-14 Thread Andreas Karlsson
you considered? -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] What are multixactids?

2013-12-09 Thread Andreas Karlsson
/d9250da032e723d80bb0150b9276cc544df6a087/src/backend/access/heap/README.tuplock#L68 -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] What are multixactids?

2013-12-09 Thread Andreas Karlsson
On 12/09/2013 08:05 PM, hubert depesz lubaczewski wrote: Thanks. Read that. Still, it would be good to have some information in normal docs, but I guess this has to do for now. It is mentioned several times in the documentation but I do not think it is explained anywhere. -- Andreas

Re: [HACKERS] Todo item: Support amgettuple() in GIN

2013-11-29 Thread Andreas Karlsson
On 11/29/2013 09:54 AM, Antonin Houska wrote: On 11/29/2013 01:13 AM, Andreas Karlsson wrote: When doing partial matching the code need to be able to return the union of all TIDs in all the matching posting trees in TID order (to be able to do AND and OR operations with multiple search keys

Re: [HACKERS] Todo item: Support amgettuple() in GIN

2013-11-29 Thread Andreas Karlsson
that a TIDBitmap based on the fast update pending list always will fit in the memory. That does not sound like a good assumption to me. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

[HACKERS] Todo item: Support amgettuple() in GIN

2013-11-28 Thread Andreas Karlsson
/ca+tgmobzhfrjnyz-fyw5kdtrurk0hjwp0vtp5fgzle6evsw...@mail.gmail.com -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Put json type into alphabetical order in manual table

2013-11-25 Thread Andreas Karlsson
? -- Andreas Karlsson diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml new file mode 100644 index dea5195..fb9c41a *** a/doc/src/sgml/datatype.sgml --- b/doc/src/sgml/datatype.sgml *** *** 137,142 --- 137,148 /row row +entrytypejson/type

Re: [HACKERS] Put json type into alphabetical order in manual table

2013-11-25 Thread Andreas Karlsson
On 11/25/2013 11:52 PM, Merlin Moncure wrote: On Mon, Nov 25, 2013 at 3:07 PM, Andreas Karlsson andr...@proxel.se wrote: Hi, When looking at table 8-1 at http://www.postgresql.org/docs/9.3/static/datatype.html i noticed that all types except for json was in alphabetical order. I have attached

Re: [HACKERS] Adding new syntax in postgre sql

2013-10-18 Thread Andreas Karlsson
/wiki/Table_partitioning#Active_Work_In_Progress -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Listen/notify across clusters

2013-07-16 Thread Andreas Karlsson
. There shouldn't be any major problems with implementing LISTEN on the slaves since LISTEN is done in memory. I feel like I as a beginner to the codebase am missing something bit because while this is a fair bit of work it does not too hard to implement. Andreas -- Andreas Karlsson -- Sent

Re: PL/Lua (was: [HACKERS] plpython implementation)

2013-07-01 Thread Andreas Karlsson
which currently seems to be larger than PL/Perl, PL/Python and PL/tcl. Including having the possibility to implement window functions. http://pgxn.org/dist/plv8/doc/plv8.html#Window.function.API Nice job with PL/Lua, Andreas -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-24 Thread Andreas Karlsson
was sent to those who should be reminded instead to the list. My personal experience is that personal reminders are more effective than public naming and shaming. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Tablespaces in the data directory

2012-12-04 Thread Andreas Karlsson
that data twice it sounds like it should. -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Strange primary key constraint influence to grouping

2012-01-18 Thread Andreas Karlsson
-- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parsing output of EXPLAIN command in PostgreSQL

2011-11-10 Thread Andreas Karlsson
be found at: https://github.com/depesz/Pg--Explain Best regards, Andreas -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parsing output of EXPLAIN command in PostgreSQL

2011-11-10 Thread Andreas Karlsson
On 2011-11-10 23:42, Andreas Karlsson wrote: Hi, I recommend using the XML, JSON or YAML version of the plan, whichever is easiest in your programming language to parse. I do not think anyone has written a formal schema yet for the XML but it still should be much easier to parse than rolling

Re: [HACKERS] EXECUTE tab completion

2011-10-20 Thread Andreas Karlsson
sanity, I should have done so myself when I noticed the problem. A new version is attached. Best regards, Andreas -- Andreas Karlsson diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c new file mode 100644 index abf9bc7..ee63198 *** a/src/bin/psql/tab-complete.c --- b/src

[HACKERS] EXECUTE tab completion

2011-09-26 Thread Andreas Karlsson
(while EXECUTE foo(1); is) and I did not feel the extra lines of code to add a query to check if the number of expected parameters is greater than 0 were worth it. -- Andreas Karlsson diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c new file mode 100644 index 4f7df36..15bb8c1

Re: [HACKERS] One Role, Two Passwords

2011-01-21 Thread Andreas Karlsson
On Fri, 2011-01-21 at 11:00 -0500, Garick Hamlin wrote: I can't tell if PG supports querying a secondary RADIUS server? I don't see how I would do it with the syntax here ... http://developer.postgresql.org/pgdocs/postgres/auth-methods.html Are multiple servers not supported? Garick

Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Andreas Karlsson
On Tue, 2011-01-18 at 19:34 -0500, Josh Kupershmidt wrote: Got that now too. I lost my ~/.emacs file recently, which is mostly why I'm making whitespace mistakes. Rebuilding slowly though; (setq-default show-trailing-whitespace t) is what I needed. Aha, I see. I left the Call Handler and

Re: [HACKERS] psql: Add \dL to show languages

2011-01-18 Thread Andreas Karlsson
Hi Josh, Nope, I do not have any better ideas than DO Blocks?. Everything looks good with the exception one bug now. \dL foo * QUERY ** SELECT l.lanname AS Name, pg_catalog.pg_get_userbyid(l.lanowner) as Owner, l.lanpltrusted AS Trusted FROM pg_catalog.pg_language

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Andreas Karlsson
On Mon, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote: Yeah. Procedural langauges may strictly be wrong, but people aren't likely to misunderstand it. That was idea when suggesting we call it procedural languages. It is short and I do not think it can be misunderstood. Regards, Andreas

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Andreas Karlsson
On Sun, 2011-01-16 at 22:32 -0500, Josh Kupershmidt wrote: On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se wrote: Should we include a column in \dL+ for the laninline function (DO blocks)? Hrm, I guess that could be useful for the verbose output at least. Magnus

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-17 Thread Andreas Karlsson
On Sun, 2011-01-16 at 14:28 -0500, Tom Lane wrote: One other point here is that I find messages like this a mite unreadable: function 1 (oidvector[], oidvector[]) btoidvectorcmp(oidvector,oidvector) of operator family array_ops for access method gin If we were to go with this, I'd be

Re: [HACKERS] psql: Add \dL to show languages

2011-01-15 Thread Andreas Karlsson
Hi Josh, Here is my review of this patch for the commitfest. Review of https://commitfest.postgresql.org/action/patch_view?id=439 Contents and Purpose This patch adds the \dL command in psql to list the procedual languages. To me this seems like a useful addition to the

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-15 Thread Andreas Karlsson
On Sat, 2011-01-15 at 10:36 -0500, Tom Lane wrote: But I can read the handwriting on the wall: if I want this done right, I'm going to have to do it myself. regards, tom lane Do I understand you correctly if I interpret what you would like to see is the same format used

Re: [HACKERS] Bug in pg_describe_object, patch v2

2011-01-12 Thread Andreas Karlsson
Here is a very simple change of the patch to make the output look more like the syntax of ALTER OPERATOR FAMILY to improve consistency. Before patch: function 1 bttextcmp(text,text) of operator family array_ops for access method gin With the first version: function 1 bttextcmp(text,text) of

Re: [HACKERS] Bug in pg_describe_object

2011-01-11 Thread Andreas Karlsson
On Tue, 2011-01-11 at 11:43 -0500, Tom Lane wrote: If that's what you're after, getObjectDescription is entirely unsuitable, because of the fact that its results are dependent on search path and language settings. regards, tom lane Agreed, and as long as the additional

Re: [HACKERS] Bug in pg_describe_object

2011-01-11 Thread Andreas Karlsson
On Tue, 2011-01-11 at 14:01 -0500, Tom Lane wrote: It really shouldn't be useful to include those. Attend what it says in the fine manual for CREATE OPERATOR CLASS: In a FUNCTION clause, the operand data type(s) the function is intended to support, if different from the input

[HACKERS] Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid))

2011-01-10 Thread Andreas Karlsson
Here is the bug-fix patch again with a description of the context so I can add it to the commit fest. Joel Jacobson discovered a bug in the function pg_describe_object where it does not produce unique identifiers for some entries in pg_amproc. This patch fixes the bug where when two entries in

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Andreas Karlsson
---+- {10608,10612} | {1009,1015} (1 row) Regards, Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] obj_unique_identifier(oid)

2011-01-08 Thread Andreas Karlsson
Here is a patch, but I am not sure I am not sure if I like my idea for format. What do you think? SELECT pg_describe_object('pg_amproc'::regclass,oid,0) FROM pg_amproc WHERE oid IN (10608,10612); pg_describe_object

[HACKERS] Comment typo in nodeWindowAgg.c

2010-12-21 Thread Andreas Karlsson
to advance_aggregates in nodeAgg.c */ static void advance_windowaggregate(WindowAggState *winstate, Regards, Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
get the correct one. Regards, Andreas Karlsson On Fri, 2010-12-17 at 21:00 -0500, Robert Haas wrote: On Fri, Dec 17, 2010 at 8:34 PM, andreas andr...@proxel.se wrote: It has annoys me every time I want to move a table to another schema that it completes to SET SCHEMA TO DEFAULT after a couple

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
On Fri, 2010-12-17 at 21:20 -0500, Robert Haas wrote: On Fri, Dec 17, 2010 at 9:14 PM, Andreas Karlsson andr...@proxel.se wrote: What it does is gets rid of the incorrect completion which comes from the completion rule for SET foo TO bar by adding the correct completion for SET SCHEMA

Re: [HACKERS] Tab completion for ALTER ... SET SCHEMA

2010-12-17 Thread Andreas Karlsson
Sorry, everyone. Ignore my patch. This was already fixed in HEAD and while I wrote my patch for the HEAD I somehow failed to spot that it was already fixed when testing without my patch. Nice that is fixed, and sorry for the noise. Andreas -- Sent via pgsql-hackers mailing list

<    1   2   3   4