Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-02-02 Thread David Fetter
st, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent vi

Re: [HACKERS] [COMMITTERS] pgsql: Make psql's \set display variables in alphabetical order.

2017-02-01 Thread David Fetter
On Wed, Feb 01, 2017 at 04:38:59PM -0500, Robert Haas wrote: > On Wed, Feb 1, 2017 at 1:08 PM, Andres Freund <and...@anarazel.de> wrote: > > On 2017-02-01 12:59:36 -0500, Tom Lane wrote: > >> David Fetter <da...@fetter.org> writes: > >> > On Wed, Feb 01

[HACKERS] Re: [COMMITTERS] pgsql: Make psql's \set display variables in alphabetical order.

2017-02-01 Thread David Fetter
On Wed, Feb 01, 2017 at 04:25:25PM +, Tom Lane wrote: > Make psql's \set display variables in alphabetical order. This is a substantial usability improvement which nevertheless is hard to imagine changes things that scripts relied on. I think it's worth back-patching. Best, David. -- Da

Re: [HACKERS] One-shot expanded output in psql using \G

2017-01-30 Thread David Fetter
ction this ought to go in is \g[options] [file] > > which is perfectly consistent with precedents in psql such as \d. > > But there isn't any place where we've decided that upper case means > > a variant of a lower case command. > > > > +1 +1 from me, too, for what

Re: [HACKERS] Superowners

2017-01-30 Thread David Fetter
would a cogent, user-facing explanation of DCL in one obvious spot, which I guess I've signed up to do now that I'm complaining about its lack. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter

Re: [HACKERS] pg_ls_dir & friends still have a hard-coded superuser check

2017-01-29 Thread David Fetter
On Sun, Jan 29, 2017 at 05:52:51PM -0500, Robert Haas wrote: > On Sun, Jan 29, 2017 at 5:39 PM, David Fetter <da...@fetter.org> wrote: > > On Thu, Jan 26, 2017 at 08:50:27AM -0500, Robert Haas wrote: > >> On Wed, Jan 25, 2017 at 10:31 PM, Stephen Frost <sfr...@snowman.ne

Re: [HACKERS] pg_ls_dir & friends still have a hard-coded superuser check

2017-01-29 Thread David Fetter
, all things are possible. A file name under $PGDATA could be the superuser password. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Re

Re: [HACKERS] COPY as a set returning function

2017-01-27 Thread David Fetter
works in a reasonable way. The description of the function still talks about its being a proof of concept. There are still neither regression tests nor SGML documentation. Are we at a point where we should add these things? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fette

Re: [HACKERS] One-shot expanded output in psql using \G

2017-01-27 Thread David Fetter
but > then I'm always annoyed that the expanded output is still active for > the next query after that. +1 Your situation is familiar to me, and likely common among heavy users of psql. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 377

Re: [HACKERS] COPY as a set returning function

2017-01-25 Thread David Fetter
tion. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate --

Re: [HACKERS] COPY as a set returning function

2017-01-25 Thread David Fetter
On Wed, Jan 25, 2017 at 06:16:16AM -0800, David Fetter wrote: > On Mon, Oct 31, 2016 at 04:45:40PM -0400, Corey Huinker wrote: > > Attached is a patch that implements copy_srf(). > > > > The function signature reflects cstate more than it reflects the COPY > > options (

Re: [HACKERS] COPY as a set returning function

2017-01-25 Thread David Fetter
eds a rebase. I'll see what I can do today. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating

Re: [HACKERS] COPY as a set returning function

2017-01-25 Thread David Fetter
gt; Attached is a patch that implements copy_srf(). > > > > Moved to next CF with "needs review" status. > > This patch is still waiting for review. David, are you planning to > look at it by the end of the CF? I'll be doing this today. Best, David. -- David Fetter <d

Re: [HACKERS] RustgreSQL

2017-01-17 Thread David Fetter
air to say that even there it was fixed only in part. David Gould (added to Cc:) mentioned that he had some ideas as to how to address this. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidf

Re: [HACKERS] New CORRESPONDING clause design

2017-01-17 Thread David Fetter
| DISTINCT ] to have a meaning in this context, to wit: ::= | UNION [ ALL | DISTINCT ] [ ] | EXCEPT [ ALL | DISTINCT ] [ ] Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: davi

Re: [HACKERS] Retiring from the Core Team

2017-01-11 Thread David Fetter
s our appreciation for your stepping up to this and staying at it, year after year. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Co

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-10 Thread David Fetter
On Tue, Jan 10, 2017 at 08:31:47AM -0800, David Fetter wrote: > On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote: > > David Fetter wrote: > > > > > + if (query->commandType == CMD_UPDATE || query->commandType == > > > CMD_DELETE) > &g

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-10 Thread David Fetter
On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote: > David Fetter wrote: > > > + if (query->commandType == CMD_UPDATE || query->commandType == > > CMD_DELETE) > > + { > > + /* Make sure there's something to look at. */ > >

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-09 Thread David Fetter
On Mon, Jan 09, 2017 at 07:52:11PM -0300, Alvaro Herrera wrote: > David Fetter wrote: > > > + if (query->commandType == CMD_UPDATE || query->commandType == > > CMD_DELETE) > > + { > > + /* Make sure there's something to look at. */ > >

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-09 Thread David Fetter
On Sun, Jan 08, 2017 at 06:50:12PM -0600, Jim Nasby wrote: > On 1/5/17 12:04 AM, David Fetter wrote: > > +errmsg("UPDATE requires a WHERE clause > > when require_where.delete is set to on"), > > ISTM that message is no longer

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-04 Thread David Fetter
On Wed, Jan 04, 2017 at 09:58:26PM -0800, David Fetter wrote: > On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote: > > On Sun, Jan 1, 2017 at 12:34 PM, David Fetter <da...@fetter.org> wrote: > > > I've rolled your patches into this next one and clarified

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-04 Thread David Fetter
On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote: > On Sun, Jan 1, 2017 at 12:34 PM, David Fetter <da...@fetter.org> wrote: > > I've rolled your patches into this next one and clarified the commit > > message, as there appears to have been some conf

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-03 Thread David Fetter
> > My questions: > > 1. is a data file really necessary? No. I'll remove it. > 2. There is not documented a assert "Assert(query->jointree != NULL)" > > It is valid, but should be documented why? Will do. Best, David. -- David Fetter <david(at)fetter(

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2017-01-03 Thread David Fetter
On Sun, Jan 01, 2017 at 07:57:33PM +0900, Michael Paquier wrote: > On Sun, Jan 1, 2017 at 12:34 PM, David Fetter <da...@fetter.org> wrote: > > I've rolled your patches into this next one and clarified the commit > > message, as there appears to have been some conf

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-12-31 Thread David Fetter
On Fri, Sep 30, 2016 at 04:23:13PM +1300, Thomas Munro wrote: > On Thu, Sep 29, 2016 at 6:19 PM, David Fetter <da...@fetter.org> wrote: > > On Thu, Sep 29, 2016 at 11:12:11AM +1300, Thomas Munro wrote: > >> On Mon, Sep 26, 2016 at 5:11 PM, Thomas Munro > >> <

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2016-12-30 Thread David Fetter
ess where people would delete files with "log" in the path, not infrequently on a system running at capacity, isn't just theoretical. I've seen people lose data permanently that way, and I know I'm not the only one who's seen this in the real world. Best, David. -- David Fetter <david(a

Re: [HACKERS] Hooks

2016-12-28 Thread David Fetter
sy. > > Callbacks aren't easy to find either. Should callbacks be another chapter in the docs? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(do

Re: [HACKERS] Hooks

2016-12-28 Thread David Fetter
On Wed, Dec 28, 2016 at 03:07:52PM +0900, Michael Paquier wrote: > On Wed, Dec 28, 2016 at 2:14 PM, David Fetter <da...@fetter.org> wrote: > > Here's everything that matches ^\w+_hook$ that I've found so far in > > git master. There are very likely false positives in this li

Re: [HACKERS] Hooks

2016-12-27 Thread David Fetter
On Tue, Dec 27, 2016 at 10:15:55PM -0600, Jim Nasby wrote: > On 12/27/16 7:41 PM, David Fetter wrote: > > I see it as larger in scope than mine because it changes how we do > > things as a project. An example of the kind of thing that this raises > > is enforcement. Will

Re: [HACKERS] Hooks

2016-12-27 Thread David Fetter
On Wed, Dec 28, 2016 at 01:33:13AM +, Tsunakawa, Takayuki wrote: > From: David Fetter [mailto:da...@fetter.org] > > > How about putting a descriptive comment at the location where each > > > hook variable is defined, using some convention (e.g. like > > > Javado

Re: [HACKERS] Hooks

2016-12-27 Thread David Fetter
ql.org/ for the project, but I haven't really found it helpful thus far. Let's take up literate programming in a separate thread. At the moment, our practice is that (most--hooks being an exception) user-facing features must come with with user-facing docs which are written separately from the s

Re: [HACKERS] Hooks

2016-12-27 Thread David Fetter
On Tue, Dec 27, 2016 at 01:32:46PM -0500, Tom Lane wrote: > David Fetter <da...@fetter.org> writes: > > One of our hidden treasures is the hook system, documented only in > > random presentations, if you can find them, and in the source code, if > > you know to look.

[HACKERS] Hooks

2016-12-27 Thread David Fetter
that a new hook shouldn't be documented? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres

Re: [HACKERS] pg_background contrib module proposal

2016-12-21 Thread David Fetter
On Wed, Dec 21, 2016 at 10:42:18AM -0500, Robert Haas wrote: > On Wed, Dec 21, 2016 at 10:29 AM, David Fetter <da...@fetter.org> wrote: > > On Wed, Dec 21, 2016 at 06:31:52PM +0800, Craig Ringer wrote: > >> On 21 December 2016 at 14:26, Andrew Borodin <boro...@octonica.

Re: [HACKERS] pg_background contrib module proposal

2016-12-21 Thread David Fetter
just how reliable they are. http://stackoverflow.com/questions/9116618/cpp-windows-is-there-a-sleep-function-in-microseconds Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fe

Re: [HACKERS] pg_background contrib module proposal

2016-12-20 Thread David Fetter
On Mon, Dec 19, 2016 at 09:30:32PM +0500, Andrew Borodin wrote: > 2016-12-19 4:21 GMT+05:00 David Fetter <da...@fetter.org>: > > Couldn't it sleep in increments smaller than a second? Like maybe > > milliseconds? Also, it's probably cleaner (or at least more > &g

Re: pg_authid.rolpassword format (was Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol)

2016-12-20 Thread David Fetter
On Tue, Dec 20, 2016 at 06:14:40PM -0500, Stephen Frost wrote: > David, > > * David Fetter (da...@fetter.org) wrote: > > On Tue, Dec 20, 2016 at 08:34:19AM -0500, Stephen Frost wrote: > > > * Heikki Linnakangas (hlinn...@iki.fi) wrote: > > > > Even if you ha

Re: [HACKERS] Clarifying "server starting" messaging in pg_ctl start without --wait

2016-12-20 Thread David Fetter
ful to have the prompt return while the server is still starting up. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider do

Re: [HACKERS] pg_background contrib module proposal

2016-12-20 Thread David Fetter
On Tue, Dec 20, 2016 at 11:11:36AM +0530, amul sul wrote: > On Tue, Dec 20, 2016 at 12:21 AM, David Fetter <da...@fetter.org> wrote: > > On Thu, Nov 24, 2016 at 09:16:53AM +0530, amul sul wrote: > >> Hi All, > >> > >> I would like to take over pg_backg

Re: pg_authid.rolpassword format (was Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol)

2016-12-20 Thread David Fetter
shows only what's to the left of the first semicolon suit this purpose? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Cons

Re: [HACKERS] pg_background contrib module proposal

2016-12-19 Thread David Fetter
tgres" --single -F -O -j -c search_path=pg_catalog -c exit_on_error=true template1 > /dev/null Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(do

Re: [HACKERS] pg_background contrib module proposal

2016-12-18 Thread David Fetter
ts smaller than a second? Like maybe milliseconds? Also, it's probably cleaner (or at least more comprehensible) to write something using format() and dollar quoting than the line with the double 's. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone:

Re: [HACKERS] Speedup twophase transactions

2016-12-17 Thread David Fetter
d it. It's pretty mystifying, though. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: ht

Re: [HACKERS] Declarative partitioning vs. sql_inheritance

2016-12-16 Thread David Fetter
es stupid > results. But turning off sql_inheritance for inheritance > hierarchies also produces stupid results. If we were going to do > anything about this, my vote would be to remove sql_inheritance. +1 It occurs to me this probably isn't the only GUC that's basically just a foot gun

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2016-12-15 Thread David Fetter
with the latest > commit dfe530a09226a9de80f2b4c3d5f667bf51481c49. This looks neat, but it no longer applies to master. Is a rebase in the offing? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter

Re: [HACKERS] Transaction oddity with list partition of a list partition

2016-12-15 Thread David Fetter
On Thu, Dec 15, 2016 at 06:20:04PM +0900, Amit Langote wrote: > > Hi David, > > On 2016/12/15 18:09, David Fetter wrote: > > Per Thomas Munro, could it be that the CREATE ... PARTITION OF ... > > code fails to run CacheInvalidateRelcache on its parent(s)? > > Tho

Re: [HACKERS] Transaction oddity with list partition of a list partition

2016-12-15 Thread David Fetter
On Thu, Dec 15, 2016 at 12:23:24AM -0800, David Fetter wrote: > Folks, > > I'm having some trouble understanding what's going on here. When I \i > the file in 55caaaeba877eac1feb6481fb413fa04ae9046ac without starting > a transaction explicitly, it produces the expected resu

[HACKERS] Transaction oddity with list partition of a list partition

2016-12-15 Thread David Fetter
ABLE_SCHEMA, TG_TABLE_NAME, CASE TG_OP WHEN 'INSERT' THEN NULL ELSE row_to_json(OLD)::jsonb END, CASE TG_OP WHEN 'DELETE' THEN NULL ELSE row_to_json(NEW)::jsonb END )" PL/pgSQL function log_change() line 3 at SQL statement shackle@shackle=# ROLLBACK; -- David F

Re: [HACKERS] tzdata 2016j

2016-12-06 Thread David Fetter
that time. I'm guessing that request came through because Vladimir is actually affected by the change. Apparently, you can replace the tzdata file and restart the server per https://wiki.postgresql.org/wiki/FAQ#Will_PostgreSQL_handle_recent_daylight_saving_time_changes_in_various_countries.3F Best,

Re: [HACKERS] Separate connection handling from backends

2016-12-05 Thread David Fetter
that handles libpq commands. Benefits: [interesting stuff elided] What do you see as the relationship between this proposal and the earlier one for admission control? https://www.postgresql.org/message-id/4b38c1c502250002d...@gw.wicourts.gov Best, David. -- David Fetter <david(at)fet

Re: [HACKERS] PSQL commands: \quit_if, \quit_unless

2016-11-29 Thread David Fetter
right out. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate

Re: [HACKERS] Tackling JsonPath support

2016-11-28 Thread David Fetter
b.io/jq/>. It's available under a PostgreSQL-compatible license, and has had a LOT of work put into correctness and performance. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP:

Re: [HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS

2016-11-27 Thread David Fetter
C } [, ...] [ WITH GRANT OPTION ] > > REVOKE [ GRANT OPTION FOR ] > { USAGE | CREATE | ALL [ PRIVILEGES ] } > ON SCHEMAS > FROM { [ GROUP ] role_name | PUBLIC } [, ...] > [ CASCADE | RESTRICT ] I'd love to have this available. Best, David.

Re: [HACKERS] pg_config --version

2016-11-27 Thread David Fetter
pgxntool/blob/master/base.mk#L47-L56 Thanks for sharing :) Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donat

Re: [HACKERS] pg_config --version

2016-11-27 Thread David Fetter
On Sun, Nov 27, 2016 at 03:16:37PM +0900, Michael Paquier wrote: > On Sun, Nov 27, 2016 at 9:16 AM, David Fetter <da...@fetter.org> wrote: > > While updating some extensions, I noticed that pg_config --version > > produces output that's...maybe not quite as useful as it m

[HACKERS] pg_config --version

2016-11-26 Thread David Fetter
for comprehension, and the third because it would be less strain on things that already parse the output. A somewhat larger project, not sure whether it's worth doing, would be to enable pg_config to print arbitrary combinations of the GUCs it could know about. What say? Best, David. -- David Fetter <da

Re: [HACKERS] Radix tree for character conversion

2016-10-28 Thread David Fetter
h reaching out to the Unicode consortium about this? They may well have added that as boilerplate without really considering the effects, and they even have a popup that specifically addresses licensing. http://www.unicode.org/reporting.html Best, David. -- David Fetter <david(at)fetter(dot)org&g

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-10-20 Thread David Fetter
names ending in "log"; let's do that > and be happy that we've removed one foot-gun from the system. Removing foot guns, un-sexy as it may be from a developer's perspective, is very useful work. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-30 Thread David Fetter
that wCTE should be handled (everyone can forget a WHERE clause), but if > not it should at least be documented. You are correct in that it should work for every unqualified UPDATE or DELETE, not just some. Would you be so kind as to send along the tests cases you used so I can add them to the pat

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-28 Thread David Fetter
>> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter <da...@fetter.org> wrote: > >> > > >> > [training_wheels_004.patch] > >> > >> [review] > > Ping. Please find attached the next revision. Best, David. -- David Fetter <david(at)fette

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-28 Thread David Fetter
>> On Mon, Sep 19, 2016 at 4:02 PM, David Fetter <da...@fetter.org> wrote: > >> > > >> > [training_wheels_004.patch] > >> > >> [review] > > Ping. I'll have another revision out as soon as I get some more test cases. Best, David. -- Da

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-09-21 Thread David Fetter
database, do we? I count 37 documented versions of ALTER as of git master. Is there some multiplier I'm missing? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fette

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-09-21 Thread David Fetter
e but a row entry. So you'd > do something like > > SELECT * FROM pg_stat_sql WHERE tag = 'ALTER VIEW'; +1 for this. It's MUCH easier to deal with changes in row counts than changes in row type. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-20 Thread David Fetter
so work. Would you be so kind as to describe how you got local_preload_libraries to work? I'm stuck on getting Makefile to realize that the hook should be installed in $libdir/plugins rather than $libdir itself. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ P

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-19 Thread David Fetter
On Mon, Sep 19, 2016 at 03:00:51PM -0400, Peter Eisentraut wrote: > On 9/19/16 12:02 AM, David Fetter wrote: > >> - The claim in the documentation that only superusers can do things > >> > with this module is not generally correct. > > I think that the claims are f

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-09-18 Thread David Fetter
I think that the claims are fixed. This is SUSET, at least in this patch, because anything short of that that changes query behavior seems incautious. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Sk

Re: [HACKERS] Suggestions for first contribution?

2016-09-05 Thread David Fetter
few about the implementation. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.o

Re: [HACKERS] Renaming some binaries

2016-08-26 Thread David Fetter
On Fri, Aug 26, 2016 at 04:33:47PM -0300, Euler Taveira wrote: > On 26-08-2016 14:03, David Fetter wrote: > > Would these make sense as pg_ctl options, or are you separating them > > out because they're not instance-wide? If separating them is > > important on those grounds

Re: [HACKERS] Renaming some binaries

2016-08-26 Thread David Fetter
above between instance-wide and db-specific holds. > initdb: we already have 'pg_ctl init' (since 9.0) and could remove initdb. > > Opinions? +1 for removing initdb. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666

Re: [HACKERS] [Patch] New psql prompt substitution %r (m = master, r = replica)

2016-08-11 Thread David Fetter
command. - Put the results of that query into a psql variable. This differs from \gset in that it would be executed silently at the end of each command. What say? Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfett

Re: [HACKERS] Column COMMENTs in CREATE TABLE?

2016-08-05 Thread David Fetter
uld > actually handle that. For what it's worth, I tend to put the function body last. That's just my taste, though. Would it be hard to keep the ability to permute the stuff after CREATE FUNCTION (args) RETURNS [SETOF] type as we have it now? Best, David. -- David Fetter <davi

Re: [HACKERS] New version numbering practices

2016-08-01 Thread David Fetter
w, and will just be puzzled and vaguely annoyed by references to the old system. Now, when we're changing the visible version number, seems like the time to break fully with the idea that our major version numbers have two parts. We'll still be referring, with decreasing frequency, to 9.6, 9.5, 9.4, e

Re: [HACKERS] New version numbering practices

2016-08-01 Thread David Fetter
PG-list message was usually sufficient > to indicate a branch number, but I do not think that will work so well > if one just writes "10". I'm tempted to start writing branch numbers > as something like "PG10" or "v10". Thoughts? I don't see 10 as ambiguous. It's clear

Re: [HACKERS] "Strong sides of MySQL" talk from PgDay16Russia, translated

2016-07-29 Thread David Fetter
. PostgreSQL's response should look more like this: ERROR: month field value out of range: "2016-99-99" LINE 1: select cast('2016-99-99' as date); ^ Any idea how much effort that would be? Best, David. -- David Fetter <david(at)fetter(dot)

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-28 Thread David Fetter
On Wed, Jul 27, 2016 at 02:59:17PM +0200, Vik Fearing wrote: > On 27/07/16 06:11, David Fetter wrote: > > On Wed, Jul 27, 2016 at 03:24:28AM +0200, Vik Fearing wrote: > >> On 27/07/16 03:15, Peter Eisentraut wrote: > >>> On 7/26/16 6:14 PM, Vik Fearing wrote:

Re: [HACKERS] BRIN vs. HOT

2016-07-28 Thread David Fetter
On Thu, Jul 28, 2016 at 10:53:47AM -0400, Robert Haas wrote: > [1] I look forward to a future PostgreSQL conference in which the > struggle to pronounce "HMT" forms a recurring theme. For maximal confusion, this should really be called a Heap Often Tuple. Best, David. -- Dav

Re: [HACKERS] A Modest Upgrade Proposal

2016-07-27 Thread David Fetter
ecipients, the DDL approach becomes just as convoluted as > calling functions and nobody will memorize the entire syntax. I don't see this as an actual problem. I've written parts of the SELECT syntax, but I haven't memorized even all of that. DDL doesn't promise to be more complicate

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-26 Thread David Fetter
ture people would really appreciate, even if it doesn't prevent every catastrophe. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vot

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-26 Thread David Fetter
On Tue, Jul 26, 2016 at 04:39:14PM -0400, Robert Haas wrote: > On Mon, Jul 25, 2016 at 11:38 PM, David Fetter <da...@fetter.org> wrote: > > On Mon, Jul 25, 2016 at 11:12:24PM -0400, Robert Haas wrote: > >> On Fri, Jul 22, 2016 at 2:38 AM, David Fetter <da...@fetter.org&

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-25 Thread David Fetter
On Mon, Jul 25, 2016 at 11:12:24PM -0400, Robert Haas wrote: > On Fri, Jul 22, 2016 at 2:38 AM, David Fetter <da...@fetter.org> wrote: > > I've renamed it to require_where and contrib-ified. > > I'm not sure that the Authors section is entirely complete. Does this suit? B

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2016-07-22 Thread David Fetter
! [Explanation and examples elided] To what extent, if any, are you attempting to follow the SQL:2011 standard? http://cs.ulb.ac.be/public/_media/teaching/infoh415/tempfeaturessql2011.pdf Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 A

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-22 Thread David Fetter
On Thu, Jul 21, 2016 at 09:52:26AM -0700, David Fetter wrote: > On Thu, Jul 21, 2016 at 12:46:29PM -0400, Robert Haas wrote: > > On Thu, Jul 21, 2016 at 12:39 PM, David Fetter <da...@fetter.org> wrote: > > > On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wro

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-21 Thread David Fetter
On Thu, Jul 21, 2016 at 04:48:37PM -0500, Jim Nasby wrote: > On 7/21/16 11:46 AM, David Fetter wrote: > > > > Can't you implement this as a extension? > > Yes. In that case, I'd want to make it a contrib extension, as it is > > at least in theory attached to specific ma

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-21 Thread David Fetter
ion as I was writing it up. I'd be delighted to change it to something else. Best, David. Oh, and the bike shed should definitely be puce with blaze orange polka dots. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-21 Thread David Fetter
On Thu, Jul 21, 2016 at 12:46:29PM -0400, Robert Haas wrote: > On Thu, Jul 21, 2016 at 12:39 PM, David Fetter <da...@fetter.org> wrote: > > On Thu, Jul 21, 2016 at 06:20:37PM +0300, Teodor Sigaev wrote: > >> > Please find attached a patch which makes it possible

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-21 Thread David Fetter
On Thu, Jul 21, 2016 at 09:21:55AM -0400, Jim Mlodgenski wrote: > On Thu, Jul 21, 2016 at 12:57 AM, David Fetter <da...@fetter.org> wrote: > > Please find attached a patch which makes it possible to disallow > > UPDATEs and DELETEs which lack a WHERE clause. As this chang

Re: [HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-21 Thread David Fetter
his patch allows people to set it so they're disallowed. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to

[HACKERS] PoC: Make it possible to disallow WHERE-less UPDATE and DELETE

2016-07-20 Thread David Fetter
. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate diff --git a/doc/sr

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-07-20 Thread David Fetter
ice your MSVC patch > uses libpgcommon while the Makefile symlinks the files. People have, in the past, expressed concerns about linking in pgcrypto. Apparently, in some countries, it's a legal problem. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone:

Re: [HACKERS] Column COMMENTs in CREATE TABLE?

2016-07-02 Thread David Fetter
MENT 'Really? A single-letter name?!?'), ... ) for cases where the CREATE isn't part of the syntax help alleviate the keyword issue? I suggested doing it this way because where there's one thing, in this case a COMMENT, it's reasonable to expect that there will be others and make

Re: [HACKERS] 10.0

2016-06-18 Thread David Fetter
nd simple, as is the code to handle it, even if it's regex. By the time we get to PostgreSQL 100.0, the first starship will already be back, and the 9.x PostgreSQLs will be in older to people using them then that the Zuse Z1 https://en.wikipedia.org/wiki/Konrad_Zuse is to us now. Just my $.02. Cheers

[HACKERS] Negators for operators

2016-06-03 Thread David Fetter
not. For some fraction I'll investigate if warranted, a negator makes no sense. For the rest, I'd like to propose adding negator operators prefixed with '!', just as we have for the negators of regex-like things. What say? Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/

Re: [HACKERS] JSON[B] arrays are second-class citizens

2016-06-01 Thread David Fetter
H ORDINALITY. Further out in the future, at least so it seems to me, it would be nice to have a feature where one could cast a column to an expanded row type, e.g.: SELECT my_jsonb::(i INT, t TEXT, p POINT), foo, bar FROM ... and get a result set with 5 columns in it. Cheers, David. --

Re: [HACKERS] JSON[B] arrays are second-class citizens

2016-06-01 Thread David Fetter
On Tue, May 31, 2016 at 06:20:26PM -0400, Tom Lane wrote: > David Fetter <da...@fetter.org> writes: > > On Tue, May 31, 2016 at 05:06:00PM -0400, David G. Johnston wrote: > >> While likely not that common the introduction of an ambiguity makes > >> raises

Re: [HACKERS] JSON[B] arrays are second-class citizens

2016-05-31 Thread David Fetter
On Tue, May 31, 2016 at 05:06:00PM -0400, David G. Johnston wrote: > On Tue, May 31, 2016 at 4:34 PM, David Fetter <da...@fetter.org> wrote: > > > Folks, > > > > While querying some JSONB blobs at work in preparation for a massive > > rework of the da

[HACKERS] JSON[B] arrays are second-class citizens

2016-05-31 Thread David Fetter
Another option I came up with is to make functions that match jsonb?_array_elements(_text)?(_with_ordinality), but that seems somewhat tedious and error-prone on the maintenance side. What say? Cheers, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666

[HACKERS] PostgreSQL Weekly News Survey

2016-05-30 Thread David Fetter
. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Allow COPY to use parameters

2016-05-24 Thread David Fetter
On Tue, May 24, 2016 at 02:16:40PM -0400, Tom Lane wrote: > David Fetter <da...@fetter.org> writes: > > Per discussion on IRC and some test code, COPY can't take parameters > > in a PREPARE, which feature would make it even more useful. > > Uh, what? > > regres

[HACKERS] Allow COPY to use parameters

2016-05-24 Thread David Fetter
, David. -- David Fetter <da...@fetter.org> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: david.fet...@gmail.com Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailin

Re: [HACKERS] Changed SRF in targetlist handling

2016-05-23 Thread David Fetter
On Mon, May 23, 2016 at 02:39:54PM -0500, Merlin Moncure wrote: > On Mon, May 23, 2016 at 2:13 PM, David Fetter <da...@fetter.org> wrote: > > On Mon, May 23, 2016 at 01:28:11PM -0500, Merlin Moncure wrote: > >> On Mon, May 23, 2016 at 12:10 PM, Tom Lane <t...@sss.pgh.

<    1   2   3   4   5   6   7   8   9   10   >