Re: [HACKERS] emergency outage requiring database restart

rom 50d7410b895a1aae26c7001f11bd0d71a200ef96 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@aiven.io> Date: Wed, 2 Nov 2016 16:42:36 +0200 Subject: [PATCH] BasicOpenFile: always use O_CLOEXEC if it is available --- src/backend/storage/file/fd.c | 14 +- 1 file changed, 13 insertions(+), 1

Re: [HACKERS] emergency outage requiring database restart

27.10.2016, 21:53, Merlin Moncure kirjoitti: As noted earlier, I was not able to reproduce the issue with crashme.sh, which was: NUM_FORKS=16 do_parallel psql -p 5432 -c"select PushMarketSample('1740')" castaging_test do_parallel psql -p 5432 -c"select PushMarketSample('4400')" castaging_test

Re: [HACKERS] Renaming of pg_xlog and pg_clog

14.10.2016, 07:38, Peter Eisentraut kirjoitti: On 10/12/16 11:22 AM, Tom Lane wrote: The main problem we're trying to fix here is people thinking that something with "log" in the name contains discardable data. Just relocating the directory without renaming it won't improve that. I think it

Re: [HACKERS] PostgreSQL - Weak DH group

06.10.2016, 16:52, Heikki Linnakangas kirjoitti: I propose the attached patch. It gives up on trying to deal with multiple key lengths (as noted earlier, OpenSSL just always passed keylength=1024, so that was useless). Instead of using the callback, it just sets fixed DH parameters with

Re: [HACKERS] [PATCH] pgpassfile connection option

05.10.2016, 20:06, Robert Haas kirjoitti: You could do something like that, I guess, but I think it might be a good idea to wait and see if anyone else has opinions on (1) the desirability of the basic feature, (2) the severity of the security hazard it creates, and (3) your proposed remediation

Re: [HACKERS] Hash Indexes

21.09.2016, 15:29, Robert Haas kirjoitti: For PostgreSQL, I expect the benefits of improving hash indexes to be (1) slightly better raw performance for equality comparisons and (2) better concurrency. There's a third benefit: with large columns a hash index is a lot smaller on disk than a

Re: [HACKERS] Use pread and pwrite instead of lseek + write and read

17.08.2016, 22:11, Tom Lane kirjoitti: Robert Haas writes: I don't understand why you think this would create non-trivial portability issues. The patch as submitted breaks entirely on platforms without pread/pwrite. Yes, we can add a configure test and some shim

Re: [HACKERS] Use pread and pwrite instead of lseek + write and read

17.08.2016, 16:40, Tom Lane kirjoitti: Oskari Saarenmaa <o...@ohmu.fi> writes: On my laptop a simple pgbench run (scale 100, 15 minutes) shows a 1.5% performance improvement. I would have hoped for a lot better result before anyone would propose that we should deal with all the porta

[HACKERS] Use pread and pwrite instead of lseek + write and read

Hi, The Uber blog post, among other things, pointed out that PG uses lseek + read instead of pread. I didn't see any discussion around that and my Google searches didn't find any posts about pread / pwrite for the past 10 years. With that plus the "C++ port" thread in mind, I was wondering

[HACKERS] Don't include MMAP DSM's transient files in basebackup

The files are not useful when restoring a backup and would be automatically deleted on startup anyway. Also deleted an out-of-date comment in dsm.c. / Oskari >From f26f06049b5f89ca3140462d6816259268322d78 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@aiven.io> Date: Wed, 6 Ju

Re: [HACKERS] Show dropped users' backends in pg_stat_activity

o get it in 9.6? -- Oskari Saarenmaa Aiven: managed cloud databases https://aiven.io -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Show dropped users' backends in pg_stat_activity

16.03.2016, 17:48, Tom Lane kirjoitti: Robert Haas writes: Gee, I would have expected the DROP to be blocked until the user disconnected, like we do for DROP DATABASE. Making that race-condition-free would require some notion of a lock on roles, I think. Seems pretty

[HACKERS] Fix typos in comments

Attached a patch to fix a bunch of typos in comments. / Oskari >From 1effab7d75c3ac08257c637d8662b4c8b3fdc750 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@ohmu.fi> Date: Tue, 15 Mar 2016 23:45:26 +0200 Subject: [PATCH] misc typofixes in comments --- contrib/pgcryp

[HACKERS] Show dropped users' backends in pg_stat_activity

activity by dropped roles. / Oskari >From 4632aa09fe82d80e378123ca46fdf8aecdda795f Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@ohmu.fi> Date: Mon, 14 Mar 2016 18:34:24 +0200 Subject: [PATCH] pg_stat_activity: display backends for dropped roles --- src/backend/catalog/system_views

Re: [HACKERS] [patch] extensions_path GUC

23.10.2015, 13:33, Sandro Santilli kirjoitti: One problem we have with PostGIS is you cannot test an extension unless you have access to the system extension dir. The following patch tries to address that by allowing to specify a per-cluster extension path via an "extensions_path" GUC. It is

Re: [HACKERS] jsonb_concat: make sure we always return a non-scalar value

09.09.2015, 18:53, Andrew Dunstan kirjoitti: On 09/08/2015 09:54 AM, Andrew Dunstan wrote: On 09/05/2015 02:47 AM, Oskari Saarenmaa wrote: There was a long thread about concatenating jsonb objects to each other, but that discussion didn't touch concatenating other types. Currently jsonb_concat

[HACKERS] jsonb_concat: make sure we always return a non-scalar value

ot sure that behavior makes sense, but didn't want to change that in this patch as I guess someone could consider that feature useful. / Oskari >From 299124e63bb26ab07fa8429b7d1c2035b81f15d5 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@ohmu.fi> Date: Sat, 5 Sep 2015 09:33:58 +0300 Subject

[HACKERS] misc typofixes

Attached a patch to fix a number of typos in docs and comments I noticed over the past few weeks. / Oskari >From dd5cb727d7fc1f1168040f502521a897d01cc127 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa <o...@ohmu.fi> Date: Sat, 5 Sep 2015 10:12:04 +0300 Subject: [PATCH] typofixes ---

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

07.07.2015, 19:50, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: I've restricted builds to one at a time on that host to work around this issue for now. Also attached a patch to explicitly set PWD=$(CURDIR) in the Makefile to make sure test.sh runs with the right directory

Re: [HACKERS] Repeated pg_upgrade buildfarm failures on binturon

restricted builds to one at a time on that host to work around this issue for now. Also attached a patch to explicitly set PWD=$(CURDIR) in the Makefile to make sure test.sh runs with the right directory. / Oskari From 61b18821553aa8193e46ad66904fabacb5a5a50a Mon Sep 17 00:00:00 2001 From: Oskari

Re: [HACKERS] Raising our compiler requirements for 9.6

01.07.2015, 23:33, Tom Lane kirjoitti: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it pademelon doesn't. HP-UX 10.20 was

Re: [HACKERS] Solaris testers wanted for strxfrm() behavior

27.06.2015, 19:51, Noah Misch kirjoitti: convert_string_datum() says: /* * Note: originally we guessed at a suitable output buffer size, and * only needed to call strxfrm twice if our guess was too small. * However, it seems that

[HACKERS] thread_test's sched_yield requires -lrt on solaris

which are using autoconf 2.63. We should probably check for sched_yield anyway on all branches even if it's not strictly required on 9.4+ at the moment. / Oskari From b5a7400bdfad10fcb78a371f29fbde5dff52b40d Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Fri, 26 Jun 2015 09:36

Re: [HACKERS] hstore_plpython regression test does not work on Python 3

29.05.2015, 03:12, Peter Eisentraut kirjoitti: On 5/26/15 5:19 PM, Oskari Saarenmaa wrote: [1] http://pgbuildfarm.org/cgi-bin/show_history.pl?nm=jaguarundibr=HEAD Looks like that animal uses Python 3.4. Python 3.3 and newer versions default to using a random seed for hashing objects

Re: [HACKERS] hstore_plpython regression test does not work on Python 3

22.05.2015, 09:44, Christian Ullrich kirjoitti: * Peter Eisentraut wrote: On 5/16/15 12:06 PM, Tom Lane wrote: As exhibited for instance here: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbilldt=2015-05-16%2011%3A00%3A07 I've been able to replicate this on a Fedora 21 box:

Re: [HACKERS] jsonb concatenate operator's semantics seem questionable

18.05.2015, 06:41, Josh Berkus kirjoitti: On 05/17/2015 05:46 PM, Robert Haas wrote: On May 17, 2015, at 8:38 PM, Peter Geoghegan p...@heroku.com wrote: The current behavior does not seem acceptable for the concatenate operator (operator || jsonb). I don't agree. It seems pretty clear to me

Re: [HACKERS] Configurable location for extension .control files

18.02.2015, 01:49, Jim Nasby kirjoitti: On 2/17/15 4:39 PM, Oskari Saarenmaa wrote: 10.06.2013, 17:51, Dimitri Fontaine kirjoitti: Andres Freund and...@2ndquadrant.com writes: In any case, no packager is going to ship an insecure-by-default configuration, which is what Dimitri seems

Re: [HACKERS] __attribute__ for non-gcc compilers

23.02.2015, 04:31, Robert Haas kirjoitti: On Tue, Feb 17, 2015 at 8:41 AM, Oskari Saarenmaa o...@ohmu.fi wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned

Re: [HACKERS] Configurable location for extension .control files

and postgresql.conf so people can test extensions without hacks like this: https://github.com/ohmu/pgmemcache/blob/master/localtests.sh#L23 / Oskari From 35cae53aa5e9cf89b19a3ae276e635b42fbe5313 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Tue, 17 Feb 2015 23:27:59 +0200 Subject: [PATCH

Re: [HACKERS] __attribute__ for non-gcc compilers

17.02.2015, 15:46, Andres Freund kirjoitti: On 2015-02-17 15:41:45 +0200, Oskari Saarenmaa wrote: 15.01.2015, 21:58, Robert Haas kirjoitti: On Wed, Jan 14, 2015 at 5:54 PM, Andres Freund and...@2ndquadrant.com wrote: I think I'd for now simply not define pg_attribute_aligned() on platforms

Re: [HACKERS] __attribute__ for non-gcc compilers

15.01.2015, 00:54, Andres Freund kirjoitti: I think I'd for now simply not define pg_attribute_aligned() on platforms where it's not supported, instead of defining it empty. If we need a softer variant we can name it pg_attribute_aligned_if_possible or something. Good point, all attributes

Re: [HACKERS] Proposal VACUUM SCHEMA

21.12.2014, 18:48, Fabrízio de Royes Mello kirjoitti: I work with some customer that have databases with a lot of schemas and sometimes we need to run manual VACUUM in one schema, and would be nice to have a new option to run vacuum in relations from a specific schema. The new syntax could

Re: [HACKERS] pg_basebackup fails with long tablespace paths

23.12.2014, 05:00, Amit Kapila kirjoitti: On Tue, Dec 23, 2014 at 4:10 AM, Oskari Saarenmaa wrote: 08.11.2014, 04:03, Peter Eisentraut kirjoitti: It errors when the file name is too long and adds tests for that. This could be applied to 9.5 and backpatched, if we so choose. It might

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

13.11.2014, 23:50, Andres Freund kirjoitti: On November 13, 2014 10:23:41 PM CET, Peter Eisentraut pete...@gmx.net wrote: On 11/12/14 7:31 PM, Andres Freund wrote: Yes, it sucks. But it beats not being able to reindex a relation with a primary key (referenced by a fkey) without waiting

Re: [HACKERS] pg_basebackup fails with long tablespace paths

08.11.2014, 04:03, Peter Eisentraut kirjoitti: On 11/4/14 3:52 PM, Peter Eisentraut wrote: Here are patches to address that. First, it reports errors when attempting to create a tar header that would truncate file or symlink names. Second, it works around the problem in the tests by

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

On Fri, Nov 14, 2014 at 01:57:16AM +0100, Andreas Karlsson wrote: *** a/configure.in --- b/configure.in *** AC_DEFINE_UNQUOTED(MAXIMUM_ALIGNOF, $MAX *** 1751,1756 --- 1751,1759 AC_CHECK_TYPES([int8, uint8, int64, uint64], [], [], [#include stdio.h]) + # Check

Re: [HACKERS] Inefficient barriers on solaris with sun cc

:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Thu, 23 Oct 2014 18:36:31 +0300 Subject: [PATCH] =?UTF-8?q?=C2=A0atomics:=20add=20compiler=20and=20memory?= =?UTF-8?q?=20barriers=20for=20solaris=20studio?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit

Re: [HACKERS] Inefficient barriers on solaris with sun cc

defined read and write barriers as acquire and release barriers instead of pure read and write ones as that's what other platforms appear to do. / Oskari From 0d1ee2b1d720a6ff1ae6b4707356e198b763fccf Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Fri, 26 Sep 2014 15:05:34 +0300

Re: [HACKERS] Inefficient barriers on solaris with sun cc

26.09.2014, 15:39, Robert Haas kirjoitti: On Fri, Sep 26, 2014 at 8:36 AM, Oskari Saarenmaa o...@ohmu.fi wrote: 25.09.2014, 16:34, Andres Freund kirjoitti: Binaries compiled on solaris using sun studio cc currently don't have compiler and memory barriers implemented. That means we fall back

Re: [HACKERS] Inefficient barriers on solaris with sun cc

26.09.2014, 17:28, Robert Haas kirjoitti: On Fri, Sep 26, 2014 at 8:55 AM, Oskari Saarenmaa o...@ohmu.fi wrote: So you think a read barrier is the same thing as an acquire barrier and a write barrier is the same as a release barrier? That would be surprising. It's certainly not true

Re: [HACKERS] missing isinf declaration on solaris

24.09.2014, 23:26, Tom Lane kirjoitti: Peter Eisentraut pete...@gmx.net writes: On 9/24/14 9:21 AM, Tom Lane wrote: Agreed, but what about non-GCC compilers? Stick AC_PROG_CC_C99 into configure.in. I think that's a bad idea, unless you mean to do it only on Solaris. If we do that

[HACKERS] missing isinf declaration on solaris

GCC 4.9 build on Solaris 10 shows these warnings about isinf: float.c: In function 'is_infinite': float.c:178:2: warning: implicit declaration of function 'isinf' [-Wimplicit-function-declaration] See

Re: [HACKERS] missing isinf declaration on solaris

24.09.2014, 15:25, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: GCC 4.9 build on Solaris 10 shows these warnings about isinf: float.c: In function 'is_infinite': float.c:178:2: warning: implicit declaration of function 'isinf' Ugh. isinf declaration is in iso/math_c99.h which

Re: [HACKERS] missing isinf declaration on solaris

24.09.2014, 16:21, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: ... so to enable XPG6 we'd need to use C99 mode anyway. OK. Could we just use -std=gnu99 (with -fgnu89-inline if required) with GCC on Solaris? ISTM it would be cleaner to just properly enable c99 mode rather than

Re: [HACKERS] better atomics - v0.6

207b02cd7ee6d38b92b51195a951713639f0d738 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Tue, 23 Sep 2014 13:28:51 +0300 Subject: [PATCH] atomics: fix ifdefs for gcc atomics --- src/include/port/atomics/generic-gcc.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [HACKERS] better atomics - v0.6

23.09.2014, 15:18, Andres Freund kirjoitti: On 2014-09-23 13:50:28 +0300, Oskari Saarenmaa wrote: 23.09.2014, 00:01, Andres Freund kirjoitti: The patches: 0001: The actual atomics API I tried building PG on Solaris 10/Sparc using GCC 4.9.0 (buildfarm animal dingo) with this patch

Re: [HACKERS] PL/pgSQL 1.2

06.09.2014 19:12, Jan Wieck kirjoitti: On 09/06/2014 04:21 AM, Marko Tiikkaja wrote: We wrap these things into (sometimes) simple-looking function so that none of the application developers ever run any SQL. We define an interface between the application and the database, and that interface is

[HACKERS] [PATCH] parser: optionally warn about missing AS for column and table aliases

in psql co to use AS so you can use things like \d and tab-completion without triggering the warnings. I can implement those changes if others think this patch makes sense. / Oskari From 478e694e5281a3bf91e44177ce925e6625cb44a5 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Fri, 5

Re: [HACKERS] [PATCH] parser: optionally warn about missing AS for column and table aliases

05.09.2014 23:45, Marko Tiikkaja kirjoitti: On 2014-09-05 22:38, Oskari Saarenmaa wrote: I wrote the attached patch to optionally emit warnings when column or table aliases are used without the AS keyword after errors caused by typos in statements turning unintended things into aliases came up

Re: [HACKERS] [PATCH] Filter error log statements by sqlstate

17.01.2014 19:07, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: I don't know about others, but filtering by individual SQLSTATE is exactly what I need - I don't want to suppress all plpgsql errors or constraint violations, but I may want to suppress plpgsql RAISE EXCEPTION and CHECK

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

On 25/08/14 14:35, Andres Freund wrote: currently pg_basebackup uses fetch mode when only -x is specified - which imo isn't a very good thing to use due to the increased risk of not fetching everything. How about switching to stream mode for 9.5+? +1. I was just wondering why it's not the

Re: [HACKERS] log_error_verbosity and unexpected errors

On 02/07/14 22:10, Tom Lane wrote: Greg Stark st...@mit.edu writes: I think log_error_verbosity is a strange variable. It's useless for expected user-facing errors but essential for unexpected errors that indicate bugs in the code -- and you can only have it on for everything or off for

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

31.01.2014 10:59, Sawada Masahiko kirjoitti: On Tue, Jan 21, 2014 at 7:17 AM, Oskari Saarenmaa o...@ohmu.fi wrote: 18.11.2013 07:53, Sawada Masahiko kirjoitti: On 13 Nov 2013, at 20:51, Mika Eloranta m...@ohmu.fi wrote: Prevent excessive progress reporting that can grow to gigabytes

Re: [HACKERS] [PATCH] Filter error log statements by sqlstate

30.01.2014 11:37, Jeevan Chalke kirjoitti: Hi Oskari, Are you planning to work on what Tom has suggested ? It make sense to me as well. What are your views on that ? Tom's suggestions make sense to me, but unfortunately I haven't had time to work on this feature recently so I don't think

Re: [HACKERS] integrate pg_upgrade analyze_new_cluster.sh into vacuumdb

09.01.2014 05:15, Peter Eisentraut kirjoitti: pg_upgrade creates a script analyze_new_cluster.{sh|bat} that runs vacuumdb --analyze-only in three stages with different statistics target settings to get a fresh cluster analyzed faster. I think this behavior is also useful for clusters or

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

18.11.2013 07:53, Sawada Masahiko kirjoitti: On 13 Nov 2013, at 20:51, Mika Eloranta m...@ohmu.fi wrote: Prevent excessive progress reporting that can grow to gigabytes of output with large databases. I got error with following scenario. $ initdb -D data -E UTF8 --no-locale /* setting the

Re: [HACKERS] [PATCH] Filter error log statements by sqlstate

17.01.2014 00:13, Tom Lane kirjoitti: Oskari Saarenmaa o...@ohmu.fi writes: [ 0001-Filter-error-log-statements-by-sqlstate.patch ] I looked at this patch. It took me some time to understand that what it actually does has got approximately nothing to do with what one might first expect

Re: [HACKERS] [PATCH] Filter error log statements by sqlstate

On Tue, Jan 14, 2014 at 12:22:30PM +0530, Jeevan Chalke wrote: On Mon, Jan 13, 2014 at 4:30 PM, Oskari Saarenmaa o...@ohmu.fi wrote: On 13/01/14 10:26, Jeevan Chalke wrote: 1. Documentation is missing and thus becomes difficult to understand what exactly you are trying to do

Re: [HACKERS] [PATCH] Filter error log statements by sqlstate

too. Right ? Good point, I'll address this in v2. I will look into this further. But please have your attention on above points. Thanks for the review! / Oskari On Fri, Jan 10, 2014 at 12:56 AM, Oskari Saarenmaa o...@ohmu.fi wrote: Allow the default log_min_error_statement

Re: [HACKERS] pgcrypto: implement gen_random_uuid

13.01.2014 04:35, Wim Lewis kirjoitti: One comment, this: /* get 128 random bits */ int err = px_get_random_bytes(buf, 16); might be better to use px_get_pseudo_random_bytes(). UUIDs don't need to be unguessable or have perfect entropy; they just need to be collision-resistant. RFC4122

[HACKERS] [PATCH] Filter error log statements by sqlstate

| 14 +++- src/include/utils/guc.h| 4 + src/include/utils/guc_tables.h | 1 + 4 files changed, 199 insertions(+), 3 deletions(-) / Oskari From 61fe332f35f49c59257e9dcd0b5e2ff80f1f4055 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Thu, 9 Jan 2014 20:49:28 +0200

[HACKERS] [PATCH] pgcrypto: implement gen_random_uuid

| 2 +- contrib/pgcrypto/pgcrypto.h | 1 + doc/src/sgml/pgcrypto.sgml| 11 +++ / Oskari From 522fef9c3739d4c4f3c107e574e84db67a0c07a2 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Thu, 9 Jan 2014 22:24:36

Re: [HACKERS] [PATCH] Make various variables read-only (const)

On Sun, Dec 22, 2013 at 09:43:57PM -0500, Robert Haas wrote: On Fri, Dec 20, 2013 at 12:01 PM, Oskari Saarenmaa o...@ohmu.fi wrote: This allows the variables to be moved from .data to .rodata section which means that more data can be shared by processes and makes sure that nothing can

[HACKERS] [PATCH] Make various variables read-only (const)

to the read-only data segment in the backend and 4 kilobytes in libpq. https://github.com/saaros/postgres/compare/constify 24 files changed, 108 insertions(+), 137 deletions(-) / Oskari From 89f0348747b356eaccf5edc2f85bf47d0a35c4f4 Mon Sep 17 00:00:00 2001 From: Oskari Saarenmaa o...@ohmu.fi Date: Fri, 20

Re: [HACKERS] Autoconf 2.69 update

20.11.2013 23:38, Robert Haas kirjoitti: On Wed, Nov 20, 2013 at 4:31 AM, Oskari Saarenmaa o...@ohmu.fi wrote: ISTM autoconf has been better with backwards compatibility lately. Maybe the fatal error could be changed to a warning and/or the check for version == 2.63 be replaced with a check

Re: [HACKERS] Minor patch for the uuid-ossp extension

23.11.2013 14:12, Mario Weilguni kirjoitti: Am 22.11.2013 16:15, schrieb Tom Lane: [ memo to self: never, ever accept another contrib module whose name isn't a plain SQL identifier ] Well, in that case and since this is a rarely used extension (I guess so), maybe it would be the best to

Re: [HACKERS] Autoconf 2.69 update

15.11.2013 05:00, Peter Eisentraut kirjoitti: I'm proposing that we upgrade our Autoconf to 2.69, which is the latest right now (release date 2012-04-24). There are no changes in the source needed, just tweak the version number in configure.in (see below) and run autoreconf. I've compared the

Re: [HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

On Mon, Nov 18, 2013 at 08:48:13PM -0500, Peter Eisentraut wrote: On Tue, 2013-11-05 at 18:29 +0200, Oskari Saarenmaa wrote: This can be used to tag custom built packages with an extra version string such as the git describe id or distribution package release version. I think

Re: [HACKERS] pg_fallocate

On Thu, Oct 31, 2013 at 01:16:44PM +, Mitsumasa KONDO wrote: --- a/src/backend/storage/file/fd.c +++ b/src/backend/storage/file/fd.c @@ -383,6 +383,21 @@ pg_flush_data(int fd, off_t offset, off_t amount) return 0; } +/* + * pg_fallocate --- advise OS that the data pre-allocate

[HACKERS] [PATCH] configure: add git describe output to PG_VERSION when building a git tree

This makes it easy to see if the binaries were built from a real release or if they were built from a custom git tree. --- configure.in | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/configure.in b/configure.in index a4baeaf..7c5b3ce 100644 --- a/configure.in +++

Re: [HACKERS] [PATCH] configure: add git describe output to PG_VERSION when building a git tree

On Tue, Nov 05, 2013 at 02:06:26PM +0200, Heikki Linnakangas wrote: On 05.11.2013 12:22, Oskari Saarenmaa wrote: This makes it easy to see if the binaries were built from a real release or if they were built from a custom git tree. Hmm, that would mean that a build from git checkout REL9_3_1

[HACKERS] [PATCH] configure: allow adding a custom string to PG_VERSION

This can be used to tag custom built packages with an extra version string such as the git describe id or distribution package release version. Based on pgsql-hackers discussion: http://www.postgresql.org/message-id/20131105102226.ga26...@saarenmaa.fi Signed-off-by: Oskari Saarenmaa o...@ohmu.fi

Re: [HACKERS] [PATCH] hstore_to_json: empty hstores must return empty json objects

On 17/10/13 17:23, Alvaro Herrera wrote: Oskari Saarenmaa wrote: @@ -1241,8 +1241,8 @@ hstore_to_json_loose(PG_FUNCTION_ARGS) if (count == 0) { - out = palloc(1); - *out = '\0'; + out = palloc(3); + memcpy(out, {}, 3

[HACKERS] [PATCH] hstore_to_json: empty hstores must return empty json objects

-off-by: Oskari Saarenmaa o...@ohmu.fi --- This should probably be applied to 9.3 tree as well as master. # select row_to_json(r.*) from (select ''::hstore as d) r; {d:} # select hstore_to_json('')::text::json; ERROR: invalid input syntax for type json contrib/hstore/expected/hstore.out | 12

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

05.10.2013 16:38, Bruce Momjian kirjoitti: On Fri, Oct 4, 2013 at 10:42:46PM +0300, Oskari Saarenmaa wrote: Thanks for the offers, but it looks like ZFS doesn't actually implement a similar file level clone operation. See https://github.com/zfsonlinux/zfs/issues/405 for discussion

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

03.10.2013 01:35, Larry Rosenman kirjoitti: On 2013-10-02 17:32, Josh Berkus wrote: No fundamental reason; I'm hoping ZFS will be supported in addition to btrfs, but I don't have any systems with ZFS filesystems at the moment so I haven't been able to test it or find out the mechanisms ZFS

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

On 02/10/13 17:18, Andrew Dunstan wrote: On 10/01/2013 06:31 PM, Oskari Saarenmaa wrote: Add file cloning as an alternative data transfer method to pg_upgrade. Currently only btrfs is supported, but copy-on-write cloning is also available on at least ZFS. Cloning must be requested explicitly

[HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

. This provides upgrade performance similar to link mode while allowing the old cluster to be used even after the new one has been started. Signed-off-by: Oskari Saarenmaa o...@ohmu.fi --- configure| 5 +- configure.in | 7 ++- contrib/pg_upgrade/check.c

[HACKERS] [PATCH] PL/Python: Add spidata to all spiexceptions

PL/Python maps Python SPIError exceptions with 'spidata' attribute into SQL errors. PL/Python also creates classes in plpy.spiexceptions for all known errors but does not initialize their spidata, so when a PL/Python function raises such an exception it is not recognized properly and is always