On 2017-10-02 23:24:30,"Alexander Korotkov" wrote:
On Sun, Oct 1, 2017 at 8:27 PM, chenhj wrote:
Now, this patch looks good for me. It applies cleanly, builds cleanly, passes
regression tests, new functionality is covered by regression tests. Code is OK
for me and docs too.
I'm markin
On Sun, Oct 1, 2017 at 8:27 PM, chenhj wrote:
> On 2017-10-01 04:09:19,"Alexander Korotkov"
> wrote:
>
> On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote:
>
>> On 2017-09-30 02:17:54,"Alexander Korotkov" > > wrote:
>>
>>
>> Great. Now code of this patch looks good for me.
>> However, we forgot a
On 2017-10-01 04:09:19,"Alexander Korotkov" wrote:
On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote:
On 2017-09-30 02:17:54,"Alexander Korotkov" wrote:
Great. Now code of this patch looks good for me.
However, we forgot about documentation.
The result is equivalent to replacing the ta
On Sat, Sep 30, 2017 at 8:18 PM, chenhj wrote:
> On 2017-09-30 02:17:54,"Alexander Korotkov"
> wrote:
>
>
> Great. Now code of this patch looks good for me.
> However, we forgot about documentation.
>
>
>>The result is equivalent to replacing the target data directory with
>> the
>>s
On 2017-09-30 02:17:54,"Alexander Korotkov" wrote:
Great. Now code of this patch looks good for me.
However, we forgot about documentation.
The result is equivalent to replacing the target data directory with the
source one. Only changed blocks from relation files are copied;
all
On Fri, Sep 29, 2017 at 8:10 PM, chenhj wrote:
> On 2017-09-30 00:53:31,"chenhj" wrote:
>
> On 2017-09-29 19:29:40,"Alexander Korotkov"
> wrote:
>
> On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote:
>>
>>
>>
> OK. That makes sense. Thank you for the explanation.
>
> I still have some minor com
On 2017-09-30 00:53:31,"chenhj" wrote:
On 2017-09-29 19:29:40,"Alexander Korotkov" wrote:
On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote:
OK. That makes sense. Thank you for the explanation.
I still have some minor comments.
/*
+* Save the WAL filenames of the divergence and
On 2017-09-29 19:29:40,"Alexander Korotkov" wrote:
On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote:
OK. That makes sense. Thank you for the explanation.
I still have some minor comments.
/*
+* Save the WAL filenames of the divergence and the current WAL insert
+* location of
On Fri, Sep 29, 2017 at 10:07 AM, chenhj wrote:
> On 2017-09-29 05:31:51, "Alexander Korotkov"
> wrote:
>
> On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote:
>
>> On 2017-09-29 00:43:18,"Alexander Korotkov"
>> wrote:
>>
>> On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote:
>>
>>> On 2017-09-28 01:2
On 2017-09-29 05:31:51, "Alexander Korotkov" wrote:
On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote:
On 2017-09-29 00:43:18,"Alexander Korotkov" wrote:
On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote:
On 2017-09-28 01:29:29,"Alexander Korotkov" wrote:
It appears that your patch conflicts wit
On Thu, Sep 28, 2017 at 10:52 PM, chenhj wrote:
> On 2017-09-29 00:43:18,"Alexander Korotkov"
> wrote:
>
> On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote:
>
>> On 2017-09-28 01:29:29,"Alexander Korotkov"
>> wrote:
>>
>> It appears that your patch conflicts with fc49e24f. Please, rebase it.
>>
On 2017-09-29 00:43:18,"Alexander Korotkov" wrote:
On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote:
On 2017-09-28 01:29:29,"Alexander Korotkov" wrote:
It appears that your patch conflicts with fc49e24f. Please, rebase it.
Yes, i had rebased it, Please check the new patch.
Good, now it ap
On Thu, Sep 28, 2017 at 6:44 PM, chenhj wrote:
> On 2017-09-28 01:29:29,"Alexander Korotkov"
> wrote:
>
> It appears that your patch conflicts with fc49e24f. Please, rebase it.
>
>
> Yes, i had rebased it, Please check the new patch.
>
Good, now it applies cleanly.
else if (strncmp(path, XLOG
On 2017-09-28 01:29:29,"Alexander Korotkov" wrote:
It appears that your patch conflicts with fc49e24f. Please, rebase it.
--
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Yes, i had rebased it, Please check the new patch.
-
On Mon, Sep 25, 2017 at 6:26 PM, chenhj wrote:
> On 2017-09-23 01:59:0, "Alexander Korotkov"
> wrote:
>
> On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote:
>
>> This is the new pacth with TAP test and use Macro XLOGDIR.
>>
>
> Good. I took a quick look over the patch.
> Why do you need master_que
On 2017-09-23 01:59:0, "Alexander Korotkov" wrote:
On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote:
This is the new pacth with TAP test and use Macro XLOGDIR.
Good. I took a quick look over the patch.
Why do you need master_query(), standby_query() and run_query() in
RewindTest.pm?
You can do
On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote:
> This is the new pacth with TAP test and use Macro XLOGDIR.
>
Good. I took a quick look over the patch.
Why do you need master_query(), standby_query() and run_query() in
RewindTest.pm?
You can do just $node_master->safe_psql() and $node_slave->sa
Hi
This is the new pacth with TAP test and use Macro XLOGDIR.
And i had add this patch to the commitfest,
https://commitfest.postgresql.org/15/1302/
--
Best Regards,
Chen Huajun
pg_rewind_wal_copy_reduce_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hac
At 2017-09-17 08:33:33, "Michael Paquier" wrote:
>On Sun, Sep 17, 2017 at 3:19 AM, Alexander Korotkov
> wrote:
>> Hi!
>>
>> On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote:
>>>
>>> This patch optimizes the above mentioned issues, as follows:
>>> 1. In the target data directory, do not delete the W
On Sun, Sep 17, 2017 at 3:19 AM, Alexander Korotkov
wrote:
> Hi!
>
> On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote:
>>
>> This patch optimizes the above mentioned issues, as follows:
>> 1. In the target data directory, do not delete the WAL files before the
>> divergence.
>> 2. When copying files
Hi!
On Sat, Sep 16, 2017 at 5:56 PM, chenhj wrote:
> This patch optimizes the above mentioned issues, as follows:
> 1. In the target data directory, do not delete the WAL files before the
> divergence.
> 2. When copying files from the source server, do not copy the WAL files
> before the diverge
Hi all,
Currently, pg_rewind copies all WAL files from the source server, whether or
not they are needed.
In some circumstances, will bring a lot of unnecessary network and disk IO
consumption, and also increase the execution time of pg_rewind.
Such as when wal_keep_segments or max_wal_size is
22 matches
Mail list logo