Re: [HACKERS] review: xml_is_well_formed

2010-08-02 Thread Pavel Stehule
2010/7/31 Robert Haas robertmh...@gmail.com: On Sat, Jul 31, 2010 at 8:10 AM, Peter Eisentraut pete...@gmx.net wrote: On fre, 2010-07-30 at 12:50 +0100, Mike Fowler wrote: * xml_is_well_formed returns true for simple text postgres=# SELECT xml_is_well_formed('');   xml_is_well_formed

Re: [HACKERS] Per-column collation, proof of concept

2010-08-02 Thread Jaime Casanova
On Tue, Jul 13, 2010 at 1:25 PM, Peter Eisentraut pete...@gmx.net wrote: Here is a proof of concept for per-column collation support. Hi, i was looking at this. nowadays, CREATE DATABASE has a lc_collate clause. is the new collate clause similar as the lc_collate? i mean, is lc_collate what

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-02 Thread Jeff Davis
On Sun, 2010-08-01 at 21:57 -0400, Robert Haas wrote: On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis pg...@j-davis.com wrote: Thank you for the review. On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: (1) Exclusion constraints support for operators where x operator x is false

Re: [HACKERS] review: xml_is_well_formed

2010-08-02 Thread Pavel Stehule
2010/8/2 Pavel Stehule pavel.steh...@gmail.com: 2010/7/31 Robert Haas robertmh...@gmail.com: On Sat, Jul 31, 2010 at 8:10 AM, Peter Eisentraut pete...@gmx.net wrote: On fre, 2010-07-30 at 12:50 +0100, Mike Fowler wrote: * xml_is_well_formed returns true for simple text postgres=# SELECT

[HACKERS] Postgres as Historian

2010-08-02 Thread Hardik Belani
We are using postgres as RDBMS for our product. There is a requirement coming for a feature which will require me to store data about various data points (mainly numbers) on a time scale. Data measurement is being taken every few secs/mins based and it is needed to be stored for statistical

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Markus Wanner
Hi, On 08/01/2010 08:04 PM, Sushant Sinha wrote: 1. We do not have separate tokens wikipedia and org 2. If we have the two tokens we should have them at adjacent position so that a phrase search for wikipedia org should work. This would needlessly increase the number of tokens. Instead you'd

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-02 Thread Pavel Stehule
Hello 2010/8/2 Mike Fowler m...@mlfowler.com: Hi Pavel, Currently your patch isn't applying to head, from the looks of things a function signature has changed. Can you update your patch please? yes - see attachment Also, having had a read through the patch itself I note that there are no

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Sun, Aug 1, 2010 at 3:11 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I don't think any of this quorum stuff makes much sense without explicitly registering standbys in the master. I'm not sure if this is a good idea. This requires users to do more manual operations than

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Sun, Aug 1, 2010 at 9:51 PM, Robert Haas robertmh...@gmail.com wrote: Perhaps someone will claim that nobody wants to do that anyway (which I don't believe, BTW), but even in simpler cases it would be nicer to have an explicit policy rather than - in effect - inferring a policy from a soup

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 5:02 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Aug 1, 2010 at 9:51 PM, Robert Haas robertmh...@gmail.com wrote: Perhaps someone will claim that nobody wants to do that anyway (which I don't believe, BTW), but even in simpler cases it would be nicer to have an

Re: [HACKERS] Postgres as Historian

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 3:20 AM, Hardik Belani hardikbel...@gmail.com wrote: We are using postgres as RDBMS for our product. There is a requirement coming for a feature which will require me to store data about various data points (mainly numbers) on a time scale. Data measurement is being taken

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas robertmh...@gmail.com wrote: Let's not get *the manner of specifying the policy* confused with *the need to update the policy when the master changes*.  It doesn't seem likely you would want the same value for  synchronous_standbys on all your

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Marc Cousin írta: The Thursday 29 July 2010 13:55:38, Boszormenyi Zoltan wrote : I fixed this by adding CheckLockTimeout() function that works like CheckStatementTimeout() and ensuring that the same start time is used for both deadlock_timeout and lock_timeout if both are active. The

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 7:06 AM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas robertmh...@gmail.com wrote: Let's not get *the manner of specifying the policy* confused with *the need to update the policy when the master changes*.  It doesn't seem likely

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Boszormenyi Zoltan írta: Marc Cousin írta: The Thursday 29 July 2010 13:55:38, Boszormenyi Zoltan wrote : I fixed this by adding CheckLockTimeout() function that works like CheckStatementTimeout() and ensuring that the same start time is used for both deadlock_timeout and

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Fujii Masao
On Mon, Aug 2, 2010 at 8:32 PM, Robert Haas robertmh...@gmail.com wrote: Sure.  If you give the standbys names, then if people change the names, they'll have to update their configuration.  But I can't see that as an argument against doing it.  You can remove the possibility that someone will

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Yeb Havinga
Fujii Masao wrote: On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas robertmh...@gmail.com wrote: Let's not get *the manner of specifying the policy* confused with *the need to update the policy when the master changes*. It doesn't seem likely you would want the same value for

Re: [HACKERS] Synchronous replication

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 8:57 AM, Yeb Havinga yebhavi...@gmail.com wrote: Fujii Masao wrote: On Mon, Aug 2, 2010 at 7:53 PM, Robert Haas robertmh...@gmail.com wrote: Let's not get *the manner of specifying the policy* confused with *the need to update the policy when the master changes*.  It

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Sushant Sinha
On 08/01/2010 08:04 PM, Sushant Sinha wrote: 1. We do not have separate tokens wikipedia and org 2. If we have the two tokens we should have them at adjacent position so that a phrase search for wikipedia org should work. This would needlessly increase the number of tokens. Instead you'd

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: I agree that's the crux of the problem, but I can't see solving it with a global variable. I realize you were just testing... Yes it was just a test. However, somewhere information must be kept or altered so it can be detected that a relation has already been visited,

Re: [HACKERS] Postgres as Historian

2010-08-02 Thread Etienne Dube
On 02/08/2010 3:20 AM, Hardik Belani wrote: We are using postgres as RDBMS for our product. There is a requirement coming for a feature which will require me to store data about various data points (mainly numbers) on a time scale. Data measurement is being taken every few secs/mins based and

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Markus Wanner
Hi, On 08/02/2010 03:12 PM, Sushant Sinha wrote: The current text parser already returns url and url_path. That already increases the number of unique tokens. Well, I think I simply turned that off to be able to search for plain words. It still works for complete URLs, those are just treated

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 9:12 AM, Sushant Sinha sushant...@gmail.com wrote: The current text parser already returns url and url_path. That already increases the number of unique tokens. I am only asking for adding of normal english words as well so that if someone types only wikipedia he gets a

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 9:20 AM, Yeb Havinga yebhavi...@gmail.com wrote: Robert Haas wrote: I agree that's the crux of the problem, but I can't see solving it with a global variable.  I realize you were just testing... Yes it was just a test. However, somewhere information must be kept or

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Sushant Sinha
On Mon, 2010-08-02 at 09:32 -0400, Robert Haas wrote: On Mon, Aug 2, 2010 at 9:12 AM, Sushant Sinha sushant...@gmail.com wrote: The current text parser already returns url and url_path. That already increases the number of unique tokens. I am only asking for adding of normal english words

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Tom Lane
Sushant Sinha sushant...@gmail.com writes: This would needlessly increase the number of tokens. Instead you'd better make it work like compound word support, having just wikipedia and org as tokens. The current text parser already returns url and url_path. That already increases the number

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Kevin Grittner
Sushant Sinha sushant...@gmail.com wrote: Yes thats what I am planning to do. I just wanted to see if anyone can help me in estimating whether this is doable in the current parser or I need to write a new one. If possible, then some idea on how to go about implementing? The current tsearch

Re: [HACKERS] english parser in text search: support for multiple words in the same position

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:21 AM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Sushant Sinha sushant...@gmail.com wrote: Yes thats what I am planning to do. I just wanted to see if anyone can help me in estimating whether this is doable in the current parser or I need to write a new one.

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: On Mon, Aug 2, 2010 at 9:20 AM, Yeb Havinga yebhavi...@gmail.com wrote: The attached patch uses the globally defined list. I can't speak for any other committer, but personally I'm prepared to reject out of hand any solution involving a global variable. This code is none to

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
2010/8/2 Alexander Korotkov aekorot...@gmail.com: On Mon, Aug 2, 2010 at 5:20 AM, Robert Haas robertmh...@gmail.com wrote: I reviewed this code in a fair amount of detail today and ended up rewriting it.  In general terms, it's best to avoid changing things that are not relevant to the central

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Marc Cousin
The Monday 02 August 2010 13:59:59, Boszormenyi Zoltan wrote : Also, I made sure that only one or two timeout causes (one of deadlock_timeout and lock_timeout in the first case or statement_timeout plus one of the other two) can be active at a time. A little clarification is needed.

Re: [HACKERS] Compiling CVS HEAD with clang under OSX

2010-08-02 Thread Tom Lane
Neil Conway neil.con...@gmail.com writes: FWIW, I think we should aim to eventually remove the dependency on -fwrapv, and instead make the code correct under the semantics guaranteed by the C spec. [ shrug... ] We've gone around on that before. I can't get excited about it, and the reason is

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:47 AM, Yeb Havinga yebhavi...@gmail.com wrote: The attached patch uses the globally defined list. I can't speak for any other committer, but personally I'm prepared to reject out of hand any solution involving a global variable.  This code is none to easy to follow

Re: [HACKERS] knngist - 0.8

2010-08-02 Thread Robert Haas
2010/7/29 Alexander Korotkov aekorot...@gmail.com: But, in pg_trgm it makes it possible to combine different similarity levels in one query. For example: select * from test_trgm order by t - 'asdf' 0.5 or t - 'qwer' 0.4; Is there any chance to handle this syntax also? Maybe I'm missing

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 2:39 AM, Jeff Davis pg...@j-davis.com wrote: On Sun, 2010-08-01 at 21:57 -0400, Robert Haas wrote: On Fri, Jul 16, 2010 at 1:19 AM, Jeff Davis pg...@j-davis.com wrote: Thank you for the review. On Mon, 2010-07-12 at 17:17 +0900, Itagaki Takahiro wrote: (1)

Re: [HACKERS] Compiling CVS HEAD with clang under OSX

2010-08-02 Thread Greg Stark
On Mon, Aug 2, 2010 at 4:27 PM, Tom Lane t...@sss.pgh.pa.us wrote: Here's the problem: if the compiler is allowed to assume that overflow cannot happen, it is always going to be able to prove that the if-test is constant false.  This is inherent.  Anybody claiming to exhibit a safe way to code

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Yeb Havinga
Robert Haas wrote: I don't think that this is much cleaner than the global variable solution; you haven't really localized that need to know about the new flag in any meaningful way, the hacks in ATOneLevelRecusion() basically destroy any pretense of that code possibly being reusable for some

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Marc Cousin cousinm...@gmail.com wrote: This time, it's this case that doesn't work : I really feel that the timeout framework is the way to go here. Since Zoltán also seems to feel this way: http://archives.postgresql.org/message-id/4c516c3a.6090...@cybertec.at I wonder whether this

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Boszormenyi Zoltan
Hi, Kevin Grittner írta: Marc Cousin cousinm...@gmail.com wrote: This time, it's this case that doesn't work : I really feel that the timeout framework is the way to go here. Since Zoltán also seems to feel this way:

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Boszormenyi Zoltan z...@cybertec.at wrote: Kevin Grittner írta: I wonder whether this patch shouldn't be rejected with a request that the timeout framework be submitted to the next CF. Does anyone feel this approach (without the framework) should be pursued further? I certainly think

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 3:09 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Marc Cousin cousinm...@gmail.com wrote: This time, it's this case that doesn't work : I really feel that the timeout framework is the way to go here. Since Zoltán also seems to feel this way:

Re: [HACKERS] lock_timeout GUC patch - Review

2010-08-02 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: I wonder whether this patch shouldn't be rejected with a request that the timeout framework be submitted to the next CF. I think Returned with Feedback would be more appropriate than Rejected, since we're asking for a rework, rather than saying -

Re: [HACKERS] patch for check constraints using multiple inheritance

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 2:56 PM, Yeb Havinga yebhavi...@gmail.com wrote: I do not completely understand what you mean with the destruction of reusability of ATOneLevelRecursion, currently only called by ATPrepAddColumn - in the patch it is documented in the definition of relVisited that is it

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
2010/8/2 Alexander Korotkov aekorot...@gmail.com: The dump of the table with russian dictionary is in attachment. I use following tests: SELECT SUM(levenshtein(a, 'foo')) from words; SELECT SUM(levenshtein(a, 'Urbański')) FROM words; SELECT SUM(levenshtein(a, 'ańs')) FROM words; SELECT

Re: [HACKERS] review: xml_is_well_formed

2010-08-02 Thread Mike Fowler
On 02/08/10 07:46, Pavel Stehule wrote: I have not any suggestions now - so I'll change flag to ready to commit sorry - contrib module should be a fixed patch attached Thanks Pavel, you saved me some time! Regards, -- Mike Fowler Registered Linux user: 379787 -- Sent via pgsql-hackers

[HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Kevin Grittner
I haven't seen any posts or CF activity from Itagaki in over a week, so I'm wondering how to handle some patches in the CF. Does anyone know whether he's on vacation? Expected return? -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Review: Row-level Locks SERIALIZABLE transactions, postgres vs. Oracle

2010-08-02 Thread Florian Pflug
Hi I've updated mvcc.sgml to explain the new serialization conflict rules for row-level locks, and added a paragraph to backend/executor/README that explains the implementation of those. I've chosen backend/executor/README because it already contains a description of UPDATE handling in READ

Re: [HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Itagaki Takahiro
2010/8/3 Kevin Grittner kevin.gritt...@wicourts.gov: I haven't seen any posts or CF activity from Itagaki in over a week, so I'm wondering how to handle some patches in the CF.  Does anyone know whether he's on vacation?  Expected return? Sorry for delayed reply. I moved to a new job, and was

Re: [HACKERS] Where in the world is Itagaki Takahiro?

2010-08-02 Thread Josh Berkus
On 8/2/10 3:42 PM, Itagaki Takahiro wrote: Sorry for delayed reply. I moved to a new job, and was very busy for it. Congratulations! Are you still at NTT Open Source? -- -- Josh Berkus PostgreSQL Experts Inc.

Re: [HACKERS] multibyte charater set in levenshtein function

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 5:07 PM, Alexander Korotkov aekorot...@gmail.com wrote: Now I think patch is as good as can be. :) OK, committed. I'm going to prepare less-or-equal function in same manner as this patch. Sounds good. Since we're now more than half-way through this CommitFest and this

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Sun, Aug 1, 2010 at 11:48 PM, Robert Haas robertmh...@gmail.com wrote: b) more robust algorithm for header rows identification Have not gotten to this one yet. I notIce that on WIN32 the default editor is notepad.exe and the default editor navigation option is /. Does notepad.exe /lineno

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: This is actually my biggest concern about this patch - that it may be just too much of a hassle to actually make it work for people. I just tried setting $EDITOR to MacOS's TextEdit program, and it turns out that TextEdit doesn't understand +. I'm

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: This is actually my biggest concern about this patch - that it may be just too much of a hassle to actually make it work for people.  I just tried setting $EDITOR to MacOS's TextEdit

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'm tempted to suggest forgetting about any user-configurable parameter and just provide code that strcmp's the $EDITOR value to see if it recognizes the editor name, otherwise do

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-08-02 Thread Jeff Davis
On Mon, 2010-08-02 at 12:27 -0400, Robert Haas wrote: I was also wondering if it would be worth adding some additional regression testing to contrib/btree_gist exercising this new functionality. Thoughts? Sure. I attached two tests. Regards, Jeff Davis ***

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Robert Haas
On Mon, Aug 2, 2010 at 11:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'm tempted to suggest forgetting about any user-configurable parameter and just provide code that strcmp's the

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Pavel Stehule
2010/8/3 Robert Haas robertmh...@gmail.com: On Sun, Aug 1, 2010 at 11:48 PM, Robert Haas robertmh...@gmail.com wrote: b) more robust algorithm for header rows identification Have not gotten to this one yet. I notIce that on WIN32 the default editor is notepad.exe and the default editor

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-02 Thread Pavel Stehule
2010/8/3 Robert Haas robertmh...@gmail.com: On Mon, Aug 2, 2010 at 11:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Aug 2, 2010 at 10:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: I'm tempted to suggest forgetting about any user-configurable parameter

[HACKERS] GROUPING SETS revisited

2010-08-02 Thread Joshua Tolley
In case anyone's interested, I've taken the CTE-based grouping sets patch from [1] and made it apply to 9.1, attached. I haven't yet done things like checked it for whitespace consistency, style conformity, or anything else, but (tuits permitting) hope to figure out how it works and get it closer