[HACKERS] Planner issue

2013-10-14 Thread Soroosh Sardari
Hi I developed a new character string type, named myvarchar. Also an operator class for btree is added. I created a table with two columns, first have myvarchar(100) and other is varchar(100). CREATE TABLE test_myvarchar (mine myvarchar(100), plain varchar(100)); CREATE INDEX

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Amit Kapila
On Sun, Oct 13, 2013 at 2:08 PM, Gibheer gibh...@zero-knowledge.org wrote: On Sun, 13 Oct 2013 11:38:17 +0530 Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Oct 10, 2013 at 3:17 AM, Gibheer gibh...@zero-knowledge.org wrote: On Mon, 7 Oct 2013 11:39:55 +0530 Amit Kapila

Re: [HACKERS] Planner issue

2013-10-14 Thread Pavel Stehule
Hello pls, send a output of EXPLAIN ANALYZE statement, there can be different reasons why optimizer doesn't choose some index Regards Pavel Stehule 2013/10/14 Soroosh Sardari soroosh.sard...@gmail.com Hi I developed a new character string type, named myvarchar. Also an operator class

Fwd: [HACKERS] Planner issue

2013-10-14 Thread Soroosh Sardari
2013/10/14 Soroosh Sardari soroosh.sard...@gmail.com Hi I developed a new character string type, named myvarchar. Also an operator class for btree is added. I created a table with two columns, first have myvarchar(100) and other is varchar(100). CREATE TABLE test_myvarchar (mine

Re: [HACKERS] Planner issue

2013-10-14 Thread Tom Lane
Soroosh Sardari soroosh.sard...@gmail.com writes: I developed a new character string type, named myvarchar. Also an operator class for btree is added. PROBLEM: When I executed a query with where clause on 'mine' column, PG does not use index. Most likely you got the opclass definition wrong.

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread David Rowley
On Sat, Oct 12, 2013 at 2:58 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Peter Eisentraut escribió: On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: I did put some time review the patch, please see my findings below i.e. Updated patch for this. Looks good to me.

[HACKERS] using testlo example of postgres source code

2013-10-14 Thread mohsen soodkhah mohammadi
I work in linux I want use testlo.c in client side that testlo.c is in src/test/example/ address of postgresql source code. I run make in /src/test/example/ then copy executable file(testlo) in lib directory of installation directory of postgresql. now I don't know how do I can use this execute

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread David Rowley
On Mon, Oct 14, 2013 at 9:45 PM, David Rowley dgrowle...@gmail.com wrote: On Sat, Oct 12, 2013 at 2:58 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Peter Eisentraut escribió: On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: I did put some time review the patch, please see my

Re: [HACKERS] dynamic shared memory

2013-10-14 Thread Robert Haas
On Sun, Oct 13, 2013 at 3:07 AM, Amit Kapila amit.kapil...@gmail.com wrote: 1. Do you think we should add information about pg_dynshmem file at link: http://www.postgresql.org/docs/devel/static/storage-file-layout.html It contains information about all files/folders in data directory 2. +/*

Re: [HACKERS] Long paths for tablespace leads to uninterruptible hang in Windows

2013-10-14 Thread Robert Haas
On Thu, Oct 10, 2013 at 9:34 AM, Amit Kapila amit.kapil...@gmail.com wrote: On further analysis, I found that hang occurs in some of Windows API(FindFirstFile, RemoveDirectroy) when symlink path (pg_tblspc/spcoid/TABLESPACE_VERSION_DIRECTORY) is used in these API's. For above testcase, it will

Re: [HACKERS] Cmpact commits and changeset extraction

2013-10-14 Thread Robert Haas
On Fri, Oct 11, 2013 at 4:05 PM, Andres Freund and...@2ndquadrant.com wrote: Maybe. The original reason we added compact commits was because we thought that making unlogged tables logged and visca/versa was going to require adding still more stuff to the commit record. I'm no longer sure

Re: [HACKERS] background workers, round three

2013-10-14 Thread Robert Haas
On Fri, Oct 11, 2013 at 9:27 AM, Michael Paquier michael.paqu...@gmail.com wrote: Few comments about the code: 1) In postmaster.c, what about adding a comment here telling that we can forget about this bgworker as it has already been requested for a termination: + if

Re: [HACKERS] background workers, round three

2013-10-14 Thread Robert Haas
On Sat, Oct 12, 2013 at 4:53 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: I briefly checked these patches. Let me add some comments. Thanks! * terminate-worker-v1.patch TerminateBackgroundWorker() turns on slot-terminate flag under LW_SHARED lock. Is it reasonable because all the possible

Re: [HACKERS] Auto-tuning work_mem and maintenance_work_mem

2013-10-14 Thread Robert Haas
On Sat, Oct 12, 2013 at 3:07 AM, Magnus Hagander mag...@hagander.net wrote: On Oct 11, 2013 10:23 PM, Josh Berkus j...@agliodbs.com wrote: On 10/11/2013 01:11 PM, Bruce Momjian wrote: In summary, I think we need to: * decide on new defaults for work_mem and maintenance_work_mem * add

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Robert Haas
On Fri, Oct 11, 2013 at 4:03 PM, Andrew Dunstan and...@dunslane.net wrote: Can the owners of these buildfarm machines please check whether there are extra semaphores allocated and if so free them? Or at least reboot, to see if that unbreaks the build? It is possible to set the buildfarm

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Andres Freund
On 2013-10-14 09:12:09 -0400, Robert Haas wrote: On Fri, Oct 11, 2013 at 4:03 PM, Andrew Dunstan and...@dunslane.net wrote: Can the owners of these buildfarm machines please check whether there are extra semaphores allocated and if so free them? Or at least reboot, to see if that unbreaks

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Andrew Dunstan
On 10/14/2013 09:12 AM, Robert Haas wrote: On Fri, Oct 11, 2013 at 4:03 PM, Andrew Dunstan and...@dunslane.net wrote: Can the owners of these buildfarm machines please check whether there are extra semaphores allocated and if so free them? Or at least reboot, to see if that unbreaks the

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Robert Haas
On Mon, Oct 14, 2013 at 9:22 AM, Andrew Dunstan and...@dunslane.net wrote: Maybe I didn't explain that well. The problem is that the regression tests require at least 20 connections to run, and those two machines are currently auto-selecting 10 connections, so make check is failing. Why do

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Andres Freund
On 2013-10-14 09:28:04 -0400, Robert Haas wrote: # By convention, we put no more than twenty tests in any one parallel group; # this limits the number of connections needed to run the tests. If it's not supposed to matter how many connections are available, then that comment is misleading.

Re: [HACKERS] logical changeset generation v6.2

2013-10-14 Thread Robert Haas
On Fri, Oct 11, 2013 at 12:57 PM, Andres Freund and...@2ndquadrant.com wrote: I don't see any need for SQL syntax. I was just thinking that the _PG_init function could fill in a structure and then call RegisterLogicalReplicationOutputPlugin(mystruct). Hm. We can do that, but what'd be the

Re: [HACKERS] removing old ports and architectures

2013-10-14 Thread Robert Haas
On Sun, Oct 13, 2013 at 5:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: - PA-RISC. I think Tom was the remaining user there? Maybe just !gcc. Until pretty recently, there was a PA-RISC machine (not mine) in the buildfarm. I don't see it in the list today though. In any case, HP's compiler has

Re: [HACKERS] removing old ports and architectures

2013-10-14 Thread Andres Freund
On 2013-10-14 09:40:10 -0400, Robert Haas wrote: On Sun, Oct 13, 2013 at 5:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: - PA-RISC. I think Tom was the remaining user there? Maybe just !gcc. Until pretty recently, there was a PA-RISC machine (not mine) in the buildfarm. I don't see it in the

Re: [HACKERS] removing old ports and architectures

2013-10-14 Thread Robert Haas
On Mon, Oct 14, 2013 at 9:41 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-10-14 09:40:10 -0400, Robert Haas wrote: On Sun, Oct 13, 2013 at 5:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: - PA-RISC. I think Tom was the remaining user there? Maybe just !gcc. Until pretty recently,

Re: [HACKERS] psql tab completion for updatable foreign tables

2013-10-14 Thread Samrat Revagade
On Fri, Sep 20, 2013 at 7:54 PM, Dean Rasheed dean.a.rash...@gmail.comwrote: On 20 September 2013 11:29, Samrat Revagade revagade.sam...@gmail.com wrote: Okay, are you adding this to the september commitfest? OK, I've done that. I think that it's too late for 9.3. +1 for

Re: [HACKERS] removing old ports and architectures

2013-10-14 Thread Andres Freund
On 2013-10-14 09:42:46 -0400, Robert Haas wrote: On Mon, Oct 14, 2013 at 9:41 AM, Andres Freund and...@2ndquadrant.com wrote: On 2013-10-14 09:40:10 -0400, Robert Haas wrote: On Sun, Oct 13, 2013 at 5:34 AM, Tom Lane t...@sss.pgh.pa.us wrote: - PA-RISC. I think Tom was the remaining user

Re: [HACKERS] logical changeset generation v6.2

2013-10-14 Thread Andres Freund
On 2013-10-14 09:36:03 -0400, Robert Haas wrote: On Fri, Oct 11, 2013 at 12:57 PM, Andres Freund and...@2ndquadrant.com wrote: I don't see any need for SQL syntax. I was just thinking that the _PG_init function could fill in a structure and then call

Re: [HACKERS] Long paths for tablespace leads to uninterruptible hang in Windows

2013-10-14 Thread Magnus Hagander
On Mon, Oct 14, 2013 at 2:28 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Oct 10, 2013 at 9:34 AM, Amit Kapila amit.kapil...@gmail.com wrote: On further analysis, I found that hang occurs in some of Windows API(FindFirstFile, RemoveDirectroy) when symlink path

Re: [HACKERS] dynamic shared memory

2013-10-14 Thread Amit Kapila
On Mon, Oct 14, 2013 at 5:11 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Oct 13, 2013 at 3:07 AM, Amit Kapila amit.kapil...@gmail.com wrote: 1. Do you think we should add information about pg_dynshmem file at link: http://www.postgresql.org/docs/devel/static/storage-file-layout.html

Re: [HACKERS] Long paths for tablespace leads to uninterruptible hang in Windows

2013-10-14 Thread Amit Kapila
On Mon, Oct 14, 2013 at 8:40 PM, Magnus Hagander mag...@hagander.net wrote: On Mon, Oct 14, 2013 at 2:28 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Oct 10, 2013 at 9:34 AM, Amit Kapila amit.kapil...@gmail.com wrote: On further analysis, I found that hang occurs in some of Windows

Re: [HACKERS] Planner issue

2013-10-14 Thread Soroosh Sardari
On Mon, Oct 14, 2013 at 10:55 AM, Tom Lane t...@sss.pgh.pa.us wrote: Soroosh Sardari soroosh.sard...@gmail.com writes: I developed a new character string type, named myvarchar. Also an operator class for btree is added. PROBLEM: When I executed a query with where clause on 'mine' column,

Re: [HACKERS] dynamic shared memory

2013-10-14 Thread Robert Haas
On Mon, Oct 14, 2013 at 11:11 AM, Amit Kapila amit.kapil...@gmail.com wrote: During test, I found one issue in Windows implementation. During startup, when it tries to create new control segment for dynamic shared memory, it loops until an unused identifier is found, but for Windows

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Josh Berkus
On 10/13/2013 01:38 AM, Gibheer wrote: So it will ensure that max_wal_senders is used for reserving connection slots from being used by non-super user connections. I find new usage of max_wal_senders acceptable, if anyone else thinks otherwise, please let us know. I think otherwise. Changing

Re: [HACKERS] Long paths for tablespace leads to uninterruptible hang in Windows

2013-10-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Oct 10, 2013 at 9:34 AM, Amit Kapila amit.kapil...@gmail.com wrote: On further analysis, I found that hang occurs in some of Windows API(FindFirstFile, RemoveDirectroy) when symlink path (pg_tblspc/spcoid/TABLESPACE_VERSION_DIRECTORY) is used

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Anyway, as Andres said, the machines were working fine until recently, so I think we just need to get them un-broken. I think you're talking past each other. What would be useful here is to find out *why* these machines are now failing, when they

Re: [HACKERS] [SQL] Comparison semantics of CHAR data type

2013-10-14 Thread Thomas Fanghaenel
On Fri, Oct 11, 2013 at 3:44 PM, Bruce Momjian br...@momjian.us wrote: You have some good questions here, though there are two interrelated things going on here. First is collation, and the second is the trimming of spaces from char() comparisons. Sorry, I should have probably mentioned more

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Andres Freund
On 2013-10-14 10:26:25 -0700, Josh Berkus wrote: On 10/13/2013 01:38 AM, Gibheer wrote: So it will ensure that max_wal_senders is used for reserving connection slots from being used by non-super user connections. I find new usage of max_wal_senders acceptable, if anyone else thinks

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Josh Berkus
On 10/14/2013 10:51 AM, Andres Freund wrote: Imo the complications around this prove my (way earlier) point that it'd be much better to treat replication connections as something entirely different to normal SQL connections. There's really not much overlap here and while there's some

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Robert Haas
On Mon, Oct 14, 2013 at 1:33 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Anyway, as Andres said, the machines were working fine until recently, so I think we just need to get them un-broken. I think you're talking past each other. What would be useful

[HACKERS] CF 2013-09 Wrap Up

2013-10-14 Thread Mike Blackwell
CF 2013-09 will be wrapping up this week. As a reminder, beginning on the official CF end date (11/15), patches Waiting for Author will be Returned with Feedback. Authors are welcome to add their patch to the next CF (2013-11). Any patches marked Needs Review will be automatically moved to the

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Peter Eisentraut
On Fri, 2013-10-11 at 15:33 -0400, Robert Haas wrote: Can the owners of these buildfarm machines please check whether there are extra semaphores allocated and if so free them? Or at least reboot, to see if that unbreaks the build? I cleaned the semaphores on smew, but they came back.

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread Peter Eisentraut
On Mon, 2013-10-14 at 23:08 +1300, David Rowley wrote: Looks like something like: #ifndef WIN32 #define HAVE_VA_COPY 1 #endif would need to be added to asprintf.c, but also some work needs to be done with mcxt.c as it uses va_copy unconditionally. Perhaps just defining a macro

Re: [HACKERS] Auto-tuning work_mem and maintenance_work_mem

2013-10-14 Thread Jim Nasby
On 10/14/13 8:18 AM, Robert Haas wrote: On Sat, Oct 12, 2013 at 3:07 AM, Magnus Hagander mag...@hagander.net wrote: On Oct 11, 2013 10:23 PM, Josh Berkus j...@agliodbs.com wrote: On 10/11/2013 01:11 PM, Bruce Momjian wrote: In summary, I think we need to: * decide on new defaults for

Re: [HACKERS] logical changeset generation v6.2

2013-10-14 Thread Andres Freund
On 2013-10-14 15:51:14 +0200, Andres Freund wrote: It'd probably not hurt to redo those benchmarks to make sure... Yes, I think it would be good to characterize it more precisely than a bit, so people know what to expect. A bit was below the 3% range for loops of adding columns.

Re: [HACKERS] Triggers on foreign tables

2013-10-14 Thread Kohei KaiGai
2013/10/13 Ronan Dunklau rdunk...@gmail.com: Le samedi 12 octobre 2013 07:30:35 Kohei KaiGai a écrit : 2013/10/10 Ronan Dunklau rdunk...@gmail.com: Sorry, I'm uncertain the point above. Are you saying FDW driver may be able to handle well a case when a remote tuple to be updated is different

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Josh Kupershmidt
On Thu, Oct 10, 2013 at 12:54 PM, Andrew Dunstan and...@dunslane.net wrote: This thread seems to have gone cold, but I'm inclined to agree with Pavel. If the table doesn't exist, neither does the trigger, and the whole point of the 'IF EXISTS' variants is to provide the ability to issue DROP

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Andres Freund
On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote: On 09/19/2013 06:12 PM, Pavel Stehule wrote: 2013/9/16 Satoshi Nagayasu sn...@uptime.jp mailto:sn...@uptime.jp I'm looking at this patch, and I have a question here. Should DROP TRIGGER IF EXISTS ignore error for

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Andrew Dunstan
On 10/14/2013 05:44 PM, Andres Freund wrote: On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote: On 09/19/2013 06:12 PM, Pavel Stehule wrote: 2013/9/16 Satoshi Nagayasu sn...@uptime.jp mailto:sn...@uptime.jp I'm looking at this patch, and I have a question here. Should DROP

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Andres Freund
On 2013-10-14 17:59:25 -0400, Andrew Dunstan wrote: On 10/14/2013 05:44 PM, Andres Freund wrote: On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote: On 09/19/2013 06:12 PM, Pavel Stehule wrote: 2013/9/16 Satoshi Nagayasu sn...@uptime.jp mailto:sn...@uptime.jp I'm looking at this

Re: [HACKERS] Improving avg performance for numeric

2013-10-14 Thread Tomas Vondra
On 24.9.2013 17:57, Pavel Stehule wrote: 2013/9/24 Robert Haas robertmh...@gmail.com mailto:robertmh...@gmail.com On Mon, Sep 23, 2013 at 4:15 PM, Tomas Vondra t...@fuzzy.cz mailto:t...@fuzzy.cz wrote: Seems ready for commiter to me. I'll wait a few days for others to comment, and

Re: [HACKERS] buildfarm failures on smew and anole

2013-10-14 Thread Robert Haas
On Mon, Oct 14, 2013 at 4:29 PM, Peter Eisentraut pete...@gmx.net wrote: On Fri, 2013-10-11 at 15:33 -0400, Robert Haas wrote: Can the owners of these buildfarm machines please check whether there are extra semaphores allocated and if so free them? Or at least reboot, to see if that unbreaks

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Tomas Vondra
Hi, On 14.10.2013 23:44, Andres Freund wrote: On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote: On 09/19/2013 06:12 PM, Pavel Stehule wrote: 2013/9/16 Satoshi Nagayasu sn...@uptime.jp mailto:sn...@uptime.jp I'm looking at this patch, and I have a question here. Should DROP TRIGGER IF

Re: [HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-10-14 Thread Andres Freund
On 2013-10-15 00:23:15 +0200, Tomas Vondra wrote: Hi, On 14.10.2013 23:44, Andres Freund wrote: On 2013-10-10 12:54:23 -0400, Andrew Dunstan wrote: On 09/19/2013 06:12 PM, Pavel Stehule wrote: 2013/9/16 Satoshi Nagayasu sn...@uptime.jp mailto:sn...@uptime.jp I'm looking at this

Re: [HACKERS] Compression of full-page-writes

2013-10-14 Thread KONDO Mitsumasa
(2013/10/13 0:14), Amit Kapila wrote: On Fri, Oct 11, 2013 at 10:36 PM, Andres Freund and...@2ndquadrant.com wrote: But maybe pglz is just not a good fit for this, it really isn't a very good algorithm in this day and aage. +1. This compression algorithm is needed more faster than pglz which is

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Amit Kapila
On Mon, Oct 14, 2013 at 10:56 PM, Josh Berkus j...@agliodbs.com wrote: On 10/13/2013 01:38 AM, Gibheer wrote: So it will ensure that max_wal_senders is used for reserving connection slots from being used by non-super user connections. I find new usage of max_wal_senders acceptable, if anyone

Re: [HACKERS] Patch for reserved connections for replication users

2013-10-14 Thread Amit Kapila
On Mon, Oct 14, 2013 at 11:21 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-10-14 10:26:25 -0700, Josh Berkus wrote: On 10/13/2013 01:38 AM, Gibheer wrote: So it will ensure that max_wal_senders is used for reserving connection slots from being used by non-super user connections. I

Re: [HACKERS] psql tab completion for updatable foreign tables

2013-10-14 Thread Pavan Deolasee
On Mon, Oct 14, 2013 at 7:20 PM, Samrat Revagade revagade.sam...@gmail.comwrote: Sorry .my environment has some problem. May be you were using old version of psql ? IIRC tab-completion relies heavily on the psql side, Thanks, Pavan -- Pavan Deolasee http://www.linkedin.com/in/pavandeolasee

Re: [HACKERS] Compression of full-page-writes

2013-10-14 Thread Amit Kapila
On Tue, Oct 15, 2013 at 6:30 AM, KONDO Mitsumasa kondo.mitsum...@lab.ntt.co.jp wrote: (2013/10/13 0:14), Amit Kapila wrote: On Fri, Oct 11, 2013 at 10:36 PM, Andres Freund and...@2ndquadrant.com wrote: But maybe pglz is just not a good fit for this, it really isn't a very good algorithm in

Re: [HACKERS] Release note fix for timeline item

2013-10-14 Thread KONDO Mitsumasa
Sorry for my reply late... (2013/10/08 23:26), Bruce Momjian wrote: First, I want to apologize for not completing the release notes earlier so that others could review them. I started working on the release notes on Friday, but my unfamiliarity with the process and fear of making a mistake

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread Amit Kapila
On Tue, Oct 15, 2013 at 2:18 AM, Peter Eisentraut pete...@gmx.net wrote: On Mon, 2013-10-14 at 23:08 +1300, David Rowley wrote: Looks like something like: #ifndef WIN32 #define HAVE_VA_COPY 1 #endif would need to be added to asprintf.c, but also some work needs to be done with mcxt.c

Re: [HACKERS] CREATE FOREIGN TABLE ( ... LIKE ... )

2013-10-14 Thread David Fetter
On Mon, Oct 07, 2013 at 11:16:56PM -0700, David Fetter wrote: Folks, Please find attached a patch implementing and documenting, to some extent, $subject. I did this in aid of being able to import SQL standard catalogs and other entities where a known example could provide a template for a

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread Asif Naeem
+1 I think you can safely use va_list without copy on Windows. va_copy is available in Visual Studio 2013 as part of support for C99, previous versions don't have it. Regards, Muhammad Asif Naeem On Tue, Oct 15, 2013 at 10:33 AM, Amit Kapila amit.kapil...@gmail.comwrote: On Tue, Oct 15, 2013

Re: [HACKERS] [PATCH] Add use of asprintf()

2013-10-14 Thread David Rowley
On Tue, Oct 15, 2013 at 9:48 AM, Peter Eisentraut pete...@gmx.net wrote: On Mon, 2013-10-14 at 23:08 +1300, David Rowley wrote: Looks like something like: #ifndef WIN32 #define HAVE_VA_COPY 1 #endif would need to be added to asprintf.c, but also some work needs to be done