Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2014-01-28 Thread KONDO Mitsumasa
(2014/01/29 15:51), Tom Lane wrote: > KONDO Mitsumasa writes: >> By the way, latest pg_stat_statement might affect performance in Windows >> system. >> Because it uses fflush() system call every creating new entry in >> pg_stat_statements, and it calls many fread() to warm file cache. > This stat

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2014-01-28 Thread Peter Geoghegan
On Tue, Jan 28, 2014 at 10:51 PM, Tom Lane wrote: > KONDO Mitsumasa writes: >> By the way, latest pg_stat_statement might affect performance in Windows >> system. >> Because it uses fflush() system call every creating new entry in >> pg_stat_statements, and it calls many fread() to warm file cac

Re: [HACKERS] drop duplicate buffers in OS

2014-01-28 Thread KONDO Mitsumasa
Hi, Attached is latest patch. I change little bit at PinBuffer() in bufmgr.c. It will evict target clean file cache in OS more exactly. - if (!(buf->flags & BM_FADVED) && !(buf->flags & BM_JUST_DIRTIED)) + if (!(buf->flags & BM_DIRTY) && !(buf->flags & BM_FADVED) && !(buf->flags & BM_JUST_DIR

Re: [HACKERS] WIP patch (v2) for updatable security barrier views

2014-01-28 Thread Kouhei Kaigai
> Kouhei Kaigai writes: > > Let me ask an elemental question. What is the reason why inheritance > > expansion logic should be located on the planner stage, not on the > > tail of rewriter? > > I think it's mostly historical. You would however have to think of a way > to preserve the inheritance

[HACKERS] Re: Patch: regexp_matches variant returning an array of matching positions

2014-01-28 Thread David Johnston
Erik Rijkers wrote > On Wed, January 29, 2014 05:16, David Johnston wrote: >> >> How does this resolve in the patch? >> >> SELECT regexp_matches('abcabc','((a)(b)(c))','g'); >> > > With the patch: > > testdb=# SELECT regexp_matches('abcabc','((a)(b)(c))','g'), > regexp_matches_positions('abcabc',

Re: [HACKERS] Re: Patch: regexp_matches variant returning an array of matching positions

2014-01-28 Thread Erik Rijkers
On Wed, January 29, 2014 05:16, David Johnston wrote: > > How does this resolve in the patch? > > SELECT regexp_matches('abcabc','((a)(b)(c))','g'); > With the patch: testdb=# SELECT regexp_matches('abcabc','((a)(b)(c))','g'), regexp_matches_positions('abcabc','((a)(b)(c))'); regexp_matches | r

Re: [HACKERS] Add min and max execute statement time in pg_stat_statement

2014-01-28 Thread Tom Lane
KONDO Mitsumasa writes: > By the way, latest pg_stat_statement might affect performance in Windows > system. > Because it uses fflush() system call every creating new entry in > pg_stat_statements, and it calls many fread() to warm file cache. This statement doesn't seem to have much to do wit

Re: [HACKERS] WIP patch (v2) for updatable security barrier views

2014-01-28 Thread Tom Lane
Kouhei Kaigai writes: > Let me ask an elemental question. What is the reason why inheritance > expansion logic should be located on the planner stage, not on the tail > of rewriter? I think it's mostly historical. You would however have to think of a way to preserve the inheritance relationships

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Tom Lane
Robert Haas writes: > If this only affects a handful of places, then sure, let's go ahead > and fix it. But if it's going to create a massive enough diff that > we've gotta think about back-patching it, then IMHO it's totally not > worth it. A quick grep search says there are well over 3000 comm

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Tom Lane
Robert Haas writes: > On Tue, Jan 28, 2014 at 12:36 PM, Alvaro Herrera > wrote: >> Honestly, I would prefer that we push a patch that has been thoroughly >> reviewed and in which we have more confidence, so that we can push >> without a GUC. This means mark in CF as needs-review, then some other

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.2

2014-01-28 Thread Peter Geoghegan
On Fri, Nov 15, 2013 at 11:47 AM, Andres Freund wrote: > 1) I've added an abstracted atomic ops implementation. Needs a fair >amount of work, also submitted as a separate CF entry. (Patch 1 & 2) Commit 220b34331f77effdb46798ddd7cca0cffc1b2858 caused bitrot when applying 0002-Very-basic-atomic

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-01-28 Thread Amit Kapila
On Tue, Jan 28, 2014 at 4:42 PM, Kyotaro HORIGUCHI wrote: > Hello, > >> Currently there is no way user can keep the dsm >> segments if he wants for postmaster lifetime, so I >> have exposed a new API dsm_keep_segment() >> to implement the same. > > I had a short look on this patch. Thanks. >

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 12:36 PM, Alvaro Herrera wrote: > Bruce Momjian escribió: >> > I have no problem removing the parameter if required to. In that case, >> > I would like to leave the parameter in until mid beta, to allow >> > greater certainty. > > Uhm. If we remove a GUC during beta we don

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-01-28 Thread Amit Kapila
On Fri, Jan 24, 2014 at 4:38 PM, MauMau wrote: > >> How about below message: >> >> event source "" is already registered. >> OK, I added several lines for this. Please check the attached patch. It gives the proper message, but even after error, the second message box it shows "DLLInstall ... s

Re: [HACKERS] Add force option to dropdb

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 9:01 AM, salah jubeh wrote: > Hello Sawada, > >>- This patch is not patched to master branch > Sorry, My mistake >>//new connections are not allowed > Corrected. > > I hope now the patch in better state, if somthing left, I will be glad to > fix it > Regards I'm not partic

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Andres Freund
On 2014-01-28 18:39:43 -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > I see I already asked about entab -s 3. Let me see how hard it would be > > to modify entab. > > I cannot tell you what to waste your time on, of course, but I wonder if > it'd be better spent trying to make somet

Re: [HACKERS] Observed Compilation warning in WIN32 build

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 6:28 AM, Andres Freund wrote: > On 2014-01-28 09:13:15 +, Rajeev rastogi wrote: >> I observed below WIN32 compilation warnings in postmaster.c (seems >> introduced by commit ea9df812d8502fff74e7bc37d61bdc7d66d77a7f "Relax the >> requirement that all lwlocks be stored

[HACKERS] Re: Patch: regexp_matches variant returning an array of matching positions

2014-01-28 Thread David Johnston
Alvaro Herrera-9 wrote > Björn Harrtell wrote: >> I've written a variant of regexp_matches called regexp_matches_positions >> which instead of returning matching substrings will return matching >> positions. I found use of this when processing OCR scanned text and >> wanted >> to prioritize matches

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 11:03 PM, Tom Lane wrote: > Bruce Momjian writes: >> On Tue, Jan 28, 2014 at 10:40:10PM -0500, Tom Lane wrote: >>> TBH I'm not sure we should be changing pgindent at this late date, even if >>> there is a good fix for its minor annoyances. When you changed its wrap >>> be

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 7:43 PM, Andreas Karlsson wrote: > I think "physical" and "logical" are fine and they seem to be well known > terminology. Oracle uses those words and I have also seen many places use > "physical backup" and "logical backup", for example on Barman's homepage. There's certa

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Tom Lane
Bruce Momjian writes: > On Tue, Jan 28, 2014 at 10:40:10PM -0500, Tom Lane wrote: >> TBH I'm not sure we should be changing pgindent at this late date, even if >> there is a good fix for its minor annoyances. When you changed its wrap >> behavior in 8.1, I spent the next several years cursing tha

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Bruce Momjian
On Tue, Jan 28, 2014 at 10:40:10PM -0500, Tom Lane wrote: > Bruce Momjian writes: > > I see I already asked about entab -s 3. Let me see how hard it would be > > to modify entab. > > TBH I'm not sure we should be changing pgindent at this late date, even if > there is a good fix for its minor an

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Tom Lane
Bruce Momjian writes: > I see I already asked about entab -s 3. Let me see how hard it would be > to modify entab. TBH I'm not sure we should be changing pgindent at this late date, even if there is a good fix for its minor annoyances. When you changed its wrap behavior in 8.1, I spent the next

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Bruce Momjian
On Tue, Jan 28, 2014 at 06:39:43PM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > > > I see I already asked about entab -s 3. Let me see how hard it would be > > to modify entab. > > I cannot tell you what to waste your time on, of course, but I wonder if > it'd be better spent trying t

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 6:12 AM, Kyotaro HORIGUCHI wrote: > I had a short look on this patch. > > - DSM implimentation seems divided into generic part (dsm.c) and >platform dependent part(dsm_impl.c). This dsm_keep_segment >puts WIN32 specific part directly into dms.c. I suppose it'd >

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Tom Lane
Andres Freund writes: >> Absolutely. Probably best to save errno into a local just before the >> ereport. > I think just resetting to edata->saved_errno is better and sufficient? -1 --- that field is nobody's business except elog.c's. regards, tom lane -- Sent via pg

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Michael Paquier
On Wed, Jan 29, 2014 at 10:55 AM, Fujii Masao wrote: > On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera > wrote: >> >> Anybody knows about this patch? >> http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp > > Though I'm not sure whether Nagayasu is still working on that patch, > it's

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Fujii Masao
On Wed, Jan 29, 2014 at 3:07 AM, Alvaro Herrera wrote: > > Anybody knows about this patch? > http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp Though I'm not sure whether Nagayasu is still working on that patch, it's worth thinking to introduce that together with pg_stat_archiver.

Re: [HACKERS] Weird error messages from Windows upon client death

2014-01-28 Thread Florian Pflug
On Jan28, 2014, at 19:19 , Jeff Janes wrote: > On windows, if the client gets terminated while sending data to the server, > in a > COPY for example, it results in some rather head-scratcher messages in the > server > log, for example: > > LOG: could not receive data from client: No connection

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Michael Paquier
On Wed, Jan 29, 2014 at 3:03 AM, Fujii Masao wrote: > On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao wrote: >> On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier >> wrote: >>> On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao wrote: On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier wrote:

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Andreas Karlsson
On 01/28/2014 10:56 PM, Andres Freund wrote: On 2014-01-28 21:48:09 +, Thom Brown wrote: On 28 January 2014 21:37, Robert Haas wrote: On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas wrote: The point of Andres's patch set is to introduce a new technology called logical decoding; that is, the

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Alvaro Herrera
Bruce Momjian wrote: > > I see I already asked about entab -s 3. Let me see how hard it would be > to modify entab. I cannot tell you what to waste your time on, of course, but I wonder if it'd be better spent trying to make something like astyle work for us. The entab/pg_bsd_indent combo is a b

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Alvaro Herrera
Stephen Frost wrote: > * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > > Well, we already have Coverity reports and the VIVA64 stuff posted last > > month. Did they not see these problems? Maybe they did, maybe not, but > > since there's a large number of false positives it's hard to tell.

Re: [HACKERS] drop duplicate buffers in OS

2014-01-28 Thread Jeff Janes
On Wed, Jan 15, 2014 at 10:34 AM, Robert Haas wrote: > On Wed, Jan 15, 2014 at 1:53 AM, KONDO Mitsumasa > wrote: > > I create patch that can drop duplicate buffers in OS using usage_count > > alogorithm. I have developed this patch since last summer. This feature > seems to > > be discussed in h

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread David Fetter
On Tue, Jan 28, 2014 at 05:31:25PM -0500, Rod Taylor wrote: > On Tue, Jan 28, 2014 at 4:56 PM, Andres Freund wrote: > > > On 2014-01-28 21:48:09 +, Thom Brown wrote: > > > On 28 January 2014 21:37, Robert Haas wrote: > > > > On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas > > wrote: > > > >> I

Re: [HACKERS] new json funcs

2014-01-28 Thread Andrew Dunstan
On 01/28/2014 05:07 PM, Marko Tiikkaja wrote: Hi Andrew, On 1/24/14, 7:26 PM, Andrew Dunstan wrote: OK, here's the patch, this time with docs, thanks to Merlin Moncure and Josh Berkus for help with that. Thanks, this one is looking pretty good. A couple of small issues: - The oid 3195 of

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Rod Taylor
On Tue, Jan 28, 2014 at 4:56 PM, Andres Freund wrote: > On 2014-01-28 21:48:09 +, Thom Brown wrote: > > On 28 January 2014 21:37, Robert Haas wrote: > > > On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas > wrote: > > >> I've rebased it here and am hacking on it still. > > > > > > Andres and I a

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Thom Brown
On 28 January 2014 21:56, Andres Freund wrote: > On 2014-01-28 21:48:09 +, Thom Brown wrote: >> On 28 January 2014 21:37, Robert Haas wrote: >> > On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas >> > wrote: >> >> I've rebased it here and am hacking on it still. >> > >> > Andres and I are going

Re: [HACKERS] new json funcs

2014-01-28 Thread Marko Tiikkaja
Hi Andrew, On 1/24/14, 7:26 PM, Andrew Dunstan wrote: OK, here's the patch, this time with docs, thanks to Merlin Moncure and Josh Berkus for help with that. Thanks, this one is looking pretty good. A couple of small issues: - The oid 3195 of json_object_agg_transfn has been taken by a rec

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Well, we already have Coverity reports and the VIVA64 stuff posted last > month. Did they not see these problems? Maybe they did, maybe not, but > since there's a large number of false positives it's hard to tell. I > don't know how many false

Re: [HACKERS] Fwd: Request for error explaination || Adding a new integer in indextupleData Structure

2014-01-28 Thread Rohit Goyal
> > Hello, >> >> I started all the process again and configured my eclipse with raw >> postgresql code. First change i made in the code is >> >> I added *int i; *in indextupleData structure in itup.h. >> > > You should show us *exactly* where you added it. (Doing so is what "diff" > was developed

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Andres Freund
On 2014-01-28 21:48:09 +, Thom Brown wrote: > On 28 January 2014 21:37, Robert Haas wrote: > > On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas wrote: > >> I've rebased it here and am hacking on it still. > > > > Andres and I are going back and forth between our respective git repos > > hacking

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Thom Brown
On 28 January 2014 21:37, Robert Haas wrote: > On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas wrote: >> I've rebased it here and am hacking on it still. > > Andres and I are going back and forth between our respective git repos > hacking on this, and I think we're getting there, but I have a > ter

Re: [HACKERS] Changeset Extraction v7.3

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 11:53 AM, Robert Haas wrote: > I've rebased it here and am hacking on it still. Andres and I are going back and forth between our respective git repos hacking on this, and I think we're getting there, but I have a terminological question which I'd like to submit to a wider

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Andres Freund
On 2014-01-28 18:31:59 -0300, Alvaro Herrera wrote: > Jason Petersen wrote: > > I realize Postgres’ codebase is probably intractably large to begin > > using a tool like splint (http://www.splint.org ), but this is exactly > > the sort of thing it’ll catch. I’m pretty sure it would have warned in >

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Bruce Momjian
On Thu, Jun 27, 2013 at 09:54:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Should we be using entab -s 3? > > IIUC, that wouldn't affect leading whitespace at all. What it would > affect I think (outside of comment blocks) is whitespace between code > and a same-line /* ... */ comment

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Alvaro Herrera
Jason Petersen wrote: > I realize Postgres’ codebase is probably intractably large to begin > using a tool like splint (http://www.splint.org ), but this is exactly > the sort of thing it’ll catch. I’m pretty sure it would have warned in > this case that the code relies on an ordering of side effec

Re: [HACKERS] updated emacs configuration

2014-01-28 Thread Bruce Momjian
On Thu, Jun 27, 2013 at 05:31:54PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > Noah Misch wrote: > >> Note that emacs and pgindent remain at odds over interior tabs in comments. > >> When pgindent finds a double-space (typically after a sentence) ending at a > >> tab stop, it replaces the

Re: [HACKERS] WIP patch (v2) for updatable security barrier views

2014-01-28 Thread Robert Haas
On Tue, Jan 28, 2014 at 5:02 AM, Simon Riggs wrote: > I agree that this is being seen the wrong way around. The planner > contains things it should not do, and as a result we are now > discussing enhancing the code that is in the wrong place, which of > course brings objections. > > I think we wou

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Andres Freund
On 2014-01-28 16:19:11 -0500, Tom Lane wrote: > Christian Kruse writes: > > According to http://llvm.org/bugs/show_bug.cgi?id=18644#c5 this is not > > a compiler bug but a difference between gcc and clang. Clang seems to > > use a left-to-right order of evaluation while gcc uses a right-to-left >

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Jason Petersen
I realize Postgres’ codebase is probably intractably large to begin using a tool like splint (http://www.splint.org ), but this is exactly the sort of thing it’ll catch. I’m pretty sure it would have warned in this case that the code relies on an ordering of side effects that is left undefined b

Re: [HACKERS] Patch: regexp_matches variant returning an array of matching positions

2014-01-28 Thread Alvaro Herrera
Björn Harrtell wrote: > I've written a variant of regexp_matches called regexp_matches_positions > which instead of returning matching substrings will return matching > positions. I found use of this when processing OCR scanned text and wanted > to prioritize matches based on their position. Inter

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Tom Lane
Christian Kruse writes: > According to http://llvm.org/bugs/show_bug.cgi?id=18644#c5 this is not > a compiler bug but a difference between gcc and clang. Clang seems to > use a left-to-right order of evaluation while gcc uses a right-to-left > order of evaluation. So if errmsg changes errno this w

Re: [HACKERS] Suspicion of a compiler bug in clang: using ternary operator in ereport()

2014-01-28 Thread Christian Kruse
Hi, On 28/01/14 16:43, Christian Kruse wrote: > ereport(FATAL, > (errmsg("could not map anonymous shared memory: > %m"), >(errno == ENOMEM) ? >errhint("This error usually means that > Post

Re: [HACKERS] fixing pg_ctl with relative paths

2014-01-28 Thread Bruce Momjian
On Mon, Jul 1, 2013 at 08:10:14PM -0400, Josh Kupershmidt wrote: > On Thu, Jun 27, 2013 at 11:47 AM, Fujii Masao wrote: > > On Thu, Jun 27, 2013 at 10:36 AM, Josh Kupershmidt > > wrote: > >> On Wed, Jun 26, 2013 at 12:22 PM, Fujii Masao > >> wrote: > >>> Though this is a corner case, the patc

Re: [HACKERS] new json funcs

2014-01-28 Thread Andrew Dunstan
On 01/28/2014 01:22 PM, Alvaro Herrera wrote: Josh Berkus wrote: On 01/27/2014 01:06 PM, Alvaro Herrera wrote: Andrew Dunstan escribió: I'm not sure I understand the need. This is the difference between the _text variants and their parents. Why would you call json_object_field when you want

Re: [HACKERS] Planning time in explain/explain analyze

2014-01-28 Thread Tom Lane
Robert Haas writes: > On Thu, Jan 9, 2014 at 11:45 PM, Tom Lane wrote: >> Uh, no, wasn't my suggestion. Doesn't that design imply measuring *every* >> planning cycle, explain or no? I was thinking more of just putting the >> timing calls into explain.c. > The problem is that you really can't d

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Stephen Frost
Greg, * Greg Stark (st...@mit.edu) wrote: > On Tue, Jan 28, 2014 at 11:56 AM, Josh Berkus wrote: > > For example, I would really like to GRANT an unpriv user access to the > > WAL columns in pg_stat_replication so that I can monitor replication > > delay without granting superuser permissions. >

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2014-01-28 Thread Florian Pflug
On Jan27, 2014, at 23:28 , Dean Rasheed wrote: > strict transfn vs non-strict inv_transfn > > > This case is explicitly forbidden, both in CREATE AGGREGATE and in the > executor. To me, that seems overly restrictive --- if transfn is > strict, then you kno

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Josh Berkus
On 01/28/2014 12:10 PM, Tom Lane wrote: > Josh Berkus writes: >> For example, I would really like to GRANT an unpriv user access to the >> WAL columns in pg_stat_replication so that I can monitor replication >> delay without granting superuser permissions. > > Just out of curiosity, why is that s

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Stephen Frost
Josh, * Josh Berkus (j...@agliodbs.com) wrote: > Really the only way we're going to solve this is to make column > permissions on special system views fully configurable. We really need to fully support column and row-level security to provide the kind of granularty which we do today (but force o

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Tom Lane
Josh Berkus writes: > For example, I would really like to GRANT an unpriv user access to the > WAL columns in pg_stat_replication so that I can monitor replication > delay without granting superuser permissions. Just out of curiosity, why is that superuser-only at all? AFAICS the hidden columns

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Greg Stark
On Tue, Jan 28, 2014 at 11:56 AM, Josh Berkus wrote: > Really the only way we're going to solve this is to make column > permissions on special system views fully configurable. > > For example, I would really like to GRANT an unpriv user access to the > WAL columns in pg_stat_replication so that I

Re: [HACKERS] Fwd: Request for error explaination || Adding a new integer in indextupleData Structure

2014-01-28 Thread Jeff Janes
On Tue, Jan 28, 2014 at 10:57 AM, Rohit Goyal wrote: Hello, > > I started all the process again and configured my eclipse with raw > postgresql code. First change i made in the code is > > I added *int i; *in indextupleData structure in itup.h. > You should show us *exactly* where you added it.

Re: [HACKERS] UNION ALL on partitioned tables won't use indices.

2014-01-28 Thread Noah Misch
On Tue, Jan 28, 2014 at 06:53:32PM +0900, Kyotaro HORIGUCHI wrote: > Hello, Thank you, and I' sorry to have kept you waiting. No hurry. > > > The attached two patches are rebased to current 9.4dev HEAD and > > > make check at the topmost directory and src/test/isolation are > > > passed without e

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Josh Berkus
On 01/28/2014 07:27 AM, Greg Stark wrote: > Why is application_name useful for users who aren't the DBA and aren't > the user in question. The sql_query would probably be more useful than > application_name but we hide that... I have non-privileged monitoring scripts do counts of connections by ap

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Greg Stark
On Tue, Jan 28, 2014 at 11:28 AM, Greg Stark wrote: > Well maybe. Or we want this useful information at a finer granularity > than "everyone or nobody" and given the choice we prefer to have it > than not. Anyways, I don't feel incredibly strongly about this. I think we should default any user-da

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Thom Brown
On 28 January 2014 19:43, Stephen Frost wrote: > Thom, > > * Thom Brown (t...@linux.com) wrote: >> Application to Google Summer of Code 2014 can be made as of next >> Monday (3rd Feb), and then there will be a 12 day window in which to >> submit an application. > > This is just for PG to be a part

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Maxence AHLOUCHE
Hi all, I'd very interesting in taking part in the GSoC with PostgreSQL, as a student. Being quite busy at the moment (exam time), I haven't had time to think of a subject yet, even though I could see some topics I found interesting. 2014-01-28 Josh Berkus > On 01/28/2014 09:46 AM, Atri Sharma

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Stephen Frost
Thom, * Thom Brown (t...@linux.com) wrote: > Application to Google Summer of Code 2014 can be made as of next > Monday (3rd Feb), and then there will be a 12 day window in which to > submit an application. This is just for PG to be a participating organization, right? There's a while before ment

Re: [HACKERS] proposal: hide application_name from other users

2014-01-28 Thread Greg Stark
On Tue, Jan 28, 2014 at 7:49 AM, Tom Lane wrote: > Oh really. So, to clean up after their own ill-considered decision, > they'd like to take useful information away from everybody. Well maybe. Or we want this useful information at a finer granularity than "everyone or nobody" and given the choic

[HACKERS] Patch: regexp_matches variant returning an array of matching positions

2014-01-28 Thread Björn Harrtell
I've written a variant of regexp_matches called regexp_matches_positions which instead of returning matching substrings will return matching positions. I found use of this when processing OCR scanned text and wanted to prioritize matches based on their position. The patch is for discussion. I'd al

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Josh Berkus
On 01/28/2014 10:56 AM, Alvaro Herrera wrote: > Josh Berkus escribió: > >> Or is this just about whitespace and line breaks? > > If the docs are going to be rehauled, please ignore my whitespace > comments. I'm sure you'll find plenty to criticize in my version. ;-) -- Josh Berkus PostgreSQL

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Alvaro Herrera
Josh Berkus escribió: > Or is this just about whitespace and line breaks? If the docs are going to be rehauled, please ignore my whitespace comments. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hacke

Re: [HACKERS] Fwd: Request for error explaination || Adding a new integer in indextupleData Structure

2014-01-28 Thread Rohit Goyal
> > Rohit Goyal writes: >> > Hi All, >> > I was trying to modify indextupledata structure by adding an integer >> > variable. ButI faced an error message "psql: FATAL: could not find >> tuple >> > for opclass 10032". >> >> > Could anyone please help me in resolving this issue. >> >> You broke a s

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Josh Berkus
On 01/28/2014 10:29 AM, Merlin Moncure wrote: >> In addition to this, the JSON vs JSONB datatype page really needs >> expansion and clarification. > > right: exactly. I'd be happy to help (such as I can) ...I wanted to > see if jsonb to make it in on this 'fest (doc issues notwithstanding); > it

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Josh Berkus
On 01/28/2014 09:46 AM, Atri Sharma wrote: > I would like to bring up the addition to MADLIB algorithms again this year. > > Also, some work on the foreign table constraints could be helpful. We can only take MADLIB this year if we have confirmed mentors who are MADLIB committers before the end o

Re: [HACKERS] alternative back-end block formats

2014-01-28 Thread Christian Convey
On Tue, Jan 28, 2014 at 12:39 PM, Tom Lane wrote: > TBH, I'd rather we waited till the commitfest is over. This is certainly > material for 9.5, if not even further out, so there's no pressing need for > a debate right now; and we have plenty of stuff we do need to deal with > right now. Works

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Merlin Moncure
On Tue, Jan 28, 2014 at 12:09 PM, Josh Berkus wrote: > On 01/28/2014 09:58 AM, Merlin Moncure wrote: >> yeah. note: I think the json documentation needs *major* overhaul. too >> much is going in inside the function listings where there really >> should be a big breakout discussing the "big picture

Re: [HACKERS] new json funcs

2014-01-28 Thread Alvaro Herrera
Josh Berkus wrote: > On 01/27/2014 01:06 PM, Alvaro Herrera wrote: > > Andrew Dunstan escribió: > > > >> I'm not sure I understand the need. This is the difference between > >> the _text variants and their parents. Why would you call > >> json_object_field when you want the dequoted text? > > > >

[HACKERS] Weird error messages from Windows upon client death

2014-01-28 Thread Jeff Janes
On windows, if the client gets terminated while sending data to the server, in a COPY for example, it results in some rather head-scratcher messages in the server log, for example: LOG: could not receive data from client: No connection could be made because the target machine actively refused it.

Re: [HACKERS] new json funcs

2014-01-28 Thread Josh Berkus
On 01/27/2014 01:06 PM, Alvaro Herrera wrote: > Andrew Dunstan escribió: > >> I'm not sure I understand the need. This is the difference between >> the _text variants and their parents. Why would you call >> json_object_field when you want the dequoted text? > > Because I first need to know its t

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Josh Berkus
On 01/28/2014 09:58 AM, Merlin Moncure wrote: > yeah. note: I think the json documentation needs *major* overhaul. too > much is going in inside the function listings where there really > should be a big breakout discussing the "big picture" of json/jsonb > with examples of various use cases. I wa

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Alvaro Herrera
Anybody knows about this patch? http://www.postgresql.org/message-id/508dfec9.4020...@uptime.jp -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] [PATCH] Support for pg_stat_archiver view

2014-01-28 Thread Fujii Masao
On Tue, Jan 28, 2014 at 3:42 AM, Fujii Masao wrote: > On Sat, Jan 25, 2014 at 3:19 PM, Michael Paquier > wrote: >> On Sat, Jan 25, 2014 at 5:41 AM, Fujii Masao wrote: >>> On Thu, Jan 23, 2014 at 4:10 PM, Michael Paquier >>> wrote: On Thu, Jan 9, 2014 at 6:36 AM, Gabriele Bartolini wr

Re: [HACKERS] jsonb and nested hstore

2014-01-28 Thread Merlin Moncure
On Tue, Jan 28, 2014 at 10:46 AM, Andrew Dunstan wrote: > > On 01/28/2014 11:29 AM, Tom Lane wrote: >> >> Andrew Dunstan writes: >>> >>> The problem is not the indexterm element, it's the space that might >>> exist outside it. Are we using block level elements like inside >>> entry elements anyw

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Simon Riggs
On 28 January 2014 17:21, Heikki Linnakangas wrote: > I don't understand why anyone would want to turn this feature off, ie. > require stronger locks than necessary for a DDL change. Nobody would *want* to turn it off. They might need to, as explained. > If we're not confident that the patch is

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Andres Freund
On 2014-01-27 15:25:22 -0500, Robert Haas wrote: > On Mon, Jan 27, 2014 at 12:58 PM, Simon Riggs wrote: > > This version adds a GUC called ddl_exclusive_locks which allows us to > > keep the 9.3 behaviour if we wish it. Some people may be surprised > > that their programs don't wait in the same pl

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Atri Sharma
On Tue, Jan 28, 2014 at 11:16 PM, Atri Sharma wrote: > > > On Tue, Jan 28, 2014 at 11:04 PM, Thom Brown wrote: > >> Hi all, >> >> Application to Google Summer of Code 2014 can be made as of next >> Monday (3rd Feb), and then there will be a 12 day window in which to >> submit an application. >>

Re: [HACKERS] [pgsql-advocacy] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Atri Sharma
On Tue, Jan 28, 2014 at 11:04 PM, Thom Brown wrote: > Hi all, > > Application to Google Summer of Code 2014 can be made as of next > Monday (3rd Feb), and then there will be a 12 day window in which to > submit an application. > > I'd like to gauge interest from both mentors and students as to >

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Simon Riggs
On 28 January 2014 17:15, Bruce Momjian wrote: > On Tue, Jan 28, 2014 at 04:36:39PM +, Simon Riggs wrote: >> For me, reducing the strength of DDL locking is a major change in >> RDBMS behaviour that could both delight and surprise our users. Maybe >> a few actually depend upon the locking beha

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Tom Lane
Alvaro Herrera writes: > Honestly, I would prefer that we push a patch that has been thoroughly > reviewed and in which we have more confidence, so that we can push > without a GUC. This means mark in CF as needs-review, then some other > developer reviews it and marks it as ready-for-committer.

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Alvaro Herrera
Bruce Momjian escribió: > > I have no problem removing the parameter if required to. In that case, > > I would like to leave the parameter in until mid beta, to allow > > greater certainty. Uhm. If we remove a GUC during beta we don't need to force an initdb. At worst we will need to keep a no-o

Re: [HACKERS] A minor correction in comment in heaptuple.c

2014-01-28 Thread Bruce Momjian
On Tue, Jan 28, 2014 at 06:30:40PM +0100, Andres Freund wrote: > > OK, reverted. I have to question how well-balanced we are when a word > > change in a C comment can cause so much contention. > > The question is rather why to do such busywork changes in the first > place imo. Without ever lookin

Re: [HACKERS] alternative back-end block formats

2014-01-28 Thread Tom Lane
Christian Convey writes: >> There are a couple of really huge issues that would have to be argued out >> before any progress could be made. > Is this something that people want to spend time on right now? As I > mentioned earlier, I'm game. But it doesn't sound like I'll get very far > without

Re: [HACKERS] ALTER TABLE lock strength reduction patch is unsafe

2014-01-28 Thread Bruce Momjian
On Tue, Jan 28, 2014 at 07:30:47PM +0200, Heikki Linnakangas wrote: > On 01/28/2014 07:26 PM, Bruce Momjian wrote: > >On Tue, Jan 28, 2014 at 07:21:50PM +0200, Heikki Linnakangas wrote: > I have no problem removing the parameter if required to. In that case, > I would like to leave the para

[HACKERS] GSoC 2014 - mentors, students and admins

2014-01-28 Thread Thom Brown
Hi all, Application to Google Summer of Code 2014 can be made as of next Monday (3rd Feb), and then there will be a 12 day window in which to submit an application. I'd like to gauge interest from both mentors and students as to whether we'll want to do this. And I'd be fine with being admin aga

Re: [HACKERS] Storing pg_stat_statements query texts externally, pg_stat_statements in core

2014-01-28 Thread Tom Lane
Peter Geoghegan writes: > I noticed a minor omission in the patch as committed. Attached patch > corrects this. Duh. Thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgr

Re: [HACKERS] A minor correction in comment in heaptuple.c

2014-01-28 Thread Alvaro Herrera
Bruce Momjian escribió: > On Tue, Jan 28, 2014 at 11:20:39AM -0500, Tom Lane wrote: > > Andres Freund writes: > > > On 2014-01-28 11:14:49 -0500, Bruce Momjian wrote: > > >> OK, so does anyone object to removing this comment line? > > > > > Let's just not do anything. This is change for changes s

Re: [HACKERS] Performance Improvement by reducing WAL for Update Operation

2014-01-28 Thread Jinyu
I think sort by string column is lower during merge join, maybe comparing function in sort need be refined to save some cycle. It’s the hot function when do sort. Heikki Linnakangas 编写: >On 01/27/2014 07:03 PM, Amit Kapila wrote: >> I have tried to improve algorithm in another way so that w

  1   2   >