Re: [HACKERS] mogrify and indent features for jsonb

2015-03-01 Thread Petr Jelinek
On 23/02/15 18:15, Dmitry Dolgov wrote: Hi, Petr, thanks for the review. >>> I think it would be better if the ident printing didn't put the start of array ([) and start of dictionary ({) on separate line Did you mean this? [ { "a": 1, "b": 2 }

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-03-01 Thread Michael Paquier
On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost wrote: > I'm going to mark this back to 'waiting on author' in case there's > something material that I've missed which you can clarify. I had > started this review thinking to help move it along but after re-reading > the thread and thinking about it

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Michael Paquier
On Sun, Mar 1, 2015 at 1:09 AM, Stephen Frost wrote: > Michael, > > * Michael Paquier (michael.paqu...@gmail.com) wrote: >> + /* >> + * Query all the foreign key dependencies for all the >> extension >> + * tables found previously. Onl

Re: [HACKERS] Reduce pinning in btree indexes

2015-03-01 Thread Kevin Grittner
Kyotaro HORIGUCHI wrote: > Hello, I measured the performance of this patch considering > markpos/restorepos. The loss seems to be up to about 10% > unfortunately. Thanks for the test case! I took another look at this optimization, and found that it didn't really depend on the pin (as I had firs

Re: [HACKERS] Additional role attributes && superuser review

2015-03-01 Thread Alvaro Herrera
Stephen Frost wrote: > Thanks! I've gone over this and made quite a few documentation and > comment updates, but not too much else, so I'm pretty happy with how > this is coming along. As mentioned elsewhere, this conflicts with the > GetUserId() to has_privs_of_role() cleanup, but as I anticipa

Re: [HACKERS] rm static libraries before rebuilding

2015-03-01 Thread Alvaro Herrera
Noah Misch wrote: > We build static libraries with "ar crs" or "ar cr". If the static library > already exists in the build directory, those commands will add new members and > replace existing members. They will not remove members present in the > existing library but not named on the "ar" comma

Re: [HACKERS] Buildfarm has got the measles

2015-03-01 Thread Alvaro Herrera
Tom Lane wrote: > Evidently the order in which child tables are visited isn't too stable. > I'm inclined to think that that's fine and this regression test needs > reconsideration. Thanks for pointing it out. I was going to just drop one of the tables, but then thought it is worth keeping a rewr

Re: [HACKERS] Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

2015-03-01 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost wrote: > > I'm going to mark this back to 'waiting on author' in case there's > > something material that I've missed which you can clarify. I had > > started this review thinking to help move it

Re: [HACKERS] logical column ordering

2015-03-01 Thread Alvaro Herrera
Tomas Vondra wrote: > > We need an API for physical column reordering, even if it's just pg_ > > functions. The reason is that we want to enable people writing their > > own physical column re-ordering tools, so that our users can figure out > > for us what the best reordering algorithm is. > >

Re: [HACKERS] logical column ordering

2015-03-01 Thread Alvaro Herrera
Jim Nasby wrote: > On 2/27/15 2:37 PM, Gavin Flower wrote: > >Might be an idea to allow lists of columns and their starting position. > > > >ALTER TABLE customer ALTER COLUMN (job_id, type_id, account_num) SET > >ORDER 3; > > I would certainly want something along those lines because it would be *

Re: [HACKERS] logical column ordering

2015-03-01 Thread Alvaro Herrera
Jim Nasby wrote: > On 2/27/15 2:49 PM, Alvaro Herrera wrote: > >Tomas Vondra wrote: > > > >>1) change the order of columns in "SELECT *" > >> > >>- display columns so that related ones grouped together > >> (irrespectedly whether they were added later, etc.) > > FWIW, I find the ordering

Re: [HACKERS] Additional role attributes && superuser review

2015-03-01 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Stephen Frost wrote: > > > Thanks! I've gone over this and made quite a few documentation and > > comment updates, but not too much else, so I'm pretty happy with how > > this is coming along. As mentioned elsewhere, this conflicts with the >

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > The thing is that we must absolutely wait for *all* the TableInfoData > of all the extensions to be created because we need to mark the > dependencies between them, and even my last patch, or even with what > you are proposing we may

Re: [HACKERS] mogrify and indent features for jsonb

2015-03-01 Thread Andrew Dunstan
On 03/01/2015 05:03 AM, Petr Jelinek wrote: On 23/02/15 18:15, Dmitry Dolgov wrote: Hi, Petr, thanks for the review. >>> I think it would be better if the ident printing didn't put the start of array ([) and start of dictionary ({) on separate line Did you mean this? [ {

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-03-01 Thread Dean Rasheed
On 27 February 2015 at 03:10, Etsuro Fujita wrote: > On 2015/02/26 11:38, Stephen Frost wrote: >> >> I've pushed an update for this to master and 9.4 and improved the >> comments and the commit message as discussed. >> >> Would be great if you could test and let me know if you run into any >> issu

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-03-01 Thread Stephen Frost
* Dean Rasheed (dean.a.rash...@gmail.com) wrote: > On 27 February 2015 at 03:10, Etsuro Fujita > wrote: > > On 2015/02/26 11:38, Stephen Frost wrote: > >> > >> I've pushed an update for this to master and 9.4 and improved the > >> comments and the commit message as discussed. > >> > >> Would be g

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-03-01 Thread Stephen Frost
* Dean Rasheed (dean.a.rash...@gmail.com) wrote: > On 27 February 2015 at 03:10, Etsuro Fujita > wrote: > > On 2015/02/26 11:38, Stephen Frost wrote: > >> > >> I've pushed an update for this to master and 9.4 and improved the > >> comments and the commit message as discussed. > >> > >> Would be g

Re: [HACKERS] plpgsql versus domains

2015-03-01 Thread Tom Lane
Andrew Gierth writes: > "Tom" == Tom Lane writes: > Tom> This is the first attempt at weaponizing the memory context > Tom> reset/delete feature, and I'm fairly happy with it, except for one > Tom> thing: I had to #include utils/memnodes.h into typcache.h in order > Tom> to preserve the inten

Re: [HACKERS] Improving RLS qual pushdown

2015-03-01 Thread Dean Rasheed
Thanks for looking at this. On 28 February 2015 at 04:25, Stephen Frost wrote: > Dean, > > * Dean Rasheed (dean.a.rash...@gmail.com) wrote: >> Attached is a patch that does that, allowing restriction clause quals >> to be pushed down into subquery RTEs if they contain leaky functions, >> provided

Re: [HACKERS] Improving RLS qual pushdown

2015-03-01 Thread Stephen Frost
Dean, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > Thanks for looking at this. Thanks for working on it. :) > On 28 February 2015 at 04:25, Stephen Frost wrote: > > * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > >> --- 1318,1347 > >> } > >> > >> > >> /***

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > >> Subject: [PATCH 2/3] Make prove_check install contents of current > >> directory as well > > > > This is really an independent thing, no? I don't see any particular > > problem with it, for my part. > > Yes, that's an independen

Re: [HACKERS] add modulo (%) operator to pgbench

2015-03-01 Thread Robert Haas
On Sat, Feb 28, 2015 at 12:06 PM, Stephen Frost wrote: > I took a look through the patch and the discussion and it certainly > seems ready to me. I agree with Robert- let's go ahead and get this in > and then folks can build on top of it. I'm guessing it was added as > "Needs Review" since that'

Re: [HACKERS] Improving RLS qual pushdown

2015-03-01 Thread Dean Rasheed
On 1 March 2015 at 18:23, Stephen Frost wrote: >> Thanks. Do you want me to post an update, or are you going to hack on it? > > Either works for me, though I'm happy to handle the modifications to > this if it means you have time to look at the other patches.. :) > OK, I'll continue testing the o

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Stephen Frost
Michael, * Stephen Frost (sfr...@snowman.net) wrote: > * Michael Paquier (michael.paqu...@gmail.com) wrote: > > >> Subject: [PATCH 2/3] Make prove_check install contents of current > > >> directory as well > > > > > > This is really an independent thing, no? I don't see any particular > > > prob

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-03-01 Thread Stephen Frost
Dean, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > I just spotted a trivial bug in this patch -- in > expand_security_quals() you need to set targetRelation = false inside > the loop, otherwise it will be true for the target relation and all > that follow it. I've pushed a fix for this.

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Stephen Frost
Michael, * Stephen Frost (sfr...@snowman.net) wrote: > * Michael Paquier (michael.paqu...@gmail.com) wrote: > > The thing is that we must absolutely wait for *all* the TableInfoData > > of all the extensions to be created because we need to mark the > > dependencies between them, and even my last

Re: [HACKERS] Index-only scans for GiST.

2015-03-01 Thread Heikki Linnakangas
On 02/27/2015 04:19 PM, Anastasia Lubennikova wrote: I add MemoryContext listCxt to avoid memory leak. listCxt is created once in gistrescan (only for index-only scan plan ) and reseted when scan of the leaf page is finished. I do not sure if the problem was completely solved, so I wait for feed

Re: [HACKERS] Bug in pg_dump

2015-03-01 Thread Michael Paquier
On Mon, Mar 2, 2015 at 6:27 AM, Stephen Frost wrote: > Please see the latest version of this, attached. I've removed the left > join, re-used the 'query' buffer (instead of destroying and recreating > it), and added a bit of documentation, along with a note in the commit > message for the release

Re: [HACKERS] Odd behavior of updatable security barrier views on foreign tables

2015-03-01 Thread Etsuro Fujita
On 2015/03/02 5:28, Stephen Frost wrote: * Dean Rasheed (dean.a.rash...@gmail.com) wrote: I just spotted a trivial bug in this patch -- in expand_security_quals() you need to set targetRelation = false inside the loop, otherwise it will be true for the target relation and all that follow it.

[HACKERS] Fix broken Install.bat when target directory contains a space

2015-03-01 Thread Michael Paquier
Hi all, When using install.bat with a path containing spaces, I got surprised by a couple of errors. 1) First with this path: $ install "c:\Program Files\pgsql" I am getting the following error: Files\pgsql""=="" was unexpected at this time. This is caused by an incorrect evaluation of the first p

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-03-01 Thread Jan de Visser
On February 19, 2015 08:26:45 PM Tom Lane wrote: > Bug #12788 reminded me of a problem I think we've discussed before: > if you use "pg_ctl reload" to trigger reload of the postmaster's > config files, and there's something wrong with those files, there's > no warning to you of that. The postmaste

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-03-01 Thread Jan de Visser
On March 2, 2015 12:56:23 AM Jan de Visser wrote: ... stuff ... I seem to have mis-clicked something in the CF app - I created two entries somehow. I think one got created when I entered the msgid of Tom's original message with the enclosing '<...>'. If that's the case, then that may be a bug.

Re: [HACKERS] Idea: closing the loop for "pg_ctl reload"

2015-03-01 Thread Michael Paquier
On Mon, Mar 2, 2015 at 3:01 PM, Jan de Visser wrote: > On March 2, 2015 12:56:23 AM Jan de Visser wrote: > ... stuff ... > > I seem to have mis-clicked something in the CF app - I created two entries > somehow. I think one got created when I entered the msgid of Tom's original > message with the e

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-03-01 Thread Haribabu Kommi
On Sat, Feb 28, 2015 at 11:41 AM, Stephen Frost wrote: > Pavel, > > * Pavel Stehule (pavel.steh...@gmail.com) wrote: >> 2015-02-27 22:26 GMT+01:00 Tom Lane : >> > Stephen Frost writes: >> > > Right, we also need a view (or function, or both) which provides what >> > > the *active* configuration o