Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2017-02-07 Thread Thomas Munro
On Tue, Feb 7, 2017 at 5:43 PM, Peter Geoghegan wrote: > However, there are some specific implementation issues with this that > I didn't quite anticipate. I would like to get feedback on these > issues now, from both Thomas and Robert. The issues relate to how much > the patch can

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Pavel Stehule
2017-02-08 8:30 GMT+01:00 Michael Paquier : > On Wed, Feb 8, 2017 at 4:24 PM, Pavel Stehule > wrote: > > What is sense for list of databases? > > ECPG uses it for example, see 0992259. > > > Some option --template can be great - with backpatch

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Michael Paquier
On Wed, Feb 8, 2017 at 4:24 PM, Pavel Stehule wrote: > What is sense for list of databases? ECPG uses it for example, see 0992259. > Some option --template can be great - with backpatch if it is possible. That's not really complicated to patch... That could be a nice

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Pavel Stehule
2017-02-08 1:30 GMT+01:00 Michael Paquier : > On Wed, Feb 8, 2017 at 9:23 AM, Tom Lane wrote: > > I ran into a use-case just today: I wanted to run one particular > > regression test script under CLOBBER_CACHE_ALWAYS, but it needed > > stuff created

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Dilip Kumar
On Wed, Feb 8, 2017 at 8:07 AM, Robert Haas wrote: .Thanks for your input, I have few queries about these comments. > 2. Add a new function dsa_pointer tbm_prepare_shared_iterate(TIDBitmap > *tbm) which allocates shared iteration arrays using the DSA passed to >

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Masahiko Sawada
On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier wrote: > On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: >> On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek >> wrote: >>> For example what happens if apply crashes

Re: [HACKERS] WAL consistency check facility

2017-02-07 Thread Kuntal Ghosh
On Tue, Jan 31, 2017 at 9:36 PM, Robert Haas wrote: > On Thu, Jan 5, 2017 at 12:54 AM, Kuntal Ghosh > wrote: >> I've attached the patch with the modified changes. PFA. > > Can this patch check contrib/bloom? > Added support for generic resource

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-07 Thread Tom Lane
Peter Eisentraut writes: > On 2/7/17 11:21 AM, Tom Lane wrote: >> A compromise that might be worth considering is to introduce >> #define PG_DEFAULT_SSL_CIPHERS "HIGH:MEDIUM:+3DES:!aNULL" >> into pg_config_manual.h, which would at least give you a reasonably >>

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-07 Thread Peter Eisentraut
On 2/7/17 11:21 AM, Tom Lane wrote: > A compromise that might be worth considering is to introduce > > #define PG_DEFAULT_SSL_CIPHERS "HIGH:MEDIUM:+3DES:!aNULL" > > into pg_config_manual.h, which would at least give you a reasonably > stable target point for a long-lived patch. You'd still need

Re: [HACKERS] drop support for Python 2.3

2017-02-07 Thread Tom Lane
Peter Eisentraut writes: > I would like to propose that we drop support for Python 2.3. > ... > We do have buildfarm coverage on prairiedog. However, that runs a >10 > year old operating system, so I think it is not representing real usage. I have no particular

Re: [HACKERS] pg_bsd_indent: implement -lps ("leave preprocessor space")

2017-02-07 Thread Tom Lane
Piotr Stefaniak writes: > this is a patch that Andres asked me for. It makes pg_bsd_indent leave > preprocessor space alone, as in this example: > #if 0 > # if 0 > # if 0 > # error > # endif > # endif > #else > # line 7 > #endif Um ... but the point

[HACKERS] drop support for Python 2.3

2017-02-07 Thread Peter Eisentraut 
I would like to propose that we drop support for Python 2.3.  Reasons:

- Python 3.6 was released in December.  The list of versions we need to
manage is growing.

- Older Python versions are increasingly hard to build locally for testing.

- It's unlikely that Python 2.3 is still used in

Re: [HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Stephen Frost
Peter, On Tue, Feb 7, 2017 at 22:49 Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 2/7/17 3:19 PM, Stephen Frost wrote: > > I understand that this is a bit complicated, but I would have thought > > we'd do something similar to what is done for DEFAULT PRIVILEGES, where > > we

Re: [HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Peter Eisentraut
On 2/7/17 3:19 PM, Stephen Frost wrote: > I understand that this is a bit complicated, but I would have thought > we'd do something similar to what is done for DEFAULT PRIVILEGES, where > we include the "global" default privileges when we are doing a dump of > "everything", but if we're dumping a

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Merlin Moncure
1On Tue, Feb 7, 2017 at 9:46 PM, Joel Jacobson wrote: > On Tue, Feb 7, 2017 at 4:58 PM, Tom Lane wrote: >> Joel Jacobson writes: >>> Currently there is no simple way to check if two sets are equal. >> >> Uh ... maybe check whether SELECT

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Robert Haas
On Sun, Feb 5, 2017 at 9:48 AM, Dilip Kumar wrote: > Here are the latest version of the patch, which address all the > comments given by Robert. I think it would be useful to break the remaining patch into two parts, one that enhances the tidbitmap.c API and another that

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 6:40 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: >> >>> On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: >>> >>> Jonathan S. Katz wrote: >>> Thanks for the clarification. I have updated the recipe

[HACKERS] pg_bsd_indent: implement -lps ("leave preprocessor space")

2017-02-07 Thread Piotr Stefaniak
Hello, this is a patch that Andres asked me for. It makes pg_bsd_indent leave preprocessor space alone, as in this example: #if 0 # if 0 # if 0 # error # endif # endif #else # line 7 #endif diff -ur pg_bsd_indent/args.c pg_bsd_indent_patched/args.c --- pg_bsd_indent/args.c

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Michael Paquier
On Wed, Feb 8, 2017 at 9:23 AM, Tom Lane wrote: > I ran into a use-case just today: I wanted to run one particular > regression test script under CLOBBER_CACHE_ALWAYS, but it needed > stuff created by earlier scripts, and I didn't especially want to > run all of those scripts

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Andres Freund
On 2017-02-07 19:23:45 -0500, Tom Lane wrote: > Michael Paquier writes: > > On Wed, Feb 8, 2017 at 12:43 AM, Pavel Stehule > > wrote: > >> Is possible to specify template database for pg_regress? > >> I have to run tests on database with

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > > > On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: > > > > Jonathan S. Katz wrote: > > > >> Thanks for the clarification. I have updated the recipe along with Emre’s > >> comments here: > >> > >> [updated text not included in the email]

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Tom Lane
Michael Paquier writes: > On Wed, Feb 8, 2017 at 12:43 AM, Pavel Stehule > wrote: >> Is possible to specify template database for pg_regress? >> I have to run tests on database with thousands database objects. Using >> template is much faster

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Michael Paquier
On Wed, Feb 8, 2017 at 12:43 AM, Pavel Stehule wrote: > Is possible to specify template database for pg_regress? > I have to run tests on database with thousands database objects. Using > template is much faster than import these objects. Not directly, all the databases

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Michael Paquier
On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: > On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek > wrote: >> For example what happens if apply crashes during the DROP >> SUBSCRIPTION/COMMIT and is not started because the delete from catalog

Re: [HACKERS] Caching index AM working data across aminsert calls

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 6:04 PM, Tom Lane wrote: > It's always been possible for index AMs to cache data across successive > amgettuple calls within a single SQL command: the IndexScanDesc.opaque > field is meant for precisely that. However, no comparable facility > exists for

[HACKERS] Caching index AM working data across aminsert calls

2017-02-07 Thread Tom Lane
It's always been possible for index AMs to cache data across successive amgettuple calls within a single SQL command: the IndexScanDesc.opaque field is meant for precisely that. However, no comparable facility exists for amortizing setup work across successive aminsert calls. The attached

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 4:39 PM, Michael Banck wrote: > > Hi, > > Am Dienstag, den 07.02.2017, 15:58 -0500 schrieb Jonathan S. Katz: > > >>

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 4:07 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: > >> Thanks for the clarification. I have updated the recipe along with Emre’s >> comments here: >> >> [updated text not included in the email] > > I still don't think the recipe is a

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 4:45 PM, Andres Freund wrote: > On 2017-02-07 16:36:55 -0500, Robert Haas wrote: >> On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund wrote: >> > FWIW, I think it'd have been better to not add the new callbacks as >> > parameters to

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Andres Freund
On 2017-02-07 16:36:55 -0500, Robert Haas wrote: > On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund wrote: > > FWIW, I think it'd have been better to not add the new callbacks as > > parameters to *_create(), but rather have them be "templatized" like the > > rest of simplehash.

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
Hi, Am Dienstag, den 07.02.2017, 15:58 -0500 schrieb Jonathan S. Katz: > https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.txt;h=f90d4716f240dbea4cca647b099f79865545b633;hb=d85498c284275bcab4752b91476834de780648b8 It says "[...]then rows that

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund wrote: > FWIW, I think it'd have been better to not add the new callbacks as > parameters to *_create(), but rather have them be "templatized" like the > rest of simplehash. That'd require that callback to check the context, > to

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 4:13 PM, Jeff Janes wrote: > I'm getting compiler errors: > > In file included from execGrouping.c:47: > ../../../src/include/lib/simplehash.h:91: error: redefinition of typedef > 'simplehash_allocate' > ../../../src/include/lib/simplehash.h:91: note:

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Andres Freund
On 2017-02-07 13:13:43 -0800, Jeff Janes wrote: > On Tue, Feb 7, 2017 at 1:03 PM, Robert Haas wrote: > > > On Sun, Feb 5, 2017 at 9:48 AM, Dilip Kumar wrote: > > >> I think maybe we should rename the functions to element_allocate, > > >>

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Andres Freund
On 2017-02-07 16:03:43 -0500, Robert Haas wrote: > On Sun, Feb 5, 2017 at 9:48 AM, Dilip Kumar wrote: > >> I think maybe we should rename the functions to element_allocate, > >> element_free, and element_allocator_ctx, or something like that. The > >> current names aren't

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Jeff Janes
On Tue, Feb 7, 2017 at 1:03 PM, Robert Haas wrote: > On Sun, Feb 5, 2017 at 9:48 AM, Dilip Kumar wrote: > >> I think maybe we should rename the functions to element_allocate, > >> element_free, and element_allocator_ctx, or something like that. The

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > Thanks for the clarification. I have updated the recipe along with Emre’s > comments here: > > [updated text not included in the email] I still don't think the recipe is a very good one because it leaves you with a window where the affected columns are not indexed at

Re: \if, \elseif, \else, \endif (was Re: [HACKERS] PSQL commands: \quit_if, \quit_unless)

2017-02-07 Thread Fabien COELHO
This was my previous understanding of ON_ERROR_STOP. Somewhere in the course of developing this patch I lost that. Glad to have it back. The only changes I made were to invalid booleans on if/elif, and the final branch balancing check won't set status to EXIT_USER unless it's non-interactive

Re: [HACKERS] Parallel bitmap heap scan

2017-02-07 Thread Robert Haas
On Sun, Feb 5, 2017 at 9:48 AM, Dilip Kumar wrote: >> I think maybe we should rename the functions to element_allocate, >> element_free, and element_allocator_ctx, or something like that. The >> current names aren't capitalized consistently with other things in >> this

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 12:44 PM, Alvaro Herrera wrote: > > Jonathan S. Katz wrote: > >> Below is the draft of the press release for the update this Thursday: >> >>

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
> On Feb 7, 2017, at 11:25 AM, Emre Hasegeli wrote: > >> As there are a lot of updates I did my best to consolidate some of the >> bullet points and as usual, people are directed to the release notes. >> Please let me know if there are any inaccuracies so I can fix them ASAP.

Re: [HACKERS] GSoC 2017 - LAST CALL

2017-02-07 Thread Alexander Korotkov
Hi! On Tue, Feb 7, 2017 at 4:39 PM, Stephen Frost wrote: > I will be submitting our application to Google tomorrow morning (the > deadline is Feb 9th, 1600 UTC, but I'd like to do it a bit early to > have time to address any issues). Please get your project ideas >

[HACKERS] PUBLICATIONS and pg_dump

2017-02-07 Thread Stephen Frost
Peter, * Peter Eisentraut (pete...@gmx.net) wrote: > Logical replication > > - Add PUBLICATION catalogs and DDL > - Add SUBSCRIPTION catalog and DDL > - Define logical replication protocol and output plugin > - Add logical replication workers I think we need to have a bit more discussion

Re: [HACKERS] Cache Hash Index meta page.

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 1:52 PM, Mithun Cy wrote: > On Tue, Feb 7, 2017 at 11:21 PM, Erik Rijkers wrote: >> On 2017-02-07 18:41, Robert Haas wrote: >>> >>> Committed with some changes (which I noted in the commit message). > > Thanks, Robert and all who

Re: [HACKERS] Cache Hash Index meta page.

2017-02-07 Thread Mithun Cy
On Tue, Feb 7, 2017 at 11:21 PM, Erik Rijkers wrote: > On 2017-02-07 18:41, Robert Haas wrote: >> >> Committed with some changes (which I noted in the commit message). Thanks, Robert and all who have reviewed the patch and given their valuable comments. > This has caused a

Re: \if, \elseif, \else, \endif (was Re: [HACKERS] PSQL commands: \quit_if, \quit_unless)

2017-02-07 Thread Corey Huinker
> > > It seems that ON_ERROR_STOP is mostly ignored by design when in > interactive mode, probably because it is nicer not to disconnect the user > who is actually typing things on a terminal. > > """ > ON_ERROR_STOP > > By default, command processing continues after an error. When this >

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Fabien COELHO
Currently there is no simple way to check if two sets are equal. My 0.02€: Assuming that you mean set = relation, and that there is a key (which should be the case for a set otherwise tuples cannot be distinguished, so this is not really a set), and assuming not null other data, then:

Re: [HACKERS] Cache Hash Index meta page.

2017-02-07 Thread Erik Rijkers
On 2017-02-07 18:41, Robert Haas wrote: Committed with some changes (which I noted in the commit message). This has caused a warning with gcc 6.20: hashpage.c: In function ‘_hash_getcachedmetap’: hashpage.c:1245:20: warning: ‘cache’ may be used uninitialized in this function

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Tom Lane
"David G. Johnston" writes: > On Tue, Feb 7, 2017 at 8:58 AM, Tom Lane wrote: >> Joel Jacobson writes: >>> Currently there is no simple way to check if two sets are equal. >> Uh ... maybe check whether SELECT set1 EXCEPT SELECT

Re: [HACKERS] [COMMITTERS] pgsql: Release note updates.

2017-02-07 Thread Pavan Deolasee
On Tue, Feb 7, 2017 at 9:29 PM, Alvaro Herrera wrote: > Alvaro Herrera wrote: > > > > > Hmm. Now that I think about it, it is probably possible to have a > > transaction started before CIC that inserted a bunch of rows, and then > > runs the UPDATE during the CIC race

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread David G. Johnston
On Tue, Feb 7, 2017 at 8:58 AM, Tom Lane wrote: > Joel Jacobson writes: > > Currently there is no simple way to check if two sets are equal. > > Uh ... maybe check whether SELECT set1 EXCEPT SELECT set2 > and SELECT set2 EXCEPT SELECT set1 are both empty? >

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Jonathan S. Katz wrote: > Below is the draft of the press release for the update this Thursday: > > https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.md;h=0cccb8986c08527f65f13d704a78c36bb8de7fef;hb=afc01091dea8a1597e8e21430edc3908c581ce0c >

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Alvaro Herrera
Michael Banck wrote: > Hi, > > Am Dienstag, den 07.02.2017, 10:37 -0500 schrieb Jonathan S. Katz: > > > Below is the draft of the press release for the update this Thursday: > > About the CREATE INDEX CONCURRENTLY issue, I wonder whether Peter's > amcheck extension[1] would catch that (for

Re: [HACKERS] Cache Hash Index meta page.

2017-02-07 Thread Robert Haas
On Wed, Feb 1, 2017 at 12:23 AM, Michael Paquier wrote: > On Sun, Jan 29, 2017 at 6:13 PM, Mithun Cy wrote: >>> HashMetaPage _hash_getcachedmetap(Relation rel, Buffer *metabuf, bool >>> force_refresh); >>> >>> If the cache is initialized and

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Joel Jacobson
On Tue, Feb 7, 2017 at 6:28 PM, David Fetter wrote: > This could be shortened further to the following if we ever implement > DISTINCT for window functions, which might involve implementing > DISTINCT via hashing more generally, which means hashable > types...whee! > > SELECT

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread David Fetter
On Tue, Feb 07, 2017 at 09:10:17AM -0800, David Fetter wrote: > On Tue, Feb 07, 2017 at 04:13:40PM +0100, Joel Jacobson wrote: > > Hi hackers, > > > > Currently there is no simple way to check if two sets are equal. > > Assuming that a and b each has at least one NOT NULL column, is this >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-07 Thread Mithun Cy
On Tue, Feb 7, 2017 at 6:11 PM, Beena Emerson wrote: > Yes it would be better to have only one pg_prewarm worker as the loader is > idle for the entire server run time after the initial load activity of few > secs. Sorry, that is again a bug in the code. The code to

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread David Fetter
On Tue, Feb 07, 2017 at 04:13:40PM +0100, Joel Jacobson wrote: > Hi hackers, > > Currently there is no simple way to check if two sets are equal. Assuming that a and b each has at least one NOT NULL column, is this simple enough? Based on nothing much, I'm assuming here that the IS NOT NULL

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2017-02-07 Thread Brandur Leach
And as a short follow up, I've moved the patch to the current commit fest: https://commitfest.postgresql.org/13/743/ On Sun, Feb 5, 2017 at 1:56 PM, Brandur Leach wrote: > Hi Julien, > > Thank you for taking the time to do this review, and my > apologies for the very

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Michael Banck
Hi, Am Dienstag, den 07.02.2017, 10:37 -0500 schrieb Jonathan S. Katz: > Below is the draft of the press release for the update this Thursday: About the CREATE INDEX CONCURRENTLY issue, I wonder whether Peter's amcheck extension[1] would catch that (for B-Tree indexes at least), and if that is

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Fujii Masao
On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek wrote: > On 07/02/17 13:10, Masahiko Sawada wrote: >> Hi all, >> >> While testing logical replciation I found that if the transaction >> issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops >> and the

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Emre Hasegeli
> As there are a lot of updates I did my best to consolidate some of the > bullet points and as usual, people are directed to the release notes. > Please let me know if there are any inaccuracies so I can fix them ASAP. Just some minor points: > * Several fixes for PostgreSQL operating in hot

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-07 Thread Tom Lane
Pavel Raiskup writes: > PostgreSQL server uses 'HIGH:MEDIUM:+3DES:!aNULL' cipher set by default, > but what Fedora would like to have is 'PROFILE=SYSTEM' (works with > Fedora-patched OpenSSL, so please don't waste your time with checking this > elsewhere). > ... > I'd like to

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Joel Jacobson
On Tue, Feb 7, 2017 at 4:58 PM, Tom Lane wrote: > Joel Jacobson writes: >> Currently there is no simple way to check if two sets are equal. > > Uh ... maybe check whether SELECT set1 EXCEPT SELECT set2 > and SELECT set2 EXCEPT SELECT set1 are both empty?

Re: [HACKERS] [COMMITTERS] pgsql: Release note updates.

2017-02-07 Thread Alvaro Herrera
Alvaro Herrera wrote: > Tom Lane wrote: > > Alvaro Herrera writes: > > > > May I suggest > > > > > + If CREATE INDEX CONCURRENTLY was used to build an index > > > + that depends on a column not previously indexed, then rows > > > + updated by

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Tom Lane
Joel Jacobson writes: > Currently there is no simple way to check if two sets are equal. Uh ... maybe check whether SELECT set1 EXCEPT SELECT set2 and SELECT set2 EXCEPT SELECT set1 are both empty? regards, tom lane -- Sent via pgsql-hackers mailing

[HACKERS] possibility to specify template database for pg_regress

2017-02-07 Thread Pavel Stehule
Hi Is possible to specify template database for pg_regress? I have to run tests on database with thousands database objects. Using template is much faster than import these objects. Regards Pavel

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Joel Jacobson
But that's already a valid statement, so there is no ambiguity: SELECT TRUE WHERE FALSE IS NOT DISTINCT FROM (SELECT TRUE); bool -- (0 rows) If you want to compare the set (SELECT TRUE WHERE FALSE) with the set (SELECT TRUE) then just add parenthesis: (SELECT TRUE WHERE FALSE) IS NOT

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Anders Granlund
What about this ambiguity? SELECT TRUE WHERE FALSE IS NOT DISTINCT FROM (SELECT TRUE) On Tue, Feb 7, 2017 at 4:13 PM, Joel Jacobson wrote: > Hi hackers, > > Currently there is no simple way to check if two sets are equal. > > Looks like no RDBMS in the world has a simple

Re: [HACKERS] [COMMITTERS] pgsql: Release note updates.

2017-02-07 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > May I suggest > > > + If CREATE INDEX CONCURRENTLY was used to build an index > > + that depends on a column not previously indexed, then rows > > + updated by transactions that ran concurrently with > > +

[HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-07 Thread Jonathan S. Katz
Hi! Below is the draft of the press release for the update this Thursday: https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/20170209updaterelease.md;h=0cccb8986c08527f65f13d704a78c36bb8de7fef;hb=afc01091dea8a1597e8e21430edc3908c581ce0c

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Petr Jelinek
On 07/02/17 16:26, Petr Jelinek wrote: > On 07/02/17 13:10, Masahiko Sawada wrote: >> I think the logical replication should not stop and the corresponding >> replication slot and replication origin should not be removed until >> the transaction commits. >> >> The solution for this I came up with

Re: [HACKERS] [COMMITTERS] pgsql: Release note updates.

2017-02-07 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> (I fear this is too late for the current set of releases; I don't want >> to make the packagers redo their work just for this. But we can correct >> it for future wraps.) > I think a large fraction of the readers will grab

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Petr Jelinek
On 07/02/17 13:10, Masahiko Sawada wrote: > Hi all, > > While testing logical replciation I found that if the transaction > issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops > and the subscription can never be removed later. The document says > that the replication worker

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Daniele Varrazzo
On Tue, Feb 7, 2017 at 2:59 PM, Andreas Karlsson wrote: > On 02/07/2017 03:14 PM, Daniele Varrazzo wrote: >> >> In psycopg '{}'::unknown is treated specially as an empty array and >> converted into an empty list, which allows empty lists to be passed to >> the server as arrays

Re: [HACKERS] pg_restore is broken on 9.2 version.

2017-02-07 Thread Stephen Frost
* Stephen Frost (sfr...@snowman.net) wrote: > Greetings, > > * Rushabh Lathia (rushabh.lat...@gmail.com) wrote: > > Commit c59a1a89035674c6efacc596d652528cebba37ec don't allow non-positive > > number > > of jobs. Now on 9.2 number of jobs get assigned to opts->number_of_jobs. If > > user don't

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Daniele Varrazzo
On Tue, Feb 7, 2017 at 2:42 PM, Tom Lane wrote: > Daniele Varrazzo writes: >> testing with psycopg2 against Postgres 10 I've found a difference in >> behaviour regarding literals, which are returned as text instead of >> unknown. ... >> Is this

[HACKERS] Idea on how to simplify comparing two sets

2017-02-07 Thread Joel Jacobson
Hi hackers, Currently there is no simple way to check if two sets are equal. Looks like no RDBMS in the world has a simple command for it. You have to do something like: WITH T1 AS (SELECT * FROM Foo WHERE FooID BETWEEN 1 AND 1), T2 AS (SELECT * FROM Bar WHERE BarID BETWEEN 1 AND 1)

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

2017-02-07 Thread Fujii Masao
On Tue, Feb 7, 2017 at 2:13 AM, Petr Jelinek wrote: > On 06/02/17 17:33, Fujii Masao wrote: >> On Sun, Feb 5, 2017 at 5:11 AM, Petr Jelinek >> wrote: >>> On 03/02/17 19:38, Fujii Masao wrote: On Sat, Feb 4, 2017 at 12:49 AM, Fujii

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Andreas Karlsson
On 02/07/2017 03:14 PM, Daniele Varrazzo wrote: In psycopg '{}'::unknown is treated specially as an empty array and converted into an empty list, which allows empty lists to be passed to the server as arrays and returned back to python. Without the special case, empty lists behave differently

[HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-07 Thread Pavel Raiskup
Hi hackers, in Fedora, there's crypto initiative where people try to consolidate ssl cipher settings for (majority of) Fedora services (PostgreSQL is included). PostgreSQL server uses 'HIGH:MEDIUM:+3DES:!aNULL' cipher set by default, but what Fedora would like to have is 'PROFILE=SYSTEM' (works

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-07 Thread Fujii Masao
On Tue, Feb 7, 2017 at 9:10 PM, Masahiko Sawada wrote: > Hi all, > > While testing logical replciation I found that if the transaction > issued DROP SUBSCRIPTION　rollbacks then the logical repliation stops > and the subscription can never be removed later. The document says

Re: [HACKERS] pg_restore is broken on 9.2 version.

2017-02-07 Thread Stephen Frost
Greetings, * Rushabh Lathia (rushabh.lat...@gmail.com) wrote: > Commit c59a1a89035674c6efacc596d652528cebba37ec don't allow non-positive > number > of jobs. Now on 9.2 number of jobs get assigned to opts->number_of_jobs. If > user don't specify any value -j then default value will be always 0.

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Tom Lane
Daniele Varrazzo writes: > testing with psycopg2 against Postgres 10 I've found a difference in > behaviour regarding literals, which are returned as text instead of > unknown. ... > Is this behaviour here to stay? Is there documentation for this change? Yup, see

Re: [HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Pavel Stehule
Hi 2017-02-07 15:14 GMT+01:00 Daniele Varrazzo : > Hello, > > testing with psycopg2 against Postgres 10 I've found a difference in > behaviour regarding literals, which are returned as text instead of > unknown. In previous versions: > > In [2]: cnn =

[HACKERS] pg_restore is broken on 9.2 version.

2017-02-07 Thread Rushabh Lathia
Hi All, Commit c59a1a89035674c6efacc596d652528cebba37ec don't allow non-positive number of jobs. Now on 9.2 number of jobs get assigned to opts->number_of_jobs. If user don't specify any value -j then default value will be always 0. Which will lead to the "invalid number of parallel jobs" error.

Re: [HACKERS] GSoC 2017

2017-02-07 Thread Stephen Frost
Ruben, * Ruben Buchatskiy (ru...@ispras.ru) wrote: > Difficulty Level > Moderate-level; however, microoptimizations might be hard. > Probably it will also be hard to keep the whole architecture as clean as it is > now. The above difficulty level looks fine, but doesn't match what's on the wiki.

Re: [HACKERS] [COMMITTERS] pgsql: Release note updates.

2017-02-07 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> Release note updates. > Sorry for not noticing earlier, but there is a bug in the notes: Mmm, right. > May I suggest > + If CREATE INDEX CONCURRENTLY was used to build an index > + that depends on a column not

[HACKERS] 'text' instead of 'unknown' in Postgres 10

2017-02-07 Thread Daniele Varrazzo
Hello, testing with psycopg2 against Postgres 10 I've found a difference in behaviour regarding literals, which are returned as text instead of unknown. In previous versions: In [2]: cnn = psycopg2.connect('') In [3]: cur = cnn.cursor() In [7]: cur.execute("select 'x'") In [9]:

Re: [HACKERS] GSoC 2017 - LAST CALL

2017-02-07 Thread Stephen Frost
Amit, * Amit Kapila (amit.kapil...@gmail.com) wrote: > On Tue, Feb 7, 2017 at 7:09 PM, Stephen Frost wrote: > > If you have any ideas for projects, please go to: > > > > https://wiki.postgresql.org/wiki/GSoC_2017 > > There are few entries which seem to be redundant: > > >

Re: [HACKERS] GSoC 2017 - LAST CALL

2017-02-07 Thread Amit Kapila
On Tue, Feb 7, 2017 at 7:09 PM, Stephen Frost wrote: > All, > > This is the LAST CALL for applications to GSoC 2017 for PostgreSQL. > > If you have any ideas for projects, please go to: > > https://wiki.postgresql.org/wiki/GSoC_2017 > There are few entries which seem to be

Re: [HACKERS] LWLock optimization for multicore Power machines

2017-02-07 Thread Alexander Korotkov
On Tue, Feb 7, 2017 at 3:16 PM, Bernd Helmle wrote: > Am Montag, den 06.02.2017, 22:44 +0300 schrieb Alexander Korotkov: > >2. Also could you run each test longer: 3-5 mins, and run them with >variety of clients count? > > > So here are some other results. I've

Re: [HACKERS] GSoC 2017

2017-02-07 Thread Stephen Frost
* Stephen Frost (sfr...@snowman.net) wrote: > * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > > On 2017/02/06 20:51, Ruben Buchatskiy wrote: > > > Also we have seen in the mailing list that Kumar Rajeev had been > > > investigating this idea too, and he reported that the results were > > >

[HACKERS] GSoC 2017 - LAST CALL

2017-02-07 Thread Stephen Frost
All, This is the LAST CALL for applications to GSoC 2017 for PostgreSQL. If you have any ideas for projects, please go to: https://wiki.postgresql.org/wiki/GSoC_2017 and add them, using the format listed there. I will be submitting our application to Google tomorrow morning (the deadline is

Re: [HACKERS] pageinspect: Hash index support

2017-02-07 Thread Robert Haas
On Sat, Feb 4, 2017 at 7:06 AM, Ashutosh Sharma wrote: >> As far as I can tell, the hash_bitmap_info() function is doing >> something completely ridiculous. One would expect that the purpose of >> this function was to tell you about the status of pages in the bitmap. >>

Re: [HACKERS] GSoC 2017

2017-02-07 Thread Stephen Frost
Greetings, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2017/02/06 20:51, Ruben Buchatskiy wrote: > > Also we have seen in the mailing list that Kumar Rajeev had been > > investigating this idea too, and he reported that the results were > > impressive (unfortunately, without

Re: [HACKERS] 0/NULL/NIL assignments in build_*_rel()

2017-02-07 Thread Robert Haas
On Mon, Feb 6, 2017 at 12:04 AM, Tom Lane wrote: > Ashutosh Bapat writes: >> Both build_simple_rel() and build_join_rel() allocate RelOptInfo using >> makeNode(), which returned a zeroed out memory. The functions then >> assign values like

Re: [HACKERS] WAL consistency check facility

2017-02-07 Thread Robert Haas
On Tue, Feb 7, 2017 at 6:32 AM, Amit Kapila wrote: > On Tue, Jan 31, 2017 at 9:36 PM, Robert Haas wrote: >> >> +if (!HeapTupleHeaderXminFrozen(page_htup)) >> +page_htup->t_infomask |= HEAP_XACT_MASK; >> +else

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-07 Thread Beena Emerson
Hello, On Tue, Feb 7, 2017 at 5:14 PM, Mithun Cy wrote: > On Tue, Feb 7, 2017 at 12:24 PM, Amit Kapila > wrote: > > On Tue, Feb 7, 2017 at 11:53 AM, Beena Emerson > wrote: > >> Are 2 workers required? > >> > > > > I

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-07 Thread Beena Emerson
Hello, On Tue, Feb 7, 2017 at 5:52 PM, Mithun Cy wrote: > Thanks Beena, > > On Tue, Feb 7, 2017 at 4:46 PM, Beena Emerson > wrote: > > Few more comments: > > > > = Background worker messages: > > > > - Workers when launched, show messages

  1   2   >