Re: [HACKERS] SCRAM authentication, take three

2017-02-08 Thread Michael Paquier
On Tue, Feb 7, 2017 at 11:28 AM, Michael Paquier wrote: > Yes, I am actively working on this one now. I am trying to come up > first with something in the shape of an extension to begin with, and > get a patch out of it. That will be more simple for testing. For now >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-08 Thread Peter Geoghegan
On Tue, Feb 7, 2017 at 1:31 AM, Mithun Cy wrote: > SEGFAULT was the coding mistake I have called the C-language function > directly without initializing the functioncallinfo. Thanks for > raising. Below patch fixes same. It would be nice if this had an option to

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-08 Thread Beena Emerson
Hello, On Wed, Feb 8, 2017 at 3:40 PM, Amit Kapila wrote: > On Tue, Feb 7, 2017 at 5:14 PM, Mithun Cy > wrote: > > On Tue, Feb 7, 2017 at 12:24 PM, Amit Kapila > wrote: > >> On Tue, Feb 7, 2017 at 11:53 AM, Beena

Re: [HACKERS] Parallel Index Scans

2017-02-08 Thread Peter Geoghegan
On Wed, Feb 8, 2017 at 10:33 PM, Amit Kapila wrote: > I had some offlist discussion with Robert about the above point and we > feel that keeping only heap pages for parallel computation might not > be future proof as for parallel index only scans there might not be > any

Re: [HACKERS] Parallel Index Scans

2017-02-08 Thread Amit Kapila
On Sat, Feb 4, 2017 at 7:14 AM, Amit Kapila wrote: > On Sat, Feb 4, 2017 at 5:54 AM, Robert Haas wrote: >> On Wed, Feb 1, 2017 at 12:58 AM, Amit Kapila wrote: > >> On balance, I'm somewhat inclined to think that we ought

Re: [HACKERS] Declarative partitioning - another take

2017-02-08 Thread amul sul
About 0001-Check-partition-strategy-in-ATExecDropNotNull.patch, following test is already covered in alter_table.sql @ Line # 1918, instead of this kindly add test for list_partition: 77 +-- cannot drop NOT NULL constraint of a range partition key column 78 +ALTER TABLE range_parted ALTER a

Re: [HACKERS] WAL consistency check facility

2017-02-08 Thread Kuntal Ghosh
On Thu, Feb 9, 2017 at 2:26 AM, Robert Haas wrote: > On Wed, Feb 8, 2017 at 1:25 AM, Kuntal Ghosh > wrote: >> Thank you Robert for the review. Please find the updated patch in the >> attachment. > > I have committed this patch after fairly

[HACKERS] CREATE COLLATION IF NOT EXISTS

2017-02-08 Thread Peter Eisentraut
Here is a patch to complete the implementation of CREATE COLLATION IF NOT EXISTS. The meat of this was already implemented for pg_import_system_collations; this just exposes it in the SQL command. If we go ahead with ICU, then creating collations by hand will become more common, so this could be

Re: [HACKERS] Declarative partitioning - another take

2017-02-08 Thread Amit Langote
On 2017/02/08 21:20, amul sul wrote: > Regarding following code in ATExecDropNotNull function, I don't see > any special check for RANGE partitioned, is it intended to have same > restriction for LIST partitioned too, I guess not? > > /* > * If the table is a range partitioned table, check

Re: [HACKERS] Logical replication existing data copy

2017-02-08 Thread Erik Rijkers
On 2017-02-08 23:25, Petr Jelinek wrote: 0001-Use-asynchronous-connect-API-in-libpqwalreceiver-v2.patch 0002-Always-initialize-stringinfo-buffers-in-walsender-v2.patch 0003-Fix-after-trigger-execution-in-logical-replication-v2.patch

Re: [HACKERS] Backport of pg_statistics typos fix

2017-02-08 Thread Yugo Nagata
On Wed, 8 Feb 2017 14:54:17 -0500 Robert Haas wrote: > On Tue, Feb 7, 2017 at 4:22 AM, Yugo Nagata wrote: > > I found typos "pg_statistics" in REL9_6_STABLE, but that has been > > fixed in the master branch. > > > > Fix typo: pg_statistics ->

Re: [HACKERS] Improve OR conditions on joined columns.

2017-02-08 Thread Tom Lane
Jim Nasby writes: > AFAICT this can be transformed into a UNION (not all) if dim.id is > unique. Does the upper planner pathification make this any easier? What I did in 9.6 is a first step. The next step, I think, is to replace prepunion.c with something that can

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Jim Nasby
On 2/7/17 9:37 AM, Jonathan S. Katz wrote: Below is the draft of the press release for the update this Thursday: Thanks for the work on this! 11 There existed a race condition if CREATE INDEX CONCURRENTLY was called on a column that had not been indexed before, then rows that were updated

Re: [HACKERS] Logical replication existing data copy

2017-02-08 Thread Petr Jelinek
Hi, here is updated patch. Note that it's rebased on top of logical replication improvements patches [1] (which still apply fine to my surprise). It will probably need another rebase once patches from Masahiko Sawada and Fujii Masao get in. [1]

Re: [HACKERS] contrib modules and relkind check

2017-02-08 Thread Corey Huinker
On Mon, Feb 6, 2017 at 4:01 AM, Amit Langote wrote: > On 2017/01/24 15:35, Amit Langote wrote: > > On 2017/01/24 15:11, Michael Paquier wrote: > >> On Tue, Jan 24, 2017 at 2:14 PM, Amit Langote > >> wrote: > >>> Some contrib

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Jim Nasby
On 2/8/17 2:51 PM, Alvaro Herrera wrote: I always have a bit of mixed feelings with these kind of string manipulations on dynamic SQL. It may look a bit nasty, but locking tables for long periods (or being without an important index for a period) is much worse in production scenarios. I think

[HACKERS] Improve OR conditions on joined columns.

2017-02-08 Thread Jim Nasby
I've a client interested enough in $SUBJECT that they're willing to offer a bounty on it. An example of the pain is (working example attached): create temp view denorm as select f.*, d1.t t1, d2.t t2 from fact f left join dim d1 on f1=d1.id left join dim d2 on f2=d2.id ; --

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Andres Freund
Hi, On 2017-02-08 16:52:19 -0500, Tom Lane wrote: > For my own purposes, the only thing that I find seriously annoying about > the status quo is the amount of time required to run "configure". For > me, that step is usually comparable to or even more than the time to > do the build proper,

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Jim Nasby
On 2/8/17 3:52 PM, Tom Lane wrote: For my own purposes, the only thing that I find seriously annoying about the status quo is the amount of time required to run "configure". For me, that step is usually comparable to or even more than the time to do the build proper, because (a) ccache and (b)

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Tom Lane
Peter Eisentraut writes: > On 2/8/17 6:21 AM, Yuriy Zhuravlev wrote: >> Support two build systems it's not big deal really. I have been working >> on this past year without any big troubles. >> Also we have second perl build system... > The perl/msvc build

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Andres Freund
Hi, On 2017-01-30 10:26:18 -0500, Peter Eisentraut wrote: > On 1/30/17 1:28 AM, Andres Freund wrote: > > Given that fact, I just don't buy why it's a good idea to not also > > replace autoconf initially. > > Well, I find it a bit scary. If you do the big switch all at once, then > you will have

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Peter Eisentraut
On 2/8/17 6:21 AM, Yuriy Zhuravlev wrote: > Support two build systems it's not big deal really. I have been working > on this past year without any big troubles. > Also we have second perl build system... The perl/msvc build system pulls in information from the makefiles. So when you add a file

Re: [HACKERS] Documentation improvements for partitioning

2017-02-08 Thread Corey Huinker
On Fri, Feb 3, 2017 at 4:15 AM, Amit Langote wrote: > Here are some patches to improve the documentation about partitioned > tables: > > 0001: Adds some details about partition_bound_spec to the CREATE TABLE > page, especially: > > - a note about inclusivity of

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

2017-02-08 Thread Robert Haas
On Sat, Feb 4, 2017 at 3:11 PM, Petr Jelinek wrote: > That was the reason why DropSubscription didn't release the lock in the > first place. It was supposed to be released at the end of the > transaction though. Holding an LWLock until end-of-transaction is a

Re: [HACKERS] WAL consistency check facility

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 1:25 AM, Kuntal Ghosh wrote: > Thank you Robert for the review. Please find the updated patch in the > attachment. I have committed this patch after fairly extensive revisions: * Rewrote the documentation to give some idea what the underlying

Re: [HACKERS] Patch: Avoid precision error in to_timestamp().

2017-02-08 Thread Tom Lane
I wrote: > I wonder if we could make things better just by using rint() rather than > a naive cast-to-integer. The cast will truncate not round, and I think > that might be what's mostly biting you. Does this help for you? > #ifdef HAVE_INT64_TIMESTAMP > - result = seconds *

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Alvaro Herrera
Tobias Bussmann wrote: > But I could put this > snippet as a "REINDEX CONCURRENTLY" workaround into the Administrative > Snippets category of the wiki, if there are no further objections > about the way it works. Sounds like a good idea. There are further complications: * you can't DROP

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Tobias Bussmann
Am 08.02.2017 um 20:17 schrieb Alvaro Herrera : > Note that this is likely to fail if the original index name is close to > the 63 chars limit. Perhaps it's enough to add substring() when > computing index_name_tmp. (You could just not use :'index_name' there > and rely

Re: [HACKERS] possibility to specify template database for pg_regress

2017-02-08 Thread Pavel Stehule
Hi 2017-02-08 8:33 GMT+01:00 Pavel Stehule : > > > 2017-02-08 8:30 GMT+01:00 Michael Paquier : > >> On Wed, Feb 8, 2017 at 4:24 PM, Pavel Stehule >> wrote: >> > What is sense for list of databases? >> >> ECPG uses it

Re: [HACKERS] Backport of pg_statistics typos fix

2017-02-08 Thread Robert Haas
On Tue, Feb 7, 2017 at 4:22 AM, Yugo Nagata wrote: > I found typos "pg_statistics" in REL9_6_STABLE, but that has been > fixed in the master branch. > > Fix typo: pg_statistics -> pg_statistic >

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-02-08 Thread Robert Haas
On Tue, Feb 7, 2017 at 3:11 AM, Okano, Naoki wrote: > On Wednesday, November 16, 2016 4:31 PM Okano Naoki wrote: >> > But in any case it would be a serious mistake to do this without first >> > implementing CREATE OR REPLACE TRIGGER. I think that's an entirely >> >

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Alvaro Herrera
Tobias Bussmann wrote: > Am 07.02.2017 um 18:44 schrieb Alvaro Herrera : > > 80 CREATE INDEX CONCURRENTLY bad_index_name ON table_name > > (column_name); /* replace names with your original index definition */ > > I was thinking if we could replace that "replace

Re: [HACKERS] Press Release Draft - 2016-02-09 Cumulative Update

2017-02-08 Thread Tobias Bussmann
Am 07.02.2017 um 18:44 schrieb Alvaro Herrera : > 80 CREATE INDEX CONCURRENTLY bad_index_name ON table_name (column_name); > /* replace names with your original index definition */ I was thinking if we could replace that "replace names with your original index

Re: [HACKERS] pg_bsd_indent: implement -lps ("leave preprocessor space")

2017-02-08 Thread Andres Freund
On 2017-02-07 23:30:44 -0500, Tom Lane wrote: > Piotr Stefaniak writes: > > this is a patch that Andres asked me for. It makes pg_bsd_indent leave > > preprocessor space alone, as in this example: > > > #if 0 > > # if 0 > > # if 0 > > # error > > # endif > >

Re: [HACKERS] multivariate statistics (v19)

2017-02-08 Thread Dean Rasheed
On 8 February 2017 at 16:09, David Fetter wrote: > Combinations are n!/(k! * (n-k)!), so computing those is more > along the lines of: > > unsigned long long > choose(unsigned long long n, unsigned long long k) { > if (k > n) { > return 0; > } > unsigned long

[HACKERS] pg_basebackup -R

2017-02-08 Thread Robert Haas
I just tried out pg_basebackup -R and got the following recovery.conf file: standby_mode = 'on' primary_conninfo = 'user=rhaas passfile=''/home/rhaas/.pgpass'' port=5432 sslmode=disable sslcompression=1 target_session_attrs=any' This seems fairly random to me. pg_basebackup explains:

Re: [HACKERS] Patch: Avoid precision error in to_timestamp().

2017-02-08 Thread Tom Lane
=?UTF-8?Q?Erik_Nordstr=C3=B6m?= writes: > I stumbled upon a precision issue with the to_timestamp() function that > causes it to return unexpected timestamp values. For instance, the query > SELECT to_timestamp(1486480176.236538) returns the timestamp "2017-02-07 >

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread David G. Johnston
On Wed, Feb 8, 2017 at 10:30 AM, Tom Lane wrote: > David Fetter writes: > > On Wed, Feb 08, 2017 at 11:22:56AM -0500, Tom Lane wrote: > >> Yes. I think a new set-operation keyword would inevitably have to > >> be fully reserved --- UNION, INTERSECT, and

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread Tom Lane
David Fetter writes: > On Wed, Feb 08, 2017 at 11:22:56AM -0500, Tom Lane wrote: >> Yes. I think a new set-operation keyword would inevitably have to >> be fully reserved --- UNION, INTERSECT, and EXCEPT all are --- which >> means that you'd break every application that has

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread David Fetter
On Wed, Feb 08, 2017 at 11:22:56AM -0500, Tom Lane wrote: > Robert Haas writes: > > On Wed, Feb 8, 2017 at 4:24 AM, Pantelis Theodosiou > > wrote: > >> I'm not advocating it but I don't see how introducing new SQL keywords > >> breaks backwards

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Tom Lane
Alvaro Herrera writes: > Tom Lane wrote: >> If we did have code for multiple libraries, perhaps some people would >> want to compile all the variants at once; in which case overloading a >> single option to be used for all the libraries would be a problem. > Hmm, I

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Alvaro Herrera
Tom Lane wrote: > Daniel Gustafsson writes: > > Since we hopefully will support more SSL libraries than OpenSSL at some > > point, > > and we don’t want a torrent of configure options, wouldn’t this be better as > > --with-server-ciphers=STRING or something similar? > > One

Re: [HACKERS] GSoC 2017

2017-02-08 Thread Pavel Stehule
2017-02-08 17:06 GMT+01:00 Robert Haas : > On Mon, Feb 6, 2017 at 6:51 AM, Ruben Buchatskiy wrote: > > 2017-01-10 12:53 GMT+03:00 Alexander Korotkov >: > >> 1. What project ideas we have? > > > > We would like to propose a

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Tom Lane
Daniel Gustafsson writes: > Since we hopefully will support more SSL libraries than OpenSSL at some point, > and we don’t want a torrent of configure options, wouldn’t this be better as > --with-server-ciphers=STRING or something similar? One of the reasons I'm not very

[HACKERS] Patch: Avoid precision error in to_timestamp().

2017-02-08 Thread Erik Nordström
Hello hackers, I stumbled upon a precision issue with the to_timestamp() function that causes it to return unexpected timestamp values. For instance, the query SELECT to_timestamp(1486480176.236538) returns the timestamp "2017-02-07 16:09:36.236537+01", which is off by one microsecond. Looking at

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread Tom Lane
Robert Haas writes: > On Wed, Feb 8, 2017 at 4:24 AM, Pantelis Theodosiou > wrote: >> I'm not advocating it but I don't see how introducing new SQL keywords >> breaks backwards compatibility. > It does at least a little bit. Yes. I think a new

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Daniel Gustafsson
> On 08 Feb 2017, at 13:31, Pavel Raiskup wrote: > > On Wednesday, February 8, 2017 1:29:19 PM CET Pavel Raiskup wrote: >> On Wednesday, February 8, 2017 1:05:08 AM CET Tom Lane wrote: >>> Peter Eisentraut writes: On 2/7/17 11:21 AM,

Re: [HACKERS] multivariate statistics (v19)

2017-02-08 Thread David Fetter
On Wed, Feb 08, 2017 at 03:23:25PM +, Dean Rasheed wrote: > On 6 February 2017 at 21:26, Alvaro Herrera wrote: > > Tomas Vondra wrote: > >> On 02/01/2017 11:52 PM, Alvaro Herrera wrote: > > > >> > Nearby, some auxiliary functions such as n_choose_k and > >> >

Re: [HACKERS] drop support for Python 2.3

2017-02-08 Thread Andrew Dunstan
On 02/07/2017 11:49 PM, Tom Lane wrote: > Peter Eisentraut writes: >> I would like to propose that we drop support for Python 2.3. >> ... >> We do have buildfarm coverage on prairiedog. However, that runs a >10 >> year old operating system, so I think it is

Re: [HACKERS] GSoC 2017

2017-02-08 Thread Robert Haas
On Mon, Feb 6, 2017 at 6:51 AM, Ruben Buchatskiy wrote: > 2017-01-10 12:53 GMT+03:00 Alexander Korotkov : >> 1. What project ideas we have? > > We would like to propose a project on rewriting PostgreSQL executor from > > traditional Volcano-style [1] to

Re: [HACKERS] chomp PQerrorMessage() in backend uses

2017-02-08 Thread Tom Lane
Peter Eisentraut writes: > Here is a patch to systematically trim the trailing newlines off > PQerrorMessage() results in backend uses (dblink, postgres_fdw, > libpqwalreceiver). +1 > I noticed that there are some inconsistent assumptions about whether >

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 8:58 AM, Dilip Kumar wrote: > On Wed, Feb 8, 2017 at 7:01 PM, Robert Haas wrote: >> You can store whatever you want in SH_TYPE's private_data member. >> SH_ALLOCATE and SH_FREE both get a pointer to the SH_TYPE, so they >> have

Re: [HACKERS] pageinspect: Hash index support

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 9:25 AM, Ashutosh Sharma wrote: >>> 1) Check if an overflow page is a new page. If so, read a bitmap page >>> to confirm if a bit corresponding to this overflow page is clear or >>> not. For this, I would first add Assert statement to ensure that the

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

2017-02-08 Thread Petr Jelinek
On 08/02/17 07:40, Masahiko Sawada wrote: > On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier > wrote: >> On Wed, Feb 8, 2017 at 1:30 AM, Fujii Masao wrote: >>> On Wed, Feb 8, 2017 at 12:26 AM, Petr Jelinek >>> wrote:

Re: [HACKERS] drop support for Python 2.3

2017-02-08 Thread Devrim Gündüz
Hi, On Wed, 2017-02-08 at 09:16 -0500, Peter Eisentraut wrote: > It appears that we don't have anything running 2.4.  A RHEL/CentOS 5 > system with standard components would be a good addition to the build farm. I have CentOS 5 instances running on buildfarm. I'll register them via

Re: [HACKERS] multivariate statistics (v19)

2017-02-08 Thread Dean Rasheed
On 6 February 2017 at 21:26, Alvaro Herrera wrote: > Tomas Vondra wrote: >> On 02/01/2017 11:52 PM, Alvaro Herrera wrote: > >> > Nearby, some auxiliary functions such as n_choose_k and >> > num_combinations are not documented. What it is that they do? I'd >> > move these

Re: [HACKERS] One-shot expanded output in psql using \gx

2017-02-08 Thread David Fetter
On Wed, Feb 08, 2017 at 03:52:40PM +0100, Christoph Berg wrote: > Re: David Fetter 2017-02-07 <20170207051659.gc3...@fetter.org> > > On Mon, Feb 06, 2017 at 08:54:13PM +0100, Christoph Berg wrote: > > > The majority of voices here was in favor of using \gx, so here is > > > another version of the

Re: [HACKERS] One-shot expanded output in psql using \gx

2017-02-08 Thread Christoph Berg
Re: David Fetter 2017-02-07 <20170207051659.gc3...@fetter.org> > On Mon, Feb 06, 2017 at 08:54:13PM +0100, Christoph Berg wrote: > > The majority of voices here was in favor of using \gx, so here is > > another version of the same patch which implements that. > > Patch is useful, and works as

[HACKERS] chomp PQerrorMessage() in backend uses

2017-02-08 Thread Peter Eisentraut
Here is a patch to systematically trim the trailing newlines off PQerrorMessage() results in backend uses (dblink, postgres_fdw, libpqwalreceiver). I noticed that there are some inconsistent assumptions about whether PQerrorMessage() can ever return NULL. From the code, I think that should not

Re: [HACKERS] pageinspect: Hash index support

2017-02-08 Thread Ashutosh Sharma
>> 1) Check if an overflow page is a new page. If so, read a bitmap page >> to confirm if a bit corresponding to this overflow page is clear or >> not. For this, I would first add Assert statement to ensure that the >> bit is clear and if it is, then set the statusbit as false indicating >> that

Re: [HACKERS] drop support for Python 2.3

2017-02-08 Thread Peter Eisentraut
On 2/7/17 11:49 PM, Tom Lane wrote: > Hm, is there anything running 2.4 in the buildfarm? If we're going to > claim support for 2.4, we'd be well advised to test it. It appears that we don't have anything running 2.4. A RHEL/CentOS 5 system with standard components would be a good addition to

Re: [HACKERS] LWLock optimization for multicore Power machines

2017-02-08 Thread Bernd Helmle
Am Dienstag, den 07.02.2017, 16:48 +0300 schrieb Alexander Korotkov: > But win isn't > as high as I observed earlier.  And I wonder why absolute numbers are > lower > than in our earlier experiments.  We used IBM E880 which is actually > two Did you run your tests on bare metal or were they also

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Dilip Kumar
On Wed, Feb 8, 2017 at 7:01 PM, Robert Haas wrote: > You can store whatever you want in SH_TYPE's private_data member. > SH_ALLOCATE and SH_FREE both get a pointer to the SH_TYPE, so they > have access to that. Hmm, but there's no way to get that set in > SH_CREATE before

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 1:59 AM, Dilip Kumar wrote: > IIUC, tbm_prepare_shared_iterate will be called only by the leader, > for tbmiterator as well as for the prefetch_iterator. And, > tbm_attach_shared_iterate will be called by each backend and for both > the iterators.

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 4:24 AM, Pantelis Theodosiou wrote: > I'm not advocating it but I don't see how introducing new SQL keywords > breaks backwards compatibility. It does at least a little bit. This starts failing: select 1 new_keyword form blah; (now you have to insert

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 4:20 AM, Dilip Kumar wrote: > The new SH_CREATE(MemoryContext ctx, uint32 nelements) don't have any > option to supply arguments to it. Our callback functions need access > to TBM. > > Is it expected that if the user of SH_CREATE who doesn't want to

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Robert Haas
On Wed, Feb 8, 2017 at 5:21 AM, Dilip Kumar wrote: > On Wed, Feb 8, 2017 at 3:44 AM, Robert Haas wrote: +#ifndef SH_USE_NONDEFAULT_ALLOCATOR + >>> >>> That should probably be documented in the file header. >> >> Right. OK, did that and a

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-02-08 Thread Ashutosh Bapat
> > 0004-hj-refactor-batch-increases-v4.patch: > > Modify the existing hash join code to detect work_mem exhaustion at > the point where chunks are allocated, instead of checking after every > tuple insertion. This matches the logic used for estimating, and more > importantly allows for some

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Pavel Raiskup 
On Wednesday, February 8, 2017 1:29:19 PM CET Pavel Raiskup wrote:
> On Wednesday, February 8, 2017 1:05:08 AM CET Tom Lane wrote:
> > Peter Eisentraut  writes:
> > > On 2/7/17 11:21 AM, Tom Lane wrote:
> > >> A compromise that might be worth considering is

Re: [HACKERS] [PATCH] configure-time knob to set default ssl ciphers

2017-02-08 Thread Pavel Raiskup
On Wednesday, February 8, 2017 1:05:08 AM CET Tom Lane wrote: > Peter Eisentraut writes: > > On 2/7/17 11:21 AM, Tom Lane wrote: > >> A compromise that might be worth considering is to introduce > >> #define PG_DEFAULT_SSL_CIPHERS "HIGH:MEDIUM:+3DES:!aNULL" > >>

Re: [HACKERS] Declarative partitioning - another take

2017-02-08 Thread amul sul
Hi Amit, Regarding following code in ATExecDropNotNull function, I don't see any special check for RANGE partitioned, is it intended to have same restriction for LIST partitioned too, I guess not? /* * If the table is a range partitioned table, check that the column is not * in the

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Yuriy Zhuravlev
2017-01-28 1:50 GMT+03:00 Michael Paquier : > On Fri, Jan 27, 2017 at 11:09 PM, Peter Eisentraut > wrote: > > On 1/24/17 8:37 AM, Tom Lane wrote: > >> Craig Ringer writes: > >>> Personally I think we

Re: [HACKERS] WIP: About CMake v2

2017-02-08 Thread Yuriy Zhuravlev
> > I don't understand what this has to do with cmake. If this is a > worthwhile improvement for the Windows build, then please explain why, > with a "before" and "after" output and a patch for the existing build > system as well. During the porting process, I meet such situations when I should

Re: [HACKERS] pg_stat_wal_write statistics view

2017-02-08 Thread Amit Kapila
On Tue, Feb 7, 2017 at 11:47 AM, Haribabu Kommi wrote: > Hi Hackers, > > I just want to discuss adding of a new statistics view that provides > the information of wal writing details as follows > +1. I think it will be useful to observe WAL activity. > postgres=# \d

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2017-02-08 Thread Thomas Munro
On Wed, Feb 8, 2017 at 8:40 PM, Thomas Munro wrote: > On Tue, Feb 7, 2017 at 5:43 PM, Peter Geoghegan wrote: >> Does anyone have any suggestions on how to tackle this? > > Hmm. One approach might be like this: > > [hand-wavy stuff] Thinking a bit

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Dilip Kumar
On Wed, Feb 8, 2017 at 3:44 AM, Robert Haas wrote: >>> +#ifndef SH_USE_NONDEFAULT_ALLOCATOR >>> + >> >> That should probably be documented in the file header. > > Right. OK, did that and a few other cleanups, and committed. I think we need to have prototype for the

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-08 Thread Amit Kapila
On Tue, Feb 7, 2017 at 5:14 PM, Mithun Cy wrote: > On Tue, Feb 7, 2017 at 12:24 PM, Amit Kapila wrote: >> On Tue, Feb 7, 2017 at 11:53 AM, Beena Emerson >> wrote: >>> Are 2 workers required? >>> >> >> I think in the

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread Pantelis Theodosiou
On Tue, Feb 7, 2017 at 3:13 PM, Joel Jacobson wrote: > Hi hackers, > > Currently there is no simple way to check if two sets are equal. > > Looks like no RDBMS in the world has a simple command for it. > > You have to do something like: > > ... > > Introducing new SQL keywords

Re: [HACKERS] Parallel bitmap heap scan

2017-02-08 Thread Dilip Kumar
On Wed, Feb 8, 2017 at 3:44 AM, Robert Haas wrote: >>> +#ifndef SH_USE_NONDEFAULT_ALLOCATOR >>> + >> >> That should probably be documented in the file header. > > Right. OK, did that and a few other cleanups, and committed. The new SH_CREATE(MemoryContext ctx, uint32

Re: [HACKERS] Idea on how to simplify comparing two sets

2017-02-08 Thread Pantelis Theodosiou
On Tue, Feb 7, 2017 at 3:58 PM, Tom Lane wrote: > Joel Jacobson writes: > > Currently there is no simple way to check if two sets are equal. > > Uh ... maybe check whether SELECT set1 EXCEPT SELECT set2 > and SELECT set2 EXCEPT SELECT set1 are both empty? >