Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-01 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 2:48 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Magnus Hagander wrote: On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: This is a review of the patch in 5192d7d2.8020...@catalyst.net.nz The patch applies cleanly (with the exception

Re: [HACKERS] Documentation/help for materialized and recursive views

2013-07-01 Thread Magnus Hagander
hostile. However, we don't do anything that remotely resembles that statement, nor has anyone proposed any such thing. Personally, I think this whole thread is much ado about nothing. Magnus is basically arguing that people might expect that CREATE VIEW ought to tell you about CREATE

Re: [HACKERS] Documentation/help for materialized and recursive views

2013-06-28 Thread Magnus Hagander
On Fri, Jun 28, 2013 at 5:54 AM, Kevin Grittner kgri...@ymail.com wrote: Robert Haas robertmh...@gmail.com wrote: Magnus Hagander mag...@hagander.net wrote: The functionality of materialized views will (over time) totally swamp that of normal views, so mixing all the corresponding

Re: [HACKERS] Documentation/help for materialized and recursive views

2013-06-28 Thread Magnus Hagander
On Fri, Jun 28, 2013 at 4:49 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Magnus Hagander escribió: They are already crosslinked under see also. But that doesn't really help the guy doing \h CREATE VIEW in psql, which was the case where it was brought to my attention. Maybe \h should

[HACKERS] Documentation/help for materialized and recursive views

2013-06-27 Thread Magnus Hagander
particular reason to split those up in the first place? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Documentation/help for materialized and recursive views

2013-06-27 Thread Magnus Hagander
On Thu, Jun 27, 2013 at 10:56 AM, Nicolas Barbier nicolas.barb...@gmail.com wrote: 2013/6/27 Magnus Hagander mag...@hagander.net: Is there a particular reason why CREATE RECURSIVE VIEW is part of the help for CREATE VIEW, but CREATE MATERIALIZED VIEW doesn't show up there? I realize

Re: [HACKERS] PostgreSQL 9.3 latest dev snapshot

2013-06-27 Thread Magnus Hagander
. Generating those snapshots on the git server is slow and expensive... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] Min value for port

2013-06-27 Thread Magnus Hagander
Is there a reason why we have set the min allowed value for port to 1, not 1024? Given that you can't actually start postgres with a value of 1024, shoulnd't the entry in pg_settings reference that as well? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com

Re: [HACKERS] Min value for port

2013-06-27 Thread Magnus Hagander
On Thu, Jun 27, 2013 at 2:16 PM, Peter Eisentraut pete...@gmx.net wrote: On 6/27/13 6:34 AM, Magnus Hagander wrote: Is there a reason why we have set the min allowed value for port to 1, not 1024? Given that you can't actually start postgres with a value of 1024, shoulnd't the entry

Re: [HACKERS] Implementing incremental backup

2013-06-20 Thread Magnus Hagander
something similar to this? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Config reload/restart preview

2013-06-20 Thread Magnus Hagander
sends off a SIGHUP when it does a reload. We'd have to give it an actual interface that could return data back as well, such as a socket of some kind. So it does take some work to come up with. But I definitely think we should have something like this. -- Magnus Hagander Me: http

Re: [HACKERS] Config reload/restart preview

2013-06-20 Thread Magnus Hagander
On Thu, Jun 20, 2013 at 2:54 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Magnus Hagander mag...@hagander.net writes: Should we have a way of previewing changes that would be applied if we reloaded/restarted the server? Yes, we should. +1 This would go well with something I started

Re: [HACKERS] How do we track backpatches?

2013-06-19 Thread Magnus Hagander
On Wed, Jun 19, 2013 at 4:44 AM, Peter Eisentraut pete...@gmx.net wrote: On Tue, 2013-06-18 at 12:32 +0200, Magnus Hagander wrote: The CF app was and is specifically for dealing with CFs. Having it deal with backpatches makes it, well, a bugtracker. It's not meant to be that. If we want

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Magnus Hagander
? Shouldn't it just be auto.conf? Or system.auto.conf? I prefer auto.conf, personally. Well, not much about it is automatic, really. It's just set elsewhere. True, but can you think of a better word to mean don't edit this by hand? generated_by_server.conf System.conf? /Magnus

Re: [HACKERS] How do we track backpatches?

2013-06-19 Thread Magnus Hagander
we have the Open Items wiki page for those? Seems to work well enough. Yes. The CF app only tracks things that already have patches. For the beta, we really need to track things that may not have been fixed - or that may have been done, just only partially so far. -- Magnus Hagander Me: http

Re: [HACKERS] How do we track backpatches?

2013-06-18 Thread Magnus Hagander
different requirements. Having an always-open CF would defeat the workflow. But since those patches are typically going into HEAD as well, why not just a commitfest *topic* for it, on whatever commitfest happens to be the open one? Then it'll get processed within the existing workflow. -- Magnus

Re: [HACKERS] Clean switchover

2013-06-12 Thread Magnus Hagander
just use a faster shutdown method (e.g. immediate) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Clean switchover

2013-06-12 Thread Magnus Hagander
closing the replication connection. Imo this is a fix that needs to get backpatched... The code tried to do this but failed, I don't think it really gives grounds for valid *new* concerns. +1 (without having looked at the code itself, it's definitely a behaviour that needs to be fixed) -- Magnus

Re: [HACKERS] Hard limit on WAL space used (because PANIC sucks)

2013-06-12 Thread Magnus Hagander
the files off is typically a great way to loose data, and we really shouldn't encourage that by default, Imo. /Magnus

Re: [HACKERS] Make targets of doc links used by phpPgAdmin static

2013-06-06 Thread Magnus Hagander
, but release docs are only loaded on release day. /Magnus

Re: [HACKERS] units in postgresql.conf comments

2013-05-30 Thread Magnus Hagander
a unit seems like a much better idea. That way, there is no way for confusion. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Running pgindent

2013-05-28 Thread Magnus Hagander
? wfm. +1. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] New committers

2013-05-27 Thread Magnus Hagander
. My apologies for forgetting to announce it here, and another welcome to the team to our new guys! /Magnus

Re: [HACKERS] proposal: option --application_name for psql

2013-05-14 Thread Magnus Hagander
enough to have it's own argument if other parameters don't. And you can still set it as long as you use psql in connection string mode, as you can with all the libpq parameters. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers

Re: [HACKERS] proposal: option --application_name for psql

2013-05-14 Thread Magnus Hagander
On Tue, May 14, 2013 at 9:36 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2013/5/14 Magnus Hagander mag...@hagander.net: psql in connection string mode Hi Magnus, can me send some link? http://www.postgresql.org/docs/9.2/static/app-psql.html If this parameter contains an = sign or starts

Re: [HACKERS] Commit subject line

2013-05-06 Thread Magnus Hagander
nor the kernel adhere to that limit... FWIW, the tool we use to generate the commit emails truncate it at 80 (minus the pgsql: header). We can increase that, but it only fixes the email one, and not the one that people look at on the web... -- Magnus Hagander Me: http://www.hagander.net/ Work

Re: [HACKERS] Commit subject line

2013-05-06 Thread Magnus Hagander
On Mon, May 6, 2013 at 4:47 PM, Andrew Dunstan and...@dunslane.net wrote: On 05/06/2013 10:19 AM, Magnus Hagander wrote: On Fri, May 3, 2013 at 9:07 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-05-03 14:54:23 -0400, Andrew Dunstan wrote: On 05/03/2013 02:43 PM, Tom Lane wrote

Re: [HACKERS] Recovery target 'immediate'

2013-05-02 Thread Magnus Hagander
On Thu, May 2, 2013 at 8:55 AM, Simon Riggs si...@2ndquadrant.com wrote: On 26 April 2013 18:13, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 26.04.2013 19:50, Magnus Hagander wrote: On Fri, Apr 26, 2013 at 6:43 PM, Simon Riggssi...@2ndquadrant.com wrote: On 26 April 2013 17:25

Re: [HACKERS] Recovery target 'immediate'

2013-04-26 Thread Magnus Hagander
pg_basebackup -x (or similar), therefor not needing the log archive at all when restoring. Yes, it makes the base backup slightly larger, but also much simpler... As a bonus, your base backup would still work if you hosed your log archive. -- Magnus Hagander Me: http://www.hagander.net/ Work: http

Re: [HACKERS] Recovery target 'immediate'

2013-04-26 Thread Magnus Hagander
to get a quick look at the state of things before recovering further. I assume that would work as well, since it would be a recovery target like the others.. /Magnus

Re: [HACKERS] Recovery target 'immediate'

2013-04-26 Thread Magnus Hagander
a cleaner syntax to break those. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] TODO links broken?

2013-04-17 Thread Magnus Hagander
i tried all worked... made that we don't have to support the historical URLs for our archives pages, I think that's a really bad plan; those links are in a lot more places than just the Todo. No, the plan has always been to support those. There are no plans to remove that. -- Magnus

Re: [HACKERS] TODO links broken?

2013-04-17 Thread Magnus Hagander
On Wed, Apr 17, 2013 at 3:14 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 17, 2013 at 8:48 AM, Magnus Hagander mag...@hagander.net wrote: Yes. We can infer that. It makes it a whole lot easier to fix something with better bug repors than that, of course, as I'm sure you (Robert

Re: [HACKERS] Extra security measures for next week's releases

2013-04-03 Thread Magnus Hagander
, but there will be no official patch for 8.3. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Orphaned files after initdb

2013-04-01 Thread Magnus Hagander
are the others from? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Orphaned files after initdb

2013-04-01 Thread Magnus Hagander
On Mon, Apr 1, 2013 at 9:09 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2013-04-01 20:43:36 +0200, Magnus Hagander wrote: Maybe my thinking is just missing something obvious here. But looking at a fresh initdb, I'm seeing a number of files in the data directory for this database

Re: [HACKERS] Orphaned files after initdb

2013-04-01 Thread Magnus Hagander
On Mon, Apr 1, 2013 at 10:53 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-04-01 21:24:06 +0200, Magnus Hagander wrote: On Mon, Apr 1, 2013 at 9:09 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2013-04-01 20:43:36 +0200, Magnus Hagander wrote: Maybe my thinking is just

Re: [HACKERS] Getting to 9.3 beta

2013-03-29 Thread Magnus Hagander
to push another one just one (or even two) weeks after that would be rushing it unnecessarily... Of course, that doesn't prevent from starting work on the release notes meanwhile :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] Interesting post-mortem on a near disaster with git

2013-03-25 Thread Magnus Hagander
by the invalid push that Kevin did a short while ago... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Materialized views vs event triggers missing docs?

2013-03-20 Thread Magnus Hagander
? If it's just a doc thing - perhaps this is a table we should somehow try to autogenerate? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [pgsql-advocacy] Call for Google Summer of Code mentors, admins

2013-03-20 Thread Magnus Hagander
on that one. I'd think that's a killer for that idea... /Magnus

Re: [HACKERS] backward incompatible pg_basebackup and pg_receivexlog

2013-03-19 Thread Magnus Hagander
it, and can give a nice error message telling the user how to deal with it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] leaking lots of unreferenced inodes (pg_xlog files?), maybe after moving tables and indexes to tablespace on different volume

2013-03-13 Thread Magnus Hagander
. I confess I can't guess what. Yeah, unreferenced inodes with no open files, and only discoverable with fsck sounds like a filsystem bug to me. Particularly since it showed up just after a operating system upgrade, and doesn't go away with a postgres restart... /Magnus

Re: [HACKERS] Reporting hba lines

2013-03-10 Thread Magnus Hagander
On Sun, Jan 20, 2013 at 5:56 PM, Dean Rasheed dean.a.rash...@gmail.com wrote: On 5 January 2013 16:58, Magnus Hagander mag...@hagander.net wrote: Attached is an updated version of the patch, per the comments from Tom and rebased on top of the current master. Since it's been a long time ago

Re: [HACKERS] Matview patch added rewriteDefine.c.orig to the repository

2013-03-04 Thread Magnus Hagander
it, and also see the email to hackers a few hours ago telling committers to stop pushing until it's fixed. /Magnus

[HACKERS] Bug in tm2timestamp

2013-03-04 Thread Magnus Hagander
needs an extra exclusion for this special case? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Hold all commits!

2013-03-04 Thread Magnus Hagander
On Mon, Mar 4, 2013 at 8:34 AM, Magnus Hagander mag...@hagander.net wrote: Committers, please hold *all* pushes to the PostgreSQL repository until we have resolved the issue mentioned in http://www.postgresql.org/message-id/cabuevezm2f8qaxvds9me-41l5bqeego4duoscqhc0c6v05h...@mail.gmail.com

Re: [HACKERS] Bug in tm2timestamp

2013-03-04 Thread Magnus Hagander
On Mon, Mar 4, 2013 at 8:54 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: AFAICT, there's a bug in tm2timestamp(). You can't do this: postgres=# select '1999-12-31T24:00:00'::timestamptz; ERROR: timestamp out of range: 1999-12-31T24:00:00 But that's

[HACKERS] Hold all commits!

2013-03-03 Thread Magnus Hagander
, and you may need to re-push it again anyway.. So please just hold off until we've sorted out that issue. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [DOCS] Contrib module xml2 status

2013-02-21 Thread Magnus Hagander
+1 on changing the deprecation message. And don't forget to backpatch the change so it shows up in the old versions of the docs as well. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] streaming header too small

2013-02-20 Thread Magnus Hagander
? /Magnus

Re: [HACKERS] streaming header too small

2013-02-20 Thread Magnus Hagander
On Wed, Feb 20, 2013 at 4:53 PM, Selena Deckelmann sel...@chesnok.com wrote: On Wed, Feb 20, 2013 at 6:23 AM, Magnus Hagander mag...@hagander.net wrote: On Feb 20, 2013 11:29 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 20.02.2013 02:11, Selena Deckelmann wrote: So, I

Re: [HACKERS] [pgsql-advocacy] Call for Google Summer of Code mentors, admins

2013-02-18 Thread Magnus Hagander
. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Documentation: references to old versions

2013-02-12 Thread Magnus Hagander
in general that contains such references, it could be dropped. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Documentation: references to old versions

2013-02-12 Thread Magnus Hagander
On Tue, Feb 12, 2013 at 4:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Feb 12, 2013 at 10:19 AM, Dave Page dp...@pgadmin.org wrote: The phrasing as of 8.2 basically means from 8.2 onwards. Changing the version there would make the text incorrect

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-11 Thread Magnus Hagander
On Mon, Feb 11, 2013 at 5:01 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Magnus Hagander escribió: On Sun, Feb 10, 2013 at 3:25 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I changed the defaults for new subscribers, and also the flags values for all existing subscribers, note

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-11 Thread Magnus Hagander
On Mon, Feb 11, 2013 at 2:44 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Magnus Hagander escribió: On Mon, Feb 11, 2013 at 5:01 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Magnus Hagander escribió: On Sun, Feb 10, 2013 at 3:25 AM, Alvaro Herrera alvhe...@2ndquadrant.com

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-10 Thread Magnus Hagander
On Sun, Feb 10, 2013 at 3:25 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Magnus Hagander escribió: On Sat, Feb 9, 2013 at 4:31 PM, Peter Geoghegan peter.geoghega...@gmail.com wrote: On 9 February 2013 15:24, Magnus Hagander mag...@hagander.net wrote: It's in your personal majordomo

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-09 Thread Magnus Hagander
it off. //Magnus On Sat, Feb 9, 2013 at 4:17 PM, Gurjeet Singh gurj...@singh.im wrote: Recently I have started getting these confirmations for every email I send to the mailing lists. I think it's related to the fact that I recently switched to using a new email address. How can I turn

Re: [HACKERS] Fwd: Successful post to pgsql-hackers

2013-02-09 Thread Magnus Hagander
On Sat, Feb 9, 2013 at 4:31 PM, Peter Geoghegan peter.geoghega...@gmail.com wrote: On 9 February 2013 15:24, Magnus Hagander mag...@hagander.net wrote: It's in your personal majordomo settings. I don't think it's related to that at all, but it's a flag you set on your subscription, so perhaps

Re: [HACKERS] Considering Gerrit for CFs

2013-02-08 Thread Magnus Hagander
broken to any newcomer. I agree it's way too many step. Several of those can certainly be made more efficient now that we have a more sane archives, well within the scope of the current system. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via

Re: [HACKERS] Comment typo

2013-02-08 Thread Magnus Hagander
On Fri, Feb 8, 2013 at 6:49 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: I found a comment typo. Please find attached a patch. Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Considering Gerrit for CFs

2013-02-08 Thread Magnus Hagander
On Fri, Feb 8, 2013 at 4:20 PM, Peter Eisentraut pete...@gmx.net wrote: On 2/8/13 5:23 AM, Magnus Hagander wrote: But do you have any actual proof that the problem is in we loose reviewers because we're relying on email? Here is one: Me. Just yesterday I downloaded a piece of software

Re: [HACKERS] [COMMITTERS] pgsql: Stamp 9.1.8.

2013-02-08 Thread Magnus Hagander
On Fri, Feb 8, 2013 at 6:53 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, Feb 8, 2013 at 11:09 AM, Kevin Grittner kgri...@ymail.com wrote: Magnus Hagander mag...@hagander.net wrote: if there is any other committer who [wants to receive emails from the packagers list], let me know and I

Re: [HACKERS] Considering Gerrit for CFs

2013-02-07 Thread Magnus Hagander
and forth between the CF app and your mail reader. But it's still only on the annoyance side, I think the process in general is not broken. (That said, I *have* been on the inside a long time, *and* I live in Stockholm, so I might well have that syndrome) -- Magnus Hagander Me: http://www.hagander.net

Re: [HACKERS] Considering Gerrit for CFs

2013-02-07 Thread Magnus Hagander
to happen) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Considering Gerrit for CFs

2013-02-06 Thread Magnus Hagander
with 128Mb RAM... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Visual Studio 2012 RC

2013-02-05 Thread Magnus Hagander
. As long as it's fairly standalone and doesn't change the actual cost around (mobile atm so i couldn't look at the actual patch), that seems like the right idea to me. /Magnus

Re: [HACKERS] [PATCH] Add PQconninfoParseParams and PQconninfodefaultsMerge to libpq

2013-02-02 Thread Magnus Hagander
essentially exposes conninfo_add_defaults(). It allows you to pass a PQconninfoOption struct and it adds defaults for all NULL values. There are no docs yet. I assumed I would let bikeshedding ensue, and also debate on whether we even want these first. I think you forgot to attach the patch. /Magnus

Re: [HACKERS] pg_basebackup with -R option and start standby have problems with escaped password

2013-01-29 Thread Magnus Hagander
On Thu, Jan 24, 2013 at 7:04 AM, Hari Babu haribabu.ko...@huawei.com wrote: On Wed, Jan 23, 2013 11:48 PM, Magnus Hagander wrote: On Wed, Jan 23, 2013 at 10:18 AM, Hari Babu haribabu.ko...@huawei.com wrote: Test scenario to reproduce: 1. Start the server 2. create the user

Re: Review of pg_basebackup and pg_receivexlog to use non-blocking socket communication, was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-28 Thread Magnus Hagander
On Tue, Jan 22, 2013 at 7:31 AM, Amit Kapila amit.kap...@huawei.com wrote: On Monday, January 21, 2013 6:22 PM Magnus Hagander On Fri, Jan 18, 2013 at 7:50 AM, Amit Kapila amit.kap...@huawei.com wrote: On Wednesday, January 16, 2013 4:02 PM Heikki Linnakangas wrote: On 07.01.2013 16:23

[HACKERS] Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables

2013-01-25 Thread Magnus Hagander
On Sun, Jan 20, 2013 at 4:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: + PGresult *res = ExecuteSqlQueryForSingleRow(fout, SELECT pg_is_in_recovery()); That function call needs to be schema-qualified for security. Applied and backpatched

[HACKERS] Re: [COMMITTERS] pgsql: Make pg_dump exclude unlogged table data on hot standby slaves

2013-01-25 Thread Magnus Hagander
On Fri, Jan 25, 2013 at 1:59 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-01-25 13:56:11 +0100, Magnus Hagander wrote: On Fri, Jan 25, 2013 at 1:31 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-01-25 08:49:10 +, Magnus Hagander wrote: Make pg_dump exclude unlogged

Re: [HACKERS] [sepgsql 1/3] add name qualified creation label

2013-01-24 Thread Magnus Hagander
it will be 2.1.9 that's included in the next debian stable. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-24 Thread Magnus Hagander
to do it for you, but I'm pretty sure it's impossible to do it as an archive_command there. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-24 Thread Magnus Hagander
On Thu, Jan 24, 2013 at 6:25 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Thu, Jan 24, 2013 at 6:04 PM, Peter Eisentraut pete...@gmx.net wrote: I think it might be better to just document this as an example. I don't quite see the overhead

Re: [HACKERS] pg_basebackup with -R option and start standby have problems with escaped password

2013-01-23 Thread Magnus Hagander
recovery.conf file look like? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-21 Thread Magnus Hagander
On Mon, Jan 21, 2013 at 9:01 AM, Andrew Dunstan and...@dunslane.net wrote: On 01/21/2013 02:17 AM, Magnus Hagander wrote: On Jan 21, 2013 3:06 AM, Craig Ringer cr...@2ndquadrant.com mailto:cr...@2ndquadrant.com wrote: On 01/21/2013 10:03 AM, Craig Ringer wrote: On 01/19/2013 04:08 AM

Re: Review of pg_basebackup and pg_receivexlog to use non-blocking socket communication, was: Re: [HACKERS] Re: [BUGS] BUG #7534: walreceiver takes long time to detect n/w breakdown

2013-01-21 Thread Magnus Hagander
or something else), it might be generic and can be used for others as well but it might need few interface changes. If it's specifying them that is cumbersome, then that's the part we should fix, rather than modifying the protocol, no? -- Magnus Hagander Me: http://www.hagander.net/ Work: http

Re: [HACKERS] Making testing on Windows easier

2013-01-21 Thread Magnus Hagander
starting each build step takes significantly longer. We've also added some things like the DEF file magic that can definitely take quite some time, particularly when building the backend. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-21 Thread Magnus Hagander
it for users that have logged in at least once. But that wouldn't be a problem for this scenario as they would have already logged in to post said link. /Magnus

[HACKERS] Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables

2013-01-20 Thread Magnus Hagander
On Tue, Jan 15, 2013 at 10:35 PM, Magnus Hagander mag...@hagander.net wrote: On Tue, Jan 15, 2013 at 12:13 AM, j...@tanga.com wrote: The following bug has been logged on the website: Bug reference: 7809 Logged by: Joe Van Dyk Email address: j...@tanga.com PostgreSQL

Re: [HACKERS] dividing privileges for replication role.

2013-01-20 Thread Magnus Hagander
missing something? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables

2013-01-20 Thread Magnus Hagander
On Sun, Jan 20, 2013 at 4:59 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: + PGresult *res = ExecuteSqlQueryForSingleRow(fout, SELECT pg_is_in_recovery()); That function call needs to be schema-qualified for security. Ha! I wonder if I can

Re: [HACKERS] Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

2013-01-20 Thread Magnus Hagander
or blocks something else, we should try to keep it working. And as you say this sounds like something that can be handled trivially, I think now is not the time. /Magnus

Re: [HACKERS] Passing connection string to pg_basebackup

2013-01-19 Thread Magnus Hagander
* support connection strings. And, an important point, do it the same way. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Passing connection string to pg_basebackup

2013-01-19 Thread Magnus Hagander
it and it didn't work. We pushed the whole implementation to next version (and then forgot about actually putting it in the next version, until now) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] CF3+4

2013-01-17 Thread Magnus Hagander
discussed, it should certainly not be open for accepting new patches for 9.3 anymore. /Magnus

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-17 Thread Magnus Hagander
for them to do a second-stage review even if somebody else has done the first one. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] review: pgbench - aggregation of info written into log

2013-01-17 Thread Magnus Hagander
that, then we can commit it as a partial feature, but if we just hope someone picks it up, that's leaving it very loose.. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] review: pgbench - aggregation of info written into log

2013-01-17 Thread Magnus Hagander
On Thu, Jan 17, 2013 at 11:09 AM, Dave Page dp...@pgadmin.org wrote: On Thu, Jan 17, 2013 at 9:36 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Jan 17, 2013 at 2:35 AM, Tatsuo Ishii is...@postgresql.org wrote: This might be way more than we want to do, but there is an article

Re: [HACKERS] Multiple --table options for other commands

2013-01-17 Thread Magnus Hagander
. Attached is a v6 patch, with no tabs in docs and based off the latest head. I'm marking it ready for committer. Thanks. Applied, with only some small whitespace changes. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers

Re: [HACKERS] review: pgbench - aggregation of info written into log

2013-01-17 Thread Magnus Hagander
-downloads-and-installs it as necessary we can get around that) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] small pg_basebackup display bug

2013-01-17 Thread Magnus Hagander
On Sun, Dec 16, 2012 at 7:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Sat, Dec 15, 2012 at 2:24 PM, Erik Rijkers e...@xs4all.nl wrote: That would make such a truncation less frequent, and after all a truncated display is not particular useful

Re: [HACKERS] default SSL compression (was: libpq compression)

2013-01-17 Thread Magnus Hagander
On Wed, Jan 2, 2013 at 3:17 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jan 2, 2013 at 3:15 PM, Noah Misch n...@leadboat.com wrote: On Wed, Jan 02, 2013 at 02:03:20PM +0100, Magnus Hagander wrote: On Wed, Jan 2, 2013 at 1:15 AM, Tom Lane t...@sss.pgh.pa.us wrote: So +1 for changing

Re: [HACKERS] Parallel query execution

2013-01-16 Thread Magnus Hagander
and discussing things that will happen that far ahead is definitely not focusing on review. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-16 Thread Magnus Hagander
put more work into it. We also talked about the one-patch-one-review. Did someone ever check if that worked out - did we get that spread, or did we end up with the same ratio as last time? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] CF3+4 (was Re: Parallel query execution)

2013-01-16 Thread Magnus Hagander
to nominate Craig Ringer to be independent CF mgr for Jan2013 CF. If he's willing to do that, then +1 from me. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] Re: [BUGS] BUG #7809: Running pg_dump on slave w/ streaming replication fails if there are unlogged tables

2013-01-15 Thread Magnus Hagander
of saying could not open file, could we find a way to say this is an unlogged table on a slave, it's not going to work? We can fix pg_dump the easy way, but what about custom tools... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] pg_retainxlog for inclusion in 9.3?

2013-01-14 Thread Magnus Hagander
On Sat, Jan 5, 2013 at 3:11 PM, Magnus Hagander mag...@hagander.net wrote: On Fri, Jan 4, 2013 at 7:13 PM, Peter Eisentraut pete...@gmx.net wrote: On 1/3/13 12:30 PM, Robert Haas wrote: On Thu, Jan 3, 2013 at 11:32 AM, Magnus Hagander mag...@hagander.net wrote: Any particular reason? It goes

<    6   7   8   9   10   11   12   13   14   15   >