Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

2017-08-16 Thread Peter Eisentraut
m (in my >> understanding this means the same hardware architecture and OS) in >> streaming replication. > > Yep, I recall the same requirement. He meant logical replication, but the code in question here is the same for streaming replication, or whatever it's called. -- Pet

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot.

2017-08-16 Thread Peter Eisentraut
On 8/14/17 13:57, Andres Freund wrote: > On 2017-08-14 13:55:29 -0400, Peter Eisentraut wrote: >> On 8/12/17 07:32, Petr Jelinek wrote: >>> This commit has side effect that it makes it possible to export >>> snapshots on the standbys. This makes it possible to do pg_

Re: [HACKERS] Broken link to DocBook XSL Stylesheets

2017-08-16 Thread Peter Eisentraut
7;t appear to have any website at all anymore. So better leave all of that rot consistently. ;-) ) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@post

Re: [HACKERS] Logical replication: stuck spinlock at ReplicationSlotRelease

2017-08-16 Thread Peter Eisentraut
On 6/23/17 20:58, Peter Eisentraut wrote: > On 6/23/17 16:15, Andres Freund wrote: >> On 2017-06-23 13:26:58 -0400, Alvaro Herrera wrote: >>> Hmm, so for instance in LogicalIncreaseRestartDecodingForSlot() we have >>> some elog(DEBUG1) calls with the slot spinlock held.

Re: [HACKERS] 10 beta docs: different replication solutions

2017-08-16 Thread Peter Eisentraut
On 7/30/17 21:34, Steve Singer wrote: > We don't seem to describe logical replication on > > https://www.postgresql.org/docs/10/static/different-replication-solutions.html > > The attached patch adds a section. Committed with some further tweaking, thanks!

Re: [HACKERS] Function to move the position of a replication slot

2017-08-16 Thread Peter Eisentraut
where in this thread, this patch needs several changes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] SCRAM salt length

2017-08-16 Thread Peter Eisentraut
(SCRAM-SHA-256) section 3 uses a length of 16. Should we use that instead? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make change

Re: [HACKERS] Fixup some misusage of appendStringInfo and friends

2017-08-15 Thread Peter Eisentraut
On 4/26/17 20:14, David Rowley wrote: > On 27 April 2017 at 06:41, Peter Eisentraut > wrote: >> On 4/19/17 08:42, Ashutosh Bapat wrote: >>> I reviewed the patch. It compiles clean, make check-world passes. I do >>> not see any issue with it. >> >> Loo

Re: [HACKERS] replication_slot_catalog_xmin not explicitly initialized when creating procArray

2017-08-15 Thread Peter Eisentraut
On 7/9/17 21:23, Masahiko Sawada wrote: > On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen wrote: >> replication_slot_catalog_xmin is not explictly initialized to >> InvalidTransactionId. > Thank you for the patch. This change makes sense to me. Committed and backpatched --

Re: [HACKERS] The error message "sorry, too many clients already" is imprecise

2017-08-15 Thread Peter Eisentraut
sons. There are other places that also emit the "sorry" message that would also need to be looked at. Also, the patch would need to be against master. This kind of patch to make error messages more precise is usually welcome, so keep working on it. But this needs a bit more refinement as

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-08-15 Thread Peter Eisentraut
have committed that version. I think the exit message can be useful, because pg_receivewal will usually run as some kind of background process where the exit status might be not be visible. I have also committed a small documentation patch to describe the exit status and behavior better. -

Re: [HACKERS] Foreign tables privileges not shown in information_schema.table_privileges

2017-08-15 Thread Peter Eisentraut
nal? A patch is attached if not. Fix committed to all branches. Thanks! -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

Re: [HACKERS] tab complete for psql pset pager values

2017-08-15 Thread Peter Eisentraut
On 7/26/17 11:02, Pavel Stehule wrote: > attached trivial patch for missing tab complete for \pset pager setting committed (back to 9.6) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent vi

Re: [HACKERS] A suspicious code in pgoutput_startup().

2017-08-15 Thread Peter Eisentraut
"we only support protocol %d or lower". Is this intentional? > Or should this be fixed as below? > > 176 if (data->protocol_version > LOGICALREP_PROTO_VERSION_NUM) > > Attached is a simple patch in case of fixing. Fixed, thanks. -- Peter Eisentraut

Re: [HACKERS] Logical replication message type 'Y' is missing in docs

2017-08-15 Thread Peter Eisentraut
On 8/9/17 20:22, Masahiko Sawada wrote: > There is a type of logical replication message 'Y' for data types, but > it's not documented in section 52.9. Logical Replication Message > Formats. Attached patch fixes this. I think it can be PG10 item. Committed with s

Re: [HACKERS] A little improvementof ApplyLauncherMain loop code

2017-08-15 Thread Peter Eisentraut
Fixed, thanks! -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PDF content lemma subdivision

2017-08-15 Thread Peter Eisentraut
tries/lemmata, like > 'CREATE TABLE'. It doesn't go any deeper anymore. I have committed a fix for this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing li

Re: [HACKERS] What users can do with custom ICU collations in Postgres 10

2017-08-15 Thread Peter Eisentraut
this into the hands of users. Here is a small piece of documentation. Thoughts? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From a9d5926b68eb6e0e726b7c9838f6ea8b3b22a157 Mon Sep 17 00:00:00 2001 From: Peter

Re: [HACKERS] What users can do with custom ICU collations in Postgres 10

2017-08-15 Thread Peter Eisentraut
On 8/14/17 12:15, Peter Eisentraut wrote: > Given that we cannot reasonably preload all these new variants that you > demonstrated, I think it would make sense to drop all the keyword > variants from the preloaded set. After playing with this a bit, I'm having some doubts. Whil

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

2017-08-15 Thread Peter Eisentraut
On 8/14/17 10:57, Tom Lane wrote: > I think we could commit add-connected-event-2.patch and call this > issue resolved. Would you like to commit your patch then? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-08-14 Thread Peter Eisentraut
On 3/11/17 07:06, Pavel Stehule wrote: > I am sending a updated version with separated sort direction in special > variable This patch also needs a rebase. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: [HACKERS] SQL/JSON in PostgreSQL

2017-08-14 Thread Peter Eisentraut
On 3/15/17 11:56, David Steele wrote: >> This patch has been moved to CF 2017-07. > > I did not manage to move this patch when I said had. It is now moved. Unsurprisingly, this patch needs a major rebase. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] postgres_fdw: evaluate placeholdervars on remote server

2017-08-14 Thread Peter Eisentraut
res 10. Therefore I think we should move this to the next >> CF. > > Honestly, I'm not satisfied with this patch and I think it would need > more work. Moved to the next CF. This patch needs to be rebased for the upcoming commit fest. -- Peter Eisentraut

Re: [HACKERS] Statement-level rollback

2017-08-14 Thread Peter Eisentraut
pcoming commit fest. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] make async slave to wait for lsn to be replayed

2017-08-14 Thread Peter Eisentraut
On 3/9/17 07:49, Ivan Kartyshov wrote: > Here I attached rebased patch waitlsn_10dev_v3 (core feature) > I will leave the choice of implementation (core/contrib) to the > discretion of the community. This patch is registered in the upcoming commit fest, but it needs to be rebased.

Re: [HACKERS] pg_stat_wal_write statistics view

2017-08-14 Thread Peter Eisentraut
On 3/29/17 22:10, Haribabu Kommi wrote: > Updated patch to use shared counter instead of adding pg_stat_ calls to send > the statistics from each background process/worker. Your patch needs to be rebased and the OID assignments updated. -- Peter Eisentraut http

Re: [HACKERS] Protect syscache from bloating with negative cache entries

2017-08-14 Thread Peter Eisentraut
mat-patch -U5 fuses all hunks on cacheinfo[] together. I'm > not sure that such a hunk can avoid rebases. Is this what you > suggested? -U4 added an identifiable forward context line for > some elements so the attached patch is made with four context > lines. This patch needs anothe

Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

2017-08-14 Thread Peter Eisentraut
On 4/4/17 01:06, Haribabu Kommi wrote: > Both pg_dump and pg_upgrade tests are passed. Updated patch attached > I will add this patch to the next commitfest. This patch needs to be rebased for the upcoming commit fest. -- Peter Eisentraut http://www.2ndQuadrant.com/ Post

Re: [HACKERS] pgbench more operators & functions

2017-08-14 Thread Peter Eisentraut
On 5/24/17 03:14, Fabien COELHO wrote: > I've improved it in attached v11: > - add a link to the CASE full documentation > - add an example expression with CASE ... This patch needs (at least) a rebase for the upcoming commit fest. -- Peter Eisentraut http://www.2

Re: [HACKERS] Re: new set of psql patches for loading (saving) data from (to) text, binary files

2017-08-14 Thread Peter Eisentraut
mmit fest. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Add Roman numeral conversion to to_number

2017-08-14 Thread Peter Eisentraut
leading/trailing zeros, filling in spaces and signs, and so on. None of that applies naturally to Roman numerals, so there isn't a strong case for including that into these functions, when a separate function or module could do. There are probably a bunch of Perl or Python modu

Re: [HACKERS] Foreign tables privileges not shown in information_schema.table_privileges

2017-08-14 Thread Peter Eisentraut
econsider, but it would be to be a separate discussion. I think I would fix #1 and #2 with back patches but no catversion change. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

Re: [HACKERS] Re: [COMMITTERS] pgsql: Don't force-assign transaction id when exporting a snapshot.

2017-08-14 Thread Peter Eisentraut
dumping from PG10+. > > I also wonder if it should be mentioned in release notes. If the > attached patch would make it into PG10 it would be no brainer to mention > it as feature under pg_dump section, but exporting snapshots alone I am > not sure about. Any other opinions on this p

Re: [HACKERS] Fix a typo in sequence.c

2017-08-14 Thread Peter Eisentraut
On 8/14/17 08:32, Masahiko Sawada wrote: > While reading source code, I found a typo in sequence.c file. Attached > patch for fixing it. > > s/localy/locally/g Fixed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote D

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-14 Thread Peter Eisentraut
onded to all these subplots now, but the discussion is ongoing. I will set the next check-in to Thursday. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@po

Re: [HACKERS] What users can do with custom ICU collations in Postgres 10

2017-08-14 Thread Peter Eisentraut
ocuses on the "old" @keyword=value syntax. I guess we'll have to write our own for now. Given that we cannot reasonably preload all these new variants that you demonstrated, I think it would make sense to drop all the keyword variants from the preloaded set. -- Peter Eisentraut

Re: [HACKERS] ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-14 Thread Peter Eisentraut
t; that it hasn't heard of. I'm not sure what you are proposing here. Convert the input to CREATE COLLATION to a BCP 47 language tag? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via p

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

2017-08-14 Thread Peter Eisentraut
original commit with an #ifndef WIN32. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www

[HACKERS] additional contrib test suites

2017-08-11 Thread Peter Eisentraut
seful. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 65b09d5b15b43c7eab24aae2d2e7e7a7979d57f3 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Fri, 11 Aug 2017 21:04:04 -0400 Subject: [PATCH 1/7] admin

Re: [HACKERS] Thoughts on unit testing?

2017-08-11 Thread Peter Eisentraut
ctions, edge cases etc can be hard to > get full test coverage on from the outside. Consider > src/backend/utils/mmgr/freepage.c as a case in point. I don't have a good idea how to address this, but I agree that something in this area would be widely useful. -- Peter Eisentraut

Re: [HACKERS] SCRAM protocol documentation

2017-08-11 Thread Peter Eisentraut
ay slightly different things. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] SCRAM protocol documentation

2017-08-11 Thread Peter Eisentraut
he long term. Please note that the > specification says that both the username and the password must be > encoded in UTF-8, so we are not completely compliant here. If there is > something to address, that would be this part. So we already handle passwords. Can't we handl

[HACKERS] coverage analysis improvements

2017-08-10 Thread Peter Eisentraut
fest. Testing with different versions of tools would be especially valuable. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 3c8a2c6afb3a8873a70c61c427128bb4d1cade2b Mon Sep 17 00:00:00 2001 From: Peter

Re: [HACKERS] Getting server crash on Windows when using ICU collation

2017-08-10 Thread Peter Eisentraut
eter E has a patch to fix the other issue (ICU 52 has a buggy >> ucol_strcollUTF8()) by never using it on ICU versions prior to 53. He >> posted this just yesterday. > > He committed it just now, so that's the end of this Windows issue, I suppose. Yes, I think so. --

[HACKERS] SCRAM protocol documentation

2017-08-10 Thread Peter Eisentraut
#x27;t we just send the actual user name, even though it's redundant with the startup message? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgres

Re: [HACKERS] How can I find a specific collation in pg_collation when using ICU?

2017-08-09 Thread Peter Eisentraut
erver, which means > Japanese, case-insensitive, and accent sensitive. There are no case-insensitive collations in PostgreSQL (yet). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-h

Re: [HACKERS] [BUGS] Replication to Postgres 10 on Windows is broken

2017-08-08 Thread Peter Eisentraut
stgreSQL 10 open item. Peter, > since you committed the patch believed to have created it, you own this open > item. I don't think I can usefully contribute to this. Could someone else take it? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24

Re: [HACKERS] ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-07 Thread Peter Eisentraut
llations and use that. It's more than most people need, sure, but it doesn't cost us anything. The alternatives are hand-maintaining a list of collations, or installing no collations by default. Both of those are arguably worse for users or for future code maintenance or both. -- Pet

Re: [HACKERS] xmltable SQL conformance

2017-08-07 Thread Peter Eisentraut
yntax is ignored in Postgres if I understand. This means that you pass in the document to work on, which is supported. Thanks for your input. I have updated the features list accordingly. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA

Re: [HACKERS] Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values

2017-08-07 Thread Peter Eisentraut
On 8/5/17 18:56, Noah Misch wrote: >> [Action required within three days. This is a generic notification.] I'm awaiting further testing and discussion. Probably nothing happening for beta3. Will report on Thursday. -- Peter Eisentraut http://www.2ndQuadrant.com/

Re: [HACKERS] Notice message of ALTER SUBSCRIPTION ... RERESH PUBLICATIION

2017-08-07 Thread Peter Eisentraut
the attached patch. This also fixes the message > when a table is removed from a subscription. Fixed, thanks. (Note that per another discussion, these are now DEBUG messages.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA

Re: [HACKERS] Subscription code improvements

2017-08-07 Thread Peter Eisentraut
en we create a subscription about which tables >> are part of it. So why do we need such messages when we refresh a >> subscription? > > I think that the messages is useful when we add/remove tables to/from > the publication and then refresh the subscription, so we might wan

Re: [HACKERS] Subscription code improvements

2017-08-07 Thread Peter Eisentraut
On 8/7/17 00:32, Masahiko Sawada wrote: > On Sun, Aug 6, 2017 at 7:44 AM, Noah Misch wrote: >> On Wed, Aug 02, 2017 at 04:09:43PM -0400, Peter Eisentraut wrote: >>> On 8/1/17 00:17, Noah Misch wrote: >>>> The above-described topic is currently a PostgreSQL 10 ope

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-05 Thread Peter Eisentraut
On 8/1/17 11:28, Peter Eisentraut wrote: > On 8/1/17 08:28, Victor Wagner wrote: >> On Tue, 1 Aug 2017 08:16:54 -0400 >> Peter Eisentraut wrote: >> >>> On 8/1/17 02:12, Victor Wagner wrote: >>>>> We are only calling uloc_toLanguageTag() with key

Re: [HACKERS] Subscription code improvements

2017-08-04 Thread Peter Eisentraut
have a good idea > though. Maybe we can just remove those messages? We don't get messages when we create a subscription about which tables are part of it. So why do we need such messages when we refresh a subscription? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreS

Re: [HACKERS] AlterUserStmt anmd RoleSpec rules in grammar.y

2017-08-03 Thread Peter Eisentraut
On 7/31/17 20:42, Peter Eisentraut wrote: > That looks like a bug to me. ALTER USER also does not support the IN > DATABASE clause, so the code deviation might have started there already. > > I propose the attached patch to clean this up. > > For backpatching, I could develop

[HACKERS] elog vs errmsg_internal

2017-08-03 Thread Peter Eisentraut
Is there a preferred method to select between using elog() and errmsg_internal()? Attached is a patch that converts some DEBUG messages to one of those two to remove them from translation, but I'm not sure which one to pick other than by random aesthetics. -- Peter Eisentraut

[HACKERS] xmltable SQL conformance

2017-08-03 Thread Peter Eisentraut
ult option X304XMLTable: passing a context item It looks so to me, but maybe you know more. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq

Re: [HACKERS] Subscription code improvements

2017-08-03 Thread Peter Eisentraut
arlier patch makes the tablesync work itself responsible for exiting. Do you wish to comment which direction to pursue? (Doing both might also be an option?) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --

Re: [HACKERS] Why does logical replication launcher exit with exit code 1?

2017-08-02 Thread Peter Eisentraut
On 8/2/17 16:52, Robert Haas wrote: > I actually don't think it's that unreasonable to get notified when > system-wide processes like the autovacuum launcher or the logical > replication launcher start or stop. But we got rid of those start messages recently due to com

Re: [HACKERS] Why does logical replication launcher exit with exit code 1?

2017-08-02 Thread Peter Eisentraut
ps as DEBUG)? A few months ago, people were complaining about too many messages about background workers starting. Now we are having complaints about messages about background workers stopping. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: [HACKERS] Subscription code improvements

2017-08-02 Thread Peter Eisentraut
m all fixed > well in advance of shipping v10. Consequently, I will appreciate your efforts > toward speedy resolution. Thanks. I'm looking into this now and will report by Friday. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: [HACKERS] reload-through-the-top-parent switch the partition table

2017-08-02 Thread Peter Eisentraut
d be more general. But I'm also OK with "restore". -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Macros bundling RELKIND_* conditions

2017-08-02 Thread Peter Eisentraut
ctual error, from the perspective of the user, is something like ERROR: "someview" is a view DETAIL: Views cannot have constraints. (Maybe they can. This is an example.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remo

Re: [HACKERS] Re: [BUGS] BUG #14758: Segfault with logical replication on a function index

2017-08-02 Thread Peter Eisentraut
On 8/1/17 16:29, Peter Eisentraut wrote: > On 8/1/17 00:21, Noah Misch wrote: >> On Mon, Jul 31, 2017 at 09:40:34AM +0900, Masahiko Sawada wrote: >>> On Sat, Jul 29, 2017 at 4:35 AM, Scott Milliken wrote: >>>> Thank you Masahiko! I've tested and confirmed tha

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Peter Eisentraut
t; Is this a typo? > > Looks like it. Fix committed to master. I don't intend to backpatch it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Re: [BUGS] BUG #14758: Segfault with logical replication on a function index

2017-08-01 Thread Peter Eisentraut
t;> >> Thank you for the testing. This issue should be added to the open item >> since this cause of the server crash. I'll add it. > > [Action required within three days. This is a generic notification.] I'm looking into this now and will report back on Thursday

Re: [HACKERS] [PATCH] A hook for session start

2017-08-01 Thread Peter Eisentraut
Still nobody has presented a concrete use case so far. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to yo

Re: [HACKERS] [PATCH] A hook for session start

2017-08-01 Thread Peter Eisentraut
On 7/20/17 07:47, Yugo Nagata wrote: > Another patch, session_start_sample.patch, is a very simple > example of this hook that changes work_mem values for sessions > of a specific database. I think test modules should go into src/test/modules/ instead of contrib. -- Peter E

Re: [HACKERS] [PATCH] A hook for session start

2017-08-01 Thread Peter Eisentraut
just want to execute the prepared > statement. Isn't that what the preprepare extension does already? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pgbench minor doc typo

2017-08-01 Thread Peter Eisentraut
ied to head/10/9.6. done -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] More flexible LDAP auth search filters?

2017-08-01 Thread Peter Eisentraut
or specifying search filters in LDAP URLs. See RFC 4516 for the format and https://linux.die.net/man/3/ldap_url_parse for the API. You might just need to grab LDAPURLDesc.lud_filter and use it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: [HACKERS] [GENERAL] Not able to create collation on Windows

2017-08-01 Thread Peter Eisentraut
tead, don't know for sure. > > I think this is actually a bug, because the collations code clearly > means to allow clones of the C/POSIX locales --- see eg lc_collate_is_c, You seem to say that we should support a "POSIX" locale even on systems where the C library does

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Peter Eisentraut
On 8/1/17 08:28, Victor Wagner wrote: > On Tue, 1 Aug 2017 08:16:54 -0400 > Peter Eisentraut wrote: > >> On 8/1/17 02:12, Victor Wagner wrote: >>>> We are only calling uloc_toLanguageTag() with keyword/value >>>> combinations that ICU itself previousl

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-08-01 Thread Peter Eisentraut
CU is broken. But what choice we have? I don't know that we can already reach that conclusion. Maybe the APIs have changed or we are not using them correctly. Are there any bug reports or changelog entries related to this? I don't think we should just give up and ignore errors. --

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-31 Thread Peter Eisentraut
On 7/31/17 16:54, Tom Lane wrote: > Maybe "which" isn't the best tool for the job, not sure. Yeah, "which" is not portable. This would need a bit more work and portability testing. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Developme

Re: [HACKERS] AlterUserStmt anmd RoleSpec rules in grammar.y

2017-07-31 Thread Peter Eisentraut
an oversight? If it's > intentional, what's the reasoning? That looks like a bug to me. ALTER USER also does not support the IN DATABASE clause, so the code deviation might have started there already. I propose the attached patch to clean this up. For backpatching, I could develo

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-31 Thread Peter Eisentraut
eem proper in this case. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] building libpq.a static library

2017-07-31 Thread Peter Eisentraut
On 7/12/17 11:11, Tom Lane wrote: > FWIW, we used to have support for building static libpq, but > we got rid of it a long time ago. I couldn't find the exact > spot in some desultory trawling of the commit history. We still build and install static libraries. -- Pe

Re: [HACKERS] Fix a typo in pg_upgrade/info.c

2017-07-31 Thread Peter Eisentraut
On 7/13/17 03:22, Masahiko Sawada wrote: > Hi, > > Attached patch for $subject. > > s/reporing/reporting/g fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] Another comment typo in execMain.c

2017-07-31 Thread Peter Eisentraut
elf. > */ > > I think that in the second sentence "it" just before "if" is a typo. > Attached is a small patch for fixing that. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training

Re: [HACKERS] [PATCH] Pattern based listeners for asynchronous messaging (LISTEN/NOTIFY)

2017-07-31 Thread Peter Eisentraut
the syntax, like you have with LISTEN SIMILAR TO. It would even be nice if a non-built-in operator could be used for matching names. Documentation is missing in the patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &a

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-31 Thread Peter Eisentraut
On 7/31/17 15:38, Tom Lane wrote: > Peter Eisentraut writes: >> One major PITA with the AC_PATH_* checks is that you can only override >> them with environment variables that are full paths; otherwise the >> environment variables are ignored. For example, currently, runn

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-31 Thread Peter Eisentraut
On 7/31/17 15:17, Peter Eisentraut wrote: > On 7/31/17 14:55, Tom Lane wrote: >>> We use the "PATH" variants when we need a fully qualified name. For >>> example, at some point or another, we needed to substitute a fully >>> qualified perl binary name into

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-31 Thread Peter Eisentraut
thon3 will result in the PYTHON setting being ignored. Currently, this only affects a small number of variables, but if we expanded that, it would be a pretty significant usability change. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-31 Thread Peter Eisentraut
lly qualified perl binary name into the headers of scripts. If there is no such requirement, then we should use the non-PATH variants. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent

Re: [HACKERS] Definitional questions for pg_sequences view

2017-07-24 Thread Peter Eisentraut
On 7/20/17 16:36, Tom Lane wrote: > What exactly is the point of the new pg_sequences view? It is analogous to pg_tables, pg_matviews, pg_indexes, and other such system views that are sort of half-way between system catalogs and information schema. -- Peter Eisentraut http://

Re: [HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-07-05 Thread Peter Eisentraut
ks like an open item to me. Cleaning up the pool queries after > promotion would be nice to see as well. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] outfuncs.c utility statement support

2017-07-05 Thread Peter Eisentraut
On 6/21/17 23:40, Tom Lane wrote: > Peter Eisentraut writes: >> On 6/18/17 10:14, Tom Lane wrote: >>> Doesn't cope with backslash-quoted characters. If we're going to bother >>> to do anything here, I think we ought to make it reversible for all >&

Re: [HACKERS] [BUGS] BUG #14699: Statement trigger and logical replication

2017-07-03 Thread Peter Eisentraut
On 6/17/17 08:29, Euler Taveira wrote: > 2017-06-16 22:08 GMT-03:00 Peter Eisentraut > <mailto:peter.eisentr...@2ndquadrant.com>>: > > > The issue is that the logical replication initial data copy fires a > statement trigger for INSERT, because

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-07-03 Thread Peter Eisentraut
commit major code rearrangements without specific reasons and detailed analysis. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Error while copying a large file in pg_rewind

2017-07-03 Thread Peter Eisentraut
lso, most of the segment and file sizes are configurable, and we have had reports of people venturing into much larger file sizes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hac

Re: [HACKERS] Code quality issues in ICU patch

2017-07-01 Thread Peter Eisentraut
On 6/30/17 08:13, Peter Eisentraut wrote: > On 6/24/17 11:51, Tom Lane wrote: >> Ah, I was about to suggest the same thing, but I was coming at it from >> the standpoint of not requiring buffers several times larger than >> necessary, which could in itself cause avoidable pal

Re: [HACKERS] Fix a typo in aclchk.c

2017-06-30 Thread Peter Eisentraut
On 6/30/17 03:58, Masahiko Sawada wrote: > Attached patch for $subject. > > s/entires/entries/ fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (

[HACKERS] Re: pg_ctl wait exit code (was Re: [COMMITTERS] pgsql: Additional tests for subtransactions in recovery)

2017-06-30 Thread Peter Eisentraut
On 5/1/17 12:19, Peter Eisentraut wrote: > On 4/27/17 08:41, Michael Paquier wrote: >> +$node_slave->promote; >> +$node_slave->poll_query_until('postgres', >> + "SELECT NOT pg_is_in_recovery()") >> + or die "Timed out while waiting for p

Re: [HACKERS] Typo in comment in postgres_fdw.c

2017-06-30 Thread Peter Eisentraut
On 6/28/17 09:53, Albe Laurenz wrote: > Attached is a fix for a small typo I found. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-

Re: [HACKERS] [PATCH] doc: Fix typo

2017-06-30 Thread Peter Eisentraut
configure. As an alternative, you can often use the > + configure. As an alternative, you can also use the >BSD-licensed libedit library, originally >developed on NetBSD. The >libedit library is > I don't think this was a typo. -- Peter Eisentraut

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

2017-06-30 Thread Peter Eisentraut
On 6/27/17 20:54, Amit Langote wrote: > Attached fixes $SUBJECT. > > s/fetch_ckpt/fetching_ckpt/g committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailin

Re: [HACKERS] Misleading comment in slru.h

2017-06-30 Thread Peter Eisentraut
t; > That comment is out of date: commit 638cf09e extended SLRUs to support > 5 character names to support pg_multixact and commit 73c986ad extended > support to 6 character SLRU file names for pg_commit_ts. > > Should we just remove that comment? done -- Peter Eisentraut

Re: [HACKERS] Incorrect mentions to pg_xlog in walmethods.c/h

2017-06-30 Thread Peter Eisentraut
On 6/27/17 01:26, Michael Paquier wrote: > I have noticed $subject. A patch is attached. Those comments are not > completely wrong either as pg_basebackup can generate pg_xlog as well, > still I would recommend to just mention "pg_wal". committed -- Peter Eisentraut

<    1   2   3   4   5   6   7   8   9   10   >