Hi Andres and Peter,
Please see below for inline responses to your feedback. New patch attached.
On Wed, Nov 8, 2017 at 10:01 AM, Andres Freund wrote:
> +set min_parallel_table_scan_size = 0;
> +set parallel_setup_cost = 0;
> +-- Make a simple relation with well distributed keys and correctly
>
On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro
wrote:
> I've only tested the attached lightly on FreeBSD + OpenLDAP and
> don't know if it'll work elsewhere.
While rebasing this on top of a nearby changes, I looked into how
portable it is. The previous version unconditionally
On Sun, Nov 12, 2017 at 8:51 PM, Amit Kapila wrote:
> On Sun, Nov 12, 2017 at 9:18 AM, Thomas Munro
> wrote:
>> How about parallel_leader_participation = on|off? The attached
>> version has it that way, and adds regression tests to exercise on, off
>> and off-but-couldn
On Sat, Oct 21, 2017 at 8:09 AM, Robert Haas wrote:
> On Tue, Oct 17, 2017 at 7:27 AM, Thomas Munro
> wrote:
>> While testing parallelism work I've wanted to be able to prevent
>> gather nodes from running the plan in the leader process, and I've
>> heard othe
On Sat, Nov 11, 2017 at 8:37 AM, Peter Eisentraut
wrote:
> On 11/6/17 23:30, Michael Paquier wrote:
>> On Fri, Nov 3, 2017 at 12:57 PM, Thomas Munro
>> wrote:
>>> 1. If you set up a pg_hba.conf with a URL that lacks a base DN or
>>> hostname, hba.c will seg
On Tue, Nov 7, 2017 at 6:39 PM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Thomas Munro
>> I have often wanted $SUBJECT and was happy to find that Fujii-san had posted
>> a patch fi
On Thu, Nov 9, 2017 at 6:27 PM, Tom Lane wrote:
> Thomas Munro writes:
>> On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane wrote:
>>> Is the AC_SEARCH_LIBS configure call needed to make PG build with the
>>> FreeBSD package?
>
>> Yes. My take is that the commi
#x27;s shouting about.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Nov 8, 2017 at 5:57 PM, Amit Khandekar wrote:
> On 8 November 2017 at 07:55, Thomas Munro
> wrote:
>> On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas wrote:
>>> The changes to trigger.c still make me super-nervous. Hey THOMAS
>>> MUNRO, any chance you could r
.1.1 installed (Apache-licensed Apple Bonjour code)
and the mdnsd daemon started. If I don't start mdnsd it shows an
error at startup. When built against the (conflicting)
avahi-libdns-0.6.31_2 package it shows the WARNING you reported and
"DNSServiceRegister() failed: error code -65537&
y
> 'dns_sd' is required for Bonjour])])
>
> fi
Hi Luke,
It lives in libSystem.dylib (implicitly linked) on macOS, so that
would break the build there. We'd need something a bit more
conditional, but I don't know what.
--
Thomas Munro
http://www.enterprisedb.com
es (also for list_parted) in the upcoming v23
> patch.
That looks good. Thanks.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas wrote:
> The changes to trigger.c still make me super-nervous. Hey THOMAS
> MUNRO, any chance you could review that part?
Looking, but here's one silly thing that jumped out at me while
getting started with this patch. I cannot seem to
arate ResourceOwnerEnlargeXXX() interface is
to be able to put it before resource acquisition.
The existing OpenTemporaryFile() coding has the same mistake. Please
see attached.
[1]
https://www.postgresql.org/message-id/20171107210155.kuksdd324kgz5oev%40alap3.anarazel.de
--
Thomas Munro
djusted. The
counter goes up when you create, and goes down when you close or
resowner closes for you. Eventually you either close and the
bookkeeping is consistent or you crash and it doesn't matter. And
some kind of freak multiple close attempt is guarded against by
setting the files size
change is probably not needed for my patch set (theory
not tested). I will put it in a separate patch as requested by
Andres, because it's generally a good idea anyway for the reasons that
Robert explained (ie you probably always want to clean up memory last,
since it might contain the meta-data/locks/control objects/whatever
you'll need to clean up anything else).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
x_%3DDO-Gu-MfPW3VQ4qC7TfVdH2zHmvZfrGv6fQ3D-Tw%40mail.gmail.com
--
Thomas Munro
http://www.enterprisedb.com
pg-stat-statements-planning-v1.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mail
very sorry I couldn't reply to your kind offer. I rebased the
> patch and will add it to CF 2017/11. I hope I will complete the patch
> in this CF.
Hi Tsunakawa-san,
With your v2 patch "make docs" fails. Here is a small patch to apply
on top of yours to fix that and s
upgrade test
in
src/bin/pg_dump/t/002_pg_dump.pl fails for me:
# Failed test 'binary_upgrade: dumps ALTER TEXT SEARCH CONFIGURATION
dump_test.alt_ts_conf1 ...'
# at t/002_pg_dump.pl line 6715.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pg
/postgres/src/test/regress/data/constro.data';
-COPY COPY_TBL FROM '@abs_srcdir@/data/constrf.data';
+COPY COPY_TBL FROM '/home/nico/ws/postgres/src/test/regress/data/constrf.data';
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql
d this project on).
+ /* Make a temporary clause list for selectivity calcuation */
s/calcuation/calculation/
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
n stuff), as far as I can tell in a good
way. Can you please double check those changes and post an updated
patch?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Oct 31, 2017 at 10:43 PM, Kyotaro HORIGUCHI
wrote:
> Hello, this is a rebased version.
Hello Horiguchi-san,
I think the "ddl" test under contrib/test_decoding also needs to be
updated because it looks at pg_replication_slots and doesn't expect
your new columns.
--
On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro
wrote:
> That
> said, I've only tested the attached lightly on FreeBSD + OpenLDAP and
> don't know if it'll work elsewhere.
Oops, that version's TAP test was a little too dependent on my
system's ldap.conf fil
#x27;t know if it'll work elsewhere. Thoughts?
--
Thomas Munro
http://www.enterprisedb.com
ldaps-v1.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t
can't see this code due to macros.)
Please see attached.
--
Thomas Munro
http://www.enterprisedb.com
ldap-fixes.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 3, 2017 at 2:24 PM, Peter Geoghegan wrote:
> Thomas Munro wrote:
>> That way you don't have to opt in to BufFile's
>> double buffering and segmentation schemes just to get shared file
>> clean-up, if for some reason you want direct file handles.
>
&
On Wed, Nov 1, 2017 at 2:11 PM, Peter Geoghegan wrote:
> On Tue, Oct 31, 2017 at 5:07 PM, Thomas Munro
> wrote:
>> Another complaint is that perhaps fd.c
>> knows too much about buffile.c's business. For example,
>> RemovePgTempFilesInDir() knows about the
On Mon, Oct 30, 2017 at 1:49 PM, Thomas Munro
wrote:
> A couple of stupid things outstanding:
>
> 1. EXPLAIN ANALYZE for Parallel Hash "actual" shows the complete row
> count, which is interesting to know (or not? maybe I should show it
> somewhere else?), but the cost
eriving from various different frozen versions of the
Unicode standard in the source tree, and that might affect some proper
languages.
🤔
[1] http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
'flat' (pointer-free) object I could stick in
relocatable shared memory. In the newest version I changed that
flexible array to tablespaces[8], because 8 should be enough
tablespaces for anyone (TM). I don't really believe anyone uses
temp_tablespaces for IO load balancing anymore
On Tue, Aug 1, 2017 at 9:28 AM, Andres Freund wrote:
> On 2017-07-26 20:12:56 +1200, Thomas Munro wrote:
>> I'll report on performance separately.
>
> Looking forward to that ;)
Here are some experimental results from a Xeon E5-2695 v3 with a ton
of RAM and spinning disks (ED
else?), but the costing shows the partial row estimate used
for costing purposes.
2. The BufFileSet's temporary directory gets created even if you
don't need it for batches. Duh.
3. I don't have a good query rescan regression query yet. I wish I
could write my own query plans
On Sun, Oct 1, 2017 at 10:03 AM, Thomas Munro
wrote:
>> I tried few more times, and I've got it two times from four attempts on a
>> fresh
>> installation (when all instances were on the same machine). But anyway I'll
>> try
>> to investigate, maybe it
assword-in-script-files stuff is
intended for use on self-destructing isolated build bot images only
and should never be done on a computer you care about.)
Hooray! Now I can go and figure out why my Parallel Hash regression
test is failing with file permissions problems on Windows...
--
Thomas Mun
On Tue, Oct 24, 2017 at 10:10 PM, Thomas Munro
wrote:
> Here is an updated patch set that does that ^.
It's a bit hard to understand what's going on with the v21 patch set I
posted yesterday because EXPLAIN ANALYZE doesn't tell you anything
interesting. Also, if you apply th
On Tue, Sep 19, 2017 at 8:06 AM, Robert Haas wrote:
> On Thu, Sep 14, 2017 at 10:01 AM, Thomas Munro
> wrote:
>> 3. Gather Merge and Parallel Hash Join may have a deadlock problem.
>
> [...]
>
> Thomas and I spent about an hour and a half brainstorming about this
> ju
d out what the cause of this problem was?
I wonder if it might have been the same issue that commit
19de0ab23ccba12567c18640f00b49f01471018d fixed a week or so later.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
end users. Better ideas?
--
Thomas Munro
http://www.enterprisedb.com
0001-Add-a-GUC-to-control-whether-Gather-runs-subplans.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
join reports that we read 30 more blocks
than we wrote (2 per batch after the first, as expected):
Buffers: shared hit=434 read=16234, temp read=5532 written=5502
With the attached patch:
Buffers: shared hit=547 read=16121, temp read=5502 written=5502
--
Thomas Munro
http://www.enterprised
ss of course it shows up in a future
standard), just pointing it out as a curiosity.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sat, Oct 14, 2017 at 11:27 AM, Thomas Munro
wrote:
> On Sat, Oct 14, 2017 at 7:47 AM, legrand legrand
> wrote:
>> Is it stored somewhere to permit to users like me
>> that want to test pg 10 on windows
>> without having to build it ?
Erm, wait, you said pg 10. That&#
gt; that want to test pg 10 on windows
> without having to build it ?
That's the idea. It's quite similar to the build farm, except that it
tests your stuff *before* it gets committed to master and everyone
shouts at you, and can also be used to test strange experiments
ut resulting regression.diffs files and
backtraces from core files (as the Travis CI version accessible from
that page does).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Oct 13, 2017 at 3:59 PM, Peter Eisentraut
wrote:
> On 9/24/17 07:00, Thomas Munro wrote:
>> Fair point. In that case there are a few others we should consider
>> moving down too for consistency, like in the attached.
>
>> Thanks, that is much tidier. Done
On Fri, Oct 13, 2017 at 12:46 PM, Tom Lane wrote:
> Thomas Munro writes:
>> On Fri, Oct 13, 2017 at 10:01 AM, Tom Lane wrote:
>>> The CTE was simply not part of the available namespace for the INSERT's
>>> target, so it found the regular table instead. v10 has
On Fri, Oct 13, 2017 at 10:01 AM, Tom Lane wrote:
> Thomas Munro writes:
>> Before that, CTE used as modify targets produced a different error message:
>
>> postgres=# WITH d AS (SELECT 42) INSERT INTO d VALUES (1);
>> ERROR: relation "d" does not exist
>&
rent compilers, different word size, add valgrind, ...).
I don't know if it would ever make sense to have standardised CI
control files in the tree -- many projects do -- but it's very easy to
carry a commit that adds them in development branches but drop it as
part of the for
On Fri, Oct 13, 2017 at 8:50 AM, Tom Lane wrote:
> Julien Rouhaud writes:
>> On Mon, Oct 9, 2017 at 10:43 PM, Thomas Munro
>> wrote:
>>> I suppose we could consider moving the schemaname check into
>>> getRTEForSpecialRelationType(), since otherwise both caller
he pointer). I
wonder... has anyone here with Microsoft know-how ever tried to
produce an appveyor.yml file that would do a MSVC build and
check-world?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your su
> PFA a simple patch to fix this issue, with updated regression test.
Thanks!
I suppose we could consider moving the schemaname check into
getRTEForSpecialRelationType(), since otherwise both callers need to
do that (and as you discovered, one forgot).
--
Thomas Munro
http://www.e
ble temporary tablespaces, but it's a
terrible API, since you have to promise to use the same stripe number
when opening the same name later... Maybe I should use a hash of the
name for that instead. Thoughts?
--
Thomas Munro
http://www.enterprisedb.com
0006-Remove-BufFile-s-isTemp-flag.
just latches anyway, but it
may be a better abstraction. On the other hand I'm not sure how waits
on a ConditionVariable would be multiplexed with IO (a distinct wait
event, or leaky abstraction where the caller relies on the fact that
it's built on MyProc->latch, something else?).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
buffers could be statically sized
with NAMEDATALEN and MAXCONNINFO.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
umber in log
> segment 00010020, offset 10092544
Hi Dmitry,
Thanks for testing. Yeah, it looks like the patch may be corrupting
the WAL stream in some case that I didn't hit in my own testing
procedure. I will try to reproduce these failures.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
new' or
something, rather than 'init'. 'init' has connotations of being the
second phase in an allocate-and-init pattern for me. Then
bloom_filt_make() would be trivially implemented on top of
bloom_estimate() and bloom_init(), and bloom_init() could
On Tue, Sep 26, 2017 at 10:12 AM, Tom Lane wrote:
> Thomas Munro writes:
>> I think the problem here is that posix_fallocate() doesn't set errno.
>
> Huh. So the fact that it worked for me is likely because glibc's
> emulation *does* allow errno to get set.
>
&g
On Tue, Sep 26, 2017 at 9:57 AM, Thomas Munro
wrote:
>> On Tue, Sep 26, 2017 at 9:13 AM, Tom Lane wrote:
>>> Pushed with that change; we'll soon see what the buildfarm thinks.
>
> Hmm. One failure in the test modules:
>
> https://buildfarm.postgresql.org/cgi-
00.753 PDT [9107:6] LOG: worker process: test_shm_mq
(PID 9362) exited with exit code 1
2017-09-25 13:51:00.753 PDT [9360:7] ERROR: could not resize shared
memory segment "/PostgreSQL.1896677221" to 65824 bytes: Success
hostname = centos7x.joeconway.com
uname -r = 3.10.0-229.11.1.el7.x
f *does*
> list EINTR, so I'm hesitant to muck with that.
Ah, it all makes sense now that I see the fallback strategy section of
the posix_fallocate() man page. I was unaware that there were kernel
releases that had the syscall but lacked support in tmpfs. Thanks for
testing and fixi
t I see now that
ENOTSUPP is possible per-filesystem implementation and tmpfs support
was added some time after the 2.6.32 era:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e2d12e22c59ce714008aa5266d769f8568d74eac
I'm not sure why glibc would provide a fallb
ay
your test case behaves the same as non-parallel mode.
> I will continue my review on the latest patch and share any updates.
Thanks!
--
Thomas Munro
http://www.enterprisedb.com
ssi-parallel-v8.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgs
t; topic is very deliberate and high level, which suggests that ours
> should be, too.
Very interesting and certainly relevant (the parts I've read so far),
though we don't have multiple consumers. Multiplexing one thread so
that it is both a consumer and a producer is an ext
On Thu, Aug 17, 2017 at 11:39 AM, Thomas Munro
wrote:
> On Thu, Jun 29, 2017 at 12:24 PM, Thomas Munro
> wrote:
>> fallocate-v5.patch
>
> Added to commitfest so we don't lose track of this.
Rebased due to collision with recent configure.in adjustments. I also
wro
exercises the
non-NULL code path because slapd rejects TLS by default with a
diagnostic message. I'm not sure if this is worth adding, since it
doesn't actually verify that the code path is reached (though you can
see that it is from the logs).
--
Thomas Munro
http://www.enterprisedb.c
x27;t see its output,
maybe due to -Otarget, before the whole job is nuked by Travis for not
making progress).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ooner. Instead of r2[X=0], the executor sees
r2[X=0,Y=0] (we scanned the whole table, as if we read all objects, in
this case X and Y, even though we only asked to read X). Then the SSI
algorithm is able to detect a "dangerous structure" at w2[Y=10],
instead of later at commit
n of reliable scoped cleanup
waiting to be discovered (as I think Craig was also getting at).
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
to manage
multi-allocation operations if that turned out to be necessary.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
area = dsa_attach(...);
MemoryContextSwitchTo(old_context);
You'll need to #include "utils/memutils.h".
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Sep 18, 2017 at 10:18 PM, Andres Freund wrote:
> On 2017-09-18 21:57:04 +1200, Thomas Munro wrote:
>> WARNING: terminating connection because of crash of another server
>> process
>> DETAIL: The postmaster has commanded this server process to rol
ds/277376953 .
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
own at the bottom of the build log in the regression diffs file you can see:
! ERROR: cache lookup failed for relation 32893
https://travis-ci.org/postgresql-cfbot/postgresql/builds/277165907
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-h
On Fri, Sep 1, 2017 at 5:11 PM, Thomas Munro
wrote:
> On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro
> wrote:
>> [ssi-parallel-v5.patch]
>
> Rebased.
Rebased again.
--
Thomas Munro
http://www.enterprisedb.com
ssi-parallel-v7.patch
Description: Binary data
--
Sent via pgs
ur command.
As far as I know these are misleading, it's really just an immediate
shutdown. There is no core file, so I don't believe anything actually
crashed.
Here's a version that's the same except it doesn't have
--enable-coverage. It passes:
https://travis-
On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro
wrote:
> Here is a patch to fix that.
Here's a better one (same code, corrected commit message).
--
Thomas Munro
http://www.enterprisedb.com
0001-Fix-uninitialized-variable-in-dshash.c.patch
Description: Binary data
--
Sent via pgsql
On Sun, Sep 17, 2017 at 8:49 AM, Thomas Munro
wrote:
> On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro
> wrote:
>> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra
>> wrote:
>>> I've been running some regression tests under valgrind, and it seems
>>&
On Mon, Sep 18, 2017 at 2:39 PM, Andres Freund wrote:
> E.g. very little of the new stuff in
> https://codecov.io/gh/postgresql-cfbot/postgresql/commit/ceaa3dbece3c9b98abcaa28009320fde45a83f88
> is exercised.
Hoist by my own petard.
--
Thomas Munro
http://www.enterprisedb.com
--
LLVM sanitizer stuff, valgrind, Coverity, more compilers, ... but I'm not sure what things really make sense. I may be
placing undue importance on things that I personally screwed up
recently :-D
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-ha
bably be pushed into the index scan.
FWIW I'd vote for 'skip' rather than 'loose' as a term to use in this
family of related features (DISTINCT being the easiest to build). It
seems more descriptive than the MySQL term. (DB2 added this a little
while ago and went with '
On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro
wrote:
> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra
> wrote:
>> I've been running some regression tests under valgrind, and it seems
>> select_parallel triggers some uses of uninitialized values in dshash. If
>> I&#x
log2
> being not being initialized in ensure_valid_bucket_pointers.
Thanks. Will investigate.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ep
getting distracted by other things catching on fire...
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
but I also see no reason to continue
> doing it.)
Done for all lines I touched in the patch.
Thanks for the review!
--
Thomas Munro
http://www.enterprisedb.com
0001-Improve-LDAP-cleanup-code-in-error-paths.patch
Description: Binary data
0002-Log-diagnostic-messages-if-errors-occur-duri
On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund wrote:
> On 2017-09-04 18:14:39 +1200, Thomas Munro wrote:
>> Thanks for the review and commits so far. Here's a rebased, debugged
>> and pgindented version of the remaining patches.
>
> I've pushed this with
still be managed by humans and the new apply and build statuses would
be managed by faithful robot servants.
How exactly that would work, I don't know. One idea is that a future
cfbot, rewritten in better Python and adopted into the pginfra
universe, pokes CF via an HTTPS endpoint s
On Thu, Sep 14, 2017 at 11:57 AM, Thomas Munro
wrote:
> On Thu, Sep 14, 2017 at 12:51 AM, Prabhat Sahu
> wrote:
>> Setting with lower "shared_buffers" and "work_mem" as below, query getting
>> crash but able to see explain plan.
>
> Thanks Prabhat.
skew hash table is present and tries to
probe it after batch 1. I have a fix for that and I will post a new
patch set just as soon as I have a good regression test figured out.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or
On Wed, Sep 6, 2017 at 11:14 PM, Ashutosh Bapat
wrote:
> On Fri, Jul 21, 2017 at 4:10 AM, Thomas Munro
> wrote:
>> That just leaves the question of whether we should try to handle the
>> empty RHS and single-value RHS cases using statistics. My intuition
>> is that w
-s0" to try your new
column-aware pager from https://github.com/okbob/pspg for my regular
work. Wow! It could use some warning clean-up but it's a clever idea
and so far it works really well. Thanks for making this.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent v
On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro
wrote:
> On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma
> wrote:
>> I am getting the following error message when trying to build latest
>> PG source on Windows,
>>
>> Error 1 error C2065: 'LDAP_NO_ATTRS'
rg/html/rfc4511
3. A list containing only the OID "1.1" indicates that no
attributes are to be returned. If "1.1" is provided with other
attributeSelector values, the "1.1" attributeSelector is
ignored. This OID was chosen because it does not (and c
_WAL but hasn't removed that reference to it.
I'm not sure what happened. Is it possible that your patch was not
created by diffing against master?
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
g it visible that the message comes from LDAP (rather than
>>> Postgres or anything else) is valuable. How about this?
>>>
>>> LOG: could not start LDAP TLS session: Protocol error
>>> DETAIL: LDAP diagnostics: unsupported extended operation.
>>>
oundtrips.
Hi Elvis,
FYI the recovery test 001_stream_rep.pl fails with this patch applied.
You can see that if you configure with --enable-tap-tests, build and
then cd into src/test/recovery and "make check".
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers ma
On Wed, Sep 13, 2017 at 1:55 AM, Peter Eisentraut
wrote:
> On 9/11/17 23:58, Thomas Munro wrote:
>> Sounds good. Here it is with $username. It's nice not to have to
>> escape any characters in URLs. I suppose more keywords could be added
>> in follow-up patches if so
ake a while because it rotates through the
submissions at a rate of one submission every 5 minutes after a new
commit to master is detected, since I don't want to get in trouble for
generating excessive load against the Commitfest, Github or (mainly)
Travis CI. That's probably too cautiou
e this line:
! return exec_simple_check_node((Node *) ((ArrayCoerceExpr
*) node)->arg);
But you removed exec_simple_check_node in
00418c61244138bd8ac2de58076a1d0dd4f539f3, so this 02 patch needs to be
rebased.
> Also, at this point this should surely be just an experiment.
+1
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Eventually I'll
also teach it how to dump a backtrace out of gdb the tests leave a
smouldering core.
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
patch
that's cfbot's fault, but if we were to nail down the acceptable
formats then it'd become your fault if it didn't understand your patch
:-D
--
Thomas Munro
http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
1 - 100 of 896 matches
Mail list logo
