[HACKERS] commit fest manager for CF 2016-11?

2016-10-30 Thread Peter Eisentraut
Commit fest CF 2016-11 is supposed to start in about a day. I don't think a commit fest manager was chosen yet. Volunteers? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hacker

Re: [HACKERS] sequences and pg_upgrade

2016-10-31 Thread Peter Eisentraut
ing whether this option is exposed or not. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From d2b98ba5df815018dac1650134398c1bac7164a4 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 23 Aug 201

Re: [HACKERS] pg_sequence catalog

2016-10-31 Thread Peter Eisentraut
On 9/10/16 7:17 AM, Peter Eisentraut wrote: > Let's start with that. Here is a patch that adds a pg_sequences view in > the style of pg_tables, pg_indexes, etc. This seems useful independent > of anything else, but would give us more freedom to change things around > behind th

Re: [HACKERS] Unsafe use of relation->rd_options without checking its type

2016-10-31 Thread Peter Geoghegan
ght kind of reloptions. It seems worth adding an assertion, at least. I wonder what running the regression tests with a bunch of similar assertions shows up... -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: htt

Re: [HACKERS] commit fest manager for CF 2016-11?

2016-10-31 Thread Peter Eisentraut
time. https://en.wikipedia.org/wiki/Anywhere_on_Earth -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your su

[HACKERS] background sessions

2016-10-31 Thread Peter Eisentraut
e all done yet, but I think it contains a lot of useful pieces that we could make into something nice. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services From 661c7fe769982e3f0c71f4ad57a768d7eb55f6e2 Mon Sep 17

Re: [HACKERS] identity columns

2016-10-31 Thread Peter Eisentraut
? fixed > 14. It would be fine if psql has support of new clauses. done > 15. Initializing attidentity in most places is ' ' but makefuncs.c has > "n->identity = 0;". Is it correct? fixed > 16. I think it is a good idea to not raise exceptions for "

[HACKERS] DROP FUNCTION of multiple functions

2016-10-31 Thread Peter Eisentraut
;business logic" functions with 10+ arguments. The details of that are to be worked out, but with the help of the present changes, this would be a quite localized change, because the grammar representation is well encapsulated. -- Peter Eisentraut http://www.2ndQuadrant.com/ Po

Re: [HACKERS] save redundant code for pseudotype I/O functions

2016-11-01 Thread Peter Eisentraut
ackend/tsearch/wparser_def.c src/backend/utils/adt/tsvector_op.c Do people prefer the macros over this? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] pageinspect: Hash index support

2016-11-01 Thread Peter Eisentraut
On 10/3/16 8:52 AM, Jesper Pedersen wrote: > On 09/29/2016 04:02 PM, Peter Eisentraut wrote: >> On 9/29/16 4:00 PM, Peter Eisentraut wrote: >>> Since the commit fest is drawing to a close, I'll set this patch as >>> returned with feedback. >> >> Actual

Re: [HACKERS] WAL consistency check facility

2016-11-01 Thread Peter Geoghegan
> yourself said, this facility generates a ton of WAL. If you're > focusing on one AM, why would you want to be forced to incur the > overhead for every other AM? A good deal has been written about this > upthread already, and just saying "I don't see the point&qu

Re: [HACKERS] make coverage-html on OS X

2016-11-02 Thread Peter Eisentraut
; a lot, even with just 2 cores. I was not able to reproduce this. The make rules look reasonable to me for parallelism. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing li

Re: [HACKERS] Logical Replication WIP

2016-11-02 Thread Peter Eisentraut
onfusing code that needs to know this difference. I think we need to use some different verbs for different purposes here. Acquire and release should keep their meaning of "I'm using this", and the calls in proc.c and postgres.c should be something like ReplicationSlotCleanup(). --

Re: [HACKERS] pageinspect: Hash index support

2016-11-02 Thread Peter Eisentraut
On 11/1/16 3:28 PM, Peter Eisentraut wrote: > I have also committed the tests > that I proposed and will work through the failures. So, we're down to crashes in gin_metapage_info() on ia64 and sparc64. My guess is that the raw page data that is passed into the function needs to be 8-b

[HACKERS] Re: [COMMITTERS] pgsql: Add make rules to download raw Unicode mapping files

2016-11-03 Thread Peter Eisentraut
On 11/2/16 3:33 AM, Michael Paquier wrote: > On Wed, Nov 2, 2016 at 12:58 AM, Peter Eisentraut wrote: >> Add make rules to download raw Unicode mapping files >> >> This serves as implicit documentation and is handy if someone wants to >> tweak things. The rules are

Re: [HACKERS] pageinspect: Hash index support

2016-11-03 Thread Peter Eisentraut
On 11/2/16 1:54 PM, Tom Lane wrote: > I think the right thing is likely to be to copy the presented bytea > into a palloc'd (and therefore properly aligned) buffer. And not > just in this one function. Does the attached look reasonable? -- Peter Eisentraut

Re: [HACKERS] add more NLS to bin

2016-11-03 Thread Peter Eisentraut
/report_status/ ok > In info.c, missing some entries in report_unmatched_relation() when > reporting unmatching relations? Yeah, that will need a bit of a rewrite, so FIXME later? > In util.c, doesn't pg_log_v() need to handle strings used in fprintf? Which specific lines do you h

Re: [HACKERS] split up psql \d Modifiers column

2016-11-03 Thread Peter Eisentraut
On 11/2/16 12:24 PM, Kuntal Ghosh wrote: > On Fri, Oct 28, 2016 at 9:00 AM, Peter Eisentraut > wrote: >> I propose to change the psql \d output a bit, best shown with an example: >> >> \d persons3 >> - Table "public.persons3&qu

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-11-03 Thread Peter Eisentraut
On 6/7/16 2:43 PM, Peter Eisentraut wrote: > On 6/7/16 1:19 AM, Haribabu Kommi wrote: >> How about the following case, Do we treat them as same or different? >> >> select 'fe80::%eth1'::inet = 'fe80::%ETH1'::inet; >> >> fe80::%2/64 is only trea

Re: [HACKERS] Logical Replication WIP

2016-11-03 Thread Peter Eisentraut
ated than what the patch does with little gain. > > What about just releasing the ephemeral slot if the different one is > being acquired instead of the current error? Maybe that would help reducing some of the mystery about when you have to call Release and when ReleasePersistent (be

Re: [HACKERS] Logical Replication WIP

2016-11-03 Thread Peter Eisentraut
ppears to address the previous discussions. I wouldn't change walrcv_xxx to walrcvconn_xxx. If we're going to have macros to hide the internals, we might as well keep the names the same. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Password identifiers, protocol aging and SCRAM protocol

2016-11-04 Thread Peter Eisentraut
lements SASL and SCRAM and SHA256. We need to be clear about which term we advertise to users. An explanation in the missing documentation would probably be a good start. I would also like to see a test suite that covers the authentication specifically. -- Peter Eisentraut http://ww

Re: [HACKERS] add more NLS to bin

2016-11-04 Thread Peter Eisentraut
n pg_rewind for example those logs are > getting translated via the pg_log() calls used with PG_DEBUG. Yeah that was wrong anyway. The previously existing translation markers were wrong. We want to translate the fmt, not the formatted message. New patch attached. -- Peter Eisentraut

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-04 Thread Peter Eisentraut
hat cause breakage? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.

2016-11-06 Thread Peter Geoghegan
this, we should make the internal pages represent the key space in the least restrictive way possible, by applying suffix truncation so that it's much more likely that things will *stay* balanced as churn occurs. This is probably a really bad problem with things like composite indexes ove

Re: [HACKERS] add more NLS to bin

2016-11-07 Thread Peter Eisentraut
fmt to gettext(), then it will look up the string that you see in the code. If you pass the formatted message to gettext(), then it will look up something like "fetched file \"foo\", length 12\n" which it will not find, unless you provide translations for all combinati

Re: [HACKERS] [COMMITTERS] pgsql: pg_xlogdump: Add NLS

2016-11-07 Thread Peter Eisentraut
On 11/5/16 9:19 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> pg_xlogdump [etc]: Add NLS > > So how large are the new .po files? pg_archivecleanup/po/pg_archivecleanup.pot: 0 translated messages, 25 untranslated messages. pg_test_fsync/po/pg_test_fsync.pot: 0 translat

Re: [HACKERS] add more NLS to bin

2016-11-07 Thread Peter Eisentraut
On 11/5/16 8:03 AM, Michael Paquier wrote: > On Sat, Nov 5, 2016 at 9:17 AM, Peter Eisentraut > wrote: >> > On 11/3/16 7:17 PM, Michael Paquier wrote: >>> >> This patch not being complicated, so I would vote for those being >>> >> addressed now so

Re: [HACKERS] Detect supported SET parameters when pg_restore is run

2016-11-07 Thread Peter Eisentraut
tVersion, default that to remoteVersion in plain text format, and set it to the actual remote version when restoring directly to a database. It will need a bit of work to tie it all together, but it shouldn't be too difficult. -- Peter Eisentraut http://www.2ndQuadrant.com/ Postgre

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2016-11-07 Thread Peter Geoghegan
On Mon, Oct 24, 2016 at 6:17 PM, Peter Geoghegan wrote: >> * Cost model. Should probably attempt to guess final index size, and >> derive calculation of number of workers from that. Also, I'm concerned >> that I haven't given enough thought to the low end, where w

Re: [HACKERS] Radix tree for character conversion

2016-11-08 Thread Peter Eisentraut
ched patches are against the 0001-0006 patches from Heikki and you in > this series of emails, the separation is intended to make them easier to read. Cool. See also here: https://www.postgresql.org/message-id/55E52225.4040305%40gmx.net -- Peter Eisentraut http://www.2ndQuadra

Re: [HACKERS] Logical Replication WIP

2016-11-08 Thread Peter Eisentraut
gt;pubinsert |= pubform->pubinsert; etc. should be ||= RelationData.rd_pubactions could be a bitmap, simplifying some memcpy and context management. But RelationData appears to favor rich data structures, so maybe that is fine. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Logical Replication WIP

2016-11-08 Thread Peter Eisentraut
s to check the pubactions against the specific command. > +} FormData_pg_publication; > > Shouldn't this have an owner? Yes, see above. > I also wonder if we want an easier to > extend form of pubinsert/update/delete (say to add pubddl, pubtruncate, > pub ... without chan

Re: [HACKERS] WIP: About CMake v2

2016-11-08 Thread Peter Eisentraut
arate preliminary patches if you need to do some refactoring. Ultimately, I would expect this patch not to require C code changes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing li

Re: [HACKERS] SERIALIZABLE with parallel query

2016-11-08 Thread Peter Geoghegan
ture to not care. I think that this works fine, given the limited scope of the problem, but it would be nice to have that confirmed. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-11-09 Thread Peter Eisentraut
hing that might be useful and not questionable is a function that takes text input and produces a zone-free address and a the zone ID as separate return values. (Or perhaps two functions, one for each component.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 2

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2016-11-09 Thread Peter Geoghegan
al number of tuples. The much > faster run time to produce the whole data set is a small price to pay > for possibly needing to wait a little longer for the first tuple. Cool. > So, I'm now feeling pretty bullish about this patch, except for one > thing, which is that I think th

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2016-11-09 Thread Peter Geoghegan
On Wed, Nov 9, 2016 at 4:54 PM, Peter Geoghegan wrote: > It's more complicated than that. As I said, I think that Knuth > basically had it right with his sweet spot of 7. I think that commit > df700e6b40195d28dc764e0c694ac8cef90d4638 was effective in large part > because a one-p

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

2016-11-09 Thread Peter Geoghegan
in too far or we'll create slow polyphase > merges in case that are reasonably likely to occur in real life. I completely agree with your analysis. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_sequence catalog

2016-11-09 Thread Peter Eisentraut
tval1() function. fixed > - The documentation does not mention the last_value column. fixed > - The extra empty line after "" does not fit with the formatting > of the rest of the SGML file. fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Develop

[HACKERS] switching documentation build to XSLT

2016-11-10 Thread Peter Eisentraut
here are more steps to be done after this, to move over the other output formats (PDF), adjust the configure script, the documentation, work out any remaining formatting problems, etc., so now is a good time to get this rolling so that we have a good chance of reaching a steady state before

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-11 Thread Peter Eisentraut
t to any of > the host server (both master(primary) and slave(standby)). If the value > is "master" then we try to connect to master(primary) only. We tend to use the term "primary" instead of "master". Will this work with logical replication? -- Peter Eisen

Re: [HACKERS] pg_dump, pg_dumpall and data durability

2016-11-12 Thread Peter Eisentraut
...@2ndquadrant.com At the time, there were no other comments, so we went ahead with it, which presumably gave encouragement to pursue the current patch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sen

Re: [HACKERS] WAL consistency check facility

2016-11-12 Thread Peter Eisentraut
ge to check > whether > +both are consistent. > + Could we name this something like wal_consistency_checking? Otherwise it sounds like you use this to select the amount of consistency in the WAL (similar to, say, wal_level). -- Peter Eisentraut http://www.2n

Re: [HACKERS] Do we need use more meaningful variables to replace 0 in catalog head files?

2016-11-12 Thread Peter Eisentraut
On 11/11/16 11:10 AM, Tom Lane wrote: > boolin: OID=1242 proname=boolin proargtypes="cstring" prorettype=bool > boolin: prosrc=boolin provolatile=i proparallel=s Then we're not very far away from just using CREATE FUNCTION SQL commands. -- Peter Eisentraut

Re: [HACKERS] Logical Replication WIP

2016-11-12 Thread Peter Eisentraut
x27;m not sure why that would be better. Adding catalog columns in future versions is not a problem. We're not planning on adding hundreds of publication attributes. Denormalizing catalog columns creates all kinds of inconveniences, in the backend code, in frontend code, for users. -- Peter Eisen

Re: [HACKERS] sequences and pg_upgrade

2016-11-13 Thread Peter Eisentraut
in the patch, aka no options of pg_dump > exposed to user, still keep the option tracking as a separate value. Committed, thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers

Re: [HACKERS] [PATCH] Allow TAP tests to be run individually

2016-11-14 Thread Peter Eisentraut
we'd prefer that for consistency, but I see no > reason to not keep your patch as well. I am marking that as ready for > committer. ($or ...) is a newer feature of GNU make, so we have avoided that so far. I have committed your v2 with $(if ...). -- Peter Eisentraut http://

Re: [HACKERS] Pinning a buffer in TupleTableSlot is unnecessary

2016-11-14 Thread Peter Geoghegan
On Mon, Nov 14, 2016 at 9:22 AM, Heikki Linnakangas wrote: > I think that difference in the API is exactly what caught Peter by surprise > and led to bug #14344. And I didn't see it either, until you two debugged > it. That is accurate, of course. -- Peter Geoghegan --

Re: [HACKERS] Pinning a buffer in TupleTableSlot is unnecessary

2016-11-14 Thread Peter Geoghegan
On Mon, Nov 14, 2016 at 10:17 AM, Andres Freund wrote: > I think so, yes. IIRC I discussed it with Noah and Peter G. at a > conference recently. We'd basically mark the content of shared buffers > inaccessible at backend startup, and mark it accessible whenever a > PinBuffer()

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
1. The old output has this: This has always been the case, AFAICT. Btw., shouldn't the output web site pages have encoding declarations? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pg

Re: [HACKERS] switching documentation build to XSLT

2016-11-16 Thread Peter Eisentraut
On 11/10/16 5:49 AM, Peter Eisentraut wrote: > We are now proposing that we change the way the HTML documentation is > built from jade/openjade+docbook-dsssl to xsltproc+docbook-xsl. > The actual patch to make this change is attached. For the build > process, nothing changes, e.g

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:29 AM, Erik Rijkers wrote: > On 2016-11-16 08:06, Peter Eisentraut wrote: >> Build HTML documentation using XSLT stylesheets by default >> >> The old DSSSL build is still available for a while using the make >> target >> "oldhtml". >

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:09 AM, Magnus Hagander wrote: > Btw., shouldn't the output web site pages have encoding declarations? > > That gets sent in the http header, doesn't it? That's probably alright, but it would be nicer if the documents were self-contained. -- Peter Eise

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 12:38 PM, Alvaro Herrera wrote: > "make check" still uses DSSSL though. Is that intentional? Is it going > to be changed? It doesn't use DSSSL. Is uses nsgmls to parse the SGML, which is a different thing that will be addressed in a separate step. So, yes,

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
On 11/16/16 6:46 AM, Tom Lane wrote: > What was the improvement we were hoping for, again? Get off an ancient and unmaintained tool chain. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent vi

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
in particular no doctype declaration and > incomplete closing tags. Yes, that is one of the upcoming steps. But we need to do the current thing first. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --

Re: [HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-11-16 Thread Peter Eisentraut
pg.version '10devel' stylesheet.xsl postgres.xml to make sure it's not downloading something from the network. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing l

[HACKERS] partial documentation builds

2016-11-16 Thread Peter Eisentraut
mat "make html XSLTPROCFLAGS='--stringparam rootid %s'" id) (defun browse-html-of-this () (interactive) (let ((id (top-level-id))) (when id (browse-url-of-file (concat (file-name-directory buffer-file-name) "html/" id ".html") -- P

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-17 Thread Peter Geoghegan
htmost child". This is covered in the nbtree README: """ To preserve consistency on the parent level, we cannot merge the key space of a page into its right sibling unless the right sibling is a child of the same parent --- otherwise, the parent's key space assignment changes too, meaning we'd have to make bounding-key updates in its parent, and perhaps all the way up the tree. Since we can't possibly do that atomically, we forbid this case. That means that the rightmost child of a parent node can't be deleted unless it's the only remaining child, in which case we will delete the parent too (see below). ''"" > I like this. Some of the more complex pieces towards the end of the > field need some attention, there's a fair amount of word-smithing > needed, and I do think we want to make the structural changes outlined > above, but besides these, imo fairly simple adaptions, I do think this > is useful and not that far from being committable. Cool. I'll try to get a revision out soon. I'm happy to do that much. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-17 Thread Peter Geoghegan
index scan for 'b' (relevant to T2). I would actually like to change things to make the invariant the classic L&Y "Ki < v <= Ki+1", to avoid bloat in the internal pages and to make suffix truncation in internal pages work. So, we don't have the cousin problem, but si

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-18 Thread Peter Eisentraut
sses don't distinguish between a SIGQUIT coming from a user-initiated immediate shutdown request and a crash-induced kill-everyone directive. So there might not be a non-ugly way to address that. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Supp

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-18 Thread Peter Eisentraut
we should adjust the naming and the comments so that we don't have two similar-sounding functions with confusing comments. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing li

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-18 Thread Peter Eisentraut
On 11/18/16 12:00 PM, Tom Lane wrote: > My feeling is that 82233ce7e has obsoleted all of the proposals made so > far in this thread, and that we should reject them all. Yes, it seems that very similar concerns were already addressed there. -- Peter Eisentraut http

Re: [HACKERS] pg_sequence catalog

2016-11-18 Thread Peter Eisentraut
On 11/11/16 12:53 PM, Andreas Karlsson wrote: > Other than my comment above about is_called and last_value I think the > patch looks great. I have made that change and committed the patch. Thanks. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Remove the comment on the countereffectiveness of large shared_buffers on Windows

2016-11-18 Thread Peter Eisentraut
m inclined to commit the original patch if there are no objections. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make change

Re: [HACKERS] WIP: Covering + unique indexes.

2016-11-18 Thread Peter Eisentraut
atest patch doesn't apply. See also review by Brad DeJong. I'm setting it back to Waiting. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-18 Thread Peter Geoghegan
On Thu, Nov 17, 2016 at 12:04 PM, Peter Geoghegan wrote: >> Hm, if we want that - and it doesn't seem like a bad idea - I think we >> should be make it available without recompiling. > > I suppose, provided it doesn't let CORRUPTION elevel be < ERROR. That >

Re: [HACKERS] [WIP] [B-Tree] Keep indexes sorted by heap physical location

2016-11-18 Thread Peter Geoghegan
On Thu, Aug 18, 2016 at 2:15 PM, Peter Geoghegan wrote: > I think that this is a bad idea. We need to implement suffix > truncation of internal page index tuples at some point, to make them > contain less information from the original leaf page index tuple. > That's an impor

Re: [HACKERS] [WIP] [B-Tree] Keep indexes sorted by heap physical location

2016-11-18 Thread Peter Geoghegan
bits can be unset. We might balance the avoidance of I/O during the scan against how much we might expect to save in a subsequent bitmap heap scan, and so on. This might be based on a selectivity estimate. That's all fairly hand-wavy, certainly, but I see significant potential along th

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-19 Thread Peter Geoghegan
is != ERROR (the thing I mention about elevel < ERROR is already documented in code comments). If that breaks, they get to keep both halves. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [WIP] [B-Tree] Keep indexes sorted by heap physical location

2016-11-21 Thread Peter Geoghegan
r TID in all cases, since the current assumption is that a high key's TID is just filler -- maybe we can lose that at some point. You should use amcheck to specifically verify that that happens reliably in all cases. Presumably, its use of an insertion scankey would automatically see the use of TID as a tie-breaker with patched Postgres amcheck verification, and so amcheck will work for this purpose unmodified. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partitioning vs ON CONFLICT

2017-02-16 Thread Peter Geoghegan
ON CONFLICT DO NOTHING permits, then it should be possible for it to just work today -- infer_arbiter_indexes() will return immediately. This should be just like the old approach involving inheritance, in that that should be possible. No? -- Peter Geoghegan -- Sent via pgsql-hackers mailing l

Re: [HACKERS] Partitioning vs ON CONFLICT

2017-02-16 Thread Peter Geoghegan
cing this directly. IIRC, that's what happens with inheritance-based partitioning. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SUBSCRIPTIONS and pg_upgrade

2017-02-17 Thread Peter Eisentraut
r. Also, restoring a subscription will immediately attempt to start replication, which might be kind of surprising. We had pondered this issue extensively during early review. I don't think we're all happy with the current behavior, but it's probably the safest and easiest one for now.

Re: [HACKERS] CREATE SUBSCRIPTION uninterruptable

2017-02-17 Thread Peter Eisentraut
27;t we have an interrupt for this? I think this is addressed by these patches: https://commitfest.postgresql.org/13/991/ Please give them a try. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

2017-02-17 Thread Peter Eisentraut
that before on system catalogs. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postg

Re: [HACKERS] Logical Replication and Character encoding

2017-02-17 Thread Peter Eisentraut
a proper libpq server should do encoding conversion accordingly. If we just play along with this, it all works correctly. Other output plugins are free to ignore the encoding settings (just like libpq can send binary data in some cases). The attached patch puts it all together. -- Peter Eis

Re: [HACKERS] Index corruption with CREATE INDEX CONCURRENTLY

2017-02-17 Thread Peter Geoghegan
would need to visit the heap, which tends to be much larger than any one index, or even all indexes. That would probably need to be random I/O, too. It might be possible to mostly not visit the heap, though -- I'm not sure offhand. I'd have to study the problem in detail, which I have no t

Re: [HACKERS] Index corruption with CREATE INDEX CONCURRENTLY

2017-02-17 Thread Peter Geoghegan
s that it will have checks for a large variety of invariants that involve the heap, and related SLRU structures such as MultiXacts. Though, that would probably necessitate code written by other people that are subject matter experts in areas that I am not. -- Peter Geoghegan -- Sent via pgsql-h

Re: [HACKERS] SUBSCRIPTIONS and pg_upgrade

2017-02-17 Thread Peter Eisentraut
abase superuser can actually read everything. There are some concurrent discussions about getting a list of subscriptions without having superuser. Once that is resolved, we'll likely have more options here, such as dumping only subscriptions you are owner of or something like that. -- Pe

[HACKERS] logical replication access control patches

2017-02-17 Thread Peter Eisentraut
f for logical replication. Use the normal database entries instead. Relates to https://www.postgresql.org/message-id/flat/CAB7nPqRf8eOv15SPQJbC1npJoDWTNPMTNp6AvMN-XWwB53h2Cg%40mail.gmail.com -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

2017-02-17 Thread Peter Eisentraut
On 2/17/17 16:13, Mark Dilger wrote: > + PGAC_PROG_CC_CFLAGS_OPT([-Wc++-compat]) If your compiler isn't warning about anything with that, then there is something wrong with it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Re

Re: [HACKERS] 2 doc typos

2017-02-17 Thread Peter Eisentraut
On 2/16/17 09:38, Thom Brown wrote: > Please find attached a patch to fix 2 typos. > > 1) s/mypubclication/mypublication/ > > 2) Removed trailing comma from last column definition in example. committed, thanks -- Peter Eisentraut http://www.2ndQuadrant.com/ Postgre

Re: [HACKERS] pg_basebackup -R

2017-02-17 Thread Peter Eisentraut
good can come of using them. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-02-17 Thread Peter Eisentraut
ymbol undefined errors at link time. Now > we stop and identify the infringing line as soon as we encounter it, > which greatly speeds up the debugging process. I think this would be useful. I haven't reviewed the code, but the general idea looks reasonable. -- Peter Eisentra

Re: [HACKERS] patch: optimize information_schema.constraint_column_usage

2017-02-17 Thread Peter Eisentraut
optimize it. committed, thanks -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.or

Re: [HACKERS] Official adoption of PGXN

2017-02-17 Thread Peter Eisentraut
coming from a Python or Ruby ecosystem, say. ;-) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-02-20 Thread Peter Moser
tuples with the same group have equal ranges) and the non-overlapping parts. For instance, the NORMALIZE between r1, s1, s2, and s3 in your example above would give the following: r1[1, 1] r1[2, 2] r1[3, 3] r1[4, 4] r1[5, 6] > > The rest of the syntax seems to deal with selecting subsets of range records > based upon attribute data. Yes, exactly! Best regards, Anton, Johann, Michael, Peter -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-02-20 Thread Peter Geoghegan
entGlobalXmin respected by VACUUM, that prevents this sort of recycling. I suspect that the restrictions on page deletion as opposed to page recycling is vastly more likely to cause pain to users, and that's not made any worse by this. -- Peter Geoghegan -- Sent via pgsql-hackers maili

Re: [HACKERS] ICU integration

2017-02-20 Thread Peter Geoghegan
problem, and users will never learn to deal with issues like this well when it is by definition something that should never happen. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ICU integration

2017-02-20 Thread Peter Geoghegan
xists. [1] http://site.icu-project.org/#TOC-Who-Uses-ICU- -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ICU integration

2017-02-20 Thread Peter Geoghegan
versions many different things, in fact. Importantly, it explicitly decouples behavioral issues (user visible sort order -- UCA version) from technical issues (collator implementation details). So, my original point is that that could change, and if that happens we ought to have a plan. But, it won'

Re: [HACKERS] drop support for Python 2.3

2017-02-21 Thread Peter Eisentraut
On 2/19/17 23:33, Devrim Gündüz wrote: > Thanks! Looks like buildfarm is green again. Thank. I have committed the patch to drop Python 2.3 support. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- S

Re: [HACKERS] safer node casting

2017-02-21 Thread Peter Eisentraut
On 1/26/17 16:15, Andres Freund wrote: > On 2017-01-25 19:21:40 -0500, Tom Lane wrote: >> Andres Freund writes: >>> On 2016-12-31 12:08:22 -0500, Peter Eisentraut wrote: >>>> RestrictInfo *rinfo = castNode(RestrictInfo, lfirst(lc)); >> >>> Are you plan

Re: [HACKERS] drop support for Python 2.3

2017-02-21 Thread Peter Eisentraut
on configuration directory] stanza. Unless there was some specific > reason for not wanting it to happen in python.m4? It's fine to move it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent

Re: [HACKERS] "may be unused" warnings for gcc

2017-02-21 Thread Peter Eisentraut
-O3 doesn't get any performance improvement, so I haven't bothered lately. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] mat views stats

2017-02-21 Thread Peter Eisentraut
ingful for materialized views. It might be easier to include materialized views into pg_stat_*_tables. I think these should be two separate patches. We might want to backpatch the first one. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Re

Re: [HACKERS] Change in "policy" on dump ordering?

2017-02-21 Thread Peter Eisentraut
bjectTypePriority). Is there any specific assignment that you have concerns about? > Is this change a good or bad idea? Should there be an official guide for > where new things go? The comment above dbObjectTypePriority explains it, doesn't it? -- Peter Eisentraut

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-02-21 Thread Peter Eisentraut
want to prewarm a standby from the info from the primary (or another standby)? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

<    3   4   5   6   7   8   9   10   11   12   >