Re: [HACKERS] list of credits for release notes

that, but if I were him, I would feel > uncomfortable. If the list explicitly stats that we do not guarantee > that the order of the last names and the first names are correct, then > that kind of misunderstanding could be avoided. Yeah, your concern might be right, but I prefer Fujii Masao, i.e.,

Re: [HACKERS] subscription worker doesn't start immediately on eabled

On Thu, Apr 27, 2017 at 6:32 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Thu, 27 Apr 2017 00:51:03 +0900, Fujii Masao <masao.fu...@gmail.com> wrote > in

Re: [HACKERS] some review comments on logical rep code

On Thu, Apr 27, 2017 at 5:37 PM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 26/04/17 18:36, Fujii Masao wrote: >> On Thu, Apr 27, 2017 at 1:28 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI >&g

Re: [HACKERS] some review comments on logical rep code

On Thu, Apr 27, 2017 at 1:28 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Apr 26, 2017 at 3:47 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> At Wed, 26 Apr 2017 14:31:12 +0900, Masahiko Sawada <sawada.m...@gmail.com> >> wrote

Re: [HACKERS] some review comments on logical rep code

d, Apr 26, 2017 at 12:35 PM, Petr Jelinek >> <petr.jeli...@2ndquadrant.com> wrote: >> > On 26/04/17 01:01, Fujii Masao wrote: >> >>>> However this is overkill for small gain and false wakeup of the >> >>>> launcher is not so harmful (prob

Re: [HACKERS] subscription worker doesn't start immediately on eabled

patch makes me think that CREATE SUBSCRIPTION should also wake up the launcher only when ENABLE is specified. Patch attached. Thought? Regards, -- Fujii Masao wakeup_launcher_when_enabled.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Fix a typo in subscriptioncmd.c

On Wed, Apr 26, 2017 at 3:07 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Hi, > > Attached patch for $subject. > > s/accomodate/accommodate/ Pushed. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] some review comments on logical rep code

er is not so harmful (probably we can live with that), so >> we do nothing here for this issue. > > I agree this as a whole. But I think that the main issue here is > not false wakeups, but 'possible delay of launching new workers > by 3 minutes at most' (this is centainly a

Re: [HACKERS] Quorum commit for multiple synchronous replication.

he priorities of sync standbys >> > to 1 in quorum-based syncrep case. Attached patch does this change. >> > Barrying any objection, I will commit this. >> >> +1 > > Ok, +1 from me. Pushed. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Separation walsender & normal backends

e. OTOH, I believe that logical replication is still useful even without initial table sync feature. So reverting the table sync patch seems possible idea. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Remove dead interfaces added by mistake in 7c4f52409

ath (commit 7c4f52409). > > Attached patch gets rid of them. Pushed. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Quorum commit for multiple synchronous replication.

ted number of synchronous standbys is smaller than the number of potential synchronous standbys running". > While quorum-based >> replication master waits only for a specified number of fastest >> standbys, priority-based replicatoin master must wait for >> standbys at the top of the

Re: [HACKERS] Quorum commit for multiple synchronous replication.

> wrote: >> > > On Wed, Apr 19, 2017 at 01:52:53PM +0900, Masahiko Sawada wrote: >> > >> On Wed, Apr 19, 2017 at 12:34 PM, Noah Misch <n...@leadboat.com> wrote: >> > >> > On Sun, Apr 16, 2017 at 07:25:28PM +0900, Fujii Masao wrote: >> >

Re: [HACKERS] some review comments on logical rep code

On Fri, Apr 21, 2017 at 4:02 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Apr 21, 2017 at 1:19 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>>

Re: [HACKERS] some review comments on logical rep code

On Thu, Apr 20, 2017 at 12:05 PM, Noah Misch <n...@leadboat.com> wrote: > On Sun, Apr 16, 2017 at 06:14:49AM +, Noah Misch wrote: >> On Fri, Apr 14, 2017 at 04:47:12AM +0900, Fujii Masao wrote: >> > Though I've read only a part of the logical rep code yet, I'd

Re: [HACKERS] some review comments on logical rep code

On Tue, Apr 18, 2017 at 5:16 PM, Masahiko Sawada wrote: > On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI > wrote: >> Hi, >> >> Thank you for the revised version. >> >> At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada

Re: [HACKERS] Quorum commit for multiple synchronous replication.

; wrote in <cad21aobqsjugx0lcdrjedlb-yx2evglmdt8nz4zr_xpxrbm...@mail.gmail.com> >>> On Tue, Apr 18, 2017 at 3:04 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> > On Wed, Apr 12, 2017 at 2:36 AM, Masahiko Sawada <sawada.m...@gmail.com> >>> &g

Re: [HACKERS] some review comments on logical rep code

some merge > conflict being solved wrongly. Maybe your patch could fix that too? > >>>>> >>>>>>> 10. >>>>>>>> >>>>>>>> SpinLockAcquire(>relmutex); >>>>>>>> MyLogicalRepWorker-

Re: [HACKERS] Quorum commit for multiple synchronous replication.

On Wed, Apr 12, 2017 at 2:36 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Apr 6, 2017 at 4:17 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: >> On Thu, Apr 6, 2017 at 10:51 AM, Noah Misch <n...@leadboat.com> wrote: >>> On Thu, Apr 06, 2017 at

Re: [HACKERS] Quorum commit for multiple synchronous replication.

On Sun, Apr 16, 2017 at 1:19 PM, Noah Misch <n...@leadboat.com> wrote: > On Fri, Apr 14, 2017 at 11:58:23PM -0400, Noah Misch wrote: >> On Wed, Apr 05, 2017 at 09:51:02PM -0400, Noah Misch wrote: >> > On Thu, Apr 06, 2017 at 12:48:56AM +0900, Fujii Masao wrote: >>

Re: [HACKERS] logical replication and PANIC during shutdown checkpoint in publisher

On Fri, Apr 14, 2017 at 10:33 PM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 12/04/17 15:55, Fujii Masao wrote: >> Hi, >> >> When I shut down the publisher while I repeated creating and dropping >> the subscription in the subscriber, the publisher emi

[HACKERS] some review comments on logical rep code

gt;relid, >relstate_lsn, false); SpinLockRelease(>relmutex); Non-"short-term" function like GetSubscriptionRelState() should not be called while spinlock is being held. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] logical replication and PANIC during shutdown checkpoint in publisher

On Thu, Apr 13, 2017 at 12:36 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Apr 13, 2017 at 12:28 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Thu, Apr 13, 2017 at 5:25 AM, Peter Eisentraut >> <peter.eisentr...@2ndquadrant.com> wrote:

Re: [HACKERS] Quorum commit for multiple synchronous replication.

On Thu, Apr 13, 2017 at 9:23 PM, Masahiko Sawada wrote: > On Thu, Apr 13, 2017 at 5:17 PM, Kyotaro HORIGUCHI > wrote: >> Hello, >> >> At Thu, 6 Apr 2017 16:17:31 +0900, Masahiko Sawada >> wrote in

Re: [HACKERS] tablesync patch broke the assumption that logical rep depends on?

On Fri, Apr 14, 2017 at 1:28 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 4/10/17 13:28, Fujii Masao wrote: >> src/backend/replication/logical/launcher.c >> * Worker started and attached to our shmem. This check is safe >>

Re: [HACKERS] logical replication and PANIC during shutdown checkpoint in publisher

On Thu, Apr 13, 2017 at 5:25 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 4/12/17 09:55, Fujii Masao wrote: >> To fix this issue, we should terminate walsender for logical replication >> before shutdown checkpoint starts. Of course walsender for physical

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

On Wed, Apr 12, 2017 at 10:32 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/04/12 0:22, Fujii Masao wrote: >> On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote >> <langote_amit...@lab.ntt.co.jp> wrote: >>> On 2017/04/07 0:56, Fujii Masao wrote:

Re: [HACKERS] Tab completion support for ALTER SUBSCRIPTION REFRESH PUBLICATION

On Thu, Apr 13, 2017 at 11:05 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Apr 12, 2017 at 11:48 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Apr 12, 2017 at 5:12 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> Hi,

Re: [HACKERS] Tab completion support for ALTER SUBSCRIPTION REFRESH PUBLICATION

e.c, but not in the documentation. ALTER PUBLICATION has the same issue, too. So I think that we need to apply the attached patch which improves the documentation for ALTER PUBLICATION and SUBSCRIPTION. Regards, -- Fujii Masao bugfix.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] logical rep worker for table sync can start and stop very frequently unexpectedly

On Wed, Apr 12, 2017 at 2:40 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Apr 12, 2017 at 2:05 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> Hi, >> >> I observed $subject when I ran the following steps. >> >> 1. start the publisher

[HACKERS] logical replication and PANIC during shutdown checkpoint in publisher

. To fix this issue, we should terminate walsender for logical replication before shutdown checkpoint starts. Of course walsender for physical replication still needs to keep running until shutdown checkpoint ends, though. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql

[HACKERS] logical rep worker for table sync can start and stop very frequently unexpectedly

and it also exits immediately because of primary key violation. This sequence repeats very fast... Attached is the script that I used to reproduce the issue. Regards, -- Fujii Masao test.sh Description: Bourne shell script -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

On Fri, Apr 7, 2017 at 9:53 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/04/07 0:56, Fujii Masao wrote: >> On Tue, Apr 4, 2017 at 10:19 AM, Amit Langote >> <langote_amit...@lab.ntt.co.jp> wrote: >>> It seems pg_stat_progress_vacuum is

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

On Tue, Apr 11, 2017 at 4:50 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Tue, Apr 11, 2017 at 1:39 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Mon, Apr 10, 2017 at 9:39 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> On

[HACKERS] tablesync patch broke the assumption that logical rep depends on?

worker. So the above assumption is not valid for now. This issue seems to cause the corner case where the launcher picks up the same worker slot that previously-started worker has already picked up to start another worker. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] max_sync_workers_per_subscription is missing in postgresql.conf

at we should not only add the parameter into postgresql.conf.sample but also - add REPLICATION_SUBSCRIBERS into config_group - mark max_logical_replication_workers and max_sync_workers_per_subscription as REPLICATION_SUBSCRIBERS parameters, in guc.c - move those parameters into "Subscribers" section in postgresql.c

Re: [HACKERS] Remove pg_stat_progress_vacuum from Table 28.2

hould appear in the table of "Dynamic Statistics Views" because it reports dynamic info, i.e., progress, about VACUUM activity? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stat_wal_write statistics view

} > > I'm *very* doubtful about this, but even if we do it, this needs careful > benchmarking. > >> /* signal that we need to wakeup walsenders later */ >> @@ -3043,6 +3157,9 @@ XLogBackgroundFlush(void) >> { >> XLogWrite(WriteRqst, flexible); >> } >> + >> + /* Collect all the wal write shared counters into local, and report it >> to stats collector */ >> + memcpy(, >stats, >> sizeof(PgStat_WalWritesCounts)); >> LWLockRelease(WALWriteLock); > > Hm. I think in a good number of workloads hti sis never reached, because > we return early. > > > I think this is an interesting feature, but I don't think it's ready, > and it was submitted very late in the v10 release cycle. Therefore I > think this should be moved to the next CF. +1 I think that there is no consensus yet about what values should be exposed. For example, with the patch, WAL writing activity by backends is reported separately from that by the other processes. But I'm not sure if this grouping is good. It seems better to report walwriter activity separately from the others, for tuning of walwriter. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] logical replication and SIGHUP

Hi, Both launcher and worker don't handle SIGHUP signal and cannot reload the configuration. I think that this is a bug. Will add this as an open item barring objection. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Quorum commit for multiple synchronous replication.

On Wed, Apr 5, 2017 at 3:45 PM, Noah Misch <n...@leadboat.com> wrote: > On Mon, Dec 19, 2016 at 09:49:58PM +0900, Fujii Masao wrote: >> Regarding this feature, there are some loose ends. We should work on >> and complete them until the release. >> >> (1) >&g

Re: [HACKERS] [COMMITTERS] pgsql: Logical replication support for initial data copy

w the error message style in docs. Also It seems a bit unclear to me. So what about replacing it with something like the following? ERROR: must connect to database to execute command \"%s\" Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

Re: [HACKERS] [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

On Wed, Mar 29, 2017 at 3:31 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> On Sun

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

Am Mittwoch, den 29.03.2017, 15:22 +0900 schrieb Michael Paquier: >> > On Wed, Mar 29, 2017 at 3:56 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> > > If your need other information except START WAL LOCATION at the >> > > beginning of >> >

Re: [HACKERS] [patch] reorder tablespaces in basebackup tar stream for backup_label

retrieve them at the beginning even when WAL files are included in the backup. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stat_wal_write statistics view

On Tue, Mar 28, 2017 at 1:40 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Mon, Mar 27, 2017 at 1:27 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> >> >> On Sat, Mar 25, 2017 at 6:40 AM, Fujii Masao <masao.fu...@gmai

Re: [HACKERS] [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>>

Re: [HACKERS] [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> On Mon,

[HACKERS] logical replication worker and statistics

Hi, Logical replication worker should call pgstat_report_stat()? Currently it doesn't seem to do that and no statistics about table accesses by logical replication workers are collected. For example, this can prevent autovacuum from working on those tables properly. Regards, -- Fujii Masao

Re: [HACKERS] [COMMITTERS] pgsql: Allow vacuums to report oldestxmin

quot;tuples" in the above should be "row versions"? We should review not only this line but also all the lines in the example of VERBOSE output, I think. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stat_wal_write statistics view

u separate "write_blocks", "write_time" and "sync_time" per the process category, like "backend_writes" and "writes"? This view doesn't seem to take into consideration the WAL writing and flushing during creating new WAL segment file. I think that it's better to make this view report also the number of WAL pages which are written when wal_buffer is full. This information is useful to tune the size of wal_buffers. This was proposed by Nagayasu before. https://www.postgresql.org/message-id/4ff824f3.5090...@uptime.jp Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

On Thu, Mar 23, 2017 at 4:28 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Wed, Mar 15, 2017 at 7:51 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Wed, Mar 15, 2017 at 1:09 PM, Yugo Nagata <nag...@sraoss.co.jp> wrote: >>> On Fri, 10 Mar

Re: [HACKERS] Report the number of skipped frozen pages by manual VACUUM

vacrelstats->pinskipped_pages); >> appendStringInfo(, ngettext("%u frozen page.\n", "%u frozen >> pages.\n", >> vacrelstats->frozenskipped_pages), >> vacrelstats->frozenskippe

Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional

On Thu, Mar 23, 2017 at 12:37 AM, Stephen Frost <sfr...@snowman.net> wrote: > David, all, > > * David Steele (da...@pgmasters.net) wrote: >> On 3/21/17 2:34 PM, Fujii Masao wrote: >> >The patch basically looks good to me, but one comment is; >> >backup.sgm

Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional

y for committer. The patch applied cleanly and worked as > expected. The patch basically looks good to me, but one comment is; backup.sgml (at least the description for "Making a non-exclusive low level backup) seems to need to be updated. Regards, -- Fujii Masao -- Sent via pgsql-hackers maili

Re: [HACKERS] Renaming of pg_xlog and pg_clog

or the commit. monitoring.sgml still has some references to "clog". We should update them? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [bug fix] dblink leaks unnamed connections

reat this as a bug right now and back-patch. Or we should fix this only in HEAD? Anyway I'd like to hear more opinions about this. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

On Wed, Mar 8, 2017 at 9:05 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Feb 8, 2017 at 12:04 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Tue, Feb 7, 2017 at 2:13 AM, Petr Jelinek >> <petr.jeli...@2ndquadrant.com> wrote: >>

[HACKERS] ALTER PUBLICATION and segmentation fault

RENAME TO hoge; Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Resolved typo in a comment

On Mon, Feb 20, 2017 at 7:34 AM, neha khatri <nehakhat...@gmail.com> wrote: > Hi, > > Attached is a patch that fixes a comment typo in varlena.c Thanks! Pushed. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to yo

Re: [HACKERS] SUBSCRIPTION command hangs up, segfault occurs in the server process and to cancel the execution.

postgres.c:4064 > #10 0x007b34e0 in BackendRun (port=0x268f4b0) at postmaster.c:4310 > #11 0x007b2c60 in BackendStartup (port=0x268f4b0) at postmaster.c:3982 > #12 0x007af2e0 in ServerLoop () at postmaster.c:1722 > #13 0x007ae9a4 in PostmasterMain (argc=5, argv

Re: [HACKERS] Walsender crash

(argc=3, > argv=0x7fbcabc02b90) + 5397 at postmaster.c:1330 > frame #14: 0x00010e76371f postgres`main(argc=3, > argv=0x7fbcabc02b90) + 751 at main.c:228 > frame #15: 0x00007fffa951c255 libdyld.dylib`start + 1 > frame #16: 0x7fffa951c255 libdyld.dylib`start +

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

On Tue, Feb 21, 2017 at 7:52 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Tue, Feb 21, 2017 at 3:42 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> On

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

On Thu, Feb 16, 2017 at 11:40 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Feb 16, 2017 at 7:52 AM, Petr Jelinek > <petr.jeli...@2ndquadrant.com> wrote: >> On 15/02/17 06:43, Masahiko Sawada wrote: >>> On Tue, Feb 14, 2017 at 1:13 AM, Fujii Ma

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Fri, Feb 17, 2017 at 11:17 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 2/13/17 12:07, Fujii Masao wrote: >> Anyway IMO that we can expose all the >> columns except the sensitive information (i.e., subconninfo field) >> in pg_subscription to e

[HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" from SQL-callable functions in p

On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rh...@postgresql.org> wrote: >>> Remove all references t

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Fri, Feb 10, 2017 at 1:52 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Feb 7, 2017 at 6:35 AM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> On 2/6/17 10:54 AM, Fujii Masao wrote: >>> Yes, that's an option. And, if we

[HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" from SQL-callable functions in p

for > some users.) There are still some mentions to "xlog" in the doc. Maybe we should replace them with "wal" as the attached patch does. Regards, -- Fujii Masao xlog2wal.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

>>> <petr.jeli...@2ndquadrant.com> wrote: >>>> On 08/02/17 07:40, Masahiko Sawada wrote: >>>>> On Wed, Feb 8, 2017 at 9:01 AM, Michael Paquier >>>>> <michael.paqu...@gmail.com> wrote: >>>>>> On Wed, Feb 8, 2017 at

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

; is now visible so the subscription is no longer there? Another idea is to treat DROP SUBSCRIPTION in the same way as VACUUM, i.e., make it emit an error if it's executed within user's transaction block. Also DROP SUBSCRIPTION should call CommitTransactionCommand() just after removing the entry fr

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

On Tue, Feb 7, 2017 at 2:13 AM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 06/02/17 17:33, Fujii Masao wrote: >> On Sun, Feb 5, 2017 at 5:11 AM, Petr Jelinek >> <petr.jeli...@2ndquadrant.com> wrote: >>> On 03/02/17 19:38, Fujii Masao wrote: >>

Re: [HACKERS] DROP SUBSCRIPTION and ROLLBACK

_to_stop" seem to be set to true even if the transaction is rollbacked. This would cause the same problem that you're trying to fix. I think that we should make the launcher periodically checks pg_subscription and stop the worker if there is no its corresponding subscription. Then, if necessary, the

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

On Sun, Feb 5, 2017 at 5:11 AM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 03/02/17 19:38, Fujii Masao wrote: >> On Sat, Feb 4, 2017 at 12:49 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >>> On Fri, Feb 3, 2017 at 10:56 AM, Kyotaro HORIGUCHI >&g

Re: [HACKERS] [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable?

On Tue, Feb 7, 2017 at 12:36 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Fujii Masao <masao.fu...@gmail.com> writes: >> On Mon, Feb 6, 2017 at 4:01 PM, Tsunakawa, Takayuki >> <tsunakawa.ta...@jp.fujitsu.com> wrote: >>> I don't have a strong opinio

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Mon, Feb 6, 2017 at 1:52 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sun, Feb 5, 2017 at 5:04 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> With this patch, when normal users type TAB after SUBSCRIPTION, >> they got "permission denied" e

Re: [HACKERS] [RFC] Should "SHOW huge_pages" display the effective value "off" when the huge page is unavailable?

he server actually uses huge page or not in huge_page=try case. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

id that they would make another serious mistake (e.g., remove pg_wal because it has many files and it occupies large amount of disk space) even after renaming to pg_wal. The crazy idea, making initdb create the empty file with the name "DONT_REMOVE_pg_xlog_IF_YOU_DONT_WANT_TO_LOSE_YOUR_IMPORTANT_DATA&quo

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

; cases, the publication defined in the publisher side should be specified. But, with this patch, the tab-completion for PUBLICATION shows the publications defined in local server (ie, subscriber side in those cases). This might be confusing. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

On Fri, Feb 3, 2017 at 3:55 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 2/2/17 12:48 PM, Fujii Masao wrote: >> +#define Query_for_list_of_subscriptions \ >> +" SELECT pg_catalog.quote_ident(subname) "\ >> +" FROM pg_catalog

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

On Sat, Feb 4, 2017 at 12:49 AM, Fujii Masao <masao.fu...@gmail.com> wrote: > On Fri, Feb 3, 2017 at 10:56 AM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> At Fri, 3 Feb 2017 01:02:47 +0900, Fujii Masao <masao.fu...@gmail.com> wrote >> in

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

On Fri, Feb 3, 2017 at 10:56 AM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Fri, 3 Feb 2017 01:02:47 +0900, Fujii Masao <masao.fu...@gmail.com> wrote > in

Re: [HACKERS] Provide list of subscriptions and publications in psql's completion

scription should be accessed here, instead. Thought? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

worker. But LogicalRepLauncherLock protects those operations, so logicalrep_worker_stop() called while holding the lock should always think the above condition is false. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Cannot shutdown subscriber after DROP SUBSCRIPTION

> enclosed by PG_TRY-CATCH since some functions can throw > exceptions. The lwlock would be released when an exception occurs, so I don't think that TRY-CATCH is necessary here. Or it's necessary for another reason? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

on > page comes. I'm afraid that many WAL segments would start with a continuation record when there are the workload of short transactions (e.g., by pgbench), and which would make restart_lsn go behind very much. No? The discussion on this thread just makes me think that restart_lsn should indicate the replay location instead of flush location. This seems safer. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [bug fix] Cascading standby cannot catch up and get stuck emitting the same message repeatedly

the situation and reason of check, see if you find >>> that as okay? >> >> Thank you, I'm happy with your comment. >> > > Okay, I have marked the patch as 'Ready for Committer'. Pushed. Thanks! Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] src/test/README for logical replication

On Tue, Jan 24, 2017 at 7:17 AM, Craig Ringer <cr...@2ndquadrant.com> wrote: > src/test/README wasn't updated for the new src/test/subscription entry. > > Patch attached. Thanks! Pushed. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgres

Re: [HACKERS] Logical Replication WIP

On Sat, Jan 21, 2017 at 1:39 AM, Petr Jelinek <petr.jeli...@2ndquadrant.com> wrote: > On 20/01/17 17:33, Jaime Casanova wrote: >> On 20 January 2017 at 11:25, Petr Jelinek <petr.jeli...@2ndquadrant.com> >> wrote: >>> On 20/01/17 17:05, Fujii Masao wrote: &

Re: [HACKERS] Checksums by default?

n terms of CPU and in terms of > produced WAL (=network traffic) given that it turns on logging of hint bits. +1 If the performance overhead by the checksums is really negligible, we may be able to get rid of wal_log_hints parameter, as well. Regards, -- Fujii Masao -- Sent via pgsql-hacke

Re: [HACKERS] Fix documentation typo

s, > -- > Ayumi Ishii > > 2017-01-19 15:56 GMT+09:00 Ishii Ayumi <ishii.ayumi...@gmail.com>: >> Hi, >> >> Here is a patch that adds temporary column's description to >> pg_replication_slots document. This is the oversight of commit a924c32. Thanks for the

Re: [HACKERS] Logical Replication WIP

does logical replication launcher need to start up by default? $ initdb -D data $ pg_ctl -D data start When I ran the above commands, I got the following message and found that the bgworker for logical replicatdion launcher was running. LOG: logical replication launcher started Reg

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.

On Tue, Jan 17, 2017 at 10:37 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Jan 17, 2017 at 5:40 PM, Fujii Masao <fu...@postgresql.org> wrote: >> Fix an assertion failure related to an exclusive backup. >> >> Previously multiple sessi

Re: [HACKERS] Measuring replay lag

On Thu, Dec 22, 2016 at 6:14 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Dec 22, 2016 at 2:14 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> I agree that the capability to measure the remote_apply lag is very useful. >> Also I want

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

he functions like xlog_position in pg_create_physical_replication_slot, etc. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_basebackups and slots

quot;no_slot" here? Since no_slot=true means that no temporary replication slot is specified, it's fine even with both -X none and fetch. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in condition_variable.c

On Mon, Jan 16, 2017 at 6:34 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Mon, Jan 16, 2017 at 6:27 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> Hi,

Re: [HACKERS] Typo in condition_variable.c

On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > Hi, > > Attached patch fixes comment typos in condition_variable.c Seems the patch still has the typo. "initiailly" should be "initially"? Regards, -- Fujii Masao -- Sent vi

Re: [HACKERS] Re: Clarifying "server starting" messaging in pg_ctl start without --wait

ps outputing. This makes me think that -W is better as the default of at least "pg_ctl start". Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal for changes to recovery.conf API

On Thu, Jan 12, 2017 at 6:46 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > On 12 January 2017 at 05:49, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Jan 11, 2017 at 7:36 PM, Simon Riggs <si...@2ndquadrant.com> wrote: >>> On 11 January 2017 at 09:51

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

ynthia S, Jim N, > Vladimir, Simon R, Fujii-san => 8 > If I misunderstood things, please feel free to speak up. To be pricise, I'd like to avoid the renaming of the functions at all rather than using aliases. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal for changes to recovery.conf API

On Wed, Jan 11, 2017 at 7:36 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > On 11 January 2017 at 09:51, Fujii Masao <masao.fu...@gmail.com> wrote: > >>> 5. recovery.conf parameters are all moved to postgresql.conf, with these >>> changes >> >&g

  1   2   3   4   5   6   7   8   9   10   >