Correct Fabien. I have already removed myself as a reviewer. Thanks.
-
robins | mobile
On 20 Sep. 2017 5:13 pm, "Fabien COELHO" wrote:
>
> Hello Robins,
>
> I was able to test the functionality (which seemed to work fine) and fed in
>> my comment to assist anyone el
I was able to test the functionality (which seemed to work fine) and fed in my
comment to assist anyone else reviewing this patch (and intentionally let it's
state as 'Needs Review').
While trying to provide my feedback, on hindsight I should have been more
detailed about what I didn't test. Be
ds Review' because clearly needs it.
Apologies for the noise here.
-
robins
On 20 September 2017 at 16:18, Fabien COELHO wrote:
>
> Hello Robins,
>
> Thanks for the review.
>
> The following review has been posted through the commitfest application:
>> make insta
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation:tested, failed
The patch applies cleanly and compiles + installs fine (although am u
l.
(I'll try to work on the tests, but sending this
nonetheless
).
-
robins
pgdump_nocomments_v3.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t if you could help with the tests though, am unsure how to
go about them.
-
robins
pgdump_nocomments_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
name (for e.g. --no-extension-comments or something) would help and I could
submit a revised patch.
Alternatively, if there are no objections, I could submit this to the
Commitfest.
References:
[1] https://www.postgresql.org/message-id/1420.1397099637%40sss.pgh.pa.us
-
robins
On 5 March 2017 at 18:00, Simon Riggs wrote:
> I'm looking to commit the patch version I posted, so I would like your
> comments that it does continue to solve the problems you raised.
>
Thanks Simon, for confirming.
Yes, the updated patch does solve the problem.
-
robins
ad idea, since the patch
doesn't do anything more than dump from pg_roles, which is anyways
available to non-superusers.
I await if more object similarly.
-
robins
e, this 'is' Postgres. Further,
case-by-case exceptions still should be considered for important issues
(here, this relates to lock-in).
Either way, I could pull-back the patch if more people object.
-
robins
does successfully
complete with all existing users dumped successfully.
pg_dumpall --globals-only --no-role-password > a.sql
> Yes, please do create a commitfest entry for this.
>
> Created Commitfest entry.
-
robins
use_pgroles_instead_of_pg_authid.diff.gz
Description: GNU Zip compres
On 19 February 2017 at 17:02, Robins Tharakan wrote:
>
> On Sun, 19 Feb 2017 at 10:08 Stephen Frost wrote:
>
>> If anything, it should use pg_roles, not pg_user.
>>
>> I don't really like the "--avoid-pgauthid" option, but "--no-passwords"
&
ub URL given earlier uses
pg_roles).
'--no-passwords' is a good alternative.
Would submit a patch soon.
-
Robins
--
-
robins
a few weeks old):
https://github.com/postgres/postgres/commit/552f4d92fde9518f934447e032b8ffcc945f12d9
Thanks
Robins Tharakan
http://www.thatguyfromdelhi.com/2016/12/custom-pgdumpall-now-works-with-aws.html
--
-
robins
NALYSE; should solve this? ... Would get back if I have
something else to offer.
-
robins
--
-
robins
On Fri, 9 Sep 2016 at 09:39 Andres Freund wrote:
> On 2016-09-07 23:37:31 +0000, Robins Tharakan wrote:
> > If someone asks for I could provide SQL + EXPLAIN, but it feels
> irrelevant
> > here.
>
> Why is that? information_schema are normal sql queries, and some of
p.s.: All postgres servers are running the v9.3.10
-
robins
--
-
robins
is kludgy.
Created a GitHub Repo in case someone's interested (
https://github.com/robins/npp-lang-plpgsql).
For PLPGSQL, (src/pl/plpgsql/src/pl_scanner.c)
For DataTypes, (src/interfaces/ecpg/preproc/c_keywords.c
; src/backend/bootstrap/bootstrap.c) as well as parse all HTML pages un
HTML Tags (such as VARNAME /
TOKEN / LITERAL / COMMAND) in PG Documentation but is there's a simpler
(more accurate) way for this?
Any pointers would be great!
-
thanks
robins
; From http://www.postgresql.org/docs/devel/static/pgbench.html:
>
>-b scriptname[@weight]
>Add the specified builtin script to the list of executed scripts. [...]
>
> Idem -f.
>
> And later at the beginning of the Notes:
>
>pgbench executes test scripts chosen randomly from a specified list.
>They include built-in scripts with -b and user-provided custom scripts
> with -f.
>[...]
>
> --
> Fabien.
--
-
robins
should be warned about.
>
Thanks Fabien, for confirming about the missing warning.
Also, by 'combined' I think you mean that both (built-in SELECTs & Custom
Script) run, although the dev docs don't (yet) say anything about that.
-
robins
something else like that?
Effectively, I think it should raise NOTICE that -f is useless here.
-
robins
--
-
robins
On 29 October 2015 at 15:35, Amit Langote
wrote:
> errmsg_plural() function determines whether to output the singular version
> or the plural
>
Duh. Thanks Amit!
Should have noticed the function-name change.
--
Robins Tharakan
intentional.
--
Robins Tharakan
lier could take care of my
use-case, so we may need more people requesting this magic field, with a
valid use-case.
--
Robins Tharakan
row.
Any pointers would be helpful.
Couldn't find anything related in 9.5devel docs either.
--
thanks
Robins
On 6 July 2013 20:25, Robins Tharakan wrote:
>
> Do let me know your view on this second point, so that I can remove these
> tests if so required.
Hi,
Please find attached the updated patch.
It address the first issue regarding reducing the repeated CREATE / DROP
ROLEs.
It stil
med v5 as v6 for clarity).
git reset --hard HEAD
git pull
patch -p1 < ../regress_sequence_v6.patch
patch -p1 -R < ../regress_sequence_v6.patch
patch -p1 < ../regress_sequence_v6.patch
make clean
./configure --enable-depend --enable-coverage --enable-cassert
--enable-debug
ma
patch -p1 < ../regress_schema_v6.patch
patch -p1 -R < ../regress_schema_v6.patch
patch -p1 < ../regress_schema_v6.patch
make clean
./configure --enable-depend --enable-coverage --enable-cassert
--enable-debug
make -j3 check
Do let me know if something is still amiss.
--
Robins Tharakan
regress_schema_v
e-debug
make -j3 check
Do let me know if something is still amiss.
--
Robins Tharakan
Hi Fabien,
Appreciate you being able to check right away.
Seems something went wrong with these set of patches... Would check again
and resubmit them soon.
--
Robins Tharakan
On 9 July 2013 10:57, Fabien COELHO wrote:
>
> Hello Robins,
>
>
> PFA an updated patch:
>> -
at its required for this
submission.
--
Robins Tharakan
On 18 June 2013 05:01, Szymon Guz wrote:
> I've checked the patch. Applies cleanly. Tests pass this time :)
Updated the patch:
- Updated ROLE names as per Robert's feedback (regress_xxx)
- Added test to serial_schedule
--
Robins Tharakan
regress_variable_v5.patch
Description
On 23 May 2013 18:19, Robins Tharakan wrote:
> Please find attached a patch to take code-coverage of LOCK TABLE (
> src/backend/commands/lockcmds.c) from 57% to 84%.
Updated the patch:
- Updated ROLEs as per Robert's feedback
- Added test to serial_schedule.
--
Robi
On 26 June 2013 01:55, Robins Tharakan wrote:
>
> Code coverage improved from 36% to 68%.
>
Updated patch:
- Renamed ROLEs as per Robert's feedback (prepend regress_xxx)
- Added test to serial_schedule (missed out earlier).
--
Robins Tharakan
regress_db_v5.patch
Descriptio
On 3 July 2013 10:13, Robert Haas wrote:
> I think you should rename the roles used here to regress_rol_seq1 etc.
> to match the CREATE OPERATOR patch.
>
Please find updated patch:
- 'make check' successful with recent changes
- Renamed ROLEs as per feedback
s there instead.
>
> Rename regression users to regress_rol_nsp1 etc. per convention
> established in the CREATE OPERATOR patch.
>
Hi Robert,
PFA an updated patch:
- Renamed ROLEs as per new feedback (although the previous naming was also
as per an earlier feedback)
- Merged t
a patch, updated towards serial_schedule /
parallel_schedule as well as the role name change as per Robert's feedback
on CREATE OPERATOR thread.
--
Robins Tharakan
On 2 July 2013 09:32, Fabrízio de Royes Mello wrote:
> On Mon, Jul 1, 2013 at 5:59 PM, Robins Tharakan wrote:
>
>>
100% code-coverage isn't the goal, I think
all tests are important, syntactical or otherwise. Its possible that not
all code is reachable (therefore testable) but the vision generally remains
at 100%.
Do let me know your view on this second point, so that I can remove these
tests if so required.
Robins Tharakan
On 26 June 2013 02:26, Robins Tharakan wrote:
> So technically I hope this regression patch I submitted could go through
> since this feedback isn't towards that patch, but in my part I am quite
> intrigued about this test (and how it passes) and probably I'd get back on
>
LANS line, although I
amn't sure on how to validate that its working.
Personally, I wouldn't call this a great patch, since most of the tests
were already running, although in a generic script. The separation of
DISCARD related tests to another file is arguably good for the long-term
though.
submitting a patch and there'd be a big pile up near a release.
- For now, the new tests that I submit for review (for next CF) would be
for 'make check', until a 'make bigcheck' or whatever is up and running.
--
Robins Tharakan
> Number of new lines added not covered by tests: -107 (Wierd but, it seems
> to have reduced line coverage). But correct me if am not seeing the
> elephant in the room.
>
>
My apologies.
Number of new untested lines: 108
Robins
tion Updated: No. (Required?)
- Tests Updated: No. (Required?)
- All tests pass: Yes
- Does it Work : ???
- Any visible issues: No
- Any compiler warnings: No
- Others:
Number of uncovered lines: Reduced by 167 lines
Robins Tharakan
cessary extra-lines: Yes
- Do we want it?: ???
- Any visible issues: No
- Any compiler warnings: No
- Others:
Number of new lines added not covered by tests: -107 (Wierd but, it seems
to have reduced line coverage). But correct me if am not seeing the
elephant in the room.
--
Robins Tharakan
he previous
patch were within transactions. So didn't have to explicitly drop any ROLEs
at the end of the script.
--
Robins Tharakan
regress_createoperator_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
patch again.
--
Robins Tharakan
On 28 June 2013 15:53, Josh Berkus wrote:
> On 05/07/2013 03:40 PM, Robins Tharakan wrote:
> > Hi,
> >
> > Have provided an updated patch as per Fabien's recent response on
> > Commitfest site.
> > Any and all feedback is app
tually got enforced was something I missed, but well, its
out of the window for now anyway.
--
Robins Tharakan
On 26 June 2013 06:34, Andres Freund wrote:
> Hi,
>
> I am generally a bit unsure whether the regression tests you propose
> aren't a bit too verbose. Does any of the com
Sure Robert.
I 'll update the tests and get back.
Two questions, while we're at it:
1. Any other conventions (for naming)?
2. Should I assume that all database objects that get created, need to be
dropped explicitly? Or is this point specifically about ROLES?
--
Robins Tharakan
So technically I hope this regression patch I submitted could go through
since this feedback isn't towards that patch, but in my part I am quite
intrigued about this test (and how it passes) and probably I'd get back on
this thread about this particular commented out test in question, as time
perm
iew more patches and mark them so on the
commitfest page
soon
.
--
Robins Tharakan
On 23 June 2013 23:41, Josh Berkus wrote:
> Folks,
>
> For 9.2, we adopted it as policy that anyone submitting a patch to a
> commitfest is expected to review at least one patch submitted by someone
hecking whether the 'CONNECTION LIMIT'
was working. Removed that as well.
Code coverage improved from 36% to 68%.
--
Robins Tharakan
On 24 June 2013 07:47, Andres Freund wrote:
> On 2013-05-21 02:58:25 +0530, Robins Tharakan wrote:
> > Attached is an updated patch that does
d get something going to
respond as soon as is possible.
Thanks
--
Robins Tharakan
--
Robins Tharakan
On 17 June 2013 05:19, Szymon Guz wrote:
> On 23 May 2013 00:34, Robins Tharakan wrote:
>
>> Hi,
>>
>> Please find attached a patch to take code-coverage of CREATE OPER
Thanks !
PFA the updated patch. Also remove a trailing whitespace at the end of SQL
script.
--
Robins Tharakan
On 17 June 2013 17:29, Szymon Guz wrote:
> On 26 May 2013 19:56, Robins Tharakan wrote:
>
>> Hi,
>>
>> Please find attached a patch to take code-coverag
rightarg = path,
procedure = path_inter,
commutator = ##
);
NOTICE: operator ## already exists, skipping
=
--
Robins Tharakan
On 24 May 2013 20:52, Fabrízio de Royes Mello wrote:
> Hi all,
>
> I working in a patch to include support of "IF NOT EXISTS" into "CREATE&qu
rt NO
T177Sequence generator support: simple restart option NO
T522Default values for IN parameters of SQL-invoked procedures
NO
T571Array-returning external SQL-invoked functions NO
--
Robins Tharakan
Hi,
Please find attached a patch to take code-coverage of SET (SESSION / SEED /
TRANSACTION / DATESTYLE / TIME ZONE) (src/backend/commands/variable.c) from
65% to 82%.
Any and all feedback is welcome.
--
Robins Tharakan
regress_variable.patch
Description: Binary data
--
Sent via pgsql
Hi,
Please find attached a patch to take code-coverage of LOCK TABLE (
src/backend/commands/lockcmds.c) from 57% to 84%.
Any and all feedback is welcome.
--
Robins Tharakan
regress_lock.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
Hi,
Please find attached a patch to take code-coverage of ALTER OPERATOR
FAMILY.. ADD / DROP (src/backend/commands/opclasscmds.c) from 50% to 87%.
Any and all feedback is welcome.
--
Robins Tharakan
regress_opclass.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql
Hi,
Please find attached a patch to take code-coverage of CREATE OPERATOR
(src/backend/commands/operatorcmds.c) from 56% to 91%.
Any and all feedback is welcome.
--
Robins Tharakan
regress_createoperator.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers
Hi,
Attached is an updated patch that does only 1 CREATE DATABASE and reuses
that for all other tests.
The code-coverage with this patch goes up from 36% to 70%.
--
Robins Tharakan
On 13 May 2013 21:04, Robins Tharakan wrote:
> I believe Tom / Andres and Fabien all have valid points.
>
need to be
clubbed (bundled up in 2-3) and submitted as a single submit.
--
Robins Tharakan
regress_async.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
preferably with minimal
CREATE/DROP).
--
Robins Tharakan
On 13 May 2013 20:30, Andres Freund wrote:
> On 2013-05-13 16:52:08 +0200, Fabien COELHO wrote:
> >
> > Hello,
> >
> > >>Would you be okay if there is one/a few effective create/drop (some
> tests
Hi,
Please find attached a patch that adds basic regression tests for DISCARD
command.
Any and all feedback is obviously welcome.
--
Robins Tharakan
regress_discard_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
Hi,
Please find attached a patch to take code-coverage of DBCommands (CREATE
DATABASE / ALTER DATABASE / DROP DATABASE) from 36% to 71%.
Any and all feedback is obviously welcome.
--
Robins Tharakan
regress_db_v2.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql
abled).
This updated patch doesn't have UTF8 string anywhere.
Let me know if you prefer to remove the commented out tests completely.
--
Robins Tharakan
On 9 May 2013 07:44, Tom Lane wrote:
> Robins Tharakan writes:
> > Fabien pointed out that currently does not check for non-trivial
ing validated
in ALTER ROLE VALID UNTIL.
Let me know if you need anything else changed in this.
--
Robins Tharakan
On 20 March 2013 03:41, Robins Tharakan wrote:
> Hi,
>
> Please find attached a patch to take 'make check' code-coverage of ROLE
> (USER) from 59% to 91%.
>
&
Hi,
Please find attached an updated patch with the said changes.
I'll try to update the other patches (if they pertain to this feedback) and
update on their respective threads (as well as on Commitfest).
--
Robins Tharakan
On 8 May 2013 13:01, Fabien COELHO wrote:
>
>
points out.
(Apologies for the delay though. An update to the patch was mostly done
back in April, but since most of the other Code-Coverage patches
(SCHEMA/ROLE/etc.) had no other feedback, I worked on all of them together
just this week).
--
Robins Tharakan
On 12 April 2013 09:28, Michael Paquier
Completely agree. Although the poster was kind enough to intimate me by
email about his update there, but was wondering that if he hadn't, I
wouldnt' have dreamt that there is a feedback on the site, two months down
the line.
--
Robins Tharakan
On 8 May 2013 09:13, Robert Haas wrote:
Hi,
Here is an updated patch that uses different schema / role names for
different tests (as per commitfest site feedback).
--
Robins Tharakan
On 18 March 2013 17:16, robins wrote:
> Hi,
>
> Attached is an updated patch that uses better schema / role names.
>
> --
> Robins
Hi,
Have provided an updated patch as per Fabien's recent response on
Commitfest site.
Any and all feedback is appreciated.
--
Robins Tharakan
regress_sequence_v4.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
IMING FALSE) ANALYZE SELECT 1;
^
mpf2=# SELECT version();
version
--
PostgreSQL 9.2.3 on x86_64-unknown-linux-gnu, compiled by gcc (GCC) 4.4.6
20120
305 (Red Hat 4.4.6-4), 64-bit
(1 row)
Thanks
--
Robins Tharakan
Hi,
Please find attached a patch to take 'make check' code-coverage of COLLATE
(/src/backend/commands/collationcmds) from 0% to 96%.
Any feedback is more than welcome. Also posting this to Commitfest-next.
--
Robins Tharakan
regress_collate_v1.patch
Description: Binary data
--
Sent
Hi,
Please find attached a patch to take 'make check' code-coverage of ROLE
(USER) from 59% to 91%.
Any feedback is more than welcome.
--
Robins Tharakan
regress_user.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chang
Duh. Apologies. That's what happens when you make that 1 last change.
Please find an updated patch.
--
Robins Tharakan
On 19 March 2013 04:07, Josh Kupershmidt wrote:
> On Mon, Mar 18, 2013 at 3:10 PM, Robins Tharakan
> wrote:
> > Hi,
> >
> > Please find an u
Hi,
Please find an updated patch (reworked on the names of SEQUENCES / ROLES /
SCHEMA etc.)
Takes code-coverage of 'make check' for SEQUENCE to ~95%.
--
Robins Tharakan
On 16 March 2013 02:03, robins wrote:
> Hi,
>
> I've added some regression tests for SEQUENC
Hi,
Attached is an updated patch that uses better schema / role names.
--
Robins Tharakan
On 18 March 2013 12:59, robins wrote:
> Thanks Alvaro.
>
> Since the tests were running fine, I didn't bother with elaborate names,
> but since you're concerned guess I'll mak
he SCHEMA patch once the above change is done.
--
Robins
On 18 March 2013 09:42, Alvaro Herrera wrote:
> robins escribió:
> > Hi,
> >
> > Please find attached a patch to take 'make check' code-coverage of SCHEMA
> > from 33% to 98%.
> >
> > Any fe
instead of submitting one patch at a time.
--
Robins
Tharakan
regress-schema.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
k') to
~95%.
Any feedback is more than welcome.
--
Robins
Tharakan
On 13 March 2013 15:41, robins wrote:
> Thanks Laurenz.
>
> Would correct these (and readup) before submitting next patch.
>
> --
> Robins
> Tharakan
>
>
> On 13 March 2013 13:49, Albe Laurenz
;s link is obviously helpful
but since I end up doing make check ~100 of times a day, for now its useful
only to cross-check how much code is uncommitted :)
Robins
On 11 March 2013 09:16, Alvaro Herrera wrote:
>
> I think increasing coverage is a good thing. But psql help? *shrug*
> backe
Thanks Laurenz.
Would correct these (and readup) before submitting next patch.
--
Robins
Tharakan
On 13 March 2013 13:49, Albe Laurenz wrote:
> robins wrote:
> > Attached is a small patch to test corner cases related to Sequences
> (basically aimed at increasing
> >
Hi,
Attached is a small patch to test corner cases related to Sequences
(basically aimed at increasing code-coverage of sequence.sql in regression
tests).
Look forward to any and all feedback.
--
Robins
Tharakan
commit-sequence.patch
Description: Binary data
--
Sent via pgsql-hackers mailing
-coverage (as
a task) is considered important at all (to me it is). If so, I could get
going with creating tests for more untouched lines / functions in 'make
check'.
Any other feedback is more than welcome.
(The patch is wrt to yesterday's pull)
---
Robins
Tharakan
commit-fa
of work, and
although not impossible, I wondered whether this has already been done.
How do you manage large list of functions (where a hard segregation isn't
hard and therefore one can't separate functions based on schemas) ?Any
pointers to a Free or Commercial tool would be of immense help.
Thanks,
Robins Tharakan
Sorry!
As rightly pointed out, guess I should have posted this to pgadmin-hackers
instead.
*Robins Tharakan*
On Mon, Mar 3, 2008 at 11:19 PM, Robins Tharakan <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I read about Google Summer of Code recently and being involved with
> pgAdmin
FOSDEM earlier. Since I am still into reading, I thought this probably is
the right time to ask. Is anyone working on a Query Builder for pgAdmin yet
?
Regards,
*Robins Tharakan*
88 matches
Mail list logo
