Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-09 Thread Magnus Hagander
In hindsight, all these ecpg changes should have been made between beta1 and beta2 when we have time to deal with the fallout, not right before beta1. Or considered new features and held back for 8.4. Not picking on Michael, but the resemblance to the /contrib discussion is striking. Ecpg

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-09 Thread Michael Meskes
On Tue, Oct 09, 2007 at 08:15:35AM +0200, Magnus Hagander wrote: In hindsight, all these ecpg changes should have been made between beta1 and beta2 when we have time to deal with the fallout, not right before beta1. This one I totally agree with. Or considered new features and held back

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-09 Thread Magnus Hagander
On Tue, Oct 09, 2007 at 10:00:51AM +0200, Michael Meskes wrote: On Tue, Oct 09, 2007 at 08:15:35AM +0200, Magnus Hagander wrote: In hindsight, all these ecpg changes should have been made between beta1 and beta2 when we have time to deal with the fallout, not right before beta1. This

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-08 Thread Bruce Momjian
In hindsight, all these ecpg changes should have been made between beta1 and beta2 when we have time to deal with the fallout, not right before beta1. --- Tom Lane wrote: This morning's ecpg patch certainly seems to have

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Magnus Hagander
Since this is an actual API library, perhaps a proper fix is to create a .def file listing the exports in it, the same way we do for libpq? And then we could (should!) also filter the exports the same ways as we do for libpq these days. (see the exports.txt file in libpq) I'll try

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Hannes Eder
Magnus Hagander schrieb: Since this is an actual API library, perhaps a proper fix is to create a .def file listing the exports in it, the same way we do for libpq? And then we could (should!) also filter the exports the same ways as we do for libpq these days. (see the exports.txt file in

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Magnus Hagander
On Wed, Oct 03, 2007 at 09:35:51AM +0200, Hannes Eder wrote: Magnus Hagander schrieb: Since this is an actual API library, perhaps a proper fix is to create a .def file listing the exports in it, the same way we do for libpq? And then we could (should!) also filter the exports the same ways

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-03 Thread Trevor Talbot
Note that unless there's some tools issue, DllMain doesn't need to be exported to function properly. A DLL's initialization routine is marked as the entry point in the PE header, same as main() in classic C. It might be simpler to just get rid of the export. ---(end of

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-02 Thread Hannes Eder
Magnus Hagander schrieb: On Sun, Sep 30, 2007 at 11:30:35PM -0400, Andrew Dunstan wrote: Tom Lane wrote: This morning's ecpg patch certainly seems to have been snake-bit. Although the Windows gcc buildfarm members seem happy, the MSVC ones are all failing with Linking...

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-01 Thread Magnus Hagander
On Sun, Sep 30, 2007 at 11:30:35PM -0400, Andrew Dunstan wrote: Tom Lane wrote: This morning's ecpg patch certainly seems to have been snake-bit. Although the Windows gcc buildfarm members seem happy, the MSVC ones are all failing with Linking... Creating library

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-10-01 Thread Magnus Hagander
On Sun, Sep 30, 2007 at 11:46:00PM -0400, Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: It is building with thread.c but it should not be unless I am misreading the Makefile. The makefile processing in Project.pm doesn't look nearly powerful enough to handle this: #

[HACKERS] Latest ecpg patch broke MSVC build

2007-09-30 Thread Tom Lane
This morning's ecpg patch certainly seems to have been snake-bit. Although the Windows gcc buildfarm members seem happy, the MSVC ones are all failing with Linking... Creating library Release\libecpg\libecpg.lib and object Release\libecpg\libecpg.exp libecpg.exp : error

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-09-30 Thread Andrew Dunstan
Tom Lane wrote: This morning's ecpg patch certainly seems to have been snake-bit. Although the Windows gcc buildfarm members seem happy, the MSVC ones are all failing with Linking... Creating library Release\libecpg\libecpg.lib and object Release\libecpg\libecpg.exp

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-09-30 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: It is building with thread.c but it should not be unless I am misreading the Makefile. The makefile processing in Project.pm doesn't look nearly powerful enough to handle this: # thread.c is needed only for non-WIN32 implementation of path.c

Re: [HACKERS] Latest ecpg patch broke MSVC build

2007-09-30 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: It is building with thread.c but it should not be unless I am misreading the Makefile. The makefile processing in Project.pm doesn't look nearly powerful enough to handle this: # thread.c is needed only for non-WIN32