Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-03-29 Thread Craig Ringer
On 15 March 2016 at 04:48, Andres Freund wrote: > On 2016-01-31 05:09:33 +0800, Craig Ringer wrote: > > On 29 January 2016 at 18:16, Andres Freund wrote: > > > > > Hi, > > > > > > so, I'm reviewing the output of: > > > > > > > Thankyou very much for the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-03-14 Thread Craig Ringer
On 15 March 2016 at 04:48, Andres Freund wrote: > On 2016-01-31 05:09:33 +0800, Craig Ringer wrote: > > On 29 January 2016 at 18:16, Andres Freund wrote: > > > > > Hi, > > > > > > so, I'm reviewing the output of: > > > > > > > Thankyou very much for the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-03-14 Thread Andres Freund
On 2016-01-31 05:09:33 +0800, Craig Ringer wrote: > On 29 January 2016 at 18:16, Andres Freund wrote: > > > Hi, > > > > so, I'm reviewing the output of: > > > > Thankyou very much for the review. Afaics you've not posted an updated version of this? Any chance you could?

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-31 Thread Michael Paquier
On Thu, Jan 7, 2016 at 4:50 PM, Craig Ringer wrote: > On 7 January 2016 at 01:17, Peter Eisentraut wrote: >> On 12/22/15 4:55 AM, Craig Ringer wrote: >> and we could probably go through them >> one by one and ask, why do we need this bit? So that kind of

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-30 Thread Craig Ringer
On 29 January 2016 at 18:16, Andres Freund wrote: > Hi, > > so, I'm reviewing the output of: > Thankyou very much for the review. > > + pglogical_output_plhooks \ > > I'm doubtful we want these plhooks. You aren't allowed to access normal > (non user catalog)

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-29 Thread Andres Freund
Hi, so, I'm reviewing the output of: > git diff $(git merge-base upstream/master > 2ndq/dev/pglogical-output)..2ndq/dev/pglogical-output > diff --git a/contrib/Makefile b/contrib/Makefile > index bd251f6..028fd9a 100644 > --- a/contrib/Makefile > +++ b/contrib/Makefile > @@ -35,6 +35,8 @@

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-18 Thread Tomasz Rybak
W dniu 07.01.2016, czw o godzinie 15∶50 +0800, użytkownik Craig Ringer napisał: > On 7 January 2016 at 01:17, Peter Eisentraut wrote: > > On 12/22/15 4:55 AM, Craig Ringer wrote: > > > I'm a touch frustrated by that, as a large part of the point of > > > submitting the output

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-07 Thread Jarred Ward
I didn't receive a response on the bugs mailing list for the following bug, so I was hoping we could triage to someone with more familiarity with Postgres internals than I to fix. This ticket seems like folks who are invested in logical decoding. The attached script is a simple workload that

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-07 Thread Andres Freund
On 2016-01-07 09:28:29 -0800, Jarred Ward wrote: > I didn't receive a response on the bugs mailing list for the following bug, > so I was hoping we could triage to someone with more familiarity with > Postgres internals than I to fix. Please don't post to unrelated threads, that just confuses

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-06 Thread Greg Stark
On Wed, Jan 6, 2016 at 5:17 PM, Peter Eisentraut wrote: > I can't imagine that there is a lot of interest in a replication tool > where you only get one side of it, no matter how well-designed or > general it is. Well I do have another purpose in mind myself so I do appreciate

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-06 Thread Peter Eisentraut
On 12/22/15 4:55 AM, Craig Ringer wrote: > I'm a touch frustrated by that, as a large part of the point of > submitting the output plugin separately and in advance of the downstream > was to get attention for it separately, as its own entity. A lot of > effort has been put into making this usable

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-06 Thread Craig Ringer
On 7 January 2016 at 01:17, Peter Eisentraut wrote: > On 12/22/15 4:55 AM, Craig Ringer wrote: > > I'm a touch frustrated by that, as a large part of the point of > > submitting the output plugin separately and in advance of the downstream > > was to get attention for it

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-12-22 Thread Craig Ringer
On 22 December 2015 at 15:17, Michael Paquier wrote: > On Mon, Dec 7, 2015 at 12:10 PM, Craig Ringer > wrote: > > Removed, change pushed. > > > > Also pushed a change to expose the decoded row data to row filter hooks. > > > > I won't cut a v4

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-12-22 Thread Robert Haas
On Tue, Dec 22, 2015 at 4:55 AM, Craig Ringer wrote: > I'm a touch frustrated by that, as a large part of the point of submitting > the output plugin separately and in advance of the downstream was to get > attention for it separately, as its own entity. A lot of effort has

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-12-21 Thread Michael Paquier
On Mon, Dec 7, 2015 at 12:10 PM, Craig Ringer wrote: > Removed, change pushed. > > Also pushed a change to expose the decoded row data to row filter hooks. > > I won't cut a v4 for this, as I'm working on merging the SGML-ified docs and > will do a v4 with that and the

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-12-06 Thread Craig Ringer
On 2 December 2015 at 18:38, Petr Jelinek wrote: > First, I wonder if it would be useful to mention somewhere, even if it's > only here in the mailing list how can the protocol be extended in > non-breaking way in future for transaction streaming if we ever get that. Good

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-12-02 Thread Petr Jelinek
Hi, I can't really do huge review considering I wrote half of the code, but I have couple of things I noticed. First, I wonder if it would be useful to mention somewhere, even if it's only here in the mailing list how can the protocol be extended in non-breaking way in future for

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-18 Thread Tomasz Rybak
W dniu 12.11.2015, czw o godzinie 22∶23 +0800, użytkownik Craig Ringer napisał: > Hi all > > Here's an updated pglogical_output patch. > > Selected changes since v1: > >     - add json protocol output support >     - fix encoding comparisons to use parsed encoding not string name >     - import

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-15 Thread Craig Ringer
On 16 November 2015 at 09:57, Peter Eisentraut wrote: > On 11/2/15 7:17 AM, Craig Ringer wrote: > > The output plugin is suitable for a number of uses. It's designed > > primarily to supply a data stream to drive a logical replication > > client running in another PostgreSQL

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-15 Thread Peter Eisentraut
On 11/2/15 7:17 AM, Craig Ringer wrote: > The output plugin is suitable for a number of uses. It's designed > primarily to supply a data stream to drive a logical replication > client running in another PostgreSQL instance, like the pglogical > client discussed at PGConf.EU 2015. So where is that

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-12 Thread Amit Langote
On 2015/11/02 23:36, Craig Ringer wrote: > On 2 November 2015 at 20:17, Craig Ringer wrote: >> Hi all >> >> I'd like to submit pglogical_output for inclusion in the 9.6 series as >> a contrib. > > Here's the protocol documentation discussed in the README. It's > asciidoc

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-11 Thread Craig Ringer
On 3 November 2015 at 02:58, Jim Nasby wrote: > On 11/2/15 8:36 AM, Craig Ringer wrote: > >> Here's the protocol documentation discussed in the README. It's >> asciidoc at the moment, so it can be formatted into something with >> readable tables. >> > > Is this by

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-03 Thread Craig Ringer
On 3 November 2015 at 16:41, Craig Ringer wrote: > On 3 November 2015 at 02:58, Jim Nasby wrote: >> On 11/2/15 8:36 AM, Craig Ringer wrote: >>> >>> Here's the protocol documentation discussed in the README. It's >>> asciidoc at the moment, so it

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-03 Thread Craig Ringer
On 3 November 2015 at 02:58, Jim Nasby wrote: > On 11/2/15 8:36 AM, Craig Ringer wrote: >> >> Here's the protocol documentation discussed in the README. It's >> asciidoc at the moment, so it can be formatted into something with >> readable tables. > > > Is this by chance

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Shulgin, Oleksandr
On Mon, Nov 2, 2015 at 1:17 PM, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Yay, that looks pretty advanced! :-) Still digesting... -- Alex

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Craig Ringer
On 2 November 2015 at 20:17, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Here's the protocol documentation discussed in the README. It's asciidoc at the moment, so it can be formatted into something

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Craig Ringer
On 2 November 2015 at 20:17, Craig Ringer wrote: > Hi all > > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. A few points are likely to come up in anything but the most cursory examination of the patch. The README alludes to protocol

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Jim Nasby
On 11/2/15 8:36 AM, Craig Ringer wrote: Here's the protocol documentation discussed in the README. It's asciidoc at the moment, so it can be formatted into something with readable tables. Is this by chance up on github? It'd be easier to read the final output there than the raw asciidoctor.

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Andres Freund
Hi, On 2015-11-02 20:17:21 +0800, Craig Ringer wrote: > I'd like to submit pglogical_output for inclusion in the 9.6 series as > a contrib. Cool! > See the README.md and DESIGN.md in the attached patch for details on > the plugin. I will follow up with a summary in a separate mail, along > with

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-02 Thread Craig Ringer
On 2 November 2015 at 20:35, Andres Freund wrote: > On 2015-11-02 20:17:21 +0800, Craig Ringer wrote: > >> See the README.md and DESIGN.md in the attached patch for details on >> the plugin. I will follow up with a summary in a separate mail, along >> with a few points I'd