2016-03-18 16:26 GMT+01:00 Teodor Sigaev :
> I hope so the messages are ok now. Few more regress tests added.
>>
>
> Thank you, committed.
Thank you very much
Pavel
>
>
> --
> Teodor Sigaev E-mail: teo...@sigaev.ru
>
Hi
2016-03-14 17:39 GMT+01:00 Teodor Sigaev :
> I afraid so I cannot to fix this inconsistency (if this is inconsistency -
>> the
>> binary values are same) - the parameter of function is raw string with
>> processed
>> escape codes, and I have not any information about original escape
>> sequenc
I hope so the messages are ok now. Few more regress tests added.
Thank you, committed.
--
Teodor Sigaev E-mail: teo...@sigaev.ru
WWW: http://www.sigaev.ru/
--
Sent via pgsql-hackers mailing list (pgsql-hacker
2016-03-14 17:39 GMT+01:00 Teodor Sigaev :
> I afraid so I cannot to fix this inconsistency (if this is inconsistency -
>> the
>> binary values are same) - the parameter of function is raw string with
>> processed
>> escape codes, and I have not any information about original escape
>> sequences.
I afraid so I cannot to fix this inconsistency (if this is inconsistency - the
binary values are same) - the parameter of function is raw string with processed
escape codes, and I have not any information about original escape sequences.
When you enter octet value, and I show it as hex value, then
2016-03-10 15:34 GMT+01:00 Teodor Sigaev :
> select
>>
>> parse_ident(E'X\rXX');
>>
>>
>> I am sending updated patch - I used json function for correct escaping -
>> the
>> escaping behave is same.
>>
>
> Hmm, it doesn't look so:
> % select p
select
parse_ident(E'X\rXX');
I am sending updated patch - I used json function for correct escaping - the
escaping behave is same.
Hmm, it doesn't look so:
% select parse_ident(E'_\005');
ERROR: identifier contains disallowed ch
Hi
2016-02-18 4:59 GMT+01:00 Pavel Stehule :
> select
>> parse_ident(E'X\rXX');
>
>
I am sending updated patch - I used json function for correct escaping -
the escaping behave is same.
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/s
Hi
2016-02-17 14:02 GMT+01:00 Teodor Sigaev :
> I missed some of my edits. Updated patch with those in place attached.
>>
>
> I'm sorry, but special chararacter still isn't escaped correctly in error
> messages:
>
> % select
> parse_ident(E'X\rX
I missed some of my edits. Updated patch with those in place attached.
I'm sorry, but special chararacter still isn't escaped correctly in error
messages:
% select parse_ident(E'X\rXX');
XX""X
T
2016-02-17 1:38 GMT+01:00 Jim Nasby :
> On 2/11/16 1:27 AM, Pavel Stehule wrote:
>
>> I editorialized the docs and some of the comments. In particular, I
>> documented behavior of not truncating, and recommended casting to
>> name[] if user cares about that. Added a unit test to verify
On 2/11/16 1:27 AM, Pavel Stehule wrote:
I editorialized the docs and some of the comments. In particular, I
documented behavior of not truncating, and recommended casting to
name[] if user cares about that. Added a unit test to verify that
works. BTW, I saw mention in the thread
Hi Jim
2016-02-11 8:27 GMT+01:00 Pavel Stehule
>
>
> ok
>
>>
>> Also added test for invalid characters.
>>
>> I think "strict" would be more in line with other uses in code. There are
>> currently no other occurrences of 'strictmode' in the code. There are loads
>> of references to 'strict', but
2016-02-10 19:26 GMT+01:00 Jim Nasby :
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation:not tested
>
> NEEDS CATVERSION
On 2/10/16 12:26 PM, Jim Nasby wrote:
I editorialized the docs and some of the comments. In particular, I documented
behavior of not truncating, and recommended casting to name[] if user cares
about that. Added a unit test to verify that works. BTW, I saw mention in the
thread about not trunca
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:not tested
NEEDS CATVERSION BUMP
I editorialized the docs and some of the comme
Hi
sorry, I am sending missing attachment
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
new file mode 100644
index f9eea76..bfba459
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
***
*** 1821,1826
--- 1821,1843
Hi
2016-02-08 16:55 GMT+01:00 Teodor Sigaev :
> rebased, messages changes per Tom's proposal
>>
> Cool feature and sometimes I needed it a lot.
>
> But, seems, there are some bugs in error processing.
>
> 1
> Following query is okay:
> # select * from parse_ident(E'"Some \r Schema".someTable');
>
Pavel Stehule wrote:
> I am looking on it
Thanks, closing as returned-with-feedback.
--
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To mak
2016-02-08 16:55 GMT+01:00 Teodor Sigaev :
> rebased, messages changes per Tom's proposal
>>
> Cool feature and sometimes I needed it a lot.
>
> But, seems, there are some bugs in error processing.
>
I am looking on it
Regards
Pavel
rebased, messages changes per Tom's proposal
Cool feature and sometimes I needed it a lot.
But, seems, there are some bugs in error processing.
1
Following query is okay:
# select * from parse_ident(E'"Some \r Schema".someTable');
parse_ident
--
{"Some \r S
Hi
2016-01-23 16:36 GMT+01:00 Tom Lane :
> Michael Paquier writes:
> > On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja wrote:
> > + errmsg("identifier contains disallowed chars"),
> > + errdetail("string \"%s\" is not valid identifier",
> > +
Michael Paquier writes:
> On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja wrote:
> + errmsg("identifier contains disallowed chars"),
> + errdetail("string \"%s\" is not valid identifier",
> + text_to_cstring(qualname)))
On Sat, Jan 23, 2016 at 1:25 AM, Marko Tiikkaja wrote:
> Hi Pavel,
>
> Sorry for the lack of review here. I didn't realize I was still the
> reviewer for this after it had been moved to another commitfest.
>
> That said, I think I've exhausted my usefulness here as a reviewer. Marking
> ready for
Hi Pavel,
Sorry for the lack of review here. I didn't realize I was still the
reviewer for this after it had been moved to another commitfest.
That said, I think I've exhausted my usefulness here as a reviewer.
Marking ready for committer.
.m
--
Sent via pgsql-hackers mailing list (pgsq
On Thu, Dec 3, 2015 at 5:31 AM, Pavel Stehule wrote:
> There is: SplitIdentifierString or textToQualifiedNameList in varlena.c. My
> first patch was based on these functions. But I cannot to use it.
>
> 1. major reason: The buildin parser is based on searching the dot "." and
> doesn't search any
On 9/15/15 11:49 PM, Pavel Stehule wrote:
1. processing user input with little bit more comfort - the user doesn't
need to separate schema and table
This is especially useful if you're doing anything that needs to
dynamically work with different objects. I'd say about 80% of the time
I'm doin
Hi
2015-11-17 1:49 GMT+01:00 Marko Tiikkaja :
> On 9/11/15 12:25 PM, Pavel Stehule wrote:
>
>> new update of parse_ident function patch
>>
>
> Nice! I've certainly wanted something like this a number of times.
>
> Some comments about the v2 of the patch:
>
>- The patch doesn't apply anymore,
On 9/11/15 12:25 PM, Pavel Stehule wrote:
new update of parse_ident function patch
Nice! I've certainly wanted something like this a number of times.
Some comments about the v2 of the patch:
- The patch doesn't apply anymore, so it should be rebased.
- The docs don't even try and expla
2015-09-16 2:41 GMT+02:00 Peter Eisentraut :
> On 9/11/15 6:25 AM, Pavel Stehule wrote:
> > new update of parse_ident function patch
>
> How would you actually use this?
>
> I know several people have spoken up that they could use this, but could
> you provide a few actual practical examples?
>
>
On 9/11/15 6:25 AM, Pavel Stehule wrote:
> new update of parse_ident function patch
How would you actually use this?
I know several people have spoken up that they could use this, but could
you provide a few actual practical examples?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@post
Hi
new update of parse_ident function patch
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
new file mode 100644
index 22d4f61..1581d5a
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
***
*** 1707,1712
--- 1707,1727
Hi
2015-09-09 21:55 GMT+02:00 Alvaro Herrera :
> Pavel Stehule wrote:
>
> > I cannot to use current SplitIdentifierString because it is designed for
> > different purpose - and it cannot to separate non identifier part. But
> the
> > code is simple - and will be cleaned.
> >
> > postgres=# selec
Pavel Stehule wrote:
> I cannot to use current SplitIdentifierString because it is designed for
> different purpose - and it cannot to separate non identifier part. But the
> code is simple - and will be cleaned.
>
> postgres=# select * from parse_ident('"AHOJ".NAZDAR[]'::text);
> ┌─
next iteration - fixed bug in parsing UTF8 chars, enhanced error messages.
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
new file mode 100644
index b3b78d2..75ea33a
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
***
*** 1707,1712
--- 1707,1
Hi
I sending the path with little bit enhanced parser - it doesn't support
utf8 alpha in identifiers yet
Regards
Pavel
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
new file mode 100644
index b3b78d2..75ea33a
*** a/doc/src/sgml/func.sgml
--- b/doc/src/sgml/func.sgml
**
2015-09-08 20:17 GMT+02:00 Corey Huinker :
>
>
> I would have immediate use for this. So often a function is written with a
> table name as a parameter and it's not immediately clear if the schema is
> to be parsed out of the string, prescribed, or a separate parameter...in
> which case the functio
On Tue, Sep 8, 2015 at 8:57 AM, Pavel Stehule
wrote:
>
>
> 2015-09-08 14:06 GMT+02:00 Robert Haas :
>
>> On Fri, Sep 4, 2015 at 12:24 AM, Pavel Stehule
>> wrote:
>> > The alghoritm for parsing identifiers is same - the differences are in a
>> > names of levels, and in ending symbols.
>> >
>> > I
2015-09-08 14:06 GMT+02:00 Robert Haas :
> On Fri, Sep 4, 2015 at 12:24 AM, Pavel Stehule
> wrote:
> > The alghoritm for parsing identifiers is same - the differences are in a
> > names of levels, and in ending symbols.
> >
> > I don't would to write totally generic parser - more without access t
On Fri, Sep 4, 2015 at 12:24 AM, Pavel Stehule wrote:
> The alghoritm for parsing identifiers is same - the differences are in a
> names of levels, and in ending symbols.
>
> I don't would to write totally generic parser - more without access to
> system catalog or without external hint, you canno
2015-09-03 13:11 GMT+02:00 Andres Freund :
> On 2015-08-23 17:46:36 +0200, Pavel Stehule wrote:
> > here is the patch
> >
> > It is really trivial - all heavy work was done done before.
>
> This seems to entirely disregard the comments in
> http://archives.postgresql.org/message-id/29030.144003015
On 2015-08-23 17:46:36 +0200, Pavel Stehule wrote:
> here is the patch
>
> It is really trivial - all heavy work was done done before.
This seems to entirely disregard the comments in
http://archives.postgresql.org/message-id/29030.1440030152%40sss.pgh.pa.us
about the fact that this approach only
Hi
2015-08-21 7:15 GMT+02:00 Pavel Stehule :
>
>
> 2015-08-20 21:16 GMT+02:00 Jim Nasby :
>
>> On 8/19/15 7:22 PM, Tom Lane wrote:
>>
>>> Jim Nasby writes:
>>>
Don't say "parse names for things other than tables". Only a minority
> of the types of objects used in the database have name
2015-08-20 21:16 GMT+02:00 Jim Nasby :
> On 8/19/15 7:22 PM, Tom Lane wrote:
>
>> Jim Nasby writes:
>>
>>> Don't say "parse names for things other than tables". Only a minority
of the types of objects used in the database have names that meet this
specification.
>>>
>> Really? My
On 8/19/15 7:22 PM, Tom Lane wrote:
Jim Nasby writes:
Don't say "parse names for things other than tables". Only a minority
of the types of objects used in the database have names that meet this
specification.
Really? My impression is that almost everything that's not a shared
object allows
2015-08-20 2:22 GMT+02:00 Tom Lane :
> Jim Nasby writes:
> >> Don't say "parse names for things other than tables". Only a minority
> >> of the types of objects used in the database have names that meet this
> >> specification.
>
> > Really? My impression is that almost everything that's not a s
Jim Nasby writes:
>> Don't say "parse names for things other than tables". Only a minority
>> of the types of objects used in the database have names that meet this
>> specification.
> Really? My impression is that almost everything that's not a shared
> object allows for a schema...
Tables me
On 8/19/15 2:44 PM, Pavel Stehule wrote:
Don't say "parse names for things other than tables". Only a minority
of the types of objects used in the database have names that meet this
specification.
Really? My impression is that almost everything that's not a shared
object allows fo
Hi
2015-08-19 21:33 GMT+02:00 Tom Lane :
> Pavel Stehule writes:
> > I miss a functionality that helps with parsing any identifier to basic
> > three parts - database, schema, objectname. We have this function
> > internally, but it is not available for SQL layer.
>
> > FUNCTION parse_ident(IN i
Pavel Stehule writes:
> I miss a functionality that helps with parsing any identifier to basic
> three parts - database, schema, objectname. We have this function
> internally, but it is not available for SQL layer.
> FUNCTION parse_ident(IN ident text, OUT dbname text, OUT schemaname text,
> OUT
Hi
I miss a functionality that helps with parsing any identifier to basic
three parts - database, schema, objectname. We have this function
internally, but it is not available for SQL layer.
FUNCTION parse_ident(IN ident text, OUT dbname text, OUT schemaname text,
OUT objectname text)
Examples:
51 matches
Mail list logo