Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread KaiGai Kohei
The attached patch is revised one based on the V3 approach. The only difference from V3 is that it also applies checks on the AT_AlterColumnType option, not only renameatt(). The performance was almost same as the V3 case. * CVS HEAD 0.828s 0.828s 0.833s 0.829s 0.838s -

Re: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-01-27 Thread Leonardo F
Consider multi-column indexes, ie: CREATE INDEX i_foo ON foo (length(a), length(b)); Ok, I've never thought of expression indexes that way (in the (expr1,expr2,exprN) form): that is a good example. Maybe you're confusing expression indexes with partial indexes? No no, that was exactly

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Magnus Hagander
2010/1/27 Josh Berkus j...@agliodbs.com: On 1/26/10 3:24 PM, David Christensen wrote: -hackers, In the spirit of small, but hopefully useful interface improvement patches, enclosed for your review is a patch for providing psql with a \whoami command (maybe a better name is \conninfo or

Re: [HACKERS] testing cvs HEAD - HS/SR - missing file

2010-01-27 Thread Heikki Linnakangas
Fujii Masao wrote: *** a/src/backend/replication/walsender.c --- b/src/backend/replication/walsender.c *** *** 661,666 XLogSend(StringInfo outMsg) --- 661,673 sentPtr = endptr; + if (sentPtr.xrecoff = XLogFileSize) + { +

Re: [HACKERS] testing cvs HEAD - HS/SR - missing file

2010-01-27 Thread Fujii Masao
On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Before that, endptr is advanced using XLByteAdvance() macro, which does handle xlogid boundaries. Is XLByteAdvance() broken? No. The cause of the bug is that endptr might be set to the SendRqstPtr

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Martin Atukunda
How about using the psql prompt to convey this information? IIRC the psql prompt can be configured to show the hostname, server, port and other fields. Wouldn't this be enough? or am I missing something? - Martin - On 27 Jan 2010, at 13:01, Magnus Hagander wrote: 2010/1/27 Josh Berkus

Re: [HACKERS] testing cvs HEAD - HS/SR - missing file

2010-01-27 Thread Heikki Linnakangas
Fujii Masao wrote: On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Before that, endptr is advanced using XLByteAdvance() macro, which does handle xlogid boundaries. Is XLByteAdvance() broken? No. The cause of the bug is that endptr might be set

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Magnus Hagander
I think the idea is that if you do that, it'll be there all the time, potentially crowding the space. //Magnus 2010/1/27 Martin Atukunda matl...@gmail.com: How about using the psql prompt to convey this information? IIRC the psql prompt can be configured to show the hostname, server, port and

Re: [HACKERS] testing cvs HEAD - HS/SR - missing file

2010-01-27 Thread Fujii Masao
On Wed, Jan 27, 2010 at 8:37 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: But SendRqstPtr comes from LogwrtResult.Write, surely that's correct, no? Right. But the point is that LogwrtResult.Write might indicate 0/FF00 because it's the last byte + 1 written out.

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Thom Brown
2010/1/27 Josh Berkus j...@agliodbs.com however, \conninfo is probably the better name. +1 Something along the lines of: Connected to localhost port 5432 as user thomb? Thom

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Mon, 25 Jan 2010 16:36:46 -0600 Kevin Grittner kevin.gritt...@wicourts.gov wrote: Ivan Sergio Borgonovo m...@webthatworks.it wrote: The README files might be a good place to start, then browse code. Is there a book? The more I read the source and the few info about it, the more I have

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Thom Brown
2010/1/27 Thom Brown thombr...@gmail.com 2010/1/27 Josh Berkus j...@agliodbs.com however, \conninfo is probably the better name. +1 Something along the lines of: Connected to localhost port 5432 as user thomb? Thom Er... ignore that. Just saw the other examples which are better ;)

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Craig Ringer
On 27/01/2010 9:14 PM, Ivan Sergio Borgonovo wrote: On Mon, 25 Jan 2010 16:36:46 -0600 Kevin Grittnerkevin.gritt...@wicourts.gov wrote: Ivan Sergio Borgonovom...@webthatworks.it wrote: The README files might be a good place to start, then browse code. Is there a book? The more I read the

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Martijn van Oosterhout
On Wed, Jan 27, 2010 at 02:14:36PM +0100, Ivan Sergio Borgonovo wrote: I haven't been able to understand the difference between function returning cstring and text and if there is any need to be careful about encoding and escaping when copying from the lexeme to a buffer that will return a

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread David Christensen
On Jan 27, 2010, at 4:01 AM, Magnus Hagander wrote: 2010/1/27 Josh Berkus j...@agliodbs.com: On 1/26/10 3:24 PM, David Christensen wrote: -hackers, In the spirit of small, but hopefully useful interface improvement patches, enclosed for your review is a patch for providing psql with a

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Pavel Stehule
Is there any difference from function returning text and function returning cstring? text is varlena type - it could be TOASTed, comprimated. It is better integrated to PostgreSQL world. cstring is just C zero terminated string - so good for system call, call some external libraries. Regards

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread David Christensen
On Jan 27, 2010, at 5:23 AM, Martin Atukunda wrote: How about using the psql prompt to convey this information? IIRC the psql prompt can be configured to show the hostname, server, port and other fields. Wouldn't this be enough? or am I missing something? Prompt customization is certainly

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Magnus Hagander
2010/1/27 David Christensen da...@endpoint.com: On Jan 27, 2010, at 4:01 AM, Magnus Hagander wrote: 2010/1/27 Josh Berkus j...@agliodbs.com: On 1/26/10 3:24 PM, David Christensen wrote: -hackers, In the spirit of small, but hopefully useful interface improvement patches, enclosed for

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread David Christensen
On Jan 27, 2010, at 8:08 AM, Magnus Hagander wrote: 2010/1/27 David Christensen da...@endpoint.com: On Jan 27, 2010, at 4:01 AM, Magnus Hagander wrote: 2010/1/27 Josh Berkus j...@agliodbs.com: On 1/26/10 3:24 PM, David Christensen wrote: -hackers, In the spirit of small, but hopefully

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tim Bunce wrote: - Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP) SPI functions are not available when the code is run. - Added normal interpreter destruction behaviour END blocks, if any, are run then objects are

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread Robert Haas
2010/1/27 KaiGai Kohei kai...@ak.jp.nec.com: The attached patch is revised one based on the V3 approach. The only difference from V3 is that it also applies checks on the AT_AlterColumnType option, not only renameatt(). I think I was clear about what the next step was for this patch in my

Re: [HACKERS] Improving the accuracy of estimate_num_groups()

2010-01-27 Thread Hitoshi Harada
2010/1/23 Tom Lane t...@sss.pgh.pa.us: I was just poking at the test case provided by Allen Johnson in bug #5294.  The essence of the complaint is that the planner is choosing a sort-and-GroupAggregate plan when a HashAggregate-and-then-sort plan would be faster, because the aggregation steps

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tim Bunce
On Wed, Jan 27, 2010 at 01:14:16AM -0500, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tim Bunce wrote: - Added plperl.on_perl_init GUC for DBA use (PGC_SIGHUP) SPI functions are not available when the code is run. - Added normal interpreter destruction behaviour END

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 14:44:02 +0100 Martijn van Oosterhout klep...@svana.org wrote: On Wed, Jan 27, 2010 at 02:14:36PM +0100, Ivan Sergio Borgonovo wrote: I haven't been able to understand the difference between function returning cstring and text and if there is any need to be careful

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 21:41:02 +0800 Craig Ringer cr...@postnewspapers.com.au wrote: I don't code on PostgreSQL's guts, so I'm perhaps not in the best position to speak, but: - Documentation has a cost too, particularly a maintenance cost. Outdated docs become misleading or downright false

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Alvaro Herrera
Ivan Sergio Borgonovo wrote: What's not included in on SQL level almost everything is text? input and output functions always use cstring rather than text. The I/O functions are normally not used directly at the SQL level. There are a lot of functions in contrib taking cstring input and

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread Peter Eisentraut
On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote: On Tue, Jan 26, 2010 at 02:21:29PM +, Bruce Momjian wrote: Log Message: --- Remove tabs in SGML. Can we see about making a commit hook for CVS that disallows \t in SGML files? The process in git is pretty simple.

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Andrew Dunstan
Ivan Sergio Borgonovo wrote: I just learned there is a return all row mode for returning set functions: There are currently two modes in which a function can return a set result: value-per-call, or materialize. In value-per-call mode, the function returns one value each time it is called,

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 11:49:46 -0300 Alvaro Herrera alvhe...@commandprompt.com wrote: There are a lot of functions in contrib taking cstring input and returning cstring output. Are they just in the same special class of [type]in, [type]out [type]recv... functions? Probably, but I didn't

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Kevin Grittner
Ivan Sergio Borgonovo m...@webthatworks.it wrote: There are a lot of functions in contrib taking cstring input and returning cstring output. Are they just in the same special class of [type]in, [type]out [type]recv... functions? If you're looking in contrib subdirectories, perhaps the

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 10:10:01 -0500 Andrew Dunstan and...@dunslane.net wrote: There are quite a few SRF functions in the code. Look for example in contrib/hstore/hstore_op.c for some fairly simple examples. SRFs are quite capable of returning huge resultsets, not just small ones. Example code

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Andrew Dunstan
Ivan Sergio Borgonovo wrote: On Wed, 27 Jan 2010 10:10:01 -0500 Andrew Dunstan and...@dunslane.net wrote: There are quite a few SRF functions in the code. Look for example in contrib/hstore/hstore_op.c for some fairly simple examples. SRFs are quite capable of returning huge resultsets,

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Heikki Linnakangas
Ivan Sergio Borgonovo wrote: I'm more interested in understanding when I should use materialized mode. eg. I should be more concerned about memory or cpu cycles and what should be taken as a reference to consider memory needs large? If for example I was going to split a large TEXT into a set

[HACKERS] make everything target

2010-01-27 Thread Andrew Dunstan
I'd like to have an everything target that would build all + html + contrib. And maybe an installcheck-everything target that would run installcheck for src, pl and contrib. Thoughts? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Review: Typed Table

2010-01-27 Thread Hitoshi Harada
2010/1/26 Peter Eisentraut pete...@gmx.net: On tis, 2010-01-19 at 01:01 +0900, Hitoshi Harada wrote: I reviewed this patch today. Thank you for this very thorough and helpful review.  Comments below and a new patch attached. OK, I confirmed all the issues relevant to the patch were fixed.

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Tom Lane
David Christensen da...@endpoint.com writes: That's a good point about forward-compatibility. In that case, I'm not sure if default is the best name for the human-readable format, but I didn't like human-readable ;-). I assume that should have an explicit spelling, and not just be the

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Alvaro Herrera
Ivan Sergio Borgonovo wrote: On Wed, 27 Jan 2010 11:49:46 -0300 Alvaro Herrera alvhe...@commandprompt.com wrote: There are a lot of functions in contrib taking cstring input and returning cstring output. Are they just in the same special class of [type]in, [type]out [type]recv...

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread KaiGai Kohei
(2010/01/27 23:29), Robert Haas wrote: 2010/1/27 KaiGai Koheikai...@ak.jp.nec.com: The attached patch is revised one based on the V3 approach. The only difference from V3 is that it also applies checks on the AT_AlterColumnType option, not only renameatt(). I think I was clear about what the

Re: [HACKERS] Review: listagg aggregate

2010-01-27 Thread Pavel Stehule
with actualised oids Regards Pavel Stehule 2010/1/26 David E. Wheeler da...@kineticode.com: On Jan 25, 2010, at 6:56 AM, Pavel Stehule wrote: actualised patch - the name is string_agg All looks fine except I'm getting this error during initdb: creating template1 database in

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: On Wed, Jan 27, 2010 at 12:46:42AM -0700, Alex Hunsaker wrote: FWIW the atexit scares me to. In what way, specifically? It runs too late, and too unpredictably, during the shutdown sequence. (In particular note that shutdown itself might be fired as an

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Andrew Dunstan
Tom Lane wrote: Indeed, AFAICS the major *point* of these additions is to allow people to insert unknown other functionality that is likely to interact with the rest of the backend; a prospect that doesn't make me feel better about it. No. The major use case we've seen for END blocks is

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Indeed, AFAICS the major *point* of these additions is to allow people to insert unknown other functionality that is likely to interact with the rest of the backend; a prospect that doesn't make me feel better about it. No. The

Re: [HACKERS] testing cvs HEAD - HS/SR - missing file

2010-01-27 Thread Heikki Linnakangas
Fujii Masao wrote: On Wed, Jan 27, 2010 at 8:37 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: But SendRqstPtr comes from LogwrtResult.Write, surely that's correct, no? Right. But the point is that LogwrtResult.Write might indicate 0/FF00 because it's the last byte +

Re: [HACKERS] Patch: psql \whoami option

2010-01-27 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: 2010/1/27 Martin Atukunda matl...@gmail.com: How about using the psql prompt to convey this information? I think the idea is that if you do that, it'll be there all the time, potentially crowding the space. I had the same reaction as Martin. If

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tim Bunce
On Wed, Jan 27, 2010 at 11:13:43AM -0500, Tom Lane wrote: Tim Bunce tim.bu...@pobox.com writes: On Wed, Jan 27, 2010 at 12:46:42AM -0700, Alex Hunsaker wrote: FWIW the atexit scares me to. In what way, specifically? It runs too late, and too unpredictably, during the shutdown sequence.

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Greg Smith
Ivan Sergio Borgonovo wrote: Is there a book? You'll find a basic intro to this area in PostgreSQL Developer's Handbook by Geschwinde and Schonig. You're already past the level of questions they answer in there though. This whole cstring/text issue you're asking about, I figured out by

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Andrew Dunstan
Tom Lane wrote: But in any case, I don't believe for a moment that profiling is the only or even the largest use to which people would try to put this. Well, ISTR there have been requests over the years for event handlers for (among other things) session

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I see I asked the wrong question. Start again. What more should be done to make all or some of it acceptable? I think a must is to get rid of the use of atexit(). Possibly an on_proc_exit callback could be used instead, although I'm not sure how you'd

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
f...@redhat.com (Frank Ch. Eigler) writes: Tom Lane t...@sss.pgh.pa.us writes: Lastly, an atexit trigger will still fire during FATAL or PANIC aborts, which scares me even more. When the house is already afire, it's not prudent to politely let user-written perl code do whatever it wants

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread David Fetter
On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote: On Tue, Jan 26, 2010 at 02:21:29PM +, Bruce Momjian wrote: Log Message: --- Remove tabs in SGML. Can we see about making a commit hook for CVS that

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: On Wed, Jan 27, 2010 at 11:13:43AM -0500, Tom Lane wrote: (In particular note that shutdown itself might be fired as an atexit callback, a move forced on us by exactly the sort of random user code that you want to add more of. It's not clear whether a

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Frank Ch. Eigler
Tom Lane t...@sss.pgh.pa.us writes: [...] Lastly, an atexit trigger will still fire during FATAL or PANIC aborts, which scares me even more. When the house is already afire, it's not prudent to politely let user-written perl code do whatever it wants before you get the heck out of there.

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread Tom Lane
David Fetter da...@fetter.org writes: On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: Better write a check in the makefile. That assumes that everyone will always actually run the appropriate make before committing, which I wouldn't assume, especially for a trivial patch

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread David Fetter
On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote: David Fetter da...@fetter.org writes: On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: Better write a check in the makefile. That assumes that everyone will always actually run the appropriate make before

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread Joshua D. Drake
On Wed, 2010-01-27 at 12:27 -0500, Tom Lane wrote: David Fetter da...@fetter.org writes: On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: Better write a check in the makefile. That assumes that everyone will always actually run the appropriate make before committing,

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread Tom Lane
David Fetter da...@fetter.org writes: On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote: The rule against tabs in SGML files is only a bit of anal retentivity anyway. I don't think that enforcing it is worth special hacks that we do not use anywhere else. Good point. What other

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread David Fetter
On Wed, Jan 27, 2010 at 12:41:28PM -0500, Tom Lane wrote: David Fetter da...@fetter.org writes: On Wed, Jan 27, 2010 at 12:27:08PM -0500, Tom Lane wrote: The rule against tabs in SGML files is only a bit of anal retentivity anyway. I don't think that enforcing it is worth special hacks

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 17:37:23 +0200 Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Currently, there's no difference in terms of memory needs. The backend always materializes the result of a SRF into a tuplestore anyway, if the function didn't do it itself. There has been

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 9:08 AM, Tom Lane wrote: This is exactly the claim that I have zero confidence in. Quite frankly, the problem with Perl as an extension language is that Perl was never designed to be a subsystem: it feels free to mess around with the entire state of the process. We've

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Jan 27, 2010, at 9:08 AM, Tom Lane wrote: This is exactly the claim that I have zero confidence in. Quite frankly, the problem with Perl as an extension language is that Perl was never designed to be a subsystem: it feels free to mess around

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 10:08 AM, Tom Lane wrote: Two examples that I can find in a quick review of our CVS history: perl stomping on the process's setlocale state, and perl stomping on the stdio state (Windows only). Are there links to those commits? Thanks, David -- Sent via pgsql-hackers

Re: [HACKERS] make everything target

2010-01-27 Thread Peter Eisentraut
On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote: I'd like to have an everything target that would build all + html + contrib. +10 And maybe an installcheck-everything target that would run installcheck for src, pl and contrib. +100 -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Review: Typed Table

2010-01-27 Thread Peter Eisentraut
Everyone, We could use some help. Anyone's got an idea what could be causing the behavior described below? On mån, 2010-01-25 at 21:45 +0200, Peter Eisentraut wrote: On tis, 2010-01-19 at 01:01 +0900, Hitoshi Harada wrote: * Conflict between transactions I'm not sure if this is related

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-27 Thread Alvaro Herrera
Greg Smith wrote: We've got pgsql-cluster-hackers to discuss this particular area. Huh, is this a new list? It wasn't added to wwwmaster's list of lists, apparently, right? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-27 Thread Greg Smith
Alvaro Herrera wrote: Greg Smith wrote: We've got pgsql-cluster-hackers to discuss this particular area. Huh, is this a new list? It wasn't added to wwwmaster's list of lists, apparently, right? The archives are at http://archives.postgresql.org/pgsql-cluster-hackers/ but it's

[HACKERS] Google Summer of Code 2010 is on! (applications due March 9)

2010-01-27 Thread Selena Deckelmann
Hi! I'm happy to facilitate this and get the details in for our application. Seems like we have lots of things that we could get students involved with, and of course, we tend to get interesting projects pitched to us that we haven't thought of before. I've attended the Mentor Summit after GSoC

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-27 Thread Alvaro Herrera
Greg Smith wrote: Alvaro Herrera wrote: Greg Smith wrote: We've got pgsql-cluster-hackers to discuss this particular area. Huh, is this a new list? It wasn't added to wwwmaster's list of lists, apparently, right? The archives are at

Re: [HACKERS] Review: Typed Table

2010-01-27 Thread Alvaro Herrera
Peter Eisentraut escribió: Everyone, We could use some help. Anyone's got an idea what could be causing the behavior described below? I wonder if the problem is that you're missing a recheck on the type's existence after you've grabbed the lock on it, similar to what shdepLockAndCheckObject

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Joe Conway
On 01/27/2010 09:49 AM, Ivan Sergio Borgonovo wrote: On Wed, 27 Jan 2010 17:37:23 +0200 Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Currently, there's no difference in terms of memory needs. The backend always materializes the result of a SRF into a tuplestore anyway, if

Re: [HACKERS] quoting psql varible as identifier

2010-01-27 Thread Robert Haas
On Mon, Jan 25, 2010 at 7:36 AM, Pavel Stehule pavel.steh...@gmail.com wrote: I hope, so this version is more readable and more clean. I removed some not necessary checks. This still seems overly complicated to me. I spent a few hours today working up the attached patch. Let me know your

Re: [HACKERS] Patch: Remove gcc dependency in definition of inline functions

2010-01-27 Thread Robert Haas
On Tue, Jan 19, 2010 at 4:55 PM, Kurt Harriman harri...@acm.org wrote: I'll submit an updated patch. We need this patch pretty soon if we're going to include this in 9.0, I think. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Heikki Linnakangas
Ivan Sergio Borgonovo wrote: But then... why do we have all that logic to save the function context if anyway it is more convenient to process everything in one run? It's a pain to save the context just to save a pointer inside a structure, it would be more convenient to just process all the

Re: [HACKERS] xpath improvement suggestion

2010-01-27 Thread Robert Haas
On Sun, Jan 17, 2010 at 11:33 AM, Jan Urbański wulc...@wulczer.org wrote: [ detailed review ] Arie, Are you planning to submit an updated patch? If so, please do so soon. Thanks, ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread Robert Haas
On Wed, Jan 27, 2010 at 10:17 AM, KaiGai Kohei kai...@kaigai.gr.jp wrote: (2010/01/27 23:29), Robert Haas wrote: 2010/1/27 KaiGai Koheikai...@ak.jp.nec.com: The attached patch is revised one based on the V3 approach. The only difference from V3 is that it also applies checks on the

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread Bernd Helmle
--On 27. Januar 2010 15:42:45 -0500 Robert Haas robertmh...@gmail.com wrote: Bernd (or anyone), feel free to take a look in parallel. More eyes would be helpful... I've planned to look at this tomorrow when i'm back in office. -- Thanks Bernd -- Sent via pgsql-hackers mailing

[HACKERS] CommitFest status summary 2010-01-27

2010-01-27 Thread Robert Haas
We have 20 remaining patches to deal with for the 2010-01 CommitFest. I've attempted to break down the status of these patches below. The good news is that almost half of the remaining patches are either already marked as Ready for Committer, or have already been reviewed once and will likely be

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread James William Pye
On Jan 27, 2010, at 1:00 PM, Joe Conway wrote: Implementing true value_per_call is still something on my TODO list, but obviously has not risen to a very high priority for me as it has now been an embarrassing long time since it was put there. But that said, materialize mode has proven

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Ivan Sergio Borgonovo
On Wed, 27 Jan 2010 22:06:43 +0200 Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Ivan Sergio Borgonovo wrote: But then... why do we have all that logic to save the function context if anyway it is more convenient to process everything in one run? It's a pain to save the

Re: [HACKERS] [COMMITTERS] pgsql: Remove tabs in SGML.

2010-01-27 Thread Peter Eisentraut
On ons, 2010-01-27 at 09:04 -0800, David Fetter wrote: On Wed, Jan 27, 2010 at 04:52:00PM +0200, Peter Eisentraut wrote: On tis, 2010-01-26 at 10:20 -0800, David Fetter wrote: On Tue, Jan 26, 2010 at 02:21:29PM +, Bruce Momjian wrote: Log Message: --- Remove tabs in

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tim Bunce
On Wed, Jan 27, 2010 at 12:08:48PM -0500, Tom Lane wrote: Tim Bunce tim.bu...@pobox.com writes: On Wed, Jan 27, 2010 at 11:13:43AM -0500, Tom Lane wrote: (In particular note that shutdown itself might be fired as an atexit callback, a move forced on us by exactly the sort of random user

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tim Bunce
On Wed, Jan 27, 2010 at 11:28:02AM -0500, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: Indeed, AFAICS the major *point* of these additions is to allow people to insert unknown other functionality that is likely to interact with the rest of the backend; a

Re: [HACKERS] Clustering Docs WAS: Mammoth in Core?

2010-01-27 Thread Greg Smith
Alvaro Herrera wrote: Greg Smith wrote: Alvaro Herrera wrote: Greg Smith wrote: We've got pgsql-cluster-hackers to discuss this particular area. Huh, is this a new list? It wasn't added to wwwmaster's list of lists, apparently, right? The archives are at

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 1:27 PM, Tim Bunce wrote: Okay. I could change the callback code to ignore calls if proc_exit_inprogress is false. So an abnormal shutdown via exit() wouldn't involve plperl at all. (Alternatively I could use use on_proc_exit() instead of atexit() to register the

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Robert Haas
On Wed, Jan 27, 2010 at 4:51 PM, David E. Wheeler da...@kineticode.com wrote: Neither of those relate to the actions of perl source code. To address that, instead of calling perl_destruct() to perform a complete destruction I could just execute END blocks and object destructors. That would

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 1:53 PM, Robert Haas wrote: What exactly do we mean by system-level actions? I mean, END blocks can execute arbitrary code Yeah. In Perl. What part of Perl can access the backend systems without SPI? And that it couldn't do at any other point in runtime? Best, David

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-27 Thread Robert Haas
On Wed, Jan 27, 2010 at 3:42 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jan 27, 2010 at 10:17 AM, KaiGai Kohei kai...@kaigai.gr.jp wrote: (2010/01/27 23:29), Robert Haas wrote: 2010/1/27 KaiGai Koheikai...@ak.jp.nec.com: The attached patch is revised one based on the V3 approach.

Re: [HACKERS] Review: listagg aggregate

2010-01-27 Thread Robert Haas
On Tue, Jan 26, 2010 at 1:38 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Jan 26, 2010 at 12:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: But what it *produces* is a string.  For comparison, the SQL-standard-specified array_agg produces arrays, but what

Re: [HACKERS] make everything target

2010-01-27 Thread David Fetter
On Wed, Jan 27, 2010 at 10:41:16AM -0500, Andrew Dunstan wrote: I'd like to have an everything target that would build all + html + contrib. And maybe an installcheck-everything target that would run installcheck for src, pl and contrib. Thoughts? +1 on both :) Cheers, David. --

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tim Bunce
On Wed, Jan 27, 2010 at 01:51:47PM -0800, David E. Wheeler wrote: On Jan 27, 2010, at 1:27 PM, Tim Bunce wrote: Okay. I could change the callback code to ignore calls if proc_exit_inprogress is false. So an abnormal shutdown via exit() wouldn't involve plperl at all. (Alternatively I

Re: [HACKERS] CommitFest status summary 2010-01-27

2010-01-27 Thread Andrew Dunstan
Robert Haas wrote: Some of the perl patches have not yet been reviewed either, but I'm a little less concerned about those because it seems that Andrew is working on those anyway: still, if anyone feels inclined to volunteer, I believe Andrew has said he would appreciate another pair of eyes.

Re: [HACKERS] make everything target

2010-01-27 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote: I'd like to have an everything target that would build all + html + contrib. +10 And maybe an installcheck-everything target that would run installcheck for src, pl and contrib. +100

Re: [HACKERS] C function accepting/returning cstring vs. text

2010-01-27 Thread Tom Lane
Heikki Linnakangas heikki.linnakan...@enterprisedb.com writes: When the set-returning-function feature was written originally, years ago, the tuple at a time mode did really work tuple at a time. But it had issues and was axed out of the patch before it was committed, to keep it simple. The

Re: [HACKERS] make everything target

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 2:38 PM, Tom Lane wrote: These proposals sound reasonable to me too, but is everything an appropriate target name, or is there some other/better convention? Oooh, more bike-shedding. make theworld make toutlemonde make myday make lovenotwar Best, David

Re: [HACKERS] make everything target

2010-01-27 Thread Andrew Dunstan
Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: On ons, 2010-01-27 at 10:41 -0500, Andrew Dunstan wrote: I'd like to have an everything target that would build all + html + contrib. +10 And maybe an installcheck-everything target that would run

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Jan 27, 2010, at 1:53 PM, Robert Haas wrote: What exactly do we mean by system-level actions? I mean, END blocks can execute arbitrary code Yeah. In Perl. What part of Perl can access the backend systems without SPI? And that it couldn't

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: Okay. I could change the callback code to ignore calls if proc_exit_inprogress is false. So an abnormal shutdown via exit() wouldn't involve plperl at all. (Alternatively I could use use on_proc_exit() instead of atexit() to register the callback.) Use

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 3:11 PM, Tom Lane wrote: You still aren't letting go of the notion that Perl could only affect the rest of the backend via SPI. The point I'm trying to impress on you is that there are any number of other possible pathways, and that Perl's historical assumption that it

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: On Wed, Jan 27, 2010 at 11:28:02AM -0500, Tom Lane wrote: Really? We've found that gprof, for instance, doesn't exactly have zero interaction with the rest of the backend --- there's actually a couple of different bits in there to help it along, including

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread David E. Wheeler
On Jan 27, 2010, at 3:33 PM, Tom Lane wrote: I don't have to read any further than the place where it says doesn't work if you call both plperl and plperlu to realize that that's quite false. Maybe we have different definitions of what a software interaction is... I think that dates from

Re: [HACKERS] Add on_perl_init and proper destruction to plperl [PATCH]

2010-01-27 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Jan 27, 2010, at 3:33 PM, Tom Lane wrote: I don't have to read any further than the place where it says doesn't work if you call both plperl and plperlu to realize that that's quite false. Maybe we have different definitions of what a software

  1   2   >