Re: [HACKERS] JSONB - JSONB operator feature request

> On 20 July 2017 at 16:24, David Fetter wrote: > > If we can agree to a definition, we can make this go. My vague > memories from graph theory indicate that that "agree to a definition" > part is the real problem to be solved. I tried to embody some relevant thoughts in this

Re: [HACKERS] JSONB - JSONB operator feature request

On Wed, Jul 19, 2017 at 06:17:35PM -0500, Merlin Moncure wrote: > On Tue, Jul 18, 2017 at 12:49 PM, David Fetter wrote: > > On Tue, Jul 18, 2017 at 01:36:32PM +0200, david.tu...@linuxbox.cz wrote: > >> Hi, > >> > >> some users and me used hstore - hstore for example storing only

Re: [HACKERS] JSONB - JSONB operator feature request

On Tue, Jul 18, 2017 at 12:49 PM, David Fetter wrote: > On Tue, Jul 18, 2017 at 01:36:32PM +0200, david.tu...@linuxbox.cz wrote: >> Hi, >> >> some users and me used hstore - hstore for example storing only changed >> rows in trigger like: >> >> hsore(NEW) - hstore(OLD) >> >>

Re: [HACKERS] JSONB - JSONB operator feature request

+420 591 166 224 fax:+420 596 621 273 mobil: +420 732 589 152 www.linuxbox.cz mobil servis: +420 737 238 656 email servis: ser...@linuxbox.cz - Od: David Fetter <da...@fetter.org> Komu: david.tu...@linuxbox.cz Kopie: pgsql-hackers@postgresql.org Datum: 18. 07. 2017

Re: [HACKERS] JSONB - JSONB operator feature request

On Tue, Jul 18, 2017 at 01:36:32PM +0200, david.tu...@linuxbox.cz wrote: > Hi, > > some users and me used hstore - hstore for example storing only changed > rows in trigger like: > > hsore(NEW) - hstore(OLD) > > There isn't same operator/function in JSON/JSONB. We can only remove keys > from

Re: [HACKERS] JSONB - JSONB operator feature request

On Tue, Jul 18, 2017 at 01:36:32PM +0200, david.tu...@linuxbox.cz wrote: > Hi, > > some users and me used hstore - hstore for example storing only changed > rows in trigger like: > > hstore(NEW) - hstore(OLD) > > There isn't same operator/function in JSON/JSONB. We can only remove keys > from

[HACKERS] JSONB - JSONB operator feature request

Hi, some users and me used hstore - hstore for example storing only changed rows in trigger like: hsore(NEW) - hstore(OLD) There isn't same operator/function in JSON/JSONB. We can only remove keys from JSONB, but not equal key-value pairs. Is there any chance to have same feature with

[HACKERS] End of CommitFest + Feature Freeze Delayed To April 7th

Hi, We had a brief stand-up meeting today at PGCONF.US to discuss the proposal to delay the end of the CommitFest and feature freeze. Those present include 9 members of the pgsql-release team (including Peter Eisentraut and myself as members of the RMT) and David Steele as the current CommitFest

[HACKERS] new high availability feature for the system with both asynchronous and synchronous replication

Hi all, I propose a new feature for high availability. This configuration is effective for following configuration: 1. Primary and synchronous standby are in the same center; called main center. 2. Asynchronous standby is in the another center; called backup center. (The backup center is

Re: [HACKERS] new tests post-feature freeze (was pgsql: Add TAP tests for pg_dump)

On Sun, May 22, 2016 at 11:22 PM, Noah Misch wrote: > Some or even most of the other tests would qualify under "closely related to > ... a feature that is new in 9.6". Your 9.6 pg_dump changes affected object > selection and catalog extraction for most object types, so I think

Re: [HACKERS] new tests post-feature freeze (was pgsql: Add TAP tests for pg_dump)

Robert Haas writes: > My suggestion is that, from this point forward, we add new tests to > 9.6 only if they are closely related to a bug that is getting fixed or > a feature that is new in 9.6. I think that's a reasonable compromise, > but what do others think? Yeah,

Re: [HACKERS] new tests post-feature freeze (was pgsql: Add TAP tests for pg_dump)

On Sat, May 7, 2016 at 5:44 PM, Stephen Frost wrote: > * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: >> On 5/7/16 9:36 AM, Stephen Frost wrote: >> >Honestly, over the next couple of months between feature-freeze and >> >release, I'd like to add even more tests,

Re: [HACKERS] commitfest app bug/feature

On Thu, May 7, 2015 at 9:17 PM, Fabien COELHO coe...@cri.ensmp.fr wrote: Hello, Some comments/bug report about the commitfest web app which just bite me:-) When creating a patch with the commitfest app, if the thread does not exist the application seems to reject the creation, so you may

Re: [HACKERS] commitfest app bug/feature

ISTM that an additional Duplicate or To remove status could be a tag for admins to remove the entries? This looks like an overkill to me. Entries with the same description headline mean the same thing. Sure. My point was to provide a mean to signal explicitely that an entry can be

[HACKERS] commitfest app bug/feature

Hello, Some comments/bug report about the commitfest web app which just bite me:-) When creating a patch with the commitfest app, if the thread does not exist the application seems to reject the creation, so you may resubmit because you know the thread is going to exist soon... Well, this

Re: [HACKERS] commitfest app bug/feature

Hello Michael, It is possible to remove patches from the set, but administrator rights are necessary. Good. Maybe this right could be granted to the person who as created the patch entry in the CF? If there are duplicated entries that you would like to get removed, simply mention them

Re: [HACKERS] commitfest app bug/feature

On Fri, May 8, 2015 at 4:17 AM, Fabien COELHO wrote: Then there is no way to remove a patch from the application. You end up marking them as Rejected, which does not make much sense, see the bottom of the 2015-06 commitfest list... Maybe a Duplicate status would be better, and the ability to

Re: [HACKERS] commitfest app bug/feature

On Fri, May 8, 2015 at 10:35 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: Hello Michael, It is possible to remove patches from the set, but administrator rights are necessary. Good. Maybe this right could be granted to the person who as created the patch entry in the CF? Er, well...

Re: [HACKERS] commitfest app bug/feature

On Fri, May 8, 2015 at 11:54 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: I'm fine to do this cleanup btw. ISTM that an additional Duplicate or To remove status could be a tag for admins to remove the entries? This looks like an overkill to me. Entries with the same description headline

Re: [HACKERS] commitfest app bug/feature

I'm fine to do this cleanup btw. ISTM that an additional Duplicate or To remove status could be a tag for admins to remove the entries? Feel free to remove the stupid Rejected entries at the end of the 2015-06 CF: there are currently 11 pgbench allow '=' in \set (mine) and 2 configure

Re: [HACKERS] [PATCH] Add transforms feature

On Tue, Apr 28, 2015 at 12:47 PM, Jeff Janes jeff.ja...@gmail.com wrote: This commit is causing a compiler warning for me in non-cassert builds: funcapi.c: In function 'get_func_trftypes': funcapi.c:890: warning: unused variable 'procStruct' Adding PG_USED_FOR_ASSERTS_ONLY seems to fix it.

Re: [HACKERS] [PATCH] Add transforms feature

On Tue, Apr 7, 2015 at 7:55 PM, Peter Eisentraut pete...@gmx.net wrote: On 3/22/15 5:46 AM, Pavel Stehule wrote: Isn't better doesn't support TRANSFORM ALL clause? If somebody would to use transformations - then he have to explicitly enable it by TRANSFORM FOR TYPE ? It is safe and without

Re: [HACKERS] [PATCH] Add transforms feature

2015-03-22 3:55 GMT+01:00 Peter Eisentraut pete...@gmx.net: Here is an updated patch. On 3/17/15 1:11 AM, Pavel Stehule wrote: 2015-03-17 2:51 GMT+01:00 Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net: On 3/12/15 8:12 AM, Pavel Stehule wrote: 1. fix missing semicolon

Re: [HACKERS] [PATCH] Add transforms feature

2015-03-22 5:45 GMT+01:00 Pavel Stehule pavel.steh...@gmail.com: 2015-03-22 3:55 GMT+01:00 Peter Eisentraut pete...@gmx.net: Here is an updated patch. On 3/17/15 1:11 AM, Pavel Stehule wrote: 2015-03-17 2:51 GMT+01:00 Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net: On

Re: [HACKERS] [PATCH] Add transforms feature

2015-03-22 3:55 GMT+01:00 Peter Eisentraut pete...@gmx.net: Here is an updated patch. On 3/17/15 1:11 AM, Pavel Stehule wrote: 2015-03-17 2:51 GMT+01:00 Peter Eisentraut pete...@gmx.net mailto:pete...@gmx.net: On 3/12/15 8:12 AM, Pavel Stehule wrote: 1. fix missing semicolon

Re: [HACKERS] [PATCH] Add transforms feature

On Mon, Mar 16, 2015 at 9:51 PM, Peter Eisentraut pete...@gmx.net wrote: 4. Why guc-use-transforms? Is there some possible negative side effect of transformations, so we have to disable it? If somebody don't would to use some transformations, then he should not to install some specific

Re: [HACKERS] [PATCH] Add transforms feature

On 3/12/15 8:12 AM, Pavel Stehule wrote: 1. fix missing semicolon pg_proc.h Oid protrftypes[1]; /* types for which to apply transforms */ Darn, I thought I had fixed that. 2. strange load lib by in sql scripts: DO '' LANGUAGE plperl; SELECT NULL::hstore; use load

Re: [HACKERS] [PATCH] Add transforms feature

2015-03-17 2:51 GMT+01:00 Peter Eisentraut pete...@gmx.net: On 3/12/15 8:12 AM, Pavel Stehule wrote: 1. fix missing semicolon pg_proc.h Oid protrftypes[1]; /* types for which to apply transforms */ Darn, I thought I had fixed that. 2. strange load lib by in sql

Re: [HACKERS] [PATCH] Add transforms feature

Hi I am looking to code. Some small issues: 1. fix missing semicolon pg_proc.h Oid protrftypes[1]; /* types for which to apply transforms */ 2. strange load lib by in sql scripts: DO '' LANGUAGE plperl; SELECT NULL::hstore; use load plperl; load hstore; instead 3.

Re: [HACKERS] [PATCH] Add transforms feature

Hi I am checking this patch, but it is broken still Regards Pavel 2015-02-13 8:14 GMT+01:00 Michael Paquier michael.paqu...@gmail.com: On Mon, Dec 22, 2014 at 12:19 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Dec 15, 2014 at 3:10 PM, Peter Eisentraut pete...@gmx.net

Re: [HACKERS] [PATCH] Add transforms feature

On Mon, Dec 15, 2014 at 3:10 PM, Peter Eisentraut pete...@gmx.net wrote: fixed This patch needs a rebase, it does not apply correctly in a couple of places on latest HEAD (699300a): ./src/include/catalog/catversion.h.rej ./src/include/catalog/pg_proc.h.rej ./src/pl/plpython/plpy_procedure.c.rej

Re: [HACKERS] [PATCH] Add transforms feature

Peter Eisentraut pete...@gmx.net writes: On 4/4/14 6:21 PM, Andres Freund wrote: + /* dependency on transform used by return type, if any */ + if ((trfid = get_transform_oid(returnType, languageObjectId, true))) Should be compared to InvalidOid imo, rather than implicitly assuming

Re: [HACKERS] Bugfix and new feature for PGXS

On 11/19/14 11:11 PM, Peter Eisentraut wrote: I noticed this item was still in the 9.4 code. Looking at the original submission (http://www.postgresql.org/message-id/201306181552.36673.ced...@2ndquadrant.com, patch 0001), I think the original reason for adding this was wrong to begin with.

Re: [HACKERS] Bugfix and new feature for PGXS

On 12/4/14 11:38 AM, Peter Eisentraut wrote: On 11/19/14 11:11 PM, Peter Eisentraut wrote: I noticed this item was still in the 9.4 code. Looking at the original submission (http://www.postgresql.org/message-id/201306181552.36673.ced...@2ndquadrant.com, patch 0001), I think the original

Re: [HACKERS] Bugfix and new feature for PGXS

On 12/04/2014 02:44 PM, Peter Eisentraut wrote: On 12/4/14 11:38 AM, Peter Eisentraut wrote: On 11/19/14 11:11 PM, Peter Eisentraut wrote: I noticed this item was still in the 9.4 code. Looking at the original submission

Re: [HACKERS] Bugfix and new feature for PGXS

On 12/04/2014 03:47 PM, Andrew Dunstan wrote: On 12/04/2014 02:44 PM, Peter Eisentraut wrote: On 12/4/14 11:38 AM, Peter Eisentraut wrote: On 11/19/14 11:11 PM, Peter Eisentraut wrote: I noticed this item was still in the 9.4 code. Looking at the original submission

Re: [HACKERS] Bugfix and new feature for PGXS

On 12/4/14 3:47 PM, Andrew Dunstan wrote: You have broken two buildfarm instances that build and test external modules - in one case the Redis FDW module and in the other the File Text Array FDW. I will see what can be retrieved. This has been fixed. One thing I'll look into sometime is

Re: [HACKERS] Bugfix and new feature for PGXS

On Wed, Nov 19, 2014 at 11:11 PM, Peter Eisentraut pete...@gmx.net wrote: The applicable parts of that patch could be backpatched as a bug fix (but evidently no one cares about building contrib with pgxs (except when I submit a patch to remove it)). Touché. -- Robert Haas EnterpriseDB:

Re: [HACKERS] Bugfix and new feature for PGXS

On 6/18/13 9:52 AM, Cédric Villemain wrote: 0006-Fix-suggested-layout-for-extension.patch I have committed this patch. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Bugfix and new feature for PGXS

On 1/31/14 9:28 PM, Bruce Momjian wrote: On Fri, Jan 31, 2014 at 09:28:06PM -0500, Andrew Dunstan wrote: On 01/31/2014 09:19 PM, Bruce Momjian wrote: On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote: On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04

Re: [HACKERS] [PATCH] Add transforms feature

On 2014-04-05 00:21:47 +0200, Andres Freund wrote: On 2014-01-15 21:13:18 -0500, Peter Eisentraut wrote: The attached patch will probably fail to apply because of the pg_proc changes. So if you want to try it out, look into the header for the Git hash it was based off. I'll produce a

Re: [HACKERS] [PATCH] Add transforms feature

On 2014-01-15 21:13:18 -0500, Peter Eisentraut wrote: The attached patch will probably fail to apply because of the pg_proc changes. So if you want to try it out, look into the header for the Git hash it was based off. I'll produce a properly merged version when this approach is validated.

Re: [HACKERS] Bugfix and new feature for PGXS

On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote: On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: On 10/07/2013 08:47 PM, Peter Eisentraut wrote: I suspect this line submake-libpq: $(libdir)/libpq.so ; will cause

Re: [HACKERS] Bugfix and new feature for PGXS

On 01/31/2014 09:19 PM, Bruce Momjian wrote: On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote: On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: On 10/07/2013 08:47 PM, Peter Eisentraut wrote: I suspect this line

Re: [HACKERS] Bugfix and new feature for PGXS

On Fri, Jan 31, 2014 at 09:28:06PM -0500, Andrew Dunstan wrote: On 01/31/2014 09:19 PM, Bruce Momjian wrote: On Thu, Oct 10, 2013 at 11:00:30PM -0400, Andrew Dunstan wrote: On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: On 10/07/2013

Re: [HACKERS] [PATCH] Add transforms feature

On Fri, Jan 10, 2014 at 10:40 PM, Peter Eisentraut pete...@gmx.net wrote: On Wed, 2013-12-11 at 11:07 -0500, Tom Lane wrote: We should have learned by now that those are usually a bad idea. In this case, we've got changes in the behavior of function calling, which seems like not only a

Re: [HACKERS] [PATCH] Add transforms feature

On Wed, 2013-12-11 at 11:07 -0500, Tom Lane wrote: We should have learned by now that those are usually a bad idea. In this case, we've got changes in the behavior of function calling, which seems like not only a nightmare for debugging but a fertile source of security issues. I note that

Re: [HACKERS] [PATCH] Add transforms feature

On Wed, 2013-12-11 at 09:47 -0500, Robert Haas wrote: Of course, making everyone decorate their new functions with references to the transforms they want to use isn't wonderful either, but it might be good at least to have the option. You could allow the use of all installed transforms by

Re: [HACKERS] [PATCH] Add transforms feature

On Tue, Dec 10, 2013 at 10:35 PM, Peter Eisentraut pete...@gmx.net wrote: On Fri, 2013-12-06 at 11:28 +0100, Dimitri Fontaine wrote: Here is an idea. Add a GUC that basically says something like use_transforms = on|off. You can then attach that to individual functions, which is the right

Re: [HACKERS] [PATCH] Add transforms feature

On 12/11/2013 01:40 PM, Robert Haas wrote: On Tue, Dec 10, 2013 at 10:35 PM, Peter Eisentraut pete...@gmx.net wrote: On Fri, 2013-12-06 at 11:28 +0100, Dimitri Fontaine wrote: Here is an idea. Add a GUC that basically says something like use_transforms = on|off. You can then attach that to

Re: [HACKERS] [PATCH] Add transforms feature

On Wed, Dec 11, 2013 at 9:19 AM, Hannu Krosing ha...@2ndquadrant.com wrote: On 12/11/2013 01:40 PM, Robert Haas wrote: On Tue, Dec 10, 2013 at 10:35 PM, Peter Eisentraut pete...@gmx.net wrote: On Fri, 2013-12-06 at 11:28 +0100, Dimitri Fontaine wrote: Here is an idea. Add a GUC that basically

Re: [HACKERS] [PATCH] Add transforms feature

Robert Haas robertmh...@gmail.com writes: On Tue, Dec 10, 2013 at 10:35 PM, Peter Eisentraut pete...@gmx.net wrote: Here is an updated patch that implements this, makes some of the documentation improvements that you suggested, and rebases everything. I'm still kinda unimpressed by this.

Re: [HACKERS] [PATCH] Add transforms feature

Peter Eisentraut pete...@gmx.net writes: Here is an idea. Add a GUC that basically says something like use_transforms = on|off. You can then attach that to individual functions, which is the right granularity, because only the function knows whether its code expects transforms or not. But

Re: [HACKERS] [PATCH] Add transforms feature

On 12/06/2013 07:25 AM, Peter Eisentraut wrote: On Tue, 2013-11-26 at 18:10 +0100, Dimitri Fontaine wrote: The problem is installing a set of extensions where some of them are already using the new transform feature and some of them are not. We need a way to cater with that, I think. Here is

Re: [HACKERS] [PATCH] Add transforms feature

On Tue, 2013-11-26 at 18:10 +0100, Dimitri Fontaine wrote: The problem is installing a set of extensions where some of them are already using the new transform feature and some of them are not. We need a way to cater with that, I think. Here is an idea. Add a GUC that basically says something

Re: [HACKERS] [PATCH] Add transforms feature

On 11/15/2013 05:04 PM, Dimitri Fontaine wrote: Hi, Peter Eisentraut pete...@gmx.net writes: Rebased patch. No changes except that merge conflicts were resolved, and I had to add some Data::Dumper tweaks to the regression tests so that the results came out in consistent order on different

Re: [HACKERS] [PATCH] Add transforms feature

Hi, Allow me to temporarily skip important questions that you asked so that we can focus on the main problem here. As soon as we decide how to handle any kind of selectivity for the transforms, then I'm back to answering the other things. Peter Eisentraut pete...@gmx.net writes: Let's review

Re: [HACKERS] [PATCH] Add transforms feature

On 11/12/2013 12:21 PM, Peter Eisentraut wrote: A transform is an SQL object that supplies to functions for converting between data types and procedural languages. How hard would it be to extend this to add transforms directly between pairs of procedural languages ? One example would be

Re: [HACKERS] [PATCH] Add transforms feature

On 11/20/2013 10:58 PM, Robert Haas wrote: On Wed, Nov 20, 2013 at 11:51 AM, Peter Eisentraut pete...@gmx.net wrote: This is a transition problem. Nobody is required to install the transforms into their existing databases. They probably shouldn't. Sure, but that's like saying nobody's

Re: [HACKERS] [PATCH] Add transforms feature

On 11/15/13, 11:04 AM, Dimitri Fontaine wrote: - Documentation style seems to be to be different from the man page or reference docs style that we use elsewhere, and is instead deriving the general case from examples. Reads strange. Which specific section do you have in mind? It's

Re: [HACKERS] [PATCH] Add transforms feature

On Wed, Nov 20, 2013 at 11:51 AM, Peter Eisentraut pete...@gmx.net wrote: This is a transition problem. Nobody is required to install the transforms into their existing databases. They probably shouldn't. Sure, but that's like saying nobody's required to use this behavior-changing GUC, so

Re: [HACKERS] [PATCH] Add transforms feature

Hi, Peter Eisentraut pete...@gmx.net writes: Rebased patch. No changes except that merge conflicts were resolved, and I had to add some Data::Dumper tweaks to the regression tests so that the results came out in consistent order on different versions of Perl. I just spent some time reading

Re: [HACKERS] Bugfix and new feature for PGXS

Le jeudi 10 octobre 2013 21:37:24 Peter Eisentraut a écrit : On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote: The code has been sitting in HEAD for several months, and I committed on the back branches because it was wanted. New features normally go through a full development cycle

Re: [HACKERS] Bugfix and new feature for PGXS

On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: On 10/07/2013 08:47 PM, Peter Eisentraut wrote: I suspect this line submake-libpq: $(libdir)/libpq.so ; will cause problems on platforms with a different extension (e.g. OS X). suggested fix is below. Hmm, this would

Re: [HACKERS] Bugfix and new feature for PGXS

On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote: The code has been sitting in HEAD for several months, and I committed on the back branches because it was wanted. New features normally go through a full development cycle including extensive beta testing, especially when they contain

Re: [HACKERS] Bugfix and new feature for PGXS

On 10/10/2013 09:37 PM, Peter Eisentraut wrote: On Mon, 2013-10-07 at 22:00 -0400, Andrew Dunstan wrote: The code has been sitting in HEAD for several months, and I committed on the back branches because it was wanted. New features normally go through a full development cycle including

Re: [HACKERS] Bugfix and new feature for PGXS

On 10/10/2013 09:35 PM, Peter Eisentraut wrote: On Tue, 2013-10-08 at 10:04 -0400, Andrew Dunstan wrote: On 10/07/2013 08:47 PM, Peter Eisentraut wrote: I suspect this line submake-libpq: $(libdir)/libpq.so ; will cause problems on platforms with a different extension (e.g. OS X).

Re: [HACKERS] Bugfix and new feature for PGXS

On 10/07/2013 08:47 PM, Peter Eisentraut wrote: I suspect this line submake-libpq: $(libdir)/libpq.so ; will cause problems on platforms with a different extension (e.g. OS X). suggested fix is below. cheers andrew diff --git a/src/Makefile.global.in b/src/Makefile.global.in index

Re: [HACKERS] Bugfix and new feature for PGXS

On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote: On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue

Re: [HACKERS] Bugfix and new feature for PGXS

On 10/07/2013 08:47 PM, Peter Eisentraut wrote: On Sun, 2013-09-29 at 19:09 -0400, Andrew Dunstan wrote: On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is

Re: [HACKERS] Bugfix and new feature for PGXS

Le lundi 30 septembre 2013 00:10:09 Andrew Dunstan a écrit : On 09/29/2013 07:09 PM, Andrew Dunstan wrote: On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written

Re: [HACKERS] Bugfix and new feature for PGXS

On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by Christoph with the installdirs prerequisite, the

Re: [HACKERS] Bugfix and new feature for PGXS

On 09/29/2013 07:09 PM, Andrew Dunstan wrote: On 09/03/2013 04:04 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by

Re: [HACKERS] Questions about checksum feature in 9.3

On 9/16/13 10:14 AM, David Johnston wrote: The single core aspect is interesting. Does the implementation have a dedicated core to perform these calculations or must the same thread that handles the relevant query perform this work as well? How much additional impact/overhead does having to

Re: [HACKERS] Questions about checksum feature in 9.3

On Sun, Sep 15, 2013 at 8:13 AM, Kevin k...@gatorgraphics.com wrote: My attempts to compile it vectorized on OS X seemed to have failed since I don't find a vector instruction in the .o file even though the options -msse4.1 -funroll-loops -ftree-vectorize should be supported according to the

Re: [HACKERS] Questions about checksum feature in 9.3

Ants Aasma-2 wrote So, has anyone compiled checksum vectorized on OS X? Are there any performance data that would indicate whether or not I should worry with this in the first place? Even without vectorization the worst case performance hit is about 20%. This is for a workload that is fully

[HACKERS] Questions about checksum feature in 9.3

I am getting a new server ready for production and saw the release note on the new checksum feature. I thought it sounded like something we might want, and then after reading realized we have to initdb with the feature on. I figured I'd better check into it a little more since changing later

Re: [HACKERS] Bugfix and new feature for PGXS

Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by Christoph with the installdirs prerequisite, the attached patch fix that. Also, the bugfixes were

Re: [HACKERS] Bugfix and new feature for PGXS

On 09/03/2013 04:02 AM, Cédric Villemain wrote: Simple one, attached. I didn't document USE_VPATH, not sure how to explain that clearly. Just a remember that the doc is written and is waiting to be commited. There is also an issue spoted by Christoph with the installdirs prerequisite, the

Re: CREATE TRANSFORM syntax (was Re: [HACKERS] [PATCH] Add transforms feature)

On 08/13/2013 07:16 PM, Peter Eisentraut wrote: My next best idea is CREATE TRANSFORM FOR hstore SERVER LANGUAGE plperl, which preserves the overall idea but still distinguishes server from client languages. Comments? My thinking is that TRANSFORMS will almost certainly be managed by

CREATE TRANSFORM syntax (was Re: [HACKERS] [PATCH] Add transforms feature)

On Mon, 2013-07-08 at 23:00 -0700, Hitoshi Harada wrote: On Sun, Jul 7, 2013 at 12:06 PM, Peter Eisentraut pete...@gmx.net wrote: On Thu, 2013-07-04 at 02:18 -0700, Hitoshi Harada wrote: as someone suggested in the previous thread, it might be a variant of CAST. CREATE CAST (hstore AS

Re: [HACKERS] Bugfix and new feature for PGXS

Le lundi 8 juillet 2013 21:46:39, Andrew Dunstan a écrit : On 07/08/2013 03:40 PM, Josh Berkus wrote: On 07/04/2013 06:18 AM, Andrew Dunstan wrote: On 07/04/2013 09:14 AM, Cédric Villemain wrote: ah yes, good catch, I though .control file were unique per contrib, but there aren't.

Re: [HACKERS] Bugfix and new feature for PGXS

On 07/08/2013 12:51 PM, Josh Berkus wrote: I think everything has been committed - as I think the CF app shows. The only thing left in this srea from Cédric is the insallation of headers, which Peter is down to review and is in Waiting on Author status. Yeah, that's the one I'm asking

Re: [HACKERS] [PATCH] Add transforms feature

On 07/08/2013 12:00 PM, Josh Berkus wrote: (b) we can expect maybe a dozen to 18 of them in core based on the data types there, and I hate to clutter up /contrib, and Well, that's a matter of opinion. I'd be more happy with 250 contribs all on the same level versus a bunch of

Re: [HACKERS] [PATCH] Add transforms feature

On Sun, Jul 7, 2013 at 12:06 PM, Peter Eisentraut pete...@gmx.net wrote: On Thu, 2013-07-04 at 02:18 -0700, Hitoshi Harada wrote: as someone suggested in the previous thread, it might be a variant of CAST. CREATE CAST (hstore AS plpython2u) ? Or CREATE LANGUAGE TRANSFORM might sound better.

Re: [HACKERS] [PATCH] Add transforms feature

On Thu, Jul 4, 2013 at 2:18 AM, Hitoshi Harada umi.tan...@gmail.com wrote: For now, that's it. I'm going to dig more later. After looking into rest of the change, - TYPTYPE_DOMAIN is not supported. Why did you specifically disallow it? - ParseFuncOrColumn now prohibits to find function

Re: [HACKERS] [PATCH] Add transforms feature

Peter, On 07/07/2013 12:06 PM, Peter Eisentraut wrote: Good point. My original patch allowed func(sql_type) - internal, but I took that out because people had security concerns. I'd be OK with restricting transform creation to superusers in the first cut. Have we added the ability of

Re: [HACKERS] Bugfix and new feature for PGXS

On 07/04/2013 06:18 AM, Andrew Dunstan wrote: On 07/04/2013 09:14 AM, Cédric Villemain wrote: ah yes, good catch, I though .control file were unique per contrib, but there aren't. It's already been fixed. Does it look like this patch will get into committable shape in the next couple of

Re: [HACKERS] Bugfix and new feature for PGXS

On 07/08/2013 03:40 PM, Josh Berkus wrote: On 07/04/2013 06:18 AM, Andrew Dunstan wrote: On 07/04/2013 09:14 AM, Cédric Villemain wrote: ah yes, good catch, I though .control file were unique per contrib, but there aren't. It's already been fixed. Does it look like this patch will get

Re: [HACKERS] Bugfix and new feature for PGXS

I think everything has been committed - as I think the CF app shows. The only thing left in this srea from Cédric is the insallation of headers, which Peter is down to review and is in Waiting on Author status. Yeah, that's the one I'm asking about. is that going to get done in the next few

Re: [HACKERS] [PATCH] Add transforms feature

On Thu, 2013-07-04 at 02:18 -0700, Hitoshi Harada wrote: as someone suggested in the previous thread, it might be a variant of CAST. CREATE CAST (hstore AS plpython2u) ? Or CREATE LANGUAGE TRANSFORM might sound better. In either case, I think we are missing the discussion on the standard

Re: [HACKERS] [PATCH] Add transforms feature

On Fri, 2013-07-05 at 12:04 -0700, Josh Berkus wrote: (a) transforms aren't like other contribs, in that they are dependant on other contribs before you install them. That doesn't appear to be a reason for creating subdirectories. (b) we can expect maybe a dozen to 18 of them in core based on

Re: [HACKERS] [PATCH] Add transforms feature

Josh Berkus j...@agliodbs.com writes: (c) I'd like to do a future feature which supports install all transforms functionality, which would be helped by having them in their own directory. I think we should install required extensions automatically when they are available. Also, we will need

Re: [HACKERS] [PATCH] Add transforms feature

On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that. The data types they apply to are in contrib after

Re: [HACKERS] [PATCH] Add transforms feature

On Friday, July 5, 2013, Peter Eisentraut wrote: On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that.

Re: [HACKERS] [PATCH] Add transforms feature

On 07/05/2013 09:08 AM, Peter Eisentraut wrote: On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that.

Re: [HACKERS] request a new feature in fuzzystrmatch

Hi Liming, Here is a more formal review of this patch. First, when submitting a patch, please follow the following guidelines: http://wiki.postgresql.org/wiki/Submitting_a_Patch http://wiki.postgresql.org/wiki/Creating_Clean_Patches Particularly, when you develop a new feature, people will

Re: [HACKERS] [PATCH] Add transforms feature

On Thu, Jun 13, 2013 at 8:11 PM, Peter Eisentraut pete...@gmx.net wrote: A transform is an SQL object that supplies to functions for converting between data types and procedural languages. For example, a transform could arrange that hstore is converted to an appropriate hash or dictionary

Re: [HACKERS] Bugfix and new feature for PGXS

I'm not sure whether this is as simple as changing $ to $^ in the pgxs.mk's installcontrol rule, or if something more is required. Could you take a look? will do. ah yes, good catch, I though .control file were unique per contrib, but there aren't. -- Cédric Villemain +33 (0)6 20 30

Re: [HACKERS] Bugfix and new feature for PGXS

On 07/04/2013 09:14 AM, Cédric Villemain wrote: I'm not sure whether this is as simple as changing $ to $^ in the pgxs.mk's installcontrol rule, or if something more is required. Could you take a look? will do. ah yes, good catch, I though .control file were unique per contrib,

  1   2   3   4   5   6   7   8   9   >