Re: [PATCHES] Packed Varlena Update (v21)

2007-04-09 Thread Bruce Momjian
Added to TODO: o Allow single-byte header storage for arrays --- Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > > "Tom Lane" <[EMAIL PROTECTED]> writes: > >> Forgot to mention: one of the revisions w

Re: [PATCHES] CREATE TABLE LIKE INCLUDING INDEXES support

2007-04-09 Thread Bruce Momjian
Added to TODO: o Have WITH CONSTRAINTS also create constraint indexes http://archives.postgresql.org/pgsql-patches/2007-04/msg00149.php --- Trevor Hardcastle wrote: > Greetings all, > > I wrote this patc

Re: [PATCHES] Clear up strxfrm() in UTF-8 with locale on Windows

2007-04-09 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- IT

Re: [PATCHES] non-recursive WITH clause support

2007-04-09 Thread David Fetter
On Mon, Apr 09, 2007 at 09:08:31PM -0400, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > On Mon, Apr 09, 2007 at 06:43:08PM -0400, Tom Lane wrote: > >> So this does not really add any new functionality, it's just variant > >> syntax for something you can do about as easily without i

Re: [PATCHES] non-recursive WITH clause support

2007-04-09 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Mon, Apr 09, 2007 at 06:43:08PM -0400, Tom Lane wrote: >> So this does not really add any new functionality, it's just variant >> syntax for something you can do about as easily without it, right? > Not totally as easily. For example, you can do some

Re: [PATCHES] UTF8MatchText

2007-04-09 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- IT

Re: [PATCHES] Minor recovery changes

2007-04-09 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Si

Re: [PATCHES] RESET SESSION v3

2007-04-09 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Ma

Re: [PATCHES] non-recursive WITH clause support

2007-04-09 Thread David Fetter
On Mon, Apr 09, 2007 at 06:43:08PM -0400, Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: > > Here's an updated patch that fixes the bug I had. This is now functional > > basic > > non-recursive WITH clause support. > > http://community.enterprisedb.com/recursive/with-pg82stable-v2.pa

Re: [PATCHES] non-recursive WITH clause support

2007-04-09 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > Here's an updated patch that fixes the bug I had. This is now functional basic > non-recursive WITH clause support. > http://community.enterprisedb.com/recursive/with-pg82stable-v2.patch.gz > It's a pretty short simple patch as is; it just directly inlin

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Martijn van Oosterhout
On Mon, Apr 09, 2007 at 04:07:16PM -0400, Andrew Dunstan wrote: > Some type systems have named array types, some don't. I can live happily > with either. Are array types anonymous in the standard? Yes, they're anonymous in the standard. That doesn't mean we can't give them names if we wanted...

Re: [PATCHES] UTF8MatchText

2007-04-09 Thread Bruce Momjian
Patch removed, updated version submitted. --- ITAGAKI Takahiro wrote: > "Andrew - Supernews" <[EMAIL PROTECTED]> wrote: > > > ITAGAKI> I think all "safe ASCII-supersets" encodings are comparable > > ITAGAKI> by bytes, not

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Andrew Dunstan
Martijn van Oosterhout wrote: On Mon, Apr 09, 2007 at 10:14:41AM -0400, Andrew Dunstan wrote: . defer for the present any consideration of a "CREATE TYPE foo AS ARRAY ..." command. What is the rationale for allowing people to name the array type. When I originally proposed the syntax I

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Martijn van Oosterhout
On Mon, Apr 09, 2007 at 10:14:41AM -0400, Andrew Dunstan wrote: > . defer for the present any consideration of a "CREATE TYPE foo AS ARRAY > ..." command. What is the rationale for allowing people to name the array type. When I originally proposed the syntax I presumed that the array name would b

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread David Fetter
On Mon, Apr 09, 2007 at 10:40:49AM -0400, Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Regarding catalog objects, we might have to try a little harder than > > just not generating in bootstrap mode - IIRC we generate system views > > (including pg_stats) in non-bootstrap mode.

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Regarding catalog objects, we might have to try a little harder than > just not generating in bootstrap mode - IIRC we generate system views > (including pg_stats) in non-bootstrap mode. Maybe we just need to exempt > anything in the pg_catalog namesp

Re: [PATCHES] [HACKERS] Arrays of Complex Types

2007-04-09 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: How would we do that? Not create the array types in bootstrap mode? Or just special-case pg_statistic? Not generate them in bootstrap mode works for me. IIRC, there's code somewhere in there that allows anyarray to pass as a c

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-09 Thread Alvaro Herrera
ITAGAKI Takahiro wrote: > > > >Yes, that's correct. Per previous discussion, what I actually wanted to > > > >do was to create a GUC setting to simplify the whole thing, something > > > >like "autovacuum_max_mb_per_second" or "autovacuum_max_io_per_second". > > > >Then, have each worker use up to

Re: [PATCHES] Minor recovery changes

2007-04-09 Thread Bruce Momjian
Simon Riggs wrote: > On Sun, 2007-04-08 at 23:02 -0400, Bruce Momjian wrote: > > Simon, do you have email access while you are away for two weeks? Can > > you answer questions via email? > > It's not a complete blackout, if I check through... > > Irregular email 10-12 Apr > Now available 17 Apr

Re: [PATCHES] Clear up strxfrm() in UTF-8 with locale on Windows

2007-04-09 Thread Hiroshi Saito
From: "ITAGAKI Takahiro" <[EMAIL PROTECTED]> The attached patch clears up the usage of strxfrm() on Windows. If the server encoding is UTF-8 and the locale is not C, we should use wcsxfrm() instead of strxfrm() because UTF-8 locale are not supported on Windows. We've already have a special versi

Re: [PATCHES] autovacuum multiworkers, patch 5

2007-04-09 Thread ITAGAKI Takahiro
> > >Yes, that's correct. Per previous discussion, what I actually wanted to > > >do was to create a GUC setting to simplify the whole thing, something > > >like "autovacuum_max_mb_per_second" or "autovacuum_max_io_per_second". > > >Then, have each worker use up to (max_per_second/active workers)

[PATCHES] Clear up strxfrm() in UTF-8 with locale on Windows

2007-04-09 Thread ITAGAKI Takahiro
The attached patch clears up the usage of strxfrm() on Windows. If the server encoding is UTF-8 and the locale is not C, we should use wcsxfrm() instead of strxfrm() because UTF-8 locale are not supported on Windows. We've already have a special version of strcoll() for Windows, but the usage of st