Re: [PATCHES] eventlog fix

2004-06-20 Thread Laurent Ballester
; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Sunday, June 20, 2004 3:33 AM Subject: Re: [PATCHES] eventlog fix > > Patch applied, with doc additions I already posted. Please test CVS and > let me know how it works. I added a README containing your explaination > below for ou

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
Ballester" <[EMAIL PROTECTED]> > Cc: "Alvaro Herrera" <[EMAIL PROTECTED]>; > <[EMAIL PROTECTED]> > Sent: Saturday, June 19, 2004 7:13 AM > Subject: Re: [PATCHES] eventlog fix > > > > > > OK, I have created the following dif

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
Dave Page wrote: > > > > -Original Message- > > From: Tom Lane [mailto:[EMAIL PROTECTED] > > Sent: 19 June 2004 22:49 > > To: Dave Page > > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester; > > [EMAIL PROTECTED] > > Subject: Re: [P

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 19 June 2004 22:49 > To: Dave Page > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester; > [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > Hm, that is a lot ... but

Re: [PATCHES] eventlog fix

2004-06-19 Thread Tom Lane
"Dave Page" <[EMAIL PROTECTED]> writes: >> So is this tool readily available? What does one have to >> do/buy to lay hands on it? > It's included with the Windows Platform SDK (which is free). Oh, good. > It's a very large download to get the SDK (180MB) - that's a lot of > bandwidth for one l

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane > Sent: 19 June 2004 20:03 > To: Magnus Hagander > Cc: Bruce Momjian; Laurent Ballester; [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > "Ma

Re: [PATCHES] eventlog fix

2004-06-19 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > We require the MS "MC" compiler to build the BIN file (note - this is > not C - this is the "Message Compiler"). So is this tool readily available? What does one have to do/buy to lay hands on it? > Not requiring it is the reason we'd include the .

Re: [PATCHES] eventlog fix

2004-06-19 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] on behalf of Bruce Momjian > Sent: Sat 6/19/2004 4:21 PM > To: Laurent Ballester > Cc: Alvaro Herrera; [EMAIL PROTECTED] > Subject: Re: [PATCHES] eventlog fix > > > Woh, we aren't requring MS C to co

Re: [PATCHES] eventlog fix

2004-06-19 Thread Andrew Dunstan
Cc: "Alvaro Herrera" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Saturday, June 19, 2004 7:13 AM Subject: Re: [PATCHES] eventlog fix OK, I have created the following diff to document the pgevent installation instructions. However, you didn't send me a

Re: [PATCHES] eventlog fix

2004-06-19 Thread Magnus Hagander
modifications. >> >> regards >> Laurent Ballester >> >> ----- Original Message - >> From: "Bruce Momjian" <[EMAIL PROTECTED]> >> To: "Laurent Ballester" <[EMAIL PROTECTED]> >> Cc: "Alvaro Herrera" <[EM

Re: [PATCHES] eventlog fix

2004-06-19 Thread Bruce Momjian
we cannot uses auto generated .def files without > handy modifications. > > regards > Laurent Ballester > > - Original Message - > From: "Bruce Momjian" <[EMAIL PROTECTED]> > To: "Laurent Ballester" <[EMAIL PROTECTED]> >

Re: [PATCHES] eventlog fix

2004-06-19 Thread Laurent Ballester
tions. regards Laurent Ballester - Original Message - From: "Bruce Momjian" <[EMAIL PROTECTED]> To: "Laurent Ballester" <[EMAIL PROTECTED]> Cc: "Alvaro Herrera" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Saturday, June 19, 2004 7:1

Re: [PATCHES] eventlog fix

2004-06-18 Thread Bruce Momjian
OK, I have created the following diff to document the pgevent installation instructions. However, you didn't send me a Makefile for creating the DLL, and I am not sure how to do that. Would you send me a `Makefile for src/bin/pgevent? Thanks. ---

Re: [PATCHES] eventlog fix

2004-06-16 Thread Laurent Ballester
> > Would you send me documentation explaining how to register this DLL with > the event logger on Win32? Ideally you could send me a diff against > installation.sgml. > Hello Bruce, After the DLL was in it target directory (C:\msys\1.0\local\pgsql\lib with make install) You can register the

Re: [PATCHES] eventlog fix

2004-06-14 Thread Bruce Momjian
Would you send me documentation explaining how to register this DLL with the event logger on Win32? Ideally you could send me a diff against installation.sgml. --- Laurent Ballester wrote: > Hello, > > > > > We don't use t

Re: [PATCHES] eventlog fix

2004-06-05 Thread Laurent Ballester
Hello, > > We don't use this hungarian notation anywhere ... it certainly looks > ugly. > Sorry, I modify pgevent.c again and suppress all hungarian variables naming. I add a diff -c for src/bin/Makefile, necessary to compile pgevent for windows platform. regards Laurent Ballester /*-

Re: [PATCHES] eventlog fix

2004-06-03 Thread Alvaro Herrera
On Thu, Jun 03, 2004 at 12:33:29AM +0200, Laurent Ballester wrote: > I modify pgevent.c, for your both remarks: "capital G" are disappears from > source and I move GetModuleFilename() before RegCreateKey() call. > > I sent full set file again, it will be easier to apply. > /* Global variables */

Re: [PATCHES] eventlog fix

2004-06-02 Thread Laurent Ballester
Hello magnus, > I assume you mean src/bin/pgevent, to be consistent with the naming used > inside the program. OK, I Modify Makefile subdir value. In fact I name it pg_event because many directory under src/bin began with pg_ . > Second, I'd register the source as "PostgreSQL", not "PostGreSQL".

Re: [PATCHES] eventlog fix

2004-06-02 Thread Magnus Hagander
> The purpose of this patch is to fix an error when > log_destination is set to 'eventlog' value in postgresql.conf files. Looks good to me, just a couple of tiny things: > After discussion on win32 mailing list, I suggest to store > source under src/bin/pg_event I assume you mean src/bin/pg