Re: [HACKERS][PATCHES] odd output in restore mode

2008-08-02 Thread Andrew Dunstan
Simon Riggs wrote: Well, this is a strange conclusion, leaving me slightly bemused. The discussion between Andrew and I at PGcon concluded that we would * document which other tools to use * remove the delay Now we have rejected the patch which does that, but then re-requested the exact same

Re: [HACKERS][PATCHES] odd output in restore mode

2008-08-02 Thread Simon Riggs
On Thu, 2008-07-31 at 12:32 -0400, Tom Lane wrote: > "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > > Martin Zaun wrote: > >> With these avenues to be explored, can the pg_standby patch on the > >> CommitFest wiki be moved to the "Returned with Feedback" section? > > > Yes, I think we can con

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-31 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Martin Zaun wrote: >> With these avenues to be explored, can the pg_standby patch on the >> CommitFest wiki be moved to the "Returned with Feedback" section? > Yes, I think we can conclude that we don't want this patch as it is. > Instead, we wan

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-31 Thread Heikki Linnakangas
Martin Zaun wrote: Heikki Linnakangas wrote: Andrew Dunstan wrote: Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: I've been working on an improved archive_command shell script that I expect to submit for comments and potential inclusion in the documentation as a better base fo

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-30 Thread Martin Zaun
Heikki Linnakangas wrote: Andrew Dunstan wrote: Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: I've been working on an improved archive_command shell script that I expect to submit for comments and potential inclusion in the documentation as a better base for other people to bu

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-29 Thread Heikki Linnakangas
Andrew Dunstan wrote: Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this e

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Andrew Dunstan
Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this even works on Windows. C

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Greg Smith
On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this even works on Windows. Could that just be d

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Heikki Linnakangas
Andrew Dunstan wrote: Heikki Linnakangas wrote: Andrew Dunstan wrote: - or maybe provide a .bat file or perl script that would work as na archive_command on Windows. We're not talking about archive_command. We're talking about the thing that copies files to the directory that pg_standby

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Andrew Dunstan
Heikki Linnakangas wrote: Andrew Dunstan wrote: - or maybe provide a .bat file or perl script that would work as na archive_command on Windows. We're not talking about archive_command. We're talking about the thing that copies files to the directory that pg_standby polls. Er, that's wha

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Heikki Linnakangas
Andrew Dunstan wrote: Kevin Grittner wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> wrote: We really need a more reliable way of detecting that a file has been fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive dire

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Simon Riggs
On Fri, 2008-07-25 at 16:58 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: > >> I thought the latest conclusion was that changing the behavior of > >> pg_standby itself wouldn't address the problem anyway, and that what we >

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: >> I thought the latest conclusion was that changing the behavior of >> pg_standby itself wouldn't address the problem anyway, and that what we >> need is just a docs patch recommending that people use safe

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Simon Riggs
On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: > >> reviewing your patch > > > Current status is this: > > * My understanding is that Dave and Andrew (and therefore Simon) think > > the approa

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: >> reviewing your patch > Current status is this: > * My understanding is that Dave and Andrew (and therefore Simon) think > the approach proposed here is an acceptable one. Heikki disagrees and > want

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Simon Riggs
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: > reviewing your patch Current status is this: * My understanding is that Dave and Andrew (and therefore Simon) think the approach proposed here is an acceptable one. Heikki disagrees and wants different approach. Perhaps I misunderstand.

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Simon Riggs
On Wed, 2008-07-23 at 21:38 +0300, Heikki Linnakangas wrote: > Simon Riggs wrote: > > On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: > >> 8. Unresolved question of implementing now/later a "cp" replacement > > > > The patch implements what's been agreed. > > > > I'm not rewriting "cp", f

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Andrew Dunstan
Kevin Grittner wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> wrote: We really need a more reliable way of detecting that a file has been fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive director

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Kevin Grittner
>>> "Heikki Linnakangas" <[EMAIL PROTECTED]> wrote: > We really need a more reliable way of detecting that a file has been > fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Heikki Linnakangas
Simon Riggs wrote: On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: 8. Unresolved question of implementing now/later a "cp" replacement The patch implements what's been agreed. I'm not rewriting "cp", for reasons already discussed. Not a comment to you Martin, but it's fairly clear th

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Simon Riggs
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: > 1. Issues with applying the patch to CVS HEAD: For me, the patch applies cleanly to CVS HEAD. I do notice that there are two files "standby.sgml" and "pgstandby.sgml". I can't see where "standby.sgml" comes from, but I haven't created it;

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Simon Riggs
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: > 1. Issues with applying the patch to CVS HEAD: Sounds awful. Thanks for the review, will fix. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-patches mailing list (pgsql-patches

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-22 Thread Martin Zaun
Below my comments on the CommitFest patch: pg_standby minor changes for Windows Simon, I'm sorry you got me, a Postgres newbie, signed up for reviewing your patch ;) To start with, I'm not quite sure of the status of this patch since Bruce's last comment on the -patches alias: Bruce Momjian