Andrew Dunstan [EMAIL PROTECTED] writes:
The initdb code is failing because we didn't call WSAStartup() - this
just took me ages to track down. All the rest works.
The attached patch seems to do the trick.
Applied.
regards, tom lane
---(end
Andrew Dunstan wrote:
I suspected we'd forgotten something.
The attached small patch appears to be what's required (at least on
loris). make check failed but not for any apparent ipv6 reason. More
importantly, we correctly set HAVE_IPV6 and HAVE_STRUCT_ADDRINFO.
Well this is what I ment
Petr Jelinek wrote:
Andrew Dunstan wrote:
I suspected we'd forgotten something.
The attached small patch appears to be what's required (at least on
loris). make check failed but not for any apparent ipv6 reason.
More importantly, we correctly set HAVE_IPV6 and HAVE_STRUCT_ADDRINFO.
Andrew Dunstan wrote:
The patch I sent should be exactly what is required to have HAVE_IPV6
and HAVE_STRUCT_ADDRINFO defined on windows. That should be true
regardless of which windows you are building on - the headers should be
the same.
Oh, if that include makes HAVE_IPV6 defined than it
Petr Jelinek wrote:
So I hope IPv6 episode is finally over :)
Almost :-)
The initdb code is failing because we didn't call WSAStartup() - this
just took me ages to track down. All the rest works.
The attached patch seems to do the trick.
cheers
andrew
Index: initdb.c
Dave Page wrote:
It, or some related patch appears to have broken the build on buildfarm member
snake.
I haven't had time to investigate.
/D
Atached patch fixes it and also adds proper gai_strerror for windows.
(It's patch against CVS *after* Chucks patch was aplied)
--
Regards
Petr
Petr Jelinek wrote:
Dave Page wrote:
It, or some related patch appears to have broken the build on
buildfarm member snake.
I haven't had time to investigate.
/D
Atached patch fixes it and also adds proper gai_strerror for windows.
(It's patch against CVS *after* Chucks patch was
Petr Jelinek [EMAIL PROTECTED] writes:
Dave Page wrote:
It, or some related patch appears to have broken the build on buildfarm
member snake.
Atached patch fixes it and also adds proper gai_strerror for windows.
Applied. I had to #ifdef the gai_strerror additions to avoid breakage
on my
Andrew Dunstan wrote:
I thought this had been tested. I should have tested it myself. Apologies.
Right, I thought I tested it, well maybe it was my version dunno but
surely it was my mistake.
Anyway, with Petr's extra patch I get a clean build, but make check
fails with a postmaster bind
Petr Jelinek [EMAIL PROTECTED] writes:
Andrew Dunstan wrote:
So, not quite there yet.
[I did make check only in W2K because I don't have direct access to XP
machine now]
No thats not windows error thats postgres error (look at pqcomm.c),
which means HAVE_IPV6 is not defined.
Possibly, but
Tom Lane wrote:
Possibly, but that's apparently not the only problem. I'm looking at
the first buildfarm result with this patch,
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=lorisdt=2005-08-25%2018:56:02
The interesting part is the postmaster log at the bottom:
LOG: could not bind IPv4
Petr Jelinek [EMAIL PROTECTED] writes:
Yep those changes proposed in my previous email fixes IPv4 too.
Apparently not on loris (unless there was another patch that I missed).
Maybe something to do with a different version of Windows?
regards, tom lane
Tom Lane wrote:
Petr Jelinek [EMAIL PROTECTED] writes:
Yep those changes proposed in my previous email fixes IPv4 too.
Apparently not on loris (unless there was another patch that I missed).
Maybe something to do with a different version of Windows?
I
I don't understand this proposed patch. Pulling in more headers, when
they aren't needed, shouldn't change the behavior of the code...
What am I missing?
-Original Message-
From: Andrew Dunstan [mailto:[EMAIL PROTECTED]
Sent: Thursday, August 25, 2005 4:03 PM
To: Tom Lane
Cc: Petr
The No error message occurs because pqcomm.c assumes bind returns the
error code in errno, but on Windows it gets returned by
WSAGetLastError().This bug probably exists in many places in the
code.
The actual error should have said:
LOG: could not bind IPv6 socket: The system detected an
Chuck McDevitt [EMAIL PROTECTED] writes:
It turns out the root of the bug is that our definition of addrinfo
and Windows definition of addrinfo are not the same.
... which answers your question about why it's important to pull in
Microsoft's header. That should ensure that the code uses
Andrew Dunstan [EMAIL PROTECTED] writes:
I suspected we'd forgotten something.
The attached small patch appears to be what's required (at least on
loris). make check failed but not for any apparent ipv6 reason. More
importantly, we correctly set HAVE_IPV6 and HAVE_STRUCT_ADDRINFO.
17 matches
Mail list logo
