Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sat, 06 May 2006 20:38:48 +0300, Bruce Momjian : I still do not know why we can't do some kind of runtime test in python and disable this feature for 2.4 builds that have debugging enabled. Can we do a dynamic function load test from plpython? There must be some function that is only visible in

Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sun, 07 May 2006 12:36:59 +0300, Sven Suursoho <[EMAIL PROTECTED]>: Btw, we developed returning compose types further. Basically did same as for SETOF functions -- allow to return any Python object that conforms to mapping protocol. Currently only dict as previously, though. But still, read

Re: [PATCHES] plpython improvements

2006-05-07 Thread Bruce Momjian
Sven Suursoho wrote: > Sat, 06 May 2006 20:38:48 +0300, Bruce Momjian : > > > I still do not know why we can't do some kind of runtime test in python > > and disable this feature for 2.4 builds that have debugging enabled. > > Can we do a dynamic function load test from plpython? There must be >

Re: [PATCHES] pgstat: delayed write of stats file

2006-05-07 Thread Bruce Momjian
Magnus Hagander wrote: > > >>> This was not ready to be applied, was it? > > > > > I don't recall any specific objections that weren't answered. > > > > How about the fact that it's already caused one buildfarm failure? > > > > http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=wasp&dt=2006 > -04

Re: [PATCHES] [HACKERS] Question on win32 semaphore simulation

2006-05-07 Thread Bruce Momjian
While we have installed a Win32-specific semaphore implementation for CVS HEAD, what do we want do apply for the back branches, 8.0.X and 8.1.X. Is this the patch that should be applied? --- Qingqing Zhou wrote: > > "Qingq

Re: [PATCHES] pgstat: delayed write of stats file

2006-05-07 Thread Tom Lane
Bruce Momjian writes: > Was this fixed somehow? I don't see any more buildfarm failures, but I > didn't see a fix go in either. It is very possible the pgport fix I did > yesterday is related, but I have not applied it yet. It's an intermittent failure; the fact you don't see any at this instan

Re: [PATCHES] [HACKERS] Question on win32 semaphore simulation

2006-05-07 Thread Tom Lane
Bruce Momjian writes: > While we have installed a Win32-specific semaphore implementation for > CVS HEAD, what do we want do apply for the back branches, 8.0.X and > 8.1.X. Is this the patch that should be applied? Leave 'em alone. That code has zero field validation, and should certainly not g

Re: [PATCHES] plpython improvements

2006-05-07 Thread Sven Suursoho
Sun, 07 May 2006 15:58:49 +0300, Bruce Momjian : Unfortunately, this is not case for Fedora Core 4, where assertions are used unconditionally. And to make things worse, there is no runtime symbol at all to indicate whether Python is compiled with debugging/assertions enabled (Py_DEBUG & NDEBU

[PATCHES] [PATCH] Magic block for modules

2006-05-07 Thread Martijn van Oosterhout
This implements a proposal made last november: http://archives.postgresql.org/pgsql-hackers/2005-11/msg00578.php Basically, it tries to catch people loading modules which belong to the wrong version or have had certain constants changed, or architechture mismatches. It's a bit more fine grained t

Re: [PATCHES] Page at a time index scan

2006-05-07 Thread Tom Lane
I've committed a rewritten version of this patch. Heikki Linnakangas <[EMAIL PROTECTED]> writes: > On Fri, 5 May 2006, Tom Lane wrote: >> btbulkdelete arrives at a page, it need take no special action unless the >> page is newly split *and* its right-link points to a lower physical >> address. If

Re: [PATCHES] [PATCH] Magic block for modules

2006-05-07 Thread Tom Lane
Martijn van Oosterhout writes: > This implements a proposal made last november: > http://archives.postgresql.org/pgsql-hackers/2005-11/msg00578.php Ah, good, I'd been meaning to do this. > changes in any of the following: > PG_VERSION_NUM > CATALOG_VERSION_NO > the size of 8 basic C types > BLC

Re: [PATCHES] pgstat: remove delayed destroy / pipe:

2006-05-07 Thread Bruce Momjian
Patch applied to HEAD, 8.1.X and 8.0.X. --- Bruce Momjian wrote: > Magnus Hagander wrote: > > > It turns out the problem is that port/pipe.c is compiled with > > > -DFRONTEND and include/port/win32.h wraps the recv to > >

Re: [PATCHES] [HACKERS] Question on win32 semaphore simulation

2006-05-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > While we have installed a Win32-specific semaphore implementation for > > CVS HEAD, what do we want do apply for the back branches, 8.0.X and > > 8.1.X. Is this the patch that should be applied? > > Leave 'em alone. That code has zero field validation

Re: [PATCHES] pgstat: delayed write of stats file

2006-05-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Was this fixed somehow? I don't see any more buildfarm failures, but I > > didn't see a fix go in either. It is very possible the pgport fix I did > > yesterday is related, but I have not applied it yet. > > It's an intermittent failure; the fact you

Re: [PATCHES] pgstat: delayed write of stats file

2006-05-07 Thread Tom Lane
Bruce Momjian writes: > Have we seen any such failures since the first day they appeared? agouti blew up about the same time you typed that, so yes it's still a problem. http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=agouti&dt=2006-05-08%2003:15:01 regards, tom lane