[pgsql-patches] pg_get_domaindef

2007-01-18 Thread FAST PostgreSQL
Hi, Attached is a small patch that implements the pg_get_domaindef(oid) function. Somethings I am not sure about the patch and which I can fix based on your input are as follows. - I have used SPI interface. I saw that in ruleutils some methods make use of SPI interface whereas others use in

Re: [pgsql-patches] pg_get_domaindef

2007-01-18 Thread FAST PostgreSQL
On Fri, 19 Jan 2007 17:02, Neil Conway wrote: > On Sat, 2007-01-20 at 02:28 +1100, FAST PostgreSQL wrote: > > Attached is a small patch that implements the pg_get_domaindef(oid) > > function. > > A few minor comments: > > - don't use C++-style comments OK. Can do.

Re: [pgsql-patches] pg_get_domaindef

2007-01-23 Thread FAST PostgreSQL
Please find attached the patch with modifications Rgds, Arul Shaji On Sat, 20 Jan 2007 04:44, FAST PostgreSQL wrote: > On Fri, 19 Jan 2007 17:02, Neil Conway wrote: > > On Sat, 2007-01-20 at 02:28 +1100, FAST PostgreSQL wrote: > > > Attached is a small patch that implements th

Re: [PATCHES] [pgsql-patches] pg_get_domaindef

2007-02-06 Thread FAST PostgreSQL
On Thu, 25 Jan 2007 02:25, Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > FAST PostgreSQL wrote: > >> Please find attached the patch with modifications > > > > are you proposing to implement the other functions in this TODO item >

[PATCHES] WIP patch - INSERT-able log statements

2007-02-15 Thread FAST PostgreSQL
Hi, I've been working on the following TODO item and attached is an initial patch. (It is only partial and not yet completely functional) "Allow server log information to be output as INSERT statements This would allow server log information to be easily loaded into a database for analysis. "

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-15 Thread FAST PostgreSQL
On Fri, 16 Feb 2007 11:50, Tom Lane wrote: > "FAST PostgreSQL" <[EMAIL PROTECTED]> writes: > > The second variable is of interest. We need to specify a table in the > > insert command. My preferred option is for the user to give one and he > > can create it if

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-18 Thread FAST PostgreSQL
On Sun, 18 Feb 2007 18:25, Greg Smith wrote: > On Sat, 17 Feb 2007, FAST PostgreSQL wrote: > > #log_output_type = 'text' #Valid values are 'SQL' or 'text' > > Defaults to 'text' which is status quo. If it is set to 'SQL' log will

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-20 Thread FAST PostgreSQL
Ok. Summarizing the key changes required on my patch, based on the discussions so far are : - The log_destination will include a new option 'sql'. This can be given with other combinations of stderr, syslog or eventlog. - The sql logs will be written in log_directory in a file log_filename.

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-20 Thread FAST PostgreSQL
On Wed, 21 Feb 2007 12:08, Tom Lane wrote: > "FAST PostgreSQL" <[EMAIL PROTECTED]> writes: > > - The log output will be in COPY format and will include the following > > information, irrespective of the log_line_prefix setting. > > ( timestamp_with_milliseconds

Re: [PATCHES] WIP patch - INSERT-able log statements

2007-02-20 Thread FAST PostgreSQL
On Wed, 21 Feb 2007 14:59, Greg Smith wrote: > On Tue, 20 Feb 2007, Tom Lane wrote: > > A smaller problem is that this forces people to incur a gettimeofday > > call for every message logged > > I'm stumped trying to think of an application that would require importing > the logs into a database to

Re: [PATCHES] WIP Patch - Updateable Cursors

2007-02-27 Thread FAST PostgreSQL
On Wed, 28 Feb 2007 09:48, Bruce Momjian wrote: [Added a subejct line] > FYI, I am not going to be comfortable accepting a final patch that > contains this email signature: > > This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN > 27 003 693 481. It is confidentia

Re: [PATCHES] [pgsql-patches] pg_get_domaindef

2007-02-28 Thread FAST PostgreSQL
decide on this one so we can update the TODO or apply > the patch. > > --- > > Tom Lane wrote: > > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > > FAST PostgreSQL wrote: > > >> P

Re: [HACKERS] [PATCHES]

2007-02-28 Thread FAST PostgreSQL
On Thu, 1 Mar 2007 04:28, Bruce Momjian wrote: > I have added this to the developer's FAQ to clarify the situtation of > posting a patch: > > PostgreSQL is licensed under a BSD license. By posting a patch > to the public PostgreSQL mailling lists, you are giving the PostgreSQL > Global

Re: [PATCHES] WIP Patch - Updateable Cursors

2007-03-01 Thread FAST PostgreSQL
On Fri, 2 Mar 2007 01:20, Simon Riggs wrote: > On Thu, 2007-03-01 at 15:17 +1100, FAST PostgreSQL wrote: Hi Simon, > > We are happy to provide that. If and when it comes to the final patch > > being accepted, we can send a copyright waiver mail which will put our > > sou

[PATCHES] Fwd: Re: [pgsql-patches] pg_get_domaindef

2007-03-30 Thread FAST PostgreSQL
gsql-patches@postgresql.org Please find attached the patch with modifications Rgds, Arul Shaji On Sat, 20 Jan 2007 04:44, FAST PostgreSQL wrote: > On Fri, 19 Jan 2007 17:02, Neil Conway wrote: > > On Sat, 2007-01-20 at 02:28 +1100, FAST PostgreSQL wrote: > > > Attached is a s

Re: [PATCHES] COPY-able sql log outputs

2007-04-01 Thread FAST PostgreSQL
On Sat, 31 Mar 2007 14:09, you wrote: > FAST PostgreSQL wrote: > >> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL: > >>> Attached is the completed patch for the COPY-able sql log outputs. > >> > >> Could you please remove random whitespace

Re: [PATCHES] COPY-able sql log outputs

2007-04-03 Thread FAST PostgreSQL
databasename 3. Constructing the csvlog filename using log_filename instead of strcat. 4. General code optimization. Any other changes required ? ? Will soon submit the updated patch. Rgds, Arul Shaji > FAST PostgreSQL wrote: > >> Am Dienstag, 3. April 2007 20:33 schrieb FAST Postg

Re: [PATCHES] Updateable cursors patch

2007-04-03 Thread FAST PostgreSQL
On Mon, 2 Apr 2007 03:15, Simon Riggs wrote: > Cool patch. > > On Wed, 2007-04-04 at 18:36 +0000, FAST PostgreSQL wrote: > > The planner has to be taught to treat a DELETE/UPDATE WHERE CURRENT OF > > as a TidScan. Currently it follows the sequential scan route and > >

Re: [PATCHES] Updateable cursors patch

2007-05-14 Thread FAST PostgreSQL
Right. I will send an updated patch against the CVS head in the next couple of days. Jaime Casanova wrote: On 4/4/07, FAST PostgreSQL <[EMAIL PROTECTED]> wrote: Attached is a working updateable cursors patch. The core functionality has been implemented and the patch also contai

Re: [PATCHES] Updateable cursors patch

2007-05-17 Thread FAST PostgreSQL
Attached is an updated version of the updateable cursors patch against the latest cvs head. Most of the changes in the patch are to make it sync with the changes in CVS recently, for DECLARE CURSOR and EXPLAIN, as mentioned by Jaime in his mail below. Rgds, Arul Shaji FAST PostgreSQL

Re: [PATCHES] Updateable cursors patch

2007-05-17 Thread FAST PostgreSQL
s). I miss part about limits in documentation. Propably updatable cursors aren't supported by plpgsql (and it's point to ToDo). Regards Pavel Stehule 2007/5/17, FAST PostgreSQL <[EMAIL PROTECTED]>: Attached is an updated version of the updateable cursors patch against the latest cv

Re: [PATCHES] Updateable cursors patch

2007-05-18 Thread FAST PostgreSQL
wrote: 2007/5/18, FAST PostgreSQL <[EMAIL PROTECTED]>: No. It works with scrollable cursors. It will work for cursors/selects which does not put the results in some store, such as WITH hold/group by/order by etc But most of these restrictions apply for normal 'Select for update

Re: [PATCHES] Updateable cursors patch

2007-05-18 Thread FAST PostgreSQL
Correction Meant to say According to the standard, updateable cursors cannot be scrollable until we have full cursor update. FAST PostgreSQL wrote: Right. The current implementation allows only simple queries. Joins are disallowed. According to the standard, updateable cursors cannot be

Re: [PATCHES] Updateable cursors patch

2007-05-20 Thread FAST PostgreSQL
ill be thrown if there are no rules. It is easily doable. But I want to confirm if this will break any other part. I am looking into it now. Rgds, Arul Shaji Jaime Casanova wrote: On 5/17/07, Jaime Casanova <[EMAIL PROTECTED]> wrote: On 5/17/07, FAST PostgreSQL <[EMAIL PROTECTED]&g

[PATCHES] A minor typo fix on pg_standby docs

2007-12-06 Thread FAST PostgreSQL
Rgds, Arul Shaji *** pgstandby.sgml 2007-12-06 14:52:18.0 +1100 --- new_pgstandby.sgml 2007-12-07 18:38:26.0 +1100 *** *** 262,268 keep the last 255 full WAL files, plus the current one sleep for 2 seconds between checks for next WAL file is full