Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Zeev Suraski
At 23:37 22-08-01, [EMAIL PROTECTED] wrote: Hi, I've got an experimental beginning of the new rand functions ready. I think it's good if others can comment on it before it is finished, because the course can be changed now quite easily, but when it's all done, I don't feel much about doing

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Jeroen van Wolffelaar
At 23:37 22-08-01, [EMAIL PROTECTED] wrote: Hi, I've got an experimental beginning of the new rand functions ready. I think it's good if others can comment on it before it is finished, because the course can be changed now quite easily, but when it's all done, I don't feel much about

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Zeev Suraski
At 23:48 22-08-01, Jeroen van Wolffelaar wrote: It involves basic_func*, *math*, *rand* and *array* files (* are wildcards, not exclamation markings) files. And of course Makefile too. And probably some others too. That makes quite a significant portion of that directory. It is way much easier to

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Andrei Zmievski
On Wed, 22 Aug 2001, Zeev Suraski wrote: If it's such a far reaching change, I suggest you simply send the diff the php-dev. It should be enough to be a basis for a discussion on the proposed changes. If we decide to go through with it, it should be committed to the main branch, and

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Jeroen van Wolffelaar
If it's such a far reaching change, I suggest you simply send the diff the php-dev. It should be enough to be a basis for a discussion on the proposed changes. If we decide to go through with it, it should be At this time, it's merely a big move-around with code, no single thing of

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Zeev Suraski
At 00:03 23-08-01, Jeroen van Wolffelaar wrote: Simply committing at once with: rewrite everything that has to do with rand won't be any useful. 80% of the diff is the moving of code, and only 20% the real change. You also don't see what changed. Just as bad as mixing WS fixes with real fixes. I

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Jeroen van Wolffelaar
What I would do in your case is: (a) Tag the relevant files as they are today (i.e., PRE_RAND_REDESIGN or whatever) (b) Commit your move-around changes (c) Commit the real changes (can be done immediately after (b), as long as it's separate) The real changes are not ready... and I didn't

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Jeroen van Wolffelaar
(a) Tag the relevant files as they are today (i.e., PRE_RAND_REDESIGN or whatever) (b) Commit your move-around changes I really think a lot of people will set ext/standard to PRE_RAND_REDESIGN then, because they want to work on other parts, and don't want a broken build. That's the other

Re: [PHP-DEV] Branching ext/standard?

2001-08-22 Thread Zeev Suraski
At 00:15 23-08-01, Jeroen van Wolffelaar wrote: What I would do in your case is: (a) Tag the relevant files as they are today (i.e., PRE_RAND_REDESIGN or whatever) (b) Commit your move-around changes (c) Commit the real changes (can be done immediately after (b), as long as it's