Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

Hi Ilia, This series got Reviewed-by: Lionel Landwerlin, but unfortunately I don't have write access to the repo to merge them. Lionel would you mind doing that for me? Thank you, Pam On Tue, Apr 11, 2017 at 5:24 PM, Ilia Mirkin wrote: > What happened to these? > > On

Re: [Piglit] [PATCH 2/3] arb_post_depth_coverage-multisampling: Add a multisampling test.

What happened to these? On Thu, Feb 2, 2017 at 9:34 AM, Plamena Manolova wrote: > A simple multisampling test to check whether the values written > to gl_SampleMaskIn are still correct after enabling the > ARB_post_depth_coverage extension. > > Signed-off-by: Plamena

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

Thank you very much Nicolai for deep explanation. You're totally right. 2017-04-11 9:27 GMT+02:00 Nicolai Hähnle : > On 10.04.2017 00:26, Dorian Apanel wrote: > >> Hi Nicolai, >> >> Thanks for checking it. >> Yes I can add some negative tests for it - as another patch, maybe

Re: [Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

On Tue, Apr 11, 2017 at 6:52 PM, Ilia Mirkin wrote: > On Tue, Apr 11, 2017 at 12:17 PM, Marek Olšák wrote: >> On Mon, Apr 10, 2017 at 11:12 PM, Ilia Mirkin wrote: >>> This appears to be nop.shader_test almost verbatim... >> >> But

Re: [Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

On Tue, Apr 11, 2017 at 12:17 PM, Marek Olšák wrote: > On Mon, Apr 10, 2017 at 11:12 PM, Ilia Mirkin wrote: >> This appears to be nop.shader_test almost verbatim... > > But the difference is clear: nop.shader_test ends up using a constant > buffer for

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Tue, Apr 11, 2017 at 6:20 PM, Marek Olšák wrote: > On Tue, Apr 11, 2017 at 4:39 PM, Ilia Mirkin wrote: >> On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák wrote: >>> >>> >>> On Apr 10, 2017 11:11 PM, "Ilia Mirkin"

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Tue, Apr 11, 2017 at 4:39 PM, Ilia Mirkin wrote: > On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák wrote: >> >> >> On Apr 10, 2017 11:11 PM, "Ilia Mirkin" wrote: >> >> Is this substantially different than

Re: [Piglit] [PATCH 3/8] arb_tessellation_shader/execution/sanity2: new variant of the test

On Mon, Apr 10, 2017 at 11:12 PM, Ilia Mirkin wrote: > This appears to be nop.shader_test almost verbatim... But the difference is clear: nop.shader_test ends up using a constant buffer for vertex data, while this tests uses a vertex buffer. Marek > > On Mon, Apr 10, 2017

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Tue, Apr 11, 2017 at 5:08 AM, Marek Olšák wrote: > > > On Apr 10, 2017 11:11 PM, "Ilia Mirkin" wrote: > > Is this substantially different than patch-single-vert.shader_test or > patch-pair-verts.shader_test? Is the 4 vertices that's important to > your

Re: [Piglit] [PATCH 2/8] arb_tessellation_shader/execution/trivial: new trivial tess test

On Apr 10, 2017 11:11 PM, "Ilia Mirkin" wrote: Is this substantially different than patch-single-vert.shader_test or patch-pair-verts.shader_test? Is the 4 vertices that's important to your test? If so, patch-four-verts.shader_test seems like a better name. That's a

Re: [Piglit] [PATCH] arb_shader_image_load_store: Create complete textures.

On 10.04.2017 00:26, Dorian Apanel wrote: Hi Nicolai, Thanks for checking it. Yes I can add some negative tests for it - as another patch, maybe in this week. Thanks. As I understand the spec, log2(size) is not relevant here. Example: You create texture, default filter uses mipmaps, and