[Piglit] [PATCH] Test dependency hints on exp2 instructions.

2014-03-31 Thread Matt Turner
--- tests/shaders/dependency-hints/exp2.shader_test | 72 + 1 file changed, 72 insertions(+) create mode 100644 tests/shaders/dependency-hints/exp2.shader_test diff --git a/tests/shaders/dependency-hints/exp2.shader_test b/tests/shaders/dependency-hints/exp2.shader_test

Re: [Piglit] [PATCH] arb_shader_atomic_counters: Bind a VAO in the points case.

2014-03-31 Thread Matt Turner
Reviewed-by: Matt Turner and many thanks for getting the atomic counter tests upstream! ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_gpu_shader5: Rename `signed` to `signed_`.

2014-03-30 Thread Matt Turner
On Sun, Mar 30, 2014 at 1:19 PM, Chris Forbes wrote: > nVIDIA's compiler considers `signed` to be a reserved word and so > refuses to compile these shaders. Whether that's sensible or not, > we'd like to see any real failures in these tests instead. If you want to change it, change it to somethin

Re: [Piglit] [PATCH 01/13] util: Add func streq()

2014-03-26 Thread Matt Turner
On Wed, Mar 26, 2014 at 10:40 AM, Chad Versace wrote: > Please. Let's stop writing `!strcmp(...)` and `strcmp(...) == 0`. This > patch defines a little function streq() that reads much more nicely than > idioms using strcmp. > > Signed-off-by: Chad Versace > --- > tests/util/piglit-util.c | 6 +

Re: [Piglit] libepoxy conversion v2

2014-03-07 Thread Matt Turner
On Fri, Mar 7, 2014 at 12:08 PM, Jose Fonseca wrote: > - Original Message - >> On Wed, Feb 26, 2014 at 10:30 AM, Ken Phillis Jr >> wrote: >> > >> > On Feb 25, 2014 3:45 PM, Brian Paul wrote: >> >> I haven't had time to look at these changes, nor libepoxy. But it's >> >> critical to us th

Re: [Piglit] running with concurrency

2014-03-07 Thread Matt Turner
On Fri, Mar 7, 2014 at 12:43 AM, Tapani Pälli wrote: > Hello; > > I'm seeing errors when running piglit tests without "--no-concurrency" > almost all the time. Below is the error log, I wonder if anyone else is > seeing these? I've tested on 2 different systems (both running fc20) and I'm > gettin

Re: [Piglit] Convert from python2 to python3

2014-02-24 Thread Matt Turner
On Mon, Feb 24, 2014 at 11:47 AM, Ilia Mirkin wrote: > On Mon, Feb 24, 2014 at 2:42 PM, Dylan Baker wrote: >> This series makes the transition from python2 to python3. In general > > Out of curiousity, what's the motivation for this? I've been able to > avoid python3 quite nicely thus far, all it

Re: [Piglit] [PATCH] log: Replace console output with a simpler output

2014-02-16 Thread Matt Turner
On Fri, Feb 14, 2014 at 11:24 AM, Eric Anholt wrote: > Dylan Baker writes: > >> This replaces the console spewer with a simpler console reporting >> mechanism inspired by the output of ninja. This reduces code, remove all >> singleton instances and speeds up piglit runs. There is a drawback, the

Re: [Piglit] [PATCH 4/4] glean: Remove VertArrayBGRATest::testAPI

2014-02-08 Thread Matt Turner
On Fri, Feb 7, 2014 at 8:46 PM, Ian Romanick wrote: > From: Ian Romanick Series is Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Add a GLSL ES 3.00 compiler test for chained qualifiers.

2014-02-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 00/11] max-texture-size test overhaul

2014-02-02 Thread Matt Turner
Whew. Series is Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_gpu_shader5: test setting the invocations count in a separate GS

2014-01-31 Thread Matt Turner
On Fri, Jan 31, 2014 at 4:10 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > .../invocation-id-in-separate-gs.shader_test | 62 > ++ > 1 file changed, 62 insertions(+) > create mode 100644 > tests/spec/arb_gpu_shader5/execution/invocation-id-in-separa

Re: [Piglit] [PATCH 2/2] Test that "continue" works in a switch statement within a do-while loop.

2014-01-31 Thread Matt Turner
skipped > + } while (w < 2); // truefalse > + > + // The loop should execute for two iterations, so w should be 2. X > + // should be incremented on the first iteration only, so it should > + // be 1. Y should never be incremented (since w never reaches 3), > + // so it should be 0. The "continue" should skip ++z on the second > + // iteration, so z should be 1. > + if (w == 2 && x == 1 && y == 0 && z == 1) > +gl_FrontColor = vec4(0.0, 1.0, 0.0, 1.0); > + else > +gl_FrontColor = vec4(1.0, 0.0, 0.0, 1.0); > +} > + > +[fragment shader] > +#version 130 > +void main() > +{ > + gl_FragColor = gl_Color; > +} > + > +[test] > +draw rect -1 -1 2 2 > +probe all rgba 0.0 1.0 0.0 1.0 > -- > 1.8.5.3 > Nice tests. I'm really happy to see that they fail without causing GPU hangs on unpatched Mesa. Both are Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glslparsertest: Support geometry and compute shader in {compile, link} status

2014-01-29 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Add missing extension check in arb_gpu_shader5/invocation-id.

2014-01-29 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] Test that scalar ops in different BBs aren't combined.

2014-01-27 Thread Matt Turner
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74113 --- ...l-vs-vectorize-between-basic-blocks.shader_test | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 tests/shaders/glsl-vs-vectorize-between-basic-blocks.shader_test diff --git a/tests/shaders/glsl-v

Re: [Piglit] [PATCH 1/2] all.tests: add fs-textureOffset-2D

2014-01-21 Thread Matt Turner
Thanks, both are Reviewed-by: Matt Turner and committed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] shaders: test linking similar unnamed types

2014-01-21 Thread Matt Turner
On Fri, Jan 17, 2014 at 4:37 PM, Grigori Goronzy wrote: > GLSL allows unnamed structure types in variable declarations. This > test verifies that the GLSL linker recognizes similar unnamed structure > types declared across multiple shader stages. > --- > tests/shaders/glsl-link-unnamed-types.shad

Re: [Piglit] [PATCH 2/3] framework: Add support for a test timeout

2014-01-20 Thread Matt Turner
On Tue, Nov 12, 2013 at 2:36 AM, Daniel Vetter wrote: > i-g-t tests can take a long time, and for a bunch of reasons (bad > tuning on disparate set of platforms, stuck in the kernel which often > can be recovered by interrupting with a signal, ...) that sometimes > extends to a good approximation

Re: [Piglit] [PATCH 8/8] egl_khr_create_context: Add valid-flag-debug tests to GLES CMakeLists

2014-01-10 Thread Matt Turner
On Fri, Jan 10, 2014 at 10:30 AM, Chad Versace wrote: > On Tue, Jan 07, 2014 at 12:02:43AM +0800, Daniel Kurtz wrote: >> Add these gles specific tests to CMakelists so they will be built when >> targeting GLES. >> >> Signed-off-by: Daniel Kurtz >> --- >> tests/egl/spec/egl_khr_create_context/CMa

Re: [Piglit] [PATCH] Test that a layered fbo can have attachments with different layer counts.

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Test full framebuffer clear color with mismatched layer count.

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/8] gles-3.0/texture-immutable-levels: Fix tex array size

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 4/8] all.tests: add texture-immutable-levels_gles3

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 8/8] egl_khr_create_context: Add valid-flag-debug tests to GLES CMakeLists

2014-01-08 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glslparsertest: Test compute shaders.

2014-01-08 Thread Matt Turner
load_text_file(filename, NULL); > if (prog_string == NULL) { > fprintf(stderr, "Couldn't open program %s: %s\n", > diff --git a/tests/spec/arb_compute_shader/compiler/do_nothing.comp > b/tests/spec/arb_compute_shader/compiler/do_nothing.comp > new file

Re: [Piglit] [PATCH 2/2] texture_rectangle: Also test the other mirror wrap modes

2013-12-14 Thread Matt Turner
Both are Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] Fix spurious failures in GL_ARB_sync/sync-initialize.

2013-12-05 Thread Matt Turner
Oh good. I saw this flip between pass and fail a lot. Both are Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_separate_shader_object: Silence _GNU_SOURCE redefined warning.

2013-12-05 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] egl_ext_client_extensions: Add initial tests

2013-12-03 Thread Matt Turner
abort(); > + } > + > + display_ext_array = piglit_split_string_to_array(display_ext_string, > " "); > + client_ext_array = piglit_split_string_to_array(client_ext_string, " > "); > + > + /* Check that

Re: [Piglit] Require Signed-off-by for patches?

2013-11-13 Thread Matt Turner
On Wed, Nov 13, 2013 at 12:06 PM, Jordan Justen wrote: > What are the arguments against just following the kernel's > Signed-off-by practice? What are the arguments for it? The kernel's submitting patches documentation says that - Signed-off-by: this is a developer's certification that he or s

Re: [Piglit] [PATCH 4/7] glsl-1.10 / glsl-1.20: Don't use ortho in variable indexing tests.

2013-11-05 Thread Matt Turner
On Tue, Nov 5, 2013 at 10:57 AM, Kenneth Graunke wrote: > On 11/04/2013 10:27 PM, Matt Turner wrote: >> Using ortho makes shrinking the window size much more difficult, which >> makes running tests in simulation take much longer. >> --- >> tests/spec/glsl-1.10/v

Re: [Piglit] [PATCH 2/7] shaders: Remove #version from glsl-const tests.

2013-11-05 Thread Matt Turner
On Tue, Nov 5, 2013 at 10:43 AM, Kenneth Graunke wrote: > On 11/04/2013 10:27 PM, Matt Turner wrote: >> Also basically a revert of 6533d757 to make the cosh test match. > > Wait, I rescind my review of this patch...sorry. > > outerProduct, transpose, determinant, and inver

Re: [Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-05 Thread Matt Turner
On Tue, Nov 5, 2013 at 10:09 AM, Dylan Baker wrote: > I'm kicking for something brainless to do, are these generators laying around > somewhere? I'll have a look at how hard it would be to convert them to python. Yes, the four I had to touch for this are ./tests/spec/glsl-1.10/variable-index-wri

Re: [Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-05 Thread Matt Turner
On Tue, Nov 5, 2013 at 9:38 AM, Ian Romanick wrote: > On 11/04/2013 10:18 PM, Matt Turner wrote: >> We'd like to shrink the window sizes of shader runner when running in >> simulation, and ortho tests make it difficult to reason about reducing >> the window size. >&

Re: [Piglit] [PATCH 3/7] shaders: Stop using ortho in glsl-const tests.

2013-11-05 Thread Matt Turner
On Tue, Nov 5, 2013 at 9:36 AM, Ian Romanick wrote: > On 11/04/2013 10:27 PM, Matt Turner wrote: >> Scripted with sed with fix ups to >> - not - actually writes .w component, so probe rgba. >> - reflect - writes const 1.0 .w component, so probe rgb. >> - cosh - wr

[Piglit] [PATCH 7/7] glsl-1.20: Print generated outerProduct test names.

2013-11-04 Thread Matt Turner
--- tests/spec/glsl-1.20/execution/outerProduct-const.sh | 2 ++ tests/spec/glsl-1.20/execution/outerProduct.sh | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/spec/glsl-1.20/execution/outerProduct-const.sh b/tests/spec/glsl-1.20/execution/outerProduct-const.sh index 508aa4a..9

[Piglit] [PATCH 5/7] glsl-1.20: Don't use ortho in outerProduct tests.

2013-11-04 Thread Matt Turner
--- tests/spec/glsl-1.20/execution/outerProduct-const.sh | 16 tests/spec/glsl-1.20/execution/outerProduct.sh | 11 ++- 2 files changed, 6 insertions(+), 21 deletions(-) diff --git a/tests/spec/glsl-1.20/execution/outerProduct-const.sh b/tests/spec/glsl-1.20/execut

[Piglit] [PATCH 4/7] glsl-1.10 / glsl-1.20: Don't use ortho in variable indexing tests.

2013-11-04 Thread Matt Turner
Using ortho makes shrinking the window size much more difficult, which makes running tests in simulation take much longer. --- tests/spec/glsl-1.10/variable-index-read.sh | 18 +++--- tests/spec/glsl-1.10/variable-index-write.sh | 17 +++-- 2 files changed, 6 insertions(+)

[Piglit] [PATCH 6/7] glsl-1.10 / glsl-1.20: Print generated variable-index test names.

2013-11-04 Thread Matt Turner
--- tests/spec/glsl-1.10/variable-index-read.sh | 64 +--- tests/spec/glsl-1.10/variable-index-write.sh | 64 +--- 2 files changed, 96 insertions(+), 32 deletions(-) diff --git a/tests/spec/glsl-1.10/variable-index-read.sh b/tests/spec/glsl-1.10/v

[Piglit] [PATCH 2/7] shaders: Remove #version from glsl-const tests.

2013-11-04 Thread Matt Turner
Also basically a revert of 6533d757 to make the cosh test match. --- tests/shaders/glsl-const-builtin-abs.shader_test | 1 - tests/shaders/glsl-const-builtin-acos.shader_test | 1 - tests/shaders/glsl-const-builtin-all.shader_test | 1 - tests/shaders/glsl-con

[Piglit] [PATCH 3/7] shaders: Stop using ortho in glsl-const tests.

2013-11-04 Thread Matt Turner
Scripted with sed with fix ups to - not - actually writes .w component, so probe rgba. - reflect - writes const 1.0 .w component, so probe rgb. - cosh - writes const 1.0 .w component, and used probe rgb with 4 components, so drop the .w from the probe. --- tests/shaders/glsl-const-builtin-ab

[Piglit] [PATCH 1/7] glsl-1.10: Delete bogus generated test.

2013-11-04 Thread Matt Turner
--- .../#fs-temp-array-mat2-index-col-wr.shader_test# | 97 -- 1 file changed, 97 deletions(-) delete mode 100644 tests/spec/glsl-1.10/execution/variable-indexing/#fs-temp-array-mat2-index-col-wr.shader_test# diff --git a/tests/spec/glsl-1.10/execution/variable-indexing/#f

[Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-04 Thread Matt Turner
We'd like to shrink the window sizes of shader runner when running in simulation, and ortho tests make it difficult to reason about reducing the window size. The following patches fix some tests and test generators to use non-ortho projections instead. This should allow us to shrink these tests' w

Re: [Piglit] [PATCH 1/2 v2] genclbuiltins.py: Add two new function types.

2013-11-03 Thread Matt Turner
On Thu, Oct 31, 2013 at 9:20 AM, Yi Sun wrote: > Sometimes we should handle scalar/vector types separately. > For example some builtin functions only support scalar type input, > and some relational builtin functions get different results between > scalar and vector type though with the same value

Re: [Piglit] Python 2.7.4/5 bad file descriptor bug should be fixed soon

2013-10-26 Thread Matt Turner
On Thu, Oct 24, 2013 at 10:51 PM, Kenneth Graunke wrote: > A number of people (at least me, cworth, and ajax) have been hitting a > bug where tests randomly fail with a "Bad file descriptor" error. It > only occurs with Python 2.7.4 and 2.7.5. Other people have strangely > not been affected. > >

Re: [Piglit] [PATCH v2 2/3] arb_texture_storage: Update test requirements

2013-10-16 Thread Matt Turner
On Wed, Oct 16, 2013 at 4:43 PM, Ian Romanick wrote: > On 10/16/2013 04:38 PM, Matt Turner wrote: >> On Wed, Oct 16, 2013 at 3:51 PM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> The test uses 3D textures which were not part of OpenGL until 1.2. This

Re: [Piglit] [PATCH v2 2/3] arb_texture_storage: Update test requirements

2013-10-16 Thread Matt Turner
y")) { > X(test_cube_array_texture(), "cube array texture"); > } > -- > 1.8.1.4 Can we return PIGLIT_SKIP for a subtest? That seems better than not reporting anything. With that, Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2 1/3] arb_texture_storage: Use piglit idoms

2013-10-16 Thread Matt Turner
ase on top of 3c21a59. Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] arb_texture_storage: Use piglit idoms

2013-10-16 Thread Matt Turner
y: Ian Romanick > Cc: Matt Turner > Cc: Corey Richardson > Cc: Jon Ashburn > --- Note the conflict between this and Brian's "[PATCH] arb_texture_storage: add some cube map error tests" sent a couple of days ago. Probably should just base this on Brian's patch

Re: [Piglit] [PATCH] ARB_texture_view: Add test suite

2013-10-16 Thread Matt Turner
On Wed, Oct 16, 2013 at 12:58 PM, Jon Ashburn wrote: > Matt: > > Thanks for clarification, I understand now why the test is in > arb_texture_view directory and the purpose it serves. I still think testing > TEXTURE_IMMUTABLE_LEVELS and TEXTURE_VIEW_NUM_LEVELS after a glTextureView() > is good add

Re: [Piglit] [PATCH] ARB_texture_view: Add test suite

2013-10-16 Thread Matt Turner
On Wed, Oct 16, 2013 at 12:30 PM, Jon Ashburn wrote: > I am not sure why the texture-immutable-levels.c file is in the > arb_texture_view directory since > it doesn't actually call glTextureView(). Should it be in the > arb_texture_storage directory instead? The background is that ES 3 adds TEXT

Re: [Piglit] [PATCH] ARB_texture_view: Add query tests for gl state effected by this extension

2013-10-15 Thread Matt Turner
On Mon, Oct 14, 2013 at 3:53 PM, Jon Ashburn wrote: > Tests the queryable state from ARB_texture_view extension is correct. > Includes GL_TEXTURE_IMMUTABLE_LEVELS,GL_TEXTURE_VIEW_MIN_LEVEL, > GL_TEXTURE_VIEW_NUM_LEVELS, GL_TEXTURE_IMMUTABLE_FORMAT. texture-immutable-levels.c already tests GL_TEX

Re: [Piglit] [PATCH] ARB_texture_view: Add test suite

2013-10-15 Thread Matt Turner
On Mon, Oct 14, 2013 at 2:31 PM, Jon Ashburn wrote: > diff --git a/tests/spec/arb_texture_view/CMakeLists.gl.txt > b/tests/spec/arb_texture_view/CMakeLists.gl.txt > index c400759..293ef72 100644 > --- a/tests/spec/arb_texture_view/CMakeLists.gl.txt > +++ b/tests/spec/arb_texture_view/CMakeLists.g

Re: [Piglit] [PATCH] built-in-constants: don't try to create GS with version < 150.

2013-10-13 Thread Matt Turner
_SHADER); > > - if (glsl_version >= 150) > + if (required_glsl_version >= 150) > test_gs = glCreateShader(GL_GEOMETRY_SHADER); > > for (i = 0; i < num_tests; i++) { > -- > 1.8.4 Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] Change INVALID_VALUE to INVALID_OPERATION in ARB_vertex_array_bgra test.

2013-10-11 Thread Matt Turner
From: Kenneth Graunke In the OpenGL 3.3 specification, this changed from INVALID_VALUE to INVALID_OPERATION. According to Ian Romanick, the GL specification provides the guidance that INVALID_VALUE should be generated for "Numeric argument out of range". Since FALSE is in range for a boolean, I

Re: [Piglit] [PATCH 1/2] arb_seamless_cube_map: Fix a spurious test fail on non-GLSL-130 drivers.

2013-10-09 Thread Matt Turner
On Wed, Oct 9, 2013 at 1:33 PM, Eric Anholt wrote: > --- Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 5/5] arb_texture_query_levels: add execution tests

2013-10-04 Thread Matt Turner
GL_ARB_texture_query_levels > + > +[vertex shader] > +in vec4 vertex; > + > +void main() { > +gl_Position = vertex; > +} Use [vertex shader passthrough] instead? I guess we don't have any tests for 3D, cube, or shadow textures because shader runne

[Piglit] [PATCH] arb_shader_bit_encoding: Generate tests for 3.30, not 4.00.

2013-10-02 Thread Matt Turner
I was generating GLSL 4.00 tests because that's when ARB_gpu_shader5 functionality was folded in, but 3.30 is actually the first version with the bit encoding functions. --- generated_tests/gen_shader_bit_encoding_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gen

Re: [Piglit] [PATCH 5/8] cmake: Increase minimum version from 2.6 to 2.8.

2013-10-02 Thread Matt Turner
On Tue, Oct 1, 2013 at 6:42 PM, Dylan Baker wrote: > On Tuesday, October 01, 2013 05:13:52 PM Ken Phillis Jr wrote: >> The use of cmake 2.8 just happens to coincide with requiring slightly newer >> tools... see these release announcements... >> kitware - news: cmake 2.8.11 released ( May 22, 2013

Re: [Piglit] [PATCH] egl_khr_create_context: Test the debug flag (v2)

2013-10-01 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] egl_khr_create_context: Test the debug flag

2013-10-01 Thread Matt Turner
On Tue, Oct 1, 2013 at 3:51 PM, Chad Versace wrote: > Argh. The lack of ES1 dispatch makes the test skip on ES1. Oops. > > Seeing that the only GL functions used here are glGetString and > glGetIntegerv, > I think it's safe to lie to piglit_dispatch_init by requesting ES2 dispatch. > I tried this,

Re: [Piglit] [PATCH 1/3] egl_khr_create_context: Fix tests for invalid flags

2013-10-01 Thread Matt Turner
On Tue, Oct 1, 2013 at 3:06 PM, Chad Versace wrote: > On 10/01/2013 02:49 PM, Matt Turner wrote: >> >> On Fri, Sep 20, 2013 at 7:02 PM, Chad Versace >> wrote: >>> >>> According to version 15 of the EGL_KHR_create_context spec, >>> EGL_CONTEXT_OP

Re: [Piglit] [PATCH 1/3] egl_khr_create_context: Fix tests for invalid flags

2013-10-01 Thread Matt Turner
(flag & invalid_flags) { > pass = pass && try_flag(flag); > flag >>= 1; > } > -- > 1.8.3.1 Although the code seems a bit silly doing this while (flag != first_valid_flag) when first_valid_flag is c

Re: [Piglit] [PATCH 2/3] util/egl: Add piglit_egl_bind_api()

2013-10-01 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] egl_khr_create_context: Test the debug flag

2013-10-01 Thread Matt Turner
NTEXT, attribs); > + if (!ctx) { > + if (piglit_check_egl_error(EGL_BAD_MATCH)) { > + piglit_report_result(PIGLIT_SKIP); > + } else { > + piglit_report_result(PIGLIT_FAIL); > + } &g

Re: [Piglit] [PATCH] arb_explicit_location: Add tests without the extension enabled

2013-09-26 Thread Matt Turner
Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 11/12] arb_gpu_shader5: Test using only the lsb from imulExtended in the vs.

2013-09-25 Thread Matt Turner
--- .../vs-imulExtended-only-lsb.shader_test | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-imulExtended-only-lsb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 12/12] arb_gpu_shader5: Test using only the msb from imulExtended in the vs.

2013-09-25 Thread Matt Turner
--- .../vs-imulExtended-only-msb.shader_test | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-imulExtended-only-msb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 09/12] arb_gpu_shader5: Test using only the msb from umulExtended in the vs.

2013-09-25 Thread Matt Turner
--- .../vs-umulExtended-only-msb.shader_test | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-umulExtended-only-msb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 10/12] arb_gpu_shader5: Add imulExtended vertex shader execution test.

2013-09-25 Thread Matt Turner
--- .../built-in-functions/vs-imulExtended.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-imulExtended.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-im

[Piglit] [PATCH 05/12] arb_gpu_shader5: Test using only the lsb from imulExtended in the fs.

2013-09-25 Thread Matt Turner
--- .../fs-imulExtended-only-lsb.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-imulExtended-only-lsb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 06/12] arb_gpu_shader5: Test using only the msb from imulExtended in the fs.

2013-09-25 Thread Matt Turner
--- .../fs-imulExtended-only-msb.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-imulExtended-only-msb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 07/12] arb_gpu_shader5: Add umulExtended vertex shader execution test.

2013-09-25 Thread Matt Turner
--- .../built-in-functions/vs-umulExtended.shader_test | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-umulExtended.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-um

[Piglit] [PATCH 08/12] arb_gpu_shader5: Test using only the lsb from umulExtended in the vs.

2013-09-25 Thread Matt Turner
--- .../vs-umulExtended-only-lsb.shader_test | 47 ++ 1 file changed, 47 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-umulExtended-only-lsb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 02/12] arb_gpu_shader5: Test using only the lsb from umulExtended in the fs.

2013-09-25 Thread Matt Turner
--- .../fs-umulExtended-only-lsb.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-umulExtended-only-lsb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 03/12] arb_gpu_shader5: Test using only the msb from umulExtended in the fs.

2013-09-25 Thread Matt Turner
--- .../fs-umulExtended-only-msb.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-umulExtended-only-msb.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functi

[Piglit] [PATCH 01/12] arb_gpu_shader5: Add umulExtended fragment shader execution test.

2013-09-25 Thread Matt Turner
--- .../built-in-functions/fs-umulExtended.shader_test | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-umulExtended.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-um

[Piglit] [PATCH 04/12] arb_gpu_shader5: Add imulExtended fragment shader execution test.

2013-09-25 Thread Matt Turner
--- .../built-in-functions/fs-imulExtended.shader_test | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-imulExtended.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-im

[Piglit] [PATCH 12/12] arb_gpu_shader5: Test using only the borrow from usubBorrow in the vs.

2013-09-23 Thread Matt Turner
--- .../vs-usubBorrow-only-borrow.shader_test | 56 ++ 1 file changed, 56 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-usubBorrow-only-borrow.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-funct

[Piglit] [PATCH 11/12] arb_gpu_shader5: Test using only the subtraction from usubBorrow in the vs.

2013-09-23 Thread Matt Turner
--- .../vs-usubBorrow-only-sub.shader_test | 56 ++ 1 file changed, 56 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-usubBorrow-only-sub.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-function

[Piglit] [PATCH 10/12] arb_gpu_shader5: Add usubBorrow vertex shader execution test.

2013-09-23 Thread Matt Turner
--- .../built-in-functions/vs-usubBorrow.shader_test | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-usubBorrow.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-usub

[Piglit] [PATCH 08/12] arb_gpu_shader5: Test using only the addition from uaddCarry in the vs.

2013-09-23 Thread Matt Turner
--- .../vs-uaddCarry-only-add.shader_test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-uaddCarry-only-add.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions

[Piglit] [PATCH 07/12] arb_gpu_shader5: Add uaddCarry vertex shader execution test.

2013-09-23 Thread Matt Turner
--- .../built-in-functions/vs-uaddCarry.shader_test| 65 ++ 1 file changed, 65 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-uaddCarry.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-uaddC

[Piglit] [PATCH 09/12] arb_gpu_shader5: Test using only the carry from uaddCarry in the vs.

2013-09-23 Thread Matt Turner
--- .../vs-uaddCarry-only-carry.shader_test| 62 ++ 1 file changed, 62 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/vs-uaddCarry-only-carry.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functio

[Piglit] [PATCH 05/12] arb_gpu_shader5: Test using only the subtraction from usubBorrow in the fs.

2013-09-23 Thread Matt Turner
--- .../fs-usubBorrow-only-sub.shader_test | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-usubBorrow-only-sub.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-function

[Piglit] [PATCH 06/12] arb_gpu_shader5: Test using only the borrow from usubBorrow in the fs.

2013-09-23 Thread Matt Turner
--- .../fs-usubBorrow-only-borrow.shader_test | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-usubBorrow-only-borrow.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-funct

[Piglit] [PATCH 04/12] arb_gpu_shader5: Add usubBorrow fragment shader execution test.

2013-09-23 Thread Matt Turner
--- .../built-in-functions/fs-usubBorrow.shader_test | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-usubBorrow.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-usub

[Piglit] [PATCH 03/12] arb_gpu_shader5: Test using only the carry from uaddCarry in the fs.

2013-09-23 Thread Matt Turner
--- .../fs-uaddCarry-only-carry.shader_test| 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-uaddCarry-only-carry.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functio

[Piglit] [PATCH 02/12] arb_gpu_shader5: Test using only the addition from uaddCarry in the fs.

2013-09-23 Thread Matt Turner
--- .../fs-uaddCarry-only-add.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-uaddCarry-only-add.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions

[Piglit] [PATCH 01/12] arb_gpu_shader5: Add uaddCarry fragment shader execution test.

2013-09-23 Thread Matt Turner
--- .../built-in-functions/fs-uaddCarry.shader_test| 55 ++ 1 file changed, 55 insertions(+) create mode 100644 tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-uaddCarry.shader_test diff --git a/tests/spec/arb_gpu_shader5/execution/built-in-functions/fs-uaddC

Re: [Piglit] [PATCH] oes_matrix_get: Add basic test for GL_OES_matrix_get

2013-09-10 Thread Matt Turner
On Tue, Sep 10, 2013 at 1:46 PM, Ian Romanick wrote: > This is an OpenGL ES 1.x extension that Mesa has advertised for quite > some time. However, it appears that there is *no* code in Mesa to back > that up! bfa66bd6 added it the extension string, as far as I can tell, in Sept 2009. ___

[Piglit] [PATCH] mesa_shader_integer_mix: Add tests for mix on integers and bools.

2013-09-09 Thread Matt Turner
Reviewed-by: Paul Berry --- Is there a way to have these tests run under Desktop GL and ES without duplicating the whole test except for the [require]? tests/all.tests| 6 +++ .../execution/fs-mix-bvec4.shader_test | 33 + .../exec

[Piglit] [PATCH] mesa_shader_integer_mix: Add tests for mix on integers and bools.

2013-09-09 Thread Matt Turner
Reviewed-by: Paul Berry --- tests/all.tests| 6 .../execution/fs-mix-bvec4.shader_test | 36 +++ .../execution/fs-mix-ivec4.shader_test | 36 +++ .../execution/fs-mix-uvec4.shader_test |

Re: [Piglit] [PATCH] mesa_shader_integer_mix: Add tests for mix on integers and bools.

2013-09-09 Thread Matt Turner
That's a good point. I'll make that change. Thanks! ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] gs: less demanding tests for triangle strips.

2013-09-09 Thread Matt Turner
On Mon, Sep 9, 2013 at 9:44 AM, Paul Berry wrote: > On 5 September 2013 17:52, Matt Turner wrote: >> >> On Wed, Aug 28, 2013 at 1:59 PM, Paul Berry >> wrote: >> > +[vertex shader] >> > +#version 150 >> >> We don't need to specify the #

[Piglit] [PATCH] mesa_shader_integer_mix: Add tests for mix on integers and bools.

2013-09-06 Thread Matt Turner
--- tests/all.tests| 6 .../execution/fs-mix-bvec4.shader_test | 36 +++ .../execution/fs-mix-ivec4.shader_test | 36 +++ .../execution/fs-mix-uvec4.shader_test | 36 +++ .

Re: [Piglit] [PATCH] gs: less demanding tests for triangle strips.

2013-09-05 Thread Matt Turner
r you meant the triangle 1-2-3, or 1-3-5. From the comment and picture I'd have thought the first, and from the code I'd have thought the second. Both, as it turn out are clockwise. Once I understand that, Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] Test bad interaction with optimizer and a uniform array as a function argument.

2013-09-05 Thread Matt Turner
These test that a uniform array used only as a function argument is not improperly optimized out or has its length reduced. v2: Use shader_tests to catch bug under non-debug builds. Cc: Dominik Behr Reported-by: Dominik Behr --- ...ax-array-access-forward-declaration.shader_test | 30 ++

Re: [Piglit] [PATCH] xfb: Fix max_varyings/max_xfb_varyings mix-up.

2013-09-03 Thread Matt Turner
ryings; row++) { > for (col = 0; col < max_varyings - row; col++) { > GLboolean ok; > float green[3] = {0.0, 1.0, 0.0}; > -- > 1.8.4 Reviewed-by: Matt Turner ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

<    1   2   3   4   5   >