[Piglit] [PATCH 5/6] glsl-1.20: Add tests for uniform structures with initializers

2012-05-16 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com It was just impractical to generate these tests using scripts, so they are hand-written. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- .../uniform-initializer/fs-structure.shader_test | 44 .../uniform-initializer

[Piglit] [PATCH 0/5] Initial GLX_ARB_create_context_profile and GLX_EXT_create_context_es2_profile tests

2012-06-12 Thread Ian Romanick
(Apologies to people on CC who received this twice. I mistyped the address for the piglit list the first time.) This is an initial set of tests for GLX_ARB_create_context_profile and GLX_EXT_create_context_es2_profile. These tests just verify that the GLX API generates the correct errors and

[Piglit] [PATCH 1/5] glx_arb_create_context_profile: Verify that invalid profiles are rejected

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com NVIDIA's closed-source driver passes this test. AMD's closed-source driver has not been tested. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests|4 + .../spec/glx_arb_create_context

[Piglit] [PATCH 2/5] glx_arb_create_context_profile: Verify that the core profile is supported for OpenGL 3.2

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com NVIDIA's closed-source driver passes this test. AMD's closed-source driver has not been tested. NVIDIA's closed-source driver supports both core and compatibility profiles. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests

[Piglit] [PATCH 4/5] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The spec doesn't forbid indirect rendering with OpenGL ES 2.0. There's no protocol defined, so it seems impossible that this could ever work. NVIDIA's closed-source driver fails this test. An indirect-rendering ES2 context is created. I have

Re: [Piglit] [PATCH 4/5] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

2012-06-12 Thread Ian Romanick
On 06/12/2012 02:56 PM, James Jones wrote: On 6/12/12 2:47 PM, Ian Romanick wrote: On 06/12/2012 02:35 PM, James Jones wrote: On 6/12/12 2:25 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com The spec doesn't forbid indirect rendering with OpenGL ES 2.0. There's no protocol

Re: [Piglit] [PATCH 5/5] glx_ext_create_context_es2_profile: Verify that the invalid ES versions are rejected

2012-06-12 Thread Ian Romanick
On 06/12/2012 02:40 PM, James Jones wrote: On 6/12/12 2:25 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com NVIDIA's closed-source driver fails this test. GLXBadProfileARB is generated instead of BadMatch. The specification isn't specific about what error should

Re: [Piglit] [PATCH 1/6] glsl-1.20 / glsl-1.30: Add tests for uniforms with initializers

2012-06-12 Thread Ian Romanick
On 06/12/2012 03:02 PM, Paul Berry wrote: On 21 May 2012 14:10, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org wrote: On 05/21/2012 10:34 AM, Paul Berry wrote: On 16 May 2012 14:23, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org

Re: [Piglit] [PATCH 1/3] Transform feedback: Stop using wrapper functions.

2012-07-03 Thread Ian Romanick
stops using the wrapper functions; the next patch will remove them. Death to the wrappers! Acked-by: Ian Romanick ian.d.roman...@intel.com --- tests/spec/ext_transform_feedback/alignment.c | 13 ++--- tests/spec/ext_transform_feedback/api-errors.c | 16

[Piglit] [PATCH 0/7] Initial GLX_ARB_create_context_profile, GLX_EXT_create_context_es2_profile, and GLX_ARB_create_context_robustness tests

2012-07-04 Thread Ian Romanick
This is an initial set of tests for GLX_ARB_create_context_profile, GLX_EXT_create_context_es2_profile, and GLX_ARB_create_context_robustness. These tests just verify that the GLX API generates the correct errors and allows certain required things to work. Since these tests share a lot of

[Piglit] [PATCH] oes_standard_derivatives: Add touch tests for the extension

2012-07-16 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Make sure that all the functions are available when they should be. This is currently broken in Mesa. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 --- tests/all.tests

[Piglit] [PATCH] arb_texture_buffer_object: Verify some behavior when the extenion isn't supported

2012-07-26 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com If the extension is not supported, applications should not be able to bind to the texture target or the buffer object target. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- This currently fails on Mesa, and I'm working on a fix. It's

Re: [Piglit] [PATCH 03/11] egl_khr_create_context: Add common test infrastructure

2012-08-01 Thread Ian Romanick
On 07/31/2012 06:38 PM, Matt Turner wrote: --- tests/all_egl.tests|3 + tests/egl/CMakeLists.gl.txt|2 + tests/egl/spec/CMakeLists.txt |1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt | 14 ++

Re: [Piglit] [PATCH 04/11] egl_khr_create_context: Verify default major version is 1

2012-08-01 Thread Ian Romanick
On 07/31/2012 06:38 PM, Matt Turner wrote: --- tests/all_egl.tests|1 + .../spec/egl_khr_create_context/CMakeLists.gl.txt |2 + .../egl_khr_create_context/default-major-version.c | 84 3 files changed, 87 insertions(+), 0

Re: [Piglit] [PATCH] texturing: add full round trip test of array depth textures.

2012-08-27 Thread Ian Romanick
the coordinate transformations involved in cube map texture lookup. Sorry for the lag... Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests |1 + tests/texturing/CMakeLists.gl.txt |1 + tests/texturing/array-depth-roundtrip.c | 203

Re: [Piglit] [PATCH] gtf: Update EGLConfig ID

2012-10-09 Thread Ian Romanick
On 10/09/2012 09:01 AM, Kenneth Graunke wrote: On 10/09/2012 07:57 AM, Chad Versace wrote: On 10/08/2012 03:40 PM, Kenneth Graunke wrote: On 10/08/2012 03:21 PM, Chad Versace wrote: The mesa commit 7dc0be8 changed the EGLConfig ID's for the Intel driver, and piglit's GTF integration hardcodes

Re: [Piglit] [PATCH 1/4] egl: Fix typo in piglit_expect_egl_error

2012-10-09 Thread Ian Romanick
The series is: Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 10/08/2012 04:57 PM, Matt Turner wrote: --- tests/util/piglit-util-egl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/util/piglit-util-egl.c b/tests/util/piglit-util-egl.c index 5de290a

Re: [Piglit] [PATCH] Add a test for GLES2 using GL_EXT_unpack_subimage with GL_BGRA_EXT

2012-10-09 Thread Ian Romanick
On 10/05/2012 03:27 AM, Neil Roberts wrote: Eric Anholt e...@anholt.net writes: If this is testing GL_EXT_unpack_subimage, it should go in tests/spec/gl_ext_unpack_subimage/ It's not really testing GL_EXT_unpack_subimage but is testing a specific bug in the Intel driver when uploading a

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-16 Thread Ian Romanick
On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless, but also we'd end up with the RGBX framebuffer config mostly untested. While

[Piglit] [PATCH] glx: Sanity check the various GLX extension strings that an app can query

2012-10-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56057 --- tests/all.tests | 2 + tests/glx/CMakeLists.gl.txt | 2 + tests/glx/glx-string-sanity.c | 187

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-10-19 Thread Ian Romanick
On 10/17/2012 09:42 AM, Chad Versace wrote: On 10/16/2012 05:12 PM, Ian Romanick wrote: On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test

Re: [Piglit] [PATCH 2/2] GL_ARB_occlusion_query2: Add tests for the API.

2012-10-19 Thread Ian Romanick
On 10/19/2012 11:13 AM, Eric Anholt wrote: Apparently I added Mesa support for it without adding tests, and shockingly the Mesa support was broken. Of course. :) Other than a small nit below, this patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests

Re: [Piglit] [PATCH 1/2] GLX_OML_sync_control: Add new tests.

2012-10-19 Thread Ian Romanick
On 10/19/2012 11:13 AM, Eric Anholt wrote: I was going to go touch this code in Mesa, then I realised that we didn't have a single test for it. v2: Rebase on Chad's BUILD_* sedjob, and explicitly test various swap intervals. A couple comments below... --- tests/all.tests

Re: [Piglit] [PATCH 3/4] glx_arb_create_context/core-profile: Remove extra newline

2012-10-19 Thread Ian Romanick
On 10/12/2012 01:42 PM, Matt Turner wrote: --- tests/spec/glx_arb_create_context/core-profile.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tests/spec/glx_arb_create_context/core-profile.c b/tests/spec/glx_arb_create_context/core-profile.c index

Re: [Piglit] [PATCH 1/3] all.tests: move all tests from general into spec

2012-10-23 Thread Ian Romanick
On 10/23/2012 06:25 AM, Marek Olšák wrote: --- tests/all.tests | 265 +++ 1 files changed, 149 insertions(+), 116 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 341d021..a260073 100644 --- a/tests/all.tests +++

Re: [Piglit] [PATCH] Add a test for ARB_map_buffer_alignment

2012-10-29 Thread Ian Romanick
On 10/28/2012 09:55 AM, Marek Olšák wrote: There's one other case that's important to test: GL_WRITE_ONLY mapping of a buffer in-use by the GPU. On at least some implementations, this would cause a temporary buffer to be allocated using malloc and returned to the application. See also my

Re: [Piglit] [PATCH 1/3] texgrad: use glFrustum() instead of gluPerspective()

2012-10-29 Thread Ian Romanick
On 10/29/2012 08:04 AM, Brian Paul wrote: I think any implementation that can do ARB_fragment_program can also do OpenGL 1.4. Does this remove all of the GLU dependencies? The series is: Reviewed-by: Ian Romanick ian.d.roman...@intel.com To remove dependency on glu.h

Re: [Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-06 Thread Ian Romanick
On 11/05/2012 02:53 PM, Chad Versace wrote: In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel Sandybridge. CC: Matt Turner matts...@gmail.com ---

Re: [Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-06 Thread Ian Romanick
On 11/06/2012 12:51 PM, Chad Versace wrote: On 11/06/2012 12:19 PM, Ian Romanick wrote: On 11/05/2012 02:53 PM, Chad Versace wrote: In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel

Re: [Piglit] [PATCH 2/2] egl: Add more cases to egl-create-context-invalid-gl-version

2012-11-08 Thread Ian Romanick
On 11/08/2012 11:00 AM, Chad Versace wrote: Fails on mesa-a196f43 with Intel Sandybridge with: Created OpenGL ES1 context with invalid version 3.9 CC: Ian Romanick i...@freedesktop.org CC: Matt Turner matts...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl

Re: [Piglit] [PATCH] egl: Add test egl-create-context-verify-gl-flavor

2012-11-08 Thread Ian Romanick
On 11/08/2012 01:20 PM, Ian Romanick wrote: On 11/08/2012 10:19 AM, Chad Versace wrote: This test requests various flavors (that is, api and version and profile) of contexts and verifies that the context's actual flavor is compatible with the requested flavor. The following subcases fail

Re: [Piglit] [PATCH 1/2] util/egl: Change piglit_expect_egl_error to return a bool

2012-11-13 Thread Ian Romanick
equivalent. CC: Ian Romanick i...@freedesktop.org Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/egl-query-surface.c | 15 +++ tests/egl/spec/egl_khr_create_context/core-profile.c

Re: [Piglit] [PATCH 1/2] util: Kill macro glewInit

2012-11-13 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/general/windowoverlap.c | 2 +- tests/glean/tbase.h | 2 +- tests/glx/glx-copy-sub-buffer.c

Re: [Piglit] [PATCH 2/2] egl: Add more cases to egl-create-context-invalid-gl-version

2012-11-13 Thread Ian Romanick
On 11/09/2012 11:58 AM, Chad Versace wrote: On 11/08/2012 01:29 PM, Ian Romanick wrote: On 11/08/2012 11:00 AM, Chad Versace wrote: Fails on mesa-a196f43 with Intel Sandybridge with: Created OpenGL ES1 context with invalid version 3.9 CC: Ian Romanick i...@freedesktop.org CC: Matt Turner

[Piglit] [PATCH 0/5] Enable shader tests to run on 3.1 without GL_ARB_compatibility

2012-11-13 Thread Ian Romanick
Right now Mesa and Apple only expose GL versions 3.0 without the GL_ARB_compatilibity extension. This means that applications that want, say, OpenGL 3.1 so that they can test GLSL 1.40 have to specifically ask for OpenGL 3.1. This series modifies shader_runner and glslparser test to request a

[Piglit] [PATCH 1/5] shader_runner: Refactor version comparisons

2012-11-13 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/shaders/shader_runner.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index f0037c1

[Piglit] [PATCH 3/5] shader_runner: Set a VAO in a GL 3.1 context

2012-11-13 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There's no default VAO (without GL_ARB_compatibility), so we have to create and bind one. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/shaders/shader_runner.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

[Piglit] [PATCH 4/5] shader_runner: Partially process the requirements section before creating the context

2012-11-13 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com A test script can require a specific GLSL version or a specific GL version. To satisfy this requirement, the piglit framework code needs to know about the requirement before creating the context. However, the requirements section can contain other

[Piglit] [PATCH 5/5] glslparsertest: Use specified GLSL version to select API version

2012-11-13 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/glslparsertest/glslparsertest.c | 37 +-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/tests/glslparsertest/glslparsertest.c b/tests

Re: [Piglit] [PATCH] Add test glsl-uniform-out-of-bounds-2.c

2012-11-14 Thread Ian Romanick
On 11/05/2012 11:39 AM, Frank Henigman wrote: This test shows the problem fixed by my add bounds checking for uniform array access patch, sent to mesa-dev on Nov. 2. Check behavior of glGetUniformLocation, glGetUniform and glUniform(Matrix) when attempting to access non-existent array elements.

Re: [Piglit] GLES

2012-11-14 Thread Ian Romanick
On 11/14/2012 12:11 PM, Tom Gall wrote: Hi All, I've an interest in using piglit for GLES testing on ARM for both linux and android. I've noticed that things are a bit light in the GLES test department. That is something of an understatement. :) Which version of GLES do you want to test?

Re: [Piglit] [PATCH 2/5] shader_runner: Use integers for GL and GLSL versions

2012-11-14 Thread Ian Romanick
On 11/14/2012 01:18 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com In floating point, 3.1 is actually 3.09, and that's just awsome for comparing GL versions. + sscanf(line, %u.%u, major, minor

Re: [Piglit] [PATCH 2/2] egl: Add test egl-create-context-verify-gl-flavor (v2)

2012-11-14 Thread Ian Romanick
On 11/14/2012 08:29 AM, Chad Versace wrote: On 11/13/2012 04:36 PM, Ian Romanick wrote: On 11/09/2012 11:45 AM, Chad Versace wrote: This test requests various flavors (that is, api and version and profile) of contexts and verifies that the context's actual flavor is compatible

Re: [Piglit] [PATCH 4/5] shader_runner: Partially process the requirements section before creating the context

2012-11-16 Thread Ian Romanick
On 11/16/2012 11:08 AM, Chad Versace wrote: On 11/13/2012 05:00 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com A test script can require a specific GLSL version or a specific GL version. To satisfy this requirement, the piglit framework code needs to know about

[Piglit] [PATCH 1/3] glslparsertest: Use integers for GL and GLSL versions

2012-11-16 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com I haven't observed any failures with this yet. Since we just did the same thing with shader_runner, it seems like a good idea. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/glslparsertest/glslparsertest.c | 54

[Piglit] [PATCH 2/3] glslparsertest: Add support for GLSL ES 3.0 via GL_ARB_ES3_compatibility

2012-11-16 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/glslparsertest/glslparsertest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/glslparsertest/glslparsertest.c b/tests/glslparsertest/glslparsertest.c index 4620b4e..14a7a13

[Piglit] [PATCH 1/4] glsl-es-3.00: Check array sizing rules in GLSL ES 3.00.

2012-11-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Mesa currently fails array-sized-by-initializer.vert. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- .../compiler/array-sized-by-initializer.vert | 31 ++ .../compiler/no-unsized-arrays-01.vert | 25

[Piglit] [PATCH 2/4] glsl-es-3.00: Add test for line continuation

2012-11-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- .../glsl-es-3.00/compiler/line-continuation.vert | 27 ++ 1 file changed, 27 insertions(+) create mode 100644 tests/spec/glsl-es-3.00/compiler/line-continuation.vert diff

Re: [Piglit] [PATCH 1/3] egl-create-context-verify-gl-flavor: Test GLES3

2012-11-20 Thread Ian Romanick
The series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- .../egl/spec/egl_khr_create_context/verify-gl-flavor.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/egl/spec/egl_khr_create_context/verify-gl-flavor.c b/tests/egl/spec/egl_khr_create_context

Re: [Piglit] [PATCH 0/3] Add OpenGL ES3 support

2012-11-20 Thread Ian Romanick
On 11/15/2012 11:10 AM, Chad Versace wrote: The series adds support for OpenGL ES3 to the piglit_gl_framework. The series doesn't add any GLES3 tests, just support for the API. Do you have a test case in hand to be sure your changes actually work? Chad Versace (3): util/gl: Add config

[Piglit] [PATCH] glsl-1.10: Add test for structure with same-name fields

2012-11-27 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This is related to the WebGL shader-with-non-reserved-words tests. Several of these tests use name that are reserved words in other GLSL versions as variable names, structure names, structure field names, and function names. Some of the cases use

[Piglit] [PATCH] glsl-1.10: Verify that impossible GLSL versions are properly rejected

2012-11-30 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Currently on Mesa's gles3 branch this leads to an assertion failure. It works correctly on Mesa master and known Mesa releases. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- I'm not sure this is the right place for this test script to live

Re: [Piglit] [PATCH 12/13] all.tests: Add all tests *.shader_test_gles3

2012-12-04 Thread Ian Romanick
On 12/03/2012 09:59 PM, Chad Versace wrote: all.tests already auto-detects all files named *.shader_test, and runs them with shader_runner. This patch does the same for files *.shader_test_gles3 and runs them with shader_runner_gles3. Yuck. :( It seems like the python script could grep for

Re: [Piglit] [PATCH 12/13] all.tests: Add all tests *.shader_test_gles3

2012-12-04 Thread Ian Romanick
On 12/03/2012 09:59 PM, Chad Versace wrote: all.tests already auto-detects all files named *.shader_test, and runs them with shader_runner. This patch does the same for files *.shader_test_gles3 and runs them with shader_runner_gles3. Yuck. :( It seems like the python script could grep for

Re: [Piglit] [PATCH 10/13] shader_runner: Add GLES workarounds

2012-12-04 Thread Ian Romanick
Gak! Sorry for the multiple sends. My mailer kept telling me that delivery failed, and asked if I wanted to resend. Apparently it was full of crap. :( On 12/04/2012 05:43 PM, Ian Romanick wrote: On 12/03/2012 09:59 PM, Chad Versace wrote: Since piglit-dispatch does not yet support GLES

Re: [Piglit] [PATCH] Fix shell scripts that claim to run with /bin/sh but actually need /bin/bash.

2012-12-04 Thread Ian Romanick
On 12/04/2012 06:19 PM, Stuart Abercrombie wrote: With this change they run on, for instance the last 6 years of Ubuntu. Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/asmparsertest/make_test_list.sh |2 +- tests/asmparsertest/vp-tex.sh

Re: [Piglit] [PATCH 2/2] Fix the fs GLSL = version output by variable-index-write.sh.

2012-12-04 Thread Ian Romanick
On 12/04/2012 06:24 PM, Stuart Abercrombie wrote: It was incorrectly hardwired to 1.10, leading to contrdictory output. Oops. That was my mistake. I got the other place correct. :) Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/spec/glsl-1.10/variable-index-write.sh |2

[Piglit] [PATCH 1/2] arb_uniform_buffer_object: Add serveral tests related to block names

2012-12-08 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The spec says that the name of a uniform block is in the same scope as other symbols. Verify that. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Kenneth Graunke kenn...@whitecape.org --- .../compiler/block-name-clashes-with-function.vert

Re: [Piglit] [PATCH 2/2] gles-2.0: Check that ES 3 queries are not allowed in ES 2

2012-12-11 Thread Ian Romanick
On 12/11/2012 10:12 AM, Matt Turner wrote: On Tue, Dec 11, 2012 at 9:57 AM, Eric Anholt e...@anholt.net wrote: Matt Turner matts...@gmail.com writes: +void +piglit_init(int argc, char **argv) +{ + /* ES 3 adds many new queries over ES 2. This test confirms that ES 2 + * correctly

[Piglit] [PATCH 2/3] arb_internalformat_query: Verify that glGetInternalformativ does over-run the buffer

2012-12-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). Queries of GL_NUM_SAMPLE_COUNTS merrily write data even when bufSize is zero. Signed-off-by: Ian

[Piglit] [PATCH 3/3] arb_internalformat_query: Verify minimum maximums

2012-12-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test passes on NVIDIA's closed-source driver (version 304.64 on GTX260). This driver supports GL_ARB_texture_multisample. This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). Querying GL_SRGB8_ALPHA8 (for all targets

[Piglit] [PATCH 2/3] arb_get_program_binary: Execercise GL_PROGRAM_BINARY_RETRIEVABLE_HINT

2012-12-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test fails on NVIDIA's closed-source driver (version 304.64). It fails because the value of GL_PROGRAM_BINARY_RETRIEVABLE_HINT is not latched by glLinkProgram. The spec is a little unclear on this topic, and I have filed a bug in the Khronos

[Piglit] [PATCH 3/3] arb_get_program_binary: Add misc. API error tests for this extension

2012-12-11 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test fails on NVIDIA's closed-source driver (version 304.64): - GL_INVALID_VALUE is not generated for specifying values other than GL_TRUE or GL_FALSE for GL_PROGRAM_BINARY_RETRIEVABLE_HINT. - GL_INVALID_VALUE is not generated

[Piglit] Many shader_runner tests fail

2012-12-11 Thread Ian Romanick
A lot of shader_runner tests are failing with the message Failed to find [require] block. Could the default of requiring desktop GL + GLSL 1.10 please be restored? I haven't bisected, but I'm guessing that this happened when support for GLSL ES 3.00 was added...

Re: [Piglit] RFC: GLES2 shader tests

2012-12-11 Thread Ian Romanick
On 12/11/2012 12:23 PM, Tom Gall wrote: Hi, I've been looking at how to take advantage of the glslparsertest code so that it could be used for OpenGL ES 2 testing as well. Thought I'd ask for an opinion on versions for glsl on gles2. For gles2, should the lower bound of valid versions be

Re: [Piglit] [PATCH 2/3] arb_internalformat_query: Verify that glGetInternalformativ does over-run the buffer

2012-12-11 Thread Ian Romanick
On 12/11/2012 04:13 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: +/** + * \file overrun.c + * Verify that queries don't over-run the size of the supplied buffer. + */ + +#include piglit-util-gl-common.h + +PIGLIT_GL_TEST_CONFIG_BEGIN

Re: [Piglit] [PATCH 1/3] arb_internalformat_query: Add initial API error test for this extension

2012-12-11 Thread Ian Romanick
On 12/11/2012 04:03 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This driver supports GL_ARB_texture_multisample, but it does not support

Re: [Piglit] glslparser.tests?

2012-12-13 Thread Ian Romanick
On 12/13/2012 08:33 AM, Tom Gall wrote: Within many of the frags in tests/glslparsertest/shaders there is the following in the config section: // # NOTE: Config section was auto-generated from file // # NOTE: 'glslparser.tests' at git revision // # NOTE: 6cc17ae70b70d150aa1751f8e28db7b2a9bd50f0

Re: [Piglit] [PATCH v3 2/2] gles-2.0: Check that ES 3 queries are not allowed in ES 2

2012-12-13 Thread Ian Romanick
On 12/13/2012 10:25 AM, Matt Turner wrote: Reviewed-by: Eric Anholt e...@anholt.net (v2) Two minor nits below. With those fixed (no need to resubmit), Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- tests/spec/gles-2.0/CMakeLists.gles2.txt |2 + tests/spec/gles-2.0/invalid

[Piglit] [PATCH] arb_uniform_buffer: Fix block / field names in dlist test

2012-12-14 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Both the block name and the names of the individual variables in the block live at global scope. Therefore, they can't both have the same names. The GLSL 1.40 spec says: Uniform block names and variable names declared within uniform blocks

Re: [Piglit] [PATCH] Remove #version from variable indexing shader tests.

2012-12-14 Thread Ian Romanick
On 12/13/2012 10:00 AM, Stuart Abercrombie wrote: The idea is to ultimately remove explicit #version directives from all .shader_test files, so we can just rely on GLSL =, and then the ES analog, allowing these tests to run on GL or GLES -- what Paul Berry outlined a while back, basically. This

Re: [Piglit] [PATCH 1/2] glsl, gles2: add version 100

2012-12-14 Thread Ian Romanick
On 12/13/2012 12:58 PM, Tom Gall wrote: This is a small change in two parts to repair support for gles2 by glslparsertest. To glslparsertest.c, add 100 into the list of versions the switch handles when passed from the command line instead of the default path. Next in piglit_init when version

[Piglit] [PATCH] Accept array uniform names with or without [0] from glGetActiveUniform

2012-12-14 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This is required by OpenGL ES 3.0 and desktop OpenGL 4.2. Previous version were ambiguous. Previously these tests failed on NVIDIA's closed-source driver (version 304.64) with the error messages: 0: f1 loc=0 size=1 type=0x1406 1: f2 loc=1

[Piglit] [PATCH 1/3 v2] arb_internalformat_query: Add initial API error test for this extension

2012-12-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This driver supports GL_ARB_texture_multisample, but it does not support GL_ARB_internalformat_query2. This test fails on AMD's closed-source driver (Catalyst 12.6 on HD

[Piglit] [PATCH 2/3 v2] arb_internalformat_query: Verify glGetInternalformativ doesn't over-run the buffer

2012-12-17 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This test passes on NVIDIA's closed-source driver (version 304.64 on GTX 260). This test fails on AMD's closed-source driver (Catalyst 12.6 on HD 3650). Queries of GL_NUM_SAMPLE_COUNTS merrily write data even when bufSize is zero. v2: Add some

Re: [Piglit] [PATCH] arb_uniform_buffer_object: Add new tests for GL_MAX_UNIFORM_BLOCK_SIZE.

2012-12-18 Thread Ian Romanick
On 12/18/2012 10:50 AM, Eric Anholt wrote: --- tests/all.tests|4 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../maxuniformblocksize.c | 237 3 files changed, 242 insertions(+)

Re: [Piglit] [PATCH 1/2] Test that varyings can't be bools or structs

2012-12-19 Thread Ian Romanick
On 12/19/2012 08:30 AM, Paul Berry wrote: Reviewed-by: Ian Romanick ian.d.roman...@intel.com Now for the bad news... In GLSL ES 3.00 and GLSL 1.50 this language changes to: They can only be float, floating-point vectors, matrices, signed or unsigned integers or integer vectors

Re: [Piglit] [PATCH 2/2] Test that varying packing can pack floats, ints, and uints together.

2012-12-19 Thread Ian Romanick
On 12/19/2012 08:30 AM, Paul Berry wrote: Reviewed-by: Ian Romanick ian.d.roman...@intel.com --- .../varying-packing-mixed-types.shader_test| 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/varying-packing-mixed

Re: [Piglit] [PATCH 2/3] util: Add compressed representations of grayscale images.

2013-01-03 Thread Ian Romanick
On 12/31/2012 11:14 AM, Paul Berry wrote: This patch adds compressed representations of uniform grayscale images to piglit, in the ETC1 and FXT1 compression formats. Although they don't exercise the full capabilities of these compression formats, they should be sufficient to create basic tests

Re: [Piglit] [PATCH 3/3] Add tests for glCompressedTex{Image, SubImage}3D().

2013-01-03 Thread Ian Romanick
On 01/03/2013 02:39 PM, Eric Anholt wrote: Paul Berry stereotype...@gmail.com writes: +#ifdef PIGLIT_USE_OPENGL +#define GRAYSCALE_IMAGES piglit_fxt1_grayscale_images +#define COMPRESSED_FORMAT GL_COMPRESSED_RGB_FXT1_3DFX FXT1 does mean that non-intel drivers won't run this test. Not

Re: [Piglit] (no subject)

2013-01-15 Thread Ian Romanick
, even though I had to rewrite some GLSL code from ints to floats. (texelFetch - texture2DRect; % - mod) The series is Reviewed-by: Ian Romanick ian.d.roman...@intel.com Marek ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH] arb_uniform_buffer_object: Fix tests with clarifications from Khronos

2013-01-22 Thread Ian Romanick
On 01/22/2013 02:29 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com OpenGL ES 3.0 (and presumably other versions of OpenGL) have two requirements that these tests expect to be violated: 1. Members of a uniform block

[Piglit] [PATCH 2/2 v2] arb_uniform_buffer_object: Only use row_major or column_major on matrix types

2013-01-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com OpenGL ES 3.0 requires that the row_major and column_major layout qualifiers only be accepted on matrix types. Previously this test would put the layout qualifier on any type. Signed-off-by: Ian Romanick ian.d.roman...@intel.com

[Piglit] [PATCH 1/2 v2] arb_uniform_buffer_object: Reference all UBO members from the shader

2013-01-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com OpenGL ES 3.0 (and presumably other versions of OpenGL) requires that UBO members that are not accessed by the shader not be marked as active. Previously these tests assumed that all members would be active regardless of use. Signed-off-by: Ian

Re: [Piglit] [PATCH 1/3] android: piglit-vbo.cpp compile error

2013-01-28 Thread Ian Romanick
These changes seem innocuous enough. Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 01/28/2013 10:30 AM, Tom Gall wrote: Android is a bit more strict when it builds. Missing was ctype.h. It doesn't break Linux. Signed-off-by: Tom Gall tom.g...@linaro.org --- tests/util/piglit-vbo.cpp

[Piglit] [PATCH] glx-multithread-makecurrent-*: Write the expected value for alpha

2013-01-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The tests would previously write 0.0 to the alpha and expect to read 1.0 back. If the test got a visual without alpha (and it doesn't request alpha), this would happen to work. However, drivers are not required to expose visuals without alpha, so

[Piglit] [PATCH] Accept array uniform names with or without [0] from glGetActiveUniform

2013-01-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This is required by OpenGL ES 3.0 and desktop OpenGL 4.2. Previous version were ambiguous. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Frank Henigman fjhenig...@google.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59688

[Piglit] [PATCH] glx-swap-pixmap: Expect alpha = 1.0 if there is no alpha in the pixmap

2013-01-28 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59833 --- tests/glx/glx-swap-pixmap.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/glx/glx-swap

Re: [Piglit] [PATCH] glx-multithread-makecurrent-*: Write the expected value for alpha

2013-01-28 Thread Ian Romanick
On 01/28/2013 04:44 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com The tests would previously write 0.0 to the alpha and expect to read 1.0 back. If the test got a visual without alpha (and it doesn't request alpha), this would

Re: [Piglit] [PATCH] glsl-uniform-out-of-bounds-2: work with or without [0] after array names

2013-01-29 Thread Ian Romanick
On 01/28/2013 05:18 PM, Frank Henigman wrote: Ignore this. Ian sent a better patch at the same time. Should I count that as a Reviewed-by for my patch? :) On Mon, Jan 28, 2013 at 4:18 PM, Frank Henigman fjhenig...@google.com mailto:fjhenig...@google.com wrote: Make

[Piglit] [PATCH] Test bad interaction with optimizer and array accesses to vector elements

2013-01-29 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chris Wolfe cwo...@chromium.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53256 --- .../shaders/glsl-vs-channel-overwrite.shader_test | 42 ++ 1 file changed, 42

[Piglit] [PATCH v2] Test bad interaction with optimizer and array accesses to vector elements

2013-01-29 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com v2: Add several other, similar test cases that tickle other related bugs in the same optimization passes. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Chris Wolfe cwo...@chromium.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id

Re: [Piglit] [PATCH] fbo: add fbo-5-varyings test to reproduce Mesa bugzilla #56920

2013-02-08 Thread Ian Romanick
On 02/02/2013 10:40 AM, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com The short long and the longer description should describe what the test is testing. I've looked at the test, and I'm still not really sure what it's doing. Just add a link in the commit

[Piglit] [PATCH 2/2] arb_uniform_buffer_object: Add missing a_rm1 reference

2013-02-19 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This somehow went missing from commit 10628a0. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=60298 Cc: Vinson Lee v...@freedesktop.org --- tests/spec/arb_uniform_buffer_object/row-major.c

Re: [Piglit] [PATCH] layout-std140-base-size-and-alignment: Fix running the test.

2013-02-19 Thread Ian Romanick
On 02/19/2013 12:00 PM, Eric Anholt wrote: The shaders compile failed as of 10628a004e18190b015bacf7640b638c51db82d0 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59648 --- .../layout-std140-base-size-and-alignment.c |2 +- 1 file changed, 1

Re: [Piglit] [PATCH] ARB_uniform_buffer_object/row_major: Reference another missed UBO member.

2013-02-19 Thread Ian Romanick
On 02/19/2013 11:40 AM, Eric Anholt wrote: Makes the test pass on Mesa master. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59957 With the spurious hunk removed, Reviewed-by: Ian Romanick ian.d.roman...@intel.com Since I wrote the exact same patch at about the exact same time

[Piglit] [PATCH] glsl-1.40: Expect shadow comparison alpha to be 1.0

2013-02-20 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Appendix E.1 (Profiles and Deprecated Features of OpenGL 3.0) of the OpenGL 3.1 spec says: • Depth texture mode - DEPTH TEXTURE MODE. Section 3.9.14 is to be changed so that r is returned to texture samplers directly, and the OpenGL

[Piglit] [PATCH] Test some interactions with multiple inout parameters

2013-03-22 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are several variations of void foo(inout int i, inout float f); ... foo(i, f[i]); that Mesa's GLSL compiler gets wrong. NVIDIA's closed-source driver (version 304.64) fails vs-inout-index-inout-mat2-col.shader_test and vs-inout-index-inout-mat2

Re: [Piglit] [PATCH] glsl-fs-main-return-conditional: Test for using return in main

2013-03-22 Thread Ian Romanick
On 03/22/2013 03:28 PM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com Similar to glsl-fs-main-return (and glsl-vs-main-return), this is testing using return in main. Contrary to the these other tests, this hits both the cases where the return path is and is NOT taken

Re: [Piglit] [PATCH] Test some interactions with multiple inout parameters

2013-03-25 Thread Ian Romanick
On 03/25/2013 09:04 AM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com There are several variations of void foo(inout int i, inout float f); ... foo(i, f[i]); that Mesa's GLSL compiler gets wrong. NVIDIA's closed-source driver

  1   2   3   4   5   6   7   8   9   10   >