Re: [Piglit] [PATCH] shaders: add test for recursive variable indexing into arrays

t; indexing.shader_test Please move the test to somewhere in test/spec/glsl-1.30 rather than putting it in shaders. I believe shaders is a legacy folder from before things were organised, its really hard to find anything in here when looking for existing tests. Otherwise - Reviewed-by: Timothy Arc

[Piglit] [PATCH] arb_enhanced_layouts: test component packing with patch in tess stages

--- ...s-tcs-tes-fs-patch-array-interleave.shader_test | 139 + .../vs-tcs-tes-fs-patch.shader_test| 119 ++ 2 files changed, 258 insertions(+) create mode 100644

[Piglit] [PATCH] SSO: reproduce linking bug in Dead Island

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85564 --- .../large-number-of-unused-varyings.shader_test| 51 ++ 1 file changed, 51 insertions(+) create mode 100644 tests/spec/arb_separate_shader_objects/linker/large-number-of-unused-varyings.shader_test diff

[Piglit] [PATCH 2/3] arb_enhanced_layouts: xfb_buffer layout qualifier compile tests

--- .../xfb_buffer/block-max.vert | 22 + .../xfb_buffer/block-member-global-mismatch.vert | 35 + .../xfb_buffer/block-member-mismatch.vert | 33 .../xfb_buffer/block-member-mismatch2.vert | 33

[Piglit] [PATCH 1/3] arb_enhanced_layouts: xfb_offset layout qualifier compile tests

--- .../xfb_offset/block-member.vert | 23 +++ .../xfb_offset/block-with-double.vert | 26 + .../xfb_offset/block.vert | 23 +++ .../xfb_offset/global.vert | 19

[Piglit] [PATCH] arb_sample_shading: run tests concurrently

Base on an earlier patch from Chris I assume this is safe. Cc: Chris Forbes --- tests/all.py | 19 +++ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/tests/all.py b/tests/all.py index 8205cc2..b682821 100644 --- a/tests/all.py +++ b/tests/all.py

Re: [Piglit] [PATCH] es2_compat: run glReleaseShaderCompiler and use a builtin

On Sat, 2016-02-06 at 15:35 -0500, Ilia Mirkin wrote: > All that mesa does when releasing the shader compiler is clear its > builtins list. So make sure to use a builtin, and release the > compiler > sooner, to trigger a bug in mesa. > > This code sequence is hit by some core Android component. >

Re: [Piglit] [PATCH] Fix a couple EXT_blend_func_extended test bugs exposed by the Nvidia blob.

On Wed, 2016-01-27 at 18:47 -0500, Ilia Mirkin wrote: > Reviwed-by: Ilia Mirkin > > Will push this shortly. > > On Wed, Jan 27, 2016 at 1:46 PM, Ryan Houdek > wrote: > > fbo-extended-blend-pattern was using an implicit integer to float > >

[Piglit] [PATCH] sso: Add several misc API error tests

sion check for GL_ARB_transform_feedback2. Use configure_transform_feedback_object utility function. Use CreateShaderProgram_with_xfb utility function. Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> --- tests/all.py

[Piglit] [PATCH] arb_enhanced_layouts: test matrix attributes can't have a component qualifier

I filled a spec bug for this as the GL Core spec seems to conflict with the GLSL spec on this and its been confirmed that they are not intended to be allowed. --- .../component-layout/matrix-array-attribute.vert | 20 .../compiler/component-layout/matrix-attribute.vert |

[Piglit] [PATCH 1/2] glsl: tidy up link empty program tests

There are two tests, the second test covers what the first test is doing plus more, so remove the first test. Add a check that glUseProgram doesn't generate an error when linked program is empty. Finally move the remaining test out of the shaders folder. Cc: Ilia Mirkin

[Piglit] [PATCH 2/2] gl-3.1: test for linking error with an empty program

From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 spec: "Linking can fail for a variety of reasons as specified in the OpenGL Shading Language Specification, as well as any of the following reasons: - No shader objects are attached to program." Cc: Ian Romanick

[Piglit] [PATCH] glsl: fix link empty program tests

Also move them out of the shaders folder. From Section 7.3 (PROGRAM OBJECTS) of the OpenGL 4.5 spec: "Linking can fail for a variety of reasons as specified in the OpenGL Shading Language Specification, as well as any of the following reasons: - No shader objects are attached to

[Piglit] [PATCH] arb_enhanced_layouts: xfb_buffer layout qualifier compile tests

--- ...ck-larger-than-gl_TransformFeedbackBuffers.vert | 22 ++ .../xfb-buffer/xfb_buffer-block-max.vert | 22 ++ .../xfb_buffer-block-member-global-mismatch.vert | 35 ++ .../xfb_buffer-block-member-mismatch.vert | 33

Re: [Piglit] [PATCH] sso: add test for linking gs without explicit locations

gt; As discussed on IRC the desktop spec leaves SSO interface validation up to the dev so the mismatch between VS and GS should be fine as far as I understand. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> > --- > .../execution/vs-gs-linking.shader_test| 5

[Piglit] [PATCH] arb_shader_image_load_store: fix location of storage qualifier

In GLSL 1.50 layout qualifiers must come before the storage qualifier. A recent fix in Mesa exposed this issue. Cc: Ilia Mirkin --- tests/spec/arb_shader_image_load_store/grid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH V2] arb_shader_image_load_store: fix syntax error in execution tests

On Wed, 2016-01-20 at 03:42 -0500, Ilia Mirkin wrote: > On Tue, Jan 19, 2016 at 9:21 PM, Timothy Arceri > <timothy.arc...@collabora.com> wrote: > > @@ -98,7 +98,7 @@ header_hunk(const struct grid_info grid) > > "#define H %d\n" >

[Piglit] [PATCH] arb_shader_image_load_store: test duplicate format qualifier more thoroughly

From the ARB_shader_image_load_store spec: "Only one format qualifier may be specified for any image variable declaration." --- .../gen_shader_image_load_store_tests.py | 15 +++ ...aration-format-qualifier-duplicate-420pack.frag | 28 +

[Piglit] [PATCH V2] arb_shader_image_load_store: fix syntax error in execution tests

In GLSL 1.50 layout qualifiers must come before the storage qualifier. A recent fix in Mesa exposed this issue. V2: rename IMAGE_T -> IMAGE_UNIFORM_T, fix DST/SRC_IMAGE_T miss in V1 Cc: Francisco Jerez --- tests/spec/arb_shader_image_load_store/atomicity.c | 2

[Piglit] [PATCH] arb_shader_image_load_store: fix syntax error in execution tests

In GLSL 1.50 layout qualifiers must come before the storage qualifier. A recent fix in Mesa exposed this issue. Cc: Francisco Jerez --- tests/spec/arb_shader_image_load_store/atomicity.c | 2 +- tests/spec/arb_shader_image_load_store/bitcast.c| 2 +-

Re: [Piglit] [PATCH] arb_shader_image_load_store: test duplicate format qualifier more thoroughly

On Tue, 2016-01-19 at 18:08 -0800, Francisco Jerez wrote: > Timothy Arceri <timothy.arc...@collabora.com> writes: > > > From the ARB_shader_image_load_store spec: > > > >"Only one format qualifier may be specified for any ima

Re: [Piglit] [PATCH] arb_shader_image_load_store: test duplicate format qualifier more thoroughly

On Wed, 2016-01-20 at 13:27 +1100, Timothy Arceri wrote: > On Tue, 2016-01-19 at 18:08 -0800, Francisco Jerez wrote: > > Timothy Arceri <timothy.arc...@collabora.com> writes: > > > > > From the ARB_shader_image_load_store spec: > > > > > >&qu

[Piglit] [PATCH] arb_shader_image_load_store: test duplicate format qualifier more thoroughly

From the ARB_shader_image_load_store spec: "Only one format qualifier may be specified for any image variable declaration." ARB_enhanced_layouts Allows duplicates within a single layout qualifier e.g. layout(location = 0, location = 1) out vec4 a; ARB_shading_language_420pack

[Piglit] [PATCH] arb_shader_subroutine: test subroutine uniform array with explicit location

Currently segfaults in Mesa. --- ...array-subroutines-explicit-location.shader_test | 51 ++ 1 file changed, 51 insertions(+) create mode 100644 tests/spec/arb_shader_subroutine/execution/array-subroutines-explicit-location.shader_test diff --git

[Piglit] [PATCH] arb_shader_subroutine: test UniformSubroutinesuiv

When setting the index for a subroutine with an explicit location, inactive locations in the indices param should be ignored. This test causes a segfault in Mesa. https://bugs.freedesktop.org/show_bug.cgi?id=93731 --- tests/all.py | 1 +

[Piglit] [PATCH] arb_enhanced_layouts: tests for duplicate layout identifiers

Test results: Nvidia GeForce 840M - NVIDIA 352.41 The results from the Nvidia binary are a little all over the place with these tests, most of the tests with arb_enhanced_layouts enabled fail but if the GLSL version is changed to 4.20 they pass. The only tests that pass with arb_enhanced_layouts

[Piglit] [PATCH V3] arb_shading_language_420pack: test multiple layout qualifiers on the same line

Test results: Nvidia GeForce 840M - NVIDIA 352.41 The results from the Nvidia binary are a little all over the place with these tests, most of the tests with arb_shading_language_420pack enabled fail but if the GLSL version is changed to 4.20 they pass. The only tests that pass with

Re: [Piglit] [PATCH V2] arb_shading_language_420pack: test multiple layout qualifiers on the same line

On Thu, 2016-01-14 at 09:18 -0800, Matt Turner wrote: > On Wed, Jan 13, 2016 at 9:45 PM, Timothy Arceri > <timothy.arc...@collabora.com> wrote: > > While the spec is taking about multiple layout qualifiers we > > interpret that > > to mean layout-qualifier-names

[Piglit] [PATCH V2] arb_shading_language_420pack: test multiple layout qualifiers on the same line

While the spec is taking about multiple layout qualifiers we interpret that to mean layout-qualifier-names can also occur multiple times within a single layout qualifier. In Section 4.4 (Layout Qualifiers) of the GLSL 4.40 spec it clarifies this: "More than one layout qualifier may appear in

[Piglit] [PATCH] arb_shading_language_420pack: test multiple layout qualifiers on the same line

While the spec is taking about multiple layout qualifiers we interpert that to mean layout-qualifier-names can also occur multiple times within a single layout qualifier. In Section 4.4 (Layout Qualifiers) of the GLSL 4.40 spec it clarifies this: "More than one layout qualifier may appear in

[Piglit] [PATCH] arb_enhanced_layouts: more fs output tests

--- .../component-layout/fs-out-array.shader_test | 36 ++ .../fs-out-overlap-array.shader_test | 36 ++ .../component-layout/fs-out-overlap4.shader_test | 35 + .../fs-out-type-mismatch-array.shader_test |

[Piglit] [PATCH 1/2] arb_enhanced_layouts: test align layout qualifier can only be used with std140 or std430

--- .../ssbo-packed-layout-member-align.vert | 26 ++ .../ssbo-shared-layout-block-align.vert| 26 ++ .../ssbo-shared-layout-member-align.vert | 26 ++ .../align-layout/ssbo-std140-block-align.vert |

[Piglit] [PATCH 2/2] arb_enhanced_layouts: tests compiler error if align qualifier not a power of 2

--- .../ssbo-block-align-not-power-of-two.vert | 26 ++ .../ssbo-member-align-not-power-of-two.vert| 26 ++ .../ubo-block-align-not-power-of-two.vert | 24 .../align-layout/ubo-block-align-zero.vert | 24

Re: [Piglit] [PATCH 0/5] Randomized UBO tests of doom

On Tue, 2015-11-10 at 16:46 -0800, Dylan Baker wrote: > Since gravy is so delicious, > > https://github.com/dcbaker/piglit.git wip/ubo-fuzzer > > bin/piglit run ubo-fuzzer output > > Obviously it's not at all feature complete, it's more proof of > concept > than anything else, but gravy. Hi

[Piglit] [PATCH] arb_enhanced_layouts: UBO explicit offset test

This is just a lazy copy of the arb_uniform_buffer_object bufferstorage test updated to make use of explicit offsets. Test results: Nvidia GeForce 840M - NVIDIA 352.41: fail This fails on the Nvidia driver due to a bug in handling the named uniform block in the fragment shader. If the name is

[Piglit] [PATCH] arb_enhanced_layouts: test for component aliasing of doubles

--- .../vs-to-fs-double-overlap.shader_test| 55 ++ 1 file changed, 55 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/linker/component-layout/vs-to-fs-double-overlap.shader_test diff --git

[Piglit] [PATCH] arb_enhanced_layouts: test linking block members for AoA with overlaping locations

--- .../block-member-location-overlap-aoa.shader_test | 62 ++ 1 file changed, 62 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/linker/block-member-locations/block-member-location-overlap-aoa.shader_test diff --git

[Piglit] [PATCH] arb_separate_shader_objects: test explicit locations work correctly for interface blocks

Test results: Nvidia GeForce 840M - NVIDIA 352.41 layout-location-block-with-aoa-member.shader_test - pass layout-location-block-with-single-line-declaration-members.shader_test - fail layout-location-block-with-struct-member.shader_test - pass Mesa (master)

[Piglit] [PATCH] arb_shader_storage_buffer_object: test GL_BUFFER_DATA_SIZE for arrays of arrays

--- .../sized_arrays_of_arrays_member.shader_test | 36 ++ .../unsized_arrays_of_arrays_member.shader_test| 36 ++ 2 files changed, 72 insertions(+) create mode 100644

[Piglit] [PATCH] arb_shader_draw_parameters: test define

Cc: Ilia Mirkin --- .../arb_shader_draw_parameters/compiler/define.vert | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 tests/spec/arb_shader_draw_parameters/compiler/define.vert diff --git

[Piglit] [PATCH 1/4] arb_enhanced_layouts: fix up test comments

Remove line describing the test that is wrong and tidy up alignment of spec quote. Cc: Emil Velikov --- .../explicit-offsets/ssbo-offset-multiple-of-base-member-align.vert | 6 ++ .../explicit-offsets/ubo-offset-multiple-of-base-member-align.vert | 6 ++ 2

[Piglit] [PATCH 3/4] arb_enhanced_layouts: test offset is a multiple of base alignment for vec4

Cc: Emil Velikov --- ...-offset-multiple-of-base-member-align-vec4.vert | 25 ++ ...-offset-multiple-of-base-member-align-vec4.vert | 24 + 2 files changed, 49 insertions(+) create mode 100644

[Piglit] [PATCH 2/4] arb_enhanced_layouts: fix constant expression offset tests

Offset must be a multiple of the base alignment which is 16 for a vec4. Cc: Emil Velikov --- .../explicit-offsets/ssbo-integral-constant-expression-offset.vert | 2 +- .../explicit-offsets/ubo-integral-constant-expression-offset.vert | 2 +- 2 files changed,

[Piglit] [PATCH] arb_enhanced_layouts: fix offset link tests to work with GLSL 1.40

Cc: Emil Velikov --- .../intrastage-ssbo-different-offset-across-shaders.shader_test | 4 +++- .../intrastage-ubo-different-offset-across-shaders.shader_test| 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Piglit] [PATCH 4/4] arb_enhanced_layouts: fix comments in component layout test

--- .../execution/component-layout/vs-tcs-tes-fs.shader_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_enhanced_layouts/execution/component-layout/vs-tcs-tes-fs.shader_test

Re: [Piglit] [PATCH] Add an SSO test which mix-and-matches TCS/TES with different interfaces.

t is updated when the TCS changes. > > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org> Seems reasonable. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] sso: Check piglit_link_check_status return value.

(const GLchar *const *) > fs_code); > - piglit_link_check_status(*prog); > + pass = piglit_link_check_status(*prog) && pass; Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> > > glGenProgramPipelines(1, pipe); > glUseProgramStag

[Piglit] [PATCH] arb_enhanced_layouts: test passing varyings with component qualifier through tessellation stage

Test results: Nvidia GeForce 840M - NVIDIA 352.41 vs-tcs-tes-fs.shader_test - pass vs-tcs-tes-fs-array-interleave.shader_test - fail --- .../vs-tcs-tes-fs-array-interleave.shader_test | 139 + .../component-layout/vs-tcs-tes-fs.shader_test | 119 ++ 2

[Piglit] [PATCH] arb_enhanced_layouts: test layout componet qualifier between multiple stages with SSO

--- .../sso-vs-gs-fs-array-interleave.shader_test | 106 + 1 file changed, 106 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/execution/component-layout/sso-vs-gs-fs-array-interleave.shader_test diff --git

[Piglit] [PATCH] arb_arrays_of_arrays: test linking between vs and gs with explicit locations

--- .../linker/vs-to-gs-explicit-location.shader_test | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 tests/spec/arb_arrays_of_arrays/linker/vs-to-gs-explicit-location.shader_test diff --git

[Piglit] [PATCH] arb_separate_shader_objects: make sure explicit locations match and don't just overlap

Test results: Nvidia GeForce 840M - NVIDIA 352.41: fail Mesa 11.2 (dev): pass --- ...fs-explicit-location-mismatch-array.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644

[Piglit] [PATCH] arb_separate_shader_objects: test for explicit varying location overlap struct and block

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass Mesa 11.2 (dev): fail --- ...-fs-explicit-location-overlap-block.shader_test | 54 ++ ...fs-explicit-location-overlap-struct.shader_test | 54 ++ 2 files changed, 108 insertions(+) create mode 100644

[Piglit] [PATCH] arb_enhanced_layouts: test component qualifier for fragment shader output

--- .../component-layout/fs-output.shader_test | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/execution/component-layout/fs-output.shader_test diff --git

[Piglit] [PATCH] arb_separate_shader_objects: test for explicit varying location overlap by arrays

Test results: Nvidia GeForce 840M - NVIDIA 352.41: fail Mesa 11.2 (dev): fail --- ...-fs-explicit-location-overlap-array.shader_test | 46 ++ 1 file changed, 46 insertions(+) create mode 100644

[Piglit] [PATCH] arb_separate_shader_objects: test for explicit varying location overlap by AoA

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass Mesa 11.2 (dev): fail --- ...t-location-overlap-arrays-of-arrays.shader_test | 55 ++ 1 file changed, 55 insertions(+) create mode 100644

[Piglit] [PATCH] arb_gpu_shader_fp64: test for varying location overlap

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass Mesa 11.2 (dev): crash --- .../vs-to-fs-explicit-location-overlap.shader_test | 52 ++ 1 file changed, 52 insertions(+) create mode 100644

[Piglit] [PATCH] arb_separate_shader_objects: test for overlaping location issues

This tests that when a strcut has explicit location were reserve enough locations for all the struct members. --- ...ed-with-implicitly-assigned-varying.shader_test | 60 ++ 1 file changed, 60 insertions(+) create mode 100644

[Piglit] [PATCH] arb_shader_image_load_store: call glMemoryBarrier before reading image

Cc: Francisco Jerez --- .../execution/gl45-imageAtomicExchange-float.shader_test | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_shader_image_load_store/execution/gl45-imageAtomicExchange-float.shader_test

[Piglit] [PATCH] arb_enhanced_layouts: vertex shader input component layout qualifier test

Test results: Nvidia GeForce 840M - NVIDIA 352.41: fail Using the component qualifier on a vertex input array seems to uncover a nasty bug on the Nvidia driver. The explict location ends up getting changed for some reason. --- .../component-layout/vs-attribs-array.shader_test | 57

Re: [Piglit] [PATCH] glsl-1.50: enhance vs input test to include matrix inputs.

hat.com> Thanks. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] arb_shader_image_load_store: call glMemoryBarrier() before reading an image written to by imageStore()

On Thu, 2015-12-10 at 16:21 +0200, Francisco Jerez wrote: > Timothy Arceri <timothy.arc...@collabora.com> writes: > > > I haven't been able to test if this fixes the bug as I cannot > > reproduce it. > > > > Cc: Francisco Jerez <curroje...@riseup.n

[Piglit] [PATCH 2/3] shader_runner: add ability to set glMemoryBarrier()

V2: use updated piglit_get_gl_enum_from_name() rather than memory barrier specific function. Cc: Jordan Justen --- tests/shaders/shader_runner.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index

[Piglit] [PATCH V2 1/3] util: add infrastructure to look-up glMemoryBarrier() enums via names

V2: make the existing piglit_get_gl_enum_from_name() function handle the memory barrier enums (Suggested by Jordan). Cc: Jordan Justen --- tests/util/gen_dispatch.py | 15 ++- tests/util/piglit-util-gl.h | 3 +++ 2 files changed, 17 insertions(+), 1

Re: [Piglit] C99

On Thu, 2015-12-10 at 07:49 +, Jose Fonseca wrote: > Piglit build failed due to C99 usage. Roland already fixed it, but > in > fact it's fine to use most C99 -- the MSVC version we require > supports > most of it too. > > What I don't why this didn't cause a compilation failure for you?

[Piglit] [PATCH 3/3] arb_shader_image_load_store: call glMemoryBarrier() before reading an image written to by imageStore()

I haven't been able to test if this fixes the bug as I cannot reproduce it. Cc: Francisco Jerez Cc: Jordan Justen https://bugs.freedesktop.org/show_bug.cgi?id=92822 --- .../image_store/basic-imageStore-const-uniform-index.shader_test | 2

[Piglit] [PATCH 1/3] util: add infrastructure to look-up glMemoryBarrier() enums via names

--- tests/util/gen_dispatch.py| 14 +- tests/util/piglit-util-gl-enum-gen.c.mako | 24 tests/util/piglit-util-gl.h | 3 +++ 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/tests/util/gen_dispatch.py

[Piglit] [PATCH 2/3] shader_runner: add ability to set glMemoryBarrier()

--- tests/shaders/shader_runner.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 966abe9..c00fd61 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -2918,6 +2918,8 @@ piglit_display(void)

[Piglit] [PATCH] util: Add new headed matrix_index header to [vertex data]

This allows data to be set for matrix attributes in shader runner. For example to set colunm 2 of mat2x3: attname/float/3/1 --- tests/util/piglit-vbo.cpp | 43 +-- 1 file changed, 33 insertions(+), 10 deletions(-) diff --git a/tests/util/piglit-vbo.cpp

[Piglit] [PATCH V4 5/5] arb_enhanced_layouts: test layout location on block members

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass --- .../sso-block-member-layout-location.shader_test | 85 ++ 1 file changed, 85 insertions(+) create mode 100644

[Piglit] [PATCH V4 1/5] shader_runner: Add basic SSO support to shader runner

This sets up the basics for using SSO with shader runner. This will only support vertex and fragment shaders but is easily extended. V2: delete pipeline in cleanup code rather than calling gen again, output error message when SSO fails to link V3: add new option to [require] to allow separate

[Piglit] [PATCH V4 4/5] shader_runner: add SSO support for remaining shader stages

--- tests/shaders/shader_runner.c | 32 1 file changed, 32 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index f6a12a3..966abe9 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -124,7

[Piglit] [PATCH V4 3/5] shader_runner: add support for setting glActiveShaderProgram()

This will allow us to set uniforms in SSO. For example to make the fragment program active: active shader program GL_FRAGMENT_SHADER Reviewed-by: Kenneth Graunke --- tests/shaders/shader_runner.c | 13 + 1 file changed, 13 insertions(+) diff --git

[Piglit] [PATCH V4 2/5] shader_runner: add support for setting uniform by location

For example to set an int at location 1 to the value 0: uniform int 1 0 Previously only name could be used to set the uniform. Reviewed-by: Kenneth Graunke --- tests/shaders/shader_runner.c | 26 +++--- 1 file changed, 15 insertions(+), 11

[Piglit] [PATCH V3 1/4] shader_runner: Add basic SSO support to shader runner

This sets up the basics for using SSO with shader runner. This will only support vertex and fragment shaders but is easily extended. V2: delete pipeline in cleanup code rather than calling gen again, output error message when SSO fails to link V3: add new option to [require] to allow separate

[Piglit] [PATCH 1/4] shader_runner: Add basic SSO support to shader runner

This sets up the basics for using SSO with shader runner. This will only support vertex and fragment shaders but is easily extended. V2: delete pipeline in cleanup code rather than calling gen again, output error message when SSO fails to link Example shader: [require] GLSL >= 1.50 [vertex

[Piglit] [PATCH 2/4] shader_runner: add support for setting uniform by location

For example to set an int at location 1 to the value 0: uniform int 1 0 Previously only name could be used to set the uniform. --- tests/shaders/shader_runner.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/tests/shaders/shader_runner.c

[Piglit] [PATCH 4/4] arb_enhanced_layouts: test layout location on block members

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass --- .../sso-block-member-layout-location.shader_test | 84 ++ 1 file changed, 84 insertions(+) create mode 100644

[Piglit] [PATCH 3/4] shader_runner: add support for setting glActiveShaderProgram()

This will allow us to set uniforms in SSO. For example to make the fragment program active: active shader program GL_FRAGMENT_SHADER --- tests/shaders/shader_runner.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c

Re: [Piglit] [PATCH] shader_runner: Add basic SSO support to shader runner

On Thu, 2015-12-03 at 17:41 +1100, Timothy Arceri wrote: > This sets up the basics for using SSO with shader runner. This will > only support vertex and fragment shaders but is easily extended. > > Example shader: > > [require] > GLSL >= 1.50 > > [vertex ss

[Piglit] [PATCH] shader_runner: Add basic SSO support to shader runner

This sets up the basics for using SSO with shader runner. This will only support vertex and fragment shaders but is easily extended. Example shader: [require] GLSL >= 1.50 [vertex sso] layout(location = 0) in vec4 piglit_vertex; layout(location = 2) out vec3 a; layout(location = 3) out vec3

[Piglit] [PATCH] arb_separate_shader_objects: dont check for INVALID_OPERATION after validation

Validation should not generate an INVALID_OPERATION only the draw call should, this was seems to have been working around a bug in Mesa. https://bugs.freedesktop.org/show_bug.cgi?id=93180 --- tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 -- 1 file changed, 2 deletions(-)

[Piglit] [PATCH 1/8] arb_enhanced_layouts: add negative test for atmoic binding qualifier

From: Timothy Arceri <t_arc...@yahoo.com.au> --- .../negative-qualifiers/binding-atomic.frag| 22 ++ 1 file changed, 22 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/compiler/compile-time-constants/negative-qualifiers/binding-atomic.frag

[Piglit] [PATCH 8/8] arb_enhanced_layouts: add layout component tests for frag shader outputs

--- .../component-layout/fs-out-overlap.shader_test| 35 ++ .../component-layout/fs-out-overlap2.shader_test | 35 ++ .../component-layout/fs-out-overlap3.shader_test | 35 ++ .../fs-out-type-mismatch.shader_test |

[Piglit] [PATCH 2/8] arb_enhanced_layouts: test for component overlap in linker rather than compiler

--- .../compiler/component-layout/overlap-illegal.vert | 32 - .../component-layout/vs-to-fs-overlap.shader_test | 52 ++ 2 files changed, 52 insertions(+), 32 deletions(-) delete mode 100644

[Piglit] [PATCH 6/8] arb_enhanced_layouts: test GetProgramResourceiv with GL_LOCATION_COMPONENT

--- .../component-layout/query-component.shader_test | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/linker/component-layout/query-component.shader_test diff --git

[Piglit] [PATCH 5/8] arb_enhanced_layouts: compile test component layout on a named block member

--- .../component-layout/block-member-named.frag | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 tests/spec/arb_enhanced_layouts/compiler/component-layout/block-member-named.frag diff --git

Re: [Piglit] [PATCH] read_depth_gles3: Remove dead code.

Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_separate_shader_objects: test explicit location on interface blocks

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.2-dev: fail --- .../execution/layout-location-block.shader_test| 51 ++ .../layout-location-named-block.shader_test| 51 ++ 2 files changed, 102 insertions(+) create mode

Re: [Piglit] [PATCH] arb_arrays_of_arrays: Fix format-secruity warning.

Thanks. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> On Sun, 2015-11-29 at 23:34 -0800, Vinson Lee wrote: > max-binding.c:126:44: warning: format string is not a string literal > (potentially insecure) [-Wformat-security] > piglit_report_subtest_result(PI

[Piglit] [PATCH] arb_separate_shader_objects: test explicit location with a struct

Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.2-dev: fail --- .../execution/layout-location-struct.shader_test | 51 ++ 1 file changed, 51 insertions(+) create mode 100644

Re: [Piglit] [PATCH v5] sso: test program pipeline with atomic counters

On Fri, 2015-11-27 at 14:58 +0200, Tapani Pälli wrote: > Test fails on current Mesa (i965 BDW) but passes on NVIDIA binary > driver version 355.11 and AMD binary driver version 15.201.1151. > > v2: - add error checks > - modify to render points > - make it possible to use regular program

[Piglit] [PATCH] shader_runner: add LOCATION_COMPONENT to verify program_interface_query

--- tests/shaders/shader_runner.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 5d26409..dc833c8 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -2088,6 +2088,7 @@

Re: [Piglit] [PATCH V3] arb_separate_shader_objects: test mixed explicit and non-explicit locations

On Wed, 2015-11-25 at 21:36 +0100, gregory hainaut wrote: > On Wed, 25 Nov 2015 13:45:51 +1100 > Timothy Arceri <timothy.arc...@collabora.com> wrote: > > > From: Timothy Arceri <t_arc...@yahoo.com.au> > > > > This tests a bug in Mesa where explicit locat

[Piglit] [PATCH] sso: move helper function to sso-common

--- .../arb_separate_shader_objects/rendezvous_by_name.c | 15 --- .../rendezvous_by_name_interpolation.c | 10 +- tests/spec/arb_separate_shader_objects/sso-common.c | 16 tests/spec/arb_separate_shader_objects/sso-common.h |

[Piglit] [PATCH V3] arb_separate_shader_objects: test mixed explicit and non-explicit locations

From: Timothy Arceri <t_arc...@yahoo.com.au> This tests a bug in Mesa where explicit locations are not taken into account when assigning varying locations which results in two inputs/outputs being given the same location. Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mes

[Piglit] [PATCH V2] arb_separate_shader_objects: test mixed explicit and non-explicit locations

This tests a bug in Mesa where explicit locations are not taken into account when assigning varying locations which results in two inputs/outputs being given the same location. Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.1-dev: pass V2: use pick_a_glsl_version() helper

Re: [Piglit] [PATCH V2] arb_separate_shader_objects: test mixed explicit and non-explicit locations

On Mon, 2015-11-23 at 17:21 -0500, Ilia Mirkin wrote: > On Mon, Nov 23, 2015 at 5:15 PM, Timothy Arceri <t_arc...@yahoo.com.au> > wrote: > > diff --git a/tests/all.py b/tests/all.py > > index e80f3af..3adc503 100644 > > --- a/tests/all.py > > +++ b

Re: [Piglit] [PATCH 2/2] SSO: new test to ensure matching with various qualifier

gt; +} > + > +void piglit_init(int argc, char **argv) > +{ > + unsigned i; > + unsigned glsl_version; > + GLuint vs_prog[4]; > + GLuint fs_prog_match[4]; > + GLuint fs_prog_unmatch[4]; > + bool es; > + int glsl_major; > + in

Re: [Piglit] [PATCH] arb_program_interface_query: add support for querying subroutine index

ni.pa...@intel.com> > Thanks. > On 11/05/2015 12:34 PM, Timothy Arceri wrote: > > This also adds support for validating an expected or explicit index. > > > > In this case we check the explicit index of subroutine set via the > > layout qualifier. > &

Re: [Piglit] [PATCH] arb_separate_shader_objects: test mixed explicit and non-explicit locations

On Thu, 2015-11-19 at 14:21 +0100, Gregory Hainaut wrote: > Hello Timothy, > > > There seems to be 3 separate issues so I think we should have a separate > > tests > > (or at least cleary labebled subtests) for each of them. > > In this case, I propose that we keep your new test. It has a better

<    1   2   3   4   5   6   7   >