Re: Some suggestions for the usermanager

2016-09-19 Thread David Edmundson
On Mon, Sep 19, 2016 at 10:23 PM, Martin Bammer wrote: > Hi, > > I was playing around with extending and fixing some bugs in the > usermanager. One > of the bugs I would like to get fixed is setting the avatar for users. > As I've seen in the code changing the avatar does not

[Differential] [Reopened] D2747: Don't list raw containments in panels menu

2016-09-19 Thread mart (Marco Martin)
mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. I think this should be reexamined. I was just asked why a 3rd party dock looking panel is not listed here. simple panels (potentially coming from ghns now) should be listed. REPOSITORY

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Marco Martin
> On Sept. 19, 2016, 9:43 p.m., David Edmundson wrote: > > The problem with this patch (which highlights a mix we have in plasma in > > general) is that it's mixing whether the screen is managed by the view or > > managed by the containment. > > With this you're overriding the screen() method

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99285 --- shell/scripting/panel.cpp (line 189)

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99284 --- The problem with this patch (which highlights a mix we have

Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Kamil Sołtysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/ --- Review request for Plasma. Bugs:

Some suggestions for the usermanager

2016-09-19 Thread Martin Bammer
Hi,   I was playing around with extending and fixing some bugs in the usermanager. One of the bugs I would like to get fixed is setting the avatar for users. As I've seen in the code changing the avatar does not check for which user the avatar was changed. It always changes the avatar of the

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/#review99283 --- doc/kcontrol/keys/index.docbook

Review Request 128949: Add monitors for Linux memory infos dirty and writeback

2016-09-19 Thread Pascal VITOUX
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128949/ --- Review request for Plasma. Repository: ksysguard Description ---

Re: Review Request 128947: Update screenlocker docbook

2016-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128947/#review99282 --- Ship it! Ship It! - Marco Martin On Sept. 19, 2016,

Re: RFC: plasma-framework IndicatorArea formFactor()

2016-09-19 Thread Marco Martin
On Mon, Sep 19, 2016 at 8:37 PM, David Edmundson wrote: >> perhaps you are right, semantically they are two things, not sure what >> could be used instead more "proper"(suggestions welcome), will think >> more about it. > > > Long term, a virtual hook for immutability?

Re: A script/voiceover text for Plasma 5.8 video

2016-09-19 Thread Ivan Čukić
Mostly ok, I've made a few alterations. One sentence I don't get is: > Global shortcuts configuration has been simplified and can now be > configured to jump to specific tasks within an application. Cheers, Ivan

Review Request 128948: Update shortcuts kcm docbook

2016-09-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Review Request 128947: Update screenlocker docbook

2016-09-19 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128947/ --- Review request for Documentation and Plasma. Repository:

Re: RFC: plasma-framework IndicatorArea formFactor()

2016-09-19 Thread David Edmundson
On Mon, Sep 19, 2016 at 7:10 PM, Marco Martin wrote: > On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson > wrote: > > https://bugs.kde.org/show_bug.cgi?id=365967 > > > > It's a bug in that weather applet that it's rendering outside the area it > >

Re: RFC: plasma-framework IndicatorArea formFactor()

2016-09-19 Thread Marco Martin
On Mon, Sep 19, 2016 at 7:55 PM, David Edmundson wrote: > https://bugs.kde.org/show_bug.cgi?id=365967 > > It's a bug in that weather applet that it's rendering outside the area it > actually has - and that needs fixing anyway. > Introducing a new form factor won't

Re: RFC: plasma-framework IndicatorArea formFactor()

2016-09-19 Thread David Edmundson
On Mon, Sep 19, 2016 at 6:09 PM, Marco Martin wrote: > Hi all, > I was looking at some systray-related bugs, such as > https://bugs.kde.org/show_bug.cgi?id=365569 > and > https://bugs.kde.org/show_bug.cgi?id=365967 > and it occurs to me they always have in common the same

Re: New shapes and colors for Breeze mime-types icons

2016-09-19 Thread Marco Martin
On Mon, Sep 19, 2016 at 10:56 AM, kainz.a wrote: > Different shapes = different contend > Different colors = different file types I find the reasoning convincing. Maybe will still need some fixes after being widely tested in the flesh, but looking forward to see it live! --

RFC: plasma-framework IndicatorArea formFactor()

2016-09-19 Thread Marco Martin
Hi all, I was looking at some systray-related bugs, such as https://bugs.kde.org/show_bug.cgi?id=365569 and https://bugs.kde.org/show_bug.cgi?id=365967 and it occurs to me they always have in common the same reason: even if I tried hard in the rewrite to make it less a "special case", it still is

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 348 - Still Unstable!

2016-09-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/348/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Sep 2016 16:32:14 + Build duration: 9 min 26 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still unstable!

2016-09-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Sep 2016 16:29:24 + Build duration: 9 min 23 sec CHANGE SET Revision

[Differential] [Closed] D2814: Make sure to animate proper containments

2016-09-19 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP49131300b7e8: Make sure to animate proper containments (authored by mart). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2814: Make sure to animate proper containments

2016-09-19 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH phab/activityanim REVISION DETAIL https://phabricator.kde.org/D2814 EMAIL PREFERENCES

[Differential] [Updated] D2814: Make sure to animate proper containments

2016-09-19 Thread mart (Marco Martin)
mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2814 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Request, 57 lines] D2814: Make sure to animate proper containments

2016-09-19 Thread mart (Marco Martin)
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY if the activity is changed again while the switch animation is being performed, the desktop finds itself in an inconsistent state, as

[Differential] [Commented On] D2813: Readability. Simplify overly complex code

2016-09-19 Thread mart (Marco Martin)
mart added a comment. the change itself is actually ok, but can we avoid further changes that aren't an explicit bugfix in 5.8 branch prior the release? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2813 EMAIL PREFERENCES

[Differential] [Closed] D2813: Readability. Simplify overly complex code

2016-09-19 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE89c34a853b64: Readability. Simplify overly complex code (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2813: Readability. Simplify overly complex code

2016-09-19 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2813 EMAIL PREFERENCES

[Differential] [Request, 38 lines] D2813: Readability. Simplify overly complex code

2016-09-19 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We have a big case because the size depend on whether the panel is vertical or horizontal but it doesn't really

Accessibility at Randa Meetings 2017

2016-09-19 Thread Mario Fux
Morning guys With some of you I already talked about this topic but most of you I missed at QtCon or elsewhere. In short: I'd like improve the accessibility of our software and for this task I'd like to have at least some of you in Randa. But before we can continue with the details of the

[Differential] [Closed] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE3bf1372dffed: Make sure the panel is within the screen's geometry (authored by apol). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

2016-09-19 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in switcherbackend.cpp:161 > "The requestedSize corresponds to the Image::sourceSize requested by an Image > item. If requestedSize is a valid size, the image returned should be of that > size." > > source size isn't set which

[Differential] [Commented On] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread apol (Aleix Pol Gonzalez)
apol added a comment. In https://phabricator.kde.org/D2812#52349, @davidedmundson wrote: > Normally: > resizePanel() -> resizeEvent -> positionPanel > > Are you saying in your case, the restore() ends up in a different position, but because it's an identical size it doesn't

Minutes Monday Plasma Meeting

2016-09-19 Thread Sebastian Kügler
Note: starting next week, we'll resort to IRC Plasma Meeting minutes 19-9-2016 Present: bshah, Sho, andreas_k, jens, kbroulik, llucas, notmart, sebas Sho: * Fixed grouping for Wine apps in Task Mananager * Fixed launcher toggle action in Task Manager context menu not being disabled when we

[Differential] [Accepted] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. Normally: resizePanel() -> resizeEvent -> positionPanel Are you saying in your case, the restore() ends up in a

[Differential] [Request, 1 line] D2812: Make sure the panel is within the screen's geometry

2016-09-19 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Whenever we restore, the position of the panel can be random, we need to ensure that it's placed in the screen

[Differential] [Commented On] D2810: Fixed loading of the wallpapers in the activity switcher

2016-09-19 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > switcherbackend.cpp:161 > + > +if (width <= 0) { > +width = 320; "The requestedSize corresponds to the Image::sourceSize requested by an Image item. If requestedSize is a valid size, the image returned should

Re: Baloo maintainer required

2016-09-19 Thread Vishesh Handa
On Mon, Sep 19, 2016 at 11:43 AM, Bhushan Shah wrote: > Hey Vishesh, > > On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa wrote: >> I've been steadily loosing motivation to work on Baloo. >> >> I've removed myself from all the bugs, as it doesn't seem like I'm >>

[Differential] [Accepted] D2810: Fixed loading of the wallpapers in the activity switcher

2016-09-19 Thread mart (Marco Martin)
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > switcherbackend.cpp:156 > + > +void run() > +{ could this have the implementation after the class definition, just for immediate readability? REPOSITORY

Re: Fwd: Cron <lxr@lxr> ~/bin/update_kf5.sh

2016-09-19 Thread Jonathan Riddell
On Sun, Sep 18, 2016 at 06:53:32PM +0200, David Faure wrote: > There seems to be a branch mixup for kaccounts-mobile... > > -- Forwarded Message -- > > Subject: Cron ~/bin/update_kf5.sh > Date: dimanche 18 septembre 2016, 14:56:33 CEST > From: Cron Daemon

[Differential] [Accepted] D2730: [Task Manager] Use Qt.binding for prefix

2016-09-19 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2730 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Baloo maintainer required

2016-09-19 Thread Vishesh Handa
Hey guys I've been steadily loosing motivation to work on Baloo. I've removed myself from all the bugs, as it doesn't seem like I'm going to look at them. I no longer use Baloo or have a KDE development environment. Therefore, it's not even scratching my own itch. If someone else wants to

Re: Baloo maintainer required

2016-09-19 Thread Bhushan Shah
Hey Vishesh, On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa wrote: > I've been steadily loosing motivation to work on Baloo. > > I've removed myself from all the bugs, as it doesn't seem like I'm > going to look at them. I no longer use Baloo or have a KDE development >

Re: New shapes and colors for Breeze mime-types icons

2016-09-19 Thread kainz.a
Executable -- In general I think it's a good idea to have a gear shape for .exe, ... files, but I have to have a look if it look good as it is now with the big gear. MS Office -- the ms logos will be removed cause we don't want to ship app specific mimetypes (exclude .deb,

Re: A script/voiceover text for Plasma 5.8 video

2016-09-19 Thread Marco Martin
On Saturday 17 September 2016, Łukasz Sawicki wrote: > Hi, > > Here is a script/voiceover text for Plasma 5.8 video. Please check > grammar, typos etc. It is heavily based on Plasma 5.8 beta > announcement. > > https://notes.kde.org/p/Plasma_5.8_script looks good to me, tough it would be good

Re: New shapes and colors for Breeze mime-types icons

2016-09-19 Thread Marco Martin
On Sunday 18 September 2016, Alessandro Longo wrote: > Hi all, > > as written here[1] on KDE Planet I want to know thoughts on new colors > and shapes for Breeze mime-types icons, specially from people involved > in Plasma, since it's the main product that uses them. > > Please reply to

Re: SystemSettings See also links

2016-09-19 Thread kainz.a
2016-09-19 10:25 GMT+02:00 Marco Martin : > On Friday 09 September 2016, kainz.a wrote: > > you want to change the desktop theme from light to dark but with oxygen > > icons. you can switch everything in the look and feel kcm and than you > have > > to switch to the icon group.

Re: SystemSettings See also links

2016-09-19 Thread Marco Martin
On Friday 09 September 2016, kainz.a wrote: > you want to change the desktop theme from light to dark but with oxygen > icons. you can switch everything in the look and feel kcm and than you have > to switch to the icon group. with see also you go to look and feel package > see the kcm's from the

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 5 - Failure!

2016-09-19 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 19 Sep 2016 07:52:30 + Build duration: 3 min 57 sec CHANGE SET Revision

[Differential] [Closed] D2806: Pick up on virtual desktop name changes at runtime.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPcb7f58b14d80: Pick up on virtual desktop name changes at runtime. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2803: Disable filter-bypass by demands-attention windows.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP4185373fc2b8: Disable filter-bypass by demands-attention windows. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2805: Fix disabling launcher toggle action if launcher URL is empty.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPd7d135fda493: Fix disabling launcher toggle action if launcher URL is empty. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2807: Treat NET::Utility type windows as SkipTaskbar.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE7dee461947ae: Treat NET::Utility type windows as SkipTaskbar. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2804: Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in XWindowsTasksModel.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5e30fc609e76: Add an ultimate fallback to WM_CLASS Class for AbstractTasksModel::AppId in… (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2802: Make it possible to disable filter-bypass by demands-attention tasks.

2016-09-19 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1c0593f8ec65: Make it possible to disable filter-bypass by demands-attention tasks. (authored by hein). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE