D10498: Workaround the touchpad toggle button not working

knambiar added a comment. +1. I've also spent some time debugging this issue, and was perplexed why the property change event doesn't propagate. This fix should be backported if possible. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

graesslin added a comment. In D3829#158947 , @ngraham wrote: > @graesslin, does this still need changes to be merge-worthy? Yes, we did not migrate back to xlib, so the port to xcb is still required. REPOSITORY R119 Plasma Desktop REVIS

D10490: Add a method to dbus interface to query information about a window

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > broulik wrote in dbusinterface.cpp:199 > Can you use introspection to fill this `QVariantMap` rather than manually > doing this? We don't have properties for all of them and it

D10495: Workaround to restore KF5 programs from system tray

graesslin added a comment. In D10495#205811 , @stikonas wrote: > This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayla

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10502 To: ngraham, #kirigami, apol Cc: plasma-devel, apol, davidedmundson, mart, hein

D10502: Eliminate unnecessary bottom pading on OverlaySheets

ngraham created this revision. ngraham added reviewers: Kirigami, apol. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The OverlaySheet already defines a bottomMargin, so we do

D10475: Make it possible to show the title despite having ctx actions

ngraham added a reviewer: abetts. ngraham added a comment. Great, now we have the titles on the left, like @mart wants. We're getting there! There are a couple remaining issues: - Needs a re-base as it doesn't apply cleanly onto current master - Now everything in the header is left-ali

D10461: GMenu-DBusMenu-Proxy

rilian added a comment. Hello, I am Konstantin, developer of vala-panel-appmenu. I have some comments about your application. MenuModel protocol consitsts for 5 items: AppMenu - with property _GTK_APPMENU_OBJECT_PATH MenuBar - with property _GTK_MENUBAR_OBJECT_PATH It is a

D10500: Make the review pop-up a bit more user-friendly

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu

D10500: Make the review pop-up a bit more user-friendly

ngraham created this revision. ngraham added a reviewer: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Polish the design of the review input pop-up, and

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27129. apol added a comment. Make the title actually stay to the left REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27083&id=27129 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED

D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau added inline comments. INLINE COMMENTS > spellcheck.cpp:222 > +Plasma::QueryMatch match(this); > +match.setType(Plasma::QueryMatch::HelperMatch); > match.setIconName(QStringLiteral("checkbox")); Not sure if HelperMatch is the correct thing here. Simi

D10499: [spellcheck runner] Make each suggestion copyable as separate item

kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Before all suggestions are only shown as single item with a te

D10498: Workaround the touchpad toggle button not working

aacid added a comment. I updated the comment, can you have a look and approve again? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo

D10498: Workaround the touchpad toggle button not working

xuetianweng accepted this revision. xuetianweng added a comment. I sent the comment before you corrected the diff branch. LGTM. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: plasma-de

D10498: Workaround the touchpad toggle button not working

aacid updated this revision to Diff 27126. aacid added a comment. better? explanation of why the workaround works REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10498?vs=27125&id=27126 BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.

D10498: Workaround the touchpad toggle button not working

xuetianweng accepted this revision. xuetianweng added a comment. This revision is now accepted and ready to land. Oh, ok.. now the diff looks normal. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xue

D10498: Workaround the touchpad toggle button not working

xuetianweng added a comment. Emm, mind to get rid of the .desktop part for this review? Also I think you need to give some explanation about why this works. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: p

D10498: Workaround the touchpad toggle button not working

aacid updated this revision to Diff 27125. aacid added a comment. correct diff against Plasma/5.12 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10498?vs=27123&id=27125 BRANCH arcpatch-D10498 REVISION DETAIL https://phabricator.kde.org/D10498

D10498: Workaround the touchpad toggle button not working

aacid updated this revision to Diff 27123. aacid edited the summary of this revision. aacid added a comment. [try to] add BUGS: REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10498?vs=27122&id=27123 BRANCH arcpatch-D10498 REVISION DETAIL https:

D10498: Workaround the touchpad toggle button not working

aacid added reviewers: davidedmundson, xuetianweng. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10498 To: aacid, davidedmundson, xuetianweng Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

aacid added a comment. My proposal to fix the bug at https://phabricator.kde.org/D10498 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: aacid, z3ntu, ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesl

D10498: Workaround the touchpad toggle button not working

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. TEST PLAN Without it the touchpad toggle at my laptop just toggles once now it works fine all the time REPOSITORY R1

Re: D10489: Fix the tray icon scaling

For some reason this request is hidden? On Tue, Feb 13, 2018 at 8:05 PM, Piotr Kosinski wrote: > pgkos created this revision. > Restricted Application added a project: Plasma. > Restricted Application added a subscriber: plasma-devel. > pgkos requested review of this revision. View Revision >

D10480: align checkable widgets in menu items

zzag added a comment. F5710626: with-check.png F5710628: no-check.png F5710630: no-icons.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10

D10480: align checkable widgets in menu items

zzag updated this revision to Diff 27116. zzag added a comment. - try to align check boxes by increasing MenuItem_MarginWidth - fix another double space problem REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10480?vs=27072&id=27116 BRANCH center-checkbox

D10495: Workaround to restore KF5 programs from system tray

wbauer added a subscriber: KWin. wbauer added a comment. Indeed. One thing that started this is https://bugs.kde.org/show_bug.cgi?id=389663 I do think this should be fixed on the lower level if possible. Adding KWin as subscriber as well to hopefully get most people that have more

D10480: align checkable widgets in menu items

zzag added a comment. F5710509: a.png //Side note: This patch tries to center every checkbox between the left border and blue rect(and it also ignores margins.)// F5710580: Screenshot_20180214_002713.png

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27114. pgkos added a comment. Use units.smallSpacing for padding instead of magic numbers. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27105&id=27114 BRANCH tray-icon-size-fix REVISION DETAIL ht

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Padding is fine. We're just saying that: - You need to retain the default appearance for a default sized panel - You need to use programmatic padding values rather than magic numbers REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.o

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. I have tried and tested this diff without any padding, and trust me, it looks very bad - **I would rather have this patch not accepted** - than not to add any padding. Particularly, the tray icons look extremely bad when there is no padding - I suppose this is bec

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson added a comment. Yeah, the clock code isn't something I'd accept either. > But with your attitude it will be difficult to justify anything. Plasma has a predefined margin size smallSpacing. If you're using something else, it probably isnt' going to end up consistent.

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. In D10487#205827 , @pgkos wrote: > I could argue that the numbers come from Material Design guidelines - it recommends between 10% to 20% of padding ar

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. I could argue that the numbers come from Material Design guidelines - it recommends between 10% to 20% of padding around icons. But with your attitude it will be difficult to justify anything. RE

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. So maybe you tell me where this comes from? https://cgit.kde.org/plasma-workspace.git/commit/applets/digital-clock/package/contents/ui/DigitalClock.qml?id=90ea27f49c84f0dffbbf79b29eaa14c57f31a24d REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D10495: Workaround to restore KF5 programs from system tray

stikonas added a comment. This is more to start some discussion on system tray under Wayland. I'm not sure myself if this should be committed. I just use this workaround locally until winId() works on Wayland. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D1

D10495: Workaround to restore KF5 programs from system tray

stikonas created this revision. stikonas added reviewers: wbauer, Plasma, davidedmundson, volkov. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. stikonas requested review of this revision. REVISION SUMMARY Currently

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I'm not merging a patch that just adds random numbers that you happen to think look good. It's not unification if you can't justify where the numbers come from

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. I have tested it with the panel in both horizontal and vertical orientations, and 0.85 looks optimal for me. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces, davidedmundson Cc: ngraham, davidedmunds

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27105. pgkos added a comment. Squashed the commits REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27103&id=27105 BRANCH tray-icon-size-fix REVISION DETAIL https://phabricator.kde.org/D10487 AFFECT

D10480: align checkable widgets in menu items

hpereiradacosta added a comment. In D10480#205772 , @zzag wrote: > > In principle it should not be needed. Right ? > > Yes. > > > Ifcheckboxes have a fixed size, and if margins would be equal to spacing, and if the math are correct, havin

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27103. pgkos added a comment. Make the padding of all the panel icons the same CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27095&id=27103 BRANCH tray-icon-size-fix REVISION DETAIL https://phabricator.kde.org/D10487 AFFECTED FILES

D10480: align checkable widgets in menu items

zzag added a comment. > In principle it should not be needed. Right ? Yes. > Ifcheckboxes have a fixed size, and if margins would be equal to spacing, and if the math are correct, having something laied out as: margin + checkbox + spacing + icon + spacing + text would be automatical

D10490: Add a method to dbus interface to query information about a window

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Cool approach. One minor thing that won't happen anyway. INLINE COMMENTS > dbusinterface.cpp:193 > +{ > +m_replyQueryWindowInfo = message(); > +setDelayedReply(true); can you add: if

D10490: Add a method to dbus interface to query information about a window

broulik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > dbusinterface.cpp:199 > +const QVariantMap ret{ > +{QStringLiteral("resourceClass"), c->resourceClass()}, > +{QStringLiteral

D10438: reserve space for checkable widgets in menu items

hpereiradacosta added a comment. In D10438#205519 , @zzag wrote: > Maybe an option like "Reserve space for check boxes" should be added in fine tuning settings? Please no option. If we put an option to every feature we are not sure about,

D10480: align checkable widgets in menu items

hpereiradacosta added a comment. Ok. So, the patch works, but ... there is something fishy here. In principle it should not be needed. Right ? Ifcheckboxes have a fixed size, and if margins would be equal to spacing, and if the math are correct, having something laied out as: margin + chec

D10483: Polish ToolBarApplicationHeader appearance

This revision was automatically updated to reflect the committed changes. Closed by commit R169:667cc4318a18: Polish ToolBarApplicationHeader appearance (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27096&id=27097 REVISION DE

D10483: Polish ToolBarApplicationHeader appearance

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH header-polish REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: abetts, #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > The 0.8 is used to create a small padding, so the icons never touch the panel's borders. If the goal of the patch is to make the icon sizes the same as the i

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. I fear this will generate the exact same types of user complaints that the huge clock text did before we gave it more vertical padding: people will say that the icons are too tall and don't have enough padding. Let's try not changing the appearance and vertical paddi

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. This patch also enables the user to configure the tray icon's size limit using System Settings -> Icons -> Advanced -> Panel REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces Cc: ngraham, davidedmunds

D10483: Polish ToolBarApplicationHeader appearance

ngraham added a comment. I've reverted the title alignment changes for now. There are too many patches in flight to keep up! If this is good, let's land it (and also Aleix's patches once they're all good too) and then I'll iterate on the titles a bit more. Does that sound like a plan? REPOS

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: abetts, #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. The 0.8 is used to create a small padding, so the icons never touch the panel's borders. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff

D10483: Polish ToolBarApplicationHeader appearance

ngraham updated this revision to Diff 27096. ngraham added a comment. Revert change to center title REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10483?vs=27071&id=27096 BRANCH header-polish REVISION DETAIL https://phabricator.kde.org/D10483 AFFECT

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks! please close 389982 REPOSITORY R119 Plasma Desktop BRANCH definenopluginwithlookandfeeltool REVISION DETAIL https://phabricator.kde.org/D10485 To: kosse

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27095. pgkos added a comment. Fix tray icon scaling REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27089&id=27095 BRANCH tray-icon-size-fix REVISION DETAIL https://phabricator.kde.org/D10487 AFFEC

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. For me this patch still has the titles aligned to the right, even after your change: F5710374: right.png But as currently implemented, if we move the title over to the left as I'm asking for, then the above image would

[Breeze] [Bug 364849] Tooltip Text in several qt apps such as Amarok and Krusader is unreadable (white on white) with the Breeze/Breeze Dark color schemes

https://bugs.kde.org/show_bug.cgi?id=364849 Myriam Schweingruber changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

D10490: Add a method to dbus interface to query information about a window

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10489: Fix the tray icon scaling

pgkos created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. pgkos requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH tray-icon-size-fix REVISION DETAIL https://phabricator.kde.org/D10489 AFFE

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

ngraham added a comment. Thanks for the patch! 1. Please follow the formatting guidelines in https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch 2. Please update the Test Plan section with evidence of testing. A pair of before-and-after screenshots is always very

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

davidedmundson added a comment. Which application icons, and where are they set to 0.8? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10487 To: pgkos, #plasma_workspaces Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensre

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos created this revision. pgkos added a reviewer: Plasma: Workspaces. pgkos added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. Restricted Application added a subscriber: plasma-devel. pgkos requested review of this revision. R

D10475: Make it possible to show the title despite having ctx actions

ngraham added a comment. No, but in Desktop mode, if the window is not widescreen, then the left side of the header currently gets navigation buttons: Back when you can go back, and after the first time you go back, Forward is shown, too. REPOSITORY R169 Kirigami REVISION DETAIL https:/

D10475: Make it possible to show the title despite having ctx actions

apol added a comment. In D10475#205609 , @ngraham wrote: > Also, what happens to the navigation buttons if you're not in widescreen view? You get navigation buttons, and then context actions, and then the title? That'll be an awful lot of conten

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27083. apol added a comment. Keep the title aligned to the left REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27074&id=27083 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED FILES

D10475: Make it possible to show the title despite having ctx actions

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This patch makes the title right-aligned, which is non-standard with anything. Let's keep it left-aligned for now. Also, what happens to the navigation buttons if you're not in

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

apol updated this revision to Diff 27080. apol added a comment. Fix the search page REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10471?vs=27034&id=27080 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10471 AFFECTED FILES

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau added a reviewer: mart. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10485 To: kossebau, #freebsd, tcberner, bshah, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10483: Polish ToolBarApplicationHeader appearance

mart added a comment. In D10483#205563 , @abetts wrote: > Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the

D10485: [lookandfeel kcm] Do not declare plugin in lookandfeeltool code version

kossebau created this revision. kossebau added reviewers: FreeBSD, tcberner, bshah. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also improves race condition on creating the J

D7849: Fix the tray icon scaling on HiDPI screens

ngraham added a comment. Does this actually fully fix https://bugs.kde.org/show_bug.cgi?id=360333? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson

D10461: GMenu-DBusMenu-Proxy

broulik updated this revision to Diff 27077. broulik retitled this revision from "WIP: GMenu-DBusMenu-Proxy" to "GMenu-DBusMenu-Proxy". broulik edited the summary of this revision. broulik added a comment. - Cleanup code and use categorized logging - Monitor action changes (e.g. toggled stat

D10475: Make it possible to show the title despite having ctx actions

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D10475 To: apol, #kirigami, mart Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10475: Make it possible to show the title despite having ctx actions

apol updated this revision to Diff 27074. apol added a comment. Have the 3-dots button rightmost REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10475?vs=27033&id=27074 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10475 AFFECTED FILES

D10483: Polish ToolBarApplicationHeader appearance

abetts added a comment. Sorry guys, this proposed left alignment just won't work IMHO. The reason is that we are turning the bar into a CSD. Unlike a desktop application, we don't have the ability to shrink the application in mobile. What this amounts to is that people will want to add more

D10475: Make it possible to show the title despite having ctx actions

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10475 To: apol, #kirigami Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein

D10471: Use Kirgami.ToolBarApplicationHeader instead of the view headers

ngraham edited the summary of this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10471 To: apol, ngraham Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10480: align checkable widgets in menu items

zzag updated this revision to Diff 27072. zzag added a comment. fix checkbox aligning when there is no any icon REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10480?vs=27062&id=27072 BRANCH center-checkbox REVISION DETAIL https://phabricator.kde.org/D10

Plasma 5.12.1

Plasma 5.12.1 is now out for your compilers https://www.kde.org/announcements/plasma-5.12.1.php

D10438: reserve space for checkable widgets in menu items

zzag added a comment. Alright here's a patch which would make possible to turn off reserving space. Yet, a checkbox should be added in "Fine tuning" tab. From 45be224b2fb31966a3117aa1f226f8ea711f8109 Mon Sep 17 00:00:00 2001 From: Vlad Zagorodniy Date: Tue, 13 Feb 2018 17:44:43

D10483: Polish ToolBarApplicationHeader appearance

ngraham edited the test plan for this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10483 To: ngraham, #kirigami, mart Cc: #discover_software_store, plasma-devel, apol, davidedmundson, mart, hein

D10483: Polish ToolBarApplicationHeader appearance

ngraham created this revision. ngraham added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Increase the toolbar height by 4 pixels, to make it loo

D10438: reserve space for checkable widgets in menu items

mmustac added a comment. I am a user :-D To be honest I liked Vlad`s proposal after my first comment a lot. { margin-left: 10px; } The current implementation is nothing I would really like to have and be definitly a reason to search for a solution or another theme (which would propably b

D10438: reserve space for checkable widgets in menu items

zzag added a comment. Maybe an option like "Reserve space for check boxes" should be added in fine tuning settings? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: alake, colomar, januz, fabianr, mmustac, abe

D10438: reserve space for checkable widgets in menu items

hpereiradacosta added a comment. In D10438#205505 , @ngraham wrote: > FWIW I like it, but since this is mostly subjective, I wouldn't fight to the death to retain if if everyone else suddenly hated it. ok. Maybe it is just a question to g

D10438: reserve space for checkable widgets in menu items

ngraham added a comment. FWIW I like it, but since this is mostly subjective, I wouldn't fight to the death to retain if if everyone else suddenly hated it. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: ala

D10438: reserve space for checkable widgets in menu items

hpereiradacosta added subscribers: colomar, alake. hpereiradacosta added a comment. So ... I applied the patch (which I approved), used it, and ... don't like it sorry. See attached screenshots I think the unnecessary space breaks alignment with the menu above. and is completely unnecessa

D10475: Make it possible to show the title despite having ctx actions

mart added a comment. I like it! tough i think the more actions button should always be on the right of everything else, including the title REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10475 To: apol, #kirigami Cc: mart, ngraham, plasma-devel, apol, davidedmu

D10482: Add an isNull() check before setting wheter QIcon is a mask

icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY To avoid stepping on a null QIcon. This can happen when calling ::fromTheme with a i

D10480: align checkable widgets in menu items

zzag added a comment. > this is because you have to rely on maxIconWidth, even if the current item has no icon, when computing the checkbox space. I've came up with something like this if( showIcon && menuItemOption->maxIconWidth > 0 ) { int dx = (iconRect.left() - Metr

D10481: Add FormLayout.qml to kirigami.qrc

icota created this revision. icota added a reviewer: Kirigami. icota added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Can't use form layout in an app that includes(kirigami.pri) otherwise REPOSITORY R

D10480: align checkable widgets in menu items

zzag marked 2 inline comments as done. zzag added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breezestyle.cpp:4701 > why was this chunk of code moved ? This is unrelated to the change. > Please try keep the diff to the minimum To keep it consistent: 1. compute required rectangle

D10480: align checkable widgets in menu items

zzag updated this revision to Diff 27062. zzag added a comment. delete changes not related to this diff REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10480?vs=27051&id=27062 BRANCH center-checkbox REVISION DETAIL https://phabricator.kde.org/D10480 AFF

  1   2   >