D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207435 , @mvourlakos wrote: > > Would you please add a HACK so that we know when to remove this? > > You mean as a comment ? Yes, preferably with the Qt bug number and some explanation.

D10490: Add a method to dbus interface to query information about a window

graesslin marked an inline comment as done. graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > davidedmundson wrote in dbusinterface.cpp:193 > can you add: > > if (m_replyQuery...) {sendError()} > > otherwise if a user makes

D10490: Add a method to dbus interface to query information about a window

graesslin updated this revision to Diff 27318. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Remove unneeded comment REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10490?vs=27094=27318 BRANCH

D10480: align checkable widgets in menu items

zzag added a comment. > Here: if you look at the last checkbox (folders first). The distance to the left edge is larger to that of the bottom edge, while before they were identical. Oh, I haven't noticed that before. To me, that's still fine. > So this really depends on what we

D9638: [effects] replace old slide effect with a new one

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ddd406dfd91c: [effects] replace old slide effect with a new one (authored by zzag). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST

Does Breeze provide QtQuick2 theming?

Hello, I was testing a QtQuick2 application (https://github.com/agateau/sfxr-qt). One thing I noticed, using dark color schemes (i.e Breeze Dark) result in unreadable white-ish text on white window backgrounds in QtQuick2 applications like [1]. Example code in Qt docs also show similar behavior.

D10563: Place toolbox in the top right corner of the screen

cfeck added inline comments. INLINE COMMENTS > ToolBoxRoot.qml:143 > function placeToolBox(ts) { > +// if nothing has been setup yet, determin default position based on > layout direction > +if (!ts) { 'determine' REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10259: [Look and feel KCM] Fix copying color scheme data

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ab44dcb86b1: [Look and feel KCM] Fix copying color scheme data (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10259?vs=26399=27313#toc REPOSITORY R119 Plasma

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. > Would you please add a HACK so that we know when to remove this? You mean as a comment ? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9275 To: mvourlakos, #plasma, mart Cc: safaalfulaij, mart, plasma-devel,

D10563: Place toolbox in the top right corner of the screen

ngraham added a comment. Apparently Kubuntu has been patching this for three years. I only found out today... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10563 To: broulik, #plasma, #vdg, ngraham Cc: rikmills, ngraham, plasma-devel, ZrenBot, progwolff,

D10563: Place toolbox in the top right corner of the screen

broulik added a comment. > If and when this goes in, any chance you could land it for 5.12.x? Strictly speaking, this is a behavior change, feature, not a bugfix per se. > This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12.

D10563: Place toolbox in the top right corner of the screen

ngraham added a comment. If and when this goes in, any chance you could land it for 5.12.x? This would let Kubuntu get rid of a downstream override, and help other distros planning to package 5.12. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10563 To:

D10562: [Clipboard plasmoid] Improved barcode selection button

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7ef47a72bffc: [Clipboard plasmoid] Improved barcode selection button (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10563: Place toolbox in the top right corner of the screen

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10563 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff,

D10563: Place toolbox in the top right corner of the screen

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10563 To: broulik, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10563: Place toolbox in the top right corner of the screen

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This moves it out of the way of desktop icons and is also

D10560: [Clipboard plasmoid] Support Aztec barcode

davidedmundson added a comment. There surely needs to be some CMake change somewhere with the version? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10560 To: broulik, #plasma, graesslin, vkrause Cc: davidedmundson, plasma-devel, ZrenBot, progwolff,

D10562: [Clipboard plasmoid] Improved barcode selection button

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10562 To: broulik, #plasma, graesslin, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10562: [Clipboard plasmoid] Improved barcode selection button

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Right-align the menu to the button and keep the button

D10560: [Clipboard plasmoid] Support Aztec barcode

broulik created this revision. broulik added reviewers: Plasma, graesslin, vkrause. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This was added in Prison 5.42 TEST PLAN

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. One small suggestion to improve the clipboard code. INLINE COMMENTS > Module.cpp:256 > +{ > +auto clipboard = QGuiApplication::clipboard(); > +QMapIterator i(collectedData); Nitpicking: Why do you declare the clipboard here, when you use

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. Thinking about it, what about this: The dialog already has all the QLabels. What you could do is something along the lines: QString text; if (!ui->plasma.text().isEmpty()) { text += i18n("%1: %2", ui->plasmaLabel, ui->plasma.text()); } if

D10557: [Clipboard plasmoid] Split delegate into separate files

broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The delegate is quite heavy with lots of seldom used

D7087: Add "Copy Info" button to the About System KCM

rkflx added a comment. In D7087#207286 , @dhaumann wrote: > In fact, I wonder whether there already is a script or similar helper tools that give you this kind of system information. I currently do not remember, though... Anyone else? Do

D10552: Keep item highlighted when context menu opens

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. and others excluding Kickoff :P REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10552 To: hein, #plasma, broulik Cc: broulik,

D10259: [Look and feel KCM] Fix copying color scheme data

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Looks good to me but I don't feel confident enough to give it a shipit but if it fixes the unittest and works.. REPOSITORY R119 Plasma Desktop BRANCH fixsettingcolorschemelnf

D7087: Add "Copy Info" button to the About System KCM

dhaumann added a comment. I can see the reason for English text only. Then again, I think that @rkflx has a very valid argument as well. I do not know any other place in KDE that intentionally uses non-translatable text. That's why I agree with @rkflx to better translate this. In fact,

D9275: fix RTL appearance for ComboBox

safaalfulaij added a comment. In D9275#207260 , @mvourlakos wrote: > @mart I fixed this issue by changing these lines to: > > 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > 114

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @mart I fixed this issue by changing these lines to: 113LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft 114LayoutMirroring.childrenInherit: true REPOSITORY R242 Plasma Framework (Library) REVISION

D9275: fix RTL appearance for ComboBox

mvourlakos added a comment. @safaalfulaij @mart we need to revert this... with frameworks 5.43 it reverses list items always!!! The issue is still present when the PlasmaComponents3.ComboBox is used in the Latte settings window, that is the items are not aligned correctly in

D10392: Don't trigger SwipeListItem's actions unless they are exposed

icota updated this revision to Diff 27292. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10392?vs=27290=27292 REVISION DETAIL https://phabricator.kde.org/D10392 AFFECTED FILES src/controls/templates/SwipeListItem.qml To: icota, #kirigami Cc: ngraham,

D10392: Don't trigger SwipeListItem's actions unless they are exposed

icota added a comment. @mart Only as a favour to you for the more elegant solution. Thanks! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10392 To: icota, #kirigami Cc: ngraham, mart, apol, plasma-devel, davidedmundson, hein

D10392: Don't trigger SwipeListItem's actions unless they are exposed

icota updated this revision to Diff 27290. REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10392?vs=26783=27290 REVISION DETAIL https://phabricator.kde.org/D10392 AFFECTED FILES src/controls/templates/SwipeListItem.qml To: icota, #kirigami Cc: ngraham,

D10297: Add new "Tools" button above System Monitor's process list

ngraham added a comment. I think putting on that tab seems sensible enough because it's one of the default tabs, and the one that ksysguard opens to. Anybody sho'w such an advanced user that they customize their ksysguard tabs and don't use this one isn't actually going to need these tools

D10392: Don't trigger SwipeListItem's actions unless they are exposed

mart added a comment. that's how i did it locally tough still need fixes Item { id: behindItem parent: listItem z: -1 //TODO: a global "open" state enabled: background.x !== 0 do you want to push this yourself? REPOSITORY R169 Kirigami REVISION DETAIL

D10553: Fix dash, enable dash settings, and card options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:dbc370f8c72a: Fix dash, enable dash settings, and card options (authored by Aiix). REPOSITORY R846 Mycroft Plasma

D10553: Fix dash, enable dash settings, and card options

Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Dash improvements to mycroft plasmoid - Dashboard activation when

D10346: check for EGL_KHR_platform_gbm extension as well

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R108:8a2b9a014f7d: check for EGL_KHR_platform_gbm extension as well (authored by mart). Restricted Application edited

D10552: Keep item highlighted when context menu opens

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Now consistent with Kicker and others. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL

D10550: Unbreak DND.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1b771cc9: Unbreak DND. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10550?vs=27279=27280 REVISION DETAIL

D10550: Unbreak DND.

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY Fixes regression from 31bcd0ac9590 . REPOSITORY R119

D10549: Don't crash if the cursor theme fails to create

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10346: check for EGL_KHR_platform_gbm extension as well

graesslin accepted this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10346 To: mart, #kwin, #plasma, davidedmundson, graesslin Cc: graesslin, garg, davidedmundson, plasma-devel, kwin, iodelay,

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:53ed39aaa477: Micro-optimise screenpool event filter by caching xcb extension offset (authored by davidedmundson).

Plasma sprint in Berlin, Germany: April 21st-27th 2018

Hi, I'm happy to announce we're going to have another Plasma sprint in a few months, from April 21st to April 27th in Berlin, Germany. Join the sprint to make all things Plasma even better in an intense-but-fun week of planning, designing and hacking! The sprint will be held at the offices of

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10259 To: kossebau, broulik, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

jtamate accepted this revision. jtamate added a comment. F5713055: plasmashell_screenpool_after.png Even the number of calls registered are less, now most of the time is spent doing the eventType != "xcb_generic_event_t". REPOSITORY R120 Plasma

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

asturmlechner added a comment. > (so as to not conflict with kdelibs4's kdesu). I don't think you need to care about conflicts with kde-runtime at this point. There is no reason why on a Plasma-5 system the old binary should be present as it works like a drop-in replacement. REPOSITORY

D10297: Add new "Tools" button above System Monitor's process list

rkflx added a comment. Just tried the patch. I think for System Activity / [Ctrl] + [⎋] the button is fine (annoyingly with a slightly larger height than the combobox, but that's life…). For KSysGuard itself it looks a bit odd, why would it appear exactly on this tab page? I could imagine

D10500: Make the review pop-up a bit more user-friendly

abetts added a comment. Looks good to me. I would change the hover animation. Most places that use star ratings tend to highlight all stars up to where your cursor is located. It gives the impression that you are also enabling the starts up to your location. If your cursor is in the fourth

D7087: Add "Copy Info" button to the About System KCM

rkflx added a comment. And what if someone is asked in a forum or chat operating in a language different than English to provide those information? I'd say we should just go with the flow, i.e. what you see is what gets copied. It's already translated, just like what you can copy in Help >

D10500: Make the review pop-up a bit more user-friendly

ngraham added reviewers: apol, abetts. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10500 To: ngraham, #discover_software_store, apol, abetts Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D10548: Improve app list padding under the header

This revision was automatically updated to reflect the committed changes. Closed by commit R134:89cf44b3e207: Improve app list padding under the header (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10548?vs=27273=27274

D10548: Improve app list padding under the header

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH fix-app-list-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D10548 To: ngraham, #discover_software_store, apol Cc: plasma-devel,

D10548: Improve app list padding under the header

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10548 To: ngraham, #discover_software_store, apol Cc: plasma-devel, abetts, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10548: Improve app list padding under the header

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Make sure the delegates don't touch the

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. normal in Latte F5713010: εικόνα.png needsattention in Latte F5713020: εικόνα.png REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL

D10516: Update status to NeedsAttention when there is a menu

mvourlakos closed this revision. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. merged with: https://commits.kde.org/plasma-active-window-control/d07bd170d39adab35b7861ab6c480286a4d0253e REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D10516 To: mvourlakos, martinkostolny Cc: broulik,

D7087: Add "Copy Info" button to the About System KCM

gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham, dhaumann Cc: dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7087: Add "Copy Info" button to the About System KCM

gregormi added a comment. In D7087#207081 , @ngraham wrote: > Fine from my side. We still need to figure out the translation issue--either work to make it translatable, or accept that this output will be English-only. I'll let the other

D10525: Only let the user write the first review if they've actually installed the app

This revision was automatically updated to reflect the committed changes. Closed by commit R134:e6c35b6d5c69: Only let the user write the first review if theyve actually installed the app (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10525?vs=27271=27272#toc

D10516: Update status to NeedsAttention when there is a menu

mvourlakos added a comment. In D10516#206606 , @martinkostolny wrote: > thanks! fatal: remote error: service not enabled: /plasma-active-window-control unfortunately I can commit, I get: fatal: remote error: service not

D10525: Only let the user write the first review if they've actually installed the app

ngraham updated this revision to Diff 27271. ngraham added a comment. Remove the enabled: part of this patch; will manually commit it to 5.12, since it has no string changes REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

davidedmundson updated this revision to Diff 27270. davidedmundson added a comment. change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10538?vs=27252=27270 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10538 AFFECTED FILES

D10544: Avoid cmake duplication

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fdd24e9f7ad3: Avoid cmake duplication (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10544?vs=27255=27269 REVISION DETAIL

D10527: Improve "show more reviews" string and logic

This revision was automatically updated to reflect the committed changes. Closed by commit R134:47d77057ded5: Improve show more reviews string and logic (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10527?vs=27209=27268

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

jtamate added inline comments. INLINE COMMENTS > broulik wrote in screenpool.cpp:44 > Needs x11 guard Shouldn't it be a #if HAVE_X11? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10538 To: davidedmundson, #plasma, broulik Cc: jtamate, mart, broulik,

D10524: Improve ToolBarApplicationHeader left padding and eliding behavior

ngraham closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10524 To: ngraham, #kirigami, apol, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D7087: Add "Copy Info" button to the About System KCM

ngraham accepted this revision. ngraham added a comment. Fine from my side. We still need to figure out the translation issue--either work to make it translatable, or accept that this output will be English-only. I'll let the other reviewers have their say on that matter. REPOSITORY R102

D10512: try to preload certain applets in a smart way

mart updated this revision to Diff 27263. mart added a comment. - less aggressive preload policy REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10512?vs=27169=27263 BRANCH mart/preload REVISION DETAIL

D10545: [KickoffItem] Remove wrapper Item

This revision was automatically updated to reflect the committed changes. Closed by commit R119:df0e74966623: [KickoffItem] Remove wrapper Item (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10545?vs=27260=27262 REVISION DETAIL

D10546: [Kickoff] Turn ActionMenu into a QtObject

broulik abandoned this revision. broulik added a comment. `PlasmaComponents.MenuItem` is a QQuickItem, for whatever reason, I suspect for recursive enabled/visible handling, and with my patch it then complains about not having been placed in a scene. REPOSITORY R119 Plasma Desktop

D10546: [Kickoff] Turn ActionMenu into a QtObject

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10546 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10545: [KickoffItem] Remove wrapper Item

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10545 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10546: [Kickoff] Turn ActionMenu into a QtObject

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's not a visual item and the `PlasmaComponents.Menu` is also

D10545: [KickoffItem] Remove wrapper Item

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There's a `MouseArea` with `anchors.fill` within an `Item`, just

D10544: Avoid cmake duplication

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10544 To: davidedmundson, #plasma, bshah Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. Things look bad when a bitmap icon appears in the tray... (e.g. Remmina) It seems `roundToIconSize` is necessary for bitmap icons. I think I am going to abandon this patch, as the necessary changes are simply too big: - all references to `marginHints` in the

D10522: Added vertical separator

anemeth abandoned this revision. anemeth added a comment. This change was submitted to supplement D10438 Because it was reverted in D10530 this change is not needed anymore. REPOSITORY R31 Breeze REVISION DETAIL

D10544: Avoid cmake duplication

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY All things we need exists in the top level

Re: Plasma is very slowly

On Thu, Feb 15, 2018 at 2:13 PM, Christoph Feck wrote: > On 15.02.2018 11:24, Андрей Черный wrote: >> >> >> > > Why are you running plasmashell multiple times? Fix your mess before > bothering developers with it. htop lists every thread separately I think. Mine looks more

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

sitter added a comment. Currently targeting 5.12 but I am not too sure that is an entirely suitable change. Input welcome. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D10541 To: sitter Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10538: Micro-optimise screenpool event filter by caching xcb extension offset

davidedmundson updated this revision to Diff 27252. davidedmundson added a comment. guard REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10538?vs=27237=27252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10538 AFFECTED FILES

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY as recently mused over on the plasma-devel list. nobody really knows why it's not installed to

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos added a comment. With this new version the tray icons scale exactly like the application icons on the left (the "jumps" between icon sizes happen at exactly the same time). INLINE COMMENTS > anthonyfieroni wrote in main.qml:42 > I see it has configuration for icon size ? What about to

D10540: [Kickoff] Move RunnerModel to SearchView

This revision was automatically updated to reflect the committed changes. Closed by commit R119:30530ab36020: [Kickoff] Move RunnerModel to SearchView (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10540?vs=27249=27250 REVISION

D10540: [Kickoff] Move RunnerModel to SearchView

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10540 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10540: [Kickoff] Move RunnerModel to SearchView

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's only used there. TEST PLAN Verified that SearchView is

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

pgkos updated this revision to Diff 27248. pgkos added a comment. Cancel out the enlargement of AbstractItem by the tasksRow's marginHints. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10487?vs=27139=27248 BRANCH tray-icon-size-fix REVISION

Re: Plasma is very slowly

On 15.02.2018 11:24, Андрей Черный wrote: Why are you running plasmashell multiple times? Fix your mess before bothering developers with it.

D10512: try to preload certain applets in a smart way

mart added a comment. sooo, benchmarks: i tracked the time that occurs between mouse click and the return of setExpanded, which is reasonably near to the popup actually appearing (numbers consistent doing things more than once) this is done on a fairly fast machine, would be interesting

D6609: [Kickoff] Allow sorting favorites

broulik abandoned this revision. broulik added a comment. Probably needs to be completely redone with activities-powered favorites REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6609 To: broulik, #plasma, #vdg, davidedmundson Cc: hein, plasma-devel, ZrenBot,

D10480: align checkable widgets in menu items

hpereiradacosta added a comment. In D10480#206782 , @zzag wrote: > Well, I could rework this patch to fix double spacing. > > Centering of check boxes would involve some changes in margins, which should be another diff, right? > > >

D10507: Turn code.js into a singleton

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0d6792c4a7fc: Turn code.js into a singleton (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10507?vs=27151=27245 REVISION DETAIL

D10533: [Icon Item] Set filtering on FadingNode texture

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c05b1bdec790: [Icon Item] Set filtering on FadingNode texture (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10523: Fix warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b95460a4f831: Fix warnings (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10523?vs=27204=27243 REVISION DETAIL

D10535: Fix whitespace

This revision was automatically updated to reflect the committed changes. Closed by commit R111:50229e7ec3c2: Fix whitespace (authored by gregormi). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10535?vs=27232=27241 REVISION DETAIL

D10535: Fix whitespace

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D10535 To: gregormi, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10539: [Task Manager] Don't delay audio indicator when task appears

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0ead1a6e77e8: [Task Manager] Dont delay audio indicator when task appears (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

  1   2   >