Move krunner also to plasma bundle? (was: Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now)

2023-11-05 Thread Friedrich W. H. Kossebau
Am Sonntag, 5. November 2023, 15:32:21 CET schrieb christ...@cullmann.io: > On 2023-11-05 15:11, Nate Graham wrote: > > On 11/5/23 07:09, christ...@cullmann.io wrote: > >> if we are atm moving stuff, might it make sense to move Baloo, too, > >> given it only > >> is usable with the daemon inside

plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

2023-11-05 Thread Friedrich W. H. Kossebau
Hi, with plasma-framework, kactivities and kactivities entering the Plasma product bundle, I assume they also will adapt to Plasma versioning. Without any de-KF-ication though this will break things though for building consumers soonish. Example --- 8< --- find_package(KF6 ${KF_MIN_VERSION}

Developer setups for user D-Bus service files?

2022-01-11 Thread Friedrich W. H. Kossebau
Hi, (plasma-devel as CC: for heads-up, please reply only to kde-devel to keep discussion in one place) at least with systemd controlled start (but possibly also before) of the session D-Bus (based on what I understood so far, please correct me) for a user is not possible just by editing their

Moving plasma-frameworks & krunner to Plasma release set for *6? (was: Re: KF6 meeting notes 2021-04-17)

2021-04-23 Thread Friedrich W. H. Kossebau
(cc: plasma-devel for heads-up, not subscribed there, please re: only to kfd) Am Samstag, 17. April 2021, 16:11:24 CEST schrieb Luigi Toscano: > Several "needs input" tasks are related to Plasma. > Maybe it would be better to focus on Plasma next time and involve Plasma > people, and find out

Re: Relicensing Plasma Browser Integration Host to GPLv3+

2021-01-18 Thread Friedrich W. H. Kossebau
t folder: > > David Edmundson > Fabian Vogt > Laurent Montel > Friedrich W. H. Kossebau > Matthijs Tijink > > Are you fine with this, or have any other comments? Fine with me. Only touched build system/cmake code though, which is rather trivial and, if actually properly licensed, should be some BSD one? Cheers Friedrich

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > Oh, OK, now I remember, sorry for misinforming you... > > I haven't had any problems with this, it "Just Worked" :) Maybe it should > return just plain QObject*, I'm not experienced in this area, what do you

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kmaterka wrote in systemtray.h:100 > I don't know, this code was there before my changes, I've just done some > refactoring here. Thanks for your reply. Okay, so seems you did not hit anything related. Thing is, you added `` Q_INVOKABLE

D26992: [SystemTray] Use unified data model everywhere

2020-07-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > systemtray.h:100 > */ > -Q_INVOKABLE void reorderItemAfter(QQuickItem* after, QQuickItem* before); > - > -Q_INVOKABLE bool isSystemTrayApplet(const QString ); > +Q_INVOKABLE Plasma::Service *serviceForSource(const QString ); >

D22778: Restore option to create a Qt Designer plugin

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Rebased/Updated as https://invent.kde.org/plasma/libksysguard/-/merge_requests/10 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D22778 To: kossebau, #plasma, davidedmundson, mart Cc:

D12459: [Icon KCM] Port to new design

2020-04-25 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > main.cpp:393 > +for (int i = 0; i < KIconLoader::LastGroup; i++) { > +KIconLoader::emitChange(KIconLoader::Group(i)); > + Is KIconLoader::emitChange also for kde4 apps only? Asking as KIconLoader of KIconThemes seems to have

D29144: [applets/weather] Improve UX for selecting a weather station

2020-04-23 Thread Friedrich W. H. Kossebau
kossebau resigned from this revision. kossebau added a comment. No time left over for Plasma currently, sorry, REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

2020-04-19 Thread Friedrich W. H. Kossebau
Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > Hi all, > > Another breakage in Qt? Should be fixed now (restarted build now completed), with similar traps also removed for the future, thanks to David Faure for the work done and Ade for the root detecting investigations.

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

2020-04-19 Thread Friedrich W. H. Kossebau
Am Samstag, 18. April 2020, 16:26:57 CEST schrieb David Faure: > On Saturday, April 18, 2020 7:09:25 AM CEST Ben Cooksley wrote: > > Hi all, > > > > Please see below - any ideas as to why KHelpCenter no longer successfully > > builds? > > > > It doesn't look like KHelpCenter has changed... > >

D28134: Add ColorUtils

2020-04-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack,

D28360: cmake: make xsettingsd check an option

2020-03-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Yes, I would just do a patch for the 'PURPOSE' text, mentioning "Required" or "Optional" (whatever you decide on), based on previously discussions with packagers on similar cases. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

2020-03-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. Sadly Cmake does not have separate "RUNTIME-OPTIONAL" & "RUNTIME-REQUIRED" so far. Previously that was solved by noting the required vs. optional in the purpose text, so the info still arrived with packagers. Just "REQUIRED" means, it is required for the build.

D28360: cmake: make xsettingsd check an option

2020-03-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. See how it is done across KDE repos here: https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=TYPE+RUNTIME&_casesensitive=1 There should be no reason the same works here as well. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28360: cmake: make xsettingsd check an option

2020-03-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D28360#636615 , @eszlari wrote: > In D28360#636610 , @kossebau wrote: > > > Can you tell which packagers missed that this is a required runtime dependency? > > >

D28360: cmake: make xsettingsd check an option

2020-03-27 Thread Friedrich W. H. Kossebau
kossebau added a comment. Can you tell which packagers missed that this is a required runtime dependency? Noting runtime dependencies as done so far here, by not having it required and tagging it as "RUNTIME" is a pattern everywhere else in KDE code, so the proposed patch or just

D28330: Color icons in titlebar if possible

2020-03-27 Thread Friedrich W. H. Kossebau
kossebau added a comment. With cross-casting I meant the type of cast where the types involved are not in same inheritance branch INLINE COMMENTS > davidre wrote in breezebutton.cpp:148 > I don't think it can fail. decoration() is a QPointer >

D28330: Color icons in titlebar if possible

2020-03-27 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +

D28262: [applets/analog-clock] Optional minute hand

2020-03-24 Thread Friedrich W. H. Kossebau
kossebau resigned from this revision. kossebau added a comment. Resigning, due to currently not having time for Plasma development. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28262 To: aloiseau, #vdg, #plasma Cc: ngraham, aloiseau, plasma-devel, Orage,

D28142: Display PID & signal numbers unlocalized

2020-03-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R871:af4cd7a4cf5f: Display PID signal numbers unlocalized (authored by kossebau). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28142?vs=78022=78116 REVISION DETAIL

D28142: Display PID & signal numbers unlocalized

2020-03-19 Thread Friedrich W. H. Kossebau
kossebau added a comment. Not tested though, somehow my setup prevents my custom drkonqi to show up. So far I just know it tells and should work in theory. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28142 To: kossebau, #plasma, sitter Cc: plasma-devel, Orage,

D28142: Display PID & signal numbers unlocalized

2020-03-19 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY These are less numbers, but more identifiers in the system. REPOSITORY R871 DrKonqi

Re: 2 kirigami fixes for a point release

2020-02-18 Thread Friedrich W. H. Kossebau
Sorry, no time to rewrite to make this short. Am Mittwoch, 12. Februar 2020, 21:59:32 CET schrieb Nate Graham: > [+ frameworks and plasma mailing lists] > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va escriure: > >> On

Re: 2 kirigami fixes for a point release

2020-02-18 Thread Friedrich W. H. Kossebau
Am Dienstag, 18. Februar 2020, 04:03:05 CET schrieb Nate Graham: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our* > > problem, what I was disagreeing

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2020-02-03 Thread Friedrich W. H. Kossebau
kossebau resigned from this revision. kossebau added a comment. Good. So stepping out here :) REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D27036 To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

2020-01-30 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Here the initial patch to get a plasma subcategory on api.kde.org started, as

D26894: Enable publication of API dox on api.kde.org

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. For KDEPIM, the definition is in the akonadi repo: https://phabricator.kde.org/source/akonadi/browse/master/metainfo.yaml REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin, graesslin, zzag Cc:

D26894: Enable publication of API dox on api.kde.org

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D26894#602388 , @davidedmundson wrote: > Go for it. > > > If so, this change should trigger addition of KDecoration on api.kde.org, similar like KAsync is currently at the toplevel. > > If we could make a

D26894: Enable publication of API dox on api.kde.org

2020-01-29 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R129:e08b848015f5: Enable publication of API dox on api.kde.org (authored by kossebau). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

D26894: Enable publication of API dox on api.kde.org

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. So, with only positive feedback so far I would be going to merge this on 31st Jan. Or earlier, if you tell me :) REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin, graesslin Cc: zzag, plasma-devel,

D26894: Enable publication of API dox on api.kde.org

2020-01-29 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 74558. kossebau added a comment. keep Martin noted as maintainer, given no official step-down rebase to latest master REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26894?vs=74305=74558 BRANCH

D26894: Enable publication of API dox on api.kde.org

2020-01-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. I stumbled over that metainfo.yaml file and was wondering whether this would not be a lib that wants to be covered an api.kde.org. So, is kdecoration still a non-deprecated lib? If so, this change should trigger addition of KDecoration on api.kde.org, similar like

D26894: Enable publication of API dox on api.kde.org

2020-01-24 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R129 Window Decoration Library BRANCH addtoapikdeorg REVISION DETAIL

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578306 , @kossebau wrote: > Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib should be invoked before during loading, no? Time to go playing with the actual

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578299 , @broulik wrote: > Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. Uh, okay, that seems like

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578298 , @broulik wrote: > Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. Okay.

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578296 , @broulik wrote: > We don't link against Kirigami, so the startup routine stuff doesn't apply? `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, whose constructor

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578291 , @broulik wrote: > Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that.

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for things loaded as plugins like QML modules. Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION being nvoked during lib loading after the QApp instance exists still

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-12-04 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R858:8b0372d2932e: Fix typo in name of installed CMake Config: Deskop-Desktop (authored by kossebau). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-12-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. Np other opinion? Would then go with this in the next days... REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D12685: Fix calendar view: hide unused start/end time labels in day events list

2019-12-01 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Sadly lost track of this, and no plans to pick this up again in the foreseeable future given other stuff to do, so discarding now to clean up the todo stack. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-11-30 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 70633. kossebau added a comment. - keep old CMake Config files installed - no longer create unused version.h file REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23005?vs=63296=70633

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-11-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Something to consider in time for Plasma 5.18, post 5.17.5 and before 5.17.90) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D22778: Restore option to create a Qt Designer plugin

2019-11-29 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 70584. kossebau added a comment. Update to latest master REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22778?vs=62646=70584 BRANCH readdoptiontogeneratedesignerplugin REVISION DETAIL

D25488: kwayland-integration: fix compilation with no-deprecated build of kwindowsystem

2019-11-23 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. For a backport, one could perhaps do this after the includes: #fndef KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE #ifndef KWINDOWSYSTEM_NO_DEPRECATED #define

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

2019-10-31 Thread Friedrich W. H. Kossebau
kossebau resigned from this revision. kossebau added a comment. Sorry, currently no time for Plasma available: see also https://mail.kde.org/pipermail/plasma-devel/2019-October/105088.html REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25082 To: ngraham,

D18961: [WIP] [weather] Migrate nativeInterface config to plasmoid.configuration.*

2019-10-21 Thread Friedrich W. H. Kossebau
kossebau resigned from this revision. kossebau added a comment. Still sorry for having stalled this effort. Stepping down as maintainer of the weather applet now, so also resigning here. Might be the chance to pick this up and just move on :) REPOSITORY R114 Plasma Addons REVISION DETAIL

D12944: [weather applet] Show a note why "Show temperature" is disabled

2019-10-21 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. No time to care for this more, someone else needs to take over if needed/wanted, REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12944 To: kossebau, #plasma Cc: mart, ngraham, plasma-devel,

Re: Weather applet/dataengine: passing on maintainer baton

2019-10-21 Thread Friedrich W. H. Kossebau
Am Dienstag, 22. Oktober 2019, 00:42:01 CEST schrieb Friedrich W. H. Kossebau: > * https://bugs.kde.org/buglist.cgi? > bug_status=__open__=Weather_id=1672869=plasmashell > (though I remember some more open?) Indeed. Seems there are 2x components for the Plasma widget, once with pl

Weather applet/dataengine: passing on maintainer baton

2019-10-21 Thread Friedrich W. H. Kossebau
Hi, 3 and 1/2 years after I adopted the code for the weather applet in kdeplasma- addons and the respective weather dataengine in plasma-workspace, to make it live on in Plasma5 era instead of being moved into the attic*, I feel there are too many other things now which have more of my

D24749: Fix build with older glibc: link there to librt for clock_gettime

2019-10-21 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R111:3cd40fede73e: Fix build with older glibc: link there to librt for clock_gettime (authored by kossebau). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > meven wrote in CMakeLists.txt:57 > We have a bunch of apps to update, I used this because I found it in krusader > code Yes, due to having no proper cmake deprecation warnings there are still some with old code. But lots of porting already

D24758: [KEditFileType] Add a desktop file

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:57 > install( FILES filetypes.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} ) > +install(PROGRAMS org.kde.keditfiletype.desktop DESTINATION > ${XDG_APPS_INSTALL_DIR} ) KDE_INSTALL_APPDIR, please. XDG_APPS_INSTALL_DIR is

D24749: Fix build with older glibc: link there to librt for clock_gettime

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Only since glibc version 2.17 -lrt is no longer needed See same fix done for processui in

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24483#544263 , @ngraham wrote: > To me it makes conceptual sense to display windiness when it's not including other severe weather conditions. In those cases, you care more about the other conditions than the fact

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24483#544189 , @ngraham wrote: > Where I live (in the desert), we often have days that are very windy with no clouds or rain, especially in the springtime. On such days, the data engine always falls back to

D24483: [Weather data engine] Handle windy conditions in NOAA backend

2019-10-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. Disclaimer: nowhere a meteorologist myself, kitchen talk quality at best :) I have to tell I have no idea how "wind" actually matches the category and what general cloud/sky conditions could be derived. Where I have lived, wind as in: fast moving air masses

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. And attributes in general are better set before the application instance is created. Some attributes even need that, so defaulting to it is better, REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23840 To: guoyunhe, #plasma,

D23840: Enable HiDPI rendering for systemmonitor

2019-09-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Does this compile? What compiler are you using? At least it does not on CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-workspace/ When calling a static method of a class using the "::", one rather needs to use the classname, not the name of an

D23575: plasnoidviewer: restore support for --list & --list-themes

2019-08-30 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Seems this whole implementation is not useful, as there is dedicated KPackage API to use instead (and which then could be used also from KDevelop itself) as well as is the question if this feature is wanted to be restored like this.

D23575: plasnoidviewer: restore support for --list & --list-themes

2019-08-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. [09:29] kpackagetool5 --g --list --type Plasma/Applet for plasmoids [09:30] kpackagetool5 --g --list --type Plasma/Theme for themes [09:31] bshah: instinctively for me it makes sense to have one tool to remember when developing applets. I readded that code to

D23575: plasnoidviewer: restore support for --list & --list-themes

2019-08-30 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Got dropped during porting to Qt5 (last commit cleaning up dead code was

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

2019-08-26 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4f309328ee00: libtaskmanager: fix launch url for startup info with pathless desktop file (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23417?vs=64529=64665#toc

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

2019-08-24 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also drop checking if the suffix exists, the code is only reached because this condition has

D23307: [weather] [envcan] Add additional current condition icon mappings

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. Can you push this to the 5.16 branch? No new string for translators, so should be fine to improve for stable. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma, ngraham,

D23325: Use non-deprecated .metainfo.xml filename extension

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. I assume you also change the cmake install command in app/CMakeLists.txt in the final patch, though :) REPOSITORY R124 System Settings BRANCH appdata-to-metainfo (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D23325 To: ngraham,

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. @ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix: > While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hi @mak, so seems we appdata content creators are still unsure what to do, allow me to put the last question of last night again to your attention: In D23306#515666 , @kossebau wrote: > In D23306#515662

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kdesystemsettings.desktop:163 > X-DBUS-ServiceName=org.kde.systemsettings > +# Otherwise Discover and other software centers show two System Settings > entries > +X-AppStream-Ignore=true For what I understood from "No. A launchable tag always

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23306#515662 , @mak wrote: > In D23306#515616 , @kossebau wrote: > > > Thanks! Though reading it, leaves open questions with me: > > > > - what is meant by

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23306#515609 , @mak wrote: > @kossebau How to hide .desktop files from AppStream is now more visible in https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for kdevelop then. any chance we can see this trick documented on https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html , please? :) REPOSITORY R124 System Settings

D23302: Stop installing two desktop files

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. As KDevelop is affected similar, because we want two different entries to appear in the system application menu, can someone tell where appstream defines that there shall be only one menu desltop file per application? Why do those installers even look at the menu

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-08-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Only current user known is plasma-desktop, from R119:737b114c2fa5bf0b01951eeb2eef22ce7fcdcfa1 No other hits seen on internet No idea what is the most simple approach here, given KF

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

2019-08-07 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: mart, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fixcmakeconfigname REVISION DETAIL

D22778: [WIP] Restore option to create a Qt Designer plugin

2019-07-27 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 62646. kossebau added a comment. also port the other two plugins REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22778?vs=62645=62646 BRANCH readdoptiontogeneratedesignerplugin REVISION DETAIL

D22778: [WIP] Restore option to create a Qt Designer plugin

2019-07-27 Thread Friedrich W. H. Kossebau
kossebau created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Had been missing out the port to Qt5/KF5 so far Using ECMAddQtDesignerPlugin reduces added dependencies to QtUIPlugin Option

D11234: [DrKonqi] Show debug button when KDevelop session is running

2019-07-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

2019-06-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R169:89b9f8768ee4: Remove accidentally slipped back traces of cmake code for Plasma style (authored by kossebau). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-15 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f65a0eee09da: PanelView: align setting of masks with how its done for dialogs/tooltips (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-14 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 59800. kossebau added a comment. for completeness also remove mask for m_backgroundHints == Plasma::Types::NoBackground REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21803?vs=59798=59800 BRANCH

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. Compare with DialogPrivate::updateTheme(): https://phabricator.kde.org/source/plasma-framework/browse/master/src/plasmaquick/dialog.cpp$229 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21803 To: kossebau, #plasma Cc:

D21803: PanelView: align setting of masks with how it's done for dialogs/tooltips

2019-06-14 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY With Plasma dialogs & tooltips the mask is only set on the widget itself if compositing is

D21802: move various properties away from qapp and to kaboutdata

2019-06-14 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. I would leave out the explicit setting of otherwise default values, but people's preferences differ :) INLINE COMMENTS > main.cpp:78 > i18n("(C) 2000-2018,

D21799: actually set kaboutdata as application aboutdata

2019-06-14 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > main.cpp:89 > QStringLiteral("sp...@kde.org")); > +KAboutData::setApplicationData(aboutData); > qa.setWindowIcon(QIcon::fromTheme(QStringLiteral("tools-report-bug"), > qa.windowIcon())); This is partially

D21784: Remove accidentally slipped back traces of cmake code for Plasma style

2019-06-13 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Removed in e914e6323277f7963334897410bd9b7f8341f2ed

D20898: WIP: [kcms/desktoptheme] Switch knsrc to "Plasma 5 Theme" category

2019-05-17 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. There is no agreement that splitting off a separate category is the way to move forward, so discarding. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20898 To: kossebau, #plasma, apol, leinir,

D21097: Handle apps which set the desktopFileName property with filename suffix

2019-05-15 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0e50f23c4c43: Handle apps which set the desktopFileName property with filename suffix (authored by kossebau). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D21226: search for a default wallpaper in lookandfeel

2019-05-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. BTW, there is also still code in place to support Plasma Themes defining a default wallpaper (or even deploy some more). Though the default & the further are not listed in the Image wallpaper config, also is the config not offering any hint about the default or to

Re: Review Request: plasma-thunderbolt

2019-05-15 Thread Friedrich W. H. Kossebau
Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel

D14147: Port from GConf to GSettings

2019-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D14147#443705 , @kossebau wrote: > Seems this patch sadly broke the build on FreeBSD: https://build.kde.org/job/Plasma/view/Everything/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/ Solved for now with

D14147: Port from GConf to GSettings

2019-05-14 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > FindGIO.cmake:20 > +include(UsePkgConfig) > +pkgconfig(gio-2.0 _LibGIOIncDir _LibGIOLinkDir _LibGIOLinkFlags > _LibGIOCflags) > +endif(NOT WIN32) It seems `_LibGIOLinkFlags`, `_LibGIOLinkDir` & `_LibGIOCflags` are not propagated into

D21176: PanelView: update mask on window on change of panelMask property

2019-05-14 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f8d5e1a24e97: PanelView: update mask on window on change of panelMask property (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21176: PanelView: update mask on window on change of panelMask property

2019-05-13 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 57974. kossebau added a comment. keep old code for KF 5.58 compat REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21176?vs=57965=57974 BRANCH updatepanelmaskonchange REVISION DETAIL

D21176: PanelView: update mask on window on change of panelMask property

2019-05-12 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH updatepanelmaskonchange REVISION DETAIL

  1   2   3   4   5   6   >