D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R31:092d44603cef: re-read color palettes when application color changes (authored by sebas). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59333=59344 REVISION

D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
sebas added a comment. @sitter here's a review sending the reparseConfiguration signal from the Colors KCM. Thanks for the review, all! REPOSITORY R31 Breeze BRANCH colorchangeeventfilter REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma, broulik, sitter Cc:

D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
sebas added a comment. Done (assuming editing the phab description is enough). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D21646 To: sebas, #plasma Cc: cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
sebas updated this revision to Diff 59333. sebas added a comment. - Qt4 compat REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59332=59333 BRANCH colorchangeeventfilter REVISION DETAIL https://phabricator.kde.org/D21646 AFFECTED FILES

D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
sebas updated this revision to Diff 59332. sebas added a comment. - use QApplication::paletteChanged as Kai suggests REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21646?vs=59330=59332 BRANCH colorchangeeventfilter REVISION DETAIL

D21647: send signal to breeze to trigger reparsing the color scheme

2019-06-07 Thread Sebastian Kügler
sebas abandoned this revision. sebas added a comment. I agree. I initially preferred this approach since the other one involves installing a very global event filter. Since you proposed a cleaner solution there, let's go with that. I'll abandon this one. REPOSITORY R119 Plasma Desktop

D21647: send signal to breeze to trigger reparsing the color scheme

2019-06-07 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Without this patch, changing the application color scheme from system settings only affects some

D21646: re-read color palettes when application color changes

2019-06-07 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Without this patch, changing the application color scheme from system settings only affects some

D11220: option to force FolderView icon-only presentation

2018-03-12 Thread Sebastian Kügler
sebas added a comment. In principle yes, but the applet should of course react suitably to these constraints. A config option for this seems to duplicate the concept of constraints (which are indeed determined by the containment.) REPOSITORY R119 Plasma Desktop REVISION DETAIL

Minutes Monday Plasma Hangout

2018-03-05 Thread Sebastian Kügler
Today's minutes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 05-03-2018 Present: notmart, kbroulik, romangg, Sho_, psifidotos, bshah, d_ed notmart: * more bugfixes connected to preloading * more work on card component, taken a lot of time due to funny qqc2 bugs, most

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-01 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a comment. This revision now requires changes to proceed. I second that the icon should be made red, this mitigates the visibility issue and makes it consistent with the disconnected ethernet icon. @andreask, can you make this change?

D10896: Show config selection OSD when display button is pressed

2018-03-01 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R104:eacbddd22d99: Show config selection OSD when display button is pressed (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10896?vs=28251=28312

D10896: Show config selection OSD when display button is pressed

2018-02-28 Thread Sebastian Kügler
sebas updated this revision to Diff 28251. sebas added a comment. - clean up now-dead code REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10896?vs=28202=28251 BRANCH sebas/displaybutton REVISION DETAIL https://phabricator.kde.org/D10896 AFFECTED

D10896: Show config selection OSD when display button is pressed

2018-02-28 Thread Sebastian Kügler
sebas added a comment. OsdManager::showActionSelector() will delete existing OSDs before showing a new one, so we won't create multiple OSDs. That's arguably not as nice as tracking if it's already shown, but I think I'd rather avoid the added complexity of adding a check if it's already

D10896: show config selection osd when display button is pressed

2018-02-27 Thread Sebastian Kügler
sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY This makes the working of the display button much more

Minutes Monday Plasma Hangout

2018-02-26 Thread Sebastian Kügler
Monday meeting time! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 26-02-2018 Present: Sho, notmart, psifidotos, kbroulik, bshah, romangg Sho: * Fixed window delegates not being properly clamped to the desktop rect in the pager * Working on a KMessageWidget equivalent

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Sebastian Kügler
sebas added a comment. When landing, can you merge the whole branch into master, the history here is relevant and it will make continuing work on my kscreen kcm qmlification branch a lot easier. Thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To:

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot,

D10723: hide primary display combo when not supported

2018-02-23 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R104:cd3b350e0225: hide primary display combo when not supported (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10723?vs=27721=27835 REVISION

Re: What does LTS mean again?

2018-02-21 Thread Sebastian Kügler
On Tue, 20 Feb 2018 23:34:33 + Jonathan Riddell <j...@jriddell.org> wrote: > On Tue, Feb 20, 2018 at 09:13:42PM +0100, Sebastian Kügler wrote: > > Hi, > > > > I know we talked about it extensively and even put it into writing, > > but I can't find it a

D10723: hide primary display combo when not supported

2018-02-21 Thread Sebastian Kügler
sebas created this revision. sebas added reviewers: Plasma, dvratil. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY Some backends, for example the kwayland backend, do not support

What does LTS mean again?

2018-02-20 Thread Sebastian Kügler
Hi, I know we talked about it extensively and even put it into writing, but I can't find it anymore. What does our LTS promise for 5.12 entail? Cheers, -- sebas http://www.kde.org | http://vizZzion.org

Minutes Monday Plasma Hangout

2018-02-05 Thread Sebastian Kügler
Crisp and short, but progress! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 5 february 2018 Present: Sho, bshah, sebas, notmart Sho: * [General] Fixed desktop toolbox not closing on click outside and ESC * [FV] Much improved quality of preview thumbnails (were ugly and

D9984: WIP: Add bookmarks runner

2018-01-31 Thread Sebastian Kügler
sebas added a comment. That's what the "old" bookmarks runner was doing, it loaded the bookmarks from the file the browsers write out. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 To: broulik, #plasma, #vdg, davidedmundson Cc: sebas,

D10200: base listitemdelegate color on selected, not checked

2018-01-31 Thread Sebastian Kügler
sebas created this revision. sebas added reviewers: hein, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. sebas requested review of this revision. REVISION SUMMARY I can't say that I'm grasping the logic here completely,

D10042: Parse EDID on the backend side

2018-01-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. One minor thing to fix, otherwise the idea + approach look fine to me. Thanks! INLINE COMMENTS > edid_p.h:3 > + * Copyright (C) 2012 - 2014 by Daniel Vrátil >

Minutes Monday Plasma Hangout

2018-01-29 Thread Sebastian Kügler
Notes of today's meeting... Enjoy! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 29 january 2018 Present: Sho, notmart, d_ed, bshah, frinring, sebas Sho: i wrote patches for kio and kjobwidgets in an attempt to make kio confirmation dialogs spawned from fv modal all

D10019: Port minimize all applet from it's own plugin to org.kde.TaskManager

2018-01-22 Thread Sebastian Kügler
sebas added a comment. I like, getting rid of C++ code is always welcome. Once the patch to libtaskmanager is in and kbroulik's comments addressed, +2 from my side. Thanks! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10019 To: davidedmundson,

D9506: milti-screen sleep fix

2018-01-22 Thread Sebastian Kügler
sebas added a comment. Yeah, so could you abandon this phabricator review? It makes it harder to sift through reviews that actually are interesting... REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni,

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-22 Thread Sebastian Kügler
sebas added a comment. In https://phabricator.kde.org/D9414#193341, @dvratil wrote: > Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master. Sorry for

Minutes Monday Plasma Hangout

2018-01-22 Thread Sebastian Kügler
Meeting minutes and log... -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 22 january 2018 Present: Sho, notmart, d_ed, kbroulik, bshah, romangg, sebas Sho: * [Kicker] Fixed the search result that Enter/Return will run while still in the search field not being

D9506: milti-screen sleep fix

2018-01-22 Thread Sebastian Kügler
sebas added a comment. Alright, please abandon this patch then, it's definitely wrong. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D8652: Add supported transformations to OutputDevice

2018-01-19 Thread Sebastian Kügler
sebas added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Dingdong? REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas,

D9506: milti-screen sleep fix

2018-01-19 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added a comment. Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review. REPOSITORY R110 KScreen Library REVISION

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-18 Thread Sebastian Kügler
sebas requested changes to this revision. sebas added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > OsdSelector.qml:49 > +iconSource: "osd-shutd-screen", > +label: qsTr("Switch to external screen"), > +

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-18 Thread Sebastian Kügler
sebas added a comment. I've tested this branch, and it's looking quite good. On X11, it works as expected now after doing a few changes: - The first two icons were mixed up, fix added to dvratil/osd branch - The OSD wouldn't dismiss when the cable got unplugged without selecting an

D3598: rework kscreen's OSD logic

2018-01-18 Thread Sebastian Kügler
sebas abandoned this revision. sebas added a comment. This branch is going to be merged as part of https://phabricator.kde.org/D9414 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D3598 To: sebas, #plasma Cc: kpiwowarski, mart, graesslin, broulik, plasma-devel,

D9462: KCM: show scaled outputs correctly

2018-01-17 Thread Sebastian Kügler
sebas added a comment. @dvratil that's much appreciated (I made that same mistake ;-)) REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9464: KCM: add support for non-integer output scaling

2018-01-17 Thread Sebastian Kügler
sebas added a comment. Also, any UI change needs screenshots attached how it looks with the change. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9464 To: dvratil, sebas, davidedmundson Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9462: KCM: show scaled outputs correctly

2018-01-17 Thread Sebastian Kügler
sebas added a comment. I agree with David, scaling the output makes the previewed "device" smaller. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9462 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-17 Thread Sebastian Kügler
sebas added a comment. In https://phabricator.kde.org/D9414#192009, @abetts wrote: > Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot? We're open to mockups, of course. :) REPOSITORY R104 KScreen REVISION DETAIL

D9414: Implement OSD to select action when unknown monitors is connected

2018-01-16 Thread Sebastian Kügler
sebas added a comment. In https://phabricator.kde.org/D9414#191971, @dvratil wrote: > In https://phabricator.kde.org/D9414#191653, @broulik wrote: > > > I think `OnScreenDisplay` implies being non-interactive on Wayland > > > I could interact with the dialog on Wayland, so

D9908: Wayland: add support for output type detection

2018-01-16 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9908 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D9906: Wayland: don't update output configuration if there are no changes

2018-01-16 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9906 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D9904: Wayland: don't share the same Config between backend and clients

2018-01-16 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. LGTM as well. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D9904 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D9903: KDED: respond to output being completely removed

2018-01-16 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D9903 To: dvratil, sebas, davidedmundson Cc: plasma-devel, ZrenBot, progwolff,

D9463: XRandR: implement scaling support

2018-01-16 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. I'm not suitable to review the X11 bits in here, but since you are the former maintainer, I trust you on those. INLINE COMMENTS > config.h:69 > +PerOutputScaling = 1 << 2, ///< The

D9506: milti-screen sleep fix

2018-01-09 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. And I'm not sure they should. There's a difference between a monitor going to sleep and a configuration change of a multi screen setup. Can you please merge this quickly? I'd like to give it some real-world exposure, we can always

Minutes Monday Plasma Hangout

2018-01-08 Thread Sebastian Kügler
Minutes and log of today's meeting -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 8 january 2018 Present: romangg, notmart, bshah, d__ed, kbroulik, Sho, sebas romangg: * there is a patch to be reviewed which needs to go in 5.12: https://phabricator.kde.org/D9352 * Diff

Re: detecting tablet mode

2018-01-08 Thread Sebastian Kügler
On Friday, January 5, 2018 6:24:38 PM CET Martin Flöser wrote: > Am 2018-01-05 16:11, schrieb Marco Martin: > > debugging a bit what happens currently on my machine, i don't seem to > > have any event device which libinput_device_switch_has_switch, > > however, when i flip it, i do get an event,

Re: Plasma and Frameworks Release issue

2017-12-27 Thread Sebastian Kügler
On Tuesday, December 26, 2017 5:57:32 PM CET David Edmundson wrote: > We have a frameworks and Plasma release schedule issue again. > > We have new API (Package::fileUrl literally everwhere and I have something > minor in kwin) that requires frameworks 5.42 > > This frameworks release comes out

D9335: invalidate the runtime cache on install

2017-12-14 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH packagefix REVISION DETAIL https://phabricator.kde.org/D9335 To: mart, #plasma, sebas Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8444: Define default Action when we plug unknown monitor

2017-12-08 Thread Sebastian Kügler
sebas added a subscriber: jensreuterberg. sebas added a comment. @dvratil Good question. I actually have a branch that adds an OSD to kscreen. It's in sebas/osd right now and I haven't merged it since it behaves weirdly on Wayland (placement is not reliable). That should be the start. The

D9108: Remove implicit string casting

2017-12-02 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9108 To: apol, #plasma, #frameworks, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: how to activate debug output ?

2017-11-27 Thread Sebastian Kügler
On dinsdag 28 november 2017 08:17:53 CET Stéphane Ancelot wrote: > Thanks , but I would like to add some debug messages eg in > systemsettings cpp program. > I have seen qDebug, kDebug in other files, but it fails when I compile kDebug isn't used in Plasma 5 anymore, use qCDebug or qDebug.

Minutes Monday Plasma Hangout

2017-11-27 Thread Sebastian Kügler
The minutes and log, as usual -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 31-7-2017 Present: kbroulik, Sho_, d_ed, bshah, notmart, eang, andris, sebas kbroulik: * I just merged Kate jump list actions support, you should now get kate sessions (if you use them) show

D8444: Define default Action when we plug unknown monitor

2017-11-20 Thread Sebastian Kügler
sebas added a comment. @mlaurent What's your plan with this? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D8444 To: mlaurent, davidedmundson Cc: sebas, graesslin, dvratil, davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Minutes Monday Plasma Hangout

2017-11-20 Thread Sebastian Kügler
Minutes and log, voila! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 20-11-2017 Present: Sho, notmart, d_ed, bshah, sebas Sho: * Rewrote the Launch Feedback KCM in Qt Quick to start helping Marco with the System Settings workload ** Will go on to do some more I guess *

[Breeze] [Bug 371276] Only black screen with breeze plymouth theme in plasma 5.8.2

2017-11-08 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=371276 Sebastian Kügler <se...@kde.org> changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@k

Re: Regarding the outputdevice Wayland protocol

2017-11-08 Thread Sebastian Kügler
Hi Drew, On woensdag 8 november 2017 15:12:03 CET Drew DeVault wrote: > Thanks for the info, guys! > > My main use-case for this protocol is to be able to share an > arandr-like tool between KDE and any compositor using wlroots (Sway, > way-cooler, waymonad, etc). > > Did you guys write a

Re: Need help: vertical screen rotation!

2017-11-07 Thread Sebastian Kügler
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote: > > upside down works, 90 and 270 do nothing on my system. > > > > Debian Unstable > > Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01) > > x86_64 GNU/ Linux > > > > 00:02.0 VGA compatible controller: Intel Corporation HD

D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas added a comment. Or ... kwin has two modes: 1) kwin auto-rotates, tells kscreen that it doesn't do any other transforms, 2) kwin hands over to kscreen, not auto-rotating... Perhaps adding "auto" is the best option, though. BRANCH automatic-rotation REVISION DETAIL

D8652: Add supported transformations to OutputDevice

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision. sebas added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > outputdevice.h:244 > + * @returns The transformations supported on this OutputDevice > + * @since 5.XX > + * @see supportedTransformationAdded 5.40 I guess

D8645: [platforms/drm] Determine the supported transformation on a plane

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH drm-supported-transformations REVISION DETAIL https://phabricator.kde.org/D8645 To: graesslin, #kwin, #plasma, subdiff, sebas Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff,

D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas added a comment. Ah, btw ... we have icons: They're in breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg These should probably be used for the statusnotifier then. BRANCH automatic-rotation REVISION DETAIL https://phabricator.kde.org/D8699 To: graesslin, #kwin,

D8699: Support automatic screen rotation based on orientation sensor

2017-11-07 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Code-wise, looks good. Have you thought about a way to switch it on and off? Perhaps a simple dbus interface that allows checking its state and turning it on and off is sufficient.

Re: Need help: vertical screen rotation!

2017-11-07 Thread Sebastian Kügler
On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote: > Hi all, > > I am currently working on screen rotation on Wayland. Unfortunately my > systems do not support vertical rotation (rotate by 90 or 270 > degrees). Thus I do not know whether my code works or what needs > fixing. > > I

Re: Regarding the outputdevice Wayland protocol

2017-11-07 Thread Sebastian Kügler
Hi Drew, Thanks for reaching out! On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote: > As part of our effort to reuse existing Wayland protocols for common > desktop features in Sway (and wlroots), we're taking a look at KDE's > output-management.xml. However, we feel like the related

Minutes Monday Plasma Hangout

2017-11-06 Thread Sebastian Kügler
Hola, The minutes and the log. Enjoy! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 6-11-2017 Present: notmart, Ridell, Sho, kbroulik, d_ed notmart: * kirigami: support for colored icons in some more places: possibility to color the main action buttons, needed by

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Sebastian Kügler
sebas added a comment. Ow, I might add that we wanted to address a similar thing by providing a popup when a display is connected that asks the user what do do now, and then an action can be chosen. Maybe your time is spent better working on that feature, as we already agreed that this

D8444: Define default Action when we plug unknown monitor

2017-10-31 Thread Sebastian Kügler
sebas added a comment. Once you're done with the code, please also add screenshot so usability can have a look at it. I'm not sure we should add UI for this, the screen setup is already very complex and hard to understand. Perhaps a set of clear use-cases would make this clearer? No

D8390: Don't re-align outputs when QMLOutput in clone mode moves

2017-10-30 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Please also merge into master. REPOSITORY R104 KScreen BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8390 To: dvratil, sebas Cc: plasma-devel, ZrenBot, progwolff,

D8391: Keep the unified QMLOutput always in center

2017-10-30 Thread Sebastian Kügler
sebas added a comment. Please also merge into master. REPOSITORY R104 KScreen BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8391 To: dvratil, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8391: Keep the unified QMLOutput always in center

2017-10-30 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8391 To: dvratil, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D8432: Use nullptr. Initialize pointer

2017-10-30 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R110 KScreen Library BRANCH use_nullptr REVISION DETAIL https://phabricator.kde.org/D8432 To: mlaurent, davidedmundson, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Minutes Monday Plasma Hangout

2017-10-30 Thread Sebastian Kügler
Meeting notes, fun as always. Enjoy the read! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team meeting, 4-9-2017 Present: fvogt, d_ed, romangg, Sho_, einar77_work, bshah, notmart, kbroulik, sebas fvogt: - I'm not quite sure what to do with ivan's request on the

[kio-extras] [Bug 376128] SMB://server/dir Timeout on Server server in Dolphin

2017-10-21 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=376128 Sebastian Kügler <se...@kde.org> changed: What|Removed |Added CC||se...@k

[Powerdevil] [Bug 383614] KCM opened from tray icon has wrong icon under Wayland

2017-10-18 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=383614 Sebastian Kügler <se...@kde.org> changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -

[kio-extras] [Bug 369850] Can't browse samba workgroups

2017-10-10 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=369850 Sebastian Kügler <se...@kde.org> changed: What|Removed |Added CC||se...@k

D8153: Try to read CPU clock from cpufreq/scaling_cur_freq instead of /proc/cpuinfo

2017-10-06 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R106 KSysguard BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D8153 To: fvogt, #plasma, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8109: remove bogus test

2017-10-02 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH xkbtest REVISION DETAIL https://phabricator.kde.org/D8109 To: mart, #plasma, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

Minutes Monday Plasma Hangout

2017-10-02 Thread Sebastian Kügler
Cheers! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Weekly Meeting, 2 October 2017, 12:00 CEST #plasma on freenode Sho: * Wrote a proof-of-concept patch for making Sonnet work on Qt Quick TextEdits: success, we can have spell-checking in Kirigami apps * Fixed some libtm unit test

D8054: Show headset icons for devices identifying as "Headset" in Description

2017-09-29 Thread Sebastian Kügler
sebas added a comment. Ah okay, I guess then keep this patch in, and ask for the breeze icon. :) REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D8054 To: antlarr, #plasma, davidedmundson Cc: sebas, plasma-devel, ZrenBot,

D8054: Show headset icons for devices identifying as "Headset" in Description

2017-09-29 Thread Sebastian Kügler
sebas added a comment. Perhaps move the conditional to the end, so it is taken if there's nothing else, that's making "surer" that nothing that currently works is changed, and at the same time, request a headset icon for breeze? REPOSITORY R115 Plasma Audio Volume Applet BRANCH master

D8054: Show headset icons for devices identifying as "Headset" in Description

2017-09-29 Thread Sebastian Kügler
sebas added a comment. Where is the headset icon? I can't see it in breeze... REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D8054 To: antlarr, #plasma, davidedmundson Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai,

Minutes Monday Plasma Hangout

2017-09-25 Thread Sebastian Kügler
Meeting minutes! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 25-09-2017 Present: jensreut, Sho_, kbroulik, fvogt, Riddell, d_ed, bshah, sebas jensreut: * VDG management Sho: * Did emergency v1.0.3 release of Simple Menu to fix favorites on Plasma v5.11 * On vacation last

[Breeze] [Bug 384999] Default setting of no borders drawn around dock widgets causes usability issues with multiple adjacent dock widgets

2017-09-24 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=384999 Sebastian Kügler <se...@kde.org> changed: What|Removed |Added Assignee|plasma-devel@kde.org|plasma-b...@kde.org -

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2017-09-22 Thread Sebastian Kügler
sebas added a comment. Thinking of it, wouldn't it make total sense to have this as a QtQuick-only KCM, i.e. using KQuickAddons::ConfigModule? INLINE COMMENTS > qtquicksettings.desktop:13 > +X-KDE-Weight=60 > + > +Name=Plasma Renderer License key would be nice. REPOSITORY R119 Plasma

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2017-09-22 Thread Sebastian Kügler
sebas added a comment. Maybe not put it in systemsettings, but tell users to run kcmshell to open it? That really hides it well though, also defeating the purpose... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D7934 To: davidedmundson, #plasma Cc: sebas,

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

2017-09-22 Thread Sebastian Kügler
sebas added a comment. Can we hide this even more, given that it's an utter expert setting? INLINE COMMENTS > qtquicksettings.desktop:14 > + > +Name=Plasma Rendererer > + I think you forgot a few "er", it should be Plasma Renderererererererer, no? ;-) REPOSITORY R119 Plasma Desktop

D7912: track the config to monitor, save scale

2017-09-21 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R104:8719c33eea8f: track the config to monitor, save scale (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7912?vs=19735=19737 REVISION DETAIL

D7912: track the config to monitor, save scale

2017-09-21 Thread Sebastian Kügler
sebas created this revision. sebas added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When doApplyConfig is called, we forgot to change the monitored config, which means we weren't

D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-21 Thread Sebastian Kügler
sebas added a comment. FWIW, I tested it, it fixes kwin crashing when adding a setApplied() call on the OutputConfiguration, and it also means the applied signal arrives. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7898 To: davidedmundson,

D7898: Only send OutputConfig sendApplied / sendFailed to the right resource

2017-09-21 Thread Sebastian Kügler
sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Yes, the initial idea was to send applied() to all connected resources. That is not s_allResources, so your patch is correct. The resources that are actually bound are not currently tracked.

D7882: on wayland startup create XDG_RUNTIME_DIR

2017-09-20 Thread Sebastian Kügler
sebas abandoned this revision. sebas added a comment. Ow, see, I was exporting a different XDG_RUNTIME_DIR in my login procedure. I guess removing that fixes the problem as well. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7882 To: sebas, #plasma

D7882: on wayland startup create XDG_RUNTIME_DIR

2017-09-20 Thread Sebastian Kügler
sebas added a comment. That's happening when I start startplasmacompositor by hand, and it's annoying as fuck. Sure, I can add that to my login script, but it's literally the only thing that I have to do to make plasma/wayland come up. Everything else works. (Also, we do create

D7882: on wayland startup create XDG_RUNTIME_DIR

2017-09-20 Thread Sebastian Kügler
sebas added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7882 To: sebas, #plasma Cc: palimaka, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6027: Use existing parseInt function

2017-09-20 Thread Sebastian Kügler
sebas resigned from this revision. sebas added a comment. Please abandon, I've already fixed this in master. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D6027 To: davidedmundson, #plasma, sebas Cc: sebas, plasma-devel, ZrenBot, progwolff, lesliezhai,

D7882: on wayland startup create XDG_RUNTIME_DIR

2017-09-20 Thread Sebastian Kügler
sebas created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kwin_wayland wants to put the wayland socket file into XDG_RUNTIME_DIR, but it doesn't make sure this directory exists. It expects the login

Minutes Monday Plasma Hangout

2017-09-18 Thread Sebastian Kügler
Meeting minutes and log from today's weekly: accessiblity, wayland, design, it has all the goodies. -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 18 Sept 2017 Present: notmart, Sho, d_ed, sebas, jensreut, fvogt notmart: * At randa meeting, was mostly about accessibility **

  1   2   3   4   5   6   7   8   9   10   >