D10438: increase left/right margin of menuitems

anemeth added a comment. @zzag Did you accidentally removed the changes in breeze.h and breezestyle.h? :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: januz, fabianr, mmustac, abetts, anemeth,

D10438: increase left/right margin of menuitems

zzag added a comment. How it currently looks: F5707975: 1.png F5707978: 2.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham,

D10438: increase left/right margin of menuitems

zzag updated this revision to Diff 27019. zzag added a comment. reserve space for checkable widgets in menu items REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10438?vs=26980=27019 BRANCH menuitem-margins REVISION DETAIL

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205042 , @zzag wrote: > Did you change the left margin? Could you please test the left margin with values 20/24/28 and pick the best one? I didn't change the margins previously, only applied the patch.

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#205041 , @zzag wrote: > > But then that makes it a different patch, right ? > > Why? Because I know the code: I wrote it. >> Margins are not changed. What is changed is the allocated

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#205007 , @anemeth wrote: > F5707729: .PNG Did you change the left margin? Could you please test the left margin with values 20/24/28 and pick the best one?

D10438: increase left/right margin of menuitems

zzag added a comment. > But then that makes it a different patch, right ? Why? > Margins are not changed. What is changed is the allocated space for the menu item content, that always accommodate for the checkbox, and draws it whenever there is one. No, margins still have to

D10438: increase left/right margin of menuitems

ngraham added a comment. In D10438#205010 , @abetts wrote: > In D10438#205009 , @ngraham wrote: > > > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now,

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#205009 , @ngraham wrote: > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to

D10438: increase left/right margin of menuitems

abetts added a comment. In D10438#205009 , @ngraham wrote: > Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to

D10438: increase left/right margin of menuitems

ngraham added a comment. Let's try to avoid radical proposals like getting rid of keyboard shortcuts and icons. For now, let's focus on the initial goal, or perhaps a slightly modified goal of adding room to put checkboxes to the left of the text (which I would support). REPOSITORY R31

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#205005 , @abetts wrote: > Are we thinking we should/not use icons in menus, keep the same? Looks quite good in my opinion with this patch applied and no icons F5707729: .PNG

D10438: increase left/right margin of menuitems

abetts added a comment. How are we accounting for stacking menu items that have: Checkbox - Item Icon - Label -- Shortcut-Arrow Icon The first part of that tends to make the checkbox be closest to the edge. Are we thinking we should/not use icons in menus, keep the same? REPOSITORY

D10438: increase left/right margin of menuitems

ngraham added a comment. We cannot ever remove the shortcuts from the menus, for countless usability reasons. Lack of discoverable keyboard shortcuts is one of the many productivity and ergonomic flaws of GNOME; we cannot regress to that level. in macOS, the shortcuts are more compact

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204922 , @zzag wrote: > Just to clarify that other DE and OS have some space on the left side: > > - Windows:

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204960 , @anemeth wrote: > In D10438#204922 , @zzag wrote: > > > Just to clarify that other DE and OS have some space on the left side: > > > > -

D10438: increase left/right margin of menuitems

anemeth added a comment. In D10438#204922 , @zzag wrote: > Just to clarify that other DE and OS have some space on the left side: > > - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png >

D10438: increase left/right margin of menuitems

zzag added a comment. In D10438#204884 , @hpereiradacosta wrote: > In anycase, increasing margins should then be made consistently accross the style and not one by one if you want to keep balance. No, it should not. This is a small

D10438: increase left/right margin of menuitems

zzag added a comment. Just to clarify that other DE and OS have some space on the left side: - Windows: https://forums.windowscentral.com/attachments/windows-8/48119d1382981718t-screenshot-1-.png - macOS: https://i.stack.imgur.com/h6LAN.png - elementaryOS:

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204764 , @fabianr wrote: > According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) or multiples of these should be used when ever possible, maybe it would make sense to uses these?

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. also see how in two the posted screenshots the checkmarks for checkable items is actually very close to the menu border. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc:

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204869 , @januz wrote: > IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each. > It's true that

D10438: increase left/right margin of menuitems

januz added a comment. IMO, the last version looks better than the current menu. That said, I think the top/bottom paddings are still too tight, I would try adding 2-3px for each. It's true that there's a question of taste but more whitespace is generally a good thing (unless you go

D10438: increase left/right margin of menuitems

hpereiradacosta added a comment. In D10438#204757 , @zzag wrote: > @mmustac what about this? > > F5706606: without-checkboxes-10.png > > margins: > > - left: 10 > - right: 4 > - top,bottom: 3

D10438: increase left/right margin of menuitems

fabianr added a comment. According to the HIG units.smallSpacing (4px) or units.largeSpacing (18px) or multiples of these should be used when ever possible, maybe it would make sense to uses these? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag,

D10438: increase left/right margin of menuitems

zzag added a comment. @mmustac what about this? F5706606: without-checkboxes-10.png margins: - left: 10 - right: 4 - top,bottom: 3 --- > The new margins shown in the screenshot are just too huge for my taste. Well, it's

D10438: increase left/right margin of menuitems

mmustac added a comment. I like the margins how they are at the moment and personally would increase it maximum by 5 px or so. The new margins shown in the screenshot are just too huge for my taste. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag,

D10438: increase left/right margin of menuitems

zzag added a comment. > What other DE or OS that you used has such a wide menu that it feels natural to you? WIndows and macOS. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: abetts, anemeth,

D10438: increase left/right margin of menuitems

zzag added a comment. @ngraham, @abetts F5706528: without-checkboxes.png F5706532: with-checkboxes.png Margins: - left: 20 - right: 6 - top: 3 - bottom: 3 What do you think of this?

D10438: increase left/right margin of menuitems

zzag updated this revision to Diff 26980. zzag added a comment. allow changing individual margins(e.g. left/right/top/bottom margin) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10438?vs=26906=26980 BRANCH menuitem-margins REVISION DETAIL

D10438: increase left/right margin of menuitems

abetts added a comment. This could work, just the left padding is too much in this patch. Maybe reduce by a 3rd? or Half? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: abetts, anemeth, plasma-devel,

D10438: increase left/right margin of menuitems

ngraham added a comment. I could //maybe// see this working for the left edge, but having such a lot of padding between the right edge and the arrows seems a little weird to me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham,

D10438: increase left/right margin of menuitems

anemeth added a comment. How does it look when a menu has a checkbox on it, for example the 'View' menu on Konsole F5705719: Screenshot_20180212_011947.png What other DE or OS that you used has such a wide menu that it feels natural to you?

D10438: increase left/right margin of menuitems

zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

zzag created this revision. zzag added reviewers: Breeze, VDG, ngraham, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY At a given moment, there is a small