D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Actually, I did find one problem that I missed from before: F6971880: 
sidebar_tree-2019-07-05_00.04.24.webm 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  As far as I can tell, there aren't any problems with this patch. Some apps 
like Spectacle and the system tray settings don't follow the new style, but 
they don't use Qt Widgets for the sidebar.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, ndavis, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.12 - Build # 138 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.12/138/
 Project:
stable-kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Jul 2019 23:04:34 +
 Build duration:
2 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 799 lines...][2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.h:23:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/package.h:1:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/private/../package.h:25:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:28:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfiggroup.h:32:[2019-07-04T23:06:46.561Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-07-04T23:06:46.561Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:46:[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qmetatype.h:1797:5: error: static_assert failed due to requirement 'bool(QMetaTypeId2::Defined)' "Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system"[2019-07-04T23:06:46.561Z] Q_STATIC_ASSERT_X(QMetaTypeId2::Defined, "Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system");[2019-07-04T23:06:46.561Z] ^~[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qglobal.h:121:49: note: expanded from macro 'Q_STATIC_ASSERT_X'[2019-07-04T23:06:46.561Z] #  define Q_STATIC_ASSERT_X(Condition, Message) static_assert(bool(Condition), Message)[2019-07-04T23:06:46.561Z] ^ ~~~[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qvariant.h:520:21: note: in instantiation of function template specialization 'qMetaTypeId' requested here[2019-07-04T23:06:46.561Z] return QVariant(qMetaTypeId(), , QTypeInfo::isPointer);[2019-07-04T23:06:46.561Z] ^[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qvariant.h:366:14: note: in instantiation of function template specialization 'qVariantFromValue' requested here[2019-07-04T23:06:46.561Z] { return qVariantFromValue(value); }[2019-07-04T23:06:46.561Z]  ^[2019-07-04T23:06:46.561Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.cpp:421:87: note: in instantiation of function template specialization 'QVariant::fromValue' requested here[2019-07-04T23:06:46.561Z] actions = factory->create(nullptr, {QVariant::fromValue(plugins.first())});[2019-07-04T23:06:46.561Z]   ^[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.cpp:20:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.h:23:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/package.h:1:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 FreeBSDQt5.12/src/plasma/private/../package.h:25:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:28:[2019-07-04T23:06:46.561Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfiggroup.h:32:[2019-07-04T23:06:46.561Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-07-04T23:06:46.561Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:46:[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qmetatype.h:1662:82: error: no member named 'qt_metatype_id' in 'QMetaTypeId'[2019-07-04T23:06:46.561Z] static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:06:46.561Z]  ^[2019-07-04T23:06:46.561Z] /usr/local/include/qt5/QtCore/qmetatype.h:1798:29: note: in instantiation of member function 'QMetaTypeId2::qt_metatype_id' requested here[2019-07-04T23:06:46.561Z] return QMetaTypeId2::qt_metatype_id();[2019-07-04T23:06:46.561Z] 

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 127 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/127/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Jul 2019 23:04:34 +
 Build duration:
1 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 1042 lines...][2019-07-04T23:06:00.420Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:421:112:   required from here[2019-07-04T23:06:00.420Z] /usr/include/qt5/QtCore/qmetatype.h:1662:96: error: ���qt_metatype_id��� is not a member of ���QMetaTypeId���[2019-07-04T23:06:00.420Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:06:00.420Z]   |  ~~^~[2019-07-04T23:06:00.420Z] /usr/include/qt5/QtCore/qmetatype.h:1662:100: error: body of ���constexpr��� function ���static constexpr int QMetaTypeId2::qt_metatype_id() [with T = KPluginMetaData]��� not a return-statement[2019-07-04T23:06:00.420Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:06:00.420Z]   |^[2019-07-04T23:06:00.420Z] [ 63%] Built target calendarplugin[2019-07-04T23:06:00.420Z] [ 63%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/containment_p.cpp.o[2019-07-04T23:06:00.420Z] make[2]: *** [src/plasma/CMakeFiles/KF5Plasma.dir/build.make:97: src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o] Error 1[2019-07-04T23:06:00.420Z] make[2]: *** Waiting for unfinished jobs[2019-07-04T23:06:00.676Z] [ 63%] Built target platformcomponentsplugin[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp: In member function ���Plasma::Package Plasma::Applet::package() const���:[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:316:13: warning: ���Plasma::Package::Package(Plasma::PackageStructure*)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:00.676Z]   316 | Package p;[2019-07-04T23:06:00.676Z]   | ^[2019-07-04T23:06:00.676Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:50:[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:95:32: note: declared here[2019-07-04T23:06:00.676Z]95 | PLASMA_DEPRECATED explicit Package(PackageStructure *structure = nullptr);[2019-07-04T23:06:00.676Z]   |^~~[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:318:12: warning: ���Plasma::Package::Package(const Plasma::Package&)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:00.676Z]   318 | return p;[2019-07-04T23:06:00.676Z]   |^[2019-07-04T23:06:00.676Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:50:[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/package.h:107:23: note: declared here[2019-07-04T23:06:00.676Z]   107 | PLASMA_DEPRECATED Package(const Package );[2019-07-04T23:06:00.676Z]   |   ^~~[2019-07-04T23:06:00.676Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:23:[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h: In constructor ���Plasma::ContainmentActionsPrivate::ContainmentActionsPrivate(const QVariant&, Plasma::ContainmentActions*)���:[2019-07-04T23:06:00.676Z] /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h:33:162: warning: ���KPluginInfo::KPluginInfo(KService::Ptr)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:00.676Z]33 | containmentActionsDescription(arg.canConvert() ? arg.value() : KPluginInfo(KService::serviceByStorageId(arg.toString())).toMetaData()),[2019-07-04T23:06:00.676Z]   |  ^[2019-07-04T23:06:00.676Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.h:25,[2019-07-04T23:06:00.676Z]  from /home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:20:[2019-07-04T23:06:00.676Z] 

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 127 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/127/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 04 Jul 2019 23:04:33 +
 Build duration:
1 min 35 sec and counting
   CONSOLE OUTPUT
  [...truncated 1039 lines...][2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/pluginloader.cpp:421:112:   required from here[2019-07-04T23:06:05.452Z] /usr/include/qt5/QtCore/qmetatype.h:1662:96: error: ���qt_metatype_id��� is not a member of ���QMetaTypeId���[2019-07-04T23:06:05.452Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:06:05.452Z]   |  ~~^~[2019-07-04T23:06:05.452Z] /usr/include/qt5/QtCore/qmetatype.h:1662:100: error: body of ���constexpr��� function ���static constexpr int QMetaTypeId2::qt_metatype_id() [with T = KPluginMetaData]��� not a return-statement[2019-07-04T23:06:05.452Z]  1662 | static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:06:05.452Z]   |^[2019-07-04T23:06:05.452Z] make[2]: *** [src/plasma/CMakeFiles/KF5Plasma.dir/build.make:97: src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o] Error 1[2019-07-04T23:06:05.452Z] make[2]: *** Waiting for unfinished jobs[2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp: In member function ���Plasma::Package Plasma::Applet::package() const���:[2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:316:13: warning: ���Plasma::Package::Package(Plasma::PackageStructure*)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:05.452Z]   316 | Package p;[2019-07-04T23:06:05.452Z]   | ^[2019-07-04T23:06:05.452Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:50:[2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/package.h:95:32: note: declared here[2019-07-04T23:06:05.452Z]95 | PLASMA_DEPRECATED explicit Package(PackageStructure *structure = nullptr);[2019-07-04T23:06:05.452Z]   |^~~[2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:318:12: warning: ���Plasma::Package::Package(const Plasma::Package&)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:05.452Z]   318 | return p;[2019-07-04T23:06:05.452Z]   |^[2019-07-04T23:06:05.452Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/applet.cpp:50:[2019-07-04T23:06:05.452Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/package.h:107:23: note: declared here[2019-07-04T23:06:05.452Z]   107 | PLASMA_DEPRECATED Package(const Package );[2019-07-04T23:06:05.452Z]   |   ^~~[2019-07-04T23:06:05.452Z] [ 61%] Built target platformcomponentsplugin[2019-07-04T23:06:06.014Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:23:[2019-07-04T23:06:06.014Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h: In constructor ���Plasma::ContainmentActionsPrivate::ContainmentActionsPrivate(const QVariant&, Plasma::ContainmentActions*)���:[2019-07-04T23:06:06.014Z] /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/private/containmentactions_p.h:33:162: warning: ���KPluginInfo::KPluginInfo(KService::Ptr)��� is deprecated [-Wdeprecated-declarations][2019-07-04T23:06:06.014Z]33 | containmentActionsDescription(arg.canConvert() ? arg.value() : KPluginInfo(KService::serviceByStorageId(arg.toString())).toMetaData()),[2019-07-04T23:06:06.014Z]   |  ^[2019-07-04T23:06:06.014Z] In file included from /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.h:25,[2019-07-04T23:06:06.014Z]  from /home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/containmentactions.cpp:20:[2019-07-04T23:06:06.014Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:115:34: note: declared here[2019-07-04T23:06:06.014Z]   115 | explicit 

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 138 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/138/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 04 Jul 2019 23:04:34 +
 Build duration:
1 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 798 lines...][2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/package.h:1:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/src/plasma/private/../package.h:25:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:28:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfiggroup.h:32:[2019-07-04T23:05:40.139Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-07-04T23:05:40.139Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:46:[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qmetatype.h:1797:5: error: static_assert failed due to requirement 'bool(QMetaTypeId2::Defined)' "Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system"[2019-07-04T23:05:40.139Z] Q_STATIC_ASSERT_X(QMetaTypeId2::Defined, "Type is not registered, please use the Q_DECLARE_METATYPE macro to make it known to Qt's meta-object system");[2019-07-04T23:05:40.139Z] ^~[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qglobal.h:121:49: note: expanded from macro 'Q_STATIC_ASSERT_X'[2019-07-04T23:05:40.139Z] #  define Q_STATIC_ASSERT_X(Condition, Message) static_assert(bool(Condition), Message)[2019-07-04T23:05:40.139Z] ^ ~~~[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qvariant.h:520:21: note: in instantiation of function template specialization 'qMetaTypeId' requested here[2019-07-04T23:05:40.139Z] return QVariant(qMetaTypeId(), , QTypeInfo::isPointer);[2019-07-04T23:05:40.139Z] ^[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qvariant.h:366:14: note: in instantiation of function template specialization 'qVariantFromValue' requested here[2019-07-04T23:05:40.139Z] { return qVariantFromValue(value); }[2019-07-04T23:05:40.139Z]  ^[2019-07-04T23:05:40.139Z] /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.cpp:421:87: note: in instantiation of function template specialization 'QVariant::fromValue' requested here[2019-07-04T23:05:40.139Z] actions = factory->create(nullptr, {QVariant::fromValue(plugins.first())});[2019-07-04T23:05:40.139Z]   ^[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.cpp:20:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/src/plasma/pluginloader.h:23:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/build/src/plasma/plasma/package.h:1:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 FreeBSDQt5.12/src/plasma/private/../package.h:25:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:28:[2019-07-04T23:05:40.139Z] In file included from /usr/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfiggroup.h:32:[2019-07-04T23:05:40.139Z] In file included from /usr/local/include/qt5/QtCore/QVariant:1:[2019-07-04T23:05:40.139Z] In file included from /usr/local/include/qt5/QtCore/qvariant.h:46:[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qmetatype.h:1662:82: error: no member named 'qt_metatype_id' in 'QMetaTypeId'[2019-07-04T23:05:40.139Z] static inline Q_DECL_CONSTEXPR int qt_metatype_id() { return QMetaTypeId::qt_metatype_id(); }[2019-07-04T23:05:40.139Z]  ^[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qmetatype.h:1798:29: note: in instantiation of member function 'QMetaTypeId2::qt_metatype_id' requested here[2019-07-04T23:05:40.139Z] return QMetaTypeId2::qt_metatype_id();[2019-07-04T23:05:40.139Z] ^[2019-07-04T23:05:40.139Z] /usr/local/include/qt5/QtCore/qvariant.h:520:21: note: in instantiation of function template specialization 'qMetaTypeId' requested here[2019-07-04T23:05:40.139Z] return 

D22231: [Lock screen] Follow KDE title & subtitle style

[Filip Fila]

filipf added a comment.


  Ping, with D22230  landed this should 
also follow quite soon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22231

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22230: [TaskManager] Follow KDE title & subtitle style

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:741ffda94294: [TaskManager] Follow KDE title  
subtitle style (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22230?vs=61062=61180

REVISION DETAIL
  https://phabricator.kde.org/D22230

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: filipf, #plasma, #vdg, ngraham, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:76045bf20e07: [Kickoff] Redo tab bar separators 
geometry (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22128?vs=60750=61179

REVISION DETAIL
  https://phabricator.kde.org/D22128

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  In D22121#490983 , @ngraham wrote:
  
  > I still get the same crash. :(
  
  
  Very weird I just tried it in a VM which hadn't seen the patch at all yet and 
it doesn't crash.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Noah Davis]

ndavis added a comment.


  In D22138#491018 , 
@hpereiradacosta wrote:
  
  > In D22138#490967 , @ndavis wrote:
  >
  > > Since this apparently doesn't need review,
  >
  >
  > This is not what I said. What I said is "thanks, it looks fantastic" is not 
a proper review and hence irrelevant. What I expect for a proper review is
  >
  > - does the patch achieve the behavior matching its title, and is it the 
intended behavior
  > - does the code look legit (compiles, properly formatted, etc.)
  > - is there a better way to achieve the same
  > - does the patch break other things, and how can it be improved so that it 
doesn't If you can provide such a review I'd be happy to modify the patch 
accordingly.
  >
  > > I'll resign.
  
  
  In that case, I will review this.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D22138#490976 , @ngraham wrote:
  
  > Very nice! In conjunction with Marco's patch (D22083 
), I now see the following for Dolphin's 
settings window: F6968869: Screenshot_20190704_134502.png 

  >
  > I notice that your screenshot depicts the sidebar with no top, bottom, or 
left margins, which is the indended appearance. Is that the result of some 
other required patch I haven't applied yet, or did I do something wrong?
  
  
  Sorry. My bad. Yes, my own copy included other changes beyond my patch and 
Marco's, resulting in the zero margins. The screenshot you post is the correct 
one. Thanks. 
  The remaining margin issue, handled at the layout level, either in breeze or 
in kpagedialog, should be a separate patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D22138#490967 , @ndavis wrote:
  
  > Since this apparently doesn't need review,
  
  
  This is not what I said. What I said is "thanks, it looks fantastic" is not a 
proper review and hence irrelevant. What I expect for a proper review is
  
  - does the patch achieve the behavior matching its title, and is it the 
intended behavior
  - does the code look legit (compiles, properly formatted, etc.)
  - is there a better way to achieve the same
  - does the patch break other things, and how can it be improved so that it 
doesn't
  
  If you can provide such a review I'd be happy to modify the patch accordingly.
  
  > I'll resign.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Nathaniel Graham]

ngraham added a comment.


  I still get the same crash. :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

[Andreas Sturmlechner]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4dcd1588c1cf: doc: Some different phrasing, one instance 
of s/KDE/Plasma/ (authored by asturmlechner).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22214?vs=61010=61164

REVISION DETAIL
  https://phabricator.kde.org/D22214

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: asturmlechner, #plasma, ngraham
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Nathaniel Graham]

ngraham added a comment.


  Very nice! In conjunction with Marco's patch (D22083 
), I now see the following for Dolphin's 
settings window: F6968869: Screenshot_20190704_134502.png 

  
  I notice that your screenshot depicts the sidebar with no top, bottom, or 
left margins, which is the indended appearance. Is that the result of some 
other required patch I haven't applied yet, or did I do something wrong?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

[Noah Davis]

ndavis resigned from this revision.
ndavis added a comment.


  Since this apparently doesn't need review, I'll resign.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D22138

To: hpereiradacosta, mart, #vdg, filipf
Cc: ngraham, ndavis, filipf, mart, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D22202: [mobile/wifi] Rework NetworkSetting footer

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:ba4ddb4ae40a: [mobile/wifi] Rework NetworkSetting footer 
(authored by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22202?vs=60972=61161

REVISION DETAIL
  https://phabricator.kde.org/D22202

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: nicolasfella, #plasma, jgrulich, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 61150.
davidedmundson added a comment.


  Reset state when told to resume an empty session

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=61149=61150

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 61149.
davidedmundson added a comment.


  update2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=61147=61149

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 61147.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=61015=61147

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490851 , @ngraham wrote:
  
  > In D21510#488800 , @leinir wrote:
  >
  > > In D21510#488646 , @ngraham 
wrote:
  > >
  > > > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  > >
  > >
  > > Aaaawesomesauce :) Land on master, or 5.16, or?
  >
  >
  > If the requisite support is entirely server-side, I'd even say the 
`Plasma/5.12` branch and merge forward. Otherwise `Plasma/5.16` and merge 
forward.
  
  
  Right, Plasma/5.16 it is :) Technically it /could/ go into 5.12... It has no 
effect unless someone runs it against Attica/KNewStuff 5.51, but i don't expect 
there'll be many using that particular combination ;)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D21510#490850 , @ngraham wrote:
  
  > In D21510#490635 , @leinir wrote:
  >
  > > - Also filter on the ghns_excluded tag, otherwise they'll be shown...
  >
  >
  > I thought that was taken care of on the server side?
  
  
  No, all filtering happens client-side

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  In D21510#488800 , @leinir wrote:
  
  > In D21510#488646 , @ngraham 
wrote:
  >
  > > Yep, seems to work and makes sense. Let's get this in so we can start 
tagging things.
  >
  >
  > Aaaawesomesauce :) Land on master, or 5.16, or?
  
  
  If the requisite support is entirely server-side, I'd even say the 
`Plasma/5.12` branch and merge forward. Otherwise `Plasma/5.16` and merge 
forward.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham added a comment.


  In D21510#490635 , @leinir wrote:
  
  > - Also filter on the ghns_excluded tag, otherwise they'll be shown...
  
  
  I thought that was taken care of on the server side?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11234: [DrKonqi] Show debug button when KDevelop session is running

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11234

To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter
Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22268: Port containmentActions to use KPlugin instead of KService

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It saves us from going through the deprecated (slower) path and will leverage 
the PluginLoader lookup cache.
  
  Depends on D22267 .

TEST PLAN
  Started plasma, containment actions are still found

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22268

AFFECTED FILES
  containmentactions/applauncher/CMakeLists.txt
  containmentactions/contextmenu/CMakeLists.txt
  containmentactions/paste/CMakeLists.txt
  containmentactions/switchdesktop/CMakeLists.txt
  containmentactions/switchwindow/CMakeLists.txt

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21963: Keep Klipper notifications out of notification history

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:120aed57ced1: Keep Klipper notifications out of 
notification history (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21963?vs=60223=61134

REVISION DETAIL
  https://phabricator.kde.org/D21963

AFFECTED FILES
  klipper/klipper.cpp
  libnotificationmanager/plasmanotifyrc

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22264: Always call into ksmserver DBus interface

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:77376fa80290: Always call into ksmserver DBus interface 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22264?vs=61128=61133

REVISION DETAIL
  https://phabricator.kde.org/D22264

AFFECTED FILES
  libkworkspace/kworkspace.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22264: Always call into ksmserver DBus interface

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Previously, it would ask ksmserver to show the logout prompt and otherwise 
directly initate a logout through `libSM`.
  The latter got removed, which is a good thing, but now we need to always know 
ksmserver which should know what to do.

TEST PLAN
  Right click on desktop, click "Leave", get a prompt again now
  Disabled "confirm logout" in startup & shutdown KCM, right clikck on desktop, 
click "leave", logged out directly
  
  Clicked leave button in lock/logout applet, same correct behavior now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22264

AFFECTED FILES
  libkworkspace/kworkspace.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:119943e6b883: Add a global shortcut action to turn off 
the screen (authored by mblumenstingl, committed by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22261?vs=61124=61127

REVISION DETAIL
  https://phabricator.kde.org/D22261

AFFECTED FILES
  daemon/actions/dpms/CMakeLists.txt
  daemon/actions/dpms/powerdevildpmsaction.cpp

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  In D22261#490680 , @broulik wrote:
  
  > Alright, very nice!
  >  I suppose you don't have commit access, so I need an email address from 
you to add you as commit author. Thanks!
  
  
  I once had commit access but I'm not sure if I still have.
  either way, I would be more comfortable with you committing this with the 
following author information: Martin Blumenstingl 

  
  >> I tried adding |Turn Off Screen to the powerdevil QRegularExpression but I 
couldn't turn off the display from the lock screen
  > 
  > You probably need to log out and back in for the new screenlocker binary to 
be loaded (or run the kscreenlocker_test binary in the build/bin directory)
  
  alright, I'll give this another go and open another review

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Alright, very nice!
  I suppose you don't have commit access, so I need an email address from you 
to add you as commit author. Thanks!
  
  > I tried adding |Turn Off Screen to the powerdevil QRegularExpression but I 
couldn't turn off the display from the lock screen
  
  You probably need to log out and back in for the new screenlocker binary to 
be loaded (or run the kscreenlocker_test binary in the build/bin directory)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl added a comment.


  In D22261#490660 , @broulik wrote:
  
  > Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to 
whitelist this new action so that it also works on the lock screen.
  
  
  I tried adding `|Turn Off Screen` to the powerdevil QRegularExpression but I 
couldn't turn off the display from the lock screen
  my test plan for this is:
  
  - original test plan
  - move mouse so the screen turns on again
  - application launcher -> Leave -> Lock -> confirm
  - press my shortcut
  - (nothing happens)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl added inline comments.

INLINE COMMENTS

> broulik wrote in powerdevildpmsaction.cpp:83
> I suppose there's no `Qt::Key_` enum for that, given laptops typically bypass 
> the operating system here anyway.

I couldn't find any appropriate `Qt::Key_` so I'm leaving it up to the user to 
choose one

> broulik wrote in powerdevildpmsaction.cpp:84
> Use new style connect, you can probably just use a lambda
> 
>   connect(globalAction, ::triggered, this, [this] {
>   if (m_helper) {
>   m_helper->trigger(QStringLiteral("TurnOff"));
>   }
>   });

that if (m_helper) is probably the overloaded != nullptr from 
https://doc.qt.io/qt-5/qscopedpointer.html#operator-not-eq-1
thanks for this hint, it's been a long time since I last did some c++/Qt

> broulik wrote in powerdevildpmsaction.h:57
> For `SLOT(...)` syntax to work this must be in a section `private Q_SLOTS`, 
> but note my comment below about using a lambda instead

sorry for that, I missed that when I moved from a public slot to a private one
your lambda expression is working fine so I'm going with that instead

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl updated this revision to Diff 61124.
mblumenstingl marked 5 inline comments as done.
mblumenstingl added a comment.


  updated patch to address the comments from @broulik

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22261?vs=61118=61124

REVISION DETAIL
  https://phabricator.kde.org/D22261

AFFECTED FILES
  daemon/actions/dpms/CMakeLists.txt
  daemon/actions/dpms/powerdevildpmsaction.cpp

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22261: Add a global shortcut action to turn off the screen

[Kai Uwe Broulik]

broulik added a comment.


  Thanks a lot for your patch!
  I have some minor style nitpicks (you probably just copied them from 
elsewhere but if we're adding new code, it should be tidy ;)
  
  Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to 
whitelist this new action so that it also works on the lock screen.

INLINE COMMENTS

> powerdevildpmsaction.cpp:42
>  
> +#include 
> +

Use `#include ` and sort it correctly into the other includes

> powerdevildpmsaction.cpp:78
> +
> +KActionCollection* actionCollection = new KActionCollection( this );
> +actionCollection->setComponentDisplayName(i18nc("Name for powerdevil 
> shortcuts category", "Power Management"));

Coding style: `KActionCollection *actionCollection` (asterisk after space)

> powerdevildpmsaction.cpp:83
> +globalAction->setText(i18nc("@action:inmenu Global shortcut", "Turn Off 
> Screen"));
> +accel->setGlobalShortcut(globalAction, QList());
> +connect(globalAction, SIGNAL(triggered(bool)), SLOT(turnOffScreen()));

I suppose there's no `Qt::Key_` enum for that, given laptops typically bypass 
the operating system here anyway.

> powerdevildpmsaction.cpp:84
> +accel->setGlobalShortcut(globalAction, QList());
> +connect(globalAction, SIGNAL(triggered(bool)), SLOT(turnOffScreen()));
>  }

Use new style connect, you can probably just use a lambda

  connect(globalAction, ::triggered, this, [this] {
  if (m_helper) {
  m_helper->trigger(QStringLiteral("TurnOff"));
  }
  });

> powerdevildpmsaction.h:57
>  void setKeyboardBrightnessHelper(int brightness);
> +void turnOffScreen();
>  

For `SLOT(...)` syntax to work this must be in a section `private Q_SLOTS`, but 
note my comment below about using a lambda instead

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

To: mblumenstingl, #plasma, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 61120.
leinir added a comment.


  - Also filter on the ghns_excluded tag, otherwise they'll be shown...

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21510?vs=58937=61120

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

AFFECTED FILES
  kcms/desktoptheme/plasma-themes.knsrc

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22261: Add a global shortcut action to turn off the screen

[Martin Blumenstingl]

mblumenstingl created this revision.
mblumenstingl added a reviewer: Plasma.
mblumenstingl added a project: Plasma.
Herald added a subscriber: plasma-devel.
mblumenstingl requested review of this revision.

REVISION SUMMARY
  PowerDevilDPMSAction already provides implementations for X11 and Wayland 
which allow turning off the screen.
  For X11 there was a way to do this on the command line (with "xset dpms force 
off"), but there's no such replacement for Wayland yet.
  
  Add an action - to which users can assign a shortcut - to turn off the screen.

TEST PLAN
  start a plasma wayland session
  open systemsettings5 -> Shortcuts -> Global Shortcuts -> Power Management
  assign a shortcut to "Turn Off Screen"
  press this shortcut
  (screen must now turn off)

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D22261

AFFECTED FILES
  daemon/actions/dpms/CMakeLists.txt
  daemon/actions/dpms/powerdevildpmsaction.cpp
  daemon/actions/dpms/powerdevildpmsaction.h

To: mblumenstingl, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61116.
davidre added a comment.


  - Sort case insensitive

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61115=61116

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre updated this revision to Diff 61115.
davidre added a comment.


  I couldm't crash it by clicking apply but noticed some type errors because 
the proxymodel 
  din't have all the functionality of the underlying model.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22121?vs=61081=61115

BRANCH
  slideshow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22121

AFFECTED FILES
  wallpapers/image/CMakeLists.txt
  wallpapers/image/backgroundlistmodel.h
  wallpapers/image/image.cpp
  wallpapers/image/image.h
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml
  wallpapers/image/slidefiltermodel.cpp
  wallpapers/image/slidefiltermodel.h
  wallpapers/image/slidemodel.cpp
  wallpapers/image/slidemodel.h
  wallpapers/image/slideshowpackage/contents/config/main.xml

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[Mihai Sorin Dobrescu]

msdobrescu added a comment.


  In D22256#490558 , @davidedmundson 
wrote:
  
  > This is awkward timing.
  >
  > See D22121 : [Image Wallpaper 
Slideshow] Allow setting of different sorting orders
  >
  > Sorry
  
  
  It is a different approach. Why not considering?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  Weird. I can't get it to crash at all but I will look at and think about it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

[David Edmundson]

davidedmundson added a comment.


  This is awkward timing.
  
  See D22121 : [Image Wallpaper Slideshow] 
Allow setting of different sorting orders
  
  Sorry

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22256

To: msdobrescu, ngraham, davidre, #plasma
Cc: davidedmundson, davidre, ngraham, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart