D26069: Fix usage of deprecated QSet/QList methods

alexeymin updated this revision to Diff 71749. alexeymin added a comment. I feel sad doing such things REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26069?vs=71748=71749 BRANCH arcpatch-D26069 REVISION DETAIL

D26069: Fix usage of deprecated QSet/QList methods

alexeymin updated this revision to Diff 71748. alexeymin added a comment. Add QT_VERSION_CHECK checks REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26069?vs=71731=71748 BRANCH arcpatch-D26069 REVISION DETAIL

D26069: Fix usage of deprecated QSet/QList methods

alexeymin added a comment. No :( just checked, Qt 5.12's https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qset.h?h=v5.12.0 is missing `inline QSet(InputIterator first, InputIterator last)`, which appeared only in 5.14. I guess I need an `#ifdef` for QSet construction then.

D26072: Port away from KIconThemes

This revision was automatically updated to reflect the committed changes. Closed by commit R128:39ce0e82856e: Port away from KIconThemes (authored by vkrause). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26072?vs=71738=71745 REVISION DETAIL

D26035: battery: Improve the brightness responsiveness

apol updated this revision to Diff 71743. apol added a comment. Use a more meaningful step size for the screen. Having steps of 1 in a 1 to 7000 slider was awkward. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26035?vs=71643=71743 BRANCH

D25945: Sync dark theme preference for GTK3 applications

GB_2 added a comment. In D25945#577731 , @gikari wrote: > In D25945#577677 , @cblack wrote: > > > For flatpaks not respecting the setting preference, have you checked that the dark theme variant is

D26069: Fix usage of deprecated QSet/QList methods

apol added a comment. Will all of this build on Qt 5.12? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26069 To: alexeymin Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

ognarb added a comment. Thanks for the review :) I will create a follow up patch with the ComboBox port when I figure that is going wrong with my desktop theme. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #plasma, davidedmundson Cc:

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R118:3e0877c9c99d: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2 (authored by ognarb). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D26072: Port away from KIconThemes

vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This was only using the deprecated IconSize() method. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > 60: StylePrivate.PropertyWriter is not a type Sounds like you just had your QQC2 style broken. In any case, this code all looks fine. Better to have to port one

D26065: [KCM/Access] Port to use KConfigXT

meven updated this revision to Diff 71734. meven marked 12 inline comments as done. meven added a comment. Address review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71719=71734 BRANCH kaccess-kconfigxt REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb updated this revision to Diff 71733. ognarb marked 2 inline comments as done. ognarb added a comment. - fix naming REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25778?vs=71732=71733 BRANCH arcpatch-D25778 REVISION DETAIL

D26039: [Plasma Style KCM] Add search filter

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Visually LGTM REPOSITORY R119 Plasma Desktop BRANCH filtermodel REVISION DETAIL https://phabricator.kde.org/D26039 To: davidre, #plasma, #vdg, broulik, ndavis Cc: ervin, ndavis,

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb added inline comments. INLINE COMMENTS > guoyunhe wrote in MetadataEditor.qml:108 > This need to be changed to `QQC2.ComboBox` I tried but I get Type QQC2.ComboBox unavailable 60: StylePrivate.PropertyWriter is not a type REPOSITORY R118 Plasma SDK REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb updated this revision to Diff 71732. ognarb marked 2 inline comments as done. ognarb added a comment. - Use same button width as for the text field - Fix dialog not closing - Improve margin REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Looks good to me. Maybe someone besides me who worked more recently on the KCM wants to give his ok as well. If nothing comes in till tomorrow, push. Thanks. REPOSITORY R119 Plasma

D26069: Fix usage of deprecated QSet/QList methods

alexeymin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexeymin requested review of this revision. REVISION SUMMARY COmpiiling with Qt 5.14 produces the following warnings: .../libdiscover/resources/StandardBackendUpdater.cpp:70:43:

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71730. meven marked 2 inline comments as done. meven added a comment. Fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71725=71730 BRANCH nightcolor-default REVISION DETAIL

D26065: [KCM/Access] Port to use KConfigXT

broulik added a comment. I read kaccess.cpp and commented on where the defaults diverge, there could be more. There's also some keys that have typos and/or don't match. This shows quite impressively why having this stuff in a central place is useful :) Given kaccess.cpp is what does the

D26068: [KCM/Activity] Use KConfigXT to store settings

meven updated this revision to Diff 71729. meven added a comment. Ensure the black list opt-in checkbox change apply button state REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26068?vs=71728=71729 BRANCH activity_kcm REVISION DETAIL

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven added inline comments. INLINE COMMENTS > romangg wrote in main.qml:65 > What is this supposed to do? Disable the restore default button REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin, romangg Cc: plasma-devel,

D26068: [KCM/Activity] Use KConfigXT to store settings

meven created this revision. meven added reviewers: Plasma, ervin, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN kcmshell5 kcm_activities Changed settings, restored defaults REPOSITORY R119 Plasma Desktop

D25874: [Task Manager] Consider parent PID for audio stream

broulik added a comment. I have not. Given a browser window typically has dozens of children whereas you typically have few audio streams, I think if any it will be slower. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25874 To: broulik, #plasma, hein Cc:

D25874: [Task Manager] Consider parent PID for audio stream

hein added a comment. Just as a sanity check: libtm knows the pid for a window. Have you checked if there might be a faster way of doing this by checking if the stream pid is among its children? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25874 To:

D25762: Don't bother serializing window icon pixmap for known services

broulik planned changes to this revision. broulik added a comment. > That means you can limit serializing to cases where the window is in usingFallbackIcon. Good idea, I'll give it a try. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To:

D25762: Don't bother serializing window icon pixmap for known services

hein added a comment. Ah right, I didn't look at the code context and forgot we don't just load the custom pixmap in the same function body but also in Private::icon. But we also do this there: `usingFallbackIcon.insert(window)` That means you can limit serializing to cases where

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

romangg added inline comments. INLINE COMMENTS > main.qml:65 > +} else { > +cA.nightColorAvailable = true; > +} What is this supposed to do? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26049 To: meven, #kwin, crossi, ervin,

D25580: [System Tray] Unified data model for System Tray items

kmaterka added a comment. In D25580#578732 , @trmdi wrote: > Please make sure it would not bring this bug back: https://phabricator.kde.org/R120:6fcf9a5e03ba573fd0bfe30125f4c739b196a989 I double checked that. If I understand correctly

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71725. meven added a comment. Mark state as default when nightcolor is not available REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71715=71725 BRANCH nightcolor-default REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

GB_2 added a comment. Ping. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #plasma Cc: GB_2, filipf, guoyunhe, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71724. davidre added a comment. I think this signal is not needed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71723=71724 BRANCH filtermodel REVISION DETAIL https://phabricator.kde.org/D26039

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71723. davidre added a comment. Don't have a overly long line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71722=71723 BRANCH filtermodel REVISION DETAIL https://phabricator.kde.org/D26039

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71722. davidre marked an inline comment as done. davidre added a comment. - better string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71721=71722 BRANCH filtermodel REVISION DETAIL

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71721. davidre added a comment. Diff against master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71720=71721 BRANCH filtermodel REVISION DETAIL https://phabricator.kde.org/D26039 AFFECTED FILES

D26039: [Plasma Style KCM] Add search filter

davidre updated this revision to Diff 71720. davidre marked 2 inline comments as done. davidre added a comment. - Reinstate isSaveNeeded - Fix initial index and pendingDeletion REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26039?vs=71654=71720

D26065: [KCM/Access] Port to use KConfigXT

meven updated this revision to Diff 71719. meven added a comment. Fix some default values REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26065?vs=71716=71719 BRANCH kaccess-kconfigxt REVISION DETAIL https://phabricator.kde.org/D26065 AFFECTED

D26031: feat: access outputs controls through config control

romangg added a comment. In D26031#579232 , @davidedmundson wrote: > Why do we need to compare names as well as ID? The id is the output hash which can be either calculated from its name or edid. If you have two of the same output

D26031: feat: access outputs controls through config control

davidedmundson added a comment. Why do we need to compare names as well as ID? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26031 To: romangg, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26065: [KCM/Access] Port to use KConfigXT

meven created this revision. meven added reviewers: ervin, Plasma, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN Tested changing settings REPOSITORY R119 Plasma Desktop BRANCH kaccess-kconfigxt REVISION

D26039: [Plasma Style KCM] Add search filter

davidre added a comment. In D26039#579200 , @crossi wrote: > Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality. > > - At initialization, the current theme is not selected in the

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71715. meven added a comment. clean up diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71714=71715 BRANCH nightcolor-default REVISION DETAIL https://phabricator.kde.org/D26049 AFFECTED FILES

D24070: Don't use toolTipMainText to show info, rather use the second line

GB_2 added a comment. Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, ndavis Cc: GB_2, ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D26049: [KCM/NightColor] Allow the user to know the default settings are selected

meven updated this revision to Diff 71714. meven added a comment. [KCM/Access] Port to use KConfigXT REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26049?vs=71678=71714 BRANCH kaccess-kconfigxt REVISION DETAIL

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality. - At initialization, the current theme is not selected in the grid view. - When settings a theme for deletion, it does not activate the apply button

D26063: QMultiHash::insertMulti is deprecated. Use directly ::insert

This revision was automatically updated to reflect the committed changes. Closed by commit R111:3f2fab734574: QMultiHash::insertMulti is deprecated. Use directly ::insert (authored by mlaurent). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir added a comment. In D25961#578727 , @zachus wrote: > is there a server out there to run it against? The provider file points it at the opendesktop.org server (that is to say, the KDE Store), so testing can be done against the live

D26056: [dataengine/geolocation] Add logging category

This revision was automatically updated to reflect the committed changes. Closed by commit R120:523ef71c8790: [dataengine/geolocation] Add logging category (authored by meven). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26056?vs=71710=71711

D26056: [dataengine/geolocation] Add logging category

meven updated this revision to Diff 71710. meven added a comment. Use qCDebug/qCWarning instead of qDebug/qWarning REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26056?vs=71704=71710 BRANCH arcpatch-D26056 REVISION DETAIL

D25539: feat(kcm): add revert timer

broulik added a comment. > With direct-apply having a revert window/overlay/inline message only shown when certain critical options were changed could be a good compromise. It needs to be made absolute sure, though, that the keyboard focus is correct, so hitting e.g. Return will undo

D25539: feat(kcm): add revert timer

romangg added a comment. With direct-apply having a revert window/overlay/inline message only shown when certain critical options were changed could be a good compromise. Though I would still like to see direct-apply land first in this case and then we can look into when and how the revert

D26042: Captive portal notification improvements

davidedmundson added a comment. Due to a confusing design notification objects can delete themselves. If the network changes after the notification is externally closed this will crash. INLINE COMMENTS > portalmonitor.h:42 > +private: > +KNotification *m_notification = nullptr; >

D25762: Don't bother serializing window icon pixmap for known services

broulik added a comment. > why don't we just change the check to QIcon::isNull? We still want to serialize custom pixmap data icons which won't be null. What we want to do is tell between "icon on disk" and "icon from pixmap data" which we can't really at the moment. REPOSITORY R120

D25807: Allow to set the available screen rect/region from outside through dbus

davidre added a comment. In D25807#579144 , @trmdi wrote: > In D25807#579125 , @davidre wrote: > > > I have a question about naming. If I had an application like panel or latte I would call

D26056: [dataengine/geolocation] Add logging category

meven added inline comments. INLINE COMMENTS > location_gps.cpp:98 > } else { > -qDebug() << "gpsd not found"; > +qWarning(DATAENGINE_GEOLOCATION) << "gpsd not found"; > } Change to qCWarning REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D26056 REVISION

D26041: Move applet configuration to KCM

jgrulich marked 10 inline comments as done. jgrulich added inline comments. INLINE COMMENTS > ngraham wrote in ConfigurationDialog.qml:55 > this shouldn't need to be in `Component.onCompleted:`; just set `checked` > directly as a binding: `checked: configuration.unlockModemOnDetection` I did

D26041: Move applet configuration to KCM

jgrulich updated this revision to Diff 71707. jgrulich added a comment. Fix review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26041?vs=71657=71707 BRANCH kcm-config REVISION DETAIL

D25762: Don't bother serializing window icon pixmap for known services

hein added a comment. If the concern is that QIcon::name isn't good enough but we actually have an icon inside, why don't we just change the check to QIcon::isNull? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25762 To: broulik, #plasma, hein Cc:

D26042: Captive portal notification improvements

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1ffef126b8f0: Captive portal notification improvements (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

kquickcharts should be added to plasma-workspace as dependency

Hi, I found that plasma-workspace (notification applet) requires KQuickCharts, but it is not added as a dependency in kdesrc-build. As a result I've got this error: file:///home/user/kde/usr/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/main.qml:96:37: Type CompactRepresentation

D26045: Add immutability to KCM Icons

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Yes it should. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To:

D26052: KCM Cursor Theme : Use ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:367 > { > m_settings->save(); > +setPreferredSize(m_settings->cursorSize()); Now you should simply call ManagedConfigModule::save(); instead > kcmcursortheme.cpp:384 > { > m_settings->load(); > +

D25807: Allow to set the available screen rect/region from outside through dbus

trmdi added a comment. In D25807#579125 , @davidre wrote: > I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not

D26047: Expose KConfig settings to allow registration in KCM Notification

broulik added inline comments. INLINE COMMENTS > settings.h:343 > > +QList configSkeletons() const; > + Not a fan of this becoming public API REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26047 To: crossi, #plasma, #frameworks, ervin, bport,

D26045: Add immutability to KCM Icons

broulik added inline comments. INLINE COMMENTS > main.qml:38 > view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme) > -enabled: !kcm.downloadingFile > Why this change? > main.qml:55 > > +enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to > change

D24846: Port kcm icons to kconfigxt

crossi added inline comments. INLINE COMMENTS > iconsmodel.cpp:29 > #include > +#include > include not used REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24846 To: bport, ervin, mart, #plasma, crossi Cc: broulik, plasma-devel, LeGast00n,

D25807: Allow to set the available screen rect/region from outside through dbus

davidre added a comment. I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not available isn't it but rather not available anymore? Maybe I'm understanding the