D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, I did find one problem that I missed from before: F6971880: sidebar_tree-2019-07-05_00.04.24.webm REPOSITORY R31 Breeze

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. As far as I can tell, there aren't any problems with this patch. Some apps like Spectacle and the system tray settings don't follow the new style, but they don't use Qt Widgets for the

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.12 - Build # 138 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.12/138/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Jul 2019 23:04:34 + Build duration: 2 min 22 sec and counting CONSOLE

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Jul 2019 23:04:34 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 127 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/127/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Thu, 04 Jul 2019 23:04:33 + Build duration: 1 min 35 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 138 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/138/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Thu, 04 Jul 2019 23:04:34 + Build duration: 1 min 11 sec and counting CONSOLE OUTPUT

D22231: [Lock screen] Follow KDE title & subtitle style

filipf added a comment. Ping, with D22230 landed this should also follow quite soon. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22231 To: filipf, #plasma, #vdg, ngraham Cc: broulik, plasma-devel, LeGast00n,

D22230: [TaskManager] Follow KDE title & subtitle style

This revision was automatically updated to reflect the committed changes. Closed by commit R119:741ffda94294: [TaskManager] Follow KDE title subtitle style (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22230?vs=61062=61180

D22128: [Kickoff] Redo tab bar separator's geometry

This revision was automatically updated to reflect the committed changes. Closed by commit R119:76045bf20e07: [Kickoff] Redo tab bar separators geometry (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22128?vs=60750=61179 REVISION

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. In D22121#490983 , @ngraham wrote: > I still get the same crash. :( Very weird I just tried it in a VM which hadn't seen the patch at all yet and it doesn't crash. REPOSITORY R120 Plasma Workspace REVISION

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ndavis added a comment. In D22138#491018 , @hpereiradacosta wrote: > In D22138#490967 , @ndavis wrote: > > > Since this apparently doesn't need review, > > > This is not what I said. What I

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta added a comment. In D22138#490976 , @ngraham wrote: > Very nice! In conjunction with Marco's patch (D22083 ), I now see the following for Dolphin's settings window: F6968869:

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

hpereiradacosta added a comment. In D22138#490967 , @ndavis wrote: > Since this apparently doesn't need review, This is not what I said. What I said is "thanks, it looks fantastic" is not a proper review and hence irrelevant. What I

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. I still get the same crash. :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4dcd1588c1cf: doc: Some different phrasing, one instance of s/KDE/Plasma/ (authored by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ngraham added a comment. Very nice! In conjunction with Marco's patch (D22083 ), I now see the following for Dolphin's settings window: F6968869: Screenshot_20190704_134502.png I notice that your screenshot

D22138: Remove 1 pixel margin around side panels, use QPalette::Base for background

ndavis resigned from this revision. ndavis added a comment. Since this apparently doesn't need review, I'll resign. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22138 To: hpereiradacosta, mart, #vdg, filipf Cc: ngraham, ndavis, filipf, mart, plasma-devel,

D22202: [mobile/wifi] Rework NetworkSetting footer

This revision was automatically updated to reflect the committed changes. Closed by commit R116:ba4ddb4ae40a: [mobile/wifi] Rework NetworkSetting footer (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 61150. davidedmundson added a comment. Reset state when told to resume an empty session REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=61149=61150 BRANCH master REVISION DETAIL

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 61149. davidedmundson added a comment. update2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=61147=61149 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21995 AFFECTED FILES

D21995: Split ksmserver into a small application that handles startup and ksmserver

davidedmundson updated this revision to Diff 61147. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21995?vs=61015=61147 REVISION DETAIL https://phabricator.kde.org/D21995 AFFECTED FILES

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#490851 , @ngraham wrote: > In D21510#488800 , @leinir wrote: > > > In D21510#488646 , @ngraham wrote: > > > > > Yep,

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir added a comment. In D21510#490850 , @ngraham wrote: > In D21510#490635 , @leinir wrote: > > > - Also filter on the ghns_excluded tag, otherwise they'll be shown... > > > I thought that

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. In D21510#488800 , @leinir wrote: > In D21510#488646 , @ngraham wrote: > > > Yep, seems to work and makes sense. Let's get this in so we can start tagging things. > >

D21510: Filter KNewStuff Plasma Themes by Download Tag

ngraham added a comment. In D21510#490635 , @leinir wrote: > - Also filter on the ghns_excluded tag, otherwise they'll be shown... I thought that was taken care of on the server side? REPOSITORY R119 Plasma Desktop BRANCH

D11234: [DrKonqi] Show debug button when KDevelop session is running

kossebau added a comment. Ping? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick, #plasma_workspaces, apol, mwolff, #kdevelop, sitter Cc: kossebau, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D22268: Port containmentActions to use KPlugin instead of KService

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It saves us from going through the deprecated (slower) path and will leverage the PluginLoader lookup

D21963: Keep Klipper notifications out of notification history

This revision was automatically updated to reflect the committed changes. Closed by commit R120:120aed57ced1: Keep Klipper notifications out of notification history (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22264: Always call into ksmserver DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R120:77376fa80290: Always call into ksmserver DBus interface (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22264?vs=61128=61133

D22264: Always call into ksmserver DBus interface

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Previously, it would ask ksmserver to show the logout prompt and otherwise

D22261: Add a global shortcut action to turn off the screen

This revision was automatically updated to reflect the committed changes. Closed by commit R122:119943e6b883: Add a global shortcut action to turn off the screen (authored by mblumenstingl, committed by broulik). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#490680 , @broulik wrote: > Alright, very nice! > I suppose you don't have commit access, so I need an email address from you to add you as commit author. Thanks! I once had commit access but

D22261: Add a global shortcut action to turn off the screen

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Alright, very nice! I suppose you don't have commit access, so I need an email address from you to add you as commit author. Thanks! > I tried adding |Turn Off Screen to the

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added a comment. In D22261#490660 , @broulik wrote: > Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to whitelist this new action so that it also works on the lock screen. I tried adding `|Turn Off

D22261: Add a global shortcut action to turn off the screen

mblumenstingl added inline comments. INLINE COMMENTS > broulik wrote in powerdevildpmsaction.cpp:83 > I suppose there's no `Qt::Key_` enum for that, given laptops typically bypass > the operating system here anyway. I couldn't find any appropriate `Qt::Key_` so I'm leaving it up to the user to

D22261: Add a global shortcut action to turn off the screen

mblumenstingl updated this revision to Diff 61124. mblumenstingl marked 5 inline comments as done. mblumenstingl added a comment. updated patch to address the comments from @broulik REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22261?vs=61118=61124

D22261: Add a global shortcut action to turn off the screen

broulik added a comment. Thanks a lot for your patch! I have some minor style nitpicks (you probably just copied them from elsewhere but if we're adding new code, it should be tidy ;) Bonus points if you also make a patch for kscreenlocker globalaccel.cpp to whitelist this new action

D21510: Filter KNewStuff Plasma Themes by Download Tag

leinir updated this revision to Diff 61120. leinir added a comment. - Also filter on the ghns_excluded tag, otherwise they'll be shown... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21510?vs=58937=61120 BRANCH filter-themes-by-download-tags

D22261: Add a global shortcut action to turn off the screen

mblumenstingl created this revision. mblumenstingl added a reviewer: Plasma. mblumenstingl added a project: Plasma. Herald added a subscriber: plasma-devel. mblumenstingl requested review of this revision. REVISION SUMMARY PowerDevilDPMSAction already provides implementations for X11 and

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61116. davidre added a comment. - Sort case insensitive REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22121?vs=61115=61116 BRANCH slideshow (branched from master) REVISION DETAIL

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre updated this revision to Diff 61115. davidre added a comment. I couldm't crash it by clicking apply but noticed some type errors because the proxymodel din't have all the functionality of the underlying model. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu added a comment. In D22256#490558 , @davidedmundson wrote: > This is awkward timing. > > See D22121 : [Image Wallpaper Slideshow] Allow setting of different sorting orders > > Sorry

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. Weird. I can't get it to crash at all but I will look at and think about it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma Cc: msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh,

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

davidedmundson added a comment. This is awkward timing. See D22121 : [Image Wallpaper Slideshow] Allow setting of different sorting orders Sorry REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22256 To: