4.3 branch plasma crash in AbstractTaskItem::basicPreferredSize

2009-08-07 Thread David Faure
, receiver=0x2c3fa48, event=0x7fff4322eac0) at kernel/qcoreapplica tion.cpp:606 #29 0x7fd336907d91 in QCoreApplication::sendEvent (receiver=0x2c3fa48, event=0x7fff4322eac0) at ../../include/QtCore/../../src/corelib/k ernel/qcoreapplication.h:213 -- David Faure, fa...@kde.org, sponsored by Qt

Re: 4.3 branch plasma crash in AbstractTaskItem::basicPreferredSize

2009-08-07 Thread David Faure
On Friday 07 August 2009, Marco Martin wrote: On Friday 07 August 2009, David Faure wrote: Plasma crashes rather often for me. I finally got a bt of the crash. Is this enough info for anyone to fix it? And now I got another backtrace, no null pointer this time (am I the only one opening

Fwd: [Kde-dashboard] Failed 4.4/kdebase-workspace r1013206

2009-08-19 Thread David Faure
--- -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

more info on the TaskGroupItem crash

2009-09-10 Thread David Faure
. -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: more info on the TaskGroupItem crash

2009-09-11 Thread David Faure
On Friday 11 September 2009, Aaron J. Seigo wrote: On September 10, 2009, David Faure wrote: I finally took the time to investigate the plasma crash that was happening so often to me. can you try the attached patch? thanks. The patch fits exactly my analysis of the problem, but it looks

Re: more info on the TaskGroupItem crash

2009-09-11 Thread David Faure
On Friday 11 September 2009, Aaron J. Seigo wrote: On September 10, 2009, David Faure wrote: I finally took the time to investigate the plasma crash that was happening so often to me. can you try the attached patch? thanks. It definitely hits this code path often... QGraphicsScene

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-14 Thread David Faure
, for a reason I cannot remember. On one hand we should probably merge that so that it's less confusing, on the other hand it would make reparseConfiguration more expensive again ;-) -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-16 Thread David Faure
On Tuesday 15 September 2009, 潘卫平(Peter Pan) wrote: Looking forward to your code using KDirWatch on ktrashrc. I didn't say _I_ was going to do it :-) -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org

Re: PlasmaKPart moved to kdereview

2010-08-17 Thread David Faure
doesn't matter, it's never called). Years after the fact, I can see that openFile() shouldn't have been a pure virtual, but a simple { return false; } default implementation. I guess I can make that change now, actually, this should be BC/SC. Doing that now. -- David Faure, fa...@kde.org, http

Re: The case for a kdelibs 4.8

2011-09-30 Thread David Faure
git merge support for kdelibs master we could re-evaluate the decision to freeze it, it's less work than having to cherry-pick every fix into 3 branches. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
. How about adding a SETTINGS_LOCALE if that's what you need? - David Faure On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103434

Re: Review Request: Reset time format upon user request

2011-12-18 Thread David Faure
only went for the minimal lines of code fix all the time, we would have one hell of a mess by now... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5 ___ Plasma-devel mailing list Plasma

Re: Review Request: Reset time format upon user request

2011-12-19 Thread David Faure
On Sunday 18 December 2011 20:26:42 Lamarque V. Souza wrote: Em Sunday 18 December 2011, David Faure escreveu: On Sunday 18 December 2011 12:51:25 Lamarque Vieira Souza wrote: Another problem with this approach is that we cannot prevent anybody else from listening to KGlobalSettings

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
://git.reviewboard.kde.org/r/103469/#comment7509 I like the idea (KGlobalSettings reparsing configuration), but not the implementation (setLanguage(langage)). Can't KLocale get a reparseConfiguration() (to reuse the KConfig naming) ? - David Faure On Dec. 19, 2011, 2:02 p.m., Lamarque Vieira Souza wrote

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867lin e886 I like the idea (KGlobalSettings reparsing

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-19 Thread David Faure
On Monday 19 December 2011 15:01:51 Lamarque V. Souza wrote: Em Monday 19 December 2011, David Faure escreveu: On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote: On Dec. 19, 2011, 2:35 p.m., David Faure wrote: kdeui/kernel/kglobalsettings.cpp, line 886 http

Re: Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().

2011-12-27 Thread David Faure
/4.8 - David Faure On Dec. 19, 2011, 10:15 p.m., Lamarque Vieira Souza wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103469

Re: Review Request: Remember current desktop when changing activity

2012-03-18 Thread David Faure
On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: makis marimpis wrote: Hm, i did that in order to restore the desktop ids from a previous run of kamd (let's say, in case of log out). Ivan Čukić wrote: You misunderstood, I don't mind saving it in the config file, I don't

Re: Review Request: Make Sonnet::Speller::setLanguage threadsafe, fixing segfaults in krunner

2012-09-06 Thread David Faure
of the method. - David Faure On Aug. 27, 2012, 9:33 p.m., Simeon Bird wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106242

Re: Notifications-future, a recap

2012-09-17 Thread David Faure
:-) But mandatory runtime requirements such as daemons and stuff, should be part of the framework, in the future. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list

Re: Git policy for kde-baseapps?

2012-09-18 Thread David Faure
new API is quickly needed in all branches, and to prevent too much merging work piling up due to the major differences between kdelibs-4.x and kdelibs-frameworks, but that is irrelevant in kde-baseapps) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-23 Thread David Faure
(and in particular so that it can all use the same command-line args parser). - David Faure On Sept. 21, 2012, 3:29 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Make it possible to use QtCreator QML profiler and debugger with KDE Applications

2012-09-28 Thread David Faure
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106527/ --- (Updated Sept. 21, 2012, 3:29 p.m.) Review request for kdelibs, Plasma, Marco Martin, and David Faure

Re: repository changes for plasma2/frameworks5

2013-01-29 Thread David Faure
build.kde.org now for this :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by BlueSystems and KDAB to work on KDE Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread David Faure
://git.reviewboard.kde.org/r/108889/#comment20443 For an install prefix in /usr, this would make it /usr/qml ... is this really wanted? Shouldn't this be QT_PLUGIN_INSTALL_DIR/qml, i.e. /usr/lib/plugins/qml ? - David Faure On Feb. 10, 2013, 3:37 p.m., Sebastian Kügler wrote

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
On Feb. 10, 2013, 3:40 p.m., David Faure wrote: kde-modules/KDEInstallDirs.cmake, line 136 http://git.reviewboard.kde.org/r/108889/diff/1/?file=113440#file113440line136 For an install prefix in /usr, this would make it /usr/qml ... is this really wanted? Shouldn't

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27273 --- Ship it! Ship It! - David Faure On Feb. 12, 2013, 4 a.m

Re: Please update extra-cmake-modules, kdelibs (and plasma-frameworks)

2013-02-28 Thread David Faure
against changing names of the imported targets. I don't expect this to happen too often ... and if it does, I'd much rather see -lsolid not found than a linker error about symbols from solid being missing, even though the variable is actually there in the target_link_libraries line... -- David

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-07 Thread David Faure
is the actual purpose of the class, and in which case it should be used. - David Faure On Aug. 6, 2013, 12:25 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-09 Thread David Faure
by a runtime hook. Just an idea. Don't know how much core/gui separation is useful for this class. - David Faure On Aug. 9, 2013, 12:38 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 112073: Partially revert commit 83d3018

2013-08-19 Thread David Faure
Aug. 14, 2013, 12:01 a.m.) Review request for Plasma and David Faure. Description --- While the commit may be technically correct, it breaks ksplash for 4.11 release... I've changed unique to multi, if there is a better solution, please hint it ;-) (maybe actually someone

Re: Review Request 112073: Partially revert commit 83d3018

2013-08-20 Thread David Faure
commit. - David Faure On Aug. 14, 2013, 12:01 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112073

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-03 Thread David Faure
On Aug. 9, 2013, 7:27 p.m., David Faure wrote: tier1/kconfig/src/gui/kconfigloader.h, line 99 http://git.reviewboard.kde.org/r/111908/diff/4/?file=177609#file177609line99 I wonder if this should really derive from KConfigSkeleton, rather than encapsulate

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review39867 --- Ship it! OK then. - David Faure On Aug. 9, 2013, 12:38 p.m

Re: 4.11 is out .. kde-workspace to qt5?

2013-09-17 Thread David Faure
into the framework it belongs to? David, is the plan to move the KIO slaves from kde-runtime into KIO itself? Yes. But let's do that *after* kdelibs is split up. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

KModifierKeyInfo usage and API

2013-10-16 Thread David Faure
its API? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-10-21 Thread David Faure
On Oct. 16, 2013, 12:15 p.m., John Layt wrote: Wow, there sure is a lot of code in there catering for all the possible corner cases :-) QTimeZone has a lot less places it checks, so I'll need to do an in-depth comparison, but given Qt5 will only support modern distros I think most

Re: Review Request 113260: Port KTimeZoned to Qt5/KF5

2013-11-10 Thread David Faure
that might make sense for some users. But if the real solution for Solaris support is to do it in Qt rather than here, then this code doesn't make sense anymore, remove it. - David Faure On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote

Re: KModifierKeyInfo usage and API

2013-11-10 Thread David Faure
Aaron? Anyone from the plasma team? I would appreciate input on this (see precise question at the end), it's preventing KF5 from moving forward with KModifierKeyInfo. Please CC kde-frameworks-devel, I'm not on plasma-devel. On Wednesday 16 October 2013 09:56:03 David Faure wrote: We are still

KDE_PLATFORM_PROFILE in kde-workspace

2013-11-24 Thread David Faure
of cmake logic from kdelibs to kde-workspace, but if you have bigger plans, please let me know. plasma itself doesn't use this cmake var (anymore). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: KDE_PLATFORM_PROFILE in kde-workspace

2013-11-24 Thread David Faure
On Sunday 24 November 2013 18:26:30 Martin Graesslin wrote: On Sunday 24 November 2013 18:12:48 David Faure wrote: kde-workspace still uses this cmake variable, set by kdelibs, but KF5 itself doesn't use it at all. What's the plan about this in kde-workspace? It's currently used

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-04 Thread David Faure
://git.reviewboard.kde.org/r/114253/#comment32266 This line is a noop. fromLocalFile is a static method. I think setPath was actually correct here, you're changing the path of an existing full URL. - David Faure On Dec. 3, 2013, 9:53 a.m., Andrea Scarpino wrote

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-05 Thread David Faure
of creating a temporary QImage just for comparison purposes. - David Faure On Dec. 5, 2013, 10:48 a.m., Andrea Scarpino wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253

Re: Review Request 114253: Port favicons dataengine to KF5

2013-12-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/#review45222 --- Ship it! Ship It! - David Faure On Dec. 5, 2013, 6:01 p.m

Re: kf5 alpha 1 : modules, versions

2014-02-06 Thread David Faure
On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote: On 02/03/2014 08:17 PM, David Faure wrote: Any new module that should be added to this release, compared to TP1? I see that plasma-framework.yaml says tier 3, is that correct - wouldn't it mean it should be released

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Thursday 06 February 2014 23:32:11 David Faure wrote: On Wednesday 05 February 2014 22:42:00 Michael Palimaka wrote: On 02/03/2014 08:17 PM, David Faure wrote: Any new module that should be added to this release, compared to TP1? I see that plasma-framework.yaml says tier 3

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself to be version 2.0.0. Can I change that to 4.96.0 like all

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
On Saturday 08 February 2014 11:36:26 Marco Martin wrote: On Saturday 08 February 2014 10:59:19 David Faure wrote: On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread David Faure
btw: commit 2702febc7474537b19d816a941261755b04798f4 Author: Aaron Seigo ase...@kde.org cut off adding/removing activities at the source -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: kf5 alpha 1 : modules, versions

2014-02-11 Thread David Faure
update the file kf5-frameworks-build-include in the kdesrc-build repo. But still, adding an entry into logical-module-structure would be good for the future. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 116085: welcome back the javascript interactive console

2014-03-01 Thread David Faure
On Feb. 26, 2014, 5:43 p.m., Hrvoje Senjan wrote: src/shell/CMakeLists.txt, line 20 https://git.reviewboard.kde.org/r/116085/diff/2/?file=246330#file246330line20 This would mean: a) propagate KTextEditor to part of the KF5 releases (that was not the case with TP1 alpha1)

Meta key and Qt (Re: kglobalaccel fixes)

2014-03-16 Thread David Faure
, so it basically ignores my xmodmap configuration. [*] keycode 133 = Meta_L Meta_L Meta_L Meta_L -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

2014-04-23 Thread David Faure
in the kde4 world now. :-) I just moved kactivities to frameworks/. Anyone using kdesrc-build: you should delete kde/kdelibs/kactivities because kdesrc-build is now using frameworks/kactivities. Whichever branch you're hacking on ! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

Re: Plasma Next - Translations KCM - What Languages?

2014-04-23 Thread David Faure
!!! :-) I would suggest using the same system for everything else that was so far covered by standalone language packages, and doing away with them. No opinion from me about workspace and apps. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM

2014-04-23 Thread David Faure
On April 15, 2014, 10:17 a.m., Martin Gräßlin wrote: David Faure changed the code with 1206a3eaaf31c5438011a53c4839e27249037ac0 to use QProcess. Should we still apply this patch or not? Yes, go ahead. Your analysis is more complete than my mindless port ;) - David

Re: Review Request 117584: Standardise DBus service CMake code

2014-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117584/#review56502 --- Ship it! Ship It! - David Faure On April 16, 2014, 10:50

Fwd: [kconfig] src/core: Store app config file in ~/.config/domain/apprc

2014-05-04 Thread David Faure
-- Subject: [kconfig] src/core: Store app config file in ~/.config/domain/apprc Date: Sunday 04 May 2014, 21:26:08 From: David Faure fa...@kde.org To: kde-comm...@kde.org Git commit 625e124898afad04ab5c3939b1b129b6014046cd by David Faure. Committed on 04/05/2014 at 17:13. Pushed by dfaure

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config/domain/apprc

2014-05-05 Thread David Faure
On Monday 05 May 2014 07:25:37 Martin Gräßlin wrote: On Sunday 04 May 2014 23:53:40 David Faure wrote: Hello, please note this change in KConfig. I would recommend making sure your applications call app.setOrganizationDomain(kde.org) so that the config files go into the right

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config/domain/apprc

2014-05-05 Thread David Faure
On Monday 05 May 2014 08:29:07 Martin Gräßlin wrote: On Monday 05 May 2014 08:17:49 David Faure wrote: On Monday 05 May 2014 07:25:37 Martin Gräßlin wrote: On Sunday 04 May 2014 23:53:40 David Faure wrote: Hello, please note this change in KConfig. I would recommend

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config/domain/apprc

2014-05-05 Thread David Faure
On Monday 05 May 2014 11:13:31 Marco Martin wrote: On Sunday 04 May 2014, David Faure wrote: Hello, please note this change in KConfig. I would recommend making sure your applications call app.setOrganizationDomain(kde.org) so that the config files go into the right subdir right

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
the unittest? Does it still pass without that check? kurifilter-plugins/shorturi/kshorturifilter.cpp https://git.reviewboard.kde.org/r/118017/#comment39947 Better use QUrl u = QUrl::fromLocalFile(path) then. - David Faure On May 6, 2014, 12:42 p.m., Alexander Richardson wrote

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
On May 6, 2014, 12:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
-extras. - David Faure On May 6, 2014, 12:42 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017

Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread David Faure
On May 6, 2014, 10:01 p.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Alexander Richardson wrote: Okay, I guess this review can be dropped then, right? Yes, I think so. Feel free to commit the unit tests though, that's always good

Re: Review Request 118017: Fix expansion of ~

2014-05-07 Thread David Faure
On May 6, 2014, 10:01 p.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Alexander Richardson wrote: Okay, I guess this review can be dropped then, right? David Faure wrote: Yes, I think so. Feel free to commit the unit tests

Re: Fwd: [kconfig] src/core: Store app config file in ~/.config/domain/apprc

2014-05-07 Thread David Faure
On Monday 05 May 2014 11:45:22 Marco Martin wrote: On Monday 05 May 2014, David Faure wrote: does KSharedConfig::openConfig(confignamerc) now tries in ~/.config or in ~/.config/kde.org ? (supposing the domain is set) I reverted the change for now. ok, so i will delay any local

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
://git.reviewboard.kde.org/r/117954/ --- (Updated May 23, 2014, 8:45 a.m.) Review request for Plasma and David Faure. Repository: kde-cli-tools Description --- This patch contains multiple commits, which I can make available

Re: Review Request 117954: Port keditfiletype away from kde4support

2014-05-27 Thread David Faure
://git.reviewboard.kde.org/r/117954/#comment40794 comment is wrong, can't be 0 anymore. - David Faure On May 23, 2014, 8:45 a.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118476: Move kded module to kf5/kded subdirectory

2014-06-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118476/#review59126 --- Ship it! Ship It! - David Faure On June 2, 2014, 4:39 p.m

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59507 --- Ship it! Ship It! - David Faure On June 6, 2014, 12:39

Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

2014-06-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/#review60305 --- Ship it! Ship It! - David Faure On June 17, 2014, 4:16

Review Request 118896: Fix 2 data races in runnercontext, mention another one.

2014-06-23 Thread David Faure
plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3 Diff: https://git.reviewboard.kde.org/r/118896/diff/ Testing --- Typing various things into krunner. The main crash is still there though: baloo or xapian isn't reentrant; but that's separate. Thanks, David Faure

Re: Review Request 118896: Fix 2 data races in runnercontext, mention another one.

2014-06-25 Thread David Faure
there though: baloo or xapian isn't reentrant; but that's separate. Thanks, David Faure ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119053: KGlobalAccel fixes for loading shortcuts

2014-07-01 Thread David Faure
/119053/#comment42722 sounds like shortcutFromInList(keys) should be put in a local variable, for use in this line and the next. - David Faure On July 1, 2014, 7:59 a.m., Martin Gräßlin wrote: --- This is an automatically

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
doesn't really need sed. - David Faure On July 6, 2014, 12:52 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). - David Faure On July 6, 2014, 1:19 p.m., Luca Beltrame wrote: --- This is an automatically

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
On July 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). I mean we should be using

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/#review61706 --- Ship it! Thanks. - David Faure On July 6, 2014, 1:28 p.m

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
On July 6, 2014, 1:25 p.m., David Faure wrote: I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's missing in qtpaths, I'll fix that. We should be using it, because ConfigLocation includes the appname on Windows (big whoops). David Faure wrote: I

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
/119145/#comment42946 comment needs to be updated startkde/startkde.cmake https://git.reviewboard.kde.org/r/119145/#comment42945 comment needs to be updated - David Faure On July 6, 2014, 1:35 p.m., Luca Beltrame wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
/119145/#comment42950 s/Move to/Use/ - we don't have to move any files :-) - David Faure On July 6, 2014, 1:46 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Kioslave repos

2014-08-19 Thread David Faure
On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: On Sunday 27 April 2014 19:35:37 I wrote: * place that repo in kde/ or kde/something in the projects.kde.org hierarchy, so that it gets released with the KDE

Re: Review Request 120040: Install kdesu under bin

2014-09-05 Thread David Faure
On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: I'm a bit worried by the multitude of user and distro specific scripts that rely on kdesu being present :/ Marco Martin wrote: to me either way it gets fixed i'm ok. the other option is to keep it called kdesu, so it wouldn't be

Re: Kioslave repos

2014-09-11 Thread David Faure
On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM

DialogNativeTest::position() breakage

2014-10-11 Thread David Faure
-frameworks-de...@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel - -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-12 Thread David Faure
then use KRun directly in the kio code that looks up x-scheme-handler stuff (grep says: KRun and DesktopExecParser). - David Faure On Oct. 12, 2014, 8:40 p.m., Luc Menut wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-13 Thread David Faure
On Oct. 12, 2014, 8:51 p.m., David Faure wrote: kcms/componentchooser/componentchooserbrowser.cpp, line 102 https://git.reviewboard.kde.org/r/120568/diff/1/?file=318115#file318115line102 No, I am very much against this. The whole point of use the right KDE app is to use

Re: Review Request 120568: Save the default browser into the group [Default Applications]

2014-10-13 Thread David Faure
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120568/ --- (Updated Oct. 12, 2014, 8:40 p.m.) Review request for Plasma and David Faure

Re: Review Request 120565: Save the default file manager into the group [Default Applications]

2014-10-13 Thread David Faure
is obsoleted by this, I guess you're keeping it for old implementations, that's fine. Hmm, well, kservice/src/kbuildsycoca/kmimeassociations.cpp is such an old implementation, it doesn't read Default Applications yet :-) That's something else you might want to fix ;) - David Faure On Oct. 12

Re: Review Request: Libkonq support for the nepomuk search runner

2009-01-19 Thread David Faure
of context -- which part of libkonq is the Locations runner interested in? -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ Plasma-devel mailing list

Re: Review Request: Libkonq support for the nepomuk search runner

2009-01-19 Thread David Faure
is that we don't need to move all of libkonq, we can move the classes that do make sense for other users than dolphin+konqueror, just like FileUndoManager has moved to kio already. -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org

Re: Review Request: Libkonq support for the nepomuk search runner

2009-02-10 Thread David Faure
implemented in kdebase/apps. Given that apps has a dependency on workspace, it's certainly ok to put a runner in apps that implements konq-specific stuff, isn't it? Or does it support multiple browsers? (but then, could the konq part be splitted out from the rest maybe?) -- David Faure, fa

KDE/kdelibs

2009-03-04 Thread David Faure
SVN commit 935291 by dfaure: Make ksycoca threadsafe. Summary of changes: - OOo design for the 4 ways to access ksycoca data (mmap, qfile, shared mem, dummy qbuffer), which also allows to have a KConfig key for choosing the technology to use. - per-thread KSycoca::self() and per-thread sycoca

Moving code for Open With and ServiceMenu actions to kdelibs

2009-03-18 Thread David Faure
cleaned up compared to what was in libkonq). Of course I also ported the libkonq classes to those new classes (can't remove them, for BC reasons, but they are now mere wrappers). -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org

Re: Moving code for Open With and ServiceMenu actions to kdelibs

2009-05-06 Thread David Faure
On Tuesday 05 May 2009, Allen Winter wrote: On Tuesday 17 March 2009 4:03:03 pm David Faure wrote: The code for handling open with action/submenus and servicemenus (RMB / Actions / ...) is currently in libkonq (and used by dolphin and konqueror), but I have received a number

Re: KDE/kdebase/workspace/plasma/applets/kickoff/core

2009-07-20 Thread David Faure
)), this, SLOT(checkSycocaChange())); It would be a good idea to check that the stringlist includes apps or xdgdata-apps and bailing out early if not. That's the whole point of the argument: to not update apps stuff if e.g. only mimetypes or servicetypes changed. -- David Faure, fa...@kde.org

Re: KDE/kdebase/workspace/plasma/applets/kickoff/core

2009-07-21 Thread David Faure
On Tuesday 21 July 2009, Aaron J. Seigo wrote: On Monday 20 July 2009, David Faure wrote: On Saturday 11 July 2009, Michael Jansen wrote: SVN commit 994994 by mjansen: Fix runtime warning: type=Qt::AutoConnection) at /home/mjansen/kde/trunk/src/qtmaster/src/corelib/kernel

Re: Review Request 120564: Write default file manager into mimeapps.list in XDG_CONFIG_HOME

2014-10-14 Thread David Faure
account? I don't have time to submit all your patches :-) https://techbase.kde.org/Contribute/Get_a_Contributor_Account - David Faure On Oct. 12, 2014, 5:48 p.m., Luc Menut wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 120569: Save the default email client into the group [Default Applications]

2014-10-18 Thread David Faure
(the EmailClient and the x-scheme-handler/mailto. - David Faure On Oct. 12, 2014, 8:43 p.m., Luc Menut wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120569

Re: Fwd: Plasma Framework problems

2014-10-19 Thread David Faure
-pick and I'll make a 5.3.1 with it. Sorry for the delay. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

  1   2   3   4   5   >