Re: Meeting on store content distribution after Monday's Plasma meeting

On Thursday, March 21, 2024 3:46:47 PM CET Nate Graham wrote: > > For the purpose of stimulating ideas and discussion in the meeting, let > me note down a few complementary routes that I could see us going down: > > # Moderation > have trusted experts filter out dangerous or broken content so it

Re: Plasm 6.1 Kickoff Meeting notes

On Wednesday, March 13, 2024 11:49:45 PM CET Nate Graham wrote: > On 3/11/24 10:31, Nicolas Fella wrote: > > ## 6.1 release planning > > > > Idea: Keep the megarelese? > > I think there's something to it. Releasing everything at once was good > for branding and user perception, and it seems for

Stale MRs

Hello, Friendly reminder that the following repository will give you a list of stalled merge requests without review and is updated every week, https://invent.kde.org/teams/gardening/gitlab/-/issues It would be nice if some more devs would subscribe to this repo and try to unblock some of the

Re: KDE Gear features list

On Monday, November 27, 2023 10:49:04???PM CET Carl Schwan wrote: > Hello, > > I started working on the announcement for the the megarelease. For Plasma, > Nate collected all the new user facing changes here: > https://community.kde.org/Plasma/Plasma_6#User-facing_changes > &g

Re: Unified internal communications channel

On Thursday, December 7, 2023 4:15:36?PM CET Nate Graham wrote: > Hello everyone, > > There have been a couple instances of drama this week caused by > decisions being made without some of the relevant stakeholders knowing > about them. In all cases, the decisions were announced, but either not >

Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

On Sunday, November 5, 2023 6:01:38 PM CET Nate Graham wrote: > On 11/5/23 07:42, Kevin Ottens wrote: > > I was clumsily advocating for this Akademy 2021 or 2022 (can't remember > > which). > > > > This way it's clearer to application authors when they tie themselves to a > > given workspace or

Re: Latte Dock Farewell

Someone is trying to step up. See https://invent.kde.org/plasma/latte-dock/-/merge_requests/46/ We probably should try to support them, instead of shutting down the project. Cheers, Carl On Fri, Oct 13, 2023, at 9:01 AM,

Re: semicolons and the policy that was none

Le mercredi 10 août 2022 à 3:57 PM, Harald Sitter a écrit : > Aloha, > > Someone recently dug up this page from 2012 > > https://community.kde.org/Plasma/QMLStyle#JS_Code_Blocks > > First I'd like to point out that this page isn't a policy page, if it > was meant to be then it needs to be

Re: Can we remove or quiet down the commit bot in the chatrooms

Le mercredi, mai 19, 2021 8:37 PM, Nate Graham a écrit : > I find it rather difficult to use #plasma for chats and discussions > because of the near-constant spam from the commit announcement bot. > > It's not that it's useless to have commits announced, but when it > happens in a room where

Re: 5.22 Soft Freeze

Le jeudi, avril 29, 2021 1:10 PM, David Edmundson a écrit : > At the end of the day is the soft freeze for Plasma 5.22, with the > beta out on the 13th of May. > > After this point we should avoid any huge refactors and big features > until we split the branch. > > Small features and changes

Re: qqc2-breeze-style

Le mardi, avril 13, 2021 1:10 PM, Arjen Hiemstra a écrit : > On Monday, 12 April 2021 23:26:18 CEST Carl Schwan wrote: > > > Le lundi, avril 12, 2021 10:20 PM, Nate Graham n...@kde.org a écrit : > > > > > [explicitly CCing Noah] > > > > And I still ha

Re: qqc2-breeze-style

Le lundi, avril 12, 2021 10:20 PM, Nate Graham a écrit : > [explicitly CCing Noah] > > On 3/10/21 8:52 AM, Marco Martin wrote: > > > On Wed, Mar 10, 2021 at 4:09 PM Nate Graham n...@kde.org wrote: > > > > > People go off an do their own thing in an un-coordinated manner when > > > there is a

Re: Plasma 5.22 Kickoff Notes

e, the sizing of every elements, animations, transition, gradiant, background image, positioning, shadows, ... And those are non trivial thing to solve in both QML and QtWidgets world and more importantly making each control use this heavy weight QML components probably won't be cheap in term of performa

Re: releaseme license clarifications

I'm fine with it Original Message On 24 Feb 2021, 1:29 PM, Harald Sitter wrote: > Yo! If you are in the CC list please respond whether you are ok with the > licenses or not. I'm in the process of moving releaseme to reuse compliance > and need y'all to approve the following

Re: Synchronized release schedule for Plasma

Le jeudi, janvier 7, 2021 12:28 PM, niccolo a écrit : > Hi, > sorry to bring this up again, but I would be in favor of a switching to 2 > releases every year. I'd like to add some reasons to do that on the > promotional side: > 1) In Promo, we are quite stepping up our game in the quality of

Re: plasma-systemmonitor in kdereview

Le jeudi, octobre 1, 2020 11:36 AM, Arjen Hiemstra a écrit  : > Hello, > > I'd hereby like to announce that plasma-systemmonitor is in kdereview. It can > be found at https://invent.kde.org/plasma/plasma-systemmonitor . > > plasma-systemmonitor is a new system monitor UI built with Kirigami. It

D28305: Systemd Startup

ognarb added a comment. I guess this was merged here: https://invent.kde.org/plasma/plasma-workspace/-/commit/256b6e1738d907cd2e4aaa0e89f113f096473258. So we can close this MR :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28305 To: davidedmundson Cc:

Licensing clarification in Plasma Vault

Hello Kees vd Broek, you contributed to the file kded/ui/backendchooserwidget.ui in the plasma vault project, we are currently converting all the license statements and unfortunately, it seems that this file didn't contain a license statement. The file can be found here:

D29466: [applets/appmenu] Add search to global application menu

ognarb added a comment. What is the state of this MR? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29466 To: cblack, #plasma, #vdg Cc: ognarb, Leon0402, trmdi, nicolasfella, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D25375: Start of the accessibility KCM

ognarb added a comment. Ping? it would be sad to see this good work lost :( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25375 To: tcanabrava, ngraham, ervin Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, LeGast00n,

D28686: [Battery Monitor] Choose better wording

ognarb accepted this revision. ognarb added a comment. Change makes sense to me, IIRC Kai doesn't have much time for KDE anymore REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28686 To: shubham, broulik, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel,

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

ognarb added a comment. I rebased this merge request on top of master and moved it to gitlab. https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/37 I see a major problem to move forward with this patch, not all the files have a license header and as such can't be merged.

D29625: Add global shortcut

ognarb added a comment. I think khotkeys is deprecated: https://phabricator.kde.org/T2050 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D29625 To: guoyunhe, #plasma Cc: ognarb, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29394: Add photographic user avatars

ognarb added a comment. CC-0 or any license compatible with CC-BY-SA-4.0 are fine. The Unsplash license is non-free too: "This license does not include the right to compile photos from Unsplash to replicate a similar or competing service. ". REPOSITORY R128 User Manager BRANCH

D29394: Add photographic user avatars

ognarb added a comment. Photo using the Unsplash licence can't be included in our repositories. The license is not consired open source :( REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: ognarb, plasma-devel, Orage,

D29203: kirigami.pri: Add missing includes

ognarb accepted this revision. ognarb added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203 To: patrickelectric, apol, mart, cblack, ognarb Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D28806: Provide light icon for dark mode via theme_icons

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. For reference this is the bug report in firefox for adding js scripting: https://bugzilla.mozilla.org/show_bug.cgi?id=1416871 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D28575: Make headings of systray and applet merge

ognarb added a comment. > I'd like to solve that by removing the sidebar and adding a back button, but that would be for another patch in the future. -1 from me to remove the sidebar. I really liked how the sidebar looked in the final mockup in T10470

D28211: [applets/systemtray] Make Pin button a bit larger

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. +1 for using standard size instead of using an hardcoded size. REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D27653: Fix ActionToolBar/PrivateActionToolButton in combination with QQC2 Action

ognarb added inline comments. INLINE COMMENTS > ActionToolBarLayoutDetails.qml:126 > + > +if (modelData.hasOwnProperty("displayHint") && > + > modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) { I think this can be simplified to

D27265: Use Kirigami.PasswordField instead of plain text field

This revision was automatically updated to reflect the committed changes. Closed by commit R116:5fbc994c959a: Use Kirigami.PasswordField instead of plain text field (authored by ognarb). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27265: Use Kirigami.PasswordField instead of plain text field

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. ognarb requested review of this revision. REVISION SUMMARY Allow showing the plain text password when typing (optional) TEST PLAN :( REPOSITORY R116

D27011: Update plasma startup sequence README

ognarb added a comment. I think I found some small typos INLINE COMMENTS > README:25 > +which may be 0, 1 or 2 (the default). Kded phase 0 means the module is > +always loaded by kded, even outside of KDE session. It should used only > +by kded modules which must be always running. Kded

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

ognarb added a comment. Thanks for the review :) I will create a follow up patch with the ComboBox port when I figure that is going wrong with my desktop theme. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg, #plasma, davidedmundson Cc:

D25778: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2

This revision was automatically updated to reflect the committed changes. Closed by commit R118:3e0877c9c99d: refactor(lookandfeelexplorer): Port almost entire look and feel explorer to QQC2 (authored by ognarb). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb updated this revision to Diff 71733. ognarb marked 2 inline comments as done. ognarb added a comment. - fix naming REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25778?vs=71732=71733 BRANCH arcpatch-D25778 REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb added inline comments. INLINE COMMENTS > guoyunhe wrote in MetadataEditor.qml:108 > This need to be changed to `QQC2.ComboBox` I tried but I get Type QQC2.ComboBox unavailable 60: StylePrivate.PropertyWriter is not a type REPOSITORY R118 Plasma SDK REVISION DETAIL

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb updated this revision to Diff 71732. ognarb marked 2 inline comments as done. ognarb added a comment. - Use same button width as for the text field - Fix dialog not closing - Improve margin REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D24238: Port the pager applet away from QtWidgets

ognarb added a comment. This patch maybe created this bug: https://bugs.kde.org/show_bug.cgi?id=414849 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb added inline comments. INLINE COMMENTS > main.qml:46 > titleIcon: "preferences-desktop-theme" > +modal: true; > +collapsible: false; This sadly didn't work :( REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D25778 To: ognarb, #vdg,

D25778: refactor(lookandfeelexplorer): Port mostly to QQC2

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY I wasn't able to convert the conbox box :( I'm getting a strange error TEST PLAN Screenshot comming REPOSITORY R118 Plasma

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

This revision was automatically updated to reflect the committed changes. Closed by commit R118:49a2d8a4988a: Rename Look and Feel Explorer to Plasma Global Theme Explorer (authored by ognarb). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. TEST PLAN not tested REPOSITORY R118 Plasma SDK BRANCH master REVISION DETAIL https://phabricator.kde.org/D25692 AFFECTED FILES

D25375: Start of the accessibility KCM

ognarb added a comment. :) INLINE COMMENTS > CMakeLists.txt:2 > # KI18N Translation Domain for this library > +# KI18N Translation Domain for this library > add_definitions(-DTRANSLATION_DOMAIN=\"kcmaccess\") Duplicate line REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25392: [414174] - Panel background transition color bug

This revision was automatically updated to reflect the committed changes. Closed by commit R878:a21f46d85ff8: [414174] - Panel background transition color bug (authored by acemond, committed by ognarb). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE

D25392: [414174] - Panel background transition color bug

ognarb added a comment. @acemond you need to wait for @mvourlakos to commit the change. You should also provide your authorship information name and email address. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D25392 To: acemond, mvourlakos Cc: ognarb,

D25104: Fix PageRow globalToolBar documentation

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R169 Kirigami BRANCH fix-pagerow-doc (branched from master) REVISION DETAIL https://phabricator.kde.org/D25104 To: dkardarakos, ognarb Cc: ognarb, plasma-devel,

D24720: [applets/systemtray] Rewrite popups with layouts

ognarb added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:48 > +//Menu mode > +if (!activeApplet && hiddenItemsView.visible && > LayoutMirroring.enabled === false) { > +return units.smallSpacing; !LayoutMirroring.enabled

Re: Discover and KSysGuard in kde.org/applications?

Since neither Discover nor KSysguard has a website, having both applications in kde.org/applications would allow both applications to still have a 'web presence'. This can be useful if we want to link to Discover from somewhere else. And kde.org/applications is not only display applications

D24766: Revert change to make the notification persistent

ognarb added a comment. +1  REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24766 To: ngraham, apol, broulik, #discover_software_store Cc: ognarb, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D24732: Rewrite AppChooser dialog

ognarb added a comment. I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb,

D24499: Do not warn about LayoutDirection in SearchField

ognarb accepted this revision. ognarb added a comment. Thanks REPOSITORY R169 Kirigami BRANCH searchfield_nowarning REVISION DETAIL https://phabricator.kde.org/D24499 To: ahiemstra, #kirigami, broulik, ognarb Cc: ognarb, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D24192: WIP: Active page follow the focus

ognarb added a subscriber: mart. ognarb added inline comments. INLINE COMMENTS > PageRow.qml:172 > +print("focus not current item"); > +root.removePage(columnView.currentItem); > +print("pop"); @mart removePage doesn't work well, how can I change the current

D24192: WIP: Active page follow the focus

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This doesn't work well yet. - Need a long time (2-4 seconde) before the page is updated - Loss focus after changing page

D24165: Add SettingsUtil utility class

ognarb added a comment. +1 but I couldn't test it (changed my distro recently and can't get pbi to work yet). The js class is available in firefox since Firefox 45 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#Browser_compatibility so it should work in

D23712: [Cuttlefish] Overhaul program, use Kirigami

ognarb accepted this revision. ognarb added a comment. It's a huge improvement. You shouldn't forget to add your copyright to some files. REPOSITORY R118 Plasma SDK BRANCH modernization (branched from master) REVISION DETAIL https://phabricator.kde.org/D23712 To: cblack, #vdg,

D24011: Provide a telemetrics kcm module for Plasma

ognarb added inline comments. INLINE COMMENTS > main.qml:46 > +wrapMode: Text.WordWrap > +text: i18n("We make Plasma for you. You can help us improve it > by contributing information on how you use it. This allows us to make > sure we focus on things that matter to you.

D23151: Implement Web Share API through Purpose

ognarb added a comment. I will try to find time to test it today INLINE COMMENTS > content-script.js:24 > +return '--4xxx-yxxx-'.replace(/[xy]/g, > function(c) { > +var r = Math.random()*16|0, v = c == 'x' ? r : (r&0x3|0x8); > +return

D23975: Improve keyboard navigation

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by ognarb). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23975?vs=66154=66158 REVISION DETAIL

D23975: Improve keyboard navigation

ognarb added a comment. Thanks, I will try to send a kirigami patch, if I don't send anything before the next weekend consider that I forgot ;p REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23975 To: ognarb, #plasma,

D23975: Improve keyboard navigation

ognarb added a comment. Looking at the behavior more in details. The 'bug' with a smaller screen should be fixed in kirigami instead. The focus is correct and I can move back the main category and select anoter subcategory. The problem is that Kirigami pageStack should display the page

D23975: Improve keyboard navigation

ognarb planned changes to this revision. ognarb added a comment. In D23975#532059 , @ngraham wrote: > Definitely better than before! > > One use case still doesn't work though: Returning to the first column of the sidebar when you're in the

D23975: Improve keyboard navigation

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Since the tab view is dead, we should improve the keyboard navigation of the sidebar view TEST PLAN Played a bit with it, it

Re: New Plasma Desktop website

for the first screenshot so that I don't overpromote the Ice Cold wallpaper and this also makes the page less version specific (less work after each release). Cheers Carl ‐‐‐ Original Message ‐‐‐ On Saturday, September 14, 2019 3:10 PM, Christoph Feck wrote: > On 09/14/19 14:38, C

New Plasma Desktop website

parts missing (p-b-i and privacy) and some possible improvement that I would like to add later. Can I get approval from the Plasma team to land the current state? Cheers, Carl Schwan publickey - carl@carlschwan.eu - 0x7F564CB5.asc Description: application/pgp-keys signature.asc Description

D23799: Get rid of khtml usage (kill classic mode)

ognarb added a comment. +1 is there a task somewhere where we can track all the KDE projects still using khtml? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel, #plasma Cc: ognarb, ngraham, #plasma, GB_2, sitter,

D23714: Manipulate Document prototype for createElement

ognarb accepted this revision. ognarb added a comment. Tested in a modern browser and it still works REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23714 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23651: WIP: Add support for a theming in Kicker Dashboard

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY - Replace hardcoded color with Kirigami.Theme.* - Replace search bar with Kirigami.Search I tried to use PlasmaCore.Theme but

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R856:a14c58b1d5f2: Fix mpris plugin in Firefox when Content-Security-Policy is enabled (authored by ognarb). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

ognarb accepted this revision. ognarb added a comment. Much better now thanks :) REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack, #breeze, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel,

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

ognarb added a comment. Could it be possible to remove most of the code duplication between _window_decorations.scss and _chromium.scss? REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack,

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Credit to kbroulik, he did all the work. TEST PLAN Tested in firefox, chromium with Nextclould Music and Youtube REPOSITORY

D23318: Add dark theme in the extension popup

This revision was automatically updated to reflect the committed changes. Closed by commit R856:02ea1012348d: Add dark theme in the extension popup (authored by ognarb). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23318?vs=64209=64210

D23318: Add dark theme in the extension popup

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. TEST PLAN Tested in firefox REPOSITORY R856 Plasma Browser Integration BRANCH darkTheme (branched from master) REVISION DETAIL

D23126: Add browser action for status reporting

ognarb accepted this revision. ognarb added a comment. This revision is now accepted and ready to land. For the png problem it was because I had a navbar with the same color. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23126 To: broulik,

D23126: Add browser action for status reporting

ognarb added a comment. Tested in Firefox: The PNG is not displayed. I'm not a fan of using string as enum value (portStatus). INLINE COMMENTS > action_popup.css:22 > + > +section { > +padding: 1em; Not used > ognarb wrote in action_popup.css:32 > Why it is empty? Or maybe

D23126: Add browser action for status reporting

ognarb added a reviewer: ognarb. ognarb added a comment. I will provide more feedback tomorrow, when I have more time. INLINE COMMENTS > action_popup.css:32 > + > +main { > + Why it is empty? > action_popup.css:45 > +} > +.message.error { > + same REPOSITORY R856 Plasma Browser

D23049: Add Kirigami ListSectionHeader component

ognarb added a comment. It's a new version so probably 2.9 everywhere REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart Cc: ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, domson, dkardarakos, apol,

D23049: Add Kirigami ListSectionHeader component

ognarb added a comment. Something is probably wrong with the version numbers. INLINE COMMENTS > kirigamiplugin.cpp:131 > qmlRegisterType(componentUrl(QStringLiteral("BasicListItem.qml")), uri, > 2, 0, "BasicListItem"); > +

D22817: Port KRunner to Plasma Components 3

ognarb added a comment. To add the clear button, maybe you can use Kirigami.SearchField instead? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22817 To: apol, #plasma, broulik Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22543: [LNF KCM] make it possible to close the preview

ognarb added a comment. I had the same problem today with qt 5.13.0, framework 5.59 and plasma 5.16.3. I switched to a tty to close system settings :/. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22543 To: ngraham, #plasma, apol Cc: ognarb, broulik,

D22426: Add Unsplash POTD Provider

ognarb added a comment. In D22426#494745 , @guoyunhe wrote: > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. > > I do think it is good to show photographers' credits. But that will require

D21435: [ActionTextField] Make QML tooltip consistent

ognarb added a reviewer: Kirigami. ognarb added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D21435 To: GB_2, #plasma, #vdg, #kirigami Cc: ognarb, #vdg, plasma-devel, #plasma, domson, dkardarakos, apol, davidedmundson, mart, hein

D19454: Fix errors in kirigami example files

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8dc09a000125: Fix errors in kirigami example files (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19454?vs=54124=54354#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST

D19502: Add a SearchField and PasswordField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:546f82f9e645: Add a SearchField and PasswordField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54119=54353 REVISION

D19454: Fix errors in kirigami example files

ognarb updated this revision to Diff 54124. ognarb added a comment. Remove goBack funtion, and I repported the bug https://bugs.kde.org/show_bug.cgi?id=405571 :) REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19454?vs=52927=54124 BRANCH

D19502: Add a SearchField and PasswordField component

ognarb updated this revision to Diff 54119. ognarb added a comment. Rebase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=54117=54119 BRANCH dev REVISION DETAIL https://phabricator.kde.org/D19502 AFFECTED FILES

D19502: Add a SearchField and PasswordField component

ognarb updated this revision to Diff 54117. ognarb added a comment. - Use qsTr instead of i18n - Kirigami version 2.7 -> 2.8 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19502?vs=53106=54117 BRANCH dev REVISION DETAIL

D19662: Fix Qmake based build

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f7100e2c9ca6: Fix Qmake based build (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19662?vs=53621=53664 REVISION DETAIL

D19662: Fix Qmake based build

ognarb created this revision. ognarb added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This patch should resolve

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

This revision was automatically updated to reflect the committed changes. Closed by commit R119:245677bfb31a: Update documentation for kcontrol desktop theme (now plasma theme) (authored by ognarb). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

ognarb updated this revision to Diff 53465. ognarb marked 4 inline comments as done. ognarb added a comment. Fix typos and use entites Thanks yuri :D REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19618?vs=53463=53465 BRANCH master REVISION

D19618: Update documentation for kcontrol desktop theme (now plasma theme)

ognarb created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Some part were copied from kcontrol icons. Need proofreading REPOSITORY R119 Plasma Desktop BRANCH

D19454: Fix errors in kirigami example files

ognarb added inline comments. INLINE COMMENTS > apol wrote in AbstractApplicationWindow.qml:105 > Why's that? Without I get the errror: TypeError: Property 'goBack' of object QQuickStackView_QML_91(0x55ea59443ee0) is not a function REPOSITORY R169 Kirigami REVISION DETAIL

D19502: Add a SearchField and PasswordField component

ognarb added inline comments. INLINE COMMENTS > broulik wrote in SearchField.qml:44 > I think this is fine but may need a translation domain > `i18nd("whatever_domain_kirigami_uses", "Search...")` Are you sure? It would mean that Kirigami should then depends on ki18n. And them Kirigami

D19315: Use ActionTextField to implement the searchField in system settings

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e80cbf128f77: Use ActionTextField to implement the searchField in system settings (authored by ognarb). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D19502: Add a SearchField and PasswordField component

ognarb updated this revision to Diff 53106. ognarb marked 8 inline comments as done. ognarb edited the summary of this revision. ognarb added a comment. - Fix typos in doc - Remove edi-clear button in password field REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D19502: Add a SearchField and PasswordField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Provide a small abstraction over ActionTextField to implement consistent standard special text field **Warning:** I include a

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb added a comment. In D19301#423523 , @ngraham wrote: > Also it would be nice to port Discover itself to use this. I'm not sure, I understand your comment. What do you mean with this? Discover already implement the

D19454: WIP: Fix errors in kirigami example files

ognarb updated this revision to Diff 52927. ognarb added a comment. More fix REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19454?vs=52920=52927 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19454 AFFECTED FILES

  1   2   >