D27914: [Kilpper] Port QRegExp to QRegularExpression

ahmadsamir added inline comments. INLINE COMMENTS > apol wrote in urlgrabber.h:185 > I think it's a silly way to do the port but okay, probably works and we get > to move on. What is silly about it? The original code in ClipCommandProcess used: const QStringList matches =

D28360: cmake: make xsettingsd check an option

kossebau added a comment. In D28360#636615 , @eszlari wrote: > In D28360#636610 , @kossebau wrote: > > > Can you tell which packagers missed that this is a required runtime dependency? > > >

D28360: cmake: make xsettingsd check an option

eszlari added a comment. In D28360#636448 , @gikari wrote: > Again, why not just make XSettingsd required? It's simpler. To quote yourself: "We cannot add mandatory dependencies to the stable branches/releases." I think it's

D28360: cmake: make xsettingsd check an option

kossebau added a comment. See how it is done across KDE repos here: https://lxr.kde.org/search?_filestring=CMakeLists.txt&_string=TYPE+RUNTIME&_casesensitive=1 There should be no reason the same works here as well. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28354: [applets/digital-clock] Fix calendar events not being shown at first

epopov updated this revision to Diff 78715. epopov added a comment. Put the `dateEquals` function outside the `onAgendaUpdated` handler, so it can be used elsewhere. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28354?vs=78694=78715 REVISION

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added inline comments. INLINE COMMENTS > backend.cpp:236-239 > +auto *job = new KIO::ApplicationLauncherJob(service); > +auto *delegate = new KNotificationJobUiDelegate; > +delegate->setAutoErrorHandlingEnabled(true); > +

D28360: cmake: make xsettingsd check an option

gikari added a comment. In D28360#636610 , @kossebau wrote: > Edit: The proposed solution to make it simply required only forces packagers to add that and all what it pulls in as build-time dependency to their package creation, even if not

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. In D28286#636668 , @dfaure wrote: > Benefit: available everywhere, unlike a local wrapper function. I think wrapper function in KIO :) REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Looks good to me, but please wait until D28367 and D28268 land, since they change the API of

D28347: Port services and shell runner away from KRun

dfaure added a comment. Looks good to me, but please wait until D28367 and D28268 land, since they change the API of ApplicationLauncherJob for KServiceAction. I do not think

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. Alternatively I'm wondering if we should add constructors to the delegates that take some AutoErrorHandlingEnabled enum value, then it can become something like auto *job = new KIO::ApplicationLauncherJob(service); job->setUiDelegate(new

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. I don't think we want to have wrapper functions in KIO for all combinations of jobs and delegates. There are many of each. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni,

D28360: cmake: make xsettingsd check an option

rikmills added a comment. In D28360#636615 , @eszlari wrote: > https://packages.ubuntu.com/focal/kde-config-gtk-style > https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec >

D27595: Watch for language change events, and forward those to the QML engine

rikmills added a comment. In D27595#636640 , @vkrause wrote: > I haven't seen a backtrace for this, but from what I understood from the chat backlog this is triggering a QML bug (?) due to the re-evaluation of qsTr() with 5.12, rather than

D28192: WIP: Refactor dictionary runner

alex added inline comments. INLINE COMMENTS > sitter wrote in dictionaryrunner.cpp:90 > You could simply use the lastPartOfSpeech I would guess. From what I've seen > and what Kai tells me you really only need to set setData if you want to > implement actions (`::actionsForMatch`) and need to

D28360: cmake: make xsettingsd check an option

kossebau added a comment. Sadly Cmake does not have separate "RUNTIME-OPTIONAL" & "RUNTIME-REQUIRED" so far. Previously that was solved by noting the required vs. optional in the purpose text, so the info still arrived with packagers. Just "REQUIRED" means, it is required for the build.

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. In D28366#636969 , @broulik wrote: > Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained ...That, or make it configurable with

D28389: Add support for logging categories

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:23 > +Critical > +) > + Any idea how to reuse the declaration from the top-directory CMake file? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28389 To: romangg, #plasma Cc: plasma-devel,

D27595: Watch for language change events, and forward those to the QML engine

vkrause added subscribers: broulik, davidedmundson. vkrause added a comment. In D27595#636543 , @rikmills wrote: > git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 I haven't seen a

D28286: [Task Manager] Port backend to ApplicationLauncherJob

anthonyfieroni added a comment. Why not? Furthermore they can be easy fixable. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

rwbarat added a comment. Hey @ngraham @davidedmundson @broulik I was wondering if there are any updates on this patch, as closing when losing focus is a frequent issue for me with KRunner a bunch of other people too according to the Bugzilla issue page for this

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 78758. pereira.alex added a comment. Deal with upgrading configuration Added code to deal with old configuration: - created a check to see if the user is using list mode view and doesn't have listViewIconSize set. If it doesnt, then use

D28081: Populate Greeter process exit stderr

This revision was automatically updated to reflect the committed changes. Closed by commit R133:c893e333b060: Populate Greeter process exit stderr (authored by romangg). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28081?vs=77784=78759 REVISION

D28082: Take file descriptor only instead of whole KWayland Display

This revision was automatically updated to reflect the committed changes. Closed by commit R133:decf7c9d4f43: Take file descriptor only instead of whole KWayland Display (authored by romangg). Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY R133

D28366: [krunner] Don't set the position three times in a row

pereira.alex added a comment. I don't want to be *that guy* but this is one of the things I do in every kde desktop I have. User facing configurable UI would be great ! That said, although I love the free floating version, I wouldn't run to xxx desktop if it was removed ! :) REPOSITORY

D28389: Add support for logging categories

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds category logging to the KScreenLocker daemon/library and the greeter. Replaces all

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex added a comment. Also forgot to mention: Tested with removing the new values from .config/plasma-org.kde.plasma.desktop-appletsrc : - If user doesn't go to properties and changes size or view mode, the old/current value is respected and used ( which might be a problem,

D28386: fix(kded): watch config also when known config is applied

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY When a known config is applied the doApplyConfig with the Config wrapper override is called. In

D28383: Add PageRouter component

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. This needs way more description and explanation of the problem it's trying to solve. REPOSITORY R169 Kirigami REVISION DETAIL

D28383: Add PageRouter component

cblack updated this revision to Diff 78747. cblack added a comment. Get arc to deal with multiple commits properly REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78746=78747 BRANCH cblack/pagerouter REVISION DETAIL

D28369: [runners/recentdocuments] disable executables or .desktop files

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28369 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 28 Mar 2020 19:45:46 + Build duration: 49 sec and counting CONSOLE OUTPUT [...truncated 348

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license texts as required by REUSE specification. REPOSITORY

D28383: Add PageRouter component

cblack created this revision. cblack added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY PageRouter is a component that manages named routes of pages. REPOSITORY R169 Kirigami

D28366: [krunner] Don't set the position three times in a row

broulik added a comment. Can we just nuke this option? I know people on the internetz™ are quite vocal about it but effectively it's just broken and unmaintained REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson,

D28286: [Task Manager] Port backend to ApplicationLauncherJob

dfaure added a comment. Why not -> because it just doesn't scale. 30 jobs * 4 delegates = 120 wrapper methods... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28286 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n,

D28385: Remove unused file

apol updated this revision to Diff 78753. apol added a comment. was only meant to include this REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28385?vs=78752=78753 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28385 AFFECTED

D28383: Add PageRouter component

cblack updated this revision to Diff 78746. cblack added a comment. Add documentation comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28383?vs=78744=78746 BRANCH cblack/pagerouter REVISION DETAIL https://phabricator.kde.org/D28383 AFFECTED

D28385: Remove unused file

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Still included dcop, hadn't been compiled in years I presume. TEST PLAN All good and normal REPOSITORY

D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28354 To: epopov, ngraham, #plasma, vkrause Cc: plasma-devel, Orage, LeGast00n,

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78754. cblack added a comment. Optimize toolbar rect function REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78667=78754 BRANCH cblack/toolsarea REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.14 - Build # 16 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.14/16/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 28 Mar 2020 19:45:46 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT [...truncated

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 78755. pereira.alex added a comment. Use single slider and sync values Removed duplicated slider, to only use one slider that uses and updates the correct value. Added an event when changing viewmode grid or list, to load the slider with

D28366: [krunner] Don't set the position three times in a row

ngraham added a comment. Yeah, it's not like the KRunner KCM is currently overflowing with options and it would get lost. :) REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28366 To: davidedmundson, #plasma, apol Cc: pereira.alex, ngraham,

D27669: [kstyle] Tools area

ndavis added a comment. I've discovered another bug. When you move a window by dragging on an empty area, the hover effect on toolbar buttons stops working. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D28386: fix(kded): watch config also when known config is applied

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Makes sense REPOSITORY R104 KScreen BRANCH control-watching-fix REVISION DETAIL https://phabricator.kde.org/D28386 To: romangg, #plasma, bshah Cc: bshah, plasma-devel, Orage,

D27669: [kstyle] Tools area

ngraham added a comment. I just found an interesting bug. KDE apps with menubars show a mis-colored area to the right of the menubar when maximized: F8203808: vokoscreenNG-2020-03-28_22-03-54.webm REPOSITORY R31 Breeze REVISION DETAIL