Triode;377608 Wrote:
OK so we need something new then - we can't ask plugins to use this when
it is only suitable for streaming related data at present. We could
easliy move all core plugins to $client-master-pluginData. Otherwise
we need a new accessor as per Peter.
Bug filed, possible
andyg;377527 Wrote:
I'm not so sure, the reason the master stores the state is so that
synced players always work correctly regardless of which player is
being controlled. If you remove this most all core plugins will not
work properly when synced.
When commiting the pluginData change,
peterw;377558 Wrote:
Better might be to refactor Client.pm so that pluginData() retains the
current behavior but is essentially $this-clientPluginData
I meant $this-master()-clientPluginData -- oops.
--
peterw
http://www.tux.org/~peterw/
free plugins: http://www.tux.org/~peterw/#slim
andyg;377527 Wrote:
I'm not so sure, the reason the master stores the state is so that
synced players always work correctly regardless of which player is
being controlled. If you remove this most all core plugins will not
work properly when synced.
OK so we need something new then - we
Triode;377608 Wrote:
OK - I didn't see the output of this - you are happy with all of them?
I'll add them if you are happy. Will post an update with additional
ones.
Andy's review of the plugins was posted in this post:
http://forums.slimdevices.com/showthread.php?p=374703#post374703
--
erland;377614 Wrote:
Andy's review of the plugins was posted in this post:
http://forums.slimdevices.com/showthread.php?p=374703#post374703
Ops - I missed this. They are now in the 3rd part repo on svn - not
sure how long this will take to get to the SN server.
Andy - the next one to review
Triode;377637 Wrote:
Ops - I missed this. They are now in the 3rd part repo on svn - not
sure how long this will take to get to the SN server.
Andy - the next one to review is TrackStat if Erland thinks it is
appropriate.
It doesn't really matter to me, but don't think Andy liked its
andyg;374703 Wrote:
SaverSwitcher: Not OK, it has an external dependency on CGI.pm which is
not included with SC. Since only 2 functions are used anyway, and
CGI.pm is a memory hog, these should be handled another way. This
plugin also makes use of a large amount of global variables, and
Thanks for taking a look at that, Andy. I'd had that refactoring on my
list for a while (http://hickinbottom.demon.co.uk/lazysearch/ticket/70)
so I'll get around to that for the next version.
Stuart
andyg wrote:
LazySearch: OK, but I want to strongly recommend this plugin be
refactored to not
hickinbottoms;377396 Wrote:
Thanks for taking a look at that, Andy. I'd had that refactoring on my
list for a while
(http://hickinbottom.demon.co.uk/lazysearch/ticket/70)
so I'll get around to that for the next version.
andyg wrote:
LazySearch: OK, but I want to strongly recommend this
You're right, with a typical user with 1 or 2 players it won't be a big
deal. You should still think about removing the globals, as it makes
the code cleaner and easier to work with.
--
andyg
andyg's Profile:
I agree - pluginData should have the $client-master bit removed and
moved to any plugins which depend on it... If we want this to be the
generic mechanism for storing plugin state then it should not be sync
specific.
Andy - have you had a chance to look at any of those plugins yet?
--
Triode
Triode;377491 Wrote:
I agree - pluginData should have the $client-master bit removed and
moved to any plugins which depend on it... If we want this to be the
generic mechanism for storing plugin state then it should not be sync
specific.
I'm not so sure, the reason the master stores the
I suggest we add a link to the wiki page from the warning string. I'll
Triode - please feel free to do so for EN. Don't delete the other strings but
assign a bug to me so I can take care of it. Thanks a lot!
--
Michael
___
plugins mailing list
Plugins not already suggested:
Magnatune
My Radio Stations
Playlist Manager
Server Power Control
Spicefly SugarCube
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/lists/listinfo/plugins
Philip Meyer;374777 Wrote:
Plugins not already suggested:
Magnatune
My Radio Stations
Playlist Manager
Server Power Control
Spicefly SugarCube
Philip, I think the idea is that nominations should go into this
thread:
http://forums.slimdevices.com/showthread.php?t=56928
Andy (or someone
erland;374741 Wrote:
Andy/Triode:
If the plan is that most plugins should be available in the list by
default I don't think these strict rules is going to work.
Well I was aiming for many of the most popular them, but we need to
make sure they don't create support issues for Logitech -
- Is it possible for Extension downloader with user permission to feed
back statistics on which plugins have been installed. This would give
a better measure of popular and may help reassuring users of
integrity of the plugin.
- If all plugins are going to be listed - can there be a column for
- Is it possible for Extension downloader with user permission to feed
back statistics on which plugins have been installed.
As long as you warn the end user that it will be calling home only to report
such usage (and provide an option to turn off the messaging).
This would give a better measure
andyg;374657 Wrote:
I'll do a quick 'official' review of the following plugins for inclusion
in the recommended list:
BBCiPlayer, TitleSwitcher, LazySearch, SaverSwitcher
One other thing that should be mentioned that would cause a plugin to
not make the list: Plugins should not make
Philip, I think the idea is that nominations should go into this
thread:
http://forums.slimdevices.com/showthread.php?t=56928
Sorry, two threads with very similar titles. I read via email whilst away, saw
this email and posted a reply.
Andy (or someone else from Logitech), it's probably a good
bpa;374804 Wrote:
- Is it possible for Extension downloader with user permission to feed
back statistics on which plugins have been installed. This would give
a better measure of popular and may help reassuring users of
integrity of the plugin.
Anything is possible - assume this would
Sure I suppose we could track some simple stats like number of installs.
--
andyg
andyg's Profile: http://forums.slimdevices.com/member.php?userid=3292
View this thread:
erland;374126 Wrote:
I suspect we are going to need some kind of instructions regarding the
review process. What are we suppose to review, is it just that the
plugin doesn't include malicious code or are we talking about a general
review of the code to get an idea of the code quality ?
I
Triode;374651 Wrote:
The following are the most mentioned above which are already available
in repos and so are candidates for inclusion:
BBCiPlayer, TitleSwitcher, LazySearch, CustomBrowse, CustomScan,
SaverSwitcher
Please note that we need to review these with Logitech and be certain
I'll do a quick 'official' review of the following plugins for inclusion
in the recommended list:
BBCiPlayer, TitleSwitcher, LazySearch, SaverSwitcher
One other thing that should be mentioned that would cause a plugin to
not make the list: Plugins should not make synchronous HTTP requests,
or
andyg;374657 Wrote:
One other thing that should be mentioned that would cause a plugin to
not make the list: Plugins should not make synchronous HTTP requests,
or other external blocking requests.
If that's also the rule for configuration/administration pages, the
following of my plugins
Yeah, sorry but anything with non-async HTTP is out. The reason is I
don't want to see a bunch of bug reports like Player UI locks up when
saving plugin settings or Music drops out after a scan. Sync HTTP
is very bad for the server, at any time.
--
andyg
andyg;374657 Wrote:
I'll do a quick 'official' review of the following plugins for inclusion
in the recommended list:
BBCiPlayer, TitleSwitcher, LazySearch, SaverSwitcher
iPlayer: OK
TitleSwitcher: OK, but make sure the description mentions that
MusicInfoSCR is required.
LazySearch:
andyg;374675 Wrote:
TitleSwitcher: OK, but make sure the description mentions that
MusicInfoSCR is required.
Done
I've change the text in the repository xml so it includes both Music
Information Screen and MusicInfoSCR, earlier it just had
MusicInfoSCR.
The next version of the plugin
andyg;374675 Wrote:
Yeah, sorry but anything with non-async HTTP is out. The reason is I
don't want to see a bunch of bug reports like Player UI locks up when
saving plugin settings or Music drops out after a scan. Sync HTTP
is very bad for the server, at any time.
No problem, it doesn't
Triode;374009 Wrote:
To ensure we only include popular plugins which have been reviewed and
are known not to include malicious code, recommendations should be
supported by 3 senior forum members, one of which has reviewed the
code.
I suspect we are going to need some kind of
erland;374126 Wrote:
I suspect we are going to need some kind of instructions regarding the
review process. What are we suppose to review, is it just that the
plugin doesn't include malicious code or are we talking about a general
review of the code to get an idea of the code quality ?
@Peter/Erland
I tend to favor a single thread which is sticky for nomiating new
plugins as then we can immediately see if there is new actvity on it
and all users of the forum will know where to go to nominate
something.
I agree with Erland - want to keep this simiple as it will hopefully be
Extension Downloader in 7.3 simplifies installing plugins and hopefully
means plugins reach a wider audiance. By default SqueezeCenter lists
plugins from a Logitech hosted Recommended 3rd Party Plugin list. At
present this includes a very small list of plugins and I'd like to
propose a process
Sounds very good. The only change to the process that I would recommend
is that we use separate threads for each plugin, to make it easier both
for those who've used the nominated software to comment on the
nomination, and for Logitech to review all nominations. Attaching polls
might also be
Good idea, although I'd have difficulty recommending just one plugin :)
It's a question that crops up from time to time as people explore the
possibilities of their new SB, so a recommended list would be useful.
--
bonze
TranquilPC T2-WHS-A3 - SqueezeCenter Version: 7.4 - 24302
3 x wireless
Triode;372280 Wrote:
We then agree via this forum a subset of the most popular plugins (and
applets) for inclusion on the Recommended 3rd Party Plugin list. This
will take information from the authors own repositories on a regular
basis so that it is maintained up to date.
When will a
peterw;372309 Wrote:
Sounds very good. The only change to the process that I would recommend
is that we use separate threads for each plugin, to make it easier both
for those who've used the nominated software to comment on the
nomination, and for Logitech to review all nominations.
If we
erland;372317 Wrote:
When will a new version of an already recommended plugin be moved into
the Recommended 3rd party plugin list ?
Do we need some way for plugin authors to notify the maintainer of the
Recommended 3rd party plugin list that a new version is available ?
Or will the
What I propose is that all plugin authors are encouraged to maintain an
Extension Downloader compatible repository with the latest details of
their plugins and to add it to the wiki page:
http://wiki.slimdevices.com/index.php/SqueezeCenter_Repositories
I've just uploaded the latest versions of
ftp://ftp.gnupg.org/gcrypt/binary/sha1sum.exe
--
andyg
andyg's Profile: http://forums.slimdevices.com/member.php?userid=3292
View this thread: http://forums.slimdevices.com/showthread.php?t=56697
Philip Meyer;372338 Wrote:
Not sure I see why the checksum is there - surely the transport
protocols for downloading will verify the download was a success?
It's about security, see this post for more information:
http://forums.slimdevices.com/showthread.php?p=353037#post353037
--
Philip Meyer;372338 Wrote:
Not sure I see why the checksum is there - surely the transport
protocols for downloading will verify the download was a success?I don't know
that that's necessarily true. I don't see anything in
Slim::Networking::SimpleAsyncHTTP that would do this. The SHA1
44 matches
Mail list logo
