I went with option C. The change is committed and ready for review:
http://poe.svn.sourceforge.net/viewvc/poe?view=revrevision=2613
The commit message reads:
!!! This change breaks backward compatibility on a relatively unused
!!! feature. You are affected if you use ARG0 or ARG1 in a
!!!
2009/7/16 Chris 'BinGOs' Williams ch...@bingosnet.co.uk
Anyways, I see three options:
a). Make the functionality match the documentation;
b). Make the documentation match the functionality;
c). Do what dngor suggests and flatten ClientArgs, forget the socket
and document as such.
Euh, well, I was meaning option A.
But either A or C is good for me.
Option B is too awkward as a bad API would stay forever and would bite any
new Server::TCP user.
Le 21 juillet 2009 12:37, Olivier Mengué olivier.men...@gmail.com a écrit
:
2009/7/16 Chris 'BinGOs' Williams
On Wed, Jul 15, 2009 at 06:59:12PM -0800, Michael Fowler wrote:
On Wed, Jul 15, 2009 at 04:08:48AM -0400, Rocco Caputo wrote:
For starters, $_[ARG0] isn't guaranteed to contain anything in particular.
Well, it's guaranteed to contain whatever was passed as the 'args'
argument to the
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in the past... It would be nice if that was
possible to get at this (either via some available API which I just haven't
Nick Williams wrote:
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in the past... It would be nice if that was
possible to get at this (either via some available API
On Thu, Jul 16, 2009 at 12:59:09PM +0100, Ed W wrote:
Nick Williams wrote:
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in the past... It would be nice if that
Chris 'BinGOs' Williams wrote:
On Thu, Jul 16, 2009 at 12:59:09PM +0100, Ed W wrote:
Nick Williams wrote:
Regarding the passing of the socket into clientconnected - I've wished for
this in the past, in order to be able to modify TCP options on the socket,
which didn't seem possible in
On Jul 14, 2009, at 02:16, Michael Fowler wrote:
http://rt.cpan.org/Ticket/Display.html?id=47855
47855 requires a bit of discussion.
The problem is that the ClientConnected callback does not actually
receive a socket in ARG0. ARG0 has been spliced off in the
POE::Wheel::ReadWrite
On Wed, Jul 15, 2009 at 04:08:48AM -0400, Rocco Caputo wrote:
For starters, $_[ARG0] isn't guaranteed to contain anything in particular.
Well, it's guaranteed to contain whatever was passed as the 'args'
argument to the POE::Session constructor, right? When the session is
constructed, 'args' is
On (07/15 18:59), Michael Fowler wrote:
The code I have that actually needs it would benefit from the clarity of
having the socket passed as ARG0. Whether or not this breaks some
possible future change in something...
Perhaps I'm misreading... What I'm hearing is you should change this
for
On Wed, Jul 15, 2009 at 11:18:03PM -0400, sungo wrote:
Perhaps I'm misreading... What I'm hearing is you should change this
for me, regardless of whether it breaks other people's code. Is that an
accurate summary?
No. That was in response to expanding ClientArgs into ARG0..$#_. I'm
12 matches
Mail list logo
