Thanks for the improvements. I'm considering to discontinue the web pages with
third-party links. It was a nice idea but thinks are out of date in no time.
Wietse
___
Postfix-devel mailing list -- postfix-devel@postfix.org
To unsubscribe send an
Wietse Venema via Postfix-devel:
> And there is an even simpler workaround: an empty statement.
>
> case BSON_TYPE_ARRAY:
>/* Empty statement for pre-C23 Clang. */ ;
>const uint8_t *dataBuffer = NULL;
>/* other existing code */
> default
Herbert J. Skuhra via Postfix-devel:
> Hi Wietse,
>
> On Thu, 15 Feb 2024 15:18:20 +0100, Wietse Venema via Postfix-devel wrote:
> >
> > Herbert J. Skuhra via Postfix-devel:
> > > Hi,
> > >
> > > I am trying to build Postfix-3.9 (20240213) with Mo
Herbert J. Skuhra via Postfix-devel:
> Hi,
>
> I am trying to build Postfix-3.9 (20240213) with MongoDB support.
> Using clang the build fails:
>
> dict_mongodb.c:258:6: error: expected expression
> 258 | const uint8_t *dataBuffer = NULL;
> | ^
uint8_t is defined
Viktor Dukhovni via Postfix-devel:
> On Tue, Dec 26, 2023 at 04:16:18PM -0500, Viktor Dukhovni via Postfix-devel
> wrote:
>
> > If I enable "-Wall", I get the noisy warnings, and they can all be
> > disabled by adding:
> >
> > -Wno-missing-braces
> > -Wmaybe-uninitialized
> >
pgnd via Postfix-devel:
> grep missing-braces tmp.txt
> dict.c:627:38: warning: missing braces around initializer
> [-Wmissing-braces]
> dict_open.c:371:48: warning: missing braces around initializer
> [-Wmissing-braces]
You are building Postfix from source
I added RFC 4627 JSON string quoting for the %letter substitutions
in the (query_)filter MongoDB parameter. For this, I updated the
existing json quoting function that was implemented for "postqueue
-j", and made it a library function (src/util/quote_for_json.c).
This means you can't just copy
Sorry, I was confusing query and result processing. The first
needs to be secured. The second is garbage in, garbage out.
Wietse
___
Postfix-devel mailing list -- postfix-devel@postfix.org
To unsubscribe send an email to
I have been adding text to the mongodb_table that any text pasted
in the place of a %letter directive in result_format will be subject
to escaping, that is, Postfix inserts a backslash character before
a double quote or backslash character.
This ensures that the result will have the same
Hamid Maadani via Postfix-devel:
> Ok, compiled with driver 1.23.4 and have no more linking issues.
> I noticed if I have docker_va_filter parameter, it throws:
> Dec 06 22:32:49 mail postfix/proxymap[202]: fatal: bad string length 0 < 1:
> docker_va_query_filter =
>
> I think line 168 needs to
Hamid Maadani:
> > If the configuration says $$or, what code shall responsible for
> > treating this as $or? The Postfix cfg_parser does not do that, and
> > dict_mongodb.c will pass $$or into the mongo-c library.
>
> It does not? I might totally be me misunderstanding the documentation,
Only
Viktor Dukhovni via Postfix-devel:
> On Wed, Dec 06, 2023 at 08:10:22PM +, Hamid Maadani via Postfix-devel
> wrote:
>
> > now, in my case, I'm using a docker container, and am using parameters
> > in main.cf , a sample below:
> > docker_va_uri = $docker_dburi
> > docker_va_dbname =
Hamid Maadani via Postfix-devel:
> > What code is supposed to pay attention to '$' characters? The Postfix
> > client?
> > The MongoC library?
>
> In MQL, you have operators like "$or", or you can use the value of a field
> like "$field". These are instances that the person configuring postfix
Wietse Venema via Postfix-devel:
> Hamid Maadani via Postfix-devel:
> > > There was a missing update to the makedefs script (in the top-level
> > > directory). The updated code is at
> > > https://github.com/wietse-postfix/postfix-dukhovni/tree/mongodb
> >
Hamid Maadani via Postfix-devel:
> > There was a missing update to the makedefs script (in the top-level
> > directory). The updated code is at
> > https://github.com/wietse-postfix/postfix-dukhovni/tree/mongodb
>
> hmm.. I'm still getting the same type of error after a rebuild:
> Dec 06 17:32:07
Hamid Maadani via Postfix-devel:
> > Can you copy the dict_mongodb.* files into your environment and see
> > what I broke? They should still build with postfix-3.8-20220527.
>
> I just did, and they build fine. However, I get a linking error when trying
> to use the library:
> "Dec 05 23:45:05
Hamid Maadani via Postfix-devel:
> > Can you copy the dict_mongodb.* files into your environment and see
> > what I broke? They should still build with postfix-3.8-20220527.
>
> I just did, and they build fine. However, I get a linking error when trying
> to use the library:
> "Dec 05 23:45:05
Hamid Maadani via Postfix-devel:
> Yes sir. the last two commit in this branch should cover everything needed:
> https://github.com/21stcaveman/postfix/tree/mongodb
I forked Viktor's repo and added a version of your code and
documentation relative to the last Postfix 3.9 development release.
The
Hamid Maadani via Postfix-devel:
> Yes sir. the last two commit in this branch should cover everything needed:
> https://github.com/21stcaveman/postfix/tree/mongodb
Got it. The diffs of this code against postfix-3.8-20220527 will
apply easily to Postfix 3.9. I'm making first pass over the code
Viktor Dukhovni (27 Jun 2022):
> After that, Wietse and I will have to find some time for code
> review. This may take a bit of time, but should ideally happen in
> time for 3.8.0, and so naturally would need to be complete a few
> snapshots earlier.
hamid via Postfix-devel:
> Was doing some
Stephan Bosch via Postfix-devel:
> Looks like Postfix [...] somehow uses the data from the previous CONT auth
> service
> response as the reason.
Does this patch address the problem? It resets any previous Dovecot
auth service response before parsing the next Dovecot auth server
response.
Just to be 100% clear, is the problem that the error message is
wrong, or that the fail/pass status is wrong, or both, or something
else?
Wietse
___
Postfix-devel mailing list -- postfix-devel@postfix.org
To unsubscribe send an email to
Christophe Kalt via Postfix-devel:
> Hi folks,
>
> https://www.mail-archive.com/postfix-devel@postfix.org/msg00952.html has
> what looks like a nearly complete patch to support redis from 2.5 years
> ago. Wondering whether this didn't get included in a subsequent release
> because of the TODOs,
Wietse Venema via Postfix-devel:
> > There is an unnecessary double check of the "addr_list" pointer for null
>
> (twice). It does no harm, and a good compiler will remove that test.
> Generally, I don't worry about repeated tests like this. They make
> Postfix c
Tomas Korbar via Postfix-devel:
> Hi guys,
> I am continuing in this thread since it's related to the SRV resolution
> feature.
> During incorporation of this feature to Fedora and RHEL, static analysis
> found some
> minor flaws that I want to report and propose addressing them.
>
> There is an
Eray Aslan via Postfix-devel:
> Hi,
>
> With postfix-3.8-20230314:
>
> clang -fPIC -I. -I../../include -DHAS_PCRE=2 -DUSE_TLS -DHAS_LMDB -DNO_NIS
> -DNO_DB -DDEF_DB_TYPE=\"lmdb\" -DHAS_CDB -I/usr/include/cdb -DHAS_DEV_URANDOM
> -DSNAPSHOT -DDEF_SHLIB_DIR=\"/usr/lib64/postfix/\${mail_version}\"
The Postfix mailing list migration should be complete by now, except
for some old messages that may still be queued on some mail servers.
I'll manually handle any sub/unsubscribe requests that may still
arrive at the old address.
See below for the pre-migration announcement, with a summary
of
This week, the Postfix mailing lists will be migrated from Majordomo at
Cloud9.net to Mailman at Sys4.de. Thanks to Cloud9.net for hosting the
Postfix lists for 24 years, and thanks to Sys4 for being the new host.
This is the pre-migration announcement.
If you don't receive a post-migration
Wietse Venema:
> Tomas Korbar:
> > Hi guys,
> > It's great news that this is at least in non production release!
> > Thanks for all your work on this. Let me know if I can provide further
> > help.
>
> As you can see I overhauled the user interface a bit. Does th
Peter:
> On 15/02/23 06:00, Wietse Venema wrote:
> > Tomas Korbar:
> >> Hi guys,
> >> It's great news that this is at least in non production release!
> >> Thanks for all your work on this. Let me know if I can provide further
> >> help.
> >
Viktor Dukhovni:
> On Tue, Feb 14, 2023 at 01:25:39PM -0500, Wietse Venema wrote:
> > Viktor Dukhovni:
> > > On Tue, Feb 14, 2023 at 01:01:05PM -0500, Wietse Venema wrote:
> > >
> > > > > Fiction aside, the use-cases look reasonable to me. I haven't t
Peter:
> On 15/02/23 06:00, Wietse Venema wrote:
> > Tomas Korbar:
> >> Hi guys,
> >> It's great news that this is at least in non production release!
> >> Thanks for all your work on this. Let me know if I can provide further
> >> help.
> >
Viktor Dukhovni:
> On Tue, Feb 14, 2023 at 01:01:05PM -0500, Wietse Venema wrote:
>
> > > Fiction aside, the use-cases look reasonable to me. I haven't thought
> > > through of what downgrade (from e.g. DANE) are introduced by the various
> > > (optional) fallbac
Tomas Korbar:
> Hi guys,
> It's great news that this is at least in non production release!
> Thanks for all your work on this. Let me know if I can provide further
> help.
As you can see I overhauled the user interface a bit. Does the user
interface cover your use cases well? The documentation
Wietse Venema:
> Viktor Dukhovni:
> > On Mon, Feb 13, 2023 at 07:33:35PM -0500, Wietse Venema wrote:
> >
> > > There's a first implementation in postfix-3.8-20230213-nonprod.
> > > Docs: https://www.postfix.org/postconf.5.html#use_srv_lookup
> > > Code
Wietse Venema:
> Tomas Korbar:
> > Hi guys,
> > did you by any chance have the time to look at this?
>
> I've been working on the configuration (i.e. user interface) for
> this for the past days.
There's a first implementation in postfix-3.8-20230213-nonprod.
Docs:
Tomas Korbar:
> Hi guys,
> did you by any chance have the time to look at this?
I've been working on the configuration (i.e. user interface) for
this for the past days.
Wietse
Andreas Weigel:
> Hi,
>
> right before the thread's 4th anniversary ;)
>
> > Andreas Weigel:
> >> Hi everyone,
> >>
> >> I stumbled upon a very minor bug with regard to parsing the supported
> >> XFORWARD attributes from the EHLO reply in smtpd_proxy: the last
> >> attribute is never
e it appears in the
next stable release. I have been a bit short on time recently, and
like the rest of Postfix this has to be done right.
Wietse
> On Tue, Oct 11, 2022 at 5:58 PM Viktor Dukhovni wrote:
> >
> > On Tue, Oct 11, 2022 at 11:46:09AM -0400, Wietse Venema wrote:
&
Wietse Venema:
> Tomas Korbar:
> > Hi guys, any update on this?
>
> Microsoft autoconfiguration uses WKS for other services: submission,
Of cour that's SRV not WKS.
> smtp, not just smtps. Any suggestions for handling that in Postfix
> without hard coding all those
Tomas Korbar:
> Hi guys, any update on this?
Microsoft auticonfiguration uses WKS for other services: submission,
smtp, not just smtps. Any suggestions for handling that in Postfix
without hard coding all those names?
Wietse
> On Thu, Sep 8, 2022 at 3:53 PM Wietse Venema
with
> > a implementation that does not involve changes in
> > Postfix connection management code. smtp process was
> > the first place where I thought that this feature could be
> > implemented.
> >
> > On Tue, Aug 9, 2022 at 11:56 AM Wietse Venema wrote:
> >
Viktor Dukhovni:
> On Mon, Aug 08, 2022 at 05:06:22PM -0400, Viktor Dukhovni wrote:
>
> > > We're discussing support for an MUA-specific feature, not high-volime
> > > MTA-to-MTA support. Connection reuse is less important, as long as
> > > Postfix does not mix traffic with different
Viktor Dukhovni:
> On Mon, Aug 08, 2022 at 04:07:39PM -0400, Wietse Venema wrote:
> > Viktor Dukhovni:
> > > On Mon, Aug 08, 2022 at 03:03:07PM -0400, Wietse Venema wrote:
> > >
> > > > All we need is a small bit of code that transforms SRV lookup results
&
Viktor Dukhovni:
> On Mon, Aug 08, 2022 at 03:03:07PM -0400, Wietse Venema wrote:
>
> > All we need is a small bit of code that transforms SRV lookup results
> > into a list of [host]:port forms that the Postfix SMTP client already
> > understands.
>
> We have
Could this not better be done with a transport_maps plugin, for example
transport_maps = tcp:host:port
transport_maps = socketmap:inet:host:port:name
transport_maps = socketmap:unix:pathname:name
Just asking, because Postfix is primarily an MTA, MUA is not
core fucntionality, and
Raymond Li:
> Hello,
>
> Currently Postfix doesn't document that the nobody user runs piped
> commands by default. The following patch amends that.
That is the case when the aliases file is owned by root; Postfix
supports aliases and :include: files that are owned by other users
and chooses
Benny Pedersen:
> Wietse Venema skrev den 2022-07-17 16:07:
>
> > Curiously, a web search for 'ehlo ignorant' lands me on a discussion
> > about servers that violate RFCs in their handling of non-compliant
> > EHLO arguments.
> >
> > https://marc.info/?l=rfci-
Benny Pedersen:
> Wietse Venema skrev den 2022-07-14 17:06:
> > Apologies for the noise, but there are no good ways to found out
> > if the list is working.
>
> any possible to extend postscreen to include test of ehlo ignorants ?
Curiously, a web search for 'eh
It appears that Wietse Venema said:
> Apologies for the noise, but there are no good ways to found out
> if the list is working.
John Levine:
> That just means you've fixed The Last Bug.
New ones are already in the works. Just kidding. In the past 2-3
months I've been working on kee
Apologies for the noise, but there are no good ways to found out
if the list is working.
Wietse
ran...@skurelabs.com:
> Thanks for all your quick and timely responses. We have started using another
> java milter library which helps us quarantine and release mails.
> But the problem is using milter, we can quarantine the email, which goes to
> hold queue. To release that email, we have to
ran...@skurelabs.com:
> My bad, I don't why I did not receive any email in users group.
> Please allow me to use developers group. As mentioned by you in
> your earlier email, I don't think milter is quarantining the emails.
> Is there any milter example I can see to know how to quarantining
>
ed, but postfix keeps trying to deliver it , after some interval of
> time.
>
> 5) Can you find that QUEUE ID in output from the mailq command.
> Answer: no
>
> root@sprucexSrv02:/var/log# mailq
> Mail queue is empty
>
> If you need log for this mail transaction , i c
ran...@skurelabs.com:
> Hi Wietse,
> Yes, we are following the steps mentioned in your earlier emails.
> Let me again put forth the steps we are doing for quarantining emails
>
> * Using milter with command SMFI_QUARANTINE for quarantining emails
Can you answer ALL of the
ran...@skurelabs.com:
[ Charset windows-1252 converted... ]
> Hi Wietse,
> We are still stuck on quarantining the message. I have come
> across one of your post https://www.tek-tips.com/viewthread.cfm?qid=1618714
That is NOT me. That is someone who calls themselves "Noway2
Viktor Dukhovni:
> Also, your parsing of the search_keys is hand-rolled, but should be
> using mystrtok(3) to split the list on commas/whitespace, and
> split_nameval(3) to split "key = value" pairs on "=".
If the result may contain quoted strings, then we need a smarter
parser than wnat
Hamid Maadani:
> Hello,
>
> I have developed a MongoDB module for postfix. Given that
> mongo-c-driver has gone mainstream on most linux distributions, I
> personally think this would be a good addition to postfix, allowing
> users to use MongoDB as a backend database. I am currently using
> it
Viktor Dukhovni:
> Release all quarantined mail from "harml...@example.net" to
> "artl...@example.org" (and any other recipients of the same message
> envelope):
>
> # jq -r '
> first(select(.queue_name == "hold" and
> (.queue_id | test("^[0-9A-F]+$")) and
>
Wietse:
> You can un-quarantine (release from the 'hold' queue) a message
> with the "postsuper -H" command.
> See https://www.postfix.org/postsuper.1.html
ran...@skurelabs.com:
> We were able to quarantine the message by using appropriate
> QUARANTINE event in milter. But after we call
ran...@skurelabs.com:
> Thanks for information. I am already using a java version of milter which
> listens to 10099 port for milter support
> Main.cf file:
>
> # JMilter (info_milter)
>
> info_milter = inet:127.0.0.1:10099
>
> milter_protocol = 6
>
> How can I resend the email again, if User
ran...@skurelabs.com:
> Hello Folks,
> Is it possible to quarantine an email using before
> queue milter(http://www.postfix.org/MILTER_README.html).
> I would appreciate your help.
Yes. Look for a libmilter library funtion called smfi_quarantine()
or something similar. The exact name depends on
Ray, Leland:
> Greetings,
>
> I have a configuration need that I haven't seen asked about before.
>
> I would like the postfix smtp client to save email if it receives
> certain return codes, such as 5.7.1. This would be in addition to
> generating a dsn. More specifically, postfix is relaying
ran...@skurelabs.com:
> Hi There,
> We have configured milter to process emails before delivery. The
> milter is written in java that fetched the complete email and
> processes it. We also configured a relay smtp server. But how can
> we block the email till the processing is done and relay to
Yasuhiro Kimura:
> Hello,
>
> Currently Postfix doesn't support version 18.x of Berkeley DB.
> Following patch adds support of it.
Thank you. This will be included with Postfix 3.7.0.
Wietse
> --- src/util/dict_db.c.orig 2018-11-07 07:25:54.0 +0900
> +++ src/util/dict_db.c
J. Thomsen:
> After upgrading from Fedora 34 to Fedora 35 I cannot compile Postfix (3.6.x)
> due to this
>
> [src/util]
> gcc -I. -I../../include -DHAS_DEV_URANDOM -DHAS_PCRE -UUSE_DYNAMIC_LIBS
> -DDEF_SHLIB_DIR=\"no\"
> -UUSE_DYNAMIC_MAPS -Wmissing-prototypes -Wformat -Wno-comment -fno-common
Wietse Venema:
> Viktor Dukhovni:
> > On Fri, Oct 29, 2021 at 09:00:20AM +0200, Beno?t Panizzon wrote:
> >
> > > It turned out, one file in the 'active' queue, was causing qmgr to
> > > crash:
> > >
> > > postfix/qmgr[86256]: fatal: unix-do
Viktor Dukhovni:
> On Fri, Oct 29, 2021 at 09:00:20AM +0200, Beno?t Panizzon wrote:
>
> > It turned out, one file in the 'active' queue, was causing qmgr to
> > crash:
> >
> > postfix/qmgr[86256]: fatal: unix-domain name too long:
> >
Viktor Dukhovni:
> On Mon, Oct 11, 2021 at 08:10:05AM +, Kai KRETSCHMANN wrote:
>
> > The monitoring rspamd now has no chance to see in the latest Received
> > header in the connection was received TLS encrpyted or plain text.
>
> If the goal is to leave a forensic trace, then it may be
f an SMTP session, or that logs properties of an SMTP session.
What missing TLS_SESS_STATE fields would break existing code? It
is not every field, but I don't have time to look into that now.
Wietse
> 11. Oktober 2021 14:10, "Wietse Venema" schrieb:
>
> > Kai KR
Kai KRETSCHMANN:
> Hi postfix experts,
>
> I think I (and others) might need an enhancement to the parameters the
> XCLIENT command currently
> accepts.
>
> The usecase is like this:
>
> I'm running a MailU installation which receives SMTP 25/tcp connections via a
> TLS terminating nginx
Jason Pyeron:
> > -Original Message-
> > From: Wietse Venema
> > Sent: Wednesday, September 29, 2021 6:51 AM
> >
> > Jason Pyeron:
> > > Is there a readme or other documentation on running the tests?
> >
> > Nope. Tests have no formal s
Jason Pyeron:
> Is there a readme or other documentation on running the tests?
Nope. Tests have no formal structure. I'm thinking of making the
tests more systematical when I have time, maybe later next year.
> It appears the tests assume postfix is installed prior
It is a long time since I did
Jason Pyeron:
> > -Original Message-
> > From: Wietse Venema
> > Sent: Tuesday, September 28, 2021 7:45 PM
> >
> > Howard Chu:
> > > Jason Pyeron wrote:
> > > > I am trying to understand why group and other permissions are set to 6
Howard Chu:
> Jason Pyeron wrote:
> > I am trying to understand why group and other permissions are set to 6.
>
> On some platforms the permission bits on sockets are completely
> ignored. The only way to control access is thru the permissions
> of the containing directory.
Postfix has to work
David Bohman:
> This is apparently a new routine in version 3.6.
>
> I upgraded from version 3.5.9 directly to 3.6.1 and ran into an issue.
> Postfix failed to start up without any diagnostic output. It took me a bit
> to narrow down the failure, but I discovered that this routine was failing
>
Excellent suggestion, but it came days before a stable release.
Wietse
>
>
> Peter
>
>
> On 26/04/21 1:49 pm, Peter wrote:
> > On 26/04/21 3:10 am, Wietse Venema wrote:
> >> Just in time for Postfix 3.6.0 :-)
> >>
> >> I have a sugges
Peter:
> +# In addition to the following you should also uncomment the
> corresponding mua_*
> +# lines in main.cf as well.
Just in time for Postfix 3.6.0 :-)
I have a suggestion to simplify this.
Assuming that most people will not need complex submission or smtps
configurations, we could
Viktor Dukhovni:
> On Tue, Apr 20, 2021 at 09:20:40AM -0400, Wietse Venema wrote:
>
> > Paul Menzel:
> > > Would you accept a patch to add fix the instructions in `DB_README`?
> >
> > I think your problem is that /etc/ld.so.conf needs updating when you
> &g
Paul Menzel:
> Would you accept a patch to add fix the instructions in `DB_README`?
I think your problem is that /etc/ld.so.conf needs updating when you
install libdb in a nonstandard place.
I will consider an update if
- it does not break static builds (the current DB_README instructions)
- it
Paul Menzel:
> Dear Wietse,
>
>
> Thank you very much for the quick reply.
>
>
> Am 19.04.21 um 19:48 schrieb Wietse Venema:
> > Paul Menzel:
>
> >> Building Berkeley DB from source, and building Postfix according to
> >> *Postfix Berkeley D
Paul Menzel:
> Dear Post
>
>
> Building Berkeley DB from source, and building Postfix according to
> *Postfix Berkeley DB Howto* [1] with
>
> make makefiles CCARGS="-DHAS_DB
> -I/scratch/local2/berkeley-db/include"
> AUXLIBS="-L/scratch/local2/berkeley-db/lib -ldb"
This expects
wrote:
> >
> > ?Thanks very much, I will have a look.
> >
> > I can look at the TODOs. I am more familiar with how it works now, but
> > need to understand the memcache code as well.
> >
> > Duncan
> >
> >> On 13 Mar 2021, at 22:34, W
Wietse Venema:
> Dunk:
> > Thanks, I have tested in on a low volume email server.
>
> Wietse Venema:
> > The code is pretty clean, so I expect no surprises. I noticed that
>
> I have cleaned up the docs and code a little, and discovered that
> the query interf
Dunk:
> Thanks, I have tested in on a low volume email server.
Wietse Venema:
> The code is pretty clean, so I expect no surprises. I noticed that
I have cleaned up the docs and code a little, and discovered that
the query interface does not support the query formatting and domain
ma
o I anticipate no 'little Bobby tables' problems
as described in https://xkcd.com/327/.
If you need to handle large query volume, try using
proxy:redis:/path/to/file.
Wietse
>
> > On 11 Mar 2021, at 22:32, Wietse Venema wrote:
> >
> > ?Dunk:
> >> Hi,
> >
Dunk:
> Hi,
> Okay, attached is output from test.sh that calls valgrind twice.
>
> Duncan
Thanks, this looks good.
Wietse
>
> > On 11 Mar 2021, at 20:29, Wietse Venema wrote:
> >
> > ?Dunk:
> >> ?Hi,
> >> I tried
> >>
Dunk:
> ?Hi,
> I tried
>
> sh postfix-env.sh valgrind --tool=memcheck src/global/mail_dict
> redis:$(pwd)/redis.cf read<<'EOF'
>
> With redis.cf
>
> host = 127.0.0.1
> port = 6379
> prefix = TEST:
>
> With ?get foo?, or any command like postmap I get segmentation fault (see
> attached
l valgrind output before I look at the code.
Wietse
>
> > On 27 Feb 2021, at 23:20, Wietse Venema wrote:
> >
> > ?Duncan Bellamy:
> >> Hi,
> >>
> >> This patch is based on the original code by Titus Jose on GitHub, I
> >> upda
Duncan Bellamy:
> Hi,
>
> This patch is based on the original code by Titus Jose on GitHub, I
> updated it to work with the development branch and have added some
> documentation.
Thanks. I have a few suggestions regarding memory leaks, data
owbership, and testing.
115 static const char
David Florness:
-- Start of PGP signed section.
> This manual section was renamed to "TABLE SEARCH ORDER" in
> postfix-2.2-20050207 (3414d539).
> ---
> postfix/html/transport.5.html | 2 +-
> postfix/man/man5/transport.5 | 2 +-
> postfix/proto/transport | 2 +-
> 3 files changed, 3
Regarding that loop termination condition, you wrote up a long
explanation, which means this code will need to be simplified or
else there will be mistakes (if not now, then in the future). Postfix
is about not writing clever code.
I took a little time to fix the delivered_hdr.c code, so now I
I am not opposed to making bounces thread-friendly, but I wonder,
Postfix includes a copy of the undelivered message, why is it
difficult to find out what message was not delivered? Are mail
systems routinely deleting that information, because spam?
The code is not bad for a rusty C programmer.
Viktor Dukhovni:
> On Fri, Aug 21, 2020 at 03:11:50PM -0400, Wietse Venema wrote:
>
> > Viktor Dukhovni:
> > > On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote:
> > >
> > > > > Viktor Dukhovni:
> > > >
thorsten.hab...@findichgut.net:
> Any chance to backport the patch to 3.4/3.5?
This is more change than is allowed in a stable release. Postfix
3.6 drops support for OpenSSL < 1.1.1, deletes o(thousand) lines
of DANE support from the Postfix TLS library, and replaces it with
o(hundred) lines to
Viktor Dukhovni:
> On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote:
>
> > > Viktor Dukhovni:
> > > > - &_DANE_BASED(state->client_start_props->tls_level))
> > > > + && TLS_DANE_HASTA(state->client_star
I have more questions.
Wietse Venema:
> Viktor Dukhovni:
> > state->client_start_props->fd = state->ciphertext_fd;
> > /* These predicates and warning belong inside tls_client_start(). */
> > if (!tls_dane_avail() /* mandatory side eff
Viktor Dukhovni:
> On Thu, Aug 20, 2020 at 01:20:00PM -0400, Wietse Venema wrote:
>
> > Viktor Dukhovni:
> >
> > > - &_DANE_BASED(state->client_start_props->tls_level))
> > > + && TLS_DANE_HASTA(state->client_start_props->dane))
> &
Viktor Dukhovni:
> state->client_start_props->fd = state->ciphertext_fd;
> /* These predicates and warning belong inside tls_client_start(). */
> if (!tls_dane_avail()/* mandatory side effects!! */
> - &_DANE_BASED(state->client_start_props->tls_level))
> +
Thorsten Habich:
> If I remember correctly the certificate verification with connection
> reuse (so the tlsproxy gets involved) was fixed with:
>
> 20200620
>
> ??? Bugfix (introduced: Postfix 3.4): SMTP over TLS connection
> ??? reuse was broken for configurations that use explicit trust
> ???
1 - 100 of 240 matches
Mail list logo
