[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163056742 --- Diff: src/java/org/apache/cassandra/db/LegacySystemKeyspaceMigrator.java --- @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163059371 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -91,47 +92,52 @@ private SystemKeyspace() public static final String

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163062356 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -607,39 +672,65 @@ public static long getTruncatedAt(TableId id

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163063411 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -607,39 +672,65 @@ public static long getTruncatedAt(TableId id

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163069286 --- Diff: src/java/org/apache/cassandra/locator/InetAddressAndPort.java --- @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163073904 --- Diff: src/java/org/apache/cassandra/hadoop/ConfigHelper.java --- @@ -349,6 +350,16 @@ public static String getOutputInitialAddress(Configuration

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163074165 --- Diff: src/java/org/apache/cassandra/locator/InetAddressAndPort.java --- @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163081197 --- Diff: src/java/org/apache/cassandra/locator/InetAddressAndPort.java --- @@ -0,0 +1,193 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163083984 --- Diff: src/java/org/apache/cassandra/db/commitlog/CommitLogDescriptor.java --- @@ -40,6 +40,7 @@ import

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163084763 --- Diff: src/java/org/apache/cassandra/net/CompactEndpointSerializationHelper.java --- @@ -21,28 +21,142 @@ import java.net.Inet4Address

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163084819 --- Diff: src/java/org/apache/cassandra/net/CompactEndpointSerializationHelper.java --- @@ -21,28 +21,142 @@ import java.net.Inet4Address

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163085031 --- Diff: src/java/org/apache/cassandra/net/ForwardToContainer.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163085375 --- Diff: src/java/org/apache/cassandra/net/MessageDeliveryTask.java --- @@ -96,19 +98,11 @@ private void handleFailure(Throwable t) if

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163086238 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -89,37 +88,39 @@ private MessageIn(InetAddress from, public static

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163086498 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -89,37 +88,39 @@ private MessageIn(InetAddress from, public static

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163086795 --- Diff: src/java/org/apache/cassandra/net/MessageIn.java --- @@ -89,37 +88,39 @@ private MessageIn(InetAddress from, public static

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163087311 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -133,11 +139,13 @@ public MessageOut(InetAddress from, MessagingService.Verb verb, T

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163092194 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -766,15 +766,16 @@ private void listen(InetAddress localEp

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163092630 --- Diff: src/java/org/apache/cassandra/repair/SystemDistributedKeyspace.java --- @@ -74,48 +74,50 @@ private SystemDistributedKeyspace

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163093996 --- Diff: src/java/org/apache/cassandra/tools/LoaderOptions.java --- @@ -122,8 +129,11 @@ EncryptionOptions clientEncOptions = new

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163094078 --- Diff: src/java/org/apache/cassandra/tools/nodetool/Ring.java --- @@ -51,72 +51,116 @@ @Override public void execute(NodeProbe

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163095381 --- Diff: src/java/org/apache/cassandra/transport/Server.java --- @@ -454,51 +455,32 @@ public static LatestEvent forTopologyChange

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163097955 --- Diff: test/unit/org/apache/cassandra/cql3/PreparedStatementsTest.java --- @@ -531,7 +530,7 @@ private void testPrepareWithLWT(ProtocolVersion

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-22 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163106555 --- Diff: src/java/org/apache/cassandra/streaming/StreamResultFuture.java --- @@ -135,11 +136,13 @@ public StreamCoordinator getCoordinator

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163301627 --- Diff: src/java/org/apache/cassandra/db/SystemKeyspace.java --- @@ -145,168 +152,218 @@ private SystemKeyspace() private static final

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163304964 --- Diff: src/java/org/apache/cassandra/gms/ApplicationState.java --- @@ -19,24 +19,25 @@ public enum ApplicationState { -STATUS

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163306691 --- Diff: src/java/org/apache/cassandra/gms/ApplicationState.java --- @@ -19,24 +19,25 @@ public enum ApplicationState { -STATUS

[GitHub] cassandra pull request #184: Cassandra 7544 rebased2

2018-01-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/184#discussion_r163306795 --- Diff: conf/cassandra.yaml --- @@ -960,6 +967,7 @@ server_encryption_options: # cipher_suites: [TLS_RSA_WITH_AES_128_CBC_SHA

[GitHub] cassandra-dtest pull request #15: Cassandra 7544

2018-01-23 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra-dtest/pull/15#discussion_r163307891 --- Diff: replace_address_test.py --- @@ -35,7 +35,7 @@ class BaseReplaceAddressTest(Tester): def _setup(self, n=3, opts=None

[GitHub] cassandra pull request #188: Cassandra 7544 rebased3

2018-01-23 Thread aweisberg
GitHub user aweisberg opened a pull request: https://github.com/apache/cassandra/pull/188 Cassandra 7544 rebased3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/aweisberg/cassandra cassandra-7544-rebased3 Alternatively you can

[GitHub] cassandra issue #184: Cassandra 7544 rebased2

2018-01-23 Thread aweisberg
Github user aweisberg commented on the issue: https://github.com/apache/cassandra/pull/184 I can't close this, but we should close it in favor of https://github.com/apache/cassandra/pull/188 which is this rebased yet

[GitHub] cassandra-dtest pull request #17: Cassandra 14206 - fix loose version and so...

2018-02-02 Thread aweisberg
GitHub user aweisberg opened a pull request: https://github.com/apache/cassandra-dtest/pull/17 Cassandra 14206 - fix loose version and some of the remaining broken dtests You can merge this pull request into a Git repository by running: $ git pull https://github.com/aweisberg

[GitHub] cassandra pull request #:

2018-02-05 Thread aweisberg
Github user aweisberg commented on the pull request: https://github.com/apache/cassandra/commit/59b5b6bef0fa76bf5740b688fcd4d9cf525760d0#commitcomment-27361658 In src/java/org/apache/cassandra/service/StorageService.java: In src/java/org/apache/cassandra/service

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
GitHub user aweisberg opened a pull request: https://github.com/apache/cassandra/pull/191 13993 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jasobrown/cassandra 13993 Alternatively you can review and apply these changes as

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r167020713 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r167017641 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r167016420 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -254,6 +258,8 @@ public long getTimeout() return

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r167017281 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-08 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r167016249 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #:

2018-02-08 Thread aweisberg
Github user aweisberg commented on the pull request: https://github.com/apache/cassandra/commit/7df36056b12a13b60097b7a9a4f8155a1d02ff62#commitcomment-27432008 In src/java/org/apache/cassandra/cql3/statements/AlterTableStatement.java: In src/java/org/apache/cassandra/cql3

[GitHub] cassandra pull request #:

2018-02-08 Thread aweisberg
Github user aweisberg commented on the pull request: https://github.com/apache/cassandra/commit/0d26879a955a3045441a5016c73c750faab03c46#commitcomment-27435050 In src/java/org/apache/cassandra/repair/RepairRunnable.java: In src/java/org/apache/cassandra/repair/RepairRunnable.java

[GitHub] cassandra pull request #:

2018-02-08 Thread aweisberg
Github user aweisberg commented on the pull request: https://github.com/apache/cassandra/commit/3fc381d5cb603e81eb70c80788aee02af7ba6d31#commitcomment-27435094 In src/java/org/apache/cassandra/net/MessageIn.java: In src/java/org/apache/cassandra/net/MessageIn.java on line 183

[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...

2018-02-09 Thread aweisberg
GitHub user aweisberg opened a pull request: https://github.com/apache/cassandra/pull/193 Better document in code InetAddressAndPort usage post 7544 You can merge this pull request into a Git repository by running: $ git pull https://github.com/aweisberg/cassandra cassandra

[GitHub] cassandra pull request #193: Better document in code InetAddressAndPort usag...

2018-02-12 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/193#discussion_r167605713 --- Diff: src/java/org/apache/cassandra/config/Config.java --- @@ -128,6 +128,13 @@ public boolean listen_on_broadcast_address = false

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168302781 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168304560 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168305034 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168320211 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168320433 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra pull request #191: 13993

2018-02-14 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r168321619 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -1664,4 +1676,113 @@ public static boolean isEncryptedConnection

[GitHub] cassandra-dtest pull request #17: Cassandra 14206 - fix loose version and so...

2018-02-16 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra-dtest/pull/17 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h

[GitHub] cassandra pull request #191: 13993

2018-02-21 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r169697893 --- Diff: src/java/org/apache/cassandra/net/MessageOut.java --- @@ -96,6 +97,11 @@ //the second object is the POJO to serialize public

[GitHub] cassandra pull request #191: 13993

2018-02-21 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/191#discussion_r169707744 --- Diff: src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java --- @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache

[GitHub] cassandra pull request #191: 13993

2018-04-02 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/191 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #188: Cassandra 7544 rebased3

2018-04-02 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/188 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #169: Support a means of logging all queries as they ...

2018-04-02 Thread aweisberg
Github user aweisberg closed the pull request at: https://github.com/apache/cassandra/pull/169 --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187383489 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-10 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187383690 --- Diff: doc/source/architecture/dynamo.rst --- @@ -74,6 +74,26 @@ nodes in each rack, the data load on the smallest rack may be much higher. Simi

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187430210 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187429139 --- Diff: src/java/org/apache/cassandra/cql3/statements/AlterKeyspaceStatement.java --- @@ -96,7 +98,35 @@ private void warnIfIncreasingRF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187474479 --- Diff: src/java/org/apache/cassandra/db/ReadCommand.java --- @@ -128,6 +130,7 @@ protected ReadCommand(Kind kind, protected abstract

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187668202 --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java --- @@ -158,14 +159,15 @@ static boolean isTrivial(Range range

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187672097 --- Diff: src/java/org/apache/cassandra/dht/RangeFetchMapCalculator.java --- @@ -347,15 +349,16 @@ else if (vertex.isRangeVertex()) private

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187439941 --- Diff: src/java/org/apache/cassandra/db/ConsistencyLevel.java --- @@ -190,50 +197,50 @@ public int countLocalEndpoints(Iterable liveEndpoints

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187726766 --- Diff: src/java/org/apache/cassandra/locator/AbstractEndpointSnitch.java --- @@ -23,17 +23,17 @@ public abstract class

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187433683 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1591,7 +1589,7 @@ public long getExpectedCompactedFileSize(Iterable sstables

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188446854 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -503,12 +498,12 @@ private static void sendCommit(Commit commit, Iterable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187442385 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve() // at

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188444331 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187442479 --- Diff: src/java/org/apache/cassandra/service/reads/DataResolver.java --- @@ -64,12 +72,19 @@ public PartitionIterator resolve() // at

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187434990 --- Diff: src/java/org/apache/cassandra/db/ColumnFamilyStore.java --- @@ -1868,7 +1866,7 @@ public void compactionDiskSpaceCheck(boolean enable

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188107268 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187476379 --- Diff: src/java/org/apache/cassandra/db/compaction/Verifier.java --- @@ -209,7 +208,9 @@ public void verify() markAndThrow

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188107218 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187434827 --- Diff: src/java/org/apache/cassandra/batchlog/BatchlogManager.java --- @@ -490,16 +497,16 @@ private static int gcgs(Collection mutations

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188435314 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -856,25 +857,25 @@ private static PendingRangeMaps calculatePendingRanges

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188116936 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188447066 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -541,12 +536,12 @@ public void run() return callback

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188108224 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188102629 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188110522 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188361596 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187710293 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188686055 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3863,17 +3863,12 @@ public void forceTerminateAllRepairSessions

[GitHub] cassandra issue #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on the issue: https://github.com/apache/cassandra/pull/224 Also I haven't reviewed the test changes yet. --- - To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.or

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188443108 --- Diff: src/java/org/apache/cassandra/service/AbstractWriteResponseHandler.java --- @@ -225,7 +223,7 @@ protected boolean waitingFor

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188352903 --- Diff: src/java/org/apache/cassandra/locator/Replicas.java --- @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188685170 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -3863,17 +3863,12 @@ public void forceTerminateAllRepairSessions

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188440896 --- Diff: src/java/org/apache/cassandra/net/MessagingService.java --- @@ -591,8 +592,9 @@ public void run() if

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188117515 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188115552 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188103293 --- Diff: src/java/org/apache/cassandra/locator/Replica.java --- @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188452737 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1526,38 +1529,37 @@ protected Verb verb() * is unclear we want to

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188688173 --- Diff: src/java/org/apache/cassandra/service/StorageService.java --- @@ -4307,32 +4300,38 @@ private void calculateToFromStreams(Collection

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188452249 --- Diff: src/java/org/apache/cassandra/service/StorageProxy.java --- @@ -1364,68 +1363,72 @@ public static void sendToHintedEndpoints(final Mutation

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188436562 --- Diff: src/java/org/apache/cassandra/locator/TokenMetadata.java --- @@ -1204,21 +1205,21 @@ private String printPendingRanges() return

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188118159 --- Diff: src/java/org/apache/cassandra/locator/ReplicaList.java --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187476007 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -871,7 +868,7 @@ public void forceUserDefinedCleanup(String

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r188102161 --- Diff: src/java/org/apache/cassandra/locator/PendingRangeMaps.java --- @@ -23,196 +23,176 @@ import com.google.common.collect.Iterators

[GitHub] cassandra pull request #224: 14405 replicas

2018-05-16 Thread aweisberg
Github user aweisberg commented on a diff in the pull request: https://github.com/apache/cassandra/pull/224#discussion_r187475375 --- Diff: src/java/org/apache/cassandra/db/compaction/CompactionManager.java --- @@ -533,7 +530,7 @@ public AllSSTableOpStatus relocateSSTables(final

  1   2   3   4   >